Re: [DISCUSSION java-chassis]scan RestController to to make springmvc controller publish as ServiceComb Rest easier

[yhs0092]

This is a great idea! And I think we should explicitly tell users about the 
priority of @RequestMapping, @RestSchema, and @RestController, no matter on the 
release note or the gitbook. Since I've seen some users transform their 
SpringBoot/SpringCloud project into ServiceComb and leave all of these three 
annotations on their rest interface classes, it's necessary to declare this 
overwriting behavior.


Yours sincerely


Yao Haishi
yhs0...@163.com
On 10/27/2018 17:01，wjm wjm wrote：
ok

bismy  于2018年10月27日周六 下午3:14写道：

I am going to make it default to true. And add some release notes about
this change.
Our compatible rule is making things better by default, and users can
change to old feature when integration. Or we can not implement new
features due to users bad practices.




-- 原始邮件 --
发件人: "zzzwjm";
发送时间: 2018年10月27日(星期六) 中午11:05
收件人: "dev";

主题: Re: [DISCUSSION java-chassis]scan RestController to to make springmvc
controller publish as ServiceComb Rest easier



+1

but, what's default value of servicecomb.rest.service.scanRestController
if to be true, then can make spring mvc controller publish as ServiceComb
Rest easier, but maybe not compatible
but if to be false, then this feature is not so useful?

bismy  于2018年10月27日周六 上午10:57写道：

Hi all,


I am going to implement a feature that scan beans with @RestController
annotation, and taken it same as:
1. @RestSchema(schemaId = class.getName())
2. @RequestMapping("/")


Consider some users want to make use of both spring mvc controller and
ServiceComb REST, we add a configuration
servicecomb.rest.service.scanRestController
to turn off this feature.


Any suggestions?

Re: [DISCUSSION java-chassis]scan RestController to to make springmvc controller publish as ServiceComb Rest easier

[wjm wjm]

ok

bismy  于2018年10月27日周六 下午3:14写道：

> I am going to make it default to true. And add some release notes about
> this change.
> Our compatible rule is making things better by default, and users can
> change to old feature when integration. Or we can not implement new
> features due to users bad practices.
>
>
>
>
> -- 原始邮件 --
> 发件人: "zzzwjm";
> 发送时间: 2018年10月27日(星期六) 中午11:05
> 收件人: "dev";
>
> 主题: Re: [DISCUSSION java-chassis]scan RestController to to make springmvc
> controller publish as ServiceComb Rest easier
>
>
>
> +1
>
> but, what's default value of servicecomb.rest.service.scanRestController
> if to be true, then can make spring mvc controller publish as ServiceComb
> Rest easier, but maybe not compatible
> but if to be false, then this feature is not so useful?
>
> bismy  于2018年10月27日周六 上午10:57写道：
>
> > Hi all,
> >
> >
> > I am going to implement a feature that scan beans with @RestController
> > annotation, and taken it same as:
> >   1. @RestSchema(schemaId = class.getName())
> >   2. @RequestMapping("/")
> >
> >
> > Consider some users want to make use of both spring mvc controller and
> > ServiceComb REST, we add a configuration
> >servicecomb.rest.service.scanRestController
> > to turn off this feature.
> >
> >
> > Any suggestions?

?????? [DISCUSSION java-chassis]scan RestController to to make springmvc controller publish as ServiceComb Rest easier

[bismy]

I am going to make it default to true. And add some release notes about this 
change.
Our compatible rule is making things better by default, and users can change to 
old feature when integration. Or we can not implement new features due to users 
bad practices. 




--  --
??: "zzzwjm";
: 2018??10??27??(??) 11:05
??: "dev";

????: Re: [DISCUSSION java-chassis]scan RestController to to make springmvc 
controller publish as ServiceComb Rest easier



+1

but, what's default value of servicecomb.rest.service.scanRestController
if to be true, then can make spring mvc controller publish as ServiceComb
Rest easier, but maybe not compatible
but if to be false, then this feature is not so useful?

bismy  ??2018??10??27?? 10:57??

> Hi all,
>
>
> I am going to implement a feature that scan beans with @RestController
> annotation, and taken it same as:
>   1. @RestSchema(schemaId = class.getName())
>   2. @RequestMapping("/")
>
>
> Consider some users want to make use of both spring mvc controller and
> ServiceComb REST, we add a configuration
>servicecomb.rest.service.scanRestController
> to turn off this feature.
>
>
> Any suggestions?