Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 -- Original -- From: Mohammad Asif Siddiqui Date: Mon,Mar 19,2018 0:16 PM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt +1 Binding I Checked - incubating in name - hashes and signatures is good - DISCLAIMER exists - can compile from source - checked for archive matching git tag - Source file have ASF headers - ran Integration test using release binary on windows and linux - ran java-chassis demo(springmvc) using service-center release binary. Regards Asif On 2018/03/16 18:38:32, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (fourth release candidate). > > Release Notes : > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 non binding 2018-03-19 15:09 GMT+08:00 Bin Ma : > +1 non binding > > Ran the service-center release binary successfully > > 2018-03-19 13:05 GMT+08:00 Mahesh Raju Somalaraju < > maheshraju.o...@gmail.com > >: > > > +1 Non Binding > > > > - Ran java-chassis demos using service-center release binary. > > - Run the rat to verify the License header issue. > > > > Thanks & Regards > > -Mahesh Raju S > > > > On Sat, Mar 17, 2018 at 12:08 AM, Mohammad Asif Siddiqui < > > asifdxtr...@apache.org> wrote: > > > > > Hi All, > > > > > > This is a call for Vote to release Apache ServiceComb Service-Center > > > (Incubating) version 1.0.0-m1 (fourth release candidate). > > > > > > Release Notes : https://github.com/apache/ > incubator-servicecomb-service- > > > center/blob/master/docs/release/releaseNotes.md > > > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > > > center/releases/tag/1.0.0-m1 > > > > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > > dist/dev/incubator/servicecomb/KEYS > > > > > > Guide to build the release from source : https://github.com/apache/ > > > incubator-servicecomb-service-center/tree/master/scripts/release > > > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain > open > > > for next 72 hours, Request all PPMC members to give their vote. > > > [ ] +1 Release this package as 1.0.0-m1 > > > [ ] +0 No Opinion > > > [ ] -1 Do not release this package because > > > > > > Regards > > > Asif > > > > > > > > > > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 non binding Ran the service-center release binary successfully 2018-03-19 13:05 GMT+08:00 Mahesh Raju Somalaraju : > +1 Non Binding > > - Ran java-chassis demos using service-center release binary. > - Run the rat to verify the License header issue. > > Thanks & Regards > -Mahesh Raju S > > On Sat, Mar 17, 2018 at 12:08 AM, Mohammad Asif Siddiqui < > asifdxtr...@apache.org> wrote: > > > Hi All, > > > > This is a call for Vote to release Apache ServiceComb Service-Center > > (Incubating) version 1.0.0-m1 (fourth release candidate). > > > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > > center/blob/master/docs/release/releaseNotes.md > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > > center/releases/tag/1.0.0-m1 > > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > dist/dev/incubator/servicecomb/KEYS > > > > Guide to build the release from source : https://github.com/apache/ > > incubator-servicecomb-service-center/tree/master/scripts/release > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > > for next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1 > > [ ] +0 No Opinion > > [ ] -1 Do not release this package because > > > > Regards > > Asif > > > > > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 Non Binding - Ran java-chassis demos using service-center release binary. - Run the rat to verify the License header issue. Thanks & Regards -Mahesh Raju S On Sat, Mar 17, 2018 at 12:08 AM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (fourth release candidate). > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > center/blob/master/docs/release/releaseNotes.md > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > center/releases/tag/1.0.0-m1 > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > dist/dev/incubator/servicecomb/KEYS > > Guide to build the release from source : https://github.com/apache/ > incubator-servicecomb-service-center/tree/master/scripts/release > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 run java-chassis integration tests against this candidate and all test cases passed. -- Original -- From: "Mohammad Asif Siddiqui"; Date: Sat, Mar 17, 2018 02:38 AM To: "dev"; Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt Hi All, This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (fourth release candidate). Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag : https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Voting will start now ( Saturday, 17th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No Opinion [ ] -1 Do not release this package because Regards Asif
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 Binding I Checked - incubating in name - hashes and signatures is good - DISCLAIMER exists - can compile from source - checked for archive matching git tag - Source file have ASF headers - ran Integration test using release binary on windows and linux - ran java-chassis demo(springmvc) using service-center release binary. Regards Asif On 2018/03/16 18:38:32, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (fourth release candidate). > > Release Notes : > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 Checked the signed keys and checksum. 2018-03-19 9:28 GMT+08:00 Willem Jiang : > +1 (binding) > > Checked the signed Keys and checksum. > Checked the binary with the examples. > Run the rat to verify the License header issue. > > > Willem Jiang > > Blog: http://willemjiang.blogspot.com (English) > http://jnn.iteye.com (Chinese) > Twitter: willemjiang > Weibo: 姜宁willem > > On Sat, Mar 17, 2018 at 2:38 AM, Mohammad Asif Siddiqui < > asifdxtr...@apache.org> wrote: > > > Hi All, > > > > This is a call for Vote to release Apache ServiceComb Service-Center > > (Incubating) version 1.0.0-m1 (fourth release candidate). > > > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > > center/blob/master/docs/release/releaseNotes.md > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > > center/releases/tag/1.0.0-m1 > > > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > dist/dev/incubator/servicecomb/KEYS > > > > Guide to build the release from source : https://github.com/apache/ > > incubator-servicecomb-service-center/tree/master/scripts/release > > > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > > for next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1 > > [ ] +0 No Opinion > > [ ] -1 Do not release this package because > > > > Regards > > Asif > > > > > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 (binding) Checked the signed Keys and checksum. Checked the binary with the examples. Run the rat to verify the License header issue. Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Sat, Mar 17, 2018 at 2:38 AM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (fourth release candidate). > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > center/blob/master/docs/release/releaseNotes.md > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > center/releases/tag/1.0.0-m1 > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > dist/dev/incubator/servicecomb/KEYS > > Guide to build the release from source : https://github.com/apache/ > incubator-servicecomb-service-center/tree/master/scripts/release > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Fourth Attempt
+1 1. Checked the binary and source releases' sha512sum and gpg signature. 2. Checked LICENSE/DISCLAIMER/NOTICE of binary and source release. 3. Run rat on binary and source release, some minor issues found. 4. Building from source following the README 5. Running service center and frontend according to README 6. Run service-center and frontend on windows, checked basic functionality of frontend. 7. Run service-center and frontend on linux, run BMI sample of Java Chassis using service-center, checked basic functionality of frontend. 8. Checked both binary and source files, no inappropriate binary files bundled(images, fonts). On Sat, Mar 17, 2018 at 2:38 AM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (fourth release candidate). > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > center/blob/master/docs/release/releaseNotes.md > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > center/releases/tag/1.0.0-m1 > > Release CommitID : 94cea25ba55e763dbe23d0cd4a8da73e37a50539 > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > dist/dev/incubator/servicecomb/KEYS > > Guide to build the release from source : https://github.com/apache/ > incubator-servicecomb-service-center/tree/master/scripts/release > > Voting will start now ( Saturday, 17th March, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1 > [ ] +0 No Opinion > [ ] -1 Do not release this package because > > Regards > Asif > > > -- Best Regards, Yang.
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt
Hi All, I am cancelling this vote as the release binary name needs to be changed, we will re-initiate the seperate vote thread for new release candidate. Thanks all for your support. Reagrds Asif On 2018/03/08 12:02:24, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (third release candidate). > > Release Notes : > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > > > Release CommitID : b30cdce694ad0752cf6dda4c52f7fef7907d14c3 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Release Source : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ > > > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now ( Thursday, 8th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1. > [ ] +0 No Opinion. > [ ] -1 Do not release this package because > > Regards > Asif > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt
-1 The release name should contain apache-incubating name, currently its apache incubator. On 2018/03/08 12:02:24, Mohammad Asif Siddiqui wrote: > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (third release candidate). > > Release Notes : > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > > > Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > Release Tag : > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > > > Release CommitID : b30cdce694ad0752cf6dda4c52f7fef7907d14c3 > > Keys to verify the Release Candidate : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Release Source : > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ > > > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now ( Thursday, 8th March, 2018) and will remain open for > next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1. > [ ] +0 No Opinion. > [ ] -1 Do not release this package because > > Regards > Asif > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt
+1 All testings are pass! -- Original -- From: Mohammad Asif Siddiqui Date: Thu,Mar 8,2018 8:02 PM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 - Third Attempt
Re: ��������������������������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
[1] https://github.com/apache/incubator-servicecomb-service-center/pull/300 On 2018/03/08 09:13:03, Mohammad Asif Siddiqui wrote: > Thanks All for your feedback, here is the PR [1] to fix the above mentioned > issues. > > We are cancelling this VOTE now, we will be re-intiate the VOTE mail with a > new release candidate. > > Regards > Asif > > > On 2018/03/08 07:49:01, Mohammad Asif Siddiqui > wrote: > > Thanks YangBo and Cuiyihua for the suggestion. > > > > We will move the frontend configurations to the app.conf and add the > > frontend starting guide in the main Readme, so from here on there will be > > only 1 Readme and 1 conf which can be used by both frontend and > > service-center. > > > > Coming back to configuration of SC api in frontend we will definitely move > > this to configuration to the app.conf and it can be dynamically replaced > > when frontend will start, this needs some time of testing in windows system > > as in linux it's quite easy but in some windows OS version it fails, so > > that was the reason we kept this conf in apiList.js. We will take this > > issues in m2 release. > > > > Regards > > Asif > > > > > > On 2018/03/08 07:38:32, "Sure" wrote: > > > Suggestion: merge these configures in SC app.conf, and move the frontend > > > readme into main readme. > > > > > > > > > > > > > > > -- ÃÂ¥ÃÂÃÂÃ¥çÃÂéÃÂîäûö > > > -- > > > ÃÂ¥ÃÂÃÂäûöäúú: "Yang Bo"; > > > ÃÂ¥ÃÂÃÂéÃÂÃÂæÃÂöéÃÂô: > > > 2018Ã¥ùô3æÃÂÃÂ8æÃÂÃÂ¥(æÃÂÃÂæÃÂÃÂÃÂ¥ÃÂÃÂ) > > > äøÃÂÃÂ¥ÃÂÃÂ3:36 > > > æÃÂöäûöäúú: "dev"; > > > > > > äøûéâÃÂ: Re: [VOTE] Release Apache ServiceComb > > > Service-Center (incubating)version 1.0.0-m1 > > > > > > > > > > > > Hi Asif, > > > > > > For the first issue, It's OK that we leave it as is in this release. But > > > in > > > the long run, it's still better to put the configurations together(the > > > frontend.conf file). > > > > > > > > > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui < > > > asifdxtr...@apache.org> wrote: > > > > > > > Hi YangBo, > > > > > > > > Thanks for your vote. > > > > > > > > We will fix the 2nd and 3rd Issue. > > > > > > > > For 1st Issue I would like to clear that the hardcode values are in js > > > > files which can be modifies easily afterwards in the release, which we > > > > have > > > > already mentioned in our Readme over here [1] > > > > > > > > [1] https://github.com/apache/incubator-servicecomb-service- > > > > center/tree/master/frontend#note > > > > > > > > Regards > > > > Asif > > > > > > > > > > > > On 2018/03/08 07:20:17, Yang Bo wrote: > > > > > -1 Binding Vote. > > > > > > > > > > Below Checks Done: > > > > > 1. Verified the md5sum, sha1sum and GPG signature for source and > > > > > binary > > > > > release packages. > > > > > 2. Verified the service-center linux release using Java Chassis BMI > > > > sample. > > > > > 3. Verified the frontend on both windows and linux. > > > > > 4. Checked the bundled files, no fonts and images without proper > > > > licensing > > > > > bundled. > > > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and > > > > > source release > > > > > 6. RAT on source release is OK > > > > > > > > > > Some issues: > > > > > 1. The service-center's address/port is hardcoded in frontend's js > > > > > file, > > > > > which cause the frontend to not functioning if service center is not > > > > > running on 127.0.0.1:30100. > > > > > Bug report: https://issues.apache.org/jira/browse/SCB-375 > > > > > > > > > > 2. The scripts in binary release does not contain the ASF header. > > > > > start-frontend.sh > > > > > start-service-center.sh > > > > >
Re: ��������� [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
Thanks All for your feedback, here is the PR [1] to fix the above mentioned issues. We are cancelling this VOTE now, we will be re-intiate the VOTE mail with a new release candidate. Regards Asif On 2018/03/08 07:49:01, Mohammad Asif Siddiqui wrote: > Thanks YangBo and Cuiyihua for the suggestion. > > We will move the frontend configurations to the app.conf and add the frontend > starting guide in the main Readme, so from here on there will be only 1 > Readme and 1 conf which can be used by both frontend and service-center. > > Coming back to configuration of SC api in frontend we will definitely move > this to configuration to the app.conf and it can be dynamically replaced when > frontend will start, this needs some time of testing in windows system as in > linux it's quite easy but in some windows OS version it fails, so that was > the reason we kept this conf in apiList.js. We will take this issues in m2 > release. > > Regards > Asif > > > On 2018/03/08 07:38:32, "Sure" wrote: > > Suggestion: merge these configures in SC app.conf, and move the frontend > > readme into main readme. > > > > > > > > > > -- Ã¥ÂÂå§Âé®件 -- > > Ã¥ÂÂ件人: "Yang Bo"; > > Ã¥ÂÂéÂÂæ¶é´: 2018å¹´3æÂÂ8æÂÂ¥(æÂÂæÂÂÃ¥ÂÂ) > > ä¸ÂÃ¥ÂÂ3:36 > > æ¶件人: "dev"; > > > > 主é¢Â: Re: [VOTE] Release Apache ServiceComb Service-Center > > (incubating)version 1.0.0-m1 > > > > > > > > Hi Asif, > > > > For the first issue, It's OK that we leave it as is in this release. But in > > the long run, it's still better to put the configurations together(the > > frontend.conf file). > > > > > > On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui < > > asifdxtr...@apache.org> wrote: > > > > > Hi YangBo, > > > > > > Thanks for your vote. > > > > > > We will fix the 2nd and 3rd Issue. > > > > > > For 1st Issue I would like to clear that the hardcode values are in js > > > files which can be modifies easily afterwards in the release, which we > > > have > > > already mentioned in our Readme over here [1] > > > > > > [1] https://github.com/apache/incubator-servicecomb-service- > > > center/tree/master/frontend#note > > > > > > Regards > > > Asif > > > > > > > > > On 2018/03/08 07:20:17, Yang Bo wrote: > > > > -1 Binding Vote. > > > > > > > > Below Checks Done: > > > > 1. Verified the md5sum, sha1sum and GPG signature for source and binary > > > > release packages. > > > > 2. Verified the service-center linux release using Java Chassis BMI > > > sample. > > > > 3. Verified the frontend on both windows and linux. > > > > 4. Checked the bundled files, no fonts and images without proper > > > licensing > > > > bundled. > > > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and > > > > source release > > > > 6. RAT on source release is OK > > > > > > > > Some issues: > > > > 1. The service-center's address/port is hardcoded in frontend's js file, > > > > which cause the frontend to not functioning if service center is not > > > > running on 127.0.0.1:30100. > > > > Bug report: https://issues.apache.org/jira/browse/SCB-375 > > > > > > > > 2. The scripts in binary release does not contain the ASF header. > > > > start-frontend.sh > > > > start-service-center.sh > > > > stop-frontend.sh > > > > stop-service-center.sh > > > > > > > > 3. Scripts on source release have ASF header but the script shebang is > > > not > > > > in the first line, which would cause problems if the script is not > > > > called > > > > directy by bash. We should still put the shell shebang on the first line > > > of > > > > scripts and followd by a blank line then the ASF header. > > > > For example: > > > > === > > > > #!/bin/bash > > > > > > > > # Licensed to the Apache ... > > > > > > > > > > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C wrote: > > > > > > > > > +1 Binding Vote. > > > > > >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+0 No Opinion. Below Checks Done, No problem found: 1.Release both windows and linux from source 2.Verified the windows release using Java Chassis BMI sample and Java Chassis SpringMvc Integration Test 3.Verified the linux release by see port is listen and can curl page content from frontend -- Original -- From: "Mohammad Asif Siddiqui"; Date: Thu, Mar 8, 2018 01:41 AM To: "dev"; Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 Hi All, This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (second release candidate). Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag : https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Release Source : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Voting will start now ( Wednesday, 7th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No Opinion. [ ] -1 Do not release this package because Regards Asif
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
Hi Asif, For the first issue, It's OK that we leave it as is in this release. But in the long run, it's still better to put the configurations together(the frontend.conf file). On Thu, Mar 8, 2018 at 3:31 PM, Mohammad Asif Siddiqui < asifdxtr...@apache.org> wrote: > Hi YangBo, > > Thanks for your vote. > > We will fix the 2nd and 3rd Issue. > > For 1st Issue I would like to clear that the hardcode values are in js > files which can be modifies easily afterwards in the release, which we have > already mentioned in our Readme over here [1] > > [1] https://github.com/apache/incubator-servicecomb-service- > center/tree/master/frontend#note > > Regards > Asif > > > On 2018/03/08 07:20:17, Yang Bo wrote: > > -1 Binding Vote. > > > > Below Checks Done: > > 1. Verified the md5sum, sha1sum and GPG signature for source and binary > > release packages. > > 2. Verified the service-center linux release using Java Chassis BMI > sample. > > 3. Verified the frontend on both windows and linux. > > 4. Checked the bundled files, no fonts and images without proper > licensing > > bundled. > > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and > > source release > > 6. RAT on source release is OK > > > > Some issues: > > 1. The service-center's address/port is hardcoded in frontend's js file, > > which cause the frontend to not functioning if service center is not > > running on 127.0.0.1:30100. > > Bug report: https://issues.apache.org/jira/browse/SCB-375 > > > > 2. The scripts in binary release does not contain the ASF header. > > start-frontend.sh > > start-service-center.sh > > stop-frontend.sh > > stop-service-center.sh > > > > 3. Scripts on source release have ASF header but the script shebang is > not > > in the first line, which would cause problems if the script is not called > > directy by bash. We should still put the shell shebang on the first line > of > > scripts and followd by a blank line then the ASF header. > > For example: > > === > > #!/bin/bash > > > > # Licensed to the Apache ... > > > > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C wrote: > > > > > +1 Binding Vote. > > > > > > Below Checks Done: > > > 1. Verify the file signature. > > > 2. Verified windows release for service center using java chassis demo. > > > 3. Ran the Service-Center and Frontend, verified basic functionality of > > > service center and frontend. > > > > > > Thanks, > > > Sukesh. > > > > > > -Original Message- > > > From: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org] > > > Sent: 07 March 2018 23:11 > > > To: dev@servicecomb.apache.org > > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) > > > version 1.0.0-m1 > > > > > > Hi All, > > > > > > This is a call for Vote to release Apache ServiceComb Service-Center > > > (Incubating) version 1.0.0-m1 (second release candidate). > > > > > > Release Notes : https://github.com/apache/ > incubator-servicecomb-service- > > > center/blob/master/docs/release/releaseNotes.md > > > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > > > center/releases/tag/1.0.0-m1 > > > > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f > > > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > > dist/dev/incubator/servicecomb/KEYS > > > > > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/ > > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ > > > > > > Guide to build the release from source : https://github.com/apache/ > > > incubator-servicecomb-service-center/tree/master/scripts/release > > > > > > Voting will start now ( Wednesday, 7th March, 2018) and will remain > open > > > for next 72 hours, Request all PPMC members to give their vote. > > > > > > [ ] +1 Release this package as 1.0.0-m1. > > > [ ] +0 No Opinion. > > > [ ] -1 Do not release this package because > > > > > > Regards > > > Asif > > > > > > > > > > > > > > > -- > > Best Regards, > > Yang. > > > -- Best Regards, Yang.
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
Hi YangBo, Thanks for your vote. We will fix the 2nd and 3rd Issue. For 1st Issue I would like to clear that the hardcode values are in js files which can be modifies easily afterwards in the release, which we have already mentioned in our Readme over here [1] [1] https://github.com/apache/incubator-servicecomb-service-center/tree/master/frontend#note Regards Asif On 2018/03/08 07:20:17, Yang Bo wrote: > -1 Binding Vote. > > Below Checks Done: > 1. Verified the md5sum, sha1sum and GPG signature for source and binary > release packages. > 2. Verified the service-center linux release using Java Chassis BMI sample. > 3. Verified the frontend on both windows and linux. > 4. Checked the bundled files, no fonts and images without proper licensing > bundled. > 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and > source release > 6. RAT on source release is OK > > Some issues: > 1. The service-center's address/port is hardcoded in frontend's js file, > which cause the frontend to not functioning if service center is not > running on 127.0.0.1:30100. > Bug report: https://issues.apache.org/jira/browse/SCB-375 > > 2. The scripts in binary release does not contain the ASF header. > start-frontend.sh > start-service-center.sh > stop-frontend.sh > stop-service-center.sh > > 3. Scripts on source release have ASF header but the script shebang is not > in the first line, which would cause problems if the script is not called > directy by bash. We should still put the shell shebang on the first line of > scripts and followd by a blank line then the ASF header. > For example: > === > #!/bin/bash > > # Licensed to the Apache ... > > > On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C wrote: > > > +1 Binding Vote. > > > > Below Checks Done: > > 1. Verify the file signature. > > 2. Verified windows release for service center using java chassis demo. > > 3. Ran the Service-Center and Frontend, verified basic functionality of > > service center and frontend. > > > > Thanks, > > Sukesh. > > > > -Original Message- > > From: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org] > > Sent: 07 March 2018 23:11 > > To: dev@servicecomb.apache.org > > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) > > version 1.0.0-m1 > > > > Hi All, > > > > This is a call for Vote to release Apache ServiceComb Service-Center > > (Incubating) version 1.0.0-m1 (second release candidate). > > > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > > center/blob/master/docs/release/releaseNotes.md > > > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > > center/releases/tag/1.0.0-m1 > > > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f > > > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > > dist/dev/incubator/servicecomb/KEYS > > > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/ > > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ > > > > Guide to build the release from source : https://github.com/apache/ > > incubator-servicecomb-service-center/tree/master/scripts/release > > > > Voting will start now ( Wednesday, 7th March, 2018) and will remain open > > for next 72 hours, Request all PPMC members to give their vote. > > > > [ ] +1 Release this package as 1.0.0-m1. > > [ ] +0 No Opinion. > > [ ] -1 Do not release this package because > > > > Regards > > Asif > > > > > > > > > -- > Best Regards, > Yang. >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
-1 Binding Vote. Below Checks Done: 1. Verified the md5sum, sha1sum and GPG signature for source and binary release packages. 2. Verified the service-center linux release using Java Chassis BMI sample. 3. Verified the frontend on both windows and linux. 4. Checked the bundled files, no fonts and images without proper licensing bundled. 5. Checked the LICENSE/NOTICE, README, DISCLAIMER for both binary and source release 6. RAT on source release is OK Some issues: 1. The service-center's address/port is hardcoded in frontend's js file, which cause the frontend to not functioning if service center is not running on 127.0.0.1:30100. Bug report: https://issues.apache.org/jira/browse/SCB-375 2. The scripts in binary release does not contain the ASF header. start-frontend.sh start-service-center.sh stop-frontend.sh stop-service-center.sh 3. Scripts on source release have ASF header but the script shebang is not in the first line, which would cause problems if the script is not called directy by bash. We should still put the shell shebang on the first line of scripts and followd by a blank line then the ASF header. For example: === #!/bin/bash # Licensed to the Apache ... On Thu, Mar 8, 2018 at 2:15 PM, Sukesh A C wrote: > +1 Binding Vote. > > Below Checks Done: > 1. Verify the file signature. > 2. Verified windows release for service center using java chassis demo. > 3. Ran the Service-Center and Frontend, verified basic functionality of > service center and frontend. > > Thanks, > Sukesh. > > -Original Message- > From: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org] > Sent: 07 March 2018 23:11 > To: dev@servicecomb.apache.org > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) > version 1.0.0-m1 > > Hi All, > > This is a call for Vote to release Apache ServiceComb Service-Center > (Incubating) version 1.0.0-m1 (second release candidate). > > Release Notes : https://github.com/apache/incubator-servicecomb-service- > center/blob/master/docs/release/releaseNotes.md > > Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag : https://github.com/apache/incubator-servicecomb-service- > center/releases/tag/1.0.0-m1 > > Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f > > Keys to verify the Release Candidate : https://dist.apache.org/repos/ > dist/dev/incubator/servicecomb/KEYS > > Release Source : https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ > > Guide to build the release from source : https://github.com/apache/ > incubator-servicecomb-service-center/tree/master/scripts/release > > Voting will start now ( Wednesday, 7th March, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1. > [ ] +0 No Opinion. > [ ] -1 Do not release this package because > > Regards > Asif > > > -- Best Regards, Yang.
RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Binding Vote. Below Checks Done: 1. Verify the file signature. 2. Verified windows release for service center using java chassis demo. 3. Ran the Service-Center and Frontend, verified basic functionality of service center and frontend. Thanks, Sukesh. -Original Message- From: Mohammad Asif Siddiqui [mailto:asifdxtr...@apache.org] Sent: 07 March 2018 23:11 To: dev@servicecomb.apache.org Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 Hi All, This is a call for Vote to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1 (second release candidate). Release Notes : https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag : https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitID : cb48d5b1a84bfae3b111a34955664e30cb4b9f3f Keys to verify the Release Candidate : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Release Source : https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/src/ Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Voting will start now ( Wednesday, 7th March, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No Opinion. [ ] -1 Do not release this package because Regards Asif
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 (binding) I checked the readme file, running the example and verify the file signature. They are all looks good. Willem On 2/26/18, Mohammad Asif Siddiqui wrote: > +1 Binding Vote. > > Checks Done: > 1. Verify the file signature using the key over here [1]. > 2. Build code from source for both linux and windows and test basic > functionality using the guide over here [2]. > 3. Ran the Service-Center Frontend and verified basic functionality of > frontend in chrome browser. > 4. Ran RAT tool using the guide over here [3], all files have proper > license. > 5. Both release contain Readme, Notice, license and disclaimer. > 6. Readme contains how to start the service-center and frontend. > > [1] https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > [2] > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > [3] > https://github.com/apache/incubator-servicecomb-service-center/tree/master/docs/release > > > Regards > Asif > > > -Original Message- > From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] > Sent: 24 February 2018 PM 05:53 > To: Dev > Cc: Vinay Murudi ; Krishna M Kumar > ; Sukesh A C > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) > version 1.0.0-m1 > > Hi All, > This is a call for vote(second attempt) to release Apache ServiceComb > Service-Center (Incubating) version 1.0.0-m1. > Release Notes: > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md > Release Candidate: > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag: > https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de > Keys to Verify the Release Candidate: > https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > Guide to build the release from source : > https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > Issues fixed for the review comments which we got from last voting > attempt: 1. Added license header in shell script.2. Updated the releases > with apache-incubator pre-fix.3. Updated the Readme with embeded_etcd > information.4. Updated frontend start and stop guide.5. Added RAT Report > https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md > > Voting will start now (Saturday, 24th Feburary, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not > release this package because > > > > With Regards Mohammad Asif Siddiqui > -- Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem
Re: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
+1 buiding and run integration tests passed -- Original -- From: Sukesh A C Date: Mon,Feb 26,2018 1:47 PM To: Mohammad Asif Siddiqui , dev@servicecomb.apache.org Cc: Vinay Murudi , Krishna M Kumar Subject: Re: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1 +1 Binding Vote. Below Checks Done: 1. Verify the file signature. 2. Verified release on windows for both service center and front end using java chassis demo. 3. Ran the Service-Center Frontend and verified basic functionality of frontend. Thanks, Sukesh. -Original Message- From: Mohammad Asif Siddiqui Sent: 26 February 2018 11:08 To: dev@servicecomb.apache.org Cc: Vinay Murudi ; Krishna M Kumar ; Sukesh A C Subject: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 +1 Binding Vote. Checks Done: 1. Verify the file signature using the key over here [1]. 2. Build code from source for both linux and windows and test basic functionality using the guide over here [2]. 3. Ran the Service-Center Frontend and verified basic functionality of frontend in chrome browser. 4. Ran RAT tool using the guide over here [3], all files have proper license. 5. Both release contain Readme, Notice, license and disclaimer. 6. Readme contains how to start the service-center and frontend. [1] https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS [2] https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release [3] https://github.com/apache/incubator-servicecomb-service-center/tree/master/docs/release Regards Asif -Original Message- From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] Sent: 24 February 2018 PM 05:53 To: Dev Cc: Vinay Murudi ; Krishna M Kumar ; Sukesh A C Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 Hi All, This is a call for vote(second attempt) to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1. Release Notes: https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Issues fixed for the review comments which we got from last voting attempt: 1. Added license header in shell script.2. Updated the releases with apache-incubator pre-fix.3. Updated the Readme with embeded_etcd information.4. Updated frontend start and stop guide.5. Added RAT Report https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md Voting will start now (Saturday, 24th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not release this package because With Regards Mohammad Asif Siddiqui
Re: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
+1 -- Original -- From: Sukesh A C Date: Mon,Feb 26,2018 1:46 PM To: Mohammad Asif Siddiqui , dev@servicecomb.apache.org Cc: Vinay Murudi , Krishna M Kumar Subject: Re: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1 +1 Binding Vote. Below Checks Done: 1. Verify the file signature. 2. Verified release on windows for both service center and front end using java chassis demo. 3. Ran the Service-Center Frontend and verified basic functionality of frontend. Thanks, Sukesh. -Original Message- From: Mohammad Asif Siddiqui Sent: 26 February 2018 11:08 To: dev@servicecomb.apache.org Cc: Vinay Murudi ; Krishna M Kumar ; Sukesh A C Subject: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 +1 Binding Vote. Checks Done: 1. Verify the file signature using the key over here [1]. 2. Build code from source for both linux and windows and test basic functionality using the guide over here [2]. 3. Ran the Service-Center Frontend and verified basic functionality of frontend in chrome browser. 4. Ran RAT tool using the guide over here [3], all files have proper license. 5. Both release contain Readme, Notice, license and disclaimer. 6. Readme contains how to start the service-center and frontend. [1] https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS [2] https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release [3] https://github.com/apache/incubator-servicecomb-service-center/tree/master/docs/release Regards Asif -Original Message- From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] Sent: 24 February 2018 PM 05:53 To: Dev Cc: Vinay Murudi ; Krishna M Kumar ; Sukesh A C Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 Hi All, This is a call for vote(second attempt) to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1. Release Notes: https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Issues fixed for the review comments which we got from last voting attempt: 1. Added license header in shell script.2. Updated the releases with apache-incubator pre-fix.3. Updated the Readme with embeded_etcd information.4. Updated frontend start and stop guide.5. Added RAT Report https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md Voting will start now (Saturday, 24th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not release this package because With Regards Mohammad Asif Siddiqui
RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Binding Vote. Below Checks Done: 1. Verify the file signature. 2. Verified release on windows for both service center and front end using java chassis demo. 3. Ran the Service-Center Frontend and verified basic functionality of frontend. Thanks, Sukesh. -Original Message- From: Mohammad Asif Siddiqui Sent: 26 February 2018 11:08 To: dev@servicecomb.apache.org Cc: Vinay Murudi ; Krishna M Kumar ; Sukesh A C Subject: RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 +1 Binding Vote. Checks Done: 1. Verify the file signature using the key over here [1]. 2. Build code from source for both linux and windows and test basic functionality using the guide over here [2]. 3. Ran the Service-Center Frontend and verified basic functionality of frontend in chrome browser. 4. Ran RAT tool using the guide over here [3], all files have proper license. 5. Both release contain Readme, Notice, license and disclaimer. 6. Readme contains how to start the service-center and frontend. [1] https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS [2] https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release [3] https://github.com/apache/incubator-servicecomb-service-center/tree/master/docs/release Regards Asif -Original Message- From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] Sent: 24 February 2018 PM 05:53 To: Dev Cc: Vinay Murudi ; Krishna M Kumar ; Sukesh A C Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 Hi All, This is a call for vote(second attempt) to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1. Release Notes: https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Issues fixed for the review comments which we got from last voting attempt: 1. Added license header in shell script.2. Updated the releases with apache-incubator pre-fix.3. Updated the Readme with embeded_etcd information.4. Updated frontend start and stop guide.5. Added RAT Report https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md Voting will start now (Saturday, 24th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not release this package because With Regards Mohammad Asif Siddiqui
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 (non-Binding Vote). Checks Done: 1. Verify the file signature using the key over here [1]. 2. Tested Linux release. 3. Ran sample JavaChassis examples and tested basic functionalities. Thanks & Regards -Mahesh Raju S On Mon, Feb 26, 2018 at 11:08 AM, Mohammad Asif Siddiqui < mohammad.asif.siddiq...@huawei.com> wrote: > +1 Binding Vote. > > Checks Done: > 1. Verify the file signature using the key over here [1]. > 2. Build code from source for both linux and windows and test basic > functionality using the guide over here [2]. > 3. Ran the Service-Center Frontend and verified basic functionality of > frontend in chrome browser. > 4. Ran RAT tool using the guide over here [3], all files have proper > license. > 5. Both release contain Readme, Notice, license and disclaimer. > 6. Readme contains how to start the service-center and frontend. > > [1] https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > [2] https://github.com/apache/incubator-servicecomb-service- > center/tree/master/scripts/release > [3] https://github.com/apache/incubator-servicecomb-service- > center/tree/master/docs/release > > Regards > Asif > > > -Original Message- > From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] > Sent: 24 February 2018 PM 05:53 > To: Dev > Cc: Vinay Murudi ; Krishna M Kumar < > krishna.m.ku...@huawei.com>; Sukesh A C > Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) > version 1.0.0-m1 > > Hi All, > This is a call for vote(second attempt) to release Apache ServiceComb > Service-Center (Incubating) version 1.0.0-m1. > Release Notes: https://github.com/apache/incubator-servicecomb-service- > center/blob/master/docs/release/releaseNotes.md > Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > Release Tag: https://github.com/apache/incubator-servicecomb-service- > center/releases/tag/1.0.0-m1 > Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de > Keys to Verify the Release Candidate: https://dist.apache.org/repos/ > dist/dev/incubator/servicecomb/KEYS > Guide to build the release from source : https://github.com/apache/ > incubator-servicecomb-service-center/tree/master/scripts/release > Issues fixed for the review comments which we got from last voting > attempt: 1. Added license header in shell script.2. Updated the releases > with apache-incubator pre-fix.3. Updated the Readme with embeded_etcd > information.4. Updated frontend start and stop guide.5. Added RAT Report > https://github.com/apache/incubator-servicecomb-service- > center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md > > Voting will start now (Saturday, 24th Feburary, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not > release this package because > > > > With Regards Mohammad Asif Siddiqui >
RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Binding Vote. Checks Done: 1. Verify the file signature using the key over here [1]. 2. Build code from source for both linux and windows and test basic functionality using the guide over here [2]. 3. Ran the Service-Center Frontend and verified basic functionality of frontend in chrome browser. 4. Ran RAT tool using the guide over here [3], all files have proper license. 5. Both release contain Readme, Notice, license and disclaimer. 6. Readme contains how to start the service-center and frontend. [1] https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS [2] https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release [3] https://github.com/apache/incubator-servicecomb-service-center/tree/master/docs/release Regards Asif -Original Message- From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] Sent: 24 February 2018 PM 05:53 To: Dev Cc: Vinay Murudi ; Krishna M Kumar ; Sukesh A C Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 Hi All, This is a call for vote(second attempt) to release Apache ServiceComb Service-Center (Incubating) version 1.0.0-m1. Release Notes: https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/releaseNotes.md Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitId: 8d40fc3b10e99c9084a7b62504226007660ad6de Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Guide to build the release from source : https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release Issues fixed for the review comments which we got from last voting attempt: 1. Added license header in shell script.2. Updated the releases with apache-incubator pre-fix.3. Updated the Readme with embeded_etcd information.4. Updated frontend start and stop guide.5. Added RAT Report https://github.com/apache/incubator-servicecomb-service-center/blob/master/docs/release/rat-report/Rat-Report-2018-02-23.md Voting will start now (Saturday, 24th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not release this package because With Regards Mohammad Asif Siddiqui
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
-1, Here are the issues that I found in this release candidate, I think we need to fix them before release. 1. The binary files and source file doesn't have the apache-incubator prefix. 2. I just used the rat tool[1] to check the License header issue and found there are some go files and script files have no license header. 3. ServiceCenter supports to run with the embedded etcd, but the README doesn't mention it. 4. There is no document for starting and stop the frontend-servicecomb-service-center. For the other parts, it looks good. The key sign is checked, the binary file and source file has the License and Notice file. License and Notice files includes the third party dependencies. Readme includes how to run the service center and build the binary from source code. [1]https://creadur.apache.org/rat/apache-rat/index.html Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Thu, Feb 22, 2018 at 9:46 AM, Sure wrote: > +1 > > > All tests are passed > > -- Original -- > From: preethi > Date: Tue,Feb 20,2018 2:14 PM > To: dev > Subject: Re: [VOTE] Release Apache ServiceComb Service-Center > (incubating)version 1.0.0-m1 > > > > +1 Verified build from source on both Linux and windows > > On 2018/02/19 10:07:00, Mohammad Asif Siddiqui wrote: > > Hi All,> > > This is a call for vote to release ServiceComb Service-Center > (Incubating) version 1.0.0-m1.> > > Release > Notes: https://github.com/asifdxtreme/incubator- > servicecomb-service-center/blob/master/docs/releaseNotes.md > > > > Release > Candidate: https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > > > Release > Tag: https://github.com/apache/incubator-servicecomb-service- > center/releases/tag/1.0.0-m1 > > > > Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8 > > > > > Keys to Verify the Release > Candidate: https://dist.apache.org/repos/dist/dev/incubator/ > servicecomb/KEYS > > > > > > Voting will start now (Monday, 19th Feburary, 2018) and will remain > open for next 72 hours, Request all PPMC members to give their vote.> > > > > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do > not release this package because> > > > > > > > > With Regards Mohammad Asif Siddiqui> >
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1
+1 All tests are passed -- Original -- From: preethi Date: Tue,Feb 20,2018 2:14 PM To: dev Subject: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1 +1 Verified build from source on both Linux and windows On 2018/02/19 10:07:00, Mohammad Asif Siddiqui wrote: > Hi All,> > This is a call for vote to release ServiceComb Service-Center (Incubating) version 1.0.0-m1.> > Release Notes: https://github.com/asifdxtreme/incubator-servicecomb-service-center/blob/master/docs/releaseNotes.md > > Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8 > > > Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > > Voting will start now (Monday, 19th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote.> > > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not release this package because> > > > > With Regards Mohammad Asif Siddiqui>
RE: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Verified build from source on Linux and tested basic usecases. -Original Message- From: Mohammad Asif Siddiqui [mailto:asifdxtr...@yahoo.com.INVALID] Sent: 19 February 2018 15:37 To: dev@servicecomb.apache.org Cc: Vinay Murudi ; Krishna M Kumar Subject: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1 Hi All, This is a call for vote to release ServiceComb Service-Center (Incubating) version 1.0.0-m1. Release Notes: https://github.com/asifdxtreme/incubator-servicecomb-service-center/blob/master/docs/releaseNotes.md Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8 Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS Voting will start now (Monday, 19th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote. [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not release this package because With Regards Mohammad Asif Siddiqui
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Verified build from source on both Linux and windows On 2018/02/19 10:07:00, Mohammad Asif Siddiqui wrote: > Hi All,> > This is a call for vote to release ServiceComb Service-Center (Incubating) version 1.0.0-m1.> > Release Notes: https://github.com/asifdxtreme/incubator-servicecomb-service-center/blob/master/docs/releaseNotes.md > > Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8 > > > Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > > Voting will start now (Monday, 19th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote.> > > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not release this package because> > > > > With Regards Mohammad Asif Siddiqui>
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Verified build from source on both Linux and windows https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release On Mon, Feb 19, 2018 at 3:37 PM, Mohammad Asif Siddiqui < asifdxtr...@yahoo.com.invalid> wrote: > Hi All, > This is a call for vote to release ServiceComb Service-Center > (Incubating) version 1.0.0-m1. > Release Notes: https://github.com/asifdxtreme/incubator- > servicecomb-service-center/blob/master/docs/releaseNotes.md > Release Candidate: https://dist.apache.org/repos/dist/dev/ > incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > Release Tag: https://github.com/apache/incubator-servicecomb- > service-center/releases/tag/1.0.0-m1 > Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8 > > Keys to Verify the Release Candidate: https://dist. > apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Voting will start now (Monday, 19th Feburary, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not > release this package because > > > > With Regards Mohammad Asif Siddiqui
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Verified build from source on both Linux and windows On 19-Feb-2018 15:37, "Mohammad Asif Siddiqui" wrote: > Hi All, > This is a call for vote to release ServiceComb Service-Center > (Incubating) version 1.0.0-m1. > Release Notes: https://github.com/asifdxtreme/incubator- > servicecomb-service-center/blob/master/docs/releaseNotes.md > Release Candidate: https://dist.apache.org/repos/dist/dev/ > incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > Release Tag: https://github.com/apache/incubator-servicecomb- > service-center/releases/tag/1.0.0-m1 > Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8 > > Keys to Verify the Release Candidate: https://dist. > apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > Voting will start now (Monday, 19th Feburary, 2018) and will remain open > for next 72 hours, Request all PPMC members to give their vote. > > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do not > release this package because > > > > With Regards Mohammad Asif Siddiqui
Re: [VOTE] Release Apache ServiceComb Service-Center (incubating) version 1.0.0-m1
+1 Tested build from source on linux/windows machine and tested user case to be OK On 2018/02/09 03:26:16, Mohammad Asif Siddiqui wrote: > Hi All,> > This is a call for vote to release ServiceComb Service-Center (Incubating) version 1.0.0-m1> > Release Notes: https://github.com/asifdxtreme/incubator-servicecomb-service-center/tree/master/docs/release-notes > > > Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/ > > Release Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1 > > Release CommitId: d34f6619d76667c038bd2e8f2ab5c00dc45c5cab > > > Keys to Verify the Release Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS > > For building the binary from the source you can refer to https://github.com/apache/incubator-servicecomb-service-center/tree/master/scripts/release > > > Voting will start now (Firday, 9th Feburary, 2018) and will remain open for next 72 hours, Request all PPMC members to give their vote.> > > [ ] +1 Release this package as 1.0.0-m1 [ ] +0 No opinion[ ] -1 Do not release this package because> > > > > With RegardsMohammad Asif Siddiqui> > >