Re: [PACK] Refactoring the Alpha module using Spring SPI
Hi Willem Jiang, I updated the document and pushed the PR[1]. Please review. [1] https://github.com/apache/servicecomb-pack/pull/749 Willem Jiang 于2022年4月3日周日 15:05写道: > Hi Lei, > > Do you mind creating a PR for it? > As we did some changes on the Alpha server and Omega client > configuration, we need to update the document for it. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Sun, Apr 3, 2022 at 1:26 AM Lei Zhang wrote: > > > > I have done the refactoring[1] and pushed it to the branch[2] > > > > All tests passed > > > > [1] https://issues.apache.org/jira/browse/SCB-2425 > > [2] https://github.com/apache/servicecomb-pack/tree/SCB-2425 > > > > > > > > Lei Zhang 于2022年3月22日周二 17:38写道: > > > > > Yes, refactoring needs a big amount of work. > > > I will refactor with minimal changes and keep the test cases. > > > After the first version is refactored and tested, I will push a new > branch > > > to the upstream repository. > > > > > > Feel free to contact me with any suggestions. > > > > > > Willem Jiang 于2022年3月22日周二 17:20写道: > > > > > >> Just a quick commons about it. > > >> It looks like the user can take control of which module he wants to > > >> use by specifying the alpha.spec.names. > > >> But those modules can have some conflicts, I think we need to double > > >> check the setting of these modules. > > >> > > >> > > >> > > >> Willem Jiang > > >> > > >> Twitter: willemjiang > > >> Weibo: 姜宁willem > > >> > > >> On Tue, Mar 22, 2022 at 3:54 PM Lei Zhang > wrote: > > >> > > > >> > Hi, pack > > >> > > > >> > I created a Jira issue > https://issues.apache.org/jira/browse/SCB-2425. > > >> > > > >> > Lei Zhang > > >> > > > >> > Best Regards > > >> > > > >
Re: [PACK] Refactoring the Alpha module using Spring SPI
Hi Lei, Do you mind creating a PR for it? As we did some changes on the Alpha server and Omega client configuration, we need to update the document for it. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Sun, Apr 3, 2022 at 1:26 AM Lei Zhang wrote: > > I have done the refactoring[1] and pushed it to the branch[2] > > All tests passed > > [1] https://issues.apache.org/jira/browse/SCB-2425 > [2] https://github.com/apache/servicecomb-pack/tree/SCB-2425 > > > > Lei Zhang 于2022年3月22日周二 17:38写道: > > > Yes, refactoring needs a big amount of work. > > I will refactor with minimal changes and keep the test cases. > > After the first version is refactored and tested, I will push a new branch > > to the upstream repository. > > > > Feel free to contact me with any suggestions. > > > > Willem Jiang 于2022年3月22日周二 17:20写道: > > > >> Just a quick commons about it. > >> It looks like the user can take control of which module he wants to > >> use by specifying the alpha.spec.names. > >> But those modules can have some conflicts, I think we need to double > >> check the setting of these modules. > >> > >> > >> > >> Willem Jiang > >> > >> Twitter: willemjiang > >> Weibo: 姜宁willem > >> > >> On Tue, Mar 22, 2022 at 3:54 PM Lei Zhang wrote: > >> > > >> > Hi, pack > >> > > >> > I created a Jira issue https://issues.apache.org/jira/browse/SCB-2425. > >> > > >> > Lei Zhang > >> > > >> > Best Regards > >> > >
Re: [PACK] Refactoring the Alpha module using Spring SPI
I have done the refactoring[1] and pushed it to the branch[2] All tests passed [1] https://issues.apache.org/jira/browse/SCB-2425 [2] https://github.com/apache/servicecomb-pack/tree/SCB-2425 Lei Zhang 于2022年3月22日周二 17:38写道: > Yes, refactoring needs a big amount of work. > I will refactor with minimal changes and keep the test cases. > After the first version is refactored and tested, I will push a new branch > to the upstream repository. > > Feel free to contact me with any suggestions. > > Willem Jiang 于2022年3月22日周二 17:20写道: > >> Just a quick commons about it. >> It looks like the user can take control of which module he wants to >> use by specifying the alpha.spec.names. >> But those modules can have some conflicts, I think we need to double >> check the setting of these modules. >> >> >> >> Willem Jiang >> >> Twitter: willemjiang >> Weibo: 姜宁willem >> >> On Tue, Mar 22, 2022 at 3:54 PM Lei Zhang wrote: >> > >> > Hi, pack >> > >> > I created a Jira issue https://issues.apache.org/jira/browse/SCB-2425. >> > >> > Lei Zhang >> > >> > Best Regards >> >
Re: [PACK] Refactoring the Alpha module using Spring SPI
Yes, refactoring needs a big amount of work. I will refactor with minimal changes and keep the test cases. After the first version is refactored and tested, I will push a new branch to the upstream repository. Feel free to contact me with any suggestions. Willem Jiang 于2022年3月22日周二 17:20写道: > Just a quick commons about it. > It looks like the user can take control of which module he wants to > use by specifying the alpha.spec.names. > But those modules can have some conflicts, I think we need to double > check the setting of these modules. > > > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, Mar 22, 2022 at 3:54 PM Lei Zhang wrote: > > > > Hi, pack > > > > I created a Jira issue https://issues.apache.org/jira/browse/SCB-2425. > > > > Lei Zhang > > > > Best Regards >
Re: [PACK] Refactoring the Alpha module using Spring SPI
Just a quick commons about it. It looks like the user can take control of which module he wants to use by specifying the alpha.spec.names. But those modules can have some conflicts, I think we need to double check the setting of these modules. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Mar 22, 2022 at 3:54 PM Lei Zhang wrote: > > Hi, pack > > I created a Jira issue https://issues.apache.org/jira/browse/SCB-2425. > > Lei Zhang > > Best Regards