AW: Review of Neo4j patch
If you can be more specific on what exactly is not well documented enough to be easy to set up, we will surely enhance the documentation in these areas. However, we have already improved it since the last conversation about this issue a few months ago. -Ursprüngliche Nachricht- Von: Ryan Baxter [mailto:rbaxte...@gmail.com] Gesendet: Freitag, 23. Mai 2014 16:17 An: dev@shindig.apache.org Betreff: Re: Review of Neo4j patch I echo Stanton's comments. The last time I tried to use the patch I was still having trouble figuring out how to get everything up and running. I can try to find some time to take a look again. Sorry to be so slow on this. On Wed, May 21, 2014 at 9:04 AM, Stanton Sievers ssiev...@apache.org wrote: Hi René, I'm sorry that this has been your experience. Please don't interpret the slow-moving process as a lack of appreciation for the work you've done. It is very much appreciated, I promise you. Given the state of the patch and the conversation on the review, I think we need to just get this committed so that work can continue in smaller, more manageable chunks. For my own part, I'll aim to play around with things over the upcoming long weekend here in the states. Thanks, -Stanton On Wed, May 21, 2014 at 8:28 AM, René Peinl rene.pe...@hof-university.dewrote: Dear Shindig Community, I’d like to bring our contribution regarding a proper database backend for Apache Shindig to your attention. As some of you might know, we already posted an initial patch over a year ago. It turned out, that it was not feasible to include this in Shindig due to licensing issues that we were not aware of before. https://issues.apache.org/jira/browse/SHINDIG-1911 A few months later we asked via the mailing list, whether you would be still interested in getting a patch which circumvents these issues and I received positive feedback from you. 4 months ago, we posted a new version of the patch which sorted out the licensing issues and had some other significant enhancements regarding multi-threading, multiple concurrent connections and things like that, that make it ready for larger installations with multiple db servers. https://reviews.apache.org/r/9773/ Initially, Ryan Baxter gave us some good hints regarding minor issues with documentation and installation. We’ve sorted them out, but during the last three months there were no visible efforts from the Shindig-side to really bring this patch into the main code. We are still committed to support and further enhance it, so if there are reasonable issues, please let us know. I’d like to communicate my frustration and disappointment about the procedure. I don’t know the reasons for the way this issue is handled and I’m sure you all have important things to do, but I can’t imagine how any open source project can work that simply ignores contributions worth several person months of work. Please give this patch a fair chance. Regards René Prof. Dr. René Peinl Teaching area: architecture of Web applications Hof University Alfons-Goppel-Platz 1 95028 Hof Germany Tel: +49 9281 409-4820 mailto: mailto:rene.pe...@hof-university.de rene.pe...@hof-university.de
Re: Review Request 9773: Alternative database backend based on graph database neo4j
On Jan. 24, 2014, 1:49 a.m., Ryan Baxter wrote: Good news I applied the patch and built the code and it produced a war :) What I don't know if how to setup the neo4j backend, I believe I need to clone the git repo right? Some simple instructions in the README would be good. René Peinl wrote: Dear Ryan, we thought we had documented everything, but realized that it may be more complicated than we thought. Therefore we attached a document that describes the setup of the driver in more detail and also includes some hints for developers how to use our code in their projects. Hope that helps René Ryan Baxter wrote: Rene, very comprehensive! Although I ran into a couple of problems. I cloned the neo4j-websocket-common project and tried to build it and the build failed. About 27 tests are not passing. Also I have a question about the shindig sample data. Do I need to run the war produced by the neo4j-websocket-server project and have my neo4j-websocket-sever.properties point to the shindig sample data you have on DropBox? I noticed there is a neo4j-websocket-server.properites in the Shindig project as well, does that just point to the neo4j-websocket-server? I did not see the same test issues that Ryan saw. All of the neo4j-websocket-* projects built just fine for me. I built on Win7 64-bit. Ryan, did you build on Mac OS X? Maybe there's a platform-specific issue there. - Stanton --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9773/#review32689 --- On April 8, 2014, 1:45 p.m., René Peinl wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9773/ --- (Updated April 8, 2014, 1:45 p.m.) Review request for shindig. Bugs: Shindig-1911 https://issues.apache.org/jira/browse/Shindig-1911 Repository: shindig Description --- Review for Shindig-1911 Alternative database backend based on graph database neo4j Any comments welcome. We are committed to further improve this. Diffs - /trunk/java/websocket-backend/LICENSE PRE-CREATION /trunk/java/websocket-backend/NOTICE PRE-CREATION /trunk/java/websocket-backend/README PRE-CREATION /trunk/java/websocket-backend/pom.xml PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION
Re: Review Request 9773: Alternative database backend based on graph database neo4j
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9773/#review43936 --- I verified that the patch applies cleanly, although IntelliJ had some path issues that needed manual correction. I built with the websocket-backend profile enabled and verified that a war file was produced, the contents of which looked correct. Ryan had some questions in an earlier comment about properties file and the sample data that I would like to see addressed. Other than that, I think this is in a state where we can commit it. It is sufficiently roped-off via the profile that the risk is low. - Stanton Sievers On April 8, 2014, 1:45 p.m., René Peinl wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9773/ --- (Updated April 8, 2014, 1:45 p.m.) Review request for shindig. Bugs: Shindig-1911 https://issues.apache.org/jira/browse/Shindig-1911 Repository: shindig Description --- Review for Shindig-1911 Alternative database backend based on graph database neo4j Any comments welcome. We are committed to further improve this. Diffs - /trunk/java/websocket-backend/LICENSE PRE-CREATION /trunk/java/websocket-backend/NOTICE PRE-CREATION /trunk/java/websocket-backend/README PRE-CREATION /trunk/java/websocket-backend/pom.xml PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java PRE-CREATION /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java PRE-CREATION
