Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-25 Thread Dan Dumont 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/#review9443
---


Adam, could you please close this review and JIRA?

- Dan Dumont


On July 18, 2012, 7:45 p.m., Adam Clarke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6035/
> ---
> 
> (Updated July 18, 2012, 7:45 p.m.)
> 
> 
> Review request for shindig, Ryan Baxter and Stanton Sievers.
> 
> 
> Description
> ---
> 
> Adds two new settings to oauth.json (or other persistence plugins) to handle 
> picky OAuth1.0a providers.
> 
> 1) New key_type "PLAINTEXT"
>"key_type" : "PLAINTEXT"
> Default remains "key_type" : "HMAC_SYMMETRIC"
> 
> 2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on 
> requests
>"bodyHash" : "false"
> Default is "true" to keep compatibility with existing configurations
> 
> 
> This addresses bug SHINDIG-1775.
> https://issues.apache.org/jira/browse/SHINDIG-1775
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
>  1363028 
> 
> Diff: https://reviews.apache.org/r/6035/diff/
> 
> 
> Testing
> ---
> 
> All JUnits pass.
> 
> 
> Thanks,
> 
> Adam Clarke
> 
>

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-24 Thread Ryan Baxter 


> On July 24, 2012, 7:24 p.m., Matt Franklin wrote:
> > Was this applied yet?
> 
> Stanton Sievers wrote:
> No, not yet.  Consider this last call.  If there are no other comments 
> I'll commit the patch in the next day.

I committed this so we can get it in beta3 which I want to work on tonight.
Committed revision 1365361


- Ryan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/#review9405
---


On July 18, 2012, 7:45 p.m., Adam Clarke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6035/
> ---
> 
> (Updated July 18, 2012, 7:45 p.m.)
> 
> 
> Review request for shindig, Ryan Baxter and Stanton Sievers.
> 
> 
> Description
> ---
> 
> Adds two new settings to oauth.json (or other persistence plugins) to handle 
> picky OAuth1.0a providers.
> 
> 1) New key_type "PLAINTEXT"
>"key_type" : "PLAINTEXT"
> Default remains "key_type" : "HMAC_SYMMETRIC"
> 
> 2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on 
> requests
>"bodyHash" : "false"
> Default is "true" to keep compatibility with existing configurations
> 
> 
> This addresses bug SHINDIG-1775.
> https://issues.apache.org/jira/browse/SHINDIG-1775
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
>  1363028 
> 
> Diff: https://reviews.apache.org/r/6035/diff/
> 
> 
> Testing
> ---
> 
> All JUnits pass.
> 
> 
> Thanks,
> 
> Adam Clarke
> 
>

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-24 Thread Stanton Sievers 


> On July 24, 2012, 7:24 p.m., Matt Franklin wrote:
> > Was this applied yet?

No, not yet.  Consider this last call.  If there are no other comments I'll 
commit the patch in the next day.


- Stanton


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/#review9405
---


On July 18, 2012, 7:45 p.m., Adam Clarke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6035/
> ---
> 
> (Updated July 18, 2012, 7:45 p.m.)
> 
> 
> Review request for shindig, Ryan Baxter and Stanton Sievers.
> 
> 
> Description
> ---
> 
> Adds two new settings to oauth.json (or other persistence plugins) to handle 
> picky OAuth1.0a providers.
> 
> 1) New key_type "PLAINTEXT"
>"key_type" : "PLAINTEXT"
> Default remains "key_type" : "HMAC_SYMMETRIC"
> 
> 2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on 
> requests
>"bodyHash" : "false"
> Default is "true" to keep compatibility with existing configurations
> 
> 
> This addresses bug SHINDIG-1775.
> https://issues.apache.org/jira/browse/SHINDIG-1775
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
>  1363028 
> 
> Diff: https://reviews.apache.org/r/6035/diff/
> 
> 
> Testing
> ---
> 
> All JUnits pass.
> 
> 
> Thanks,
> 
> Adam Clarke
> 
>

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-24 Thread Matt Franklin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/#review9405
---

Ship it!


Was this applied yet?

- Matt Franklin


On July 18, 2012, 7:45 p.m., Adam Clarke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6035/
> ---
> 
> (Updated July 18, 2012, 7:45 p.m.)
> 
> 
> Review request for shindig, Ryan Baxter and Stanton Sievers.
> 
> 
> Description
> ---
> 
> Adds two new settings to oauth.json (or other persistence plugins) to handle 
> picky OAuth1.0a providers.
> 
> 1) New key_type "PLAINTEXT"
>"key_type" : "PLAINTEXT"
> Default remains "key_type" : "HMAC_SYMMETRIC"
> 
> 2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on 
> requests
>"bodyHash" : "false"
> Default is "true" to keep compatibility with existing configurations
> 
> 
> This addresses bug SHINDIG-1775.
> https://issues.apache.org/jira/browse/SHINDIG-1775
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
>  1363028 
> 
> Diff: https://reviews.apache.org/r/6035/diff/
> 
> 
> Testing
> ---
> 
> All JUnits pass.
> 
> 
> Thanks,
> 
> Adam Clarke
> 
>

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-18 Thread Ryan Baxter 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/#review9266
---

Ship it!


Looks good Adam thanks for doing this!  I would give you a huge +1 though if 
you had some time to write some unit tests for some of these classes, I know 
that they dont exist today.

- Ryan Baxter


On July 18, 2012, 7:45 p.m., Adam Clarke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6035/
> ---
> 
> (Updated July 18, 2012, 7:45 p.m.)
> 
> 
> Review request for shindig, Ryan Baxter and Stanton Sievers.
> 
> 
> Description
> ---
> 
> Adds two new settings to oauth.json (or other persistence plugins) to handle 
> picky OAuth1.0a providers.
> 
> 1) New key_type "PLAINTEXT"
>"key_type" : "PLAINTEXT"
> Default remains "key_type" : "HMAC_SYMMETRIC"
> 
> 2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on 
> requests
>"bodyHash" : "false"
> Default is "true" to keep compatibility with existing configurations
> 
> 
> This addresses bug SHINDIG-1775.
> https://issues.apache.org/jira/browse/SHINDIG-1775
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
>  1363028 
> 
> Diff: https://reviews.apache.org/r/6035/diff/
> 
> 
> Testing
> ---
> 
> All JUnits pass.
> 
> 
> Thanks,
> 
> Adam Clarke
> 
>

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-18 Thread Stanton Sievers 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/#review9262
---

Ship it!


Small javadoc issue.  Other than that, this looks good.


http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java


Can you add doc for the oauthBodyHash param?  Maybe remove the doc of the 
other constructor and use an @see tag to point to this one.


- Stanton Sievers


On July 18, 2012, 7:45 p.m., Adam Clarke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6035/
> ---
> 
> (Updated July 18, 2012, 7:45 p.m.)
> 
> 
> Review request for shindig, Ryan Baxter and Stanton Sievers.
> 
> 
> Description
> ---
> 
> Adds two new settings to oauth.json (or other persistence plugins) to handle 
> picky OAuth1.0a providers.
> 
> 1) New key_type "PLAINTEXT"
>"key_type" : "PLAINTEXT"
> Default remains "key_type" : "HMAC_SYMMETRIC"
> 
> 2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on 
> requests
>"bodyHash" : "false"
> Default is "true" to keep compatibility with existing configurations
> 
> 
> This addresses bug SHINDIG-1775.
> https://issues.apache.org/jira/browse/SHINDIG-1775
> 
> 
> Diffs
> -
> 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
>  1363028 
>   
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
>  1363028 
> 
> Diff: https://reviews.apache.org/r/6035/diff/
> 
> 
> Testing
> ---
> 
> All JUnits pass.
> 
> 
> Thanks,
> 
> Adam Clarke
> 
>

Re: Review Request: OAuth1.0a , Make oauth_body_hash optional and support PLAINTEXT

2012-07-18 Thread Adam Clarke 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6035/
---

(Updated July 18, 2012, 7:45 p.m.)


Review request for shindig, Ryan Baxter and Stanton Sievers.


Changes
---

Wrong JIRA


Description
---

Adds two new settings to oauth.json (or other persistence plugins) to handle 
picky OAuth1.0a providers.

1) New key_type "PLAINTEXT"
   "key_type" : "PLAINTEXT"
Default remains "key_type" : "HMAC_SYMMETRIC"

2) New field "bodyHash" that won't put extra params like "oauth_body_hash" on 
requests
   "bodyHash" : "false"
Default is "true" to keep compatibility with existing configurations


This addresses bug SHINDIG-1775.
https://issues.apache.org/jira/browse/SHINDIG-1775


Diffs
-

  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java
 1363028 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStoreConsumerKeyAndSecret.java
 1363028 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
 1363028 
  
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthStore.java
 1363028 

Diff: https://reviews.apache.org/r/6035/diff/


Testing
---

All JUnits pass.


Thanks,

Adam Clarke