[GitHub] [shiro] bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-07-02 Thread GitBox 
bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment
URL: https://github.com/apache/shiro/pull/156#issuecomment-507768223
 
 
   Thanks for catching that @fpapon, I thought I had already changed my vote
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shiro] bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment

2019-06-27 Thread GitBox 
bdemers commented on issue #156: SHIRO-711 - Deprecate JavaEnvironment
URL: https://github.com/apache/shiro/pull/156#issuecomment-506345743
 
 
   Thanks!! 
   
   Sorry one more nit, Can you add a `@deprecated` javadoc tag?  Maybe say 
something about will remove in the next major version? or this class is no 
longer used by Shiro 樂 ?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services