[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module
URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320544707
 
 

 ##
 File path: src/dist/communicator.cc
 ##
 @@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   sorry i will also need to modify the cmakelist
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module
URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320544707
 
 

 ##
 File path: src/dist/communicator.cc
 ##
 @@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   sorry i will also need to modify the cmakelist
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module
URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320542607
 
 

 ##
 File path: src/dist/communicator.cc
 ##
 @@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   I have moved both communicator.cc and communicator.h to io folders


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-singa] chrishkchris commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
chrishkchris commented on a change in pull request #468: Distributted module
URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320542607
 
 

 ##
 File path: src/dist/communicator.cc
 ##
 @@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   I have moved the both communicator.cc and communicator.h to io folders


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SINGA-474) Implement ONNX Operators in Autograd

2019-09-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SINGA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921498#comment-16921498
 ] 

ASF subversion and git services commented on SINGA-474:
---

Commit 572efeac1fa7405736e64d4ac5cd4d86694b96df in incubator-singa's branch 
refs/heads/master from ShichengChen
[ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=572efea ]

SINGA-474 prelu,add,equal,selu,elu operator


> Implement ONNX Operators in Autograd
> 
>
> Key: SINGA-474
> URL: https://issues.apache.org/jira/browse/SINGA-474
> Project: Singa
>  Issue Type: Improvement
>Reporter: Shicheng
>Priority: Minor
>  Time Spent: 21h 50m
>  Remaining Estimate: 0h
>
> Implement ONNX Operators following 
> https://github.com/onnx/onnx/blob/master/docs/Operators.md



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SINGA-474) Implement ONNX Operators in Autograd

2019-09-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SINGA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921497#comment-16921497
 ] 

ASF subversion and git services commented on SINGA-474:
---

Commit 39b4c3fd55f29af65c2474f593c60cab35622a80 in incubator-singa's branch 
refs/heads/master from ShichengChen
[ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=39b4c3f ]

SINGA-474 prelu operator


> Implement ONNX Operators in Autograd
> 
>
> Key: SINGA-474
> URL: https://issues.apache.org/jira/browse/SINGA-474
> Project: Singa
>  Issue Type: Improvement
>Reporter: Shicheng
>Priority: Minor
>  Time Spent: 21h 50m
>  Remaining Estimate: 0h
>
> Implement ONNX Operators following 
> https://github.com/onnx/onnx/blob/master/docs/Operators.md



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SINGA-474) Implement ONNX Operators in Autograd

2019-09-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SINGA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921500#comment-16921500
 ] 

ASF subversion and git services commented on SINGA-474:
---

Commit 850e0c154548febbb5a75fc3dda11a4e691e3736 in incubator-singa's branch 
refs/heads/master from Wei Wang
[ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=850e0c1 ]

Merge pull request #524 from ShichengChen/operator5

SINGA-474 prelu,add,equal,selu,elu operator

> Implement ONNX Operators in Autograd
> 
>
> Key: SINGA-474
> URL: https://issues.apache.org/jira/browse/SINGA-474
> Project: Singa
>  Issue Type: Improvement
>Reporter: Shicheng
>Priority: Minor
>  Time Spent: 21h 50m
>  Remaining Estimate: 0h
>
> Implement ONNX Operators following 
> https://github.com/onnx/onnx/blob/master/docs/Operators.md



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SINGA-474) Implement ONNX Operators in Autograd

2019-09-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SINGA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921496#comment-16921496
 ] 

ASF subversion and git services commented on SINGA-474:
---

Commit 68b7ac2e8bad44ed1f1ac8a33bf627c757e9938d in incubator-singa's branch 
refs/heads/master from ShichengChen
[ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=68b7ac2 ]

SINGA-474 prelu operator


> Implement ONNX Operators in Autograd
> 
>
> Key: SINGA-474
> URL: https://issues.apache.org/jira/browse/SINGA-474
> Project: Singa
>  Issue Type: Improvement
>Reporter: Shicheng
>Priority: Minor
>  Time Spent: 21h 50m
>  Remaining Estimate: 0h
>
> Implement ONNX Operators following 
> https://github.com/onnx/onnx/blob/master/docs/Operators.md



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (SINGA-474) Implement ONNX Operators in Autograd

2019-09-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/SINGA-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921499#comment-16921499
 ] 

ASF subversion and git services commented on SINGA-474:
---

Commit 21f27a774ec7ff0954aa5541bbbc606bcb8ce7b4 in incubator-singa's branch 
refs/heads/master from ShichengChen
[ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=21f27a7 ]

SINGA-474 prelu,add,equal,selu,elu operator, optimize operations and add 
assertions


> Implement ONNX Operators in Autograd
> 
>
> Key: SINGA-474
> URL: https://issues.apache.org/jira/browse/SINGA-474
> Project: Singa
>  Issue Type: Improvement
>Reporter: Shicheng
>Priority: Minor
>  Time Spent: 21h 50m
>  Remaining Estimate: 0h
>
> Implement ONNX Operators following 
> https://github.com/onnx/onnx/blob/master/docs/Operators.md



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[GitHub] [incubator-singa] nudles merged pull request #524: SINGA-474 prelu, add, equal, selu, elu operator

2019-09-03 Thread GitBox
nudles merged pull request #524: SINGA-474 prelu,add,equal,selu,elu operator
URL: https://github.com/apache/incubator-singa/pull/524
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-singa] nudles commented on a change in pull request #468: Distributted module

2019-09-03 Thread GitBox
nudles commented on a change in pull request #468: Distributted module
URL: https://github.com/apache/incubator-singa/pull/468#discussion_r320326414
 
 

 ##
 File path: src/dist/communicator.cc
 ##
 @@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   move dist/* into io/ folder?
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services