[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929672#comment-16929672 ] ASF subversion and git services commented on SINGA-485: --- Commit bbd9015867de6fbb8845d12d455647dd1bb141a8 in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=bbd9015 ] SINGA-485 Add Ubuntu 16.04 and 18.04 to Travis CI build > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929674#comment-16929674 ] ASF subversion and git services commented on SINGA-485: --- Commit 8159e87e0ae4c8a78c5874b7abda83b667200bed in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=8159e87 ] Merge pull request #531 from moazreyad/SINGA-485 SINGA-485 Add code coverage with codecov > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929673#comment-16929673 ] ASF subversion and git services commented on SINGA-485: --- Commit 8159e87e0ae4c8a78c5874b7abda83b667200bed in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=8159e87 ] Merge pull request #531 from moazreyad/SINGA-485 SINGA-485 Add code coverage with codecov > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-485) Code Coverage Analysis
[ https://issues.apache.org/jira/browse/SINGA-485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929671#comment-16929671 ] ASF subversion and git services commented on SINGA-485: --- Commit 5cf19022cffe6bdfcd028c005c6b33e29577aa45 in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=5cf1902 ] SINGA-485 Add code coverage with codecov > Code Coverage Analysis > -- > > Key: SINGA-485 > URL: https://issues.apache.org/jira/browse/SINGA-485 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > SINGA development and testing can be improved by using a [code > coverage|https://en.wikipedia.org/wiki/Code_coverage] tool. > Some Apache projects use [codecov|https://codecov.io/gh/apache?page=1], while > others use [coverall|https://coveralls.io/github/apache?page=1]. > This issue is open to choose a code coverage tool and add it to SINGA build > and test pipeline. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [incubator-singa] nudles merged pull request #531: SINGA-485 Add code coverage with codecov
nudles merged pull request #531: SINGA-485 Add code coverage with codecov URL: https://github.com/apache/incubator-singa/pull/531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] nudles commented on a change in pull request #529: SINGA-484 Code analysis with LGTM
nudles commented on a change in pull request #529: SINGA-484 Code analysis with
LGTM
URL: https://github.com/apache/incubator-singa/pull/529#discussion_r324411358
##
File path: include/singa/io/transformer.h
##
@@ -56,12 +56,12 @@ class ImageTransformer: public Transformer {
Tensor Apply(int flag, Tensor& input) override;
- const bool featurewise_center() const { return featurewise_center_; }
- const bool featurewise_std_norm() const { return featurewise_std_norm_; }
- const bool horizontal_mirror() const { return horizontal_mirror_; }
- const int resize_height() const { return resize_height_; }
- const int resize_width() const { return resize_width_; }
- const float rescale() const { return rescale_; }
+ bool featurewise_center() const { return featurewise_center_; }
Review comment:
Does the code analysis suggest to remove the const?
Where can we find all the suggestions?
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (SINGA-489) Add onnx backend test cases for the new operators
zhangzhaoqi created SINGA-489: - Summary: Add onnx backend test cases for the new operators Key: SINGA-489 URL: https://issues.apache.org/jira/browse/SINGA-489 Project: Singa Issue Type: New Feature Reporter: zhangzhaoqi Add onnx backend test cases for the new operators at 'SINGA-471' -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Closed] (SINGA-483) fix dummy bugs
[ https://issues.apache.org/jira/browse/SINGA-483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhaoqi closed SINGA-483. - Resolution: Fixed > fix dummy bugs > -- > > Key: SINGA-483 > URL: https://issues.apache.org/jira/browse/SINGA-483 > Project: Singa > Issue Type: New Feature >Reporter: zhangzhaoqi >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > There is a but at autograd dummy operator. It should call __getattribute__ > function to get tensor's attribute, not directly use the name. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Updated] (SINGA-481) Reconstruct SONNX
[ https://issues.apache.org/jira/browse/SINGA-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangzhaoqi updated SINGA-481: -- Description: * Reconstruct the frontend and backend of soonx, and make it support transfer learning. * Develop soonx operators: conv2d, relu, avg_pool, softmax, sigmoid, add, concat, matmul * Add these operators' test cases. was: * Reconstruct the frontend and backend of soonx, and make it support transfer learning. * Develop soonx operators: conv2d, relu, avg_pool, softmax, sigmoid, add, concat, matmul * Add these operators' test cases. > Reconstruct SONNX > - > > Key: SINGA-481 > URL: https://issues.apache.org/jira/browse/SINGA-481 > Project: Singa > Issue Type: New Feature >Reporter: zhangzhaoqi >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > * Reconstruct the frontend and backend of soonx, and make it support transfer > learning. > * Develop soonx operators: conv2d, relu, avg_pool, softmax, sigmoid, add, > concat, matmul > * Add these operators' test cases. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [incubator-singa] joddiy commented on issue #462: SINGA-333 Add ONNX backend test
joddiy commented on issue #462: SINGA-333 Add ONNX backend test URL: https://github.com/apache/incubator-singa/pull/462#issuecomment-531445928 please refer to [here](https://github.com/apache/incubator-singa/pull/534) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] joddiy commented on issue #534: Test onnx backend
joddiy commented on issue #534: Test onnx backend URL: https://github.com/apache/incubator-singa/pull/534#issuecomment-531445904 Please don't merge this PR until I finish all the test cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] joddiy opened a new pull request #534: Test onnx backend
joddiy opened a new pull request #534: Test onnx backend URL: https://github.com/apache/incubator-singa/pull/534 add onnx backend test cases This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] joddiy commented on issue #462: SINGA-333 Add ONNX backend test
joddiy commented on issue #462: SINGA-333 Add ONNX backend test URL: https://github.com/apache/incubator-singa/pull/462#issuecomment-531445841 I think we cannot directly use all the onnx test cases. Since, first, it's hard to integrate the sonnx into it. Second, there are lots of test cases we cannot use because we don't have some functionalities, such as dilation... So far, I've written a new test file to adapt the test cases from onnx, so that we can discard some cases that we cannot implement. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SINGA-487) Distributed Module Development and Improvement
[ https://issues.apache.org/jira/browse/SINGA-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929664#comment-16929664 ] ASF subversion and git services commented on SINGA-487: --- Commit 872eb6c06a7ecc108a77382606da4571f49aba3f in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=872eb6c ] Merge pull request #532 from chrishkchris/SINGA-487 SINGA-487 Add the support of Python Multiprocess Module > Distributed Module Development and Improvement > -- > > Key: SINGA-487 > URL: https://issues.apache.org/jira/browse/SINGA-487 > Project: Singa > Issue Type: New Feature > Components: Module >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Here I open a new Jira ticket for long term development and improvement of > distributed learning module. > E.g., Firstly, I will make the distributed module to be compatible with > python multiprocessing. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-487) Distributed Module Development and Improvement
[ https://issues.apache.org/jira/browse/SINGA-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929661#comment-16929661 ] ASF subversion and git services commented on SINGA-487: --- Commit c36faf42ede14a0011b61743dbd37d34021fa0b7 in incubator-singa's branch refs/heads/master from chrishkchris [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=c36faf4 ] SINGA-487 Modified the Distributed Module to be compatiable with Python Multiprocessing > Distributed Module Development and Improvement > -- > > Key: SINGA-487 > URL: https://issues.apache.org/jira/browse/SINGA-487 > Project: Singa > Issue Type: New Feature > Components: Module >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Here I open a new Jira ticket for long term development and improvement of > distributed learning module. > E.g., Firstly, I will make the distributed module to be compatible with > python multiprocessing. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-487) Distributed Module Development and Improvement
[ https://issues.apache.org/jira/browse/SINGA-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929662#comment-16929662 ] ASF subversion and git services commented on SINGA-487: --- Commit 72754462876eaebcd9737ab7c5012b12ffca in incubator-singa's branch refs/heads/master from chrishkchris [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=727 ] SINGA-487 Update Distributed Module Examples > Distributed Module Development and Improvement > -- > > Key: SINGA-487 > URL: https://issues.apache.org/jira/browse/SINGA-487 > Project: Singa > Issue Type: New Feature > Components: Module >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Here I open a new Jira ticket for long term development and improvement of > distributed learning module. > E.g., Firstly, I will make the distributed module to be compatible with > python multiprocessing. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (SINGA-487) Distributed Module Development and Improvement
[ https://issues.apache.org/jira/browse/SINGA-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929663#comment-16929663 ] ASF subversion and git services commented on SINGA-487: --- Commit 872eb6c06a7ecc108a77382606da4571f49aba3f in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=872eb6c ] Merge pull request #532 from chrishkchris/SINGA-487 SINGA-487 Add the support of Python Multiprocess Module > Distributed Module Development and Improvement > -- > > Key: SINGA-487 > URL: https://issues.apache.org/jira/browse/SINGA-487 > Project: Singa > Issue Type: New Feature > Components: Module >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Here I open a new Jira ticket for long term development and improvement of > distributed learning module. > E.g., Firstly, I will make the distributed module to be compatible with > python multiprocessing. > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[GitHub] [incubator-singa] nudles merged pull request #532: SINGA-487 Add the support of Python Multiprocess Module
nudles merged pull request #532: SINGA-487 Add the support of Python Multiprocess Module URL: https://github.com/apache/incubator-singa/pull/532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] nudles commented on issue #462: SINGA-333 Add ONNX backend test
nudles commented on issue #462: SINGA-333 Add ONNX backend test URL: https://github.com/apache/incubator-singa/pull/462#issuecomment-531445209 @joddiy can we merge this one? or we need to wait until the operators are all implemented? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] nudles commented on a change in pull request #533: fixed operation add assertion for convolution
nudles commented on a change in pull request #533: fixed operation add
assertion for convolution
URL: https://github.com/apache/incubator-singa/pull/533#discussion_r324410807
##
File path: src/core/tensor/tensor_math_cpp.h
##
@@ -868,6 +868,25 @@ void RowMax(const Tensor& in, Tensor
*out, Context *ctx) {
}
}
+template <>
+void SoftMax(const Tensor& in, Tensor* out, Context *ctx) {
Review comment:
do we need to move SoftMax into tensor_math_cpp.h?
If not, please delete the changes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[VOTE] Recommend 'Apache SINGA graduation to Top Level Project' resolution to the board
In the four and a half years that Apache SINGA (incubating) has been a part of the Apache incubator, the community has grown, diversified, and adapted to the Apache Way. We believe that the project is ready to graduate to a TLP. As a community, we have discussed [1] and voted [2] to graduate to a TLP, we have worked through the maturity model [3], notified the IPMC that we have the intention to graduate [4] and proposed PMC chair [5]. We filed a software grant [6] and discussed the graduation here [7]. Please take a minute to vote on whether or not the IPMC should recommend the resolution below to the Board by responding with one of the following: [ ] +1 Apache SINGA should graduate [ ] 0 No opinion [ ] -1 Apache SINGA should not graduate because... The VOTE is open for a minimum of 72 hours. Thank you, Moaz, on behalf of Apache SINGA (incubating) community [1] https://lists.apache.org/thread.html/fd2fe639f3314ff22d2e47d39bd6d4126d61d10e8628fa26f71ef01d@%3Cdev.singa.apache.org%3E [2] https://lists.apache.org/thread.html/cb40b73b3fd685b44a129601abd5967e4150db245b3fc6552f106faf@%3Cdev.singa.apache.org%3E [3] https://cwiki.apache.org/confluence/display/SINGA/Maturity+model+assessment [4] https://lists.apache.org/thread.html/5b5ebefe705084e0a9d67cfaf56f17ff27518273366f8088be19273e@%3Cgeneral.incubator.apache.org%3E [5] https://lists.apache.org/thread.html/2903ea94da1b862acf8d706dd4f7cd9ecbc434166d4381d170be731f@%3Cprivate.singa.apache.org%3E [6] https://lists.apache.org/thread.html/0ae459aa462ab1aac6771f6ce7ff2a8a14ac286103bee5e1a42426b2@%3Cprivate.singa.apache.org%3E [7] https://lists.apache.org/thread.html/8f4bbc5f2945ffcda848fcf5cf2f6ff676069e0807cef3221f401728@%3Cgeneral.incubator.apache.org%3E -- Proposed Resolution for the Apache SINGA project for the ASF Board: Establish the Apache SINGA Project WHEREAS, the Board of Directors deems it to be in the best interests of the Foundation and consistent with the Foundation's purpose to establish a Project Management Committee charged with the creation and maintenance of open-source software, for distribution at no charge to the public, related to a distributed deep learning platform. NOW, THEREFORE, BE IT RESOLVED, that a Project Management Committee (PMC), to be known as the "Apache SINGA Project", be and hereby is established pursuant to Bylaws of the Foundation; and be it further RESOLVED, that the Apache SINGA Project be and hereby is responsible for the creation and maintenance of software related to a distributed deep learning platform; and be it further RESOLVED, that the office of "Vice President, Apache SINGA" be and hereby is created, the person holding such office to serve at the direction of the Board of Directors as the chair of the Apache SINGA Project, and to have primary responsibility for management of the projects within the scope of responsibility of the Apache SINGA Project; and be it further RESOLVED, that the persons listed immediately below be and hereby are appointed to serve as the initial members of the Apache SINGA Project: * Thejas Nair ( the...@apache.org ) * Alan Gates ( ga...@apache.org ) * Ted Dunning ( tdunn...@apache.org ) * Beng Chin Ooi ( oo...@apache.org ) * Wang Wei ( wang...@apache.org ) * Anh Dinh ( dinh...@apache.org ) * Chen Gang( c...@apache.org ) * Jinyang Gao ( jiny...@apache.org ) * Kian-Lee Tan ( tankian...@apache.org ) * Luo Zhaojing ( zhaoj...@apache.org ) * Xie Zhongle ( zhon...@apache.org ) * Zheng Kaiping ( kaip...@apache.org ) * Moaz Reyad ( m...@apache.org ) NOW, THEREFORE, BE IT FURTHER RESOLVED, that Wang Wei be appointed to the office of Vice President, Apache SINGA, to serve in accordance with and subject to the direction of the Board of Directors and the Bylaws of the Foundation until death, resignation, retirement, removal or disqualification, or until a successor is appointed; and be it further RESOLVED, that the initial Apache SINGA PMC be and hereby is tasked with the creation of a set of bylaws intended to encourage open development and increased participation in the Apache SINGA Project; and be it further RESOLVED, that the Apache SINGA Project be and hereby is tasked with the migration and rationalization of the Apache Incubator SINGA podling; and be it further RESOLVED, that all responsibilities pertaining to the Apache Incubator SINGA podling encumbered upon the Apache Incubator Project are hereafter discharged.
Re: [Discuss] Graduate Apache SINGA (incubating) as a TLP
Ok, now that the SGA is filed, I'm +1 on this. Thanks for chasing this down. Alan. On Thu, Sep 5, 2019 at 2:36 AM Beng Chin OOI wrote: > > A number have joined Alibaba, Kyoto University, Zhejiang University and > other companies in > various countries, and some still continue to contribute. > > On Singapore side, IMDA https://www2.imda.gov.sg is pushing the system > for adoption by > the local industry/SME. > > SINGA-lite (with federated learning facility, for edge computing etc) > and SINGA-easy (for > the dummies, such as clinicians and subject matter experts who are not > AI experts) are on > schedule for releases in three months time. > > regards > beng chin > > > On 2019-09-05 17:22, Justin Mclean wrote: > > Hi, > > > >> 1. The affiliation of the proposed PMC can be found here [1]. It shows > >> that > >> the PPMC members belong to six different organizations (not counting > >> the > >> affiliations of the mentors) > > > > Thanks for that I can see that 1/2 are from the National University of > > Singapore, would the project continue if for some some reason they > > stopped contributing? We’ve had several projects suddenly stop when a > > majority of participants have moved elsewhere for one reasons or > > another. This is probably not a blocker but something for teh project > > to think out and perhaps try to increase the number of PMC members. > > > > Thanks, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
