[GitHub] coveralls commented on issue #975: Support direct server setting in agent.
coveralls commented on issue #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975#issuecomment-375206448 [![Coverage Status](https://coveralls.io/builds/16137161/badge)](https://coveralls.io/builds/16137161) Coverage increased (+0.02%) to 19.237% when pulling **9e219c95a9eece4b311150abeb02f88b9d32dc01 on feature/direct_server** into **56c090b66b9874d48bfb83c0585b07f9f45a5ba8 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #980: Fix document.
wu-sheng opened a new pull request #980: Fix document. URL: https://github.com/apache/incubator-skywalking/pull/980 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #979: get 5.x jar
wu-sheng commented on issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979#issuecomment-375526281 @cyberdak Thanks for pointing to right direction. @zilanghuo Apache release process is still on going, after we passed, you will have way to download it from Apache mirror. Now you have to build from source, if you want to try. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #979: get 5.x jar
wu-sheng closed issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zilanghuo commented on issue #979: get 5.x jar
zilanghuo commented on issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979#issuecomment-375525996 thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cyberdak commented on issue #979: get 5.x jar
cyberdak commented on issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979#issuecomment-375522384 Now you need build it from source. https://github.com/apache/incubator-skywalking/blob/master/docs/cn/How-to-build-CN.md Here is the build manual. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0-alpha (2nd round)
Vote result: 4 (+1) binding 1 (+1) nobinding And I think the vote checks have been done by more than one PMC or committer. Thanks, everyone. I will start the vote in IPMC, hope we fit all requirements for the Apache release. On 2018/03/20 03:26:29, "å´æ Sheng Wu"wrote: > Hi All, > This is a call for vote to release Apache SkyWalking (Incubating) version > 5.0.0-alpha. > > > Release notes: > > > * https://github.com/apache/incubator-skywalking/blob/master/CHANGES.md > > > Release Candidate: > > > * https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha/ > > > Maven 2 staging repository: > > > * > https://repository.apache.org/content/repositories/orgapacheskywalking-1005/org/apache/skywalking/apache-skywalking-apm-incubating/5.0.0-alpha/ > > > Release Tag : > > > * v5.0.0-alpha > > > Release CommitID : > > > * f52d99498f02402d2ce1a0b7b909cd7fcfb3526f > > > Keys to verify the Release Candidate : > > > * > https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha/KEYS > * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777 > > > corresponding to pen...@apache.org > > > Guide to build the release from source : > > > * > https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-build.md#build-from-apache-source-codes > > > Voting will start now (March 20th, 2018) and will remain open for at least 72 > hours, Request all PPMC members to give their vote. > [ ] +1 Release this package. > [ ] +0 No opinion. > [ ] -1 Do not release this package because > > > > Everyone, I recommend you to run check by following this list: > https://github.com/apache/incubator-skywalking/blob/master/docs/en/How-to-release.md#vote-check > > > > -- > Sheng Wu > Apache SkyWalking original creator and PPMC member
[GitHub] zilanghuo opened a new issue #979: get 5.x jar
zilanghuo opened a new issue #979: get 5.x jar URL: https://github.com/apache/incubator-skywalking/issues/979 Excuse me, how can I get 5. X version of the jar package. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan
wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375510423 Yes, they are always in one thread, guarantee by Javs stack module, not by SkyWalking. But you must be careful of concurrency. For tags, those are from OpenTracing, which tag the info for backend analysis, aggregation and visualization. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 commented on issue #978: Purpose of tag method in AbstractSpan
zone1511 commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375503420 Does the before and after method interceptor guarantee to run on same thread? What is the original purpose of Tag in span? Sent from my iPhone > On 23 Mar 2018, at 8:14 AM, 吴晟 Wu Shengwrote: > > Yes, that depends how does your intercepted object use in thread? if no concurrency situation, you can use dynamic field to propagate. If has, use your own thread local, or proposal to add runtime context for TracingContext. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or mute the thread. > This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan
wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375498603 Yes, that depends how does your intercepted object use in thread? if no concurrency situation, you can use dynamic field to propagate. If has, use your own thread local, or proposal to add runtime context for TracingContext. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 commented on issue #978: Purpose of tag method in AbstractSpan
zone1511 commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375496224 Need to pass data around before and after method invokation. Does the span a go place to store? If not, where to store the temp data appear in the before/after method invocation? And what’s the original purpose of tag in span? Sent from my iPhone > On 23 Mar 2018, at 7:09 AM, 吴晟 Wu Shengwrote: > > why do you need gettag in span? can you provide scenario? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub, or mute the thread. > This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan
wu-sheng commented on issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978#issuecomment-375487066 why do you need gettag in span? can you provide scenario? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zone1511 opened a new issue #978: Purpose of tag method in AbstractSpan
zone1511 opened a new issue #978: Purpose of tag method in AbstractSpan URL: https://github.com/apache/incubator-skywalking/issues/978 Please answer these questions before submitting your issue. - Why do you submit this issue? - [X] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or performance improvement ___ ### Question - What do you want to know? in `AbstractSpan` there is a tag method, will the tag value pass to collector and ui? Can we add the `getTags` method in `AbstractSpan` as well? ___ ### Bug - Which version of SkyWalking, OS and JRE? - Which company or project? - What happen? If possible, provide a way for reproducing the error. e.g. demo application, component version. ___ ### Requirement or improvement - Please describe about your requirements or improvement suggestions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #770: Decouple JDBCURL parser logic from URLParser question
wu-sheng closed pull request #770: Decouple JDBCURL parser logic from URLParser question URL: https://github.com/apache/incubator-skywalking/pull/770 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/H2URLParser.java b/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/h2/parser/H2URLParser.java similarity index 93% rename from apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/H2URLParser.java rename to apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/h2/parser/H2URLParser.java index 08c4b636d..ad1fd687e 100644 --- a/apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/H2URLParser.java +++ b/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdbc/h2/parser/H2URLParser.java @@ -17,9 +17,11 @@ */ -package org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser; +package org.apache.skywalking.apm.plugin.jdbc.h2.parser; import org.apache.skywalking.apm.network.trace.component.ComponentsDefine; +import org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.AbstractURLParser; +import org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.URLLocation; import org.apache.skywalking.apm.plugin.jdbc.trace.ConnectionInfo; /** @@ -55,6 +57,10 @@ public H2URLParser(String url) { super(url); } +public H2URLParser() { +this(""); +} + @Override protected URLLocation fetchDatabaseHostsIndexRange() { int hostLabelStartIndex = url.indexOf("//"); @@ -92,6 +98,10 @@ public ConnectionInfo parse() { } } +@Override public String getJDBCURLPrefix() { +return "jdbc:h2"; +} + /** * Fetch range index that the database name from connection url if H2 database running with file mode. * diff --git a/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/main/resources/META-INF/services/org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.ConnectionURLParser b/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/main/resources/META-INF/services/org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.ConnectionURLParser new file mode 100644 index 0..89c0b82f4 --- /dev/null +++ b/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/main/resources/META-INF/services/org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.ConnectionURLParser @@ -0,0 +1 @@ +org.apache.skywalking.apm.plugin.jdbc.h2.parser.H2URLParser \ No newline at end of file diff --git a/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/jdbc/h2/URLParserTest.java b/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/jdbc/h2/URLParserTest.java new file mode 100644 index 0..42f602825 --- /dev/null +++ b/apm-sniffer/apm-sdk-plugin/h2-1.x-plugin/src/test/java/org/apache/skywalking/apm/plugin/jdbc/h2/URLParserTest.java @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + + +package org.apache.skywalking.apm.plugin.jdbc.h2; + +import org.apache.skywalking.apm.plugin.jdbc.connectionurl.parser.URLParser; +import org.junit.Test; +import org.apache.skywalking.apm.plugin.jdbc.trace.ConnectionInfo; + +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; + +public class URLParserTest { +@Test +public void testParseH2JDBCURLWithEmbedded() { +ConnectionInfo connectionInfo = new URLParser().parser("jdbc:h2:file:/data/sample"); +assertThat(connectionInfo.getDBType(), is("H2")); +assertThat(connectionInfo.getDatabaseName(), is("/data/sample")); +assertThat(connectionInfo.getDatabasePeer(), is("localhost:-1")); +} + +@Test +
[GitHub] wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question
wu-sheng commented on issue #770: Decouple JDBCURL parser logic from URLParser question URL: https://github.com/apache/incubator-skywalking/pull/770#issuecomment-375239858 This pr stays no change in near one month, and some conflicts. I am closing this pr, if you have more things to contribute or discuss, please start a new one. Thanks. @zone1511 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #973: Topology show error
wu-sheng commented on issue #973: Topology show error URL: https://github.com/apache/incubator-skywalking/issues/973#issuecomment-375237469 FYI @hanahmily I think you may be interested in the topology based on this data. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #977: Add calls and online time to replace tps
wu-sheng opened a new issue #977: Add calls and online time to replace tps URL: https://github.com/apache/incubator-skywalking/issues/977 For a low throughput system, tps is always 0. For improving that, I proposal to add calls and online time in those services. Just keep tps in protocol before 5.0-GA, marked as `Deprecated` in GraphQL service. I will pull request protocol changes soon. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xyydcoo commented on issue #973: Topology show error
xyydcoo commented on issue #973: Topology show error URL: https://github.com/apache/incubator-skywalking/issues/973#issuecomment-375229445 [参数.txt](https://github.com/apache/incubator-skywalking/files/1836779/default.txt) es数据链接:https://pan.baidu.com/s/19t_L02m3iMQRzevDS8y3SQ 密码:s04q This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #976: Add total distributed calls in Overview page
wu-sheng commented on issue #976: Add total distributed calls in Overview page URL: https://github.com/apache/incubator-skywalking/issues/976#issuecomment-375228685 Come frome https://github.com/apache/incubator-skywalking-ui/issues/134 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #134: Add total distributed calls in Overview page
wu-sheng closed issue #134: Add total distributed calls in Overview page URL: https://github.com/apache/incubator-skywalking-ui/issues/134 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #976: Add total distributed calls in Overview page
wu-sheng opened a new issue #976: Add total distributed calls in Overview page URL: https://github.com/apache/incubator-skywalking/issues/976 For improving the end user experience, current overview is too static. I recommend to add a new metric, also a new backend service. The metric is **Total distributed calls**, every distributed call or rpc will be included. So the value will be every big, Recommend show as `xxx K`, `xxx M`, `xxx B` and `xxx T` to represent kilo, million, billion and trillion times calls. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #151: Place conjecture nodes outside application topology
wu-sheng opened a new issue #151: Place conjecture nodes outside application topology URL: https://github.com/apache/incubator-skywalking-ui/issues/151 Make application topology layout in high priority, then place the conjecture nodes around the topology. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #975: Support direct server setting in agent.
coveralls commented on issue #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975#issuecomment-375206448 [![Coverage Status](https://coveralls.io/builds/16115544/badge)](https://coveralls.io/builds/16115544) Coverage increased (+0.02%) to 19.237% when pulling **ae95d5264192682f272e41906ae21f72bdf9673c on feature/direct_server** into **d8d28a0b33f9d6a405e43d65eff6dcf1dde49409 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #975: Support direct server setting in agent.
wu-sheng commented on issue #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975#issuecomment-375199594 @hanahmily You can set domain name in this, I think. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #975: Support direct server setting in agent.
wu-sheng opened a new pull request #975: Support direct server setting in agent. URL: https://github.com/apache/incubator-skywalking/pull/975 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance - Related issues #952 ___ ### New feature or improvement - Describe the details and related test reports. In some cases, agent can't access collector cluster's real IPs, by that, the collector discovery mechanism fails, and causes deployment block. As that, I provide a setting in `agent.config`, named **collector.direct_servers** By using this setting, agent will ignore the collector discovery mechanism, and choose one of the `direct server addresses`. ### NOTICE I recommend to use this only when collector cluster IPs are unreachable from agent side. Such as: 1. Agent and collector cluster are in different VPC in Cloud. 2. Agent uplinks data to collector cluster through Internet. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services