[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377114983
 
 
   new case : 
   telnet --> dubbo-provider3 --> dubbo-provider2 --> redis 
   but topology can't show 
   https://user-images.githubusercontent.com/7055460/38069515-633adc24-3349-11e8-972f-4cdafb5e1f7d.png;>
   
   ```
   2018-03-29 12:03:50,915 - 
graphql.execution.SimpleDataFetcherExceptionHandler -4226210 [qtp256004657-290] 
WARN  [] - Exception while fetching data (/getApplicationTopology) : / by zero
   java.lang.ArithmeticException: / by zero
   at 
org.apache.skywalking.apm.collector.ui.service.TopologyBuilder.lambda$build$1(TopologyBuilder.java:171)
 ~[collector-ui-jetty-provider-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_112]
   at 
org.apache.skywalking.apm.collector.ui.service.TopologyBuilder.build(TopologyBuilder.java:131)
 ~[collector-ui-jetty-provider-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at 
org.apache.skywalking.apm.collector.ui.service.ApplicationTopologyService.getApplicationTopology(ApplicationTopologyService.java:85)
 ~[collector-ui-jetty-provider-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at 
org.apache.skywalking.apm.collector.ui.query.ApplicationQuery.getApplicationTopology(ApplicationQuery.java:85)
 ~[collector-ui-jetty-provider-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at 
org.apache.skywalking.apm.collector.ui.query.ApplicationQueryMethodAccess.invoke(Unknown
 Source) ~[reflectasm-1.11.3.jar:5.0.0-beta-SNAPSHOT]
   at 
com.coxautodev.graphql.tools.MethodFieldResolverDataFetcher.get(MethodFieldResolver.kt:132)
 ~[graphql-java-tools-4.3.0.jar:?]
   at 
graphql.execution.ExecutionStrategy.fetchField(ExecutionStrategy.java:219) 
[graphql-java-6.0.jar:?]
   at 
graphql.execution.ExecutionStrategy.resolveField(ExecutionStrategy.java:165) 
[graphql-java-6.0.jar:?]
   at 
graphql.execution.AsyncExecutionStrategy.execute(AsyncExecutionStrategy.java:55)
 [graphql-java-6.0.jar:?]
   at graphql.execution.Execution.executeOperation(Execution.java:154) 
[graphql-java-6.0.jar:?]
   at graphql.execution.Execution.execute(Execution.java:98) 
[graphql-java-6.0.jar:?]
   at graphql.GraphQL.execute(GraphQL.java:546) [graphql-java-6.0.jar:?]
   at graphql.GraphQL.parseValidateAndExecute(GraphQL.java:488) 
[graphql-java-6.0.jar:?]
   at graphql.GraphQL.executeAsync(GraphQL.java:463) 
[graphql-java-6.0.jar:?]
   at graphql.GraphQL.execute(GraphQL.java:394) [graphql-java-6.0.jar:?]
   at 
org.apache.skywalking.apm.collector.ui.jetty.handler.GraphQLHandler.execute(GraphQLHandler.java:121)
 [collector-ui-jetty-provider-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at 
org.apache.skywalking.apm.collector.ui.jetty.handler.GraphQLHandler.doPost(GraphQLHandler.java:115)
 [collector-ui-jetty-provider-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at 
org.apache.skywalking.apm.collector.server.jetty.JettyHandler.doPost(JettyHandler.java:65)
 [server-component-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) 
[javax.servlet-api-3.1.0.jar:3.1.0]
   at 
org.apache.skywalking.apm.collector.server.jetty.JettyHandler.service(JettyHandler.java:112)
 [server-component-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) 
[javax.servlet-api-3.1.0.jar:3.1.0]
   at 
org.apache.skywalking.apm.collector.server.jetty.JettyHandler.service(JettyHandler.java:116)
 [server-component-5.0.0-beta-SNAPSHOT.jar:5.0.0-beta-SNAPSHOT]
   at 
org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841) 
[jetty-servlet-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 
org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:543) 
[jetty-servlet-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188)
 [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1239)
 [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168)
 [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 
org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:481) 
[jetty-servlet-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 
org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166)
 [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1141)
 [jetty-server-9.4.2.v20170220.jar:9.4.2.v20170220]
   at 

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377114029
 
 
   @peng-yongsheng You should pay attention on this issue. And check your trace 
segment query for cross-thread trace.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377113930
 
 
   I think you have updated your comments. I receive a different comment from 
my mail notification. Is trace broken? If so, there must be a bug existed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377113385
 
 
   @carlvine500 Is there a parent thread? I think the better case is dubbo1 -> 
dubbo2( dubbo-service -> cross-thread -> Jedis). Can you provide one?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377110497
 
 
   with skywalking 5.0 show(user-->dubbo-provider2-->redis): 
   https://user-images.githubusercontent.com/7055460/38068664-fa494088-3344-11e8-9572-b721ee1f51ed.png;>
   https://user-images.githubusercontent.com/7055460/38068968-6ae84fa4-3346-11e8-9ecd-9624ad1a68b7.png;>
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377110497
 
 
   with skywalking 5.0 show: 
   https://user-images.githubusercontent.com/7055460/38068664-fa494088-3344-11e8-9572-b721ee1f51ed.png;>
   https://user-images.githubusercontent.com/7055460/38068668-01e7b8ec-3345-11e8-94ff-7f9a7b76277d.png;>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377110497
 
 
   we can't see user topology if there are no ExitSpan:
   actual topology is : user--> dubbo-provider2 --> redis
   https://user-images.githubusercontent.com/7055460/38068664-fa494088-3344-11e8-9572-b721ee1f51ed.png;>
   https://user-images.githubusercontent.com/7055460/38068668-01e7b8ec-3345-11e8-94ff-7f9a7b76277d.png;>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

coveralls commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-369194516
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16238676/badge)](https://coveralls.io/builds/16238676)
   
   Coverage increased (+0.03%) to 19.29% when pulling 
**86a10fca8486803e91d5f14ee8d65d9a5245a506 on 
carlvine500:jdk-cross-thread-plugin** into 
**4a8372b9f5a349dac6dd7fc16eede0f30b11df33 on apache:master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0 (3rd round)

[Yuntao Li]

On 2018/03/28 02:43:06, Sheng Wu  wrote: 
> Hi All,
> This is a call for vote to release Apache SkyWalking (Incubating) version 
> 5.0.0-alpha.
> 
> Release notes:
> 
>  * https://github.com/apache/incubator-skywalking/blob/v5.0.0-alpha/CHANGES.md
> 
> Release Candidate:
> 
>  * https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha/
> 
> Maven 2 staging repository:
> 
>  * 
> https://repository.apache.org/content/repositories/orgapacheskywalking-1010/org/apache/skywalking/
> 
> Release Tag :
> 
>  * 5.0.0-alpha
> 
> Release CommitID :
> 
>  * 476ae378bed24690628cc0d16108185b7b5580b6
> 
> Keys to verify the Release Candidate :
> 
>  * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777 
>  * 
> https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha/KEYS
> 
> corresponding to pen...@apache.org
> 
> Guide to build the release from source :
> 
>  * 
> https://github.com/apache/incubator-skywalking/blob/v5.0.0-alpha/docs/en/How-to-build.md#build-from-apache-source-codes
> 
> Voting will start now (March 28th 2018) and will remain open for at least 72 
> hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because
> 

Hi  All

+1

I had checked the following items: 
1. Features test is passed.
2. All artifacts in staging repository are published with .asc, .md5 , *sha1 
files.
3. Source codes are successfully built. 
4. running "mvn apache-rat:check" passed. 

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377096941
 
 
   @carlvine500 Take your time. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-377096204
 
 
   @wu-sheng sorry , merge is dangerous , I have reset it to old version . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng opened a new issue #998: GraphQL type AppServerInfo#name rename and redefine.

[GitBox]

wu-sheng opened a new issue #998: GraphQL type AppServerInfo#name rename and 
redefine.
URL: https://github.com/apache/incubator-skywalking/issues/998
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   - [x] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Bug
   `AppServerInfo#name` is ambiguity, and the value in current implementation 
is `applicationCode` + `ipv4`, which is meanless, and even is required, it 
should be built in frontend.
   
   So I proposal to rename field `name` to `osName` in type `AppServerInfo`. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0 (3rd round)

[peng-yongsheng]

+1 (binding)

Checked list:
1. Features test.   √
2. staging repository√
3. distribution package  √
4. LICENSE and NOTICE   √
5. source package check √
6. apache-rat:check √
7. DISCLAIMER exists checked   √

—
Yongsheng Peng
Apache SkyWalking PPMC member



> 在 2018年3月28日，22:07，吴晟 Sheng Wu  写道：
> 
> +1 (binding)
> 
> I had checked the following items:
> 1. All test cases is passed.
> 2. All artifacts in staging repository are published with .asc, .md5 , *sha1 
> files.
> 3. All files in https://dist.apache.org/repos/dist/dev/incubator/
> skywalking/5.0.0-alpha/ are verified by GPG and sha512sum.
> 4. Source codes are successfully built.
> 5. Both source and binary packages contains LICENSE and NOTICE files. And 
> LICENSE and NOTICE files are separated by different purposes.
> 6. No error found after running "mvn apache-rat:check".
> 7. DISCLAIMER exists checked.
> 
> 
> --
> Sheng Wu
> Apache SkyWalking original creator and PPMC member
> 
> 
> 
> 
> 
> 
> 
> -- Original --
> From:  "Hongtao Gao";
> Date:  Wed, Mar 28, 2018 09:05 PM
> To:  "dev";
> 
> Subject:  Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0 
> (3rd round)
> 
> 
> 
> +1 (binding)
> 
> I had checked the following items:
> 1. All test cases is passed.
> 2. All artifacts in staging repository are published with .asc, .md5 ,
> *sha1 files.
> 2. All files in https://dist.apache.org/repos/dist/dev/incubator/
> skywalking/5.0.0-alpha/ are verified by GPG and sha512sum.
> 3. Source codes are successfully built.
> 4. Both source and binary packages contains LICENSE and NOTICE files.
> 5. No error found after running "mvn apache-rat:check".
> 
> --
> Gao Hongtao
> Apache SkyWalking PPMC member
> 
> 
> 2018-03-28 18:49 GMT+08:00 xin zhang :
> 
>> Hi All
>> 
>> +1 (binding)
>> 
>> Here is my check stuff:
>> [x] Features tested.
>> [x] Source code package and distribution package are published.
>> [x] all publish packaged with asc file and sha512 file.
>> [x] The asc file and sha512 file checked.
>> [x] LICENSE and NOTICE checked.
>> [x] build distribution from source code package successful.
>> [x] apache rat checked.
>> [x] DISCLAIMER exists checked.
>> 
>> Regards
>> 
>> Xin
>> 
>> 
>>> 在 2018年3月28日，10:43，Sheng Wu  写道：
>>> 
>>> Hi All,
>>> This is a call for vote to release Apache SkyWalking (Incubating)
>> version 5.0.0-alpha.
>>> 
>>> Release notes:
>>> 
>>> * https://github.com/apache/incubator-skywalking/blob/v5.
>> 0.0-alpha/CHANGES.md
>>> 
>>> Release Candidate:
>>> 
>>> * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
>> 5.0.0-alpha/
>>> 
>>> Maven 2 staging repository:
>>> 
>>> * https://repository.apache.org/content/repositories/
>> orgapacheskywalking-1010/org/apache/skywalking/
>>> 
>>> Release Tag :
>>> 
>>> * 5.0.0-alpha
>>> 
>>> Release CommitID :
>>> 
>>> * 476ae378bed24690628cc0d16108185b7b5580b6
>>> 
>>> Keys to verify the Release Candidate :
>>> 
>>> * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777
>>> * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
>> 5.0.0-alpha/KEYS
>>> 
>>> corresponding to pen...@apache.org
>>> 
>>> Guide to build the release from source :
>>> 
>>> * https://github.com/apache/incubator-skywalking/blob/v5.
>> 0.0-alpha/docs/en/How-to-build.md#build-from-apache-source-codes
>>> 
>>> Voting will start now (March 28th 2018) and will remain open for at
>> least 72 hours, Request all PPMC members to give their vote.
>>> [ ] +1 Release this package.
>>> [ ] +0 No opinion.
>>> [ ] -1 Do not release this package because
>> 

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0 (3rd round)

[???? Sheng Wu]

+1 (binding)

I had checked the following items:
1. All test cases is passed.
2. All artifacts in staging repository are published with .asc, .md5 , *sha1 
files.
3. All files in https://dist.apache.org/repos/dist/dev/incubator/
skywalking/5.0.0-alpha/ are verified by GPG and sha512sum.
4. Source codes are successfully built.
5. Both source and binary packages contains LICENSE and NOTICE files. And 
LICENSE and NOTICE files are separated by different purposes.
6. No error found after running "mvn apache-rat:check".
7. DISCLAIMER exists checked.


--
Sheng Wu
Apache SkyWalking original creator and PPMC member


 




-- Original --
From:  "Hongtao Gao";
Date:  Wed, Mar 28, 2018 09:05 PM
To:  "dev";

Subject:  Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0 (3rd 
round)



+1 (binding)

I had checked the following items:
1. All test cases is passed.
2. All artifacts in staging repository are published with .asc, .md5 ,
*sha1 files.
2. All files in https://dist.apache.org/repos/dist/dev/incubator/
skywalking/5.0.0-alpha/ are verified by GPG and sha512sum.
3. Source codes are successfully built.
4. Both source and binary packages contains LICENSE and NOTICE files.
5. No error found after running "mvn apache-rat:check".

--
Gao Hongtao
Apache SkyWalking PPMC member


2018-03-28 18:49 GMT+08:00 xin zhang :

> Hi All
>
> +1 (binding)
>
> Here is my check stuff:
> [x] Features tested.
> [x] Source code package and distribution package are published.
> [x] all publish packaged with asc file and sha512 file.
> [x] The asc file and sha512 file checked.
> [x] LICENSE and NOTICE checked.
> [x] build distribution from source code package successful.
> [x] apache rat checked.
> [x] DISCLAIMER exists checked.
>
> Regards
>
> Xin
>
>
> > ?? 2018??3??2810:43??Sheng Wu  ??
> >
> > Hi All,
> > This is a call for vote to release Apache SkyWalking (Incubating)
> version 5.0.0-alpha.
> >
> > Release notes:
> >
> > * https://github.com/apache/incubator-skywalking/blob/v5.
> 0.0-alpha/CHANGES.md
> >
> > Release Candidate:
> >
> > * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> 5.0.0-alpha/
> >
> > Maven 2 staging repository:
> >
> > * https://repository.apache.org/content/repositories/
> orgapacheskywalking-1010/org/apache/skywalking/
> >
> > Release Tag :
> >
> > * 5.0.0-alpha
> >
> > Release CommitID :
> >
> > * 476ae378bed24690628cc0d16108185b7b5580b6
> >
> > Keys to verify the Release Candidate :
> >
> > * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777
> > * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> 5.0.0-alpha/KEYS
> >
> > corresponding to pen...@apache.org
> >
> > Guide to build the release from source :
> >
> > * https://github.com/apache/incubator-skywalking/blob/v5.
> 0.0-alpha/docs/en/How-to-build.md#build-from-apache-source-codes
> >
> > Voting will start now (March 28th 2018) and will remain open for at
> least 72 hours, Request all PPMC members to give their vote.
> > [ ] +1 Release this package.
> > [ ] +0 No opinion.
> > [ ] -1 Do not release this package because
>
>

[GitHub] coveralls commented on issue #997: Support setting override through system.properties and envs.

[GitBox]

coveralls commented on issue #997: Support setting override through 
system.properties and envs.
URL: 
https://github.com/apache/incubator-skywalking/pull/997#issuecomment-376886214
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/16223567/badge)](https://coveralls.io/builds/16223567)
   
   Coverage remained the same at 19.256% when pulling 
**4a274c13f05aced9d9a6bedaced8e83cf073913a on feature/override-setting** into 
**4a8372b9f5a349dac6dd7fc16eede0f30b11df33 on master**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0 (3rd round)

[Hongtao Gao]

+1 (binding)

I had checked the following items:
1. All test cases is passed.
2. All artifacts in staging repository are published with .asc, .md5 ,
*sha1 files.
2. All files in https://dist.apache.org/repos/dist/dev/incubator/
skywalking/5.0.0-alpha/ are verified by GPG and sha512sum.
3. Source codes are successfully built.
4. Both source and binary packages contains LICENSE and NOTICE files.
5. No error found after running "mvn apache-rat:check".

--
Gao Hongtao
Apache SkyWalking PPMC member


2018-03-28 18:49 GMT+08:00 xin zhang :

> Hi All
>
> +1 (binding)
>
> Here is my check stuff:
> [x] Features tested.
> [x] Source code package and distribution package are published.
> [x] all publish packaged with asc file and sha512 file.
> [x] The asc file and sha512 file checked.
> [x] LICENSE and NOTICE checked.
> [x] build distribution from source code package successful.
> [x] apache rat checked.
> [x] DISCLAIMER exists checked.
>
> Regards
>
> Xin
>
>
> > 在 2018年3月28日，10:43，Sheng Wu  写道：
> >
> > Hi All,
> > This is a call for vote to release Apache SkyWalking (Incubating)
> version 5.0.0-alpha.
> >
> > Release notes:
> >
> > * https://github.com/apache/incubator-skywalking/blob/v5.
> 0.0-alpha/CHANGES.md
> >
> > Release Candidate:
> >
> > * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> 5.0.0-alpha/
> >
> > Maven 2 staging repository:
> >
> > * https://repository.apache.org/content/repositories/
> orgapacheskywalking-1010/org/apache/skywalking/
> >
> > Release Tag :
> >
> > * 5.0.0-alpha
> >
> > Release CommitID :
> >
> > * 476ae378bed24690628cc0d16108185b7b5580b6
> >
> > Keys to verify the Release Candidate :
> >
> > * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777
> > * https://dist.apache.org/repos/dist/dev/incubator/skywalking/
> 5.0.0-alpha/KEYS
> >
> > corresponding to pen...@apache.org
> >
> > Guide to build the release from source :
> >
> > * https://github.com/apache/incubator-skywalking/blob/v5.
> 0.0-alpha/docs/en/How-to-build.md#build-from-apache-source-codes
> >
> > Voting will start now (March 28th 2018) and will remain open for at
> least 72 hours, Request all PPMC members to give their vote.
> > [ ] +1 Release this package.
> > [ ] +0 No opinion.
> > [ ] -1 Do not release this package because
>
>

[GitHub] wu-sheng commented on issue #845: add jdk-cross-thread-plugin

[GitBox]

wu-sheng commented on issue #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#issuecomment-376875153
 
 
   @carlvine500 CI fails...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache SkyWalking (incubating) version 5.0.0 (3rd round)

[xin zhang]

Hi All

+1 (binding)

Here is my check stuff:
[x] Features tested.
[x] Source code package and distribution package are published.
[x] all publish packaged with asc file and sha512 file.
[x] The asc file and sha512 file checked.
[x] LICENSE and NOTICE checked.
[x] build distribution from source code package successful.
[x] apache rat checked.
[x] DISCLAIMER exists checked.

Regards

Xin


> 在 2018年3月28日，10:43，Sheng Wu  写道：
> 
> Hi All,
> This is a call for vote to release Apache SkyWalking (Incubating) version 
> 5.0.0-alpha.
> 
> Release notes:
> 
> * https://github.com/apache/incubator-skywalking/blob/v5.0.0-alpha/CHANGES.md
> 
> Release Candidate:
> 
> * https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha/
> 
> Maven 2 staging repository:
> 
> * 
> https://repository.apache.org/content/repositories/orgapacheskywalking-1010/org/apache/skywalking/
> 
> Release Tag :
> 
> * 5.0.0-alpha
> 
> Release CommitID :
> 
> * 476ae378bed24690628cc0d16108185b7b5580b6
> 
> Keys to verify the Release Candidate :
> 
> * http://pgp.mit.edu:11371/pks/lookup?op=get=0x2EF5026E70A55777 
> * https://dist.apache.org/repos/dist/dev/incubator/skywalking/5.0.0-alpha/KEYS
> 
> corresponding to pen...@apache.org
> 
> Guide to build the release from source :
> 
> * 
> https://github.com/apache/incubator-skywalking/blob/v5.0.0-alpha/docs/en/How-to-build.md#build-from-apache-source-codes
> 
> Voting will start now (March 28th 2018) and will remain open for at least 72 
> hours, Request all PPMC members to give their vote.
> [ ] +1 Release this package.
> [ ] +0 No opinion.
> [ ] -1 Do not release this package because

[GitHub] wu-sheng opened a new pull request #997: Support setting override through system.properties and envs.

[GitBox]

wu-sheng opened a new pull request #997: Support setting override through 
system.properties and envs.
URL: https://github.com/apache/incubator-skywalking/pull/997
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [ ] Bug fix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #933 
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   Override setting by system.properties and system.envs if the key matches 
`moduleName.provideName.settingKey`.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

wu-sheng commented on a change in pull request #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177655233
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableInvokeInterceptor.java
 ##
 @@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import java.lang.reflect.Method;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableInvokeInterceptor implements 
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes,
+MethodInterceptResult result) throws Throwable {
+ContextManager.createLocalSpan("Thread/run");
 
 Review comment:
   Then I am OK with that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on a change in pull request #845: add 
jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177648709
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableInvokeInterceptor.java
 ##
 @@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import java.lang.reflect.Method;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableInvokeInterceptor implements 
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes,
+MethodInterceptResult result) throws Throwable {
+ContextManager.createLocalSpan("Thread/run");
 
 Review comment:
   @wu-sheng 
   method#getName return run or call 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on issue #996: Tomcat and Dubbo Monitoring

[GitBox]

wu-sheng commented on issue #996: Tomcat and Dubbo Monitoring
URL: 
https://github.com/apache/incubator-skywalking/issues/996#issuecomment-376775581
 
 
   Oh, happy you solve 1) by yourself, good work.
   
   For 3.2.6, or 5.x, no settings required for JVM metrics. Can you provide 
some screenshots of `Application Instance`, and what shows after you clicked an 
instance in that page.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wu-sheng commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

wu-sheng commented on a change in pull request #845: add jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177647848
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableInvokeInterceptor.java
 ##
 @@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import java.lang.reflect.Method;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableInvokeInterceptor implements 
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes,
+MethodInterceptResult result) throws Throwable {
+ContextManager.createLocalSpan("Thread/run");
 
 Review comment:
   @carlvine500 `method#getName` always return **run** right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on a change in pull request #845: add 
jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177647237
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableConstructInterceptor.java
 ##
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableConstructInterceptor implements 
InstanceConstructorInterceptor {
+@Override public void onConstruct(EnhancedInstance objInst, Object[] 
allArguments) {
+ContextCarrier contextCarrier = new ContextCarrier();
+AbstractSpan span = ContextManager.createExitSpan("JDK/Thread/run", 
contextCarrier, Thread.currentThread().getName());
 
 Review comment:
   @ascrutae 
   do you think it's better , this code is diffrent from 
CallableOrRunnableConstructInterceptor:
   `ContextManager.createLocalSpan("Thread/" + objInst.getClass().getName() + 
"/" + method.getName())`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on a change in pull request #845: add 
jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177647396
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableInvokeInterceptor.java
 ##
 @@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import java.lang.reflect.Method;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableInvokeInterceptor implements 
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes,
+MethodInterceptResult result) throws Throwable {
+ContextManager.createLocalSpan("Thread/run");
 
 Review comment:
   @ascrutae
   do you think it's better , this code is diffrent from 
CallableOrRunnableConstructInterceptor:
   ContextManager.createLocalSpan("Thread/" + objInst.getClass().getName() + 
"/" + method.getName())


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on a change in pull request #845: add 
jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177647237
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableConstructInterceptor.java
 ##
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableConstructInterceptor implements 
InstanceConstructorInterceptor {
+@Override public void onConstruct(EnhancedInstance objInst, Object[] 
allArguments) {
+ContextCarrier contextCarrier = new ContextCarrier();
+AbstractSpan span = ContextManager.createExitSpan("JDK/Thread/run", 
contextCarrier, Thread.currentThread().getName());
 
 Review comment:
   @ascrutae 
   do you think it's better , this code is diffrent from 
CallableOrRunnableConstructInterceptor:
   `ContextManager.createLocalSpan("Thread/" + objInst.getClass().getName() + 
"/" + method.getName())`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on a change in pull request #845: add 
jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177646303
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableConstructInterceptor.java
 ##
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import org.apache.skywalking.apm.agent.core.context.ContextCarrier;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.trace.AbstractSpan;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableConstructInterceptor implements 
InstanceConstructorInterceptor {
+@Override public void onConstruct(EnhancedInstance objInst, Object[] 
allArguments) {
+ContextCarrier contextCarrier = new ContextCarrier();
+AbstractSpan span = ContextManager.createExitSpan("JDK/Thread/run", 
contextCarrier, Thread.currentThread().getName());
 
 Review comment:
   I will try to change to 
   `ContextManager.createLocalSpan("Thread/" + objInst.getClass().getName())`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on a change in pull request #845: add 
jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177646307
 
 

 ##
 File path: 
apm-sniffer/apm-sdk-plugin/jdk-cross-thread-plugin/src/main/java/org/apache/skywalking/apm/plugin/jdk/thread/CallableOrRunnableInvokeInterceptor.java
 ##
 @@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.plugin.jdk.thread;
+
+import java.lang.reflect.Method;
+import org.apache.skywalking.apm.agent.core.context.ContextManager;
+import org.apache.skywalking.apm.agent.core.context.ContextSnapshot;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceMethodsAroundInterceptor;
+import 
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.MethodInterceptResult;
+
+/**
+ * @author carlvine500
+ */
+public class CallableOrRunnableInvokeInterceptor implements 
InstanceMethodsAroundInterceptor {
+@Override
+public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class[] argumentsTypes,
+MethodInterceptResult result) throws Throwable {
+ContextManager.createLocalSpan("Thread/run");
 
 Review comment:
   I will try to change to 
   `ContextManager.createLocalSpan("Thread/" + objInst.getClass().getName())`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlvine500 commented on a change in pull request #845: add jdk-cross-thread-plugin

[GitBox]

carlvine500 commented on a change in pull request #845: add 
jdk-cross-thread-plugin
URL: 
https://github.com/apache/incubator-skywalking/pull/845#discussion_r177645427
 
 

 ##
 File path: 
apm-application-toolkit/apm-toolkit-trace/src/main/java/org/apache/skywalking/apm/toolkit/trace/CallableWrapper.java
 ##
 @@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.skywalking.apm.toolkit.trace;
+
+import java.util.concurrent.Callable;
+
+/**
+ * @author carlvine500
+ */
+@TraceCrossThread
+public class CallableWrapper implements Callable {
+Callable callable;
 
 Review comment:
   `final Callable callable;` is efficient . I'll change it


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services