Re: [DISCUSS] Heading to graduation
Look like the discussion is very positive from [1]. I will start the vote soon, besides that, I will proposal two things, 1. I volunteer to be SkyWalking VP. And be clear, VP means SkyWalking secretory only, no more power than that. 2. Proposal to move the PPMCs and mentors to PMC, committer to committer [1] https://github.com/apache/incubator-skywalking/issues/1768 -- Sheng Wu Apache SkyWalking -- Original -- From: " Sheng Wu"; Date: Tue, Oct 16, 2018 10:56 AM To: "dev"; Subject: Re: [DISCUSS] Heading to graduation Thanks Willem. From my stats, Just in the main repo, our code contributor grows from 18 to 64. I am very exciting about this growing. I also comments in this GitHub discussion issue[1] [1] https://github.com/apache/incubator-skywalking/issues/1768#issuecomment-430081056 -- Sheng Wu Apache SkyWalking -- Original -- From: "willem.jiang"; Date: Tue, Oct 16, 2018 10:08 AM To: "dev"; Subject: Re: [DISCUSS] Heading to graduation I just want to add one more note, It's great to see Skywalking already build a very lively community by attracting more than 30 contributors[1] in one year of incubating. I think SkyWalking is in a very good track to the graduation. [1]https://github.com/apache/incubator-skywalking/graphs/contributors Regards, Willem Jiang Twitter: willemjiang Weibo: willem On Tue, Oct 16, 2018 at 9:02 AM With Lin wrote: > > +1 > > Sheng Wu ??2018??10??15?? 11:11?? > > > With the SkyWalking 5.0.0 alpha, beta, beta2, and RC release officially > > out. > > GA is under voting in IPMC already > > We believe it is time to discuss what requirements remain to consider > > graduation to the TLP. > > > > > > http://skywalking.incubator.apache.org/ > > > > > > Apache SkyWalking entered incubation in December of 2017, SkyWalking > > community learned a lot about how to do things in Apache ways. > > Now we are a very helpful and engaged community, ready to help on all > > questions from the SkyWalking Community. > > We are making consensus decisions through the discussion in the mailing > > list, voted 1 new committer, also voted 1 new PPMC member. > > We managed delivered 4 releases of source codes and binary already > > , now we can do self-driving releases in good cadence. > > > > > > Please check out the maturity assessment doc[1] for more information. > > > > > > [1] > > https://cwiki.apache.org/confluence/display/SKYWALKING/Apache+Maturity+Model+Assessment+for+SkyWalking > > > > > > > > Any thoughts? And welcome advice from SkyWalking Mentors? > > > > > > Also this discussion happens in GitHub issue[2], considering more people > > show up in there. > > > > > > [2] https://github.com/apache/incubator-skywalking/issues/1768 > > > > > > Regards > > > > > > > > -- > > Sheng Wu > > Apache SkyWalking
Re: [DISCUSS] Heading to graduation
+1 This is really good news. I'm sure that Wu Sheng will be a best VP. 吴晟 Sheng Wu 于2018年10月22日周一 下午11:18写道： > Look like the discussion is very positive from [1]. I will start the vote > soon, besides that, I will proposal two things, > > > 1. I volunteer to be SkyWalking VP. And be clear, VP means SkyWalking > secretory only, no more power than that. > 2. Proposal to move the PPMCs and mentors to PMC, committer to committer > > > > [1] https://github.com/apache/incubator-skywalking/issues/1768 > > > -- > Sheng Wu > Apache SkyWalking > > > > > > > > -- Original -- > From: "吴晟 Sheng Wu"; > Date: Tue, Oct 16, 2018 10:56 AM > To: "dev"; > > Subject: Re: [DISCUSS] Heading to graduation > > > > Thanks Willem. From my stats, Just in the main repo, our code contributor > grows from 18 to 64. I am very exciting about this growing. > > > I also comments in this GitHub discussion issue[1] > > > [1] > https://github.com/apache/incubator-skywalking/issues/1768#issuecomment-430081056 > > > -- > Sheng Wu > Apache SkyWalking > > > > > > > > -- Original -- > From: "willem.jiang"; > Date: Tue, Oct 16, 2018 10:08 AM > To: "dev"; > > Subject: Re: [DISCUSS] Heading to graduation > > > > I just want to add one more note, > It's great to see Skywalking already build a very lively community by > attracting more than 30 contributors[1] in one year of incubating. > > I think SkyWalking is in a very good track to the graduation. > > [1]https://github.com/apache/incubator-skywalking/graphs/contributors > > Regards, > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > On Tue, Oct 16, 2018 at 9:02 AM With Lin wrote: > > > > +1 > > > > 吴晟 Sheng Wu 于2018年10月15日周一 下午11:11写道： > > > > > With the SkyWalking 5.0.0 alpha, beta, beta2, and RC release officially > > > out. > > > GA is under voting in IPMC already > > > We believe it is time to discuss what requirements remain to consider > > > graduation to the TLP. > > > > > > > > > http://skywalking.incubator.apache.org/ > > > > > > > > > Apache SkyWalking entered incubation in December of 2017, SkyWalking > > > community learned a lot about how to do things in Apache ways. > > > Now we are a very helpful and engaged community, ready to help on all > > > questions from the SkyWalking Community. > > > We are making consensus decisions through the discussion in the mailing > > > list, voted 1 new committer, also voted 1 new PPMC member. > > > We managed delivered 4 releases of source codes and binary already > > > , now we can do self-driving releases in good cadence. > > > > > > > > > Please check out the maturity assessment doc[1] for more information. > > > > > > > > > [1] > > > > https://cwiki.apache.org/confluence/display/SKYWALKING/Apache+Maturity+Model+Assessment+for+SkyWalking > > > > > > > > > > > > Any thoughts? And welcome advice from SkyWalking Mentors? > > > > > > > > > Also this discussion happens in GitHub issue[2], considering more > people > > > show up in there. > > > > > > > > > [2] https://github.com/apache/incubator-skywalking/issues/1768 > > > > > > > > > Regards > > > > > > > > > > > > -- > > > Sheng Wu > > > Apache SkyWalking
[GitHub] wu-sheng closed pull request #11: Add copyFrom method for complex data type.
wu-sheng closed pull request #11: Add copyFrom method for complex data type.
URL: https://github.com/apache/incubator-skywalking-oal-tool/pull/11
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl
b/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl
index 6f8240e..3245422 100644
--- a/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl
+++ b/oal-parser/src/main/resources/code-templates/IndicatorImplementor.ftl
@@ -178,15 +178,26 @@ public class ${metricName}Indicator extends
${indicatorClassName} implements Ala
@Override
public Indicator toHour() {
${metricName}Indicator indicator = new ${metricName}Indicator();
-indicator.setTimeBucket(toTimeBucketInHour());
<#list fieldsFromSource as field>
-<#if field.columnName != "time_bucket">
+<#if field.columnName == "time_bucket">
+indicator.setTimeBucket(toTimeBucketInHour());
+<#elseif field.typeName == "java.lang.String" || field.typeName == "long"
|| field.typeName == "int" || field.typeName == "double" || field.typeName ==
"float">
indicator.${field.fieldSetter}(this.${field.fieldGetter}());
+<#else>
+${field.typeName} newValue = new ${field.typeName}();
+newValue.copyFrom(this.${field.fieldGetter}());
+indicator.${field.fieldSetter}(newValue);
<#list persistentFields as field>
-<#if field.columnName != "time_bucket">
+<#if field.columnName == "time_bucket">
+indicator.setTimeBucket(toTimeBucketInHour());
+<#elseif field.typeName == "java.lang.String" || field.typeName == "long"
|| field.typeName == "int" || field.typeName == "double" || field.typeName ==
"float">
indicator.${field.fieldSetter}(this.${field.fieldGetter}());
+<#else>
+${field.typeName} newValue = new ${field.typeName}();
+newValue.copyFrom(this.${field.fieldGetter}());
+indicator.${field.fieldSetter}(newValue);
return indicator;
@@ -195,15 +206,26 @@ public class ${metricName}Indicator extends
${indicatorClassName} implements Ala
@Override
public Indicator toDay() {
${metricName}Indicator indicator = new ${metricName}Indicator();
-indicator.setTimeBucket(toTimeBucketInDay());
<#list fieldsFromSource as field>
-<#if field.columnName != "time_bucket">
+<#if field.columnName == "time_bucket">
+indicator.setTimeBucket(toTimeBucketInDay());
+<#elseif field.typeName == "java.lang.String" || field.typeName == "long"
|| field.typeName == "int" || field.typeName == "double" || field.typeName ==
"float">
indicator.${field.fieldSetter}(this.${field.fieldGetter}());
+<#else>
+${field.typeName} newValue = new ${field.typeName}();
+newValue.copyFrom(this.${field.fieldGetter}());
+indicator.${field.fieldSetter}(newValue);
<#list persistentFields as field>
-<#if field.columnName != "time_bucket">
+<#if field.columnName == "time_bucket">
+indicator.setTimeBucket(toTimeBucketInDay());
+<#elseif field.typeName == "java.lang.String" || field.typeName == "long"
|| field.typeName == "int" || field.typeName == "double" || field.typeName ==
"float">
indicator.${field.fieldSetter}(this.${field.fieldGetter}());
+<#else>
+${field.typeName} newValue = new ${field.typeName}();
+newValue.copyFrom(this.${field.fieldGetter}());
+indicator.${field.fieldSetter}(newValue);
return indicator;
@@ -212,15 +234,26 @@ public class ${metricName}Indicator extends
${indicatorClassName} implements Ala
@Override
public Indicator toMonth() {
${metricName}Indicator indicator = new ${metricName}Indicator();
-indicator.setTimeBucket(toTimeBucketInMonth());
<#list fieldsFromSource as field>
-<#if field.columnName != "time_bucket">
+<#if field.columnName == "time_bucket">
+indicator.setTimeBucket(toTimeBucketInMonth());
+<#elseif field.typeName == "java.lang.String" || field.typeName == "long"
|| field.typeName == "int" || field.typeName == "double" || field.typeName ==
"float">
indicator.${field.fieldSetter}(this.${field.fieldGetter}());
+<#else>
+${field.typeName} newValue = new ${field.typeName}();
+newValue.copyFrom(this.${field.fieldGetter}());
+indicator.${field.fieldSetter}(newValue);
<#list persistentFields as field>
-<#if field.columnName != "time_bucket">
+<#if field.columnName == "time_bucket">
+indicator.setTimeBucket(toTimeBucketInMonth());
+<#elseif field.typeName == "java.lang.String" || field.typeName == "long"
|| field.typeName ==
