[GitHub] wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module.
wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module. URL: https://github.com/apache/incubator-skywalking/pull/871#discussion_r178456099 ## File path: apm-collector/apm-collector-boot/src/main/resources/application.yml ## @@ -34,18 +34,27 @@ ui: host: localhost port: 12800 context_path: / -storage: - elasticsearch: -cluster_name: CollectorDBCluster -cluster_transport_sniffer: true -cluster_nodes: localhost:9300 -index_shards_number: 2 -index_replicas_number: 0 -ttl: 7 #storage: -# h2: -#url: jdbc:h2:tcp://localhost/~/test -#user_name: sa +# elasticsearch: +#cluster_name: elasticsearch +#cluster_transport_sniffer: true +#cluster_nodes: 10.126.94.37:9300 +#index_shards_number: 2 +#index_replicas_number: 0 +#ttl: 7 +#storage: +# elasticsearch-http: +#cluster_name: elasticsearch +#cluster_nodes: 10.126.94.37:9200 +#index_shards_number: 2 +#ssl : false +#index_replicas_number: 0 +#username : admin +#password : admin +storage: + h2: +url: jdbc:h2:tcp://localhost/~/test +user_name: sa Review comment: h2 is not provided in alpha, so we can't use this as default. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module.
wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module. URL: https://github.com/apache/incubator-skywalking/pull/871#discussion_r178456138 ## File path: apm-collector/apm-collector-boot/src/main/resources/application.yml ## @@ -34,18 +34,27 @@ ui: host: localhost port: 12800 context_path: / -storage: - elasticsearch: -cluster_name: CollectorDBCluster -cluster_transport_sniffer: true -cluster_nodes: localhost:9300 -index_shards_number: 2 -index_replicas_number: 0 -ttl: 7 #storage: -# h2: -#url: jdbc:h2:tcp://localhost/~/test -#user_name: sa +# elasticsearch: +#cluster_name: elasticsearch +#cluster_transport_sniffer: true +#cluster_nodes: 10.126.94.37:9300 +#index_shards_number: 2 +#index_replicas_number: 0 +#ttl: 7 +#storage: +# elasticsearch-http: Review comment: Add comment here, to mention this is an incubating feature, and no product use for now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on a change in pull request #871: Add elasticSearch-http storage module.
wu-sheng commented on a change in pull request #871: Add elasticSearch-http
storage module.
URL:
https://github.com/apache/incubator-skywalking/pull/871#discussion_r178456173
##
File path: apm-collector/apm-collector-component/client-component/pom.xml
##
@@ -17,94 +17,99 @@
~
-->
-http://maven.apache.org/POM/4.0.0";
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-
-apm-collector-component
-org.apache.skywalking
-5.0.0-alpha-SNAPSHOT
-
-4.0.0
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+
+ apm-collector-component
+ org.apache.skywalking
+ 5.0.0-alpha-SNAPSHOT
+
+ 4.0.0
-client-component
-jar
-
-
-com.h2database
-h2
-1.4.196
-
-
-redis.clients
-jedis
-2.9.0
-
-
-org.elasticsearch.client
-transport
-5.5.0
-
-
-snakeyaml
-org.yaml
-
-
-netty-common
-io.netty
-
-
-netty-transport
-io.netty
-
-
-netty-codec
-io.netty
-
-
-netty-codec-http
-io.netty
-
-
-netty-buffer
-io.netty
-
-
-netty-handler
-io.netty
-
-
-netty-resolver
-io.netty
-
-
-
-
-org.apache.zookeeper
-zookeeper
-3.4.10
-
-
-slf4j-api
-org.slf4j
-
-
-slf4j-log4j12
-org.slf4j
-
-
-
-
-org.apache.skywalking
-apm-network
-${project.version}
-
-
-guava
-com.google.guava
-
-
-
-
+ client-component
+ jar
+
+
+
+ com.h2database
+ h2
+ 1.4.196
+
+
+ redis.clients
+ jedis
+ 2.9.0
+
+
+ org.elasticsearch.client
+ transport
+ 5.5.0
+
+
+ snakeyaml
+ org.yaml
+
+
+ netty-common
+ io.netty
+
+
+ netty-transport
+ io.netty
+
+
+ netty-codec
+ io.netty
+
+
+
netty-codec-http
+ io.netty
+
+
+ netty-buffer
+ io.netty
+
+
+ netty-handler
+ io.netty
+
+
+ netty-resolver
+ io.netty
+
+
+
+
+ org.apache.zookeeper
+ zookeeper
+ 3.4.10
+
+
+ slf4j-api
+ org.slf4j
+
+
+ slf4j-log4j12
+
