[jira] Resolved: (SLING-1842) IllegalStateException in DefaultErrorHandlerServlet when HttpServletResponse.getOutputStream() already called

[Felix Meschberger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger resolved SLING-1842.
--

Resolution: Fixed

Thanks for the feedback. Thus I think this can be resolved.

> IllegalStateException in DefaultErrorHandlerServlet when 
> HttpServletResponse.getOutputStream() already called
> -
>
> Key: SLING-1842
> URL: https://issues.apache.org/jira/browse/SLING-1842
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Servlets
>Affects Versions: Servlets Resolver 2.1.0, Engine 2.1.0
>Reporter: Carl Hall
>Assignee: Felix Meschberger
> Fix For: Servlets Resolver 2.1.2, Engine 2.1.2
>
> Attachments: SLING-1842.diff
>
>
> When getOutputStream() has been called, DefaultErrorHandlerServlet is unable 
> to write the error page and dumps an exception in the logs.  It'd be nice if 
> it failed a bit more gracefully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: Debugging JavaScript esp files

[Felix Meschberger]

Hi Sandro,

On 19.10.2010 02:39, Sandro Boehme wrote:
> Hi Felix,
> 
> after diving into the topic I got the following understanding. Please
> correct me if I'm wrong.
> o In the Eclipse preferences one needs to map *.esp files to the
> JavaScript content type.

Yes. Likewise for *.ecma. Though I have issues setting breakpoints on
*.esp files because on my box Eclipse tells it cannot resolve the line
number to set the breakpoint on.

> o Now its possible to set a breakpoint in the esp file.
> o Next one needs to load the esp script file in the "Breakpoints" view.
> o Starting the debugger now calls new
> ...jsdt.debug.internal.rhino.jsdi.VirtualMachineImpl() which sends a
> scripts command request [1] to the
> ...jsdt.debug.internal.rhino.debugger.RequestHandler on the server side.
> That handler calls
> ...jsdt.debug.internal.rhino.debugger.RhinoDebuggerImpl.getScriptIds().
> The only location that sets the script id's is the
> handleCompilationDone() method of RhinoDebuggerImpl. I only see that
> indirectly called by
> oas.scripting.javascript.helper.SlingGlobal.require() and .execIdCall().
> As the latter is a method from org.mozilla.javascript.IdFunctionCall
> there are too many possible callers and I cannot easily find out if the
> trigger to load the JavaScript files is already there somewhere.
> 
> I guess we only need to trigger the handleCompilationDone() methode
> somewhere in Sling but I don't know enough about Sling to decide where
> that would fit in or what to configure to make it fit. Maybe it could be
> triggered during
> ...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you
> have an idea?

Actually from my traces I see, that the Eclipse rhino.debugger bundle in
facts replies to the compilationDone event and informs the Eclipse
debugger about this.

Then the Eclipse debugger is probably supposed to send back breakpoints
for the script but fails to do so because of script path issues: Sling
reports script paths as they exist in Sling, e.g.
/apps/sling/nt/folder.html. Eclipse on the other hand (I am creating a
folder linking to a WebDAV mount of Sling) reports the script path as
the project IPath, that is prefixed with the project name and path to
the linked script folder.

In the end the Eclipse debugger is not able to match the script reported
from rhino.debugger in Sling with the script in Eclipse ...

I once debugged this and "hacked" the correct path into and in fact was
able to break a script and step through it. But we probably really need
some way of mapping the script paths ... I just didn't find out how to,
for example, set a prefix to cut off to get the actual script path from
the project's path.

Regards
Felix

> 
> Best,
> 
> Sandro
> 
> [1] - http://wiki.eclipse.org/JSDT/Debug/Rhino_Debug_Wire_Protocol#scripts
> 
> 
> Am 18.10.10 02:58, schrieb Sandro Boehme:
>> Hi Felix,
>>
>> that was fast. I'm impressed.
>> Thanks for the tutorial. I can connect too but the debugger also doesn't
>> stop at my breakpoint like in your case.
>>
>> Best,
>>
>> Sandro
>>
>> PS: Just in case somebody else want to follow: The export in step 5 is
>> "org.mozilla.javascript.debug".
>>
>>
>> Am 17.10.10 23:00, schrieb Felix Meschberger:
>>> Hi,
>>>
>>> On 17.10.2010 20:34, Justin Edelson wrote:
 On Sun, Oct 17, 2010 at 2:28 PM, Felix
 Meschberger wrote:
> Hi,
>
> On 17.10.2010 16:05, Sandro Boehme wrote:
>> Hi Felix,
>>
>> thanks for the feedback.
>> The Swing debugger GUI doesn't seem to work in this case as it cannot
>> open e.g. the explorer.esp file. It says:
>> "Syntax error (.../explorer.esp#83)"
>> This refers to the line containing only "" which is
>> correct in my opinion.
>
> I would expect the line to be correct, but I must admit to not have
> used
> this for quite some time, so ... this may really not properly work
> (unfortunately).
>
>>
>> I also tried the "Eclipse IDE for JavaScript Web Developers" from
>> http://www.eclipse.org/downloads/ as it contains debugging support
>> for
>> Rhino (http://wiki.eclipse.org/JSDT/Debug). But it doesn't work
>> out of
>> the box. Even though it is based on JPDA I guess there needs to be
>> something Rhino specific installed on the serverside.
>
> Sounds interesting. Would be exactly what I had in mind ;-) Will
> investigate.

 It'd be better if this page wasn't blank:
 http://wiki.eclipse.org/JSDT/Debug/Embedding_Rhino_Debugger
>>>
>>> Yes, well, I got it sort of working with a bit hacking 
>>>
>>> 1. deploy two JSDT bundles into Sling:
>>> org.eclipse.wst.jsdt.debug.rhino.debugger
>>> org.eclipse.wst.jsdt.debug.transport
>>> (ignore for now that these bundles use Require-Bundle
>>> and export internals ...)
>>> 2. upgrade Sling Rhino reference to 1.7R2
>>> 3. inside Sling add a dependency to the
>>> org.eclipse.wst.jsdt.debug.rhino.debugger project checked
>>> out from Eclipse CVS
>>> 4. In the Sling

[jira] Assigned: (SLING-1545) ScripteEngineManagerFactory is not thread safe

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-1545:
---

Assignee: Carsten Ziegeler

> ScripteEngineManagerFactory is not thread safe
> --
>
> Key: SLING-1545
> URL: https://issues.apache.org/jira/browse/SLING-1545
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.12
>Reporter: Felix Meschberger
>Assignee: Carsten Ziegeler
> Fix For: Scripting Core 2.0.12
>
>
> The ScriptEngineManagerFactory class is not thread-safe:
>   * Access to the engineSpiBundles, engineSpiServices fields (lists) are not 
> guarded
>   * Calls to refreshScriptEngineManager are not guarded
> This may cause improper states under certain circumstances.
> Accesses to these internal fields and methods should properly be guarded.
> In addition, replacement of the List as collection of the SPI bundles and 
> service by Set should be considered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (SLING-1847) Redirect after logout does not work with form authentication

[Eric Norman (JIRA)]

Redirect after logout does not work with form authentication


 Key: SLING-1847
 URL: https://issues.apache.org/jira/browse/SLING-1847
 Project: Sling
  Issue Type: Bug
  Components: Authentication
Affects Versions: Auth Core 1.0.2, Form Based Authentication 1.0.0
Reporter: Eric Norman


The redirectAfterLogout method of 
org.apache.sling.auth.core.impl.SlingAuthenticator is looking for a request 
attribute or parameter named "resource" to decide where to redirect after 
logout.

But, if there is a request parameter named "resource" on the request, the 
request never makes it to the LogoutServlet because the authenticationSucceeded 
method of the FormAuthenticationHandler is also looking for a request parameter 
with the same name and immediately redirecting to the specified resource which 
terminates the rest of the request processing.  The user is never logged out 
before redirecting to the resource.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: Debugging JavaScript esp files

[Sandro Boehme]

Hi Felix,

after diving into the topic I got the following understanding. Please 
correct me if I'm wrong.
o In the Eclipse preferences one needs to map *.esp files to the 
JavaScript content type.

o Now its possible to set a breakpoint in the esp file.
o Next one needs to load the esp script file in the "Breakpoints" view.
o Starting the debugger now calls new 
...jsdt.debug.internal.rhino.jsdi.VirtualMachineImpl() which sends a 
scripts command request [1] to the 
...jsdt.debug.internal.rhino.debugger.RequestHandler on the server side. 
That handler calls 
...jsdt.debug.internal.rhino.debugger.RhinoDebuggerImpl.getScriptIds(). 
The only location that sets the script id's is the 
handleCompilationDone() method of RhinoDebuggerImpl. I only see that 
indirectly called by 
oas.scripting.javascript.helper.SlingGlobal.require() and .execIdCall(). 
As the latter is a method from org.mozilla.javascript.IdFunctionCall 
there are too many possible callers and I cannot easily find out if the 
trigger to load the JavaScript files is already there somewhere.


I guess we only need to trigger the handleCompilationDone() methode 
somewhere in Sling but I don't know enough about Sling to decide where 
that would fit in or what to configure to make it fit. Maybe it could be 
triggered during 
...scripting.javascript.internal.RhinoJavaScriptEngine.eval(). Do you 
have an idea?


Best,

Sandro

[1] - http://wiki.eclipse.org/JSDT/Debug/Rhino_Debug_Wire_Protocol#scripts


Am 18.10.10 02:58, schrieb Sandro Boehme:

Hi Felix,

that was fast. I'm impressed.
Thanks for the tutorial. I can connect too but the debugger also doesn't
stop at my breakpoint like in your case.

Best,

Sandro

PS: Just in case somebody else want to follow: The export in step 5 is
"org.mozilla.javascript.debug".


Am 17.10.10 23:00, schrieb Felix Meschberger:

Hi,

On 17.10.2010 20:34, Justin Edelson wrote:

On Sun, Oct 17, 2010 at 2:28 PM, Felix
Meschberger wrote:

Hi,

On 17.10.2010 16:05, Sandro Boehme wrote:

Hi Felix,

thanks for the feedback.
The Swing debugger GUI doesn't seem to work in this case as it cannot
open e.g. the explorer.esp file. It says:
"Syntax error (.../explorer.esp#83)"
This refers to the line containing only "" which is
correct in my opinion.


I would expect the line to be correct, but I must admit to not have
used
this for quite some time, so ... this may really not properly work
(unfortunately).



I also tried the "Eclipse IDE for JavaScript Web Developers" from
http://www.eclipse.org/downloads/ as it contains debugging support for
Rhino (http://wiki.eclipse.org/JSDT/Debug). But it doesn't work out of
the box. Even though it is based on JPDA I guess there needs to be
something Rhino specific installed on the serverside.


Sounds interesting. Would be exactly what I had in mind ;-) Will
investigate.


It'd be better if this page wasn't blank:
http://wiki.eclipse.org/JSDT/Debug/Embedding_Rhino_Debugger


Yes, well, I got it sort of working with a bit hacking 

1. deploy two JSDT bundles into Sling:
org.eclipse.wst.jsdt.debug.rhino.debugger
org.eclipse.wst.jsdt.debug.transport
(ignore for now that these bundles use Require-Bundle
and export internals ...)
2. upgrade Sling Rhino reference to 1.7R2
3. inside Sling add a dependency to the
org.eclipse.wst.jsdt.debug.rhino.debugger project checked
out from Eclipse CVS
4. In the SlingContextFactory constructor instantiate a RhinoDebugger
with a connector string (e.g.
"transport=socket,suspend=n,address=9000"), register it as a
listener and start the RhinoDebugger
5. Export org.mozilla.javascript.debugger package and add an
optional import to org.eclipse.wst.jsdt.debug.rhino.debugger in
the pom.xml
6. build and install the Sling Javascript bundle

Now you can connect to this Debugger with Eclipse ... And yes, I can
connect but I cannot yet cope with filenames...

I create a project and a folder linked to a WebDAV mounted Sling folder
and can then set breakpoints. The problem is, that Eclipse seems to
prefix all script names with the project and folder name and thus is not
able to match the names of executed scripts to apply break points ...

Regards
Felix



Justin


Regards
Felix



Best,

Sandro

Am 16.10.10 20:22, schrieb Felix Meschberger:

Hi Sandro,

The best solution (which I once considered working on a long time ago
but never got around to implement) is to have Rhino debugging
support in
Eclipse.

But for now, you may set the
"org.apache.sling.scripting.javascript.debug" framework property
(e.g.
in the sling.properties file) to true. When this property is set
to true
Rhino will launch the Swing debugger GUI (on the server system)
once the
Rhino ScriptEngineFactory is started.

Regards
Felix


On 16.10.2010 15:36, Sandro Boehme wrote:

Hello,

I'm trying to get into the Sling Explorer and I'm wondering how
(or if)
you guys debug these esp scripts? While the Eclipse debugger
stops in
jsp files it doesn't stop in esp files as they don't contain Java
code.
Is there a specia

[jira] Commented: (SLING-1842) IllegalStateException in DefaultErrorHandlerServlet when HttpServletResponse.getOutputStream() already called

[Carl Hall (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1297#action_1297
 ] 

Carl Hall commented on SLING-1842:
--

The changes look great to me.  Thanks for fixing this!

> IllegalStateException in DefaultErrorHandlerServlet when 
> HttpServletResponse.getOutputStream() already called
> -
>
> Key: SLING-1842
> URL: https://issues.apache.org/jira/browse/SLING-1842
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Servlets
>Affects Versions: Servlets Resolver 2.1.0, Engine 2.1.0
>Reporter: Carl Hall
>Assignee: Felix Meschberger
> Fix For: Servlets Resolver 2.1.2, Engine 2.1.2
>
> Attachments: SLING-1842.diff
>
>
> When getOutputStream() has been called, DefaultErrorHandlerServlet is unable 
> to write the error page and dumps an exception in the logs.  It'd be nice if 
> it failed a bit more gracefully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: [VOTE] Initial Content and Servlet Archetypes 1.0.0

[Eric Norman]

+1
Eric

On Oct 15, 2010 7:45 AM, "Justin Edelson"  wrote:

Hi,

This vote is for:
Sling Initial Content Archetype 1.0.0
Sling Servlet Archetype 1.0.0

This is the initial version of each.

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-001/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 001 /tmp/sling-staging

Please vote to approve this release:

 [ ] +1 Approve the release
 [ ]  0 Don't care
 [ ] -1 Don't release, because ...

This vote will be open for 72 hours.

Thanks,
Justin

Scripting Releases

[Carsten Ziegeler]

For Sling-6 we need some releases of scripting stuff. As far as I can
see, there is only a single bug open in this area.

https://issues.apache.org/jira/browse/SLING-1545

As soon as we have this fixed I can take care of releasing this stuff.
Anyone working on this?

Regards
Carsten
-- 
Carsten Ziegeler
cziege...@apache.org

Hudson build is unstable: sling-trunk-1.6 #615

[Apache Hudson Server]

See 

Hudson build is back to normal : sling-tr unk-1.6 » Apache Sling Event Support #615

[Apache Hudson Server]

See 

Re: [VOTE] Initial Content and Servlet Archetypes 1.0.0

[Ian Boston]

+1 
Ian

On 15 Oct 2010, at 15:45, Justin Edelson wrote:

> Hi,
> 
> This vote is for:
> Sling Initial Content Archetype 1.0.0
> Sling Servlet Archetype 1.0.0
> 
> This is the initial version of each.
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-001/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 001 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This vote will be open for 72 hours.
> 
> Thanks,
> Justin

Hudson build is unstable: sling-trunk-1.5 #929

[Apache Hudson Server]

See 

Build failed in Hudson: sling-trunk-1.6 #614

[Apache Hudson Server]

See 

Changes:

[fmeschbe] SLING-1842 Prevent IllegalStateException when trying to get writer to
handle a problem after the response output stream has already been
retrieved.

[cziegeler] Improve webconsole layout and add restart method

[cziegeler] Apache Snapshot directory is missing in Apache parent pom for 
plugins; adding this for the snapshot of the SCR plugin

--
[...truncated 5682 lines...]
at aQute.lib.osgi.Analyzer.getImportPackages(Analyzer.java:248)
at aQute.lib.osgi.Builder.getImportPackages(Builder.java:149)
at aQute.lib.osgi.Analyzer.analyze(Analyzer.java:146)
at aQute.lib.osgi.Builder.analyze(Builder.java:198)
at aQute.lib.osgi.Analyzer.calcManifest(Analyzer.java:283)
at aQute.lib.osgi.Builder.build(Builder.java:78)
at 
org.apache.felix.bundleplugin.BundlePlugin.buildOSGiBundle(BundlePlugin.java:395)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:286)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:240)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:231)
at 
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at 
hudson.maven.agent.PluginManagerInterceptor.executeMojo(PluginManagerInterceptor.java:182)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at 
org.apache.maven.lifecycle.LifecycleExecutorInterceptor.execute(LifecycleExecutorInterceptor.java:65)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at hudson.maven.agent.Main.launch(Main.java:165)
at hudson.maven.MavenBuilder.call(MavenBuilder.java:165)
at 
hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:694)
at 
hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:638)
at hudson.remoting.UserRequest.perform(UserRequest.java:114)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:270)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalArgumentException: Invalid syntax for version: 
$...@}
at aQute.libg.version.Version.(Version.java:45)
at aQute.lib.osgi.Macro._version(Macro.java:627)
... 53 more
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
No translation found for macro: @
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
Exception in replace: java.lang.IllegalArgumentException: Invalid syntax for 
version: $...@}
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
No translation found for macro: version;==;$...@}
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
No translation found for macro: version;=+;$...@}
[INFO] Preparing source:jar
[WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
[HUDSON] Archiving 

Build failed in Hudson: sling-trunk- 1.6 » Apache Sling Event Support #614

[Apache Hudson Server]

See 


Changes:

[cziegeler] Improve webconsole layout and add restart method

--
[INFO] 
[INFO] Building Apache Sling Event Support
[INFO]task-segment: [clean, install]
[INFO] 
Downloading: 
http://repository.apache.org/snapshots/org/apache/felix/maven-scr-plugin/1.4.5-SNAPSHOT/maven-scr-plugin-1.4.5-20101018.070240-2.jar
136K downloaded  (maven-scr-plugin-1.4.5-20101018.070240-2.jar)
[INFO] [clean:clean {execution: default-clean}]
[INFO] Deleting file set: 

 (included: [**], excluded: [])
[INFO] snapshot 
org.apache.felix:org.apache.felix.scr.annotations:1.3.1-SNAPSHOT: checking for 
updates from apache.snapshots
Downloading: 
http://repository.apache.org/snapshots/org/apache/felix/org.apache.felix.scr.annotations/1.3.1-SNAPSHOT/org.apache.felix.scr.annotations-1.3.1-20101018.062411-1.pom
2K downloaded  (org.apache.felix.scr.annotations-1.3.1-20101018.062411-1.pom)
Downloading: 
http://repository.apache.org/snapshots/org/apache/felix/org.apache.felix.scr.annotations/1.3.1-SNAPSHOT/org.apache.felix.scr.annotations-1.3.1-20101018.062411-1.jar
19K downloaded  (org.apache.felix.scr.annotations-1.3.1-20101018.062411-1.jar)
[INFO] [enforcer:enforce {execution: enforce-java}]
[INFO] [groovy:execute {execution: save-bundle-metadata}]
[INFO] [remote-resources:process {execution: default}]
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] [antrun:run {execution: default}]
[INFO] Executing tasks
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 41 source files to 

[INFO] [scr:scr {execution: generate-scr-scrdescriptor}]
[INFO] Generating 10 MetaType Descriptors to 

[INFO] Writing abstract service descriptor 

 with 11 entries.
[INFO] Generating 10 Service Component Descriptors to 

[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] Compiling 14 source files to 

[HUDSON] Archiving 

 to 
/home/hudson/hudson/jobs/sling-trunk-1.6/modules/org.apache.sling$org.apache.sling.event/builds/2010-10-18_09-05-23/archive/org.apache.sling/org.apache.sling.event/3.0.0-SNAPSHOT/pom.xml
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
:[39,59]
  is 
not abstract and does not override abstract method restart() in 
org.apache.sling.event.impl.jobs.JobEvent


[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 
[INFO] Total time: 8 minutes 51 seconds
[INFO] Finished at: Mon Oct 18 09:14:26 UTC 2010
[INFO] F

[jira] Updated: (SLING-1842) IllegalStateException in DefaultErrorHandlerServlet when HttpServletResponse.getOutputStream() already called

[Felix Meschberger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger updated SLING-1842:
-

  Component/s: Engine
Affects Version/s: Servlets Resolver 2.1.0
   Engine 2.1.0
Fix Version/s: Engine 2.1.2
   Servlets Resolver 2.1.2

> IllegalStateException in DefaultErrorHandlerServlet when 
> HttpServletResponse.getOutputStream() already called
> -
>
> Key: SLING-1842
> URL: https://issues.apache.org/jira/browse/SLING-1842
> Project: Sling
>  Issue Type: Bug
>  Components: Engine, Servlets
>Affects Versions: Servlets Resolver 2.1.0, Engine 2.1.0
>Reporter: Carl Hall
>Assignee: Felix Meschberger
> Fix For: Servlets Resolver 2.1.2, Engine 2.1.2
>
> Attachments: SLING-1842.diff
>
>
> When getOutputStream() has been called, DefaultErrorHandlerServlet is unable 
> to write the error page and dumps an exception in the logs.  It'd be nice if 
> it failed a bit more gracefully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SLING-1842) IllegalStateException in DefaultErrorHandlerServlet when HttpServletResponse.getOutputStream() already called

[Felix Meschberger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922022#action_12922022
 ] 

Felix Meschberger commented on SLING-1842:
--

And fixed DefaultErrorHandlerServlet of the Servlet Resolver to only get the 
response writer after setting the character encoding and also reset the 
response before sending back the error message in Rev. 1023693

> IllegalStateException in DefaultErrorHandlerServlet when 
> HttpServletResponse.getOutputStream() already called
> -
>
> Key: SLING-1842
> URL: https://issues.apache.org/jira/browse/SLING-1842
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Carl Hall
>Assignee: Felix Meschberger
> Attachments: SLING-1842.diff
>
>
> When getOutputStream() has been called, DefaultErrorHandlerServlet is unable 
> to write the error page and dumps an exception in the logs.  It'd be nice if 
> it failed a bit more gracefully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SLING-1842) IllegalStateException in DefaultErrorHandlerServlet when HttpServletResponse.getOutputStream() already called

[Felix Meschberger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922017#action_12922017
 ] 

Felix Meschberger commented on SLING-1842:
--

Committed a fix in Rev. 1023692:

  - the RequestProcessorImpl.handleError methods now check whether the response 
is committed before even continuing
  - the response is now wrapped in the handleError methods to fall back to wrap 
the output stream with a print writer if needed

Can you please validate, this works in your case ? thanks.

> IllegalStateException in DefaultErrorHandlerServlet when 
> HttpServletResponse.getOutputStream() already called
> -
>
> Key: SLING-1842
> URL: https://issues.apache.org/jira/browse/SLING-1842
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Carl Hall
>Assignee: Felix Meschberger
> Attachments: SLING-1842.diff
>
>
> When getOutputStream() has been called, DefaultErrorHandlerServlet is unable 
> to write the error page and dumps an exception in the logs.  It'd be nice if 
> it failed a bit more gracefully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Build failed in Hudson: sling-trunk-1.5 #928

[Apache Hudson Server]

See 

Changes:

[cziegeler] Don't throw illegal state exception if queue has been removed in 
the meantime; use status message
Avoid division by zero

--
[...truncated 6433 lines...]
at aQute.lib.osgi.Processor.getProperty(Processor.java:387)
at aQute.lib.osgi.Analyzer.getImportPackages(Analyzer.java:248)
at aQute.lib.osgi.Builder.getImportPackages(Builder.java:149)
at aQute.lib.osgi.Analyzer.analyze(Analyzer.java:146)
at aQute.lib.osgi.Builder.analyze(Builder.java:198)
at aQute.lib.osgi.Analyzer.calcManifest(Analyzer.java:283)
at aQute.lib.osgi.Builder.build(Builder.java:78)
at 
org.apache.felix.bundleplugin.BundlePlugin.buildOSGiBundle(BundlePlugin.java:395)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:286)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:240)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:231)
at 
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at 
hudson.maven.agent.PluginManagerInterceptor.executeMojo(PluginManagerInterceptor.java:182)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at 
org.apache.maven.lifecycle.LifecycleExecutorInterceptor.execute(LifecycleExecutorInterceptor.java:65)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:592)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at hudson.maven.agent.Main.launch(Main.java:165)
at hudson.maven.MavenBuilder.call(MavenBuilder.java:165)
at 
hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:694)
at 
hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:638)
at hudson.remoting.UserRequest.perform(UserRequest.java:114)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:270)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:417)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:269)
at java.util.concurrent.FutureTask.run(FutureTask.java:123)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:651)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:676)
at java.lang.Thread.run(Thread.java:595)
Caused by: java.lang.IllegalArgumentException: Invalid syntax for version: 
$...@}
at aQute.libg.version.Version.(Version.java:45)
at aQute.lib.osgi.Macro._version(Macro.java:627)
... 53 more
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
No translation found for macro: @
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
Exception in replace: java.lang.IllegalArgumentException: Invalid syntax for 
version: $...@}
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
No translation found for macro: version;==;$...@}
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
No translation found for macro: version;=+;$...@}
[INFO] Preparing source:jar
[WARNING] Removing: jar from forked lifecycle, to prevent recursive invocation.
[HUDSON] Archiving 

 to 
/home/hudson/hudson/jobs/sling-trunk-1.5/modules/org.apache.sling$org.apache.sling.bundleresource.impl/b

[jira] Assigned: (SLING-1842) IllegalStateException in DefaultErrorHandlerServlet when HttpServletResponse.getOutputStream() already called

[Felix Meschberger (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-1842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger reassigned SLING-1842:


Assignee: Felix Meschberger

> IllegalStateException in DefaultErrorHandlerServlet when 
> HttpServletResponse.getOutputStream() already called
> -
>
> Key: SLING-1842
> URL: https://issues.apache.org/jira/browse/SLING-1842
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Carl Hall
>Assignee: Felix Meschberger
> Attachments: SLING-1842.diff
>
>
> When getOutputStream() has been called, DefaultErrorHandlerServlet is unable 
> to write the error page and dumps an exception in the logs.  It'd be nice if 
> it failed a bit more gracefully.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Build failed in Hudson: sling-trunk-1.6 #613

[Apache Hudson Server]

See 

Changes:

[cziegeler] Don't throw illegal state exception if queue has been removed in 
the meantime; use status message
Avoid division by zero

--
[...truncated 5627 lines...]
at aQute.libg.version.Version.(Version.java:45)
at aQute.lib.osgi.Macro._version(Macro.java:627)
... 53 more
java.lang.reflect.InvocationTargetException
at sun.reflect.GeneratedMethodAccessor26.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at aQute.lib.osgi.Macro.doCommand(Macro.java:183)
at aQute.lib.osgi.Macro.doCommands(Macro.java:171)
at aQute.lib.osgi.Macro.replace(Macro.java:118)
at aQute.lib.osgi.Macro.process(Macro.java:62)
at aQute.lib.osgi.Macro.process(Macro.java:78)
at aQute.lib.osgi.Macro.process(Macro.java:48)
at aQute.lib.osgi.Macro.process(Macro.java:43)
at aQute.lib.osgi.Processor.getProperty(Processor.java:609)
at aQute.lib.osgi.Processor.getProperty(Processor.java:387)
at aQute.lib.osgi.Analyzer.getImportPackages(Analyzer.java:248)
at aQute.lib.osgi.Builder.getImportPackages(Builder.java:149)
at aQute.lib.osgi.Analyzer.analyze(Analyzer.java:146)
at aQute.lib.osgi.Builder.analyze(Builder.java:198)
at aQute.lib.osgi.Analyzer.calcManifest(Analyzer.java:283)
at aQute.lib.osgi.Builder.build(Builder.java:78)
at 
org.apache.felix.bundleplugin.BundlePlugin.buildOSGiBundle(BundlePlugin.java:395)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:286)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:240)
at 
org.apache.felix.bundleplugin.BundlePlugin.execute(BundlePlugin.java:231)
at 
org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:490)
at 
hudson.maven.agent.PluginManagerInterceptor.executeMojo(PluginManagerInterceptor.java:182)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:694)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:556)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:535)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:387)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:348)
at 
org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:180)
at 
org.apache.maven.lifecycle.LifecycleExecutorInterceptor.execute(LifecycleExecutorInterceptor.java:65)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:328)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:138)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:362)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at hudson.maven.agent.Main.launch(Main.java:165)
at hudson.maven.MavenBuilder.call(MavenBuilder.java:165)
at 
hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:694)
at 
hudson.maven.MavenModuleSetBuild$Builder.call(MavenModuleSetBuild.java:638)
at hudson.remoting.UserRequest.perform(UserRequest.java:114)
at hudson.remoting.UserRequest.perform(UserRequest.java:48)
at hudson.remoting.Request$2.run(Request.java:270)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.IllegalArgumentException: Invalid syntax for version: 
$...@}
at aQute.libg.version.Version.(Version.java:45)
at aQute.lib.osgi.Macro._version(Macro.java:627)
... 53 more
[WARNING] Warning building bundle 
org.apache.sling:org.apache.sling.bundleresource.impl:bundle:2.0.5-SNAPSHOT : 
No translation found for macro: @
[WARNING] W

RE: [VOTE] Initial Content and Servlet Archetypes 1.0.0

[Mike Müller]

+1
best regards
mike

> Hi,
> 
> This vote is for:
> Sling Initial Content Archetype 1.0.0
> Sling Servlet Archetype 1.0.0
> 
> This is the initial version of each.
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-001/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 001 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This vote will be open for 72 hours.
> 
> Thanks,
> Justin

Re: [VOTE] Initial Content and Servlet Archetypes 1.0.0

[Felix Meschberger]

+1

Thanks and Regards
Felix

On 15.10.2010 16:45, Justin Edelson wrote:
> Hi,
> 
> This vote is for:
> Sling Initial Content Archetype 1.0.0
> Sling Servlet Archetype 1.0.0
> 
> This is the initial version of each.
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-001/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 001 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This vote will be open for 72 hours.
> 
> Thanks,
> Justin
>