Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing WAR version #1478

[Apache Jenkins Server]

See 

Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478

[Apache Jenkins Server]

See 

Jenkins build is unstable: sling-trunk-1.5 #1478

[Apache Jenkins Server]

See 

[jira] [Created] (SLING-2327) Visible TODOs in the background servlets console

[Bertrand Delacretaz (Created) (JIRA)]

Visible TODOs in the background servlets console


 Key: SLING-2327
 URL: https://issues.apache.org/jira/browse/SLING-2327
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Bertrand Delacretaz
Priority: Minor


The console plugin of the contrib/extensions/bgservlets displays some ugly 
TODOs, those should be removed.

It might also be good to make this plugin optional, in case users want to 
supply a custom variant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2327) Visible TODOs in the background servlets console

[Felix Meschberger (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167442#comment-13167442
 ] 

Felix Meschberger commented on SLING-2327:
--

> It might also be good to make this plugin optional, in case users want to 
> supply a custom variant.

Why ? Isn't our plugin good enough ?

> Visible TODOs in the background servlets console
> 
>
> Key: SLING-2327
> URL: https://issues.apache.org/jira/browse/SLING-2327
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> The console plugin of the contrib/extensions/bgservlets displays some ugly 
> TODOs, those should be removed.
> It might also be good to make this plugin optional, in case users want to 
> supply a custom variant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1478

[Jeff Young]

I was trying to look into the 4th test failure (the JsonRenderingTest), but I 
can't get to svn.apache.org.  Is it down, or is it just my machine?

Thanks,
Jeff.


-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] 
Sent: 12 December 2011 10:22
To: dev@sling.apache.org
Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
Testing #1478

See 

Jenkins build is unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1151

[Apache Jenkins Server]

See 

Jenkins build is unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #1151

[Apache Jenkins Server]

See 

Jenkins build is unstable: sling-trunk-1.6 #1151

[Apache Jenkins Server]

See 

RE: Jenkins test failure

[Jeff Young]

Well, the server is still pretty glacial for me (when it responds at all), but 
I've gotten enough out of it that I believe the test failure is a result of the 
bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by the patch 
servlet_tests.patch (see comment 07/Dec/11 11:48).

https://issues.apache.org/jira/browse/SLING-2320

Could I get a committer to apply that patch?  (Carsten has looked over it.)

I've also got a further patch developed to fix some of the other issues 
discovered:
a) throwing two exceptions per node traversed
b) serializing/de-serializing/re-serializing the JSON data

but it'll be easier for me to post a clean patch if HEAD is updated first 
(otherwise I'm likely to get a diff including some of my changes twice).  (Yes, 
I'm sure there's a way around that, but I'm a SVN newbie too, and would just as 
soon not have my brain explode today.)

Thanks,
Jeff.


-Original Message-
From: Jeff Young [mailto:j...@adobe.com] 
Sent: 12 December 2011 10:50
To: dev@sling.apache.org
Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling 
Launchpad Testing #1478

I was trying to look into the 4th test failure (the JsonRenderingTest), but I 
can't get to svn.apache.org.  Is it down, or is it just my machine?

Thanks,
Jeff.


-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] 
Sent: 12 December 2011 10:22
To: dev@sling.apache.org
Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
Testing #1478

See 

[jira] [Assigned] (SLING-2320) Current DOS-prevention for infinity.json can prevent enumeration of children

[Justin Edelson (Assigned) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson reassigned SLING-2320:
-

Assignee: Justin Edelson  (was: Felix Meschberger)

> Current DOS-prevention for infinity.json can prevent enumeration of children
> 
>
> Key: SLING-2320
> URL: https://issues.apache.org/jira/browse/SLING-2320
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.0
>Reporter: Jeff Young
>Assignee: Justin Edelson
>  Labels: newbie, patch
> Fix For: Servlets Get 2.1.4
>
> Attachments: jsonRenderer.diff, servlet_tests.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> A request of resource.1.json should always succeed, as it's the primary 
> method for JSON introspection of the repository hierarchy.  DOS protection 
> should only apply to "deep" traversals; that is, anything with a depth 
> greater than 1 (and, in particular, resource.infinity.json).
> For a fuller discussion, see: 
> http://www.mail-archive.com/dev@sling.apache.org/msg13961.html.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2320) Current DOS-prevention for infinity.json can prevent enumeration of children

[Justin Edelson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167590#comment-13167590
 ] 

Justin Edelson commented on SLING-2320:
---

level fix done in r1213304

> Current DOS-prevention for infinity.json can prevent enumeration of children
> 
>
> Key: SLING-2320
> URL: https://issues.apache.org/jira/browse/SLING-2320
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.0
>Reporter: Jeff Young
>Assignee: Justin Edelson
>  Labels: newbie, patch
> Fix For: Servlets Get 2.1.4
>
> Attachments: jsonRenderer.diff, servlet_tests.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> A request of resource.1.json should always succeed, as it's the primary 
> method for JSON introspection of the repository hierarchy.  DOS protection 
> should only apply to "deep" traversals; that is, anything with a depth 
> greater than 1 (and, in particular, resource.infinity.json).
> For a fuller discussion, see: 
> http://www.mail-archive.com/dev@sling.apache.org/msg13961.html.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: Jenkins test failure

[Justin Edelson]

Patch applied.

On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young  wrote:
> Well, the server is still pretty glacial for me (when it responds at all), 
> but I've gotten enough out of it that I believe the test failure is a result 
> of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by 
> the patch servlet_tests.patch (see comment 07/Dec/11 11:48).
>
> https://issues.apache.org/jira/browse/SLING-2320
>
> Could I get a committer to apply that patch?  (Carsten has looked over it.)
>
> I've also got a further patch developed to fix some of the other issues 
> discovered:
> a) throwing two exceptions per node traversed
> b) serializing/de-serializing/re-serializing the JSON data
>
> but it'll be easier for me to post a clean patch if HEAD is updated first 
> (otherwise I'm likely to get a diff including some of my changes twice).  
> (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would 
> just as soon not have my brain explode today.)
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Jeff Young [mailto:j...@adobe.com]
> Sent: 12 December 2011 10:50
> To: dev@sling.apache.org
> Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling 
> Launchpad Testing #1478
>
> I was trying to look into the 4th test failure (the JsonRenderingTest), but I 
> can't get to svn.apache.org.  Is it down, or is it just my machine?
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
> Sent: 12 December 2011 10:22
> To: dev@sling.apache.org
> Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
> Testing #1478
>
> See 
> 
>
>

[jira] [Commented] (SLING-2320) Current DOS-prevention for infinity.json can prevent enumeration of children

[Justin Edelson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167591#comment-13167591
 ] 

Justin Edelson commented on SLING-2320:
---

adding unit tests patch in r1213305.

Jeff - I forgot to give you thanks in the commit message. Apologies.

> Current DOS-prevention for infinity.json can prevent enumeration of children
> 
>
> Key: SLING-2320
> URL: https://issues.apache.org/jira/browse/SLING-2320
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.0
>Reporter: Jeff Young
>Assignee: Justin Edelson
>  Labels: newbie, patch
> Fix For: Servlets Get 2.1.4
>
> Attachments: jsonRenderer.diff, servlet_tests.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> A request of resource.1.json should always succeed, as it's the primary 
> method for JSON introspection of the repository hierarchy.  DOS protection 
> should only apply to "deep" traversals; that is, anything with a depth 
> greater than 1 (and, in particular, resource.infinity.json).
> For a fuller discussion, see: 
> http://www.mail-archive.com/dev@sling.apache.org/msg13961.html.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

RE: Jenkins test failure

[Jeff Young]

Thanks, Justin.

Was svn.apache.org really slow for you, or is it just my connection?

Jeff.


-Original Message-
From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of 
Justin Edelson
Sent: 12 December 2011 16:48
To: dev@sling.apache.org
Subject: Re: Jenkins test failure

Patch applied.

On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young  wrote:
> Well, the server is still pretty glacial for me (when it responds at all), 
> but I've gotten enough out of it that I believe the test failure is a result 
> of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by 
> the patch servlet_tests.patch (see comment 07/Dec/11 11:48).
>
> https://issues.apache.org/jira/browse/SLING-2320
>
> Could I get a committer to apply that patch?  (Carsten has looked over it.)
>
> I've also got a further patch developed to fix some of the other issues 
> discovered:
> a) throwing two exceptions per node traversed
> b) serializing/de-serializing/re-serializing the JSON data
>
> but it'll be easier for me to post a clean patch if HEAD is updated first 
> (otherwise I'm likely to get a diff including some of my changes twice).  
> (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would 
> just as soon not have my brain explode today.)
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Jeff Young [mailto:j...@adobe.com]
> Sent: 12 December 2011 10:50
> To: dev@sling.apache.org
> Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling 
> Launchpad Testing #1478
>
> I was trying to look into the 4th test failure (the JsonRenderingTest), but I 
> can't get to svn.apache.org.  Is it down, or is it just my machine?
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
> Sent: 12 December 2011 10:22
> To: dev@sling.apache.org
> Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
> Testing #1478
>
> See 
> 
>
>

Re: Jenkins test failure

[Justin Edelson]

I didn't notice any particular slowness, but I'm multitasking :)

On Mon, Dec 12, 2011 at 8:50 AM, Jeff Young  wrote:
> Thanks, Justin.
>
> Was svn.apache.org really slow for you, or is it just my connection?
>
> Jeff.
>
>
> -Original Message-
> From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of 
> Justin Edelson
> Sent: 12 December 2011 16:48
> To: dev@sling.apache.org
> Subject: Re: Jenkins test failure
>
> Patch applied.
>
> On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young  wrote:
>> Well, the server is still pretty glacial for me (when it responds at all), 
>> but I've gotten enough out of it that I believe the test failure is a result 
>> of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by 
>> the patch servlet_tests.patch (see comment 07/Dec/11 11:48).
>>
>> https://issues.apache.org/jira/browse/SLING-2320
>>
>> Could I get a committer to apply that patch?  (Carsten has looked over it.)
>>
>> I've also got a further patch developed to fix some of the other issues 
>> discovered:
>> a) throwing two exceptions per node traversed
>> b) serializing/de-serializing/re-serializing the JSON data
>>
>> but it'll be easier for me to post a clean patch if HEAD is updated first 
>> (otherwise I'm likely to get a diff including some of my changes twice).  
>> (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and 
>> would just as soon not have my brain explode today.)
>>
>> Thanks,
>> Jeff.
>>
>>
>> -Original Message-
>> From: Jeff Young [mailto:j...@adobe.com]
>> Sent: 12 December 2011 10:50
>> To: dev@sling.apache.org
>> Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling 
>> Launchpad Testing #1478
>>
>> I was trying to look into the 4th test failure (the JsonRenderingTest), but 
>> I can't get to svn.apache.org.  Is it down, or is it just my machine?
>>
>> Thanks,
>> Jeff.
>>
>>
>> -Original Message-
>> From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
>> Sent: 12 December 2011 10:22
>> To: dev@sling.apache.org
>> Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
>> Testing #1478
>>
>> See 
>> 
>>
>>

RE: Jenkins test failure

[Jeff Young]

Hi Justin,

In revision 1213304, I only see the change to ResourceTraversor.java.  I think 
you might have applied the wrong patch (there was an earlier diff with just 
that file, and a later patch with that file and 4 or 5 test files and a POM or 
two).

Or is there a further revision coming?

Thanks,
Jeff.


-Original Message-
From: Jeff Young [mailto:j...@adobe.com] 
Sent: 12 December 2011 16:51
To: dev@sling.apache.org
Subject: RE: Jenkins test failure

Thanks, Justin.

Was svn.apache.org really slow for you, or is it just my connection?

Jeff.


-Original Message-
From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of 
Justin Edelson
Sent: 12 December 2011 16:48
To: dev@sling.apache.org
Subject: Re: Jenkins test failure

Patch applied.

On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young  wrote:
> Well, the server is still pretty glacial for me (when it responds at all), 
> but I've gotten enough out of it that I believe the test failure is a result 
> of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by 
> the patch servlet_tests.patch (see comment 07/Dec/11 11:48).
>
> https://issues.apache.org/jira/browse/SLING-2320
>
> Could I get a committer to apply that patch?  (Carsten has looked over it.)
>
> I've also got a further patch developed to fix some of the other issues 
> discovered:
> a) throwing two exceptions per node traversed
> b) serializing/de-serializing/re-serializing the JSON data
>
> but it'll be easier for me to post a clean patch if HEAD is updated first 
> (otherwise I'm likely to get a diff including some of my changes twice).  
> (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and would 
> just as soon not have my brain explode today.)
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Jeff Young [mailto:j...@adobe.com]
> Sent: 12 December 2011 10:50
> To: dev@sling.apache.org
> Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling 
> Launchpad Testing #1478
>
> I was trying to look into the 4th test failure (the JsonRenderingTest), but I 
> can't get to svn.apache.org.  Is it down, or is it just my machine?
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
> Sent: 12 December 2011 10:22
> To: dev@sling.apache.org
> Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
> Testing #1478
>
> See 
> 
>
>

Re: Jenkins test failure

[Justin Edelson]

Yep. I did the tests in the next revision.

Justin

On Mon, Dec 12, 2011 at 8:55 AM, Jeff Young  wrote:
> Hi Justin,
>
> In revision 1213304, I only see the change to ResourceTraversor.java.  I 
> think you might have applied the wrong patch (there was an earlier diff with 
> just that file, and a later patch with that file and 4 or 5 test files and a 
> POM or two).
>
> Or is there a further revision coming?
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Jeff Young [mailto:j...@adobe.com]
> Sent: 12 December 2011 16:51
> To: dev@sling.apache.org
> Subject: RE: Jenkins test failure
>
> Thanks, Justin.
>
> Was svn.apache.org really slow for you, or is it just my connection?
>
> Jeff.
>
>
> -Original Message-
> From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of 
> Justin Edelson
> Sent: 12 December 2011 16:48
> To: dev@sling.apache.org
> Subject: Re: Jenkins test failure
>
> Patch applied.
>
> On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young  wrote:
>> Well, the server is still pretty glacial for me (when it responds at all), 
>> but I've gotten enough out of it that I believe the test failure is a result 
>> of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by 
>> the patch servlet_tests.patch (see comment 07/Dec/11 11:48).
>>
>> https://issues.apache.org/jira/browse/SLING-2320
>>
>> Could I get a committer to apply that patch?  (Carsten has looked over it.)
>>
>> I've also got a further patch developed to fix some of the other issues 
>> discovered:
>> a) throwing two exceptions per node traversed
>> b) serializing/de-serializing/re-serializing the JSON data
>>
>> but it'll be easier for me to post a clean patch if HEAD is updated first 
>> (otherwise I'm likely to get a diff including some of my changes twice).  
>> (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and 
>> would just as soon not have my brain explode today.)
>>
>> Thanks,
>> Jeff.
>>
>>
>> -Original Message-
>> From: Jeff Young [mailto:j...@adobe.com]
>> Sent: 12 December 2011 10:50
>> To: dev@sling.apache.org
>> Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling 
>> Launchpad Testing #1478
>>
>> I was trying to look into the 4th test failure (the JsonRenderingTest), but 
>> I can't get to svn.apache.org.  Is it down, or is it just my machine?
>>
>> Thanks,
>> Jeff.
>>
>>
>> -Original Message-
>> From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
>> Sent: 12 December 2011 10:22
>> To: dev@sling.apache.org
>> Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
>> Testing #1478
>>
>> See 
>> 
>>
>>

RE: Jenkins test failure

[Jeff Young]

Yep, got it now.  (I think I'm going to have to reboot.  Something's decidedly 
fishy about my connection)

Thanks,
Jeff.


-Original Message-
From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of 
Justin Edelson
Sent: 12 December 2011 16:57
To: dev@sling.apache.org
Subject: Re: Jenkins test failure

Yep. I did the tests in the next revision.

Justin

On Mon, Dec 12, 2011 at 8:55 AM, Jeff Young  wrote:
> Hi Justin,
>
> In revision 1213304, I only see the change to ResourceTraversor.java.  I 
> think you might have applied the wrong patch (there was an earlier diff with 
> just that file, and a later patch with that file and 4 or 5 test files and a 
> POM or two).
>
> Or is there a further revision coming?
>
> Thanks,
> Jeff.
>
>
> -Original Message-
> From: Jeff Young [mailto:j...@adobe.com]
> Sent: 12 December 2011 16:51
> To: dev@sling.apache.org
> Subject: RE: Jenkins test failure
>
> Thanks, Justin.
>
> Was svn.apache.org really slow for you, or is it just my connection?
>
> Jeff.
>
>
> -Original Message-
> From: justinedel...@gmail.com [mailto:justinedel...@gmail.com] On Behalf Of 
> Justin Edelson
> Sent: 12 December 2011 16:48
> To: dev@sling.apache.org
> Subject: Re: Jenkins test failure
>
> Patch applied.
>
> On Mon, Dec 12, 2011 at 3:58 AM, Jeff Young  wrote:
>> Well, the server is still pretty glacial for me (when it responds at all), 
>> but I've gotten enough out of it that I believe the test failure is a result 
>> of the bug identified in SLING-2320 (comment 06/Dec/11 23:33), and fixed by 
>> the patch servlet_tests.patch (see comment 07/Dec/11 11:48).
>>
>> https://issues.apache.org/jira/browse/SLING-2320
>>
>> Could I get a committer to apply that patch?  (Carsten has looked over it.)
>>
>> I've also got a further patch developed to fix some of the other issues 
>> discovered:
>> a) throwing two exceptions per node traversed
>> b) serializing/de-serializing/re-serializing the JSON data
>>
>> but it'll be easier for me to post a clean patch if HEAD is updated first 
>> (otherwise I'm likely to get a diff including some of my changes twice).  
>> (Yes, I'm sure there's a way around that, but I'm a SVN newbie too, and 
>> would just as soon not have my brain explode today.)
>>
>> Thanks,
>> Jeff.
>>
>>
>> -Original Message-
>> From: Jeff Young [mailto:j...@adobe.com]
>> Sent: 12 December 2011 10:50
>> To: dev@sling.apache.org
>> Subject: RE: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling 
>> Launchpad Testing #1478
>>
>> I was trying to look into the 4th test failure (the JsonRenderingTest), but 
>> I can't get to svn.apache.org.  Is it down, or is it just my machine?
>>
>> Thanks,
>> Jeff.
>>
>>
>> -Original Message-
>> From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
>> Sent: 12 December 2011 10:22
>> To: dev@sling.apache.org
>> Subject: Jenkins build is unstable: sling-trunk-1.5 » Apache Sling Launchpad 
>> Testing #1478
>>
>> See 
>> 
>>
>>

[jira] [Commented] (SLING-2289) Implement generic retry mechanism

[Carsten Ziegeler (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167601#comment-13167601
 ] 

Carsten Ziegeler commented on SLING-2289:
-

In fact, the handling of retries was a little bit confusing and different 
between tasks. Some tasks simply assumed that they get re-invoked correctly 
while others implemented retry counters etc.
I've now cleaned up the api and task handling: if a task does nothing it is 
retried and it's up the installer to detect when something should be retried. 
As the installer needs input from the outside I'Ve added a new RetryHandler 
interface which should be invoked by listeners whenever they think that a retry 
makes sense. For example if a bundle got installed etc.

> Implement generic retry mechanism
> -
>
> Key: SLING-2289
> URL: https://issues.apache.org/jira/browse/SLING-2289
> Project: Sling
>  Issue Type: New Feature
>  Components: Installer
>Affects Versions: Installer Core 3.2.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.2.4
>
>
> Currently, if a task fails it is retried over and over again which basically 
> is kind of an endless loop.
> However, if between two retries nothing has changed, it is most likely that a 
> retry is failing again. We have some basic code for bundle handling, but this 
> is a) tied to bundles, b) not reusable, and c) not working perfectly.
> Instead we should come up with a generic mechanism for retries - a task 
> should signal that it want's to be retried. In addition we need a 
> notification mechanism which notifies the installer to retry something, e.g. 
> a service listening for bundle events would notify the installer each time a 
> bundle event has occurred etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2320) Current DOS-prevention for infinity.json can prevent enumeration of children

[Jeff Young (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Young updated SLING-2320:
--

Attachment: json_get_servlet_rewrite.patch

No worries, Justin.  I've got one more anyway ;)

Hopefully this is the final installment.
Rewrite of JSON GET servlet to:
a) not throw two exceptions per node finding the parent (in fact, we don't look 
for the parent at all anymore as the JSON rendering is now done via a 
second-pass, depth-first traversal rather than during the breadth-first 
depthCheck)
b) not serialize/de-serialize/re-serialize the JSON (also due to the above 
two-pass approach)
c) use ArrayLists instead of LinkedLists for breadth-first traversal (to reduce 
memory allocation calls)
d) not use exceptions for limiting depth

> Current DOS-prevention for infinity.json can prevent enumeration of children
> 
>
> Key: SLING-2320
> URL: https://issues.apache.org/jira/browse/SLING-2320
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.0
>Reporter: Jeff Young
>Assignee: Justin Edelson
>  Labels: newbie, patch
> Fix For: Servlets Get 2.1.4
>
> Attachments: jsonRenderer.diff, json_get_servlet_rewrite.patch, 
> servlet_tests.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> A request of resource.1.json should always succeed, as it's the primary 
> method for JSON introspection of the repository hierarchy.  DOS protection 
> should only apply to "deep" traversals; that is, anything with a depth 
> greater than 1 (and, in particular, resource.infinity.json).
> For a fuller discussion, see: 
> http://www.mail-archive.com/dev@sling.apache.org/msg13961.html.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2320) Current DOS-prevention for infinity.json can prevent enumeration of children

[Jeff Young (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167650#comment-13167650
 ] 

Jeff Young commented on SLING-2320:
---

BTW: final installment is "json_get_servlet_rewrite.patch".

> Current DOS-prevention for infinity.json can prevent enumeration of children
> 
>
> Key: SLING-2320
> URL: https://issues.apache.org/jira/browse/SLING-2320
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.0
>Reporter: Jeff Young
>Assignee: Justin Edelson
>  Labels: newbie, patch
> Fix For: Servlets Get 2.1.4
>
> Attachments: jsonRenderer.diff, json_get_servlet_rewrite.patch, 
> servlet_tests.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> A request of resource.1.json should always succeed, as it's the primary 
> method for JSON introspection of the repository hierarchy.  DOS protection 
> should only apply to "deep" traversals; that is, anything with a depth 
> greater than 1 (and, in particular, resource.infinity.json).
> For a fuller discussion, see: 
> http://www.mail-archive.com/dev@sling.apache.org/msg13961.html.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing WAR version #1479

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing #1479

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.5 #1479

[Apache Jenkins Server]

See 

RE: Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing WAR version #1479

[Jeff Young]

Felix recently committed a change by Alex relating to the: 
   org.apache.sling.servlets.get.impl.RedirectServletTest 
no longer returning absolute paths.  

It would appear that the failing tests are the same issue, but from:
   org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.

Cheers,
Jeff.


-Original Message-
From: Apache Jenkins Server [mailto:jenk...@builds.apache.org] 
Sent: 12 December 2011 19:11
To: dev@sling.apache.org
Subject: Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling 
Launchpad Testing WAR version #1479

See 

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #1152

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1152

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.6 #1152

[Apache Jenkins Server]

See 

Re: Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling Launchpad Testing WAR version #1479

[Alexander Klimetschek]

Yes, the error messages look very much related to
https://issues.apache.org/jira/browse/SLING-2251

expected:<[http://localhost:38340]/VanityPathTest_1323...> but
was:<[]/VanityPathTest_1323...>
expected:<[http://localhost:38340]/VanityPathTest_1323...> but
was:<[]/VanityPathTest_1323...>


expected:<[http://localhost:38340]/VanityPathTest_1323...> but
was:<[]/VanityPathTest_1323...>

The integration tests need to be adapted. Ideally, they properly resolve
any relative URL to an absolute one first (using a base URL) and check
against that one.

Cheers,
Alex


On 12.12.11 20:46, "Jeff Young"  wrote:

>Felix recently committed a change by Alex relating to the:
>   org.apache.sling.servlets.get.impl.RedirectServletTest
>no longer returning absolute paths.
>
>It would appear that the failing tests are the same issue, but from:
>   org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.
>
>Cheers,
>Jeff.
>
>
>-Original Message-
>From: Apache Jenkins Server [mailto:jenk...@builds.apache.org]
>Sent: 12 December 2011 19:11
>To: dev@sling.apache.org
>Subject: Jenkins build is still unstable: sling-trunk-1.5 » Apache Sling
>Launchpad Testing WAR version #1479
>
>See 
>.sling.launchpad.testing-war/1479/>
>
>
>



-- 
Alexander Klimetschek
Developer // Adobe (Day) // Berlin - Basel

[jira] [Commented] (SLING-2251) RedirectServlet should create relative Location headers as often as possible

[Troy Caldwell (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13167958#comment-13167958
 ] 

Troy Caldwell commented on SLING-2251:
--

Other tests that break are in:

launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/VanityPathTest.java
test302Redirect()
test301Redirect()
testRedirectKeepingExtensionAndSelector()

In the attached patch I've removed HTTP_BASE_URL from the expected value.

> RedirectServlet should create relative Location headers as often as possible
> 
>
> Key: SLING-2251
> URL: https://issues.apache.org/jira/browse/SLING-2251
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.2
>Reporter: Alexander Klimetschek
> Attachments: SLING-2251.patch
>
>
> SLING-1965 (more specifically 
> http://svn.apache.org/viewvc?view=revision&revision=903175 ) changed the 
> redirect servlet so that it _always_ generates an absolute location header. 
> The issue does not give much reasoning for that.
> The problem is that this breaks cases where a Sling server is run behind a 
> proxy (which does not or cannot rewrite the Location header), as the redirect 
> ("http://localhost:8080/some/path";) might not match the externally visible 
> domain (e.g. "https://my.domain.com";). Also, the schema is fixed (e.g. might 
> switch external https back to http).
> A solution would be to generate absolute URLs only if a resource resolver 
> mapping (/etc/map) includes an explicit domain and thus generates an absolute 
> URL. For all other cases, relative URLs should be generated. AFAICS, this was 
> the case before SLING-1965.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2251) RedirectServlet should create relative Location headers as often as possible

[Troy Caldwell (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Troy Caldwell updated SLING-2251:
-

Attachment: SLING-2251-VanityPathTest.patch

Remove HTTP_BASE_URL from expected values

> RedirectServlet should create relative Location headers as often as possible
> 
>
> Key: SLING-2251
> URL: https://issues.apache.org/jira/browse/SLING-2251
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.2
>Reporter: Alexander Klimetschek
> Attachments: SLING-2251-VanityPathTest.patch, SLING-2251.patch
>
>
> SLING-1965 (more specifically 
> http://svn.apache.org/viewvc?view=revision&revision=903175 ) changed the 
> redirect servlet so that it _always_ generates an absolute location header. 
> The issue does not give much reasoning for that.
> The problem is that this breaks cases where a Sling server is run behind a 
> proxy (which does not or cannot rewrite the Location header), as the redirect 
> ("http://localhost:8080/some/path";) might not match the externally visible 
> domain (e.g. "https://my.domain.com";). Also, the schema is fixed (e.g. might 
> switch external https back to http).
> A solution would be to generate absolute URLs only if a resource resolver 
> mapping (/etc/map) includes an explicit domain and thus generates an absolute 
> URL. For all other cases, relative URLs should be generated. AFAICS, this was 
> the case before SLING-1965.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira