Reducing the import options for Sling post servlet

2012-01-10 Thread Carsten Ziegeler
Hi,

currently the sling post servlet uses our content importer for
importing. This has basically been added to post json.
However the content importer handles other files like xml, zip, and
jar as well. But I really think we should support this and concentrate
on one format, just json. (Reducing this is easy).

If noone objects, I'll implement this change

Thanks
Carsten

-- 
Carsten Ziegeler
cziege...@apache.org


Re: Status of the Maven Adapter Annotations?

2012-01-10 Thread Carsten Ziegeler
I briefly looked at the code and it looks fine to me :)

So +1 for a first release

Carsten

2012/1/3 Justin Edelson jus...@justinedelson.com:
 I think it is in OK shape, but it'd be great for someone else to look
 through the code before a first release.

 Regards,
 Justin

 On Mon, Jan 2, 2012 at 11:57 PM, Carsten Ziegeler cziege...@apache.org 
 wrote:
 Hi,

 I'm planning to release a new version of the jcr resource bundle in
 the near future. This depends on the new Adapter Annotations. So in
 order to release the jcr bundle, we need to release the annotations
 stuff first.
 Is this ready for a release or are there outstanding issue?

 Regards
 Carsten
 --
 Carsten Ziegeler
 cziege...@apache.org



-- 
Carsten Ziegeler
cziege...@apache.org


Re: Reducing the import options for Sling post servlet

2012-01-10 Thread Bertrand Delacretaz
On Tue, Jan 10, 2012 at 4:30 PM, Carsten Ziegeler cziege...@apache.org wrote:
 ...currently the sling post servlet uses our content importer for
 importing. This has basically been added to post json.
 However the content importer handles other files like xml, zip, and
 jar as well. But I really think we should support this and concentrate
 on one format, just json. (Reducing this is easy)

How about backwards compatibility?

-Bertrand


Re: Reducing the import options for Sling post servlet

2012-01-10 Thread Carsten Ziegeler
2012/1/10 Bertrand Delacretaz bdelacre...@apache.org:
 On Tue, Jan 10, 2012 at 4:30 PM, Carsten Ziegeler cziege...@apache.org 
 wrote:
 ...currently the sling post servlet uses our content importer for
 importing. This has basically been added to post json.
 However the content importer handles other files like xml, zip, and
 jar as well. But I really think we should support this and concentrate
 on one format, just json. (Reducing this is easy)

 How about backwards compatibility?

It's right that this is not backwards compatible - however I don't
think that anyone is really using this for other things than json. If
someone really needs it we can make it configurable, but disallow by
default.

Regards
Carsten



-- 
Carsten Ziegeler
cziege...@apache.org


[jira] [Created] (SLING-2353) Prevent sling:include resource=%= null % / to include itself

2012-01-10 Thread Tobias Bocanegra (Created) (JIRA)
Prevent sling:include resource=%= null % / to include itself
--

 Key: SLING-2353
 URL: https://issues.apache.org/jira/browse/SLING-2353
 Project: Sling
  Issue Type: Bug
Reporter: Tobias Bocanegra
Priority: Minor


If you add this sling:include to a JSP sling:include resource=%= null % /
then it will cause the page to keep including itself recursively making the
server slow. there is a recursion limitation though to prevent endless loops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (SLING-2353) Prevent sling:include resource=%= null % / to include itself

2012-01-10 Thread Tobias Bocanegra (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra updated SLING-2353:


  Component/s: Scripting
Affects Version/s: Scripting JSP-Taglib 2.1.2

 Prevent sling:include resource=%= null % / to include itself
 --

 Key: SLING-2353
 URL: https://issues.apache.org/jira/browse/SLING-2353
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting JSP-Taglib 2.1.2
Reporter: Tobias Bocanegra
Priority: Minor

 If you add this sling:include to a JSP sling:include resource=%= null % 
 /
 then it will cause the page to keep including itself recursively making the
 server slow. there is a recursion limitation though to prevent endless loops.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




LoginServlet broken since SLING-2165

2012-01-10 Thread Justin Edelson
I noticed yesterday that the login link on the index.html page (to
http://localhost:/system/sling/login.html) in the initial content
no longer works - it returns a 403 error.

This appears to be because the LoginServlet tries to delegate serving
the login page to the various authentication handlers, but they all
refuse to handle it because the referrer isn't their own login page.
This appears to be a regression added by SLING-2165.

Is the LoginServlet still usable? If so, how?

Thanks
Justin


[jira] [Updated] (SLING-2349) [Authentication] Osgi event creation for successful login

2012-01-10 Thread Justin Edelson (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson updated SLING-2349:
--

Assignee: Justin Edelson

 [Authentication] Osgi event creation for successful login
 -

 Key: SLING-2349
 URL: https://issues.apache.org/jira/browse/SLING-2349
 Project: Sling
  Issue Type: New Feature
  Components: Authentication
Affects Versions: Auth Core 1.0.6
Reporter: Nicolas Peltier
Assignee: Justin Edelson
Priority: Minor

 Successful authentication (with credentials only?) should create an a logged 
 in osgi event mentionning userid.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (SLING-2312) Add Adapter Annotations

2012-01-10 Thread Justin Edelson (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson updated SLING-2312:
--

Fix Version/s: Extensions Rewriter 1.0.2

added to rewriter in r1229714

 Add Adapter Annotations
 ---

 Key: SLING-2312
 URL: https://issues.apache.org/jira/browse/SLING-2312
 Project: Sling
  Issue Type: Improvement
  Components: Extensions, JCR
Reporter: Justin Edelson
 Fix For: JCR Resource 2.1.0, File System Resource Provider 1.0.4, 
 Extensions Rewriter 1.0.2, JCR Jackrabbit User Manager 2.2.2


 Container issue for adding annotations introduced in SLING-2313 to various 
 bundles.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (SLING-2312) Add Adapter Annotations

2012-01-10 Thread Justin Edelson (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-2312.
---

Resolution: Fixed
  Assignee: Justin Edelson

annotations have been added to all Sling bundles

 Add Adapter Annotations
 ---

 Key: SLING-2312
 URL: https://issues.apache.org/jira/browse/SLING-2312
 Project: Sling
  Issue Type: Improvement
  Components: Extensions, JCR
Reporter: Justin Edelson
Assignee: Justin Edelson
 Fix For: JCR Resource 2.1.0, File System Resource Provider 1.0.4, 
 Extensions Rewriter 1.0.2, JCR Jackrabbit User Manager 2.2.2


 Container issue for adding annotations introduced in SLING-2313 to various 
 bundles.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (SLING-2349) [Authentication] Osgi event creation for successful login

2012-01-10 Thread Justin Edelson (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-2349.
---

   Resolution: Fixed
Fix Version/s: Auth Core 1.1.0

 [Authentication] Osgi event creation for successful login
 -

 Key: SLING-2349
 URL: https://issues.apache.org/jira/browse/SLING-2349
 Project: Sling
  Issue Type: New Feature
  Components: Authentication
Affects Versions: Auth Core 1.0.6
Reporter: Nicolas Peltier
Assignee: Justin Edelson
Priority: Minor
 Fix For: Auth Core 1.1.0


 Successful authentication (with credentials only?) should create an a logged 
 in osgi event mentionning userid.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (SLING-2349) [Authentication] Osgi event creation for successful login

2012-01-10 Thread Justin Edelson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183551#comment-13183551
 ] 

Justin Edelson commented on SLING-2349:
---

added Login and Logout events in r1229715

 [Authentication] Osgi event creation for successful login
 -

 Key: SLING-2349
 URL: https://issues.apache.org/jira/browse/SLING-2349
 Project: Sling
  Issue Type: New Feature
  Components: Authentication
Affects Versions: Auth Core 1.0.6
Reporter: Nicolas Peltier
Assignee: Justin Edelson
Priority: Minor
 Fix For: Auth Core 1.1.0


 Successful authentication (with credentials only?) should create an a logged 
 in osgi event mentionning userid.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (SLING-2312) Add Adapter Annotations

2012-01-10 Thread Justin Edelson (Resolved) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-2312.
---

Resolution: Fixed

nevermind. OCM isn't an issue.

 Add Adapter Annotations
 ---

 Key: SLING-2312
 URL: https://issues.apache.org/jira/browse/SLING-2312
 Project: Sling
  Issue Type: Improvement
  Components: Extensions, JCR
Reporter: Justin Edelson
Assignee: Justin Edelson
 Fix For: JCR Resource 2.1.0, File System Resource Provider 1.0.4, 
 Extensions Rewriter 1.0.2, JCR Jackrabbit User Manager 2.2.2


 Container issue for adding annotations introduced in SLING-2313 to various 
 bundles.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: Status of the Maven Adapter Annotations?

2012-01-10 Thread Justin Edelson
Actually, I just found an issue which I'd like to address. I'll take
ownership of the release and try to get it started late in the day.

Justin

On Tue, Jan 10, 2012 at 7:38 AM, Carsten Ziegeler cziege...@apache.org wrote:
 I briefly looked at the code and it looks fine to me :)

 So +1 for a first release

 Carsten

 2012/1/3 Justin Edelson jus...@justinedelson.com:
 I think it is in OK shape, but it'd be great for someone else to look
 through the code before a first release.

 Regards,
 Justin

 On Mon, Jan 2, 2012 at 11:57 PM, Carsten Ziegeler cziege...@apache.org 
 wrote:
 Hi,

 I'm planning to release a new version of the jcr resource bundle in
 the near future. This depends on the new Adapter Annotations. So in
 order to release the jcr bundle, we need to release the annotations
 stuff first.
 Is this ready for a release or are there outstanding issue?

 Regards
 Carsten
 --
 Carsten Ziegeler
 cziege...@apache.org



 --
 Carsten Ziegeler
 cziege...@apache.org


Build failed in Jenkins: sling-trunk-1.5 #1520

2012-01-10 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.5/1520/changes

Changes:

[justin] SLING-2349 - adding login and logout events

[justin] SLING-2312 - adding adapter annotations for rewriter

[justin] fixing misspellings in comments

--
[...truncated 16484 lines...]
 T E S T S
---
There are no tests to run.

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results[INFO] Checking unresolved references to 
org.codehaus.mojo.signature:java15:1.0

[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ 
org.apache.sling.testing.samples.integrationtests ---
[INFO] 
[INFO] --- maven-jar-plugin:2.3.1:jar (default-jar) @ 
org.apache.sling.testing.samples.integrationtests ---
[INFO] Building jar: 
https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/testing/samples/integration-tests/target/org.apache.sling.testing.samples.integrationtests-1.0.7-SNAPSHOT.jar
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.testing.samples.integrationtests ---
[JENKINS] Archiving 
https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/testing/samples/integration-tests/pom.xml
 to 
/home/hudson/hudson/jobs/sling-trunk-1.5/modules/org.apache.sling$org.apache.sling.testing.samples.integrationtests/builds/2012-01-10_21-05-59/archive/org.apache.sling/org.apache.sling.testing.samples.integrationtests/1.0.7-SNAPSHOT/org.apache.sling.testing.samples.integrationtests-1.0.7-SNAPSHOT.pom
[JENKINS] Archiving 
https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/testing/samples/integration-tests/target/org.apache.sling.testing.samples.integrationtests-1.0.7-SNAPSHOT.jar
 to 
/home/hudson/hudson/jobs/sling-trunk-1.5/modules/org.apache.sling$org.apache.sling.testing.samples.integrationtests/builds/2012-01-10_21-05-59/archive/org.apache.sling/org.apache.sling.testing.samples.integrationtests/1.0.7-SNAPSHOT/org.apache.sling.testing.samples.integrationtests-1.0.7-SNAPSHOT.jar
Jan 10, 2012 9:46:51 PM hudson.maven.ExecutedMojo init
WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ 
org.apache.sling.testing.samples.integrationtests ---
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Building jar: 
https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/testing/samples/integration-tests/target/org.apache.sling.testing.samples.integrationtests-1.0.7-SNAPSHOT-sources.jar
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] 
[INFO] --- maven-failsafe-plugin:2.7.2:integration-test (integration-test) @ 
org.apache.sling.testing.samples.integrationtests ---
[INFO] Failsafe report directory: 
https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/testing/samples/integration-tests/target/failsafe-reports

---
 T E S T S
---
Running org.apache.sling.testing.samples.integrationtests.http.OsgiConsoleTest
8 [main] INFO 
org.apache.sling.testing.samples.integrationtests.http.OsgiConsoleTest - Server 
base URL=http://localhost:35252
18 [main] INFO org.apache.sling.testing.tools.jarexec.JarExecutor - Executable 
jar options: -p 35252
18 [main] INFO org.apache.sling.testing.tools.jarexec.JarExecutor - Executing 
java -Xmx512m -jar 
https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/testing/samples/integration-tests/target/dependency/org.apache.sling.launchpad-6-standalone.jar
 -p 35252
21 [main] INFO org.apache.sling.testing.tools.sling.TimeoutsProvider - Timeout 
factor set to 1.0 from system property sling.testing.timeout.multiplier
21 [main] INFO 
org.apache.sling.testing.samples.integrationtests.http.OsgiConsoleTest - Will 
wait up to 60 seconds for server to become ready
24 [main] INFO 
org.apache.sling.testing.samples.integrationtests.http.OsgiConsoleTest - 
Checking that GET requests return expected content (timeout=60 seconds): 
[/:script src=system/sling.js, 
/.explorer.html:href=/libs/sling/explorer/css/explorer.css, 
/sling-test/sling/sling-test.html:Sling client library tests]
10.01.2012 21:46:52.348 *INFO* [main] Setting sling.home=sling (default)
10.01.2012 21:46:52.349 *INFO* [main] Starting Sling in sling 
(https://builds.apache.org/job/sling-trunk-1.5/ws/trunk/testing/samples/integration-tests/sling)
10.01.2012 21:46:52.353 *INFO* [main] Checking launcher JAR in folder sling
10.01.2012 21:46:52.367 *INFO* [main] Installing new launcher: 

Jenkins build became unstable: sling-trunk-1.6 #1191

2012-01-10 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.6/1191/changes




[jira] [Created] (SLING-2354) There should be a way to add multiple Adapter annotations to a class

2012-01-10 Thread Justin Edelson (Created) (JIRA)
There should be a way to add multiple Adapter annotations to a class


 Key: SLING-2354
 URL: https://issues.apache.org/jira/browse/SLING-2354
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Justin Edelson
Assignee: Justin Edelson


For AdapterFactory instances which support multiple adaptable classes, it would 
be useful to be able to support multiple annotations per class. Since the 
language spec doesn't allow this, we need a container annotation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: LoginServlet broken since SLING-2165

2012-01-10 Thread Eric Norman
Maybe it should only be checking the referrer when the request is a POST.
 The intent of that referer checking was to make sure you returned to the
same login page when there was an error with the credentials that were
posted from the login form.

Regards,
Eric

On Tue, Jan 10, 2012 at 12:23 PM, Justin Edelson
jus...@justinedelson.comwrote:

 I noticed yesterday that the login link on the index.html page (to
 http://localhost:/system/sling/login.html) in the initial content
 no longer works - it returns a 403 error.

 This appears to be because the LoginServlet tries to delegate serving
 the login page to the various authentication handlers, but they all
 refuse to handle it because the referrer isn't their own login page.
 This appears to be a regression added by SLING-2165.

 Is the LoginServlet still usable? If so, how?

 Thanks
 Justin



[jira] [Created] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata

2012-01-10 Thread Justin Edelson (Created) (JIRA)
An Adapter annotation should be able to declare that it replaces the service 
properties metadata


 Key: SLING-2355
 URL: https://issues.apache.org/jira/browse/SLING-2355
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Justin Edelson
Assignee: Justin Edelson


Currently, the Adapters web console plugin merges metadata from the JSON files 
with the metadata extracted from the OSGi service properties for AdapterFactory 
services. It should be possible for the JSON metadata to declare that it 
overrides the metadata from the AdapterFactory service (just for the purposes 
of the web console plugin).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (SLING-2350) Sling Maven JSPC Plugin depends on legacy Sling API lib which does not support adaptable SlingHttpServletRequest objects

2012-01-10 Thread David Gonzalez (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183862#comment-13183862
 ] 

David Gonzalez commented on SLING-2350:
---

I was able to resolve: java.lang.NoClassDefFoundError: org/slf4j/LoggerFactory 
by adding slf4j-api and slf4j-log4j12 as plugin depdencies in my pom.xml

  plugin
groupIdorg.apache.sling/groupId
artifactIdmaven-jspc-plugin/artifactId
version2.0.6-SNAPSHOT/version   
  ...
dependencies
dependency
groupIdorg.slf4j/groupId
artifactIdslf4j-api/artifactId
version1.5.2/version
/dependency
dependency
groupIdorg.slf4j/groupId
artifactIdslf4j-log4j12/artifactId
version1.5.2/version
/dependency  
  
/dependencies
/plugin


I also needed to add a log4j.properties file to the maven-jspc-plugin under 
/src/main/resources else i received a numbe of warnings about log4j not being 
properly initialized (I couldnt put them in my proj's /src/main/resources, it 
had to be in the maven-jspc-plugin project's).

I am now running into a NullPointerException:

ava.lang.NullPointerException
at 
org.apache.sling.scripting.jsp.jasper.compiler.Compiler.isOutDated(Compiler.java:361)
at org.apache.sling.maven.jspc.JspcMojo.processFile(JspcMojo.java:359)
at 
org.apache.sling.maven.jspc.JspcMojo.executeInternal(JspcMojo.java:315)
at org.apache.sling.maven.jspc.JspcMojo.execute(JspcMojo.java:227)


I've included the entire maven build output here: 
https://gist.github.com/1592959

It looks like in Compiler.java its throwing the exception because jsw is null:

final long lastModifiedTest = jsw.getLastModificationTest();

In JspMojo,processFile the Compiler object is created, however i *think* the 
only way to set the JspServletWrapper in the Compiler is by calling its:

public void init(JspCompilationContext ctxt, JspServletWrapper jsw) 

And it's not, thus its null.

I looked through code and im not sure I understand what would be needed to 
create a JspServletWrapper obj properly, or if its even needed (is 
jsw.getLastModificationTest even truly needed?)

Any thoughts around this?

 Sling Maven JSPC Plugin depends on legacy Sling API lib which does not 
 support adaptable SlingHttpServletRequest objects
 

 Key: SLING-2350
 URL: https://issues.apache.org/jira/browse/SLING-2350
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Affects Versions:  Maven JSPC Plugin 2.0.4
 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
 Maven home: /usr/share/maven
 Java version: 1.6.0_29, vendor: Apple Inc.
 Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home
 Default locale: en_US, platform encoding: MacRoman
 OS name: mac os x, version: 10.7.2, arch: x86_64, family: mac
Reporter: David Gonzalez
Assignee: Carsten Ziegeler
  Labels: maven-bundle-plugin
 Attachments: jspc-test.zip, pom.xml, pom.xml.diff

   Original Estimate: 0.5h
  Remaining Estimate: 0.5h

 Buiding Sling-based project using the Maven JSPC Plugin but am getting 
 compilation errors because SlingHttpServletRequest object doesn't have 
 .adaptTo(...) defined.
 Latest Sling API docs state:
   Starting with Sling API 2.0.6, this [SlingHttpServletRequest] interface 
 also extends the Adaptable interface.
 Sling Maven JSPC Plugin 2.0.4-incubator plugin [1] depends on  Sling 
 Scripting 2.0.2-incubator [2] which in turn depends on Sling API  
 2.0.2-incubator which is older than 2.0.6 thus no Adaptable support.
 [1] 
 http://svn.apache.org/repos/asf/sling/tags/maven-jspc-plugin-2.0.4-incubator/pom.xml
 [2] 
 http://svn.apache.org/viewvc/sling/tags/org.apache.sling.scripting.jsp-2.0.2-incubator/pom.xml?view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (SLING-2355) An Adapter annotation should be able to declare that it replaces the service properties metadata

2012-01-10 Thread Felix Meschberger (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13183912#comment-13183912
 ] 

Felix Meschberger commented on SLING-2355:
--

I wonder about the use case here ?

An AdpaterFactory service must be fully described by its two service 
registration properties for it to be used by the AdapterManager. I do not see 
how the web console metadata would usefully extend this information

Maybe I am just missing a point ?

 An Adapter annotation should be able to declare that it replaces the service 
 properties metadata
 

 Key: SLING-2355
 URL: https://issues.apache.org/jira/browse/SLING-2355
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Justin Edelson
Assignee: Justin Edelson

 Currently, the Adapters web console plugin merges metadata from the JSON 
 files with the metadata extracted from the OSGi service properties for 
 AdapterFactory services. It should be possible for the JSON metadata to 
 declare that it overrides the metadata from the AdapterFactory service (just 
 for the purposes of the web console plugin).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (SLING-2356) Correctly sort resources

2012-01-10 Thread Carsten Ziegeler (Created) (JIRA)
Correctly sort resources


 Key: SLING-2356
 URL: https://issues.apache.org/jira/browse/SLING-2356
 Project: Sling
  Issue Type: Improvement
  Components: Installer
Affects Versions: Installer Core 3.3.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Installer Core 3.3.2


The sorting of resources pointing to the same artifact is not 100% correct. The 
digest should only be compared if the artifact is either a snapshot artifact or 
does not have a version information

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira