Re: Board Report March
Thanks, lgtm - I'll submit this version Regards Carsten 2012/3/12 Bertrand Delacretaz : > Hi, > > On Mon, Mar 12, 2012 at 7:29 AM, Carsten Ziegeler > wrote: >>... I've assembled an initial board report: >> >> https://cwiki.apache.org/confluence/display/SLING/Status+Report+%28March+2012%29 >> >> Please comment/add/change if required - I plan to submit the report >> tomorrow... > > Thanks - I've changed the community section to be more explicit, "No > new committers or PMC members, the project is relatively quiet but > mailing lists are responsive", hope that works for you. > > -Bertrand -- Carsten Ziegeler cziege...@apache.org
Json.org license
Hi, I saw this on Twitter. https://twitter.com/#!/postwait/status/179292171533430785 see https://github.com/apache/sling/blob/trunk/bundles/commons/json/src/main/java/org/apache/sling/commons/json/JSONObject.java The license is MIT but contains an additional clause: "The software shall be used for good, not evil." Which is hard to comply with since there is no legal definition of "good" or "evil" or where the boundary is. Do we need to do anything ? Ian
[jira] [Commented] (SLING-2425) Incorrect and inconsistent escaping of property names used in JcrPropertyMap
[ https://issues.apache.org/jira/browse/SLING-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227686#comment-13227686 ] Alexander Klimetschek commented on SLING-2425: -- How do you think the inconsistency can be resolved when using the JCR API as well? > Incorrect and inconsistent escaping of property names used in JcrPropertyMap > > > Key: SLING-2425 > URL: https://issues.apache.org/jira/browse/SLING-2425 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Resource 2.0.10 >Reporter: Alexander Klimetschek >Assignee: Carsten Ziegeler > > The JcrPropertyMap uses the (wrong) ISO9075 encoding for property names, and > this also behaves differently between the read() and readFully() variants. > 1) ISO9075 is needed for XML names, e.g. for mapping JCR names into Xpath > queries. But the set of valid JCR names is much larger (for example "-" is > valid, while it is not allowed in ISO9075 and becomes "_x002d_"). > org.apache.jackrabbit.util.Text#escapeIllegalJcrChars() must be used instead > to escape any string for use as JCR names. [0] > 2) Inconsistency: > a) read() will take the key and use ISO9075#encodePath(), before looking up > the jcr property using the encoded variant > b) readFully() will go through all jcr properties and cache them with the key > using ISO9075#decode() > Hence for all valid JCR names, which are not valid under ISO9075 (like > "1_prop", "-foo"), these can be looked up using the cached variant b) (as > decode() won't touch them), while they cannot be looked up using read() at > all due to the forced "arbitrary" escaping. > I think there should be no auto-magically escaping at all (also not in the > accompanying JcrModifiablePropertyMap). Incorrect naming errors should simply > be passed through, it is the job of the application to handle that. The > framework should not run an arbitrary & undocumented escaping, if it cannot > enforce that anyway, since there are other ways to create properties with a > different valid char set (using the JCR API). > [0] http://wiki.apache.org/jackrabbit/EncodingAndEscaping -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2433) Add xml-stylesheet support to XML :import POST operation
[ https://issues.apache.org/jira/browse/SLING-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227570#comment-13227570 ] Mike Pfaff commented on SLING-2433: --- That's a possibility for me, but the end users usually prefer not to have to install/run custom-written tools with a lot of XML/XSL-Java/-Library dependencies (aka dependency hell ;) . They usually just work with the browser and sometimes maybe a small shell script / batch file that just calls curl with some params. > Add xml-stylesheet support to XML :import POST operation > > > Key: SLING-2433 > URL: https://issues.apache.org/jira/browse/SLING-2433 > Project: Sling > Issue Type: Improvement > Components: JCR, Servlets >Affects Versions: Servlets Post 2.1.0, JCR ContentLoader 2.1.4 > Environment: CQ 5.5 >Reporter: Mike Pfaff >Priority: Minor > > It would be nice if one could also POST an XSL file for an XML :import > operation, so that the XML file is transformed before the import. This would > help a lot when one needs to import a custom(= non-JCR-view) XML file -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Board Report March
Hi, On Mon, Mar 12, 2012 at 7:29 AM, Carsten Ziegeler wrote: >... I've assembled an initial board report: > > https://cwiki.apache.org/confluence/display/SLING/Status+Report+%28March+2012%29 > > Please comment/add/change if required - I plan to submit the report > tomorrow... Thanks - I've changed the community section to be more explicit, "No new committers or PMC members, the project is relatively quiet but mailing lists are responsive", hope that works for you. -Bertrand
[jira] [Assigned] (SLING-2425) Incorrect and inconsistent escaping of property names used in JcrPropertyMap
[ https://issues.apache.org/jira/browse/SLING-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-2425: --- Assignee: Carsten Ziegeler > Incorrect and inconsistent escaping of property names used in JcrPropertyMap > > > Key: SLING-2425 > URL: https://issues.apache.org/jira/browse/SLING-2425 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Resource 2.0.10 >Reporter: Alexander Klimetschek >Assignee: Carsten Ziegeler > > The JcrPropertyMap uses the (wrong) ISO9075 encoding for property names, and > this also behaves differently between the read() and readFully() variants. > 1) ISO9075 is needed for XML names, e.g. for mapping JCR names into Xpath > queries. But the set of valid JCR names is much larger (for example "-" is > valid, while it is not allowed in ISO9075 and becomes "_x002d_"). > org.apache.jackrabbit.util.Text#escapeIllegalJcrChars() must be used instead > to escape any string for use as JCR names. [0] > 2) Inconsistency: > a) read() will take the key and use ISO9075#encodePath(), before looking up > the jcr property using the encoded variant > b) readFully() will go through all jcr properties and cache them with the key > using ISO9075#decode() > Hence for all valid JCR names, which are not valid under ISO9075 (like > "1_prop", "-foo"), these can be looked up using the cached variant b) (as > decode() won't touch them), while they cannot be looked up using read() at > all due to the forced "arbitrary" escaping. > I think there should be no auto-magically escaping at all (also not in the > accompanying JcrModifiablePropertyMap). Incorrect naming errors should simply > be passed through, it is the job of the application to handle that. The > framework should not run an arbitrary & undocumented escaping, if it cannot > enforce that anyway, since there are other ways to create properties with a > different valid char set (using the JCR API). > [0] http://wiki.apache.org/jackrabbit/EncodingAndEscaping -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2425) Incorrect and inconsistent escaping of property names used in JcrPropertyMap
[ https://issues.apache.org/jira/browse/SLING-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227355#comment-13227355 ] Carsten Ziegeler commented on SLING-2425: - We explicitly had to add the encoding (therefore SLING-1077) as many apps where already relying on this behaviour and without it completely broke. So we can't change the escaping part I'll look into the inconsistency problem > Incorrect and inconsistent escaping of property names used in JcrPropertyMap > > > Key: SLING-2425 > URL: https://issues.apache.org/jira/browse/SLING-2425 > Project: Sling > Issue Type: Bug > Components: JCR >Affects Versions: JCR Resource 2.0.10 >Reporter: Alexander Klimetschek > > The JcrPropertyMap uses the (wrong) ISO9075 encoding for property names, and > this also behaves differently between the read() and readFully() variants. > 1) ISO9075 is needed for XML names, e.g. for mapping JCR names into Xpath > queries. But the set of valid JCR names is much larger (for example "-" is > valid, while it is not allowed in ISO9075 and becomes "_x002d_"). > org.apache.jackrabbit.util.Text#escapeIllegalJcrChars() must be used instead > to escape any string for use as JCR names. [0] > 2) Inconsistency: > a) read() will take the key and use ISO9075#encodePath(), before looking up > the jcr property using the encoded variant > b) readFully() will go through all jcr properties and cache them with the key > using ISO9075#decode() > Hence for all valid JCR names, which are not valid under ISO9075 (like > "1_prop", "-foo"), these can be looked up using the cached variant b) (as > decode() won't touch them), while they cannot be looked up using read() at > all due to the forced "arbitrary" escaping. > I think there should be no auto-magically escaping at all (also not in the > accompanying JcrModifiablePropertyMap). Incorrect naming errors should simply > be passed through, it is the job of the application to handle that. The > framework should not run an arbitrary & undocumented escaping, if it cannot > enforce that anyway, since there are other ways to create properties with a > different valid char set (using the JCR API). > [0] http://wiki.apache.org/jackrabbit/EncodingAndEscaping -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira