Build failed in Jenkins: sling-samples-1.5 #305

2012-04-12 Thread Apache Jenkins Server
See 

--
[...truncated 1228 lines...]
 [echo] 
**
[INFO] Executed tasks
[INFO] 
[INFO] --- yuicompressor-maven-plugin:1.3.0:compress (default) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nb warnings: 0, nb errors: 0
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-scr-plugin:1.7.2:scr (generate-scr-scrdescriptor) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources

[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] [INFO] No sources to compile

[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] 
[INFO] --- maven-surefire-plugin:2.7.2:test (default-test) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] Surefire report directory: 


---
 T E S T S
---
There are no tests to run.

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0
[INFO] 
[INFO] --- maven-bundle-plugin:2.0.1:bundle (default-bundle) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.samples.usermanager.ui ---
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-samples-1.5/modules/org.apache.sling.samples$org.apache.sling.samples.usermanager.ui/builds/2012-04-12_15-00-00/archive/org.apache.sling.samples/org.apache.sling.samples.usermanager.ui/0.9-SNAPSHOT/org.apache.sling.samples.usermanager.ui-0.9-SNAPSHOT.pom
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-samples-1.5/modules/org.apache.sling.samples$org.apache.sling.samples.usermanager.ui/builds/2012-04-12_15-00-00/archive/org.apache.sling.samples/org.apache.sling.samples.usermanager.ui/0.9-SNAPSHOT/org.apache.sling.samples.usermanager.ui-0.9-SNAPSHOT.jar
Apr 12, 2012 3:02:21 PM hudson.maven.ExecutedMojo 
WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Building jar: 

[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] Checking legal files in: 
org.apache.sling.samples.usermanager.ui-0.9-SNAPSHOT.jar
[INFO] Checking legal file

Build failed in Jenkins: sling-contrib-1.5 #856

2012-04-12 Thread Apache Jenkins Server
See 

--
[...truncated 2301 lines...]
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-contrib-1.5/modules/org.apache.sling$org.apache.sling.scripting.velocity/builds/2012-04-12_14-51-55/archive/org.apache.sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.jar
Apr 12, 2012 2:59:38 PM hudson.maven.ExecutedMojo 
WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ 
org.apache.sling.scripting.velocity ---
[INFO] META-INF already added, skipping
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Building jar: 

[INFO] META-INF already added, skipping
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] [INFO] Checking legal files in: 
org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT-sources.jar

[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.scripting.velocity ---
[INFO] [INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT-sources.jar

[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
org.apache.sling.scripting.velocity ---
[INFO] Local OBR update disabled (enable with -DobrRepository)
[INFO] 
[INFO] --- maven-bundle-plugin:2.0.1:install (default-install) @ 
org.apache.sling.scripting.velocity ---
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-contrib-1.5/modules/org.apache.sling$org.apache.sling.scripting.velocity/builds/2012-04-12_14-51-55/archive/org.apache.sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT-sources.jar
[INFO] 
[INFO] 
[INFO] Building Apache Sling Scripting W3C XML Processing Support 2.0.0-SNAPSHOT
[INFO] 
[INFO] [INFO] Deleting 


[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ 
org.apache.sling.scripting.xproc ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.scripting.xproc ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
org.apache.sling.scripting.xproc ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources

[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
org.apache.sling.scripting.xproc ---
[INFO] [INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks

[INFO] --- maven-antrun-plugin:

[jira] [Updated] (SLING-2076) Make MapEntries more dynamic

2012-04-12 Thread Carsten Ziegeler (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-2076:


Fix Version/s: (was: JCR Resource 2.1.0)

I'm unscheduling this from 2.1.0 to not block the release. I think we a new jcr 
resource release is overdue :)

> Make MapEntries more dynamic
> 
>
> Key: SLING-2076
> URL: https://issues.apache.org/jira/browse/SLING-2076
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Resource 2.0.10
>Reporter: Vidar S. Ramdal
>Assignee: Vidar S. Ramdal
>
> In some scenarios it would be nice to be able to store mapping specs other 
> places than under /etc/map (for instance scattered around the 
> repository/resource tree, or in an external XML file). 
> It would be better if the entire map specification was provided by a separate 
> service. The current MapEntries would act as the default implementation.
> Mailing list discussion: http://markmail.org/thread/5ww634sqarxtudks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (SLING-2425) Incorrect and inconsistent escaping of property names used in JcrPropertyMap

2012-04-12 Thread Carsten Ziegeler (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-2425:


Fix Version/s: JCR Resource 2.1.0

> Incorrect and inconsistent escaping of property names used in JcrPropertyMap
> 
>
> Key: SLING-2425
> URL: https://issues.apache.org/jira/browse/SLING-2425
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.0.10
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
> Fix For: JCR Resource 2.1.0
>
>
> The JcrPropertyMap uses the (wrong) ISO9075 encoding for property names, and 
> this also behaves differently between the read() and readFully() variants.
> 1) ISO9075 is needed for XML names, e.g. for mapping JCR names into Xpath 
> queries. But the set of valid JCR names is much larger (for example "-" is 
> valid, while it is not allowed in ISO9075 and becomes "_x002d_"). 
> org.apache.jackrabbit.util.Text#escapeIllegalJcrChars() must be used instead 
> to escape any string for use as JCR names. [0]
> 2) Inconsistency:
> a) read() will take the key and use ISO9075#encodePath(), before looking up 
> the jcr property using the encoded variant
> b) readFully() will go through all jcr properties and cache them with the key 
> using ISO9075#decode()
> Hence for all valid JCR names, which are not valid under ISO9075 (like 
> "1_prop", "-foo"), these can be looked up using the cached variant b) (as 
> decode() won't touch them), while they cannot be looked up using read() at 
> all due to the forced "arbitrary" escaping.
> I think there should be no auto-magically escaping at all (also not in the 
> accompanying JcrModifiablePropertyMap). Incorrect naming errors should simply 
> be passed through, it is the job of the application to handle that. The 
> framework should not run an arbitrary & undocumented escaping, if it cannot 
> enforce that anyway, since there are other ways to create properties with a 
> different valid char set (using the JCR API).
> [0] http://wiki.apache.org/jackrabbit/EncodingAndEscaping

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (SLING-2425) Incorrect and inconsistent escaping of property names used in JcrPropertyMap

2012-04-12 Thread Carsten Ziegeler (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252378#comment-13252378
 ] 

Carsten Ziegeler commented on SLING-2425:
-

I've committed a first implementation in revision 1325221 which basically works 
like Felix has outlined
I'll leave this bug open for further comments / testing

> Incorrect and inconsistent escaping of property names used in JcrPropertyMap
> 
>
> Key: SLING-2425
> URL: https://issues.apache.org/jira/browse/SLING-2425
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.0.10
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>
> The JcrPropertyMap uses the (wrong) ISO9075 encoding for property names, and 
> this also behaves differently between the read() and readFully() variants.
> 1) ISO9075 is needed for XML names, e.g. for mapping JCR names into Xpath 
> queries. But the set of valid JCR names is much larger (for example "-" is 
> valid, while it is not allowed in ISO9075 and becomes "_x002d_"). 
> org.apache.jackrabbit.util.Text#escapeIllegalJcrChars() must be used instead 
> to escape any string for use as JCR names. [0]
> 2) Inconsistency:
> a) read() will take the key and use ISO9075#encodePath(), before looking up 
> the jcr property using the encoded variant
> b) readFully() will go through all jcr properties and cache them with the key 
> using ISO9075#decode()
> Hence for all valid JCR names, which are not valid under ISO9075 (like 
> "1_prop", "-foo"), these can be looked up using the cached variant b) (as 
> decode() won't touch them), while they cannot be looked up using read() at 
> all due to the forced "arbitrary" escaping.
> I think there should be no auto-magically escaping at all (also not in the 
> accompanying JcrModifiablePropertyMap). Incorrect naming errors should simply 
> be passed through, it is the job of the application to handle that. The 
> framework should not run an arbitrary & undocumented escaping, if it cannot 
> enforce that anyway, since there are other ways to create properties with a 
> different valid char set (using the JCR API).
> [0] http://wiki.apache.org/jackrabbit/EncodingAndEscaping

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




Build failed in Jenkins: sling-samples-1.5 #304

2012-04-12 Thread Apache Jenkins Server
See 

--
[...truncated 1226 lines...]
 [echo] 
**
[INFO] Executed tasks
[INFO] 
[INFO] --- yuicompressor-maven-plugin:1.3.0:compress (default) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nb warnings: 0, nb errors: 0
[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-scr-plugin:1.7.2:scr (generate-scr-scrdescriptor) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources

[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] [INFO] No sources to compile

[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] [INFO] Surefire report directory: 


[INFO] --- maven-surefire-plugin:2.7.2:test (default-test) @ 
org.apache.sling.samples.usermanager.ui ---

---
 T E S T S
---
There are no tests to run.

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] [INFO] Checking unresolved references to 
org.codehaus.mojo.signature:java15:1.0
--- animal-sniffer-maven-plugin:1.7:check (default) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] 
[INFO] --- maven-bundle-plugin:2.0.1:bundle (default-bundle) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.samples.usermanager.ui ---
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-samples-1.5/modules/org.apache.sling.samples$org.apache.sling.samples.usermanager.ui/builds/2012-04-12_10-58-59/archive/org.apache.sling.samples/org.apache.sling.samples.usermanager.ui/0.9-SNAPSHOT/org.apache.sling.samples.usermanager.ui-0.9-SNAPSHOT.pom
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-samples-1.5/modules/org.apache.sling.samples$org.apache.sling.samples.usermanager.ui/builds/2012-04-12_10-58-59/archive/org.apache.sling.samples/org.apache.sling.samples.usermanager.ui/0.9-SNAPSHOT/org.apache.sling.samples.usermanager.ui-0.9-SNAPSHOT.jar
Apr 12, 2012 11:01:06 AM hudson.maven.ExecutedMojo 
WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Building jar: 

[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.samples.usermanager.ui ---
[INFO] Checking legal files in: 
org.apache.sling.samples.usermanager.ui-0.9-SNAPSHOT.jar
[INFO] Checking legal fi

Build failed in Jenkins: sling-contrib-1.5 #855

2012-04-12 Thread Apache Jenkins Server
See 

--
[...truncated 2251 lines...]
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-contrib-1.5/modules/org.apache.sling$org.apache.sling.scripting.velocity/builds/2012-04-12_10-51-22/archive/org.apache.sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.jar
Apr 12, 2012 10:58:36 AM hudson.maven.ExecutedMojo 
WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ 
org.apache.sling.scripting.velocity ---
[INFO] META-INF already added, skipping
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] Building jar: 

[INFO] META-INF already added, skipping
[INFO] META-INF already added, skipping
[INFO] META-INF/LICENSE already added, skipping
[INFO] META-INF/NOTICE already added, skipping
[INFO] META-INF/DEPENDENCIES already added, skipping
[INFO] [INFO] Checking legal files in: 
org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT-sources.jar

[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.scripting.velocity ---
[INFO] [INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.jar

[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
org.apache.sling.scripting.velocity ---
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT-sources.jar
[INFO] [INFO] Local OBR update disabled (enable with -DobrRepository)

[INFO] --- maven-bundle-plugin:2.0.1:install (default-install) @ 
org.apache.sling.scripting.velocity ---
[JENKINS] Archiving 

 to 
/home/hudson/hudson/jobs/sling-contrib-1.5/modules/org.apache.sling$org.apache.sling.scripting.velocity/builds/2012-04-12_10-51-22/archive/org.apache.sling/org.apache.sling.scripting.velocity/2.0.0-SNAPSHOT/org.apache.sling.scripting.velocity-2.0.0-SNAPSHOT-sources.jar
[INFO] 
[INFO] 
[INFO] Building Apache Sling Scripting W3C XML Processing Support 2.0.0-SNAPSHOT
[INFO] 
[INFO] Deleting 

[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ 
org.apache.sling.scripting.xproc ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.scripting.xproc ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
org.apache.sling.scripting.xproc ---
[INFO] [INFO] Using 'UTF-8' encoding to copy filtered resources.

[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
org.apache.sling.scripting.xproc ---
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] [INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks

[INFO] --- maven-antrun-plugin

[jira] [Commented] (SLING-2425) Incorrect and inconsistent escaping of property names used in JcrPropertyMap

2012-04-12 Thread Carsten Ziegeler (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252250#comment-13252250
 ] 

Carsten Ziegeler commented on SLING-2425:
-

Thanks Alex,

ok, it's clear that we should only encode if there is a need to encode and 
obviously the encoding should either be applied always or never and not depend 
on side effects.
I guess/fear we have to do something like Felix suggests earlier on in order to 
a) get this right and b) be compatible

> Incorrect and inconsistent escaping of property names used in JcrPropertyMap
> 
>
> Key: SLING-2425
> URL: https://issues.apache.org/jira/browse/SLING-2425
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.0.10
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>
> The JcrPropertyMap uses the (wrong) ISO9075 encoding for property names, and 
> this also behaves differently between the read() and readFully() variants.
> 1) ISO9075 is needed for XML names, e.g. for mapping JCR names into Xpath 
> queries. But the set of valid JCR names is much larger (for example "-" is 
> valid, while it is not allowed in ISO9075 and becomes "_x002d_"). 
> org.apache.jackrabbit.util.Text#escapeIllegalJcrChars() must be used instead 
> to escape any string for use as JCR names. [0]
> 2) Inconsistency:
> a) read() will take the key and use ISO9075#encodePath(), before looking up 
> the jcr property using the encoded variant
> b) readFully() will go through all jcr properties and cache them with the key 
> using ISO9075#decode()
> Hence for all valid JCR names, which are not valid under ISO9075 (like 
> "1_prop", "-foo"), these can be looked up using the cached variant b) (as 
> decode() won't touch them), while they cannot be looked up using read() at 
> all due to the forced "arbitrary" escaping.
> I think there should be no auto-magically escaping at all (also not in the 
> accompanying JcrModifiablePropertyMap). Incorrect naming errors should simply 
> be passed through, it is the job of the application to handle that. The 
> framework should not run an arbitrary & undocumented escaping, if it cannot 
> enforce that anyway, since there are other ways to create properties with a 
> different valid char set (using the JCR API).
> [0] http://wiki.apache.org/jackrabbit/EncodingAndEscaping

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira