Build failed in Jenkins: sling-samples-1.5 #334

2012-06-05 Thread Apache Jenkins Server 
See 

--
[...truncated 1783 lines...]
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
org.apache.sling.samples.accessmanager.ui ---
mojoSucceeded 
org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)[INFO] 
Using 'UTF-8' encoding to copy filtered resources.

[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ 
org.apache.sling.samples.accessmanager.ui ---
[INFO] Copying 14 resources
[INFO] Copying 3 resources
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)
mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (default) @ 
org.apache.sling.samples.accessmanager.ui ---
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
mojoStarted net.alchim31.maven:yuicompressor-maven-plugin:1.3.0(default)[INFO] 
nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nothing to do, 

 is younger than original, use 'force' option or clean your target
[INFO] nb warnings: 0, nb errors: 0

[INFO] 
[INFO] --- yuicompressor-maven-plugin:1.3.0:compress (default) @ 
org.apache.sling.samples.accessmanager.ui ---
mojoSucceeded net.alchim31.maven:yuicompressor-maven-plugin:1.3.0(default)
mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-compile)[INFO] 
Nothing to compile - all classes are up to date

[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ 
org.apache.sling.samples.accessmanager.ui ---
mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-compile)
mojoStarted org.apache.felix:maven-scr-plugin:1.7.2(generate-scr-scrdescriptor)
[INFO] 
[INFO] --- maven-scr-plugin:1.7.2:scr (generate-scr-scrdescriptor) @ 
org.apache.sling.samples.accessmanager.ui ---
mojoSucceeded 
org.apache.felix:maven-scr-plugin:1.7.2(generate-scr-scrdescriptor)
mojoStarted 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)[INFO]
 Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources

[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ 
org.apache.sling.samples.accessmanager.ui ---
mojoSucceeded 
org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)
mojoStarted 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-testCompile)[INFO] 
No sources to compile

[INFO] 
[INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ 
org.apache.sling.samples.accessmanager.ui ---
mojoSucceeded 
org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-testCompile)
mojoStarted 
org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)[INFO] 
Surefire report directory: 


[INFO] 
[INFO] --- maven-surefire-plugin:2.7.2:test (default-test) @ 
org.apache.sling.samples.accessmanager.ui ---

---
 T E S T S
---
There are no tests to run.

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)
[JENKINS] Recording test results[INFO] Checking unresolved references to 
org.codehaus.mojo.signature:java15:1.0

mojoStarted

Build failed in Jenkins: sling-contrib-1.5 #887

2012-06-05 Thread Apache Jenkins Server 
See 

--
[...truncated 3339 lines...]
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.scripting.xproc ---
mojoSucceeded org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1(default)
mojoStarted 
org.apache.maven.plugins:maven-install-plugin:2.3.1(default-install)[INFO] 
Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.scripting.xproc/2.0.0-SNAPSHOT/org.apache.sling.scripting.xproc-2.0.0-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.scripting.xproc/2.0.0-SNAPSHOT/org.apache.sling.scripting.xproc-2.0.0-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.scripting.xproc/2.0.0-SNAPSHOT/org.apache.sling.scripting.xproc-2.0.0-SNAPSHOT-sources.jar

[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
org.apache.sling.scripting.xproc ---
mojoSucceeded 
org.apache.maven.plugins:maven-install-plugin:2.3.1(default-install)
mojoStarted org.apache.felix:maven-bundle-plugin:2.0.1(default-install)[INFO] 
Local OBR update disabled (enable with -DobrRepository)

[INFO] 
[INFO] --- maven-bundle-plugin:2.0.1:install (default-install) @ 
org.apache.sling.scripting.xproc ---
mojoSucceeded org.apache.felix:maven-bundle-plugin:2.0.1(default-install)
projectSucceeded 
org.apache.sling:org.apache.sling.scripting.xproc:2.0.0-SNAPSHOT
projectStarted 
org.apache.sling:org.apache.sling.launchpad.smx-kernel:2.0.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] Building Apache Sling Features for ServiceMix Kernel 2.0.0-SNAPSHOT
[INFO] 
mojoStarted org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean)
[INFO] 
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ 
org.apache.sling.launchpad.smx-kernel ---
[INFO] Deleting 

mojoSucceeded org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean)
mojoStarted org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ 
org.apache.sling.launchpad.smx-kernel ---
mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java)
mojoStarted org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.1:process (default) @ 
org.apache.sling.launchpad.smx-kernel ---
[INFO] Setting property: classpath.resource.loader.class => 
'org.codehaus.plexus.velocity.ContextClassLoaderResourceLoader'.
[INFO] Setting property: velocimacro.messages.on => 'false'.
[INFO] Setting property: resource.loader => 'classpath'.
[INFO] Setting property: resource.manager.logwhenfound => 'false'.
mojoSucceeded 
org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default)
mojoStarted org.apache.maven.plugins:maven-resources-plugin:2.4.3(filter)
[INFO] 
[INFO] --- maven-resources-plugin:2.4.3:resources (filter) @ 
org.apache.sling.launchpad.smx-kernel ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
mojoSucceeded org.apache.maven.plugins:maven-resources-plugin:2.4.3(filter)
mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
[INFO] 
[INFO] --- maven-antrun-plugin:1.6:run (default) @ 
org.apache.sling.launchpad.smx-kernel ---
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default)
mojoStarted org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default)[INFO] 
Checking unresolved references to org.codehaus.mojo.signature:java15:1.0

[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ 
org.apache.sling.launchpad.smx-kernel ---
mojoSucceed

Jenkins build became unstable: sling-trunk-1.6 #1339

2012-06-05 Thread Apache Jenkins Server 
See

[jira] [Resolved] (SLING-2497) updating a system fragment extension causes an NPE

2012-06-05 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2497.
-

   Resolution: Fixed
Fix Version/s: Installer Core 3.3.8

Fixed both places where a NPE could occur

> updating a system fragment extension causes an NPE
> --
>
> Key: SLING-2497
> URL: https://issues.apache.org/jira/browse/SLING-2497
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Justin Edelson
>Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.3.8
>
>
> When you update a system bundle extension fragment bundle, a NPE is thrown on 
> line 121 of SystemBundleUpdateTask because getResource() returns null. This 
> is because the SystemBundleUpdateTask is created from BundleUpdateTask with a 
> null resource.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SLING-2476) Sling installer swallows exceptions for properties config file parsing

2012-06-05 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2476.
-

   Resolution: Fixed
Fix Version/s: Installer Core 3.3.8

Fixed

> Sling installer swallows exceptions for properties config file parsing
> --
>
> Key: SLING-2476
> URL: https://issues.apache.org/jira/browse/SLING-2476
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.3.4
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Installer Core 3.3.8
>
>
> If there is a syntax error in the properties config file (.config), all you 
> get is this:
> org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create internal 
> resource (resource will be ignored):InstallableResource, priority=100, 
> id=/libs/sling/config/org.apache.sling.i18n.impl.I18NFilter.config 
> java.io.IOException: Unable to read dictionary from input stream: 
> /libs/sling/config/org.apache.sling.i18n.impl.I18NFilter.config
>   at 
> org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:99)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:277)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:316)
>   at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:579)
>   at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:265)
> However, debugging shows there is a more specific IOException message 
> available from the dictionary parser:
> java.io.IOException: Unexpected token 78; expected: 61 (line=2, pos=4)
> InternalResource#readDictionary() is swallowing the IOException in line 250 
> [0]. It should be added to the exception chain.
> [0] 
> http://svn.apache.org/viewvc/sling/trunk/installer/core/src/main/java/org/apache/sling/installer/core/impl/InternalResource.java?revision=1240017&view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (SLING-2497) updating a system fragment extension causes an NPE

2012-06-05 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-2497:
---

Assignee: Carsten Ziegeler

> updating a system fragment extension causes an NPE
> --
>
> Key: SLING-2497
> URL: https://issues.apache.org/jira/browse/SLING-2497
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Reporter: Justin Edelson
>Assignee: Carsten Ziegeler
>
> When you update a system bundle extension fragment bundle, a NPE is thrown on 
> line 121 of SystemBundleUpdateTask because getResource() returns null. This 
> is because the SystemBundleUpdateTask is created from BundleUpdateTask with a 
> null resource.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (SLING-2476) Sling installer swallows exceptions for properties config file parsing

2012-06-05 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-2476:
---

Assignee: Carsten Ziegeler

> Sling installer swallows exceptions for properties config file parsing
> --
>
> Key: SLING-2476
> URL: https://issues.apache.org/jira/browse/SLING-2476
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Affects Versions: Installer Core 3.3.4
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Installer Core 3.3.8
>
>
> If there is a syntax error in the properties config file (.config), all you 
> get is this:
> org.apache.sling.installer.core.impl.OsgiInstallerImpl Cannot create internal 
> resource (resource will be ignored):InstallableResource, priority=100, 
> id=/libs/sling/config/org.apache.sling.i18n.impl.I18NFilter.config 
> java.io.IOException: Unable to read dictionary from input stream: 
> /libs/sling/config/org.apache.sling.i18n.impl.I18NFilter.config
>   at 
> org.apache.sling.installer.core.impl.InternalResource.create(InternalResource.java:99)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.createResources(OsgiInstallerImpl.java:277)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.updateResources(OsgiInstallerImpl.java:316)
>   at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller.runOneCycle(JcrInstaller.java:579)
>   at 
> org.apache.sling.installer.provider.jcr.impl.JcrInstaller$StoppableThread.run(JcrInstaller.java:265)
> However, debugging shows there is a more specific IOException message 
> available from the dictionary parser:
> java.io.IOException: Unexpected token 78; expected: 61 (line=2, pos=4)
> InternalResource#readDictionary() is swallowing the IOException in line 250 
> [0]. It should be added to the exception chain.
> [0] 
> http://svn.apache.org/viewvc/sling/trunk/installer/core/src/main/java/org/apache/sling/installer/core/impl/InternalResource.java?revision=1240017&view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2428) JcrInstaller does not provide hint properties of node location that caused configuration changes

2012-06-05 Thread Carsten Ziegeler (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-2428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289539#comment-13289539
 ] 

Carsten Ziegeler commented on SLING-2428:
-

@Tyson : do you still have this requirement? If so, could you please elaborate?

> JcrInstaller does not provide hint properties of node location that caused 
> configuration changes
> 
>
> Key: SLING-2428
> URL: https://issues.apache.org/jira/browse/SLING-2428
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Core 3.3.4
>Reporter: Tyson Norris
>
> I'm using JcrInstaller to generate config instances for a 
> ManagedServiceFactory. These configurations get a generated service.pid, and 
> no properties indicating that this was generated via jcr node.
> Per the docs at 
> http://sling.apache.org/site/jcr-installer-jcrjcrinstall-and-osgiinstaller.html
> I was looking for this: "A node named like o.a.s.foo.bar-a uses o.a.s.foo.bar 
> as its factory PID creating a configuration with an automatically generated 
> PID. The value of a is stored as an alias property in the configuration to 
> correlate the configuration object with the repository node - demonstrate 
> that." 
> I think that either or both should work:
> - specifying the node name as - with pid=-somename
> - OR the config with  should include a property like 
> "installation.hint" to indicate the location of the config node
> A few noticable problems:
> - In 
> http://svn.apache.org/repos/asf/sling/trunk/installer/providers/jcr/src/main/java/org/apache/sling/installer/provider/jcr/impl/FileNodeConverter.java
>  - It looks like the InstallableResource is created with a Dictionary AND 
> InputStream, and the dictionary gets the hint added, but 
> OsgiInstallerImpl.java ignores the Dictionary if InputStream is provided.
> - It also looks like the hint is added with a value of the parent node - I 
> would expect this to be the actual file node that contains the config, not 
> the parent of the file node.
> - in 
> http://svn.apache.org/repos/asf/sling/trunk/installer/providers/jcr/src/main/java/org/apache/sling/installer/provider/jcr/impl/ConfigNodeConverter.java
>  - should work similar with regard to adding the hint property
> If there is another way to correlate a ManagedServiceFactory config instances 
> with jcr installer sling:OsgiConfig nodes, please let me know.
> Thanks
> Tyson

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2503) Update to new Jackrabbit version to fix JCR-3329

2012-06-05 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-2503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289343#comment-13289343
 ] 

Julian Reschke commented on SLING-2503:
---

Also note that the project currently references 2.3.4, which is from an 
unstable branch. So, minimally, it should use the latest 2.4.* release.


> Update to new Jackrabbit version to fix JCR-3329
> 
>
> Key: SLING-2503
> URL: https://issues.apache.org/jira/browse/SLING-2503
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Affects Versions: JCR Webdav 2.1.0
>Reporter: Carsten Ziegeler
> Fix For: JCR Webdav 2.1.2
>
>
> Once a new jackrabbit release is out, we should update to this release in 
> order to get the fix for JCR.3329

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (SLING-2503) Update to new Jackrabbit version to fix JCR-3329

2012-06-05 Thread Carsten Ziegeler (JIRA) 
Carsten Ziegeler created SLING-2503:
---

 Summary: Update to new Jackrabbit version to fix JCR-3329
 Key: SLING-2503
 URL: https://issues.apache.org/jira/browse/SLING-2503
 Project: Sling
  Issue Type: Task
  Components: JCR
Affects Versions: JCR Webdav 2.1.0
Reporter: Carsten Ziegeler
 Fix For: JCR Webdav 2.1.2


Once a new jackrabbit release is out, we should update to this release in order 
to get the fix for JCR.3329

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2320) Current DOS-prevention for infinity.json can prevent enumeration of children

2012-06-05 Thread Jeff Young (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289232#comment-13289232
 ] 

Jeff Young commented on SLING-2320:
---

The 12/Dec/11 patch still needs to be applied.

Without it performance will be impaired (due to 2 exceptions being thrown per 
node and the result being serialized/de-serialized/re-serialized).

> Current DOS-prevention for infinity.json can prevent enumeration of children
> 
>
> Key: SLING-2320
> URL: https://issues.apache.org/jira/browse/SLING-2320
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.0
>Reporter: Jeff Young
>Assignee: Felix Meschberger
>  Labels: newbie, patch
> Fix For: Servlets Get 2.1.4
>
> Attachments: jsonRenderer.diff, json_get_servlet_rewrite.patch, 
> servlet_tests.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> A request of resource.1.json should always succeed, as it's the primary 
> method for JSON introspection of the repository hierarchy.  DOS protection 
> should only apply to "deep" traversals; that is, anything with a depth 
> greater than 1 (and, in particular, resource.infinity.json).
> For a fuller discussion, see: 
> http://www.mail-archive.com/dev@sling.apache.org/msg13961.html.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2502) Incorrect escaping of property names in JcrModifiablePropertyMap on save

2012-06-05 Thread Carsten Ziegeler (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-2502:


Attachment: org.apache.sling.jcr.resource.patch

Some test testing a jcr:title property (which currently fail)

> Incorrect escaping of property names in JcrModifiablePropertyMap on save
> 
>
> Key: SLING-2502
> URL: https://issues.apache.org/jira/browse/SLING-2502
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.1.0
>Reporter: Alex Parvulescu
> Attachments: SLING-2502.patch, org.apache.sling.jcr.resource.patch
>
>
> This follows SLING-2425 where there was a change in the way JCR properties 
> are escaped before being persited.
> The regression happens for properties that have ":" in the name.
> For example: jcr:title after the #save() call will turn into jcr%3Atitle so 
> the node will end up with a brand new property, instead of having the old 
> jcr:title updated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2502) Incorrect escaping of property names in JcrModifiablePropertyMap on save

2012-06-05 Thread Carsten Ziegeler (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289217#comment-13289217
 ] 

Carsten Ziegeler commented on SLING-2502:
-

Good catch!

I think, the right way would be to modify the save() method to check whether a 
property name is allowed or not:
- if it has a colon, check if the prefix is known - if so check if any other 
character needs escaping
- if the prefix is unknown, to full escaping as is

The clear method clears the whole map which means all properties need to be 
removed, that's why all keys are added

> Incorrect escaping of property names in JcrModifiablePropertyMap on save
> 
>
> Key: SLING-2502
> URL: https://issues.apache.org/jira/browse/SLING-2502
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.1.0
>Reporter: Alex Parvulescu
> Attachments: SLING-2502.patch
>
>
> This follows SLING-2425 where there was a change in the way JCR properties 
> are escaped before being persited.
> The regression happens for properties that have ":" in the name.
> For example: jcr:title after the #save() call will turn into jcr%3Atitle so 
> the node will end up with a brand new property, instead of having the old 
> jcr:title updated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2338) create integration tests for archetypes

2012-06-05 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289205#comment-13289205
 ] 

Julian Reschke commented on SLING-2338:
---

Ok. So let's do this systematically...

1) The reference files are supposed to have just LF?

2) The generated files are supposed to have just LF?



> create integration tests for archetypes
> ---
>
> Key: SLING-2338
> URL: https://issues.apache.org/jira/browse/SLING-2338
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Justin Edelson
>Assignee: Justin Edelson
>
> The Maven Archetype plugin now has the ability to create simple integration 
> tests for archetypes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira