Re: using jdk 6 class in a sling patch

[Chetan Mehrotra]

+1

For new bundles it should be possible to make use of JDK 6 API. Two cases I
require them for

1. JAAS Support (SLING-2623) - Need to use the new API of ConfigurationSpi
2. Managing multiple references (SLING-2575) - Need to use the
ConcurrentSkipListMap for simplifying usage [1] of multiple references (as
required by Amit also)

Chetan Mehrotra
[1] https://gist.github.com/3918574

On Mon, Nov 26, 2012 at 10:36 AM, Amit.. Gupta.  wrote:

> >  * Java 5 by default
>   * Java 6 acceptable (requiring appropriate
>   Bundle-RequiredExceutionEnvironment setup and API checks)
>   * Launchpad will require Java 6 in the future
>
> +1
>
> Thanks,
> Amit
>

Trying to convert Sling Logging -> Logback. How much backwards compatibility do we need?

[Justin Edelson]

I'm taking a run at replacing the internals of the Sling Logging bundle
with Logback. I'm having some trouble mapping our existing configuration
structure to Logback. And I'm wondering how useful an exercise it is in the
first place as one of the reasons (at least for me) in moving to Logback is
the ability to be get more flexibility in terms of different appenders,
file rollover triggering policies, etc.

So... WDYT about a much simpler structure where:
1) On startup, a config file in a location relative to sling.home is
consulted. If it does not exist, some default configuration is used.
2) Once a resource resolver factory is located, the configuration file is
reloaded from a configurable location.
2a) Alternatively, rather than storing the configuration as an XML file in
the repository, store it as a resource structure.

We could also have some script which converts existing sling:OsgiConfig
nodes into the Logback config file, but I have a feeling that's going to be
more trouble than it is worth.

Justin

[jira] [Updated] (SLING-2680) [Tooling] Usability improvements for the Slingclipse import wizard

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-2680:
---

Attachment: SLING-2680.diff

> [Tooling] Usability improvements for the Slingclipse import wizard
> --
>
> Key: SLING-2680
> URL: https://issues.apache.org/jira/browse/SLING-2680
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Reporter: Robert Munteanu
>Priority: Minor
> Attachments: SLING-2680.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The wizard can be improved a little in terms of usability.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2680) [Tooling] Usability improvements for the Slingclipse import wizard

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503965#comment-13503965
 ] 

Robert Munteanu commented on SLING-2680:


- use the wizard's container to run the import and clean up the progress 
reporting for when we'll actually be able to use it
- make sure to report and log import errors whenever they happen
- update the wizard's name to include 'Sling' so that filtering in the import 
wizard selection dialog includes it
- use the Sling logo as a wizard icon and banner image
- tweaks to import page error reporting

The referenced 'sling-logo.png' image is just 
http://sling.apache.org/site/media.data/logo.png . It's not the proper scale or 
dimension, but makes things look a bit more into place.


> [Tooling] Usability improvements for the Slingclipse import wizard
> --
>
> Key: SLING-2680
> URL: https://issues.apache.org/jira/browse/SLING-2680
> Project: Sling
>  Issue Type: Sub-task
>  Components: Extensions
>Reporter: Robert Munteanu
>Priority: Minor
> Attachments: SLING-2680.diff
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> The wizard can be improved a little in terms of usability.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (SLING-2680) [Tooling] Usability improvements for the Slingclipse import wizard

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-2680:
--

 Summary: [Tooling] Usability improvements for the Slingclipse 
import wizard
 Key: SLING-2680
 URL: https://issues.apache.org/jira/browse/SLING-2680
 Project: Sling
  Issue Type: Sub-task
  Components: Extensions
Reporter: Robert Munteanu
Priority: Minor


The wizard can be improved a little in terms of usability.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SLING-2679) JcrJavaCompiler should use class writer

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2679.
-

Resolution: Fixed

> JcrJavaCompiler should use class writer
> ---
>
> Key: SLING-2679
> URL: https://issues.apache.org/jira/browse/SLING-2679
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Compiler 2.0.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: JCR Compiler 2.1.0
>
>
> Instead of doing class writing magic by itself, the JcrJavaCompiler should 
> rely on the class loader writer service

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (SLING-2679) JcrJavaCompiler should use class writer

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-2679:
---

 Summary: JcrJavaCompiler should use class writer
 Key: SLING-2679
 URL: https://issues.apache.org/jira/browse/SLING-2679
 Project: Sling
  Issue Type: Bug
  Components: JCR
Affects Versions: JCR Compiler 2.0.4
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Compiler 2.0.6


Instead of doing class writing magic by itself, the JcrJavaCompiler should rely 
on the class loader writer service

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: svn commit: r1412583 - /sling/trunk/bundles/extensions/settings/src/main/java/org/apache/sling/settings/impl/SlingSettingsServiceImpl.java

[Carsten Ziegeler]

I took care of this - it's now more informative and in debug mode

Carsten

2012/11/26 Felix Meschberger :
> Hi,
>
> Am 22.11.2012 um 16:18 schrieb  
> :
>
>> Author: bdelacretaz
>> Date: Thu Nov 22 15:18:04 2012
>> New Revision: 1412583
>>
>> URL: http://svn.apache.org/viewvc?rev=1412583&view=rev
>> Log:
>> SLING-2674 - take new run mode options into account when starting on an 
>> older Sling instance
>>
>> Modified:
>> +logger.info("isInstall={}, isUpgrade={}", isInstall, isUpgrade);
>
> I think that this message is confusing: I suggest to beef it up with more 
> prose to indicate, what exactly is being logged. Also, I am not sure, whether 
> using INFO level is appropriate...
>
> Regards
> Felix
>



-- 
Carsten Ziegeler
cziege...@apache.org

[jira] [Resolved] (SLING-2678) Parallel compilation if same jsp is requested in parallel

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2678.
-

Resolution: Fixed

I've corrected the isValid check

> Parallel compilation if same jsp is requested in parallel
> -
>
> Key: SLING-2678
> URL: https://issues.apache.org/jira/browse/SLING-2678
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.0.24
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Scripting JSP 2.0.26
>
>
> If the same jsp is requested in parallel for the first time, it might happen 
> that two wrappers are created and the second request actually destroys the 
> runtime context as well

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2678) Parallel compilation if same jsp is requested in parallel

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503800#comment-13503800
 ] 

Carsten Ziegeler commented on SLING-2678:
-

This leads to parallel compilation attempts which further down the road might 
lead to jcr exceptions when the class file is tried to be written to the 
repository in parallel

> Parallel compilation if same jsp is requested in parallel
> -
>
> Key: SLING-2678
> URL: https://issues.apache.org/jira/browse/SLING-2678
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting JSP 2.0.24
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Scripting JSP 2.0.26
>
>
> If the same jsp is requested in parallel for the first time, it might happen 
> that two wrappers are created and the second request actually destroys the 
> runtime context as well

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (SLING-2678) Parallel compilation if same jsp is requested in parallel

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-2678:
---

 Summary: Parallel compilation if same jsp is requested in parallel
 Key: SLING-2678
 URL: https://issues.apache.org/jira/browse/SLING-2678
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting JSP 2.0.24
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Scripting JSP 2.0.26


If the same jsp is requested in parallel for the first time, it might happen 
that two wrappers are created and the second request actually destroys the 
runtime context as well


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: [jira] [Resolved] (SLING-2674) SlingSettingsServiceImpl should detect and handle upgrades

[Ryan Lunka]

Unsubscribe

--

Ryan D. Lunka





On Nov 26, 2012, at 5:20 AM, Carsten Ziegeler (JIRA)  wrote:

> 
> [ 
> https://issues.apache.org/jira/browse/SLING-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
> 
> Carsten Ziegeler resolved SLING-2674.
> -
> 
>Resolution: Fixed
> 
> Rewrite the implementation to use the startup handler service
> 
>> SlingSettingsServiceImpl should detect and handle upgrades
>> --
>> 
>>Key: SLING-2674
>>URL: https://issues.apache.org/jira/browse/SLING-2674
>>Project: Sling
>> Issue Type: Bug
>> Components: Extensions
>>   Affects Versions: Extensions Settings 1.2.0
>>   Reporter: Bertrand Delacretaz
>>   Assignee: Carsten Ziegeler
>>Fix For: Extensions Settings 1.2.2
>> 
>> 
>> With the recent run modes handling changes, starting a Sling instance as an 
>> upgrade (i.e. on an existing sling folder) might define new default run 
>> modes that were not present in the old instance but need to be active on the 
>> upgraded instance.
>> In this case, the SlingSettingsServiceImpl needs to evaluate the run mode 
>> options against the existing run modes, in a similar way to an "install" 
>> startup.
> 
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators
> For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SLING-2677) Compilation should work with no provided class loader

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2677.
-

Resolution: Fixed

> Compilation should work with no provided class loader
> -
>
> Key: SLING-2677
> URL: https://issues.apache.org/jira/browse/SLING-2677
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Compiler 2.0.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Commons Compiler 2.0.8
>
>
> If a class loader writer is provided which is not able to do class loading, 
> compilation currently fails.
> For compatibility we should support compilation in this case anyway

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (SLING-2677) Compilation should work with no provided class loader

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-2677:
---

 Summary: Compilation should work with no provided class loader
 Key: SLING-2677
 URL: https://issues.apache.org/jira/browse/SLING-2677
 Project: Sling
  Issue Type: Bug
  Components: Commons
Affects Versions: Commons Compiler 2.0.6
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
Priority: Minor
 Fix For: Commons Compiler 2.0.8


If a class loader writer is provided which is not able to do class loading, 
compilation currently fails.
For compatibility we should support compilation in this case anyway

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Jenkins build is back to normal : sling-trunk-1.6 #1526

[Apache Jenkins Server]

See 

[jira] [Resolved] (SLING-2674) SlingSettingsServiceImpl should detect and handle upgrades

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2674.
-

Resolution: Fixed

Rewrite the implementation to use the startup handler service

> SlingSettingsServiceImpl should detect and handle upgrades
> --
>
> Key: SLING-2674
> URL: https://issues.apache.org/jira/browse/SLING-2674
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Extensions Settings 1.2.0
>Reporter: Bertrand Delacretaz
>Assignee: Carsten Ziegeler
> Fix For: Extensions Settings 1.2.2
>
>
> With the recent run modes handling changes, starting a Sling instance as an 
> upgrade (i.e. on an existing sling folder) might define new default run modes 
> that were not present in the old instance but need to be active on the 
> upgraded instance.
> In this case, the SlingSettingsServiceImpl needs to evaluate the run mode 
> options against the existing run modes, in a similar way to an "install" 
> startup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

RE: using jdk 6 class in a sling patch

[Amit.. Gupta.]

>  * Java 5 by default
  * Java 6 acceptable (requiring appropriate
  Bundle-RequiredExceutionEnvironment setup and API checks)
  * Launchpad will require Java 6 in the future

+1

Thanks,
Amit

[jira] [Resolved] (SLING-2675) Make startup mode available as a framework properties

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-2675.
-

Resolution: Won't Fix

As mentioned above, we have the service which is a much more reliable way and 
can be made to work when the launchpad is not used as well

> Make startup mode available as a framework properties
> -
>
> Key: SLING-2675
> URL: https://issues.apache.org/jira/browse/SLING-2675
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.4.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (SLING-2675) Make startup mode available as a framework properties

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-2675:


Fix Version/s: (was: Launchpad Base 2.4.2)

> Make startup mode available as a framework properties
> -
>
> Key: SLING-2675
> URL: https://issues.apache.org/jira/browse/SLING-2675
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.4.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Re: using jdk 6 class in a sling patch

[Felix Meschberger]

(Moving Dev discussions to the Dev list)

Hi Amit,

IIRC we had discussions before, but at that time decided to stick with Java 5. 
Times are changing, Java 5 is vanishing, Java 6 being EOL-ed, ...

I think we should pick this discussion up again and say:

  * Java 5 by default
  * Java 6 acceptable (requiring appropriate
  Bundle-RequiredExceutionEnvironment setup and API checks)
  * Launchpad will require Java 6 in the future

WDYT ?

Regards
Felix

Am 23.11.2012 um 12:00 schrieb Amit.. Gupta.:

> Hi Guys,
> 
> I am working on a sling patch and planning to use a JDK6 class [0].
> 
> What is the min JDK requirement for sling? Are we planning to move to JDK6?
> 
> Thanks,
> Amit
> [0] 
> http://docs.oracle.com/javase/6/docs/api/index.html?java/util/concurrent/ConcurrentSkipListMap.html

[jira] [Reopened] (SLING-2674) SlingSettingsServiceImpl should detect and handle upgrades

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-2674:
-


> SlingSettingsServiceImpl should detect and handle upgrades
> --
>
> Key: SLING-2674
> URL: https://issues.apache.org/jira/browse/SLING-2674
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Extensions Settings 1.2.0
>Reporter: Bertrand Delacretaz
>Assignee: Carsten Ziegeler
> Fix For: Extensions Settings 1.2.2
>
>
> With the recent run modes handling changes, starting a Sling instance as an 
> upgrade (i.e. on an existing sling folder) might define new default run modes 
> that were not present in the old instance but need to be active on the 
> upgraded instance.
> In this case, the SlingSettingsServiceImpl needs to evaluate the run mode 
> options against the existing run modes, in a similar way to an "install" 
> startup.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (SLING-2675) Make startup mode available as a framework properties

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-2675:
-


> Make startup mode available as a framework properties
> -
>
> Key: SLING-2675
> URL: https://issues.apache.org/jira/browse/SLING-2675
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.4.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Launchpad Base 2.4.2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2675) Make startup mode available as a framework properties

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503664#comment-13503664
 ] 

Carsten Ziegeler commented on SLING-2675:
-

There are use cases, like the settings service which need the startup mode 
before the startup is finished.

Actually, the settings service is one of them. When adding this I didn't 
realize that the startup handler interface already allows this use case.

So, I think we can remove this feature again and I'll rewrite the settings to 
use the startup handler

> Make startup mode available as a framework properties
> -
>
> Key: SLING-2675
> URL: https://issues.apache.org/jira/browse/SLING-2675
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.4.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Launchpad Base 2.4.2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (SLING-2675) Make startup mode available as a framework properties

[Felix Meschberger (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503662#comment-13503662
 ] 

Felix Meschberger commented on SLING-2675:
--

Why ?

> Make startup mode available as a framework properties
> -
>
> Key: SLING-2675
> URL: https://issues.apache.org/jira/browse/SLING-2675
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
>Affects Versions: Launchpad Base 2.4.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Launchpad Base 2.4.2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira