[jira] [Commented] (SLING-3021) Use service properties for HC meta data and improve JMX registration
[ https://issues.apache.org/jira/browse/SLING-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13743582#comment-13743582 ] Carsten Ziegeler commented on SLING-3021: - In a first step, I removed the separate constants class, added the properties as service props to the HealthCheck interface and updated all code to use the service ref props instead of the getInfos() method. Rev 1515281 Use service properties for HC meta data and improve JMX registration Key: SLING-3021 URL: https://issues.apache.org/jira/browse/SLING-3021 Project: Sling Issue Type: Improvement Reporter: Carsten Ziegeler As discussed in the mailing list, we can simplify the health check api by using service properties for all meta data of a HC. In addition, the jmx registration bridge needs updates on how to handle if two HC services are using the same name for registration Mail threads: http://mail-archives.us.apache.org/mod_mbox/sling-dev/201308.mbox/%3CCAKkCf4r89JbsVP_-RQK=r304wbl8gqpzaq4rw3z9sijwbbo...@mail.gmail.com%3E http://mail-archives.us.apache.org/mod_mbox/sling-dev/201308.mbox/%3ccakkcf4q79no26va542s_qghof1f1uvsjnyls6as_2xqczre...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build became unstable: sling-contrib-1.6 #1054
See https://builds.apache.org/job/sling-contrib-1.6/1054/changes
Jenkins build became unstable: sling-contrib-1.6 » Apache Sling Launchpad Karaf - Integration Tests #1054
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/1054/
[jira] [Created] (SLING-3024) Move SimpleConstraintChecker to healthchecks bundle
Carsten Ziegeler created SLING-3024: --- Summary: Move SimpleConstraintChecker to healthchecks bundle Key: SLING-3024 URL: https://issues.apache.org/jira/browse/SLING-3024 Project: Sling Issue Type: Bug Components: Extensions Reporter: Carsten Ziegeler The SimpleConstraintChecker is useful for scripted tests and therefore should be moved into the healthchecks bundle. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2987) Simplified health check services
[ https://issues.apache.org/jira/browse/SLING-2987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-2987: Fix Version/s: healthcheck-api 1.0.0 Simplified health check services Key: SLING-2987 URL: https://issues.apache.org/jira/browse/SLING-2987 Project: Sling Issue Type: Improvement Components: Health Check Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Priority: Minor Fix For: healthcheck-api 1.0.0 Attachments: webconsole-is-back.jpg After some prototyping, the health check tools are ready for a rewrite that will make them simpler and more OSGi friendly. The functionality will be similar but with much less code, more focused on the actual use cases that have emerged during prototyping. The new API is being discussed on list, http://markmail.org/thread/i6ib7tgax4cn2sss -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build is back to stable : sling-trunk-1.7 #205
See https://builds.apache.org/job/sling-trunk-1.7/205/changes
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Launchpad Base #205
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.base/205/
[jira] [Resolved] (SLING-3024) Move SimpleConstraintChecker to healthchecks bundle
[ https://issues.apache.org/jira/browse/SLING-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3024. - Resolution: Fixed Fix Version/s: healthcheck-api 1.0.0 Assignee: Carsten Ziegeler I've movd the class and also removed the dependency to a slf4j impl 1.6.0, rev 1515292 Move SimpleConstraintChecker to healthchecks bundle --- Key: SLING-3024 URL: https://issues.apache.org/jira/browse/SLING-3024 Project: Sling Issue Type: Bug Components: Extensions Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: healthcheck-api 1.0.0 The SimpleConstraintChecker is useful for scripted tests and therefore should be moved into the healthchecks bundle. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Requiring Java 6 for a Sling bundle
Hi, just a reminder, if your bundle requires Java 6, please simply use the provided functionality of our parent pom and do: properties sling.java.version6/sling.java.version /properties This configures all required plugins accordingly and also adds a header to your bundle stating the requirement. Don't configure all the plugins in your pom by hand. Thanks Carsten -- Carsten Ziegeler cziege...@apache.org
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Launchpad Testing #1830
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/1830/
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #1830
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/1830/
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #1830
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/1830/
Jenkins build is still unstable: sling-trunk-1.6 #1830
See https://builds.apache.org/job/sling-trunk-1.6/changes
Jenkins build is back to stable : sling-contrib-1.6 » Apache Sling Launchpad Karaf - Integration Tests #1055
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.launchpad.karaf-integration-tests/1055/
Jenkins build is back to stable : sling-contrib-1.6 #1055
See https://builds.apache.org/job/sling-contrib-1.6/1055/changes
Re: 500 Error when obtaining a resource
Hi, Initially, just to verify that you can get the CassandraResourceProvider to work, just take the code from the PlanetProvider and send back a Map with 1 value (eg path). Once you have that working and can perform a get on the resource, then you need to populate that map with the values associated with the columns in the Cassandra row that represents the Cassandra resource. To give the data in Cassandra some reality you can get you data population code to add the following columns to every cassandra row. path : the path of the resource created : a long representing the time (System.currentTimeMillis()) when the resource was created. when you have done that the following test code should be pass. ValueMap vm = resourceResolver.get(/content/cassandra/testitem).adapTo(ValueMap.class); Assert.assertNotNull(vm.get(path)); Assert.assertTrue(((String)vm.get(path)).length()0); Assert.assertNotNull(vm.get(created)); Assert.assertTrue(((Long)vm.get(path)) System.currentTimeMillis()); Best Regards Ian On 18 August 2013 22:35, Dishara Wijewardana ddwijeward...@gmail.com wrote: Hi Ian , Thanks for the clarification. Each PlanetResource value map has two predefined properties (keys) in its Map. name and distance. I looked in to the code of PlanetResource/Provider end to end. I am trying the understand the rationale behind this so that I can incooperate this to CassandraResource. - To obtain a PlanetResource, the implementation always returns a PlanetResource on the availability of the Map it maintains PLANETS. (can see in getResource/listResource) - The content of the planet map ONLY has a Pre-Defined number of key/values. (some planet names and its distances). Because PLANETS map only populated from the static code block from the provider. - After server starts the ONLY keys PLANETS map have is i.e /planets/mercury/ /planets/earth/ and etc. Also for some test there is also /planets/earth/moon. And its corresponding PlanetValueMap. - As per current code in planet resource; if I do a PlanetResouceProvide#getResource(/planets/myplanet/moon1) this returns NULL. It returns something only when we pass those pre defined paths. i.e /planets/mercury/. In CassandraResourceProvider I do not refer any map, but rather directly deals with the Cassandra DB, after decoding the path to column family key. Is this PlanetResource provider behavior correct ? If so how my Cassandra Provider/Resource should map to this? Should I define pre defined column families like this. Thanks On Sun, Aug 18, 2013 at 1:43 PM, Ian Boston i...@tfd.co.uk wrote: Hi, The annotations in PlanetResource add OSGi properties and code that registers the class as adatable from a PlanetResource to a ValueMap. You need to do the same for CassandraResource. The contents of the ValueMap (backed by a Map), should be selected properties of the Cassandra row. (ie the names and values of the columns). Ian On 17 August 2013 06:16, Dishara Wijewardana ddwijeward...@gmail.com wrote: Hi all, Seems the error I have posted is wrong. The above error is correct, because I am trying to acquire a non existing resource. (I saw in the doc, the way jcr resources get resolved, there it defines a resourcePathInfo as .html/.json where if you add a node as /foo/bar) you can view the content of it through /foo/bar.html or /foo/bar.json. In my case If I do the same, the resource that I have stored is /content/cassandra/1K/0 , but above NPE comes when I tried * http://localhost:8080/content/cassandra/1K/0.html*. (NOTE: I have also set resourcePathInfo =.html in resource meta data). I am getting following when I do the correct sample path * http://localhost:8080/content/cassandra/1K/0. *The unsupported exception is thrown by me on resource.adaptTo since I did not see any requirement of implementing that. Is it required to implement adaptTo method ? What does it suppose to do ? ( I believe now up to this error point, my request has come in the correct path , and this is something I should fix) I checked on PlanetResource impl class. There I found following which I do not have in my CassandraResource class. What these annotations means ? @Adaptable(adaptableClass=Resource.class, adapters={ @Adapter({ValueMap.class}) }) * * Internal Server Error (500) The requested URL /content/cassandra/num4K/0 resulted in an error in org.apache.sling.servlets.get.DefaultGetServlet. Exception: java.lang.UnsupportedOperationException at org.apache.sling.cassandra.resource.provider.CassandraResource.adaptTo(CassandraResource.java:186) at org.apache.sling.servlets.get.impl.helpers.HtmlRendererServlet.doGet(HtmlRendererServlet.java:63) at org.apache.sling.api.servlets.SlingSafeMethodsServlet.mayService(SlingSafeMethodsServlet.java:268) at
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Sample Integration Tests #1831
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/1831/
Jenkins build is back to stable : sling-trunk-1.6 #1831
See https://builds.apache.org/job/sling-trunk-1.6/1831/changes
Build failed in Jenkins: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1832
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/1832/ -- [INFO] Deleting https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target [INFO] Deleting https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/ (includes = [derby.log, cachedir, sling, jackrabbit], excludes = []) [INFO] Executing tasks main: [INFO] Executed tasks [INFO] Using bundle list file from /home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/launchpad/builder/target/bundleList.xml [INFO] merging partial bundle list for org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT [INFO] merging configuration from partial bundle list for org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip [INFO] Copying base artifact from /home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/launchpad/base/target/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/org.apache.sling.launchpad.base.jar. [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/commons-io/commons-io/1.4/commons-io-1.4.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/commons-io-1.4.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/commons-fileupload/commons-fileupload/1.2.2/commons-fileupload-1.2.2.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/commons-fileupload-1.2.2.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/commons-collections-3.2.1.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/commons-codec/commons-codec/1.6/commons-codec-1.6.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/commons-codec-1.6.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/commons-lang/commons-lang/2.5/commons-lang-2.5.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/commons-lang-2.5.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/commons/commons-math/2.2/commons-math-2.2.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/commons-math-2.2.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/geronimo/bundles/commons-httpclient/3.1_1/commons-httpclient-3.1_1.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/commons-httpclient-3.1_1.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/bundles/commons/osgi/target/org.apache.sling.commons.osgi-2.2.1-SNAPSHOT.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/org.apache.sling.commons.osgi-2.2.1-SNAPSHOT.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.mime/2.1.4/org.apache.sling.commons.mime-2.1.4.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/org.apache.sling.commons.mime-2.1.4.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.classloader/1.3.0/org.apache.sling.commons.classloader-1.3.0.jar to https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/ws/target/launchpad-bundles/resources/bundles/0/org.apache.sling.commons.classloader-1.3.0.jar [INFO] Copying bundle from /home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/bundles/commons/scheduler/target/org.apache.sling.commons.scheduler-2.3.5-SNAPSHOT.jar to
[jira] [Commented] (SLING-3021) Use service properties for HC meta data and improve JMX registration
[ https://issues.apache.org/jira/browse/SLING-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13743739#comment-13743739 ] Carsten Ziegeler commented on SLING-3021: - I rewrote the jmx registration: a health check is now only registered, if it sets the hc.mbean.name property. This value is used for the name property of the object name. All services with such a property are registered in the domain org.apache.sling.healthcheck and have the type property set to HealthCheck. If there is more than one service with the same hc.mbean.name property, the one with highest service ranking is used. Rev 1515349 Use service properties for HC meta data and improve JMX registration Key: SLING-3021 URL: https://issues.apache.org/jira/browse/SLING-3021 Project: Sling Issue Type: Improvement Reporter: Carsten Ziegeler As discussed in the mailing list, we can simplify the health check api by using service properties for all meta data of a HC. In addition, the jmx registration bridge needs updates on how to handle if two HC services are using the same name for registration Mail threads: http://mail-archives.us.apache.org/mod_mbox/sling-dev/201308.mbox/%3CCAKkCf4r89JbsVP_-RQK=r304wbl8gqpzaq4rw3z9sijwbbo...@mail.gmail.com%3E http://mail-archives.us.apache.org/mod_mbox/sling-dev/201308.mbox/%3ccakkcf4q79no26va542s_qghof1f1uvsjnyls6as_2xqczre...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Launchpad Base #208
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.base/208/
Jenkins build became unstable: sling-trunk-1.7 #208
See https://builds.apache.org/job/sling-trunk-1.7/208/changes
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #1833
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/1833/
Jenkins build is unstable: sling-trunk-1.6 #1833
See https://builds.apache.org/job/sling-trunk-1.6/1833/changes
Jenkins build is back to normal : sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #1833
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing-war/1833/
Re: 500 Error when obtaining a resource
Hi Ian, Thank you very much for the explanation. I did the changes and commited it. If you see on CassandraResource and CassandraResourceProvider, you will see I have done similar to Planet Resource. And when I do a http://localhost:8080/cassandra/pnode1/cnode1/ I am not seeing any errors in BE and either nothing get seen on the browser. It's a blank page with no errors. So apparently it seems work. And when I evaluated followings they worked fine :-). I currently only added path property only for the map. ValueMap vm = resourceResolver.get(/content/cassandra/testitem).adapTo(ValueMap.class); Assert.assertNotNull(vm.get(path)); Assert.assertTrue(((String)vm.get(path)).length()0); So how should we test 1M record test on top of this (because I am getting a blank response on the browser) ?. Even in that case I think I have to populate the Map with 1M records for instance. (Correct me if I am wrong). But if it is the case, this will consume quite a lot of memory to keep a 1M size hash map. Please advice how to proceed. Thanks On Mon, Aug 19, 2013 at 1:40 PM, Ian Boston i...@tfd.co.uk wrote: Hi, Initially, just to verify that you can get the CassandraResourceProvider to work, just take the code from the PlanetProvider and send back a Map with 1 value (eg path). Once you have that working and can perform a get on the resource, then you need to populate that map with the values associated with the columns in the Cassandra row that represents the Cassandra resource. To give the data in Cassandra some reality you can get you data population code to add the following columns to every cassandra row. path : the path of the resource created : a long representing the time (System.currentTimeMillis()) when the resource was created. when you have done that the following test code should be pass. ValueMap vm = resourceResolver.get(/content/cassandra/testitem).adapTo(ValueMap.class); Assert.assertNotNull(vm.get(path)); Assert.assertTrue(((String)vm.get(path)).length()0); Assert.assertNotNull(vm.get(created)); Assert.assertTrue(((Long)vm.get(path)) System.currentTimeMillis()); Best Regards Ian On 18 August 2013 22:35, Dishara Wijewardana ddwijeward...@gmail.com wrote: Hi Ian , Thanks for the clarification. Each PlanetResource value map has two predefined properties (keys) in its Map. name and distance. I looked in to the code of PlanetResource/Provider end to end. I am trying the understand the rationale behind this so that I can incooperate this to CassandraResource. - To obtain a PlanetResource, the implementation always returns a PlanetResource on the availability of the Map it maintains PLANETS. (can see in getResource/listResource) - The content of the planet map ONLY has a Pre-Defined number of key/values. (some planet names and its distances). Because PLANETS map only populated from the static code block from the provider. - After server starts the ONLY keys PLANETS map have is i.e /planets/mercury/ /planets/earth/ and etc. Also for some test there is also /planets/earth/moon. And its corresponding PlanetValueMap. - As per current code in planet resource; if I do a PlanetResouceProvide#getResource(/planets/myplanet/moon1) this returns NULL. It returns something only when we pass those pre defined paths. i.e /planets/mercury/. In CassandraResourceProvider I do not refer any map, but rather directly deals with the Cassandra DB, after decoding the path to column family key. Is this PlanetResource provider behavior correct ? If so how my Cassandra Provider/Resource should map to this? Should I define pre defined column families like this. Thanks On Sun, Aug 18, 2013 at 1:43 PM, Ian Boston i...@tfd.co.uk wrote: Hi, The annotations in PlanetResource add OSGi properties and code that registers the class as adatable from a PlanetResource to a ValueMap. You need to do the same for CassandraResource. The contents of the ValueMap (backed by a Map), should be selected properties of the Cassandra row. (ie the names and values of the columns). Ian On 17 August 2013 06:16, Dishara Wijewardana ddwijeward...@gmail.com wrote: Hi all, Seems the error I have posted is wrong. The above error is correct, because I am trying to acquire a non existing resource. (I saw in the doc, the way jcr resources get resolved, there it defines a resourcePathInfo as .html/.json where if you add a node as /foo/bar) you can view the content of it through /foo/bar.html or /foo/bar.json. In my case If I do the same, the resource that I have stored is /content/cassandra/1K/0 , but above NPE comes when I tried * http://localhost:8080/content/cassandra/1K/0.html*. (NOTE: I have also set resourcePathInfo =.html in resource meta data). I am getting following when I do the correct sample path *