Re: [VOTE] Release Apache Sling Maven JSPC Plugin 2.0.8

[Felix Meschberger]

+1

Regards
Felix

—
Felix Meschberger  |  Principal Scientist  |  Adobe



Am 10.12.2013 um 01:44 schrieb Carsten Ziegeler :

> Hi,
> 
> its time for a new maven plugin release, we fixed one issue
> 
> Sling Maven JSPC Plugin 2.0.8
> https://issues.apache.org/jira/browse/SLING-2730
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-032/
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 032 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
> [ ] +1 Approve the release
> [ ]  0 Don't care
> [ ] -1 Don't release, because ...
> 
> This vote will be open for 72 hours.
> 
> Regards
> Carsten
> -- 
> Carsten Ziegeler
> cziege...@apache.org

Re: [Sling Event] difference between JobConsumer and JobExecutor

[Tommaso Teofili]

got it, thanks a lot Victor and Carsten for the explanation.
Regards,
Tommaso


2013/12/10 Carsten Ziegeler 

> Hi
>
> as Victor points out JobExecutor provides more functionality for the
> implementor (like tracking, logging etc). JobConsumer is the preceding
> variant which I didn't want to deprecate right now as it allows you to
> implement a simpler interface if your implementation does not care about
> the additional features.
>
> Carsten
>
>
> 2013/11/18 Victor Saar 
>
> > Hi Tommaso,
> >
> > JobExecutor has recently replaced JobConsumer while support for progress
> > tracking was introduced. AFAIK JobConsumer should have been deprecated
> > already. I guess the documentation was not yet updated accordingly.
> >
> > Ciao, Victor.
> >
> > On 15.11.13 14:39, "Tommaso Teofili"  wrote:
> >
> > >Hi all,
> > >
> > >while working with Sling Event I noticed there's a somewhat similar API
> > >for
> > >consuming a Job defined in JobConsumer and JobExecutor.
> > >The API and javadoc for them are quite similar except that the executor
> > >also gets an ExecutorContext while executing the Job.
> > >
> > >Is there any guideline about which one is better suitable for what
> > >scenario
> > >and / or if one should just use one instead of the other in general?
> > >
> > >Thanks in advance for your help,
> > >Regards,
> > >Tommaso
> > >
> > >[1] :
> > >
> >
> http://sling.apache.org/documentation/the-sling-engine/eventing-and-jobs.h
> > >tml
> > >[2] :
> > >
> >
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-jo
> > >b-handling.html
> >
> >
>
>
> --
> Carsten Ziegeler
> cziege...@apache.org
>

[jira] [Resolved] (SLING-3276) Escape quotes and double quotes when escaping for XML

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3276.
-

Resolution: Fixed

Added the additional escaping

> Escape quotes and double quotes when escaping for XML
> -
>
> Key: SLING-3276
> URL: https://issues.apache.org/jira/browse/SLING-3276
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Affects Versions: API 2.4.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: API 2.5.0
>
>
> Currently only <, > and & are escaped in the ResponseUtil, we should extend 
> this to " and ' in order to use the same functionality for writing out 
> attributes as well as text



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3276) Escape quotes and double quotes when escaping for XML

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-3276:
---

 Summary: Escape quotes and double quotes when escaping for XML
 Key: SLING-3276
 URL: https://issues.apache.org/jira/browse/SLING-3276
 Project: Sling
  Issue Type: Improvement
  Components: API
Affects Versions: API 2.4.2
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: API 2.5.0


Currently only <, > and & are escaped in the ResponseUtil, we should extend 
this to " and ' in order to use the same functionality for writing out 
attributes as well as text



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: [VOTE] Release Apache Sling Maven JSPC Plugin 2.0.8

[Carsten Ziegeler]

+1

Carsten


2013/12/10 Carsten Ziegeler 

> Hi,
>
> its time for a new maven plugin release, we fixed one issue
>
> Sling Maven JSPC Plugin 2.0.8
>  https://issues.apache.org/jira/browse/SLING-2730
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-032/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 032 /tmp/sling-staging
>
> Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
> This vote will be open for 72 hours.
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> cziege...@apache.org
>



-- 
Carsten Ziegeler
cziege...@apache.org

buildbot success in ASF Buildbot on sling-trunk-oak

[buildbot]

The Buildbot has detected a restored build on builder sling-trunk-oak while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/sling-trunk-oak/builds/25

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: osiris_ubuntu

Build Reason: downstream
Build Source Stamp: [branch sling/trunk] 1549762
Blamelist: cziegeler

Build succeeded!

sincerely,
 -The Buildbot

[jira] [Created] (SLING-3275) Add Buffered Logging Configuration in "Apache Sling Logging Logger"

[Chetan Mehrotra (JIRA)]

Chetan Mehrotra created SLING-3275:
--

 Summary: Add Buffered Logging Configuration in "Apache Sling 
Logging Logger"
 Key: SLING-3275
 URL: https://issues.apache.org/jira/browse/SLING-3275
 Project: Sling
  Issue Type: Improvement
  Components: Commons
Affects Versions: Commons Log 4.0.0
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor


Logback supports buffered logging [1]. As of now it can be used directly by 
configuring the appender via Logback xml file [2]. To simplify its usage we 
should expose a config as part of OSGi config

[1] http://logback.qos.ch/manual/encoders.html#immediateFlush
[2] 
http://sling.apache.org/documentation/development/logging.html#wzxhzdk13wzxhzdk14configuring-osgi-appenders-in-the-logback-config




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

buildbot failure in ASF Buildbot on sling-trunk-oak

[buildbot]

The Buildbot has detected a new failure on builder sling-trunk-oak while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/sling-trunk-oak/builds/24

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: osiris_ubuntu

Build Reason: downstream
Build Source Stamp: [branch sling/trunk] 1549759
Blamelist: cziegeler

BUILD FAILED: failed compile

sincerely,
 -The Buildbot

[jira] [Created] (SLING-3274) Properly xml escape web console output

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-3274:
---

 Summary: Properly xml escape web console output
 Key: SLING-3274
 URL: https://issues.apache.org/jira/browse/SLING-3274
 Project: Sling
  Issue Type: Improvement
  Components: Authentication
Affects Versions: Auth Core 1.1.4
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Auth Core 1.1.6


The output of the web console plugin is not properly xml escaped, if some auth 
reg properties contain a <, > or & the output will be broken



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Resolved] (SLING-3274) Properly xml escape web console output

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3274.
-

Resolution: Fixed

> Properly xml escape web console output
> --
>
> Key: SLING-3274
> URL: https://issues.apache.org/jira/browse/SLING-3274
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication
>Affects Versions: Auth Core 1.1.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Auth Core 1.1.6
>
>
> The output of the web console plugin is not properly xml escaped, if some 
> auth reg properties contain a <, > or & the output will be broken



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (SLING-3273) Switch to login page if user is not allowed to access the web console

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843964#comment-13843964
 ] 

Carsten Ziegeler commented on SLING-3273:
-

I've added a call to the authenticator service to login - if the current user 
is not allowed to access the web console

> Switch to login page if user is not allowed to access the web console
> -
>
> Key: SLING-3273
> URL: https://issues.apache.org/jira/browse/SLING-3273
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Web Console Security Provider 1.1.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Web Console Security Provider 1.1.2
>
>
> RIght now if the current user is not allowed to access the web console, 
> forbidden is returned - we should rather redirect to the login page instead



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3273) Switch to login page if user is not allowed to access the web console

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-3273:
---

 Summary: Switch to login page if user is not allowed to access the 
web console
 Key: SLING-3273
 URL: https://issues.apache.org/jira/browse/SLING-3273
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Web Console Security Provider 1.1.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Web Console Security Provider 1.1.2


RIght now if the current user is not allowed to access the web console, 
forbidden is returned - we should rather redirect to the login page instead



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Resolved] (SLING-3272) Only register security provider 2 if startup is finished

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3272.
-

Resolution: Fixed

Added a StartupListener which checks whether startup is finished or not

> Only register security provider 2 if startup is finished
> 
>
> Key: SLING-3272
> URL: https://issues.apache.org/jira/browse/SLING-3272
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Web Console Security Provider 1.1.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Web Console Security Provider 1.1.2
>
>
> The security provider 2 which uses Sling for authentication should only be 
> registered, if the startup is finished - usually all content should be 
> installed to properly render the login form, therefore it makes sense to 
> defer until startup is finished



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3272) Only register security provider 2 if startup is finished

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-3272:
---

 Summary: Only register security provider 2 if startup is finished
 Key: SLING-3272
 URL: https://issues.apache.org/jira/browse/SLING-3272
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Web Console Security Provider 1.1.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Web Console Security Provider 1.1.2


The security provider 2 which uses Sling for authentication should only be 
registered, if the startup is finished - usually all content should be 
installed to properly render the login form, therefore it makes sense to defer 
until startup is finished



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3271) Make Sling imports dynamic

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-3271:
---

 Summary: Make Sling imports dynamic
 Key: SLING-3271
 URL: https://issues.apache.org/jira/browse/SLING-3271
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Web Console Security Provider 1.1.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Web Console Security Provider 1.1.2


Currently the imports to sling auth core and sling api resource are mandatory, 
this means the security provider is only active if Sling is running.
These imports should rather be dynamic as the provider should also run if only 
the repository is available



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Build failed in Jenkins: sling-healthcheck-1.6 #214

[Apache Jenkins Server]

See 

--
[...truncated 612 lines...]
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling Avalon Logger API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling JULI Logger API support.
org.ops4j.pax.exam.invoker.junit[org.ops4j.pax.exam.invoker.junit.internal.ContainerTestRunner]
 : running testOther in reactor
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [foo] with hc.tags=[foo]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [bar] with hc.tags=[bar]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [foo, bar] with hc.tags=[foo, bar]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [other, thing] with hc.tags=[other, thing]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [] with hc.tags=[]
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling SLF4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling Jakarta Commons Logging API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling Log4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling Avalon Logger API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling JULI Logger API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling SLF4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling Jakarta Commons Logging API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling Log4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling Avalon Logger API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling JULI Logger API support.
org.ops4j.pax.exam.invoker.junit[org.ops4j.pax.exam.invoker.junit.internal.ContainerTestRunner]
 : running testSelectorService in reactor
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [foo] with hc.tags=[foo]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [bar] with hc.tags=[bar]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [foo, bar] with hc.tags=[foo, bar]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [other, thing] with hc.tags=[other, thing]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [] with hc.tags=[]
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling SLF4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling Jakarta Commons Logging API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling Log4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling Avalon Logger API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Disabling JULI Logger API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling SLF4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling Jakarta Commons Logging API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling Log4J API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling Avalon Logger API support.
org.ops4j.pax.logging.pax-logging-api[org.ops4j.pax.logging.internal.Activator] 
: Enabling JULI Logger API support.
org.ops4j.pax.exam.invoker.junit[org.ops4j.pax.exam.invoker.junit.internal.ContainerTestRunner]
 : running testEmptyTags in reactor
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [foo] with hc.tags=[foo]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [bar] with hc.tags=[bar]
PAXEXAM-PROBE-71683ef9-d1d8-437c-a1b0-5ad52e76ee0b[org.apache.sling.hc.it.core.HealthCheckFilterTest]
 : Registered [foo, bar] with hc.t

Build failed in Jenkins: sling-trunk-1.6 #2054

[Apache Jenkins Server]

See 

Changes:

[bdelacretaz] Apply SLING-3265.2.patch, contributed by Tommaso Teofili, thanks! 
Such a large patch is unusual, ok here as it takes into account a number of 
issues raised during the donation review

[bdelacretaz] SLING-3269 - expose cases where ResourceDecorator returning null 
is not handled as specified

--
[...truncated 6774 lines...]
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ 
org.apache.sling.jcr.contentloader ---
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
org.apache.sling.jcr.contentloader ---
[INFO] Compiling 17 source files to 

[INFO] 
[INFO] --- maven-scr-plugin:1.14.0:scr (generate-scr-scrdescriptor) @ 
org.apache.sling.jcr.contentloader ---
[WARNING] 

 [0:0]: @Component : Component is defined to generate metatype information, 
however no properties have been defined; in case no properties are wanted, 
consider to use 'metatype=false'
[INFO] Generating 1 MetaType Descriptors in 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
org.apache.sling.jcr.contentloader ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 5 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
org.apache.sling.jcr.contentloader ---
[INFO] Compiling 3 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ 
org.apache.sling.jcr.contentloader ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running org.apache.sling.jcr.contentloader.internal.DefaultContentCreatorTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.162 sec
Running org.apache.sling.jcr.contentloader.internal.JsonReaderTest
Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.114 sec
Running org.apache.sling.jcr.contentloader.internal.readers.XmlReaderTest
373 [main] WARN org.apache.sling.jcr.contentloader.internal.readers.XmlReader - 
file element encountered when xml location isn't known. skipping.
374 [main] WARN org.apache.sling.jcr.contentloader.internal.readers.XmlReader - 
file element encountered when xml location isn't known. skipping.
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.149 sec

Results :

Tests run: 25, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] --- animal-sniffer-maven-plugin:1.9:check (default) @ 
org.apache.sling.jcr.contentloader ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0
[INFO] 
[INFO] --- maven-bundle-plugin:2.3.4:bundle (default-bundle) @ 
org.apache.sling.jcr.contentloader ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ 
org.apache.sling.jcr.contentloader ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run 
(set-bundle-required-execution-environment) @ 
org.apache.sling.jcr.contentloader ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[WARNING] Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] --- maven-source-plugin:2.2.1:jar (attach-sources) @ 
org.apache

[VOTE] Release Apache Sling Maven JSPC Plugin 2.0.8

[Carsten Ziegeler]

Hi,

its time for a new maven plugin release, we fixed one issue

Sling Maven JSPC Plugin 2.0.8
 https://issues.apache.org/jira/browse/SLING-2730

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-032/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 032 /tmp/sling-staging

Please vote to approve this release:

 [ ] +1 Approve the release
 [ ]  0 Don't care
 [ ] -1 Don't release, because ...

This vote will be open for 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
cziege...@apache.org

Re: [Sling Event] difference between JobConsumer and JobExecutor

[Carsten Ziegeler]

Hi

as Victor points out JobExecutor provides more functionality for the
implementor (like tracking, logging etc). JobConsumer is the preceding
variant which I didn't want to deprecate right now as it allows you to
implement a simpler interface if your implementation does not care about
the additional features.

Carsten


2013/11/18 Victor Saar 

> Hi Tommaso,
>
> JobExecutor has recently replaced JobConsumer while support for progress
> tracking was introduced. AFAIK JobConsumer should have been deprecated
> already. I guess the documentation was not yet updated accordingly.
>
> Ciao, Victor.
>
> On 15.11.13 14:39, "Tommaso Teofili"  wrote:
>
> >Hi all,
> >
> >while working with Sling Event I noticed there's a somewhat similar API
> >for
> >consuming a Job defined in JobConsumer and JobExecutor.
> >The API and javadoc for them are quite similar except that the executor
> >also gets an ExecutorContext while executing the Job.
> >
> >Is there any guideline about which one is better suitable for what
> >scenario
> >and / or if one should just use one instead of the other in general?
> >
> >Thanks in advance for your help,
> >Regards,
> >Tommaso
> >
> >[1] :
> >
> http://sling.apache.org/documentation/the-sling-engine/eventing-and-jobs.h
> >tml
> >[2] :
> >
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-jo
> >b-handling.html
>
>


-- 
Carsten Ziegeler
cziege...@apache.org

Re: Board Report for December

[Carsten Ziegeler]

Thanks Bertrand - I'll file the report today

Carsten


2013/12/9 Bertrand Delacretaz 

> Hi,
>
> On Mon, Dec 9, 2013 at 4:06 AM, Carsten Ziegeler 
> wrote:
> ...
> >
> https://cwiki.apache.org/confluence/display/SLING/Status+Report+December+2013
>
> Looks good to me, thanks!
>
> I have just added "Last PMC member addition was Mike Mueller,
> September 2010" which I believe is correct.
>
> -Bertrand
>



-- 
Carsten Ziegeler
cziege...@apache.org

[jira] [Commented] (SLING-3249) Cache not properly used in JcrPropertyMap

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843697#comment-13843697
 ] 

Carsten Ziegeler commented on SLING-3249:
-

I've committed a potential fix - WDYT?

> Cache not properly used in JcrPropertyMap
> -
>
> Key: SLING-3249
> URL: https://issues.apache.org/jira/browse/SLING-3249
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.2.8
>Reporter: Przemo Pakulski
>Assignee: Carsten Ziegeler
>  Labels: perfomance
> Fix For: JCR Resource 2.3.0
>
>
> JcrPropertyMap class has internal cache for properties an values.
> The cache is not used correctly, e.g. reading the same property twice still 
> results in access to underlying node.
> The problem is with get() methods, when property is red it is put into the 
> cache, but the cache is never checked if it already contains the property.
> The only way to force the caching is to use readFully() method indirectly, in 
> this case read method is examining the cache.
> It looks this has been introduced by fixing SLING-2425.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Assigned] (SLING-3249) Cache not properly used in JcrPropertyMap

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3249:
---

Assignee: Carsten Ziegeler

> Cache not properly used in JcrPropertyMap
> -
>
> Key: SLING-3249
> URL: https://issues.apache.org/jira/browse/SLING-3249
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.2.8
>Reporter: Przemo Pakulski
>Assignee: Carsten Ziegeler
>  Labels: perfomance
> Fix For: JCR Resource 2.3.0
>
>
> JcrPropertyMap class has internal cache for properties an values.
> The cache is not used correctly, e.g. reading the same property twice still 
> results in access to underlying node.
> The problem is with get() methods, when property is red it is put into the 
> cache, but the cache is never checked if it already contains the property.
> The only way to force the caching is to use readFully() method indirectly, in 
> this case read method is examining the cache.
> It looks this has been introduced by fixing SLING-2425.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3249) Cache not properly used in JcrPropertyMap

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3249:


Fix Version/s: JCR Resource 2.3.0

> Cache not properly used in JcrPropertyMap
> -
>
> Key: SLING-3249
> URL: https://issues.apache.org/jira/browse/SLING-3249
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Resource 2.2.8
>Reporter: Przemo Pakulski
>  Labels: perfomance
> Fix For: JCR Resource 2.3.0
>
>
> JcrPropertyMap class has internal cache for properties an values.
> The cache is not used correctly, e.g. reading the same property twice still 
> results in access to underlying node.
> The problem is with get() methods, when property is red it is put into the 
> cache, but the cache is never checked if it already contains the property.
> The only way to force the caching is to use readFully() method indirectly, in 
> this case read method is examining the cache.
> It looks this has been introduced by fixing SLING-2425.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (SLING-3269) ResourceDecorator returning null does not behave as specified

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843682#comment-13843682
 ] 

Carsten Ziegeler commented on SLING-3269:
-

I think your test is bogus as it uses a custom ResourceDecoratorTracker

> ResourceDecorator returning null does not behave as specified
> -
>
> Key: SLING-3269
> URL: https://issues.apache.org/jira/browse/SLING-3269
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> The ResourceDecorator javadocs specify that decorate(Resource r) returning 
> null is the same as returning r, but this is not the case. Returning null 
> causes a null Resource to be returned in several places, instead of the 
> original resource.
> Following up on the SLING-3267 discussions, I'll update the 
> bundles/resourceresolver to expose the problems, and tag them with 
> TODO:SLING-3269



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (SLING-3269) ResourceDecorator returning null does not behave as specified

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843674#comment-13843674
 ] 

Carsten Ziegeler commented on SLING-3269:
-

Can you point to some code where this happens? - afaik resource decorators are 
not called directly but by using the ResourceDecoratorTracker which handles the 
null case

> ResourceDecorator returning null does not behave as specified
> -
>
> Key: SLING-3269
> URL: https://issues.apache.org/jira/browse/SLING-3269
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> The ResourceDecorator javadocs specify that decorate(Resource r) returning 
> null is the same as returning r, but this is not the case. Returning null 
> causes a null Resource to be returned in several places, instead of the 
> original resource.
> Following up on the SLING-3267 discussions, I'll update the 
> bundles/resourceresolver to expose the problems, and tag them with 
> TODO:SLING-3269



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Build failed in Jenkins: sling-contrib-1.6 #1103

[Apache Jenkins Server]

See 

Changes:

[bdelacretaz] Apply SLING-3265.2.patch, contributed by Tommaso Teofili, thanks! 
Such a large patch is unusual, ok here as it takes into account a number of 
issues raised during the donation review

--
[...truncated 2692 lines...]
[INFO] --- maven-bundle-plugin:2.3.7:bundle (default-bundle) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run 
(set-bundle-required-execution-environment) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[WARNING] Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo
[INFO] 
[INFO] --- maven-source-plugin:2.2.1:jar (attach-sources) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.2:attach-descriptor (attach-descriptor) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] Checking legal files in: 
org.apache.sling.extensions.gwt.servlet-3.0.1-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.extensions.gwt.servlet-3.0.1-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.extensions.gwt.servlet/3.0.1-SNAPSHOT/org.apache.sling.extensions.gwt.servlet-3.0.1-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.extensions.gwt.servlet/3.0.1-SNAPSHOT/org.apache.sling.extensions.gwt.servlet-3.0.1-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.extensions.gwt.servlet/3.0.1-SNAPSHOT/org.apache.sling.extensions.gwt.servlet-3.0.1-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- maven-bundle-plugin:2.3.7:install (default-install) @ 
org.apache.sling.extensions.gwt.servlet ---
[INFO] Local OBR update disabled (enable with -DobrRepository)
[INFO] 
[INFO] 
[INFO] Building Apache Sling Google Web Toolkit Sample 2.0.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
org.apache.sling.extensions.gwt.sample ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ 
org.apache.sling.extensions.gwt.sample ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run 
(set-bundle-required-execution-environment) @ 
org.apache.sling.extensions.gwt.sample ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.4:process (default) @ 
org.apache.sling.extensions.gwt.sample ---
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
org.apache.sling.extensions.gwt.sample ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 6 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ 
org.apache.sling.extensions.gwt.sample ---
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
org.apache.sling.extensions.gwt.sample ---
[INFO] Compiling 4 source files to 

[INFO] 
[INFO] --- maven-scr-plugin:1.14.0:scr (generate-scr-scrdescriptor) @ 
org.apache.sling.extensions.gwt.sample ---
[INF

Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Internationalization Support #1103

[Apache Jenkins Server]

See 


--
[INFO] 
[INFO] 
[INFO] Building Apache Sling Internationalization Support 2.2.7-SNAPSHOT
[INFO] 
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.paxexam.util/1.0-SNAPSHOT/maven-metadata.xml
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.paxexam.util/1.0-SNAPSHOT/org.apache.sling.paxexam.util-1.0-SNAPSHOT.pom
[WARNING] The POM for 
org.apache.sling:org.apache.sling.paxexam.util:jar:1.0-SNAPSHOT is missing, no 
dependency information available
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.paxexam.util/1.0-SNAPSHOT/org.apache.sling.paxexam.util-1.0-SNAPSHOT.jar

Re: [OT] Feature flag influence on Resource access (Was: FYI: feature flags prototype)

[Carsten Ziegeler]

Good idea - do we have a wiki page where we collect real use cases for
feature flags?

Carsten


2013/12/10 Bertrand Delacretaz 

> Hi,
>
> On Sun, Dec 8, 2013 at 6:04 AM, Carsten Ziegeler 
> wrote:
> > ...I can see how we can implement a global feature flag within the
> resource
> > resolver easily, but as soon as there is some "randomness" involved, like
> > enable it for specific users or N users etc. this really gets tricky
>
> I agree. Another possibility is to use dynamic ACLs to show/hide
> resources to specific users/sessions based on feature flags, and
> according to [1] this should be possible at the Oak level.
>
> At this point I think it's fairly unclear how people are actually
> going to use feature flags, so if there's a way of prototyping that
> that doesn't require changes to the Sling core I'd go that route.
> Prototype in the simplest possible way (*), evaluate actual use cases
> and go back to the drawing board once we understand the whole thing
> better.
>
> -Bertrand
>
> [1] http://markmail.org/thread/7j7zkuwr6pa3ckql
>
> (*) which my SLING-3267 patch can also enable, that's still available
> there for experimenting even if we know that's not the final solution
>



-- 
Carsten Ziegeler
cziege...@apache.org

Re: [OT] Feature flag influence on Resource access (Was: FYI: feature flags prototype)

[Bertrand Delacretaz]

Hi,

On Sun, Dec 8, 2013 at 6:04 AM, Carsten Ziegeler  wrote:
> ...I can see how we can implement a global feature flag within the resource
> resolver easily, but as soon as there is some "randomness" involved, like
> enable it for specific users or N users etc. this really gets tricky

I agree. Another possibility is to use dynamic ACLs to show/hide
resources to specific users/sessions based on feature flags, and
according to [1] this should be possible at the Oak level.

At this point I think it's fairly unclear how people are actually
going to use feature flags, so if there's a way of prototyping that
that doesn't require changes to the Sling core I'd go that route.
Prototype in the simplest possible way (*), evaluate actual use cases
and go back to the drawing board once we understand the whole thing
better.

-Bertrand

[1] http://markmail.org/thread/7j7zkuwr6pa3ckql

(*) which my SLING-3267 patch can also enable, that's still available
there for experimenting even if we know that's not the final solution

[jira] [Created] (SLING-3270) html-generator to support html5

[Jason E Bailey (JIRA)]

Jason E Bailey created SLING-3270:
-

 Summary: html-generator to support html5
 Key: SLING-3270
 URL: https://issues.apache.org/jira/browse/SLING-3270
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Extensions Rewriter 1.0.2
Reporter: Jason E Bailey


Given the following fragment of HTML



This is invalid html4 and valid html5, as html5 allows anchor tags to contain 
block elements.

The current html-generator corrects the bad html4 and produces the following 
output





--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Health Check Improvements

[Bertrand Delacretaz]

Hi Georg,

On Thu, Dec 5, 2013 at 7:51 AM, Georg Henzler
 wrote:
> ...I just had a closer look at the Sling code
> and I like some of the concepts but believe some other things could maybe be
> improved...

Thanks for your review - I agree that we need better control on the
execution time and asynchronous execution of our health checks.

We discussed this recently [1] and what's suggested there is fairly
similar to what you suggest in terms of health checks execution, with
timeouts and caching of previously computed values.

> ...There is an emphasis on getting the overall status of the system: There is 
> a Web Console Plugin
> and whiteboard servlet (not being dependent on sling) to retrieve an 
> aggregated result of all
> health checks registered as services...

You can aggregate Sling health checks with the CompositeHealthCheck
that's briefly described at [3] and used in the health check samples,
would that cover your use cases?

> As a first step, I would like to propose the following:
> * Introduce HealthCheckRunner to hc-core  with the following signature:
>List HealthCheckRunner.runAllForTags(String... tags) // the
> list is sorted to put failed ones always on top...

I don't think I would sort here, that's a presentation concern - I
prefer having a stable order in the output of the execution service
itself.

> * The HealthCheckRunner would use the existing class HealthCheckFilter to
> retrieve the service references

Sounds good

> * The Web Console would be adjusted to use HealthCheckRunner

Ok

> * I would add getExecutionTimeInMs() to org.apache.sling.hc.api.Result

If we're caching the Results I'd add creation timestamp, an expiration
time that can be set when creating the Result and the execution
duration as you suggest.

> ...* Add parameter format=json to /system/console/healthcheck to provide the
> result in JSON format (to avoid an extra servlet, I think it is possible for
> console urls to return JSON but I would have to check)...

Maybe we don't need that as we have the SLING-2999 JMX resource
provider, but in general this makes sense.

If you want to provide a prototype health check executor service that
would be cool. Note that we have a Sling thread pools service [2]
that's probably useful for that.

-Bertrand

[1] http://markmail.org/message/ioatdxdogexacu2b

[2] 
http://sling.apache.org/documentation/bundles/apache-sling-commons-thread-pool.html

[3] http://sling.apache.org/documentation/bundles/sling-health-check-tool.html

[jira] [Commented] (SLING-3265) Implement suggestions from SLING-3223 in Sling replication

[Tommaso Teofili (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843168#comment-13843168
 ] 

Tommaso Teofili commented on SLING-3265:


thanks a lot Bertrand, everything looks good.

> Implement suggestions from SLING-3223 in Sling replication
> --
>
> Key: SLING-3265
> URL: https://issues.apache.org/jira/browse/SLING-3265
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Tommaso Teofili
> Attachments: SLING-3265.2.patch, SLING-3265.patch
>
>
> Umbrella issue to track implementation of improvements for Sling Replication 
> as suggested in SLING-3223 comments.
> Main ones refer to:
> - more tests
> - fix javadoc / typos
> - avoid AdapterFactory for installing packages
> - fix action names
> - refactor AuthenticationHandlers



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Resolved] (SLING-3265) Implement suggestions from SLING-3223 in Sling replication

[Tommaso Teofili (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tommaso Teofili resolved SLING-3265.


Resolution: Fixed

> Implement suggestions from SLING-3223 in Sling replication
> --
>
> Key: SLING-3265
> URL: https://issues.apache.org/jira/browse/SLING-3265
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Tommaso Teofili
> Attachments: SLING-3265.2.patch, SLING-3265.patch
>
>
> Umbrella issue to track implementation of improvements for Sling Replication 
> as suggested in SLING-3223 comments.
> Main ones refer to:
> - more tests
> - fix javadoc / typos
> - avoid AdapterFactory for installing packages
> - fix action names
> - refactor AuthenticationHandlers



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Build failed in Jenkins: sling-trunk-1.7 #424

[Apache Jenkins Server]

See 

Changes:

[cziegeler] SLING-3268 : TopicRoundRobin queue thread is not stopped when queue 
is closed

--
[...truncated 6250 lines...]
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
org.apache.sling.engine ---
[INFO] Compiling 53 source files to 

[INFO] 
[INFO] --- maven-scr-plugin:1.14.0:scr (generate-scr-scrdescriptor) @ 
org.apache.sling.engine ---
[WARNING] 

 [0:0]: Property filter.scope in class 
org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter is set as 
private. This is redundant as no metatype will be generated.
[INFO] Generating 1 MetaType Descriptors in 

[INFO] Generating 1 MetaType Descriptors in 

[INFO] Generating 1 MetaType Descriptors in 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] Writing 1 Service Component Descriptors to 

[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
org.apache.sling.engine ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
org.apache.sling.engine ---
[INFO] Compiling 10 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ 
org.apache.sling.engine ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running org.apache.sling.engine.ResponseUtilTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec
Running org.apache.sling.engine.impl.parameters.ContainerRequestParameterTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec
Running org.apache.sling.engine.impl.parameters.UtilTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.053 sec
Running org.apache.sling.engine.impl.log.CustomLogFormatTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.03 sec
Running org.apache.sling.engine.impl.RequestProcessorMBeanImplTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 18.427 sec
Running org.apache.sling.engine.impl.request.SlingRequestPathInfoTest
Tests run: 24, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 

[jira] [Commented] (SLING-3265) Implement suggestions from SLING-3223 in Sling replication

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843148#comment-13843148
 ] 

Bertrand Delacretaz commented on SLING-3265:


I have applied the monster SLING-3265.2.patch in http://svn.apache.org/r1549567

Could you double-check and resolve this issue if ok? 

> Implement suggestions from SLING-3223 in Sling replication
> --
>
> Key: SLING-3265
> URL: https://issues.apache.org/jira/browse/SLING-3265
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Tommaso Teofili
> Attachments: SLING-3265.2.patch, SLING-3265.patch
>
>
> Umbrella issue to track implementation of improvements for Sling Replication 
> as suggested in SLING-3223 comments.
> Main ones refer to:
> - more tests
> - fix javadoc / typos
> - avoid AdapterFactory for installing packages
> - fix action names
> - refactor AuthenticationHandlers



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Resolved] (SLING-3267) ResourceDecorator returning null should cause Resources to be ignored

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-3267.


Resolution: Won't Fix

Resolving won't fix as it looks like we have consensus to do things differently.

I have created SLING-3269 to fix the ResourceDecorator.decorate() null handling.

Let's discuss on list if and how we want to implement the "feature flags hide 
resources" use case.

> ResourceDecorator returning null should cause Resources to be ignored
> -
>
> Key: SLING-3267
> URL: https://issues.apache.org/jira/browse/SLING-3267
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-3267.patch
>
>
> The ResourceDecorator API's decorate(...) method javadocs currently specify 
> that it can return null, but I don't think that's supported in a consistent 
> way in the resource resolving process - returning null causes the resource 
> resolver to supply a null Resource in some cases, which will probably cause 
> NPEs downstream. 
> The javadocs also say "If the service does not want to decorate the resource, 
> it should return the original resource" which is consistent with how the 
> resource resolver currently operates: returning null is clearly not a way of 
> saying "do not decorate this resource".
> As we're discussing feature flags in Sling, we could clarify this behavior by 
> specifying that a ResourceDecorator returning null causes the resource to be 
> considered as non-existent, and making the corresponding (rather small) 
> changes in the resource resolver code. 
> As every Resource needs to go through the available ResourceDecorators, this 
> is a simple way of making resources hideable based on feature flags. One then 
> just needs to implement a ResourceDecorator that returns null when a Resource 
> must be ignored.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Assigned] (SLING-3269) ResourceDecorator returning null does not behave as specified

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz reassigned SLING-3269:
--

Assignee: (was: Bertrand Delacretaz)

Tests added in http://svn.apache.org/r1549566 - the offending cases are in 
ResourceDecoratorReturnsNullTest, with TODOs for when this is fixed.

> ResourceDecorator returning null does not behave as specified
> -
>
> Key: SLING-3269
> URL: https://issues.apache.org/jira/browse/SLING-3269
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Bertrand Delacretaz
>Priority: Minor
>
> The ResourceDecorator javadocs specify that decorate(Resource r) returning 
> null is the same as returning r, but this is not the case. Returning null 
> causes a null Resource to be returned in several places, instead of the 
> original resource.
> Following up on the SLING-3267 discussions, I'll update the 
> bundles/resourceresolver to expose the problems, and tag them with 
> TODO:SLING-3269



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3269) ResourceDecorator returning null does not behave as specified

[Bertrand Delacretaz (JIRA)]

Bertrand Delacretaz created SLING-3269:
--

 Summary: ResourceDecorator returning null does not behave as 
specified
 Key: SLING-3269
 URL: https://issues.apache.org/jira/browse/SLING-3269
 Project: Sling
  Issue Type: Bug
  Components: ResourceResolver
Affects Versions: Resource Resolver 1.0.6
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
Priority: Minor


The ResourceDecorator javadocs specify that decorate(Resource r) returning null 
is the same as returning r, but this is not the case. Returning null causes a 
null Resource to be returned in several places, instead of the original 
resource.

Following up on the SLING-3267 discussions, I'll update the 
bundles/resourceresolver to expose the problems, and tag them with 
TODO:SLING-3267



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3269) ResourceDecorator returning null does not behave as specified

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-3269:
---

Description: 
The ResourceDecorator javadocs specify that decorate(Resource r) returning null 
is the same as returning r, but this is not the case. Returning null causes a 
null Resource to be returned in several places, instead of the original 
resource.

Following up on the SLING-3267 discussions, I'll update the 
bundles/resourceresolver to expose the problems, and tag them with 
TODO:SLING-3269

  was:
The ResourceDecorator javadocs specify that decorate(Resource r) returning null 
is the same as returning r, but this is not the case. Returning null causes a 
null Resource to be returned in several places, instead of the original 
resource.

Following up on the SLING-3267 discussions, I'll update the 
bundles/resourceresolver to expose the problems, and tag them with 
TODO:SLING-3267


> ResourceDecorator returning null does not behave as specified
> -
>
> Key: SLING-3269
> URL: https://issues.apache.org/jira/browse/SLING-3269
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> The ResourceDecorator javadocs specify that decorate(Resource r) returning 
> null is the same as returning r, but this is not the case. Returning null 
> causes a null Resource to be returned in several places, instead of the 
> original resource.
> Following up on the SLING-3267 discussions, I'll update the 
> bundles/resourceresolver to expose the problems, and tag them with 
> TODO:SLING-3269



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: FYI, request setup script prototype

[Bertrand Delacretaz]

On Sun, Dec 8, 2013 at 6:53 AM, Carsten Ziegeler  wrote:
> ...We already have the BVP, now with the ability to bind BVPs to a  context
> (or whatever the term is). I think we should rather focus on one feature
> and getting it right than spreading similar functionality across different
> features which all look similar but behave differently...

I agree that folding this into BVPs sounds interesting and would avoid
inventing more new things than needed.

Especially if we can generalize the mechanism that finds the best
service (BVP in this case) to handle a given Resource, based on our
existing resource script resolution rules.

To me the main use cases are:

1) Create lightweight domain objects which can be scripted as well as
written in Java, and take care of assembling/formatting/defaulting
values for presentation, as well as providing smart iterators, for
search results pagination for example.

2) Act as mini-controllers that can redirect, fail or forward the
current request to take that code out of rendering templates. This is
out of scope of BVPs currently, but does also not generally belong
into rendering templates.

For now, I'll just keep my whiteboard prototype [1] around and see
where this goes.

Thanks everybody for the feedback!

-Bertrand

[1] 
https://svn.apache.org/repos/asf/sling/whiteboard/bdelacretaz/request-context

Re: FYI, request setup script prototype

[Bertrand Delacretaz]

Hi,

On Fri, Dec 6, 2013 at 6:11 PM, Daniel Klco  wrote:
> ...Actually, I've been batting this around in my head for awhile.  Make it
> possible to create BindingsValuesProviders which are constrained by
> resource type.  And a simple service for getting the various default Sling
> properties from the existing bindings

Sounds interesting, as long as you can script the BVP code which is
certainly possible.

The whole idea of being to resolve arbitrary "things" based on
resource types has been in the back of my mind for quite some time,
looks like it would be useful in several places.

You could probably use, at least for experimenting, a similar trick
than in my prototype. i.e. resolve a script with a fake extension to
take advantage of Script's resolution.

-Bertrand

Re: FYI, request setup script prototype

[Bertrand Delacretaz]

Hi,

On Fri, Dec 6, 2013 at 5:48 PM, Justin Edelson  wrote:
> ...This looks a bit too magical to me :) All you're avoiding is a single
> include line, right? Or am I missing something?...

In the current example you're correct, as I'm using an ESP script for
rendering this could just include the setup.ecma code.

It's different when using scriptless rendering languages - like
Velocity maybe, where this would make more sense.

-Bertrand

[jira] [Commented] (SLING-3265) Implement suggestions from SLING-3223 in Sling replication

[Tommaso Teofili (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842994#comment-13842994
 ] 

Tommaso Teofili commented on SLING-3265:


this patch includes:
- deprecated adapter factory for reading packages, receiving servlet manages 
that now on its own without the need of specific headers but just by reading 
the stream
- added default rule engine implementation, implementations of trigger and 
chain rules
- added servlet / resource for retrieving agent queues
- refactoring of transport authentication classes, more proper package location 
and naming
- HTTP headers have X- prefix to eventually pass through proxies
- moved agents' configuration under libs/sling/replication/config.$runmode 
(currently author and publish)
- added more extensive unit test (still missing for servlets)
- minor refactoring of names

> Implement suggestions from SLING-3223 in Sling replication
> --
>
> Key: SLING-3265
> URL: https://issues.apache.org/jira/browse/SLING-3265
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Tommaso Teofili
> Attachments: SLING-3265.2.patch, SLING-3265.patch
>
>
> Umbrella issue to track implementation of improvements for Sling Replication 
> as suggested in SLING-3223 comments.
> Main ones refer to:
> - more tests
> - fix javadoc / typos
> - avoid AdapterFactory for installing packages
> - fix action names
> - refactor AuthenticationHandlers



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Board Report for December

[Bertrand Delacretaz]

Hi,

On Mon, Dec 9, 2013 at 4:06 AM, Carsten Ziegeler  wrote:
...
> https://cwiki.apache.org/confluence/display/SLING/Status+Report+December+2013

Looks good to me, thanks!

I have just added "Last PMC member addition was Mike Mueller,
September 2010" which I believe is correct.

-Bertrand

[jira] [Updated] (SLING-3265) Implement suggestions from SLING-3223 in Sling replication

[Tommaso Teofili (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tommaso Teofili updated SLING-3265:
---

Attachment: SLING-3265.2.patch

updated version of the patch.


> Implement suggestions from SLING-3223 in Sling replication
> --
>
> Key: SLING-3265
> URL: https://issues.apache.org/jira/browse/SLING-3265
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Tommaso Teofili
> Attachments: SLING-3265.2.patch, SLING-3265.patch
>
>
> Umbrella issue to track implementation of improvements for Sling Replication 
> as suggested in SLING-3223 comments.
> Main ones refer to:
> - more tests
> - fix javadoc / typos
> - avoid AdapterFactory for installing packages
> - fix action names
> - refactor AuthenticationHandlers



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)