[jira] [Updated] (SLING-3282) No metatype generated for JobManagerImpl OSGi configuration

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3282:


Priority: Minor  (was: Major)
 Summary: No metatype generated for JobManagerImpl OSGi configuration  
(was: No metatype generationr for JobManagerImpl OSGi configuration)

> No metatype generated for JobManagerImpl OSGi configuration
> ---
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3282) No metatype generationr for JobManagerImpl OSGi configuration

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3282:


Summary: No metatype generationr for JobManagerImpl OSGi configuration  
(was: JobManagerConfiguration refers to undefined OSGi properties)

> No metatype generationr for JobManagerImpl OSGi configuration
> -
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Comment Edited] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848275#comment-13848275
 ] 

Carsten Ziegeler edited comment on SLING-3282 at 12/14/13 7:41 AM:
---

The reason for not making these properties visible is to avoid web console 
admins to switch back and force without knowing what they do - while this might 
be true for other settings as well - I thought it's a good idea. The property 
can of course be set through an osgi configuration

But I agree that its probably better to make this visible in the web console


was (Author: cziegeler):
The reason for not making these properties visible is to avoid web console 
admins to switch back and force without knowing what they do - while this might 
be true for other settings as well - I thought it's a good idea. The property 
can of course be set through an osgi configuration

> JobManagerConfiguration refers to undefined OSGi properties
> ---
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848275#comment-13848275
 ] 

Carsten Ziegeler commented on SLING-3282:
-

The reason for not making these properties visible is to avoid web console 
admins to switch back and force without knowing what they do - while this might 
be true for other settings as well - I thought it's a good idea. The property 
can of course be set through an osgi configuration

> JobManagerConfiguration refers to undefined OSGi properties
> ---
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3282:


Fix Version/s: Event 3.3.2

> JobManagerConfiguration refers to undefined OSGi properties
> ---
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3282:


Affects Version/s: Event 3.3.0

> JobManagerConfiguration refers to undefined OSGi properties
> ---
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3282:


Component/s: Extensions

> JobManagerConfiguration refers to undefined OSGi properties
> ---
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Assigned] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3282:
---

Assignee: Carsten Ziegeler

> JobManagerConfiguration refers to undefined OSGi properties
> ---
>
> Key: SLING-3282
> URL: https://issues.apache.org/jira/browse/SLING-3282
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.3.0
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
> Fix For: Event 3.3.2
>
>
> Currently the JobManagerImpl does not expose the properties in the web 
> console. Also the properties being used by JobManagerConfiguration like  
> job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Resolved] (SLING-3284) Remove deprecated documentation of Sling Jobs

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3284.
-

Resolution: Fixed

Thanks for reporting, yes that seems to be a left over. I've removed it and 
added a redirect from the old to the new page

> Remove deprecated documentation of Sling Jobs
> -
>
> Key: SLING-3284
> URL: https://issues.apache.org/jira/browse/SLING-3284
> Project: Sling
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>
> Currently there is documentation about Sling Jobs available at
> 1) 
> http://sling.apache.org/documentation/the-sling-engine/eventing-and-jobs.html
> and
> 2) 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
> They do overlap but 2) seems to be the more recent documentation. Can you 
> either crosslink between those 2 or just remove 1)?



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Assigned] (SLING-3284) Remove deprecated documentation of Sling Jobs

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3284:
---

Assignee: Carsten Ziegeler

> Remove deprecated documentation of Sling Jobs
> -
>
> Key: SLING-3284
> URL: https://issues.apache.org/jira/browse/SLING-3284
> Project: Sling
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Carsten Ziegeler
>
> Currently there is documentation about Sling Jobs available at
> 1) 
> http://sling.apache.org/documentation/the-sling-engine/eventing-and-jobs.html
> and
> 2) 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
> They do overlap but 2) seems to be the more recent documentation. Can you 
> either crosslink between those 2 or just remove 1)?



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Commented] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848221#comment-13848221
 ] 

Carsten Ziegeler commented on SLING-3285:
-

I think we have two options:
a) cache the admin resource resolver per resource resolver impl
b) create a separate (internal) service taking care of the resource hierarchy 
and using a single admin session. This service could also keep a cache and 
simply throw it away of a change is done to any sub tree of the search paths

So b) is similar to Will's suggestion but keeps it in a separate service where 
we can handle the multi-threaded access to the single admin resource resolver

Do avoid any additional sync'ing a think it's better to go with a)

> ResourceResolver.isResourceType() creates admin session for every call with 
> super type, slowing down processing
> ---
>
> Key: SLING-3285
> URL: https://issues.apache.org/jira/browse/SLING-3285
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>Priority: Critical
>  Labels: Performance
> Fix For: Resource Resolver 1.1.0
>
>
> SLING-2457 fixed the ACL issue with super type lookups, but at the cost of 
> creating a new admin resource resolver for every super type lookup. If an 
> inheritance chain contains multiple super types (N), a single call can 
> trigger the creation of N admin sessions. Often this also happens for a 
> number of resources per request, depending on the application, so you might 
> end up creating many Jackrabbit JCR sessions per request. While creating a 
> resource resolver / session is cheap, having too many at the same time has a 
> big performance impact on the read performance due to increased concurrency 
> in the JCR repository layer.
> This affects:
> * ResourceUtil.isA()
> * Resource.isResourceType()
> * ResourceResolver.isResourceType()
> * implementation in ResourceResolverImpl.isResourceType() and 
> getParentResourceType() [1]
> A simple fix could be to cache a single admin resolver for the duration of 
> the resource resolver containing it and reusing it for subsequent 
> isResourceType() calls.
> Another improvement could also be to cache the isResourceType() lookups - if 
> this is a typical short-lived request resource resolver. Within a request 
> resource type hierarchies are unlikely to change and should probably be 
> stable (and with Jackrabbit Oak the session won't refresh anyway). The cache 
> would simply be a map of "resource type" => "is also this resource type", so 
> that the super lookups don't have to be done again and again. Often an 
> application might iterate over a tree of data and looking for the same 
> resource type again and again, so the hit rate for the cache will be high.
> [1] 
> https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3285:


Fix Version/s: Resource Resolver 1.1.0

> ResourceResolver.isResourceType() creates admin session for every call with 
> super type, slowing down processing
> ---
>
> Key: SLING-3285
> URL: https://issues.apache.org/jira/browse/SLING-3285
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>Priority: Critical
>  Labels: Performance
> Fix For: Resource Resolver 1.1.0
>
>
> SLING-2457 fixed the ACL issue with super type lookups, but at the cost of 
> creating a new admin resource resolver for every super type lookup. If an 
> inheritance chain contains multiple super types (N), a single call can 
> trigger the creation of N admin sessions. Often this also happens for a 
> number of resources per request, depending on the application, so you might 
> end up creating many Jackrabbit JCR sessions per request. While creating a 
> resource resolver / session is cheap, having too many at the same time has a 
> big performance impact on the read performance due to increased concurrency 
> in the JCR repository layer.
> This affects:
> * ResourceUtil.isA()
> * Resource.isResourceType()
> * ResourceResolver.isResourceType()
> * implementation in ResourceResolverImpl.isResourceType() and 
> getParentResourceType() [1]
> A simple fix could be to cache a single admin resolver for the duration of 
> the resource resolver containing it and reusing it for subsequent 
> isResourceType() calls.
> Another improvement could also be to cache the isResourceType() lookups - if 
> this is a typical short-lived request resource resolver. Within a request 
> resource type hierarchies are unlikely to change and should probably be 
> stable (and with Jackrabbit Oak the session won't refresh anyway). The cache 
> would simply be a map of "resource type" => "is also this resource type", so 
> that the super lookups don't have to be done again and again. Often an 
> application might iterate over a tree of data and looking for the same 
> resource type again and again, so the hit rate for the cache will be high.
> [1] 
> https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Assigned] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3285:
---

Assignee: Carsten Ziegeler

> ResourceResolver.isResourceType() creates admin session for every call with 
> super type, slowing down processing
> ---
>
> Key: SLING-3285
> URL: https://issues.apache.org/jira/browse/SLING-3285
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Assignee: Carsten Ziegeler
>Priority: Critical
>  Labels: Performance
> Fix For: Resource Resolver 1.1.0
>
>
> SLING-2457 fixed the ACL issue with super type lookups, but at the cost of 
> creating a new admin resource resolver for every super type lookup. If an 
> inheritance chain contains multiple super types (N), a single call can 
> trigger the creation of N admin sessions. Often this also happens for a 
> number of resources per request, depending on the application, so you might 
> end up creating many Jackrabbit JCR sessions per request. While creating a 
> resource resolver / session is cheap, having too many at the same time has a 
> big performance impact on the read performance due to increased concurrency 
> in the JCR repository layer.
> This affects:
> * ResourceUtil.isA()
> * Resource.isResourceType()
> * ResourceResolver.isResourceType()
> * implementation in ResourceResolverImpl.isResourceType() and 
> getParentResourceType() [1]
> A simple fix could be to cache a single admin resolver for the duration of 
> the resource resolver containing it and reusing it for subsequent 
> isResourceType() calls.
> Another improvement could also be to cache the isResourceType() lookups - if 
> this is a typical short-lived request resource resolver. Within a request 
> resource type hierarchies are unlikely to change and should probably be 
> stable (and with Jackrabbit Oak the session won't refresh anyway). The cache 
> would simply be a map of "resource type" => "is also this resource type", so 
> that the super lookups don't have to be done again and again. Often an 
> application might iterate over a tree of data and looking for the same 
> resource type again and again, so the hit rate for the cache will be high.
> [1] 
> https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Closed] (SLING-2730) Allow JSPs to be excluded from compilation in maven-jspc-plugin

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-2730.
---


> Allow JSPs to be excluded from compilation in maven-jspc-plugin
> ---
>
> Key: SLING-2730
> URL: https://issues.apache.org/jira/browse/SLING-2730
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.0.6
>Reporter: Ben Peter
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Maven JSPC Plugin 2.0.8
>
> Attachments: SLING-2730-take2.patch, SLING-2730.patch
>
>
> JSPs may contain symbols that are declared not in the JSP itself, but in a 
> JSP that includes it (although that may be considered bad style).
> including.jsp:
> <%String foo = "bar"; %>
> <%@include file="included.jsp" %>
> included.jsp:
> <%= foo %>
> The result is that such a JSP does not compile on its own and the goal will 
> fail.
> This can be circumvented if individual JSPs can be excluded from compilation. 
> Excluding them from the resources to start with does not help, as they are 
> still required for the including JSPs to compile.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[VOTE RESULT] Release Apache Sling Maven JSPC Plugin 2.0.8

[Carsten Ziegeler]

The vote passes with three binding +1 votes from Justin Edelson, Felix
Meschberger, and Carsten Ziegeler. No other votes have been cast.

Thanks
Carsten

-- 
Carsten Ziegeler
cziege...@apache.org

[jira] [Commented] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing

[Will McGauley (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848190#comment-13848190
 ] 

Will McGauley commented on SLING-3285:
--

Having a cache of the isResourceType() lookups would certainly be ideal, but it 
may be difficult to invalidate such a cache if we store the cache long-term.  

What about storing a "long lived" admin resource resolver associated with the 
current resource resolver factory and using that for the resource type 
heirarchy lookups?  This would eliminate the need to get new admin resolvers 
each time.  Of course on OAK this admin resolver would need to be refreshed on 
occasion which could also pose it's own set of challenges.

> ResourceResolver.isResourceType() creates admin session for every call with 
> super type, slowing down processing
> ---
>
> Key: SLING-3285
> URL: https://issues.apache.org/jira/browse/SLING-3285
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.0.6
>Reporter: Alexander Klimetschek
>Priority: Critical
>  Labels: Performance
>
> SLING-2457 fixed the ACL issue with super type lookups, but at the cost of 
> creating a new admin resource resolver for every super type lookup. If an 
> inheritance chain contains multiple super types (N), a single call can 
> trigger the creation of N admin sessions. Often this also happens for a 
> number of resources per request, depending on the application, so you might 
> end up creating many Jackrabbit JCR sessions per request. While creating a 
> resource resolver / session is cheap, having too many at the same time has a 
> big performance impact on the read performance due to increased concurrency 
> in the JCR repository layer.
> This affects:
> * ResourceUtil.isA()
> * Resource.isResourceType()
> * ResourceResolver.isResourceType()
> * implementation in ResourceResolverImpl.isResourceType() and 
> getParentResourceType() [1]
> A simple fix could be to cache a single admin resolver for the duration of 
> the resource resolver containing it and reusing it for subsequent 
> isResourceType() calls.
> Another improvement could also be to cache the isResourceType() lookups - if 
> this is a typical short-lived request resource resolver. Within a request 
> resource type hierarchies are unlikely to change and should probably be 
> stable (and with Jackrabbit Oak the session won't refresh anyway). The cache 
> would simply be a map of "resource type" => "is also this resource type", so 
> that the super lookups don't have to be done again and again. Often an 
> application might iterate over a tree of data and looking for the same 
> resource type again and again, so the hit rate for the cache will be high.
> [1] 
> https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3285) ResourceResolver.isResourceType() creates admin session for every call with super type, slowing down processing

[Alexander Klimetschek (JIRA)]

Alexander Klimetschek created SLING-3285:


 Summary: ResourceResolver.isResourceType() creates admin session 
for every call with super type, slowing down processing
 Key: SLING-3285
 URL: https://issues.apache.org/jira/browse/SLING-3285
 Project: Sling
  Issue Type: Bug
  Components: ResourceResolver
Affects Versions: Resource Resolver 1.0.6
Reporter: Alexander Klimetschek
Priority: Critical


SLING-2457 fixed the ACL issue with super type lookups, but at the cost of 
creating a new admin resource resolver for every super type lookup. If an 
inheritance chain contains multiple super types (N), a single call can trigger 
the creation of N admin sessions. Often this also happens for a number of 
resources per request, depending on the application, so you might end up 
creating many Jackrabbit JCR sessions per request. While creating a resource 
resolver / session is cheap, having too many at the same time has a big 
performance impact on the read performance due to increased concurrency in the 
JCR repository layer.

This affects:
* ResourceUtil.isA()
* Resource.isResourceType()
* ResourceResolver.isResourceType()
* implementation in ResourceResolverImpl.isResourceType() and 
getParentResourceType() [1]

A simple fix could be to cache a single admin resolver for the duration of the 
resource resolver containing it and reusing it for subsequent isResourceType() 
calls.

Another improvement could also be to cache the isResourceType() lookups - if 
this is a typical short-lived request resource resolver. Within a request 
resource type hierarchies are unlikely to change and should probably be stable 
(and with Jackrabbit Oak the session won't refresh anyway). The cache would 
simply be a map of "resource type" => "is also this resource type", so that the 
super lookups don't have to be done again and again. Often an application might 
iterate over a tree of data and looking for the same resource type again and 
again, so the hit rate for the cache will be high.

[1] 
https://svn.apache.org/viewvc/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java?revision=1537136&view=markup



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Authentication Handler Credential Validation

[Alexander Klimetschek]

Might be slightly OT, but still: there is always a 
repository.loginAdminstrative() to do all kinds of things. So if you can deploy 
code, you can do anything. To improve on that over the long term, I think we 
should have configurability on the repository infra level, which can do what 
login.

With the login as service functionality this is IMO already given - a customer 
could simply have a fixed whitelist of services with their corresponding users, 
but any new service code (or script doing loginAdministrative()) would not work.

The second part are the authentication handlers, which could use the same 
configurable trust mechanism, and use impersonation in case they are 
pre-authenticated in any form (either it is an SSO where the authentication 
already happend outside the sling instance, or it is a more complex 
authentication that needs to be done in a sling authentication handler and is 
hard to do in a Jackrabbit LoginModule etc.). So nobody can inject a new 
authentication handler that isn't explicitly configured.

Of course there is probably a long way to make sure no other ways exist to get 
a admin session (like services leaking the session etc.), but then there would 
be a clear boundary to work towards. AFAICS there are currently so many ways 
between authentication handlers and JCR login (deprecated trusted credentials, 
null login, sudo, user.identified, passing a jcr session, ) and to clean 
that up needs some clear goal IMO.

Cheers,
Alex

On 13.12.2013, at 01:44, Antonio Sanso  wrote:

> hi Felix,
> 
> thanks for your comments
> 
> On Dec 13, 2013, at 10:31 AM, Felix Meschberger  wrote:
> 
>> Hi
>> 
>> Am 13.12.2013 um 09:38 schrieb Antonio Sanso :
>> 
>>> hi *,
>>> 
>>> I (finally) started to give a look into the Authentication Handler 
>>> Credential Validation tracked in [0].
>> 
>> Thanks !
>> 
>>> 
>>> I kind of like the overall design I would have a question regarding the  
>>> String IDENTIFIED = "user.identified"; property.
>>> 
>>> I was wondering if we do need this property or  we can replace with 
>>> something like AuthenticationInfo with empty 
>>> ResourceResolverFactory.PASSWORD and present ResourceResolverFactory.USER 
>>> Having this property is not a big deal but since we do already "threat" 
>>> SimpleCredential differently in the JcrResourceProviderFactory  this might 
>>> be IMHO feasible.
>>> 
>>> At the end of the day a pre-authenticated user is someone that knows his 
>>> username but not his repository password so it would not be too wrong 
>>> conceptually. 
>>> From the other hand I already fear somebody doing something like
>>> 
>>> new AuthenticationInfo(HttpServletRequest.FORM_AUTH,
>>>  user,getPassword());
>>> 
>>> and for some unexpected reason getPassword is null.
>> 
>> Right. But the spec for the user.password property in the 
>> ResourceResovlerFactory states that
>> 
>>> If this property is missing an empty password is assumed.
>> 
>> and we don't want to prohibit empty passwords on this level.
>> 
>> And then there is the other user whoe does:
>> 
>>> ResourceResolverFactory.getResourceResovler(new Map(){{
>>>   put("user.name", admin);
>>> }});
>> 
>> which makes for a great privilege escalation.
> 
> right but with the user.identified property 
> 
>>> ResourceResolverFactory.getResourceResovler(new Map(){{
>>>   put("user.name", admin);
>   put("user.identified", "true");
>>> }});
>> 
> 
> 
> will technically be the same escalation. 
> In both case the privilege  escalation guard should be in place …
> 
> As a side comment the security model we have in place assumes that if 
> somebody there is not much we can do if somebody has the ability to write and 
> deploy code…
> So for sure having the privilege  escalation guard is good but it would not 
> be the panacea for everything.
> 
> But in any case empty password or property would not change the overall 
> proposal, so let's stick with the property ;)
> 
> regards
> 
> antonio
> 
> 
>> 
>>> 
>>> Said that also using the repository somebody can have 
>>> repository.login(getCredentials());  with getCredentials() being null
>> 
>> In this case the API spec of hanlding null credentials applies, which 
>> assumes the call context would provide the Subject to use for login (see the 
>> idea outlined in the wiki page on how to implement the support 
>> user.identified in the Jackrabbit Server Repository bundle.
>> 
>>> 
>>> Moreover we can still partially prevent this continuing using the privilege 
>>> escalation guard.
>>> 
>>> WDYT? just a thought keeping the  String IDENTIFIED = "user.identified"; 
>>> property would not be  a big deal as well….
>> 
>> I prefer to have a new property because it is a special and new user case 
>> apart from regular username/password authentication.
>> 
>> Whether the proposed property name "user.identified" is actually a good one 
>> is another question, though ;-)
>> 
>> Regards
>> Felix
>> 
>>> 
>>> regards
>>> 
>>> antonio
>>> 
>>> [0] 

Re: [OT] Feature flag influence on Resource access (Was: FYI: feature flags prototype)

[Alexander Klimetschek]

On 12.12.2013, at 19:40, Carsten Ziegeler  wrote:

> I think you missunderstood me, or we're maybe talking about different
> things - as repeatedly stated we don't need to change the resource resolver
> - we have everything in place; and now we exactly need to define the use
> cases to know how the flags api should look like and which possibilites it
> has. The implementation of that api can do all kinds of stuff like using
> thread locals to access the current request etc.

Ah, sorry. I thought you'd define an API that the resource resolver impl would 
call directly.

Cheers,
Alex

[jira] [Resolved] (SLING-3283) Table on http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html broken

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3283.


Resolution: Fixed

Thanks for the report. I've fixed the layout in http://svn.apache.org/r1550766 
and improved it in http://svn.apache.org/r1550767

> Table on 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
>  broken
> -
>
> Key: SLING-3283
> URL: https://issues.apache.org/jira/browse/SLING-3283
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Minor
>
> The table for Queue Configurations seems to be broken at 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html.
>  Probably related to the wiki migration.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3283) Table on http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html broken

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-3283:
---

Component/s: Documentation

> Table on 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
>  broken
> -
>
> Key: SLING-3283
> URL: https://issues.apache.org/jira/browse/SLING-3283
> Project: Sling
>  Issue Type: Bug
>  Components: Documentation
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Minor
>
> The table for Queue Configurations seems to be broken at 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html.
>  Probably related to the wiki migration.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Assigned] (SLING-3283) Table on http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html broken

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-3283:
--

Assignee: Robert Munteanu

> Table on 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
>  broken
> -
>
> Key: SLING-3283
> URL: https://issues.apache.org/jira/browse/SLING-3283
> Project: Sling
>  Issue Type: Bug
>Reporter: Konrad Windszus
>Assignee: Robert Munteanu
>Priority: Minor
>
> The table for Queue Configurations seems to be broken at 
> http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html.
>  Probably related to the wiki migration.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Build failed in Jenkins: sling-trunk-1.7 #430

[Apache Jenkins Server]

See 

Changes:

[rombert] Update list.xml to contain latest SNAPSHOT of 
org.apache.sling.commons.log

--
[...truncated 32840 lines...]
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Failsafe report directory: 

[WARNING] File encoding has not been set, using platform encoding 
ANSI_X3.4-1968, i.e. build is platform dependent!
[JENKINS] Recording test results[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.jar

[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-bundlelist.xml
[INFO] Deleting 
 
(includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 

[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 

 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 

 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #430

[Apache Jenkins Server]

See 

Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #430

[Apache Jenkins Server]

See 


--
[INFO] Deleting 

 (includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7/trunk/launchpad/builder/target/bundleList.xml
[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7/trunk/launchpad/base/target/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7/trunk/bundles/commons/log/target/org.apache.sling.commons.log-4.0.0-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.transaction/1.0.0/org.apache.sling.fragment.transaction-1.0.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.javax.activation/0.1.0/org.apache.sling.javax.activation-0.1.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.ws/1.0.2/org.apache.sling.fragment.ws-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.installer/1.2.0/org.apache.sling.launchpad.installer-1.2.0.jar
 to 

Build failed in Jenkins: sling-trunk-1.6 #2060

[Apache Jenkins Server]

See 

Changes:

[rombert] Update list.xml to contain latest SNAPSHOT of 
org.apache.sling.commons.log

--
[...truncated 32122 lines...]
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-7-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Failsafe report directory: 

[WARNING] File encoding has not been set, using platform encoding 
ANSI_X3.4-1968, i.e. build is platform dependent!
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-bundlelist.xml
[INFO] Deleting 

[INFO] Deleting 
 
(includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 

[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 

 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 

 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.

Build failed in Jenkins: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #2060

[Apache Jenkins Server]

See 


--
[INFO] Deleting 

[INFO] Deleting 

 (includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/launchpad/builder/target/bundleList.xml
[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/launchpad/base/target/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/bundles/commons/log/target/org.apache.sling.commons.log-4.0.0-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.transaction/1.0.0/org.apache.sling.fragment.transaction-1.0.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.javax.activation/0.1.0/org.apache.sling.javax.activation-0.1.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.ws/1.0.2/org.apache.sling.fragment.ws-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad

Build failed in Jenkins: sling-trunk-1.6 #2059

[Apache Jenkins Server]

See 

Changes:

[chetanm] SLING-3049 - Make Logback Stacktrace Packaging data support OSGi aware

Disabling the PackagingDataCalculator support in OSGi as current logic of 
estimating class would not work properly in OSGi env

--
[...truncated 12983 lines...]
13.12.2013 12:32:59.330 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.fs.local.LocalFileSystem LocalFileSystem initialized 
at path 

13.12.2013 12:32:59.656 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.query.lucene.SearchIndex Index initialized: 

 Version: 3
13.12.2013 12:32:59.656 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.RepositoryImpl workspace 'security' initialized
13.12.2013 12:32:59.656 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.DefaultSecurityManager init: use Repository 
Login-Configuration for Jackrabbit
13.12.2013 12:32:59.675 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.security.user.UserManagerImpl Admin user does not 
exist.
13.12.2013 12:32:59.864 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.security.user.UserManagerImpl ... created admin user 
with id 'admin' and default pw.
13.12.2013 12:32:59.892 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.DefaultSecurityManager ... created anonymous user 
with id 'anonymous' ...
13.12.2013 12:32:59.897 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.RepositoryImpl Repository started (4027ms)
13.12.2013 12:32:59.902 *INFO* [FelixStartLevel] 
org.apache.sling.jcr.jackrabbit.server Service [59] ServiceEvent REGISTERED
13.12.2013 12:33:00.060 *WARN* [FelixStartLevel] 
org.apache.sling.jcr.jackrabbit.server.impl.security.PluggableDefaultAccessManager
 No pluggable AccessManager available, falling back to DefaultAccessManager
13.12.2013 12:33:00.126 *INFO* [FelixStartLevel] 
org.apache.jackrabbit.core.security.authorization.acl.CachingEntryCollector 
Creating cache with max size of: 5000
13.12.2013 12:33:00.685 *INFO* [FelixStartLevel] 
org.apache.sling.jcr.jackrabbit.server Service 
[org.apache.sling.jcr.jackrabbit.server.impl.TestContentLoaderImpl,61] 
ServiceEvent REGISTERED
13.12.2013 12:33:00.685 *INFO* [FelixStartLevel] 
org.apache.sling.jcr.base.internal.RepositoryPrinterProvider Providing new 
configuration printer for 
org.apache.sling.jcr.jackrabbit.server.impl.SlingServerRepository@195a626 : 
{admin.password=not-used, poll.active=10, poll.inactive=10, 
anonymous.name=anonymous, component.id=27, admin.name=admin, 
component.name=org.apache.sling.jcr.jackrabbit.server.SlingServerRepository, 
objectClass=[Ljava.lang.String;@1cf1d17, service.id=60, defaultWorkspace=, 
anonymous.password=not-used, 
service.factoryPid=org.apache.sling.jcr.jackrabbit.server.SlingServerRepository,
 
service.pid=org.apache.sling.jcr.jackrabbit.server.SlingServerRepository.cc72046e-29b3-48e3-af44-ca93cdf819ea,
 service.vendor=The Apache Software Foundation, service.description=Factory for 
embedded Jackrabbit Repository Instances, sling.context=default, 
home=jackrabbit, config=, name=jackrabbit}
13.12.2013 12:33:00.687 *INFO* [FelixStartLevel] org.apache.felix.inventory 
Service [64] ServiceEvent REGISTERED
13.12.2013 12:33:00.688 *INFO* [FelixStartLevel] org.apache.felix.inventory 
Service [63] ServiceEvent REGISTERED
13.12.2013 12:33:00.688 *INFO* [FelixStartLevel] org.apache.sling.jcr.base 
Service [62] ServiceEvent REGISTERED
13.12.2013 12:33:00.689 *INFO* [FelixStartLevel] 
org.apache.sling.jcr.classloader Service 
[org.apache.sling.jcr.classloader.internal.DynamicClassLoaderProviderImpl,65] 
ServiceEvent REGISTERED
13.12.2013 12:33:00.713 *INFO* [FelixStartLevel] org.apache.felix.inventory 
Service [69] ServiceEvent REGISTERED
13.12.2013 12:33:00.714 *INFO* [FelixStartLevel] org.apache.felix.inventory 
Service [68] ServiceEvent REGISTERED
13.12.2013 12:33:00.714 *INFO* [FelixStartLevel] 
org.apache.sling.resourceresolver Service 
[org.apache.sling.resourceresolver.impl.console.ResourceResolverWebConsolePlugin,67]
 ServiceEvent REGISTERED
13.12.2013 12:33:00.770 *INFO* [FelixStartLevel] 
org.apache.sling.resourceresolver Service [Map Entries Observation,70] 
ServiceEvent REGISTERED
13.12.2013 12:33:00.771 *INFO* [FelixStartLevel] org.apache.sling.jcr.resource 
Service 
[org.apache.sling.jcr.resource.internal.LegacyJcrResourceResolverFactoryImpl,72]
 ServiceEvent REGISTERED
13.12.2013 12:33:00.777 *INFO* [FelixStartLevel] 
org.apache.sling.auth.core.impl.SlingAuthenticator modified: Setting new cookie 
name for impersonation sling.sudo (was null)
13.12.2013 12:33:00.777 *INFO* [FelixStartLevel] 
org.apache.sling.auth.core.impl.SlingAuthenticator modified: Setting new 
parameter name for impersonation sudo (was null)
13.12.201

Failure running Launchpad Testing WAR version - ClassNotFoundException: org.apache.sling.commons.testing.integration.HttpTest

[Robert Munteanu]

Hi,

I can't run the testing-war project locally and WAR integration tests
are not enabled on BuildBot.

I'll paste the error at the end of the mail, maybe this looks familiar
to someone.

Thanks,

Robert

[INFO] --- maven-surefire-plugin:2.12.4:test
(surefire-integration-test) @ org.apache.sling.launchpad.testing-war
---
[INFO] Surefire report directory:
/home/ADOBENET/rmuntean/w/git/sling/launchpad/testing-war/target/surefire-reports

---
 T E S T S
---
Running org.apache.sling.launchpad.testing.TestAll
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.579
sec <<< FAILURE!
initializationError(org.apache.sling.launchpad.testing.TestAll)  Time
elapsed: 0.007 sec  <<< ERROR!
java.lang.NoClassDefFoundError:
org/apache/sling/commons/testing/integration/HttpTest
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
at 
org.apache.maven.surefire.booter.IsolatedClassLoader.loadClass(IsolatedClassLoader.java:97)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
at 
org.apache.maven.surefire.booter.IsolatedClassLoader.loadClass(IsolatedClassLoader.java:97)
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
at 
java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
at 
org.apache.maven.surefire.booter.IsolatedClassLoader.loadClass(IsolatedClassLoader.java:97)
at org.apache.sling.launchpad.testing.TestAll.suite(TestAll.java:76)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.junit.internal.runners.SuiteMethod.testFromSuiteMethod(SuiteMethod.java:35)
at org.junit.internal.runners.SuiteMethod.(SuiteMethod.java:24)
at org.junit.runners.AllTests.(AllTests.java:25)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
at 
org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:29)
at 
org.junit.internal.builders.AnnotatedBuilder.runnerForClass(AnnotatedBuilder.java:21)
at 
org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
at 
org.junit.internal.builders.AllDefaultPossibilitiesBuilder.runnerForClass(AllDefaultPossibilitiesBuilder.java:26)
at 
org.junit.runners.model.RunnerBuilder.safeRunnerForClass(RunnerBuilder.java:59)
at 
org.junit.internal.reque

Re: buildbot failure in ASF Buildbot on sling-trunk

[Robert Munteanu]

On Fri, 2013-12-13 at 14:22 +, build...@apache.org wrote:
The Buildbot has detected a new failure on builder sling-trunk while
building ASF Buildbot.
> Full details are available at:
>  http://ci.apache.org/builders/sling-trunk/builds/44
>
> Buildbot URL: http://ci.apache.org/
>
> Buildslave for this Build: osiris_ubuntu
>
> Build Reason: scheduler
> Build Source Stamp: [branch sling/trunk] 1550733
> Blamelist: rombert
>

This is still SLING-1794.

Robert


> BUILD FAILED: failed compile
>
> sincerely,
>  -The Buildbot
>
>
>
>

buildbot failure in ASF Buildbot on sling-trunk

[buildbot]

The Buildbot has detected a new failure on builder sling-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/sling-trunk/builds/44

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: osiris_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch sling/trunk] 1550733
Blamelist: rombert

BUILD FAILED: failed compile

sincerely,
 -The Buildbot

[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847504#comment-13847504
 ] 

Robert Munteanu commented on SLING-3049:


Thanks!

I've also updated the bundle list to refer to the latest snapshot in 
http://svn.apache.org/r1550733 . The problem should be gone in the next build.

> Make Logback Stacktrace Packaging data support OSGi aware
> -
>
> Key: SLING-3049
> URL: https://issues.apache.org/jira/browse/SLING-3049
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>  Labels: logback
> Fix For: Commons Log 4.0.0
>
> Attachments: SLING-3049.patch, 
> buildbot-exceptions-while-stopping-jetty.txt
>
>
> Logback provides a useful feature where it dumps the Class packaging Data 
> along with the stacktrace [1]. This provides a quick view of the location 
> from where classes in a given stacktrace are coming. Its default logic does 
> not work properly in OSGi env. Hence it would be useful to patch its logic to 
> become OSGi aware
> [1] http://logback.qos.ch/reasonsToSwitch.html#packagingData



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Build failed in Jenkins: sling-trunk-1.7 #429

[Apache Jenkins Server]

See 

Changes:

[chetanm] SLING-3049 - Make Logback Stacktrace Packaging data support OSGi aware

Disabling the PackagingDataCalculator support in OSGi as current logic of 
estimating class would not work properly in OSGi env

--
[...truncated 32680 lines...]
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Failsafe report directory: 

[WARNING] File encoding has not been set, using platform encoding 
ANSI_X3.4-1968, i.e. build is platform dependent!
[JENKINS] Recording test results
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-bundlelist.xml
[INFO] Deleting 

[INFO] Deleting 
 
(includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 

[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 

 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.log/3.0.3-SNAPSHOT/org.apache.sling.commons.log-3.0.3-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repos

Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #429

[Apache Jenkins Server]

See 


--
[INFO] Deleting 

[INFO] Deleting 

 (includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7/trunk/launchpad/builder/target/bundleList.xml
[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7/trunk/launchpad/base/target/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.log/3.0.3-SNAPSHOT/org.apache.sling.commons.log-3.0.3-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.transaction/1.0.0/org.apache.sling.fragment.transaction-1.0.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.javax.activation/0.1.0/org.apache.sling.javax.activation-0.1.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.ws/1.0.2/org.apache.sling.fragment.ws-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.

Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2058

[Apache Jenkins Server]

See 

Build failed in Jenkins: sling-trunk-1.6 #2058

[Apache Jenkins Server]

See 

Changes:

[rombert] .gitignore oak and jackrabbit directories in it-jackrabbit-oak

--
[...truncated 39411 lines...]
[INFO] Failsafe report directory: 

[WARNING] File encoding has not been set, using platform encoding 
ANSI_X3.4-1968, i.e. build is platform dependent!
[JENKINS] Recording test results[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.jar

[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-bundlelist.xml
[INFO] Deleting 
 
(includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 

[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 

 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.log/3.0.3-SNAPSHOT/org.apache.sling.commons.log-3.0.3-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/ma

Build failed in Jenkins: sling-trunk-1.6 » Apache Sling Launchpad Testing WAR version #2058

[Apache Jenkins Server]

See 


--
[INFO] Deleting 

 (includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/launchpad/builder/target/bundleList.xml
[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.6/trunk/launchpad/base/target/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.log/3.0.3-SNAPSHOT/org.apache.sling.commons.log-3.0.3-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.transaction/1.0.0/org.apache.sling.fragment.transaction-1.0.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.javax.activation/0.1.0/org.apache.sling.javax.activation-0.1.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.fragment.ws/1.0.2/org.apache.sling.fragment.ws-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.launchpad.installer/1.2.0/org.apache.sling.launchpad.installer-1.2.0.jar
 to 

Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Sample Integration Tests #2058

[Apache Jenkins Server]

See 

Build failed in Jenkins: sling-trunk-1.7 #428

[Apache Jenkins Server]

See 

Changes:

[rombert] .gitignore oak and jackrabbit directories in it-jackrabbit-oak

--
[...truncated 32789 lines...]
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Failsafe report directory: 

[WARNING] File encoding has not been set, using platform encoding 
ANSI_X3.4-1968, i.e. build is platform dependent!
[JENKINS] Recording test results
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT.pom
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-sources.jar
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.launchpad.testing/7-SNAPSHOT/org.apache.sling.launchpad.testing-7-SNAPSHOT-bundlelist.xml
[INFO] Deleting 

[INFO] Deleting 
 
(includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 

[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 

 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.log/3.0.3-SNAPSHOT/org.apache.sling.commons.log-3.0.3-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Launchpad Testing WAR version #428

[Apache Jenkins Server]

See 


--
[INFO] Deleting 

[INFO] Deleting 

 (includes = [derby.log, cachedir, sling, jackrabbit], excludes = [])
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] Using bundle list file from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7/trunk/launchpad/builder/target/bundleList.xml
[INFO] Merging partial bundle list 
org.apache.sling:org.apache.sling.launchpad.test-bundles:0.0.1-SNAPSHOT
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-bundles/0.0.1-SNAPSHOT/org.apache.sling.launchpad.test-bundles-0.0.1-SNAPSHOT-bundlelistconfig.zip
[INFO] Copying base artifact from 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7/trunk/launchpad/base/target/org.apache.sling.launchpad.base-2.5.1-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/slf4j-api/1.7.5/slf4j-api-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.log/3.0.3-SNAPSHOT/org.apache.sling.commons.log-3.0.3-SNAPSHOT.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.commons.logservice/1.0.2/org.apache.sling.commons.logservice-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/jcl-over-slf4j/1.7.5/jcl-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/slf4j/log4j-over-slf4j/1.7.5/log4j-over-slf4j-1.7.5.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.settings/1.3.0/org.apache.sling.settings-1.3.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.fragment.xml/1.0.2/org.apache.sling.fragment.xml-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.fragment.transaction/1.0.0/org.apache.sling.fragment.transaction-1.0.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.javax.activation/0.1.0/org.apache.sling.javax.activation-0.1.0.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.apache.sling.fragment.ws/1.0.2/org.apache.sling.fragment.ws-1.0.2.jar
 to 

[INFO] Copying bundle from 
/home/jenkins/jenkins-slave/maven-repositories/0/org/apache/sling/org.

[jira] [Commented] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13847427#comment-13847427
 ] 

Chetan Mehrotra commented on SLING-3049:


With [1550694|http://svn.apache.org/r1550694] I have disabled support for 
PackagingDataCalculator all together. The way it computes PackagingData would 
cause issue in OSGi environment. Also the support we had required a locally 
modified file of Logback and which with its EPL licences would anyway have to 
be removed.

So with this disabled we should not see this issue. Later if Logback does 
include the fix for LOGBACK-899 users can still enable it as suggested in 
SLING-3257. Leaving it open for now, once it is confirmed that above issue is 
not seen anymore would close the bug as WontFix 

> Make Logback Stacktrace Packaging data support OSGi aware
> -
>
> Key: SLING-3049
> URL: https://issues.apache.org/jira/browse/SLING-3049
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>  Labels: logback
> Fix For: Commons Log 4.0.0
>
> Attachments: SLING-3049.patch, 
> buildbot-exceptions-while-stopping-jetty.txt
>
>
> Logback provides a useful feature where it dumps the Class packaging Data 
> along with the stacktrace [1]. This provides a quick view of the location 
> from where classes in a given stacktrace are coming. Its default logic does 
> not work properly in OSGi env. Hence it would be useful to patch its logic to 
> become OSGi aware
> [1] http://logback.qos.ch/reasonsToSwitch.html#packagingData



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3284) Remove deprecated documentation of Sling Jobs

[Konrad Windszus (JIRA)]

Konrad Windszus created SLING-3284:
--

 Summary: Remove deprecated documentation of Sling Jobs
 Key: SLING-3284
 URL: https://issues.apache.org/jira/browse/SLING-3284
 Project: Sling
  Issue Type: Bug
Reporter: Konrad Windszus


Currently there is documentation about Sling Jobs available at
1) http://sling.apache.org/documentation/the-sling-engine/eventing-and-jobs.html
and
2) 
http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html

They do overlap but 2) seems to be the more recent documentation. Can you 
either crosslink between those 2 or just remove 1)?



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3283) Table on http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html broken

[Konrad Windszus (JIRA)]

Konrad Windszus created SLING-3283:
--

 Summary: Table on 
http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html
 broken
 Key: SLING-3283
 URL: https://issues.apache.org/jira/browse/SLING-3283
 Project: Sling
  Issue Type: Bug
Reporter: Konrad Windszus
Priority: Minor


The table for Queue Configurations seems to be broken at 
http://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html.
 Probably related to the wiki migration.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Created] (SLING-3282) JobManagerConfiguration refers to undefined OSGi properties

[Konrad Windszus (JIRA)]

Konrad Windszus created SLING-3282:
--

 Summary: JobManagerConfiguration refers to undefined OSGi 
properties
 Key: SLING-3282
 URL: https://issues.apache.org/jira/browse/SLING-3282
 Project: Sling
  Issue Type: Bug
Reporter: Konrad Windszus


Currently the JobManagerImpl does not expose the properties in the web console. 
Also the properties being used by JobManagerConfiguration like  
job.consumermanager.disableDistribution are not even defined. 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

[jira] [Updated] (SLING-3049) Make Logback Stacktrace Packaging data support OSGi aware

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-3049:
---

Attachment: buildbot-exceptions-while-stopping-jetty.txt

In both [the buildbot sling-trunk build 
41|http://ci.apache.org/builders/sling-trunk/builds/41/steps/compile/logs/stdio]
 and [jenkins sling-1.6 build 
2057|https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.6/2057/consoleText]
 I can see that when Jetty shuts down errors are thrown related to logback 
logging.

I've attached [^buildbot-exceptions-while-stopping-jetty.txt] , which contains 
these errors.





> Make Logback Stacktrace Packaging data support OSGi aware
> -
>
> Key: SLING-3049
> URL: https://issues.apache.org/jira/browse/SLING-3049
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>  Labels: logback
> Fix For: Commons Log 4.0.0
>
> Attachments: SLING-3049.patch, 
> buildbot-exceptions-while-stopping-jetty.txt
>
>
> Logback provides a useful feature where it dumps the Class packaging Data 
> along with the stacktrace [1]. This provides a quick view of the location 
> from where classes in a given stacktrace are coming. Its default logic does 
> not work properly in OSGi env. Hence it would be useful to patch its logic to 
> become OSGi aware
> [1] http://logback.qos.ch/reasonsToSwitch.html#packagingData



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Re: Authentication Handler Credential Validation

[Antonio Sanso]

hi Felix,

thanks for your comments

On Dec 13, 2013, at 10:31 AM, Felix Meschberger  wrote:

> Hi
> 
> Am 13.12.2013 um 09:38 schrieb Antonio Sanso :
> 
>> hi *,
>> 
>> I (finally) started to give a look into the Authentication Handler 
>> Credential Validation tracked in [0].
> 
> Thanks !
> 
>> 
>> I kind of like the overall design I would have a question regarding the  
>> String IDENTIFIED = "user.identified"; property.
>> 
>> I was wondering if we do need this property or  we can replace with 
>> something like AuthenticationInfo with empty 
>> ResourceResolverFactory.PASSWORD and present ResourceResolverFactory.USER 
>> Having this property is not a big deal but since we do already "threat" 
>> SimpleCredential differently in the JcrResourceProviderFactory  this might 
>> be IMHO feasible.
>> 
>> At the end of the day a pre-authenticated user is someone that knows his 
>> username but not his repository password so it would not be too wrong 
>> conceptually. 
>> From the other hand I already fear somebody doing something like
>> 
>> new AuthenticationInfo(HttpServletRequest.FORM_AUTH,
>>   user,getPassword());
>> 
>> and for some unexpected reason getPassword is null.
> 
> Right. But the spec for the user.password property in the 
> ResourceResovlerFactory states that
> 
>> If this property is missing an empty password is assumed.
> 
> and we don't want to prohibit empty passwords on this level.
> 
> And then there is the other user whoe does:
> 
>> ResourceResolverFactory.getResourceResovler(new Map(){{
>>put("user.name", admin);
>> }});
> 
> which makes for a great privilege escalation.

right but with the user.identified property 

>> ResourceResolverFactory.getResourceResovler(new Map(){{
>>put("user.name", admin);
put("user.identified", "true");
>> }});
> 


will technically be the same escalation. 
In both case the privilege  escalation guard should be in place …

As a side comment the security model we have in place assumes that if somebody 
there is not much we can do if somebody has the ability to write and deploy 
code…
So for sure having the privilege  escalation guard is good but it would not be 
the panacea for everything.

But in any case empty password or property would not change the overall 
proposal, so let's stick with the property ;)

regards

antonio


> 
>> 
>> Said that also using the repository somebody can have 
>> repository.login(getCredentials());  with getCredentials() being null
> 
> In this case the API spec of hanlding null credentials applies, which assumes 
> the call context would provide the Subject to use for login (see the idea 
> outlined in the wiki page on how to implement the support user.identified in 
> the Jackrabbit Server Repository bundle.
> 
>> 
>> Moreover we can still partially prevent this continuing using the privilege 
>> escalation guard.
>> 
>> WDYT? just a thought keeping the  String IDENTIFIED = "user.identified"; 
>> property would not be  a big deal as well….
> 
> I prefer to have a new property because it is a special and new user case 
> apart from regular username/password authentication.
> 
> Whether the proposed property name "user.identified" is actually a good one 
> is another question, though ;-)
> 
> Regards
> Felix
> 
>> 
>> regards
>> 
>> antonio
>> 
>> [0] 
>> https://cwiki.apache.org/confluence/display/SLING/Solving+the+Authentication+Handler+Credential+Validation+Problem
> 

Re: Authentication Handler Credential Validation

[Felix Meschberger]

Hi

Am 13.12.2013 um 09:38 schrieb Antonio Sanso :

> hi *,
> 
> I (finally) started to give a look into the Authentication Handler Credential 
> Validation tracked in [0].

Thanks !

> 
> I kind of like the overall design I would have a question regarding the  
> String IDENTIFIED = "user.identified"; property.
> 
> I was wondering if we do need this property or  we can replace with something 
> like AuthenticationInfo with empty ResourceResolverFactory.PASSWORD and 
> present ResourceResolverFactory.USER 
> Having this property is not a big deal but since we do already "threat" 
> SimpleCredential differently in the JcrResourceProviderFactory  this might be 
> IMHO feasible.
> 
> At the end of the day a pre-authenticated user is someone that knows his 
> username but not his repository password so it would not be too wrong 
> conceptually. 
> From the other hand I already fear somebody doing something like
> 
> new AuthenticationInfo(HttpServletRequest.FORM_AUTH,
>user,getPassword());
> 
> and for some unexpected reason getPassword is null.

Right. But the spec for the user.password property in the 
ResourceResovlerFactory states that

> If this property is missing an empty password is assumed.

and we don't want to prohibit empty passwords on this level.

And then there is the other user whoe does:

> ResourceResolverFactory.getResourceResovler(new Map(){{
> put("user.name", admin);
> }});

which makes for a great privilege escalation.

> 
> Said that also using the repository somebody can have 
> repository.login(getCredentials());  with getCredentials() being null

In this case the API spec of hanlding null credentials applies, which assumes 
the call context would provide the Subject to use for login (see the idea 
outlined in the wiki page on how to implement the support user.identified in 
the Jackrabbit Server Repository bundle.

> 
> Moreover we can still partially prevent this continuing using the privilege 
> escalation guard.
> 
> WDYT? just a thought keeping the  String IDENTIFIED = "user.identified"; 
> property would not be  a big deal as well….

I prefer to have a new property because it is a special and new user case apart 
from regular username/password authentication.

Whether the proposed property name "user.identified" is actually a good one is 
another question, though ;-)

Regards
Felix

> 
> regards
> 
> antonio
> 
> [0] 
> https://cwiki.apache.org/confluence/display/SLING/Solving+the+Authentication+Handler+Credential+Validation+Problem

Authentication Handler Credential Validation

[Antonio Sanso]

hi *,

I (finally) started to give a look into the Authentication Handler Credential 
Validation tracked in [0].

I kind of like the overall design I would have a question regarding the  String 
IDENTIFIED = "user.identified"; property.

I was wondering if we do need this property or  we can replace with something 
like AuthenticationInfo with empty ResourceResolverFactory.PASSWORD and present 
ResourceResolverFactory.USER 
Having this property is not a big deal but since we do already "threat" 
SimpleCredential differently in the JcrResourceProviderFactory  this might be 
IMHO feasible.

At the end of the day a pre-authenticated user is someone that knows his 
username but not his repository password so it would not be too wrong 
conceptually. 
From the other hand I already fear somebody doing something like

new AuthenticationInfo(HttpServletRequest.FORM_AUTH,
user,getPassword());

and for some unexpected reason getPassword is null.

Said that also using the repository somebody can have 
repository.login(getCredentials());  with getCredentials() being null
 
Moreover we can still partially prevent this continuing using the privilege 
escalation guard.

WDYT? just a thought keeping the  String IDENTIFIED = "user.identified"; 
property would not be  a big deal as well….

regards

antonio

[0] 
https://cwiki.apache.org/confluence/display/SLING/Solving+the+Authentication+Handler+Credential+Validation+Problem