[jira] [Updated] (SLING-3563) Removal of node with sling:alias property is ignored by sling resource resolution

2014-05-16 Thread Antonio Sanso (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-3563:
-

Component/s: ResourceResolver

 Removal of node with sling:alias property  is ignored by sling resource 
 resolution
 --

 Key: SLING-3563
 URL: https://issues.apache.org/jira/browse/SLING-3563
 Project: Sling
  Issue Type: Bug
  Components: ResourceResolver
Reporter: Antonio Sanso

 Removal of node with sling:alias property  is ignored by sling resource 
 resolution.
 I will commit a show case test.
 This issue will be address together with SLING-3505



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998841#comment-13998841
 ] 

Robert Munteanu commented on SLING-3567:


That code hasn't changed in some time, so I'm not sure what triggered this 
problem. Just to be on the safe side, what SVN revision did you build the 
project from?

 Cannot add null entries, when creating a new bundle and adding it to an 
 existing server
 ---

 Key: SLING-3567
 URL: https://issues.apache.org/jira/browse/SLING-3567
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 With the most recent version of Sling IDE Tooling I get the following 
 exception when adding a new Sling bundle project and adding it to an existing 
 server: 
 {code}
 !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
 !MESSAGE Cannot add null entries
 !STACK 0
 java.lang.IllegalArgumentException: Cannot add null entries
   at 
 org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
   at 
 org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
   at 
 org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
   at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
   at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
   at 
 org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
   at 
 org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
   at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
   at 
 org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
   at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
   at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
   at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
   at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
   at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
   at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
   at org.eclipse.jface.window.Window.open(Window.java:802)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
   at 
 org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
   at 
 org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
   at 
 org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
   at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
   at 
 org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
   at 
 org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
   at 
 

Re: JIRA components to be created for release

2014-05-16 Thread Justin Edelson
Hi Chetan,
We usually don't create components per module - just use Extensions for
these. I assume you need some versions however. What versions do you want
me to create?

Justin


On Thursday, May 15, 2014, Chetan Mehrotra chetan.mehro...@gmail.com
wrote:

 Hi,

 I would like to make release of following bundles

 1.
 https://github.com/apache/sling/tree/trunk/contrib/extensions/leak-detector
 2. https://github.com/apache/sling/tree/trunk/contrib/extensions/slf4j-mdc

 Can someone create the JIRA components for the two modules and also
 the versions for release or grant me the required karma!

 Chetan Mehrotra



[VOTE] Release Apache Sling Scripting JSP 2.1.0 and Apache Sling Commons Compiler 2.2.0

2014-05-16 Thread Carsten Ziegeler
Hi,

this vote is about adding Java 8 support to our compilers/script engines:

Apache Sling Commons Compiler 2.2.0
https://issues.apache.org/jira/browse/SLING/fixforversion/12323578

Apache Sling Scripting JSP 2.1.0
https://issues.apache.org/jira/browse/SLING/fixforversion/12324445

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1066

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1066 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
cziege...@apache.org


[jira] [Updated] (SLING-3405) Support Java 8 for compiling scripts

2014-05-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3405:


Summary: Support Java 8 for compiling scripts  (was: SLING2094Test and 
ServerSideScriptsTest fail with java 8: JSP compiler does not find 
java.util.Arrays or java.lang.CharSequence)

 Support Java 8 for compiling scripts
 

 Key: SLING-3405
 URL: https://issues.apache.org/jira/browse/SLING-3405
 Project: Sling
  Issue Type: Bug
  Components: Scripting, Testing
Reporter: Bertrand Delacretaz
Priority: Minor
 Fix For: Scripting JSP 2.1.0, Commons Compiler 2.2.0

 Attachments: jasper-upgrade.patch


 Running the launchpad/integration-tests SLING2094Test fails due to a 
 compilation error for the test script [1]: Unable to compile class for JSP, 
 the import java.util.Arrays cannot be resolved.
 [1] 
 https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/resources/integration-test/issues/sling2094/sling2094.jsp



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3499) Support custom annotations with Sling Models

2014-05-16 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998721#comment-13998721
 ] 

Konrad Windszus commented on SLING-3499:


Hi Justin, the patch looks fine to me, but please make sure that the changed 
handling of default values is not overwritten (SLING-3547). I definitely 
appreciate your changes. There is only one thing which should be changed which 
is the Javadoc for InjectAnnotationProcessor.isOptional(). There is some copy 
paste mistake in there. It should rather state that three values are supported 
as return values: true, means the injection can be left out, false means it is 
mandatory and null means the value from the Optional annotation is taken.

 Support custom annotations with Sling Models
 

 Key: SLING-3499
 URL: https://issues.apache.org/jira/browse/SLING-3499
 Project: Sling
  Issue Type: New Feature
  Components: Extensions
Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2
Reporter: Konrad Windszus

 To support custom annotations the API needs to be extended. 
 The reasons for custom annotations are listed in 
 http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is 
 much more comfortable for developers, since they can use code completion in 
 the IDE to see which options are available for each injector-specific 
 annotation, apart from that it is less code to write (instead of multiple 
 annotations on one field/method I would only have to write one annotation 
 with some attributes).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3549) PollingTransportHandler should log connection errors

2014-05-16 Thread Tommaso Teofili (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tommaso Teofili resolved SLING-3549.


Resolution: Fixed

fixed in r1593256

 PollingTransportHandler should log connection errors
 

 Key: SLING-3549
 URL: https://issues.apache.org/jira/browse/SLING-3549
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Tommaso Teofili
Assignee: Tommaso Teofili
Priority: Minor

 PollingTransportHandler currently throws an Exception if it's unable to 
 establish a connection to the endpoint instance however it'd be better to log 
 the problem and go ahead, as that would allow to remove the useless polling 
 request from the queue which would instead stay.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[GitHub] sling pull request: SLING-3376 - TenantProvider passes tenant with...

2014-05-16 Thread roele
Github user roele closed the pull request at:

https://github.com/apache/sling/pull/11


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (SLING-3566) Properties from extended file aggregates are not synchronized

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3566.


Resolution: Fixed

As it turns out, this worked but I wrote the tests incorrectly. Nevertheless, 
we have one more automated test for the sync process.

* http://svn.apache.org/viewvc?view=revisionrevision=1594912 - added tracing 
to the impl-vlt plugin
* http://svn.apache.org/viewvc?view=revisionrevision=1594913 - added a 
PropertyMatcher
- http://svn.apache.org/viewvc?view=revisionrevision=1594914 - added test to 
validate the scenario of this bug

 Properties from extended file aggregates are not synchronized
 -

 Key: SLING-3566
 URL: https://issues.apache.org/jira/browse/SLING-3566
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 Assume the following directory structure
 {code}
 .
 ├── ace.html.esp
 ├── ace.html.esp.dir
 │   ├── .content.xml
 {code}
 where .content.xml contains
 {code}
 ?xml version=1.0 encoding=UTF-8?
 jcr:root xmlns:jcr=http://www.jcp.org/jcr/1.0; 
 xmlns:nt=http://www.jcp.org/jcr/nt/1.0;
 jcr:primaryType=nt:file
 jcr:content
 jcr:lastModifiedBy=admin
 jcr:mimeType=text/javascript
 jcr:primaryType=nt:resource/
 /jcr:root
 {code}
 Changes to the jcr:mimeType are not registered, since we don't descend down 
 the jcr:content node when updating file-like nodes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (SLING-3564) it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: Invalid thread access

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-3564:
---

Summary: it tests in tooling/ide/eclipse-test fail on MacOS X with 
SWTException: Invalid thread access  (was: it tests in tooling/ide/eclipse-test 
fail (for me) with SWTException: Invalid thread access)

 it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: 
 Invalid thread access
 -

 Key: SLING-3564
 URL: https://issues.apache.org/jira/browse/SLING-3564
 Project: Sling
  Issue Type: Bug
  Components: IDE
 Environment: mac os x, 10.7.5, java version 1.6.0_65
 Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
 Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: SLING-3564-1.diff


 When I run 'mvn clean install' in tooling/ide I get a failure in 
 tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in 
 eclipse-test):
 {code}
 ***WARNING: Display must be created on main thread due to Cocoa restrictions.
 {code}
 and the corresponding 
 tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
 {code}
 org.eclipse.swt.SWTException: Invalid thread access
 at org.eclipse.swt.SWT.error(SWT.java:4397)
 at org.eclipse.swt.SWT.error(SWT.java:4312)
 at org.eclipse.swt.SWT.error(SWT.java:4283)
 at org.eclipse.swt.widgets.Display.error(Display.java:1076)
 at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
 at org.eclipse.swt.widgets.Display.create(Display.java:816)
 at org.eclipse.swt.graphics.Device.init(Device.java:130)
 at org.eclipse.swt.widgets.Display.init(Display.java:707)
 at org.eclipse.swt.widgets.Display.init(Display.java:698)
 at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
 at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
 at 
 org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
 at 
 org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
 at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
 at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
 at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[VOTE] Release Apache Sling Classloader Leak Detector 1.0.0

2014-05-16 Thread Chetan Mehrotra
Hi,

This is to vote for the Apache Sling Classloader Leak Detector 1.0.0
release. This is the first release of this module

The docs are up to date at
https://github.com/apache/sling/tree/trunk/contrib/extensions/leak-detector

Issues fixed
https://issues.apache.org/jira/browse/SLING/fixforversion/12326854

Release Notes
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12326854projectId=12310710

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1059

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1059 /tmp/sling-staging

Please vote to approve this release:

 [ ] +1 Approve the release
 [ ]  0 Don't care
 [ ] -1 Don't release, because ...

This vote will be open for 72 hours.

regards
Chetan


[jira] [Commented] (SLING-3520) Consolidate archetype plugin versions in a parent pom

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998582#comment-13998582
 ] 

Robert Munteanu commented on SLING-3520:


Archetypes now use the released parent pom - 
http://svn.apache.org/viewvc?view=revisionrevision=1594818

 Consolidate archetype plugin versions in a parent pom
 -

 Key: SLING-3520
 URL: https://issues.apache.org/jira/browse/SLING-3520
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Archetype Parent Version 1

 Attachments: SLING-3520-1.patch, SLING-3520-2.patch


 Currently all plugin versions used in generated archetypes are maintained in 
 each pom. This makes it difficult to update the used versions, and many 
 archetypes now have outdated plugin versions.
 To make maintenance easier, we should create an archetype parent which 
 centralises these settings.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Assigned] (SLING-3165) Cannot remove Bundle or Content Package Module from Server

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-3165:
--

Assignee: Robert Munteanu

 Cannot remove Bundle or Content Package Module from Server
 --

 Key: SLING-3165
 URL: https://issues.apache.org/jira/browse/SLING-3165
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Justin Edelson
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 From the Servers view, right clicking on a module (bundle or content package) 
 includes a Remove option which opens a confirmation dialog, but this 
 doesn't seem to do anything.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Jenkins build became unstable: sling-trunk-1.7 #488

2014-05-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.7/488/changes



[jira] [Created] (SLING-3566) Properties from extended file aggregates are not synchronized

2014-05-16 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-3566:
--

 Summary: Properties from extended file aggregates are not 
synchronized
 Key: SLING-3566
 URL: https://issues.apache.org/jira/browse/SLING-3566
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


Assume the following directory structure

{code}
.
├── ace.html.esp
├── ace.html.esp.dir
│   ├── .content.xml
{code}

where .content.xml contains

{code}
?xml version=1.0 encoding=UTF-8?
jcr:root xmlns:jcr=http://www.jcp.org/jcr/1.0; 
xmlns:nt=http://www.jcp.org/jcr/nt/1.0;
jcr:primaryType=nt:file
jcr:content
jcr:lastModifiedBy=admin
jcr:mimeType=text/javascript
jcr:primaryType=nt:resource/
/jcr:root
{code}

Changes to the jcr:mimeType are not registered, since we don't descend down the 
jcr:content node when updating file-like nodes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Assigned] (SLING-3521) Merged resource is not available if parent folder is unreadable

2014-05-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3521:
---

Assignee: Carsten Ziegeler

 Merged resource is not available if parent folder is unreadable
 ---

 Key: SLING-3521
 URL: https://issues.apache.org/jira/browse/SLING-3521
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Resource Merger 1.1.2
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Resource Merger 1.1.4

 Attachments: SLING-3521-patch.diff


 If the parent folder is not readable the hide detection simply skips the 
 resource. This seems not very intuitiv, so I think we should rather treat an 
 unreadable parent folder in the same way as a readable parent folder without 
 a hide property.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998860#comment-13998860
 ] 

Robert Munteanu edited comment on SLING-3567 at 5/15/14 3:49 PM:
-

I've committed a potential fix in 
http://svn.apache.org/viewvc?view=revisionrevision=1594956, can you check if 
this solves the problem for you?


was (Author: rombert):
I've committed a potential fix in 
http://svn.apache.org/viewvc?view=revisionrevision=r1594956, can you check if 
this solves the problem for you?

 Cannot add null entries, when creating a new bundle and adding it to an 
 existing server
 ---

 Key: SLING-3567
 URL: https://issues.apache.org/jira/browse/SLING-3567
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 With the most recent version of Sling IDE Tooling I get the following 
 exception when adding a new Sling bundle project and adding it to an existing 
 server: 
 {code}
 !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
 !MESSAGE Cannot add null entries
 !STACK 0
 java.lang.IllegalArgumentException: Cannot add null entries
   at 
 org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
   at 
 org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
   at 
 org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
   at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
   at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
   at 
 org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
   at 
 org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
   at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
   at 
 org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
   at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
   at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
   at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
   at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
   at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
   at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
   at org.eclipse.jface.window.Window.open(Window.java:802)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
   at 
 org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
   at 
 org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
   at 
 org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
   at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
   at 
 org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
   at 
 

[jira] [Resolved] (SLING-3571) Introduce NodeTypeRegistry, attached to Repository

2014-05-16 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-3571.


Resolution: Fixed

[~rombert] thanks for the patch, it's applied.

Closing this one. The NodeTypeRegistry does not implement everything atm, but 
it does what we need so far. We can open separate tickets to add more pieces as 
we go.

 Introduce NodeTypeRegistry, attached to Repository
 --

 Key: SLING-3571
 URL: https://issues.apache.org/jira/browse/SLING-3571
 Project: Sling
  Issue Type: Task
  Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


 We need more node type support in the IDE to support proper content 
 manipulation checks and displaying properties with more details.
 To do this, we introduce a NodeTypeRegistry that is attached to the 
 Repository.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [VOTE] Release Apache Sling Servlet Archetype 1.0.2

2014-05-16 Thread Robert Munteanu
+1 ( non-binding )

On Thu, May 15, 2014 at 12:03 PM, Robert Munteanu romb...@apache.org wrote:
 Hi,

 We solved 9 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12315454

 There are still some outstanding issues:
 https://issues.apache.org/jira/browse/SLING/component/12311945

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1064/

 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 1064 /tmp/sling-staging

 Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

 This majority vote is open for at least 72 hours.


[jira] [Assigned] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-3567:
--

Assignee: Robert Munteanu

 Cannot add null entries, when creating a new bundle and adding it to an 
 existing server
 ---

 Key: SLING-3567
 URL: https://issues.apache.org/jira/browse/SLING-3567
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 With the most recent version of Sling IDE Tooling I get the following 
 exception when adding a new Sling bundle project and adding it to an existing 
 server: 
 {code}
 !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
 !MESSAGE Cannot add null entries
 !STACK 0
 java.lang.IllegalArgumentException: Cannot add null entries
   at 
 org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
   at 
 org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
   at 
 org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
   at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
   at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
   at 
 org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
   at 
 org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
   at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
   at 
 org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
   at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
   at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
   at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
   at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
   at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
   at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
   at org.eclipse.jface.window.Window.open(Window.java:802)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
   at 
 org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
   at 
 org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
   at 
 org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
   at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
   at 
 org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
   at 
 org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
   at 
 org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
   at 
 

[jira] [Resolved] (SLING-3559) Never run project launches when publishing

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3559.


Resolution: Fixed

Fixed in http://svn.apache.org/viewvc?view=revisionrevision=1595033

 Never run project launches when publishing
 --

 Key: SLING-3559
 URL: https://issues.apache.org/jira/browse/SLING-3559
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 The SlingLaunchpadBehaviour still runs project launches if they exist. I 
 don't think that's needed anymore, as the content sync code should be good 
 enough, and launches are reserved for other tasks. As such, we should remove 
 that code.
 [~egli] - is there anything that I missed?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [VOTE] Release Apache Sling Classloader Leak Detector 1.0.0

2014-05-16 Thread Chetan Mehrotra
+1 Approve the release

Chetan Mehrotra


[jira] [Commented] (SLING-3081) Do not re-publish modules when starting the launchpad for the first time

2014-05-16 Thread Stefan Egli (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998538#comment-13998538
 ] 

Stefan Egli commented on SLING-3081:


Agreed, might make it more light-weight to just 'connect' instead of 'full 
publish'. If the user knows that the 'connect to server' button doesn't imply 
an initial publish, then all things are fine. If we get user feedback about 
this being odd we could still add a config parameter to the server about this. 
But having it off by default sounds good.

The new-project-wizard will also start the server of course and up-till-now was 
assuming the publish would automatically start. That we can still trigger 
explicitly from the wizard though, so no issue there.

 Do not re-publish modules when starting the launchpad for the first time
 

 Key: SLING-3081
 URL: https://issues.apache.org/jira/browse/SLING-3081
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.2


 This results in unnecessary publishing activity. The right way is to provide 
 a manual action to sync a sub-tree to ( or the whole module ) to the 
 Launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3081) Do not re-publish modules when starting the launchpad for the first time

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999758#comment-13999758
 ] 

Robert Munteanu commented on SLING-3081:


{quote}The new-project-wizard will also start the server of course and 
up-till-now was assuming the publish would automatically start. That we can 
still trigger explicitly from the wizard though, so no issue there.{quote}

Sounds good

 Do not re-publish modules when starting the launchpad for the first time
 

 Key: SLING-3081
 URL: https://issues.apache.org/jira/browse/SLING-3081
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.2


 This results in unnecessary publishing activity. The right way is to provide 
 a manual action to sync a sub-tree to ( or the whole module ) to the 
 Launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (SLING-3565) TenantProvider.getTenants throws NPE if tenant root does not exist

2014-05-16 Thread Roland Schaer (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Roland Schaer updated SLING-3565:
-

Attachment: SLING-3565.patch

attaching patch

 TenantProvider.getTenants throws NPE if tenant root does not exist
 --

 Key: SLING-3565
 URL: https://issues.apache.org/jira/browse/SLING-3565
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Tenant 1.0.0
Reporter: Roland Schaer
 Attachments: SLING-3565.patch


 The method TenantProvider.getTenant(tenantId) throws a NullPointerException 
 if the tenant root at /etc/tenants does not exist.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-2651) Manually trigger sync on files/directories

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998242#comment-13998242
 ] 

Robert Munteanu commented on SLING-2651:


* http://svn.apache.org/viewvc?view=revisionrevision=r1594750 - allow import 
from arbitray paths

 Manually trigger sync on files/directories
 --

 Key: SLING-2651
 URL: https://issues.apache.org/jira/browse/SLING-2651
 Project: Sling
  Issue Type: Improvement
  Components: IDE
Reporter: Antonio Sanso
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 We should be able to manually publish a subtree of content, as opposed to the 
 sync happening in the background. One use case is where the auto-sync is 
 disabled and the user only wants to publish the changes manually.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3165) Cannot remove Bundle or Content Package Module from Server

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3165.


Resolution: Fixed

Fixed in http://svn.apache.org/viewvc?view=revisionrevision=1594935

 Cannot remove Bundle or Content Package Module from Server
 --

 Key: SLING-3165
 URL: https://issues.apache.org/jira/browse/SLING-3165
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Justin Edelson
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 From the Servers view, right clicking on a module (bundle or content package) 
 includes a Remove option which opens a confirmation dialog, but this 
 doesn't seem to do anything.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3161) SlingIDE Import Content wizard should respect .vltignore files

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3161.


Resolution: Fixed

I've added .vltignore logic, but just for importing. Let's see if we need 
something else.

* http://svn.apache.org/viewvc?view=revisionrevision=1595203 added 
EclipseResourceMatchers
* http://svn.apache.org/viewvc?view=revisionrevision=1595205 added 
RepositoryAccessor.createFile
* http://svn.apache.org/viewvc?view=revisionrevision=1595207 added 
ContentImportTest.importFilesAndFolders
* http://svn.apache.org/viewvc?view=revisionrevision=1595208 added 
ContentImportTest.importFilesAndFoldersRespectsVltFilters
* http://svn.apache.org/viewvc?view=revisionrevision=1595209 add an 
IgnoredResources abstraction in the api project.
* http://svn.apache.org/viewvc?view=revisionrevision=1595210 respect found 
.vltignore files found when importing.
* http://svn.apache.org/viewvc?view=revisionrevision=1595211 take into account 
.vltignore files which are present under the content sync root but not under 
the import root.

 SlingIDE Import Content wizard should respect .vltignore files
 --

 Key: SLING-3161
 URL: https://issues.apache.org/jira/browse/SLING-3161
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Justin Edelson
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 Given in repository:
 /apps/foo/install
 /apps/foo/install/.vltignore = *.jar
 /apps/foo/install/foo.jar
 Then running import content should not copy foo.jar into the local working 
 copy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3569) Fix test suite on Windows

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1350#comment-1350
 ] 

Robert Munteanu commented on SLING-3569:


It seems that on Windows the Sling launchpad does not start, see 
[^BundleDeploymentTest-windows-error.txt].

 Fix test suite on Windows
 -

 Key: SLING-3569
 URL: https://issues.apache.org/jira/browse/SLING-3569
 Project: Sling
  Issue Type: Test
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: BundleDeploymentTest-windows-error.txt


 Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt 
 ones fail.
 For the eclipse-test ones, it seems that no connection is made to the 
 launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3572) Make RepositoryFactory statefull, allow a Repository to be stopped

2014-05-16 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-3572.


Resolution: Fixed

done

 Make RepositoryFactory statefull, allow a Repository to be stopped
 --

 Key: SLING-3572
 URL: https://issues.apache.org/jira/browse/SLING-3572
 Project: Sling
  Issue Type: New Feature
  Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


 At the moment we have a stateless RepositoryFactory, ie it only provides 
 newRepository() which creates a new repository each time. This was fine as 
 long as the repository was stateless - but with the introduction of the 
 NodeTypeRegistry for example, the repository initialization is now also 
 heavy-weight.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3174) [Tooling] add 'new simple content/bundle project' wizards

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1376#comment-1376
 ] 

Robert Munteanu commented on SLING-3174:


[~egli] - what do you think is still missing here? A wizard for creating a 
content project? A wizard for creating a plain ( non-Maven ) bundle project?

 [Tooling] add 'new simple content/bundle project' wizards
 -

 Key: SLING-3174
 URL: https://issues.apache.org/jira/browse/SLING-3174
 Project: Sling
  Issue Type: Improvement
  Components: IDE
Reporter: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


 We should include 'new' wizards which create simple content/bundle projects. 
 The project would simply create a faceted project with the according facet 
 set and set any additional type specific properties (eg with content it would 
 create a jcr_root directory). Although these two wizards would do very 
 trivial tasks, IMO this will help users kickstart projects and get into the 
 mindset of slingclipse.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3569) Fix test suite on Windows

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3569.


Resolution: Fixed

The issues were most about PermGen size, JVM ergonomics are different on 
Windows. All tests now pass

* http://svn.apache.org/viewvc?view=revisionrevision=1595254 fix 
VltSerializationManagerTest when running on Windows
* http://svn.apache.org/viewvc?view=revisionrevision=1595263 ensure that the 
test Eclipse instance has enough PermGen
* http://svn.apache.org/viewvc?view=revisionrevision=1595264 added a README.md 
file which explains the PermGen requirements

 Fix test suite on Windows
 -

 Key: SLING-3569
 URL: https://issues.apache.org/jira/browse/SLING-3569
 Project: Sling
  Issue Type: Test
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: BundleDeploymentTest-windows-error.txt


 Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt 
 ones fail.
 For the eclipse-test ones, it seems that no connection is made to the 
 launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (SLING-3570) Assertion failed when trying to create new Sling Bundle project

2014-05-16 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-3570:
--

 Summary: Assertion failed when trying to create new Sling Bundle 
project
 Key: SLING-3570
 URL: https://issues.apache.org/jira/browse/SLING-3570
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Konrad Windszus


When I try to create a new Sling Bundle project with the wizard I get the 
following exception:

{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
!MESSAGE assertion failed: 
!STACK 0
org.eclipse.core.runtime.AssertionFailedException: assertion failed: 
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
at 
org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
at 
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
at 
org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
at 
org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
at 
org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
at 
org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
at org.eclipse.core.internal.resources.Project.build(Project.java:114)
at 
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
at 
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
at 
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
at 
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
at 
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
at 
org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
at 
org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
at 
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
at 
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
at 
org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at 
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
{code}

I tested with SVN revision 1595036.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[VOTE] Release Apache Sling SLF4J MDC Filter 1.0.0

2014-05-16 Thread Chetan Mehrotra
Hi,

This is to vote for the Apache Sling SLF4J MDC Filter 1.0.0 release.
This is the first release of this module

The docs are up to date at
https://github.com/apache/sling/tree/trunk/contrib/extensions/slf4j-mdc

Issues fixed
https://issues.apache.org/jira/browse/SLING/fixforversion/12326853

Release Notes
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12326853projectId=12310710

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1061

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1061 /tmp/sling-staging

Please vote to approve this release:

 [ ] +1 Approve the release
 [ ]  0 Don't care
 [ ] -1 Don't release, because ...

This vote will be open for 72 hours.

regards
Chetan


[jira] [Assigned] (SLING-3405) Support Java 8 for compiling scripts

2014-05-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3405:
---

Assignee: Carsten Ziegeler

 Support Java 8 for compiling scripts
 

 Key: SLING-3405
 URL: https://issues.apache.org/jira/browse/SLING-3405
 Project: Sling
  Issue Type: Bug
  Components: Scripting, Testing
Reporter: Bertrand Delacretaz
Assignee: Carsten Ziegeler
Priority: Minor
 Fix For: Scripting JSP 2.1.0, Commons Compiler 2.2.0

 Attachments: jasper-upgrade.patch


 Running the launchpad/integration-tests SLING2094Test fails due to a 
 compilation error for the test script [1]: Unable to compile class for JSP, 
 the import java.util.Arrays cannot be resolved.
 [1] 
 https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/resources/integration-test/issues/sling2094/sling2094.jsp



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (SLING-3564) it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: Invalid thread access

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999216#comment-13999216
 ] 

Robert Munteanu edited comment on SLING-3564 at 5/15/14 9:00 PM:
-

So this particular issue is fixed - commited in 
http://svn.apache.org/viewvc?view=revisionrevision=1595036 . Please open a new 
issue about the BundleDeploymentTest. A couple of thoughts

- you can inspect the error log of the sling launchpad 
tooling/ide/eclipse-test/target/sling/_/logs ; perhaps there are some error 
logged in there ; or perhaps the tooling bundle was not installed during the 
test
- you can try increasing the timeout in the Poller class, although I don't 
think it's a timing issue - 5 seconds are more than enough
- you can try running the test as a plug-in test from within Eclipse ; it tries 
to find a Sling launchpad on port 8080
- perhaps you have an older tooling support bundle installed? You can try 
bumping the dependency to 1.0.1-SNAPSHOT ( 1.0.0 vote is still underway ) and 
see what that does


was (Author: rombert):
So this particular issue is fixed - commited in 
http://svn.apache.org/viewvc?view=revisionrevision=1595036 . Please open a new 
issue about the BundleDeploymentTest. A couple of thoughts

- you can inspect the error log of the sling launchpad 
tooling/ide/eclipse-test/target/sling/_/logs ; perhaps there are some error 
logged in there ; or perhaps the tooling bundle was not installed during the 
test
 -you can try increasing the timeout in the Poller class, although I don't 
think it's a timing issue - 5 seconds are more than enough
 - you can try running the test as a plug-in test from within Eclipse ; it 
tries to find a Sling launchpad on port 8080

 it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: 
 Invalid thread access
 -

 Key: SLING-3564
 URL: https://issues.apache.org/jira/browse/SLING-3564
 Project: Sling
  Issue Type: Bug
  Components: IDE
 Environment: mac os x, 10.7.5, java version 1.6.0_65
 Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
 Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: SLING-3564-1.diff


 When I run 'mvn clean install' in tooling/ide I get a failure in 
 tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in 
 eclipse-test):
 {code}
 ***WARNING: Display must be created on main thread due to Cocoa restrictions.
 {code}
 and the corresponding 
 tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
 {code}
 org.eclipse.swt.SWTException: Invalid thread access
 at org.eclipse.swt.SWT.error(SWT.java:4397)
 at org.eclipse.swt.SWT.error(SWT.java:4312)
 at org.eclipse.swt.SWT.error(SWT.java:4283)
 at org.eclipse.swt.widgets.Display.error(Display.java:1076)
 at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
 at org.eclipse.swt.widgets.Display.create(Display.java:816)
 at org.eclipse.swt.graphics.Device.init(Device.java:130)
 at org.eclipse.swt.widgets.Display.init(Display.java:707)
 at org.eclipse.swt.widgets.Display.init(Display.java:698)
 at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
 at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
 at 
 org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
 at 
 org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 

[jira] [Updated] (SLING-3569) Fix test suite on Windows

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-3569:
---

Attachment: BundleDeploymentTest-windows-error.txt

 Fix test suite on Windows
 -

 Key: SLING-3569
 URL: https://issues.apache.org/jira/browse/SLING-3569
 Project: Sling
  Issue Type: Test
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: BundleDeploymentTest-windows-error.txt


 Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt 
 ones fail.
 For the eclipse-test ones, it seems that no connection is made to the 
 launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3521) Merged resource is not available if parent folder is unreadable

2014-05-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3521.
-

Resolution: Fixed

Thanks for your patch Matei - I solved it now slightly different by allowing 
null in the ParentHidingHandler constructor

 Merged resource is not available if parent folder is unreadable
 ---

 Key: SLING-3521
 URL: https://issues.apache.org/jira/browse/SLING-3521
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Resource Merger 1.1.2
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Resource Merger 1.1.4

 Attachments: SLING-3521-patch.diff


 If the parent folder is not readable the hide detection simply skips the 
 resource. This seems not very intuitiv, so I think we should rather treat an 
 unreadable parent folder in the same way as a readable parent folder without 
 a hide property.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: Events, Jobs and admin sessions

2014-05-16 Thread Bertrand Delacretaz
Hi Lars,

On Thu, May 15, 2014 at 10:19 AM, Lars Krapf lkr...@adobe.com wrote:
 ...In other examples, for instance a job
 that processes an asset, the job should be performed with the privileges
 of the triggering user, to limit the possibilities of an potential exploit

If JCR nodes could belong to a specific user, like unix files do, it
might make sense to run such jobs with the identity of the user owner.

Unfortunately AFAIK JCR doesn't have a concept of user/group owner for
nodes, and implementing that securely at the application level doesn't
look easy. I'd be happy to be proven wrong on this, though.

-Bertrand


[jira] [Assigned] (SLING-3569) Fix test suite on Windows

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-3569:
--

Assignee: Robert Munteanu

 Fix test suite on Windows
 -

 Key: SLING-3569
 URL: https://issues.apache.org/jira/browse/SLING-3569
 Project: Sling
  Issue Type: Test
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt 
 ones fail.
 For the eclipse-test ones, it seems that no connection is made to the 
 launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[VOTE] Release Apache Sling JCRInstall Bundle Archetype 1.0.2

2014-05-16 Thread Robert Munteanu
Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12326806

There are still some outstanding issues:
https://issues.apache.org/jira/browse/SLING/component/12311945

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1063/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1063 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


Re: [VOTE] Release Apache Sling SLF4J MDC Filter 1.0.0

2014-05-16 Thread Chetan Mehrotra
+1 Approve the release
Chetan Mehrotra


On Thu, May 15, 2014 at 3:08 PM, Chetan Mehrotra
chetan.mehro...@gmail.com wrote:
 Hi,

 This is to vote for the Apache Sling SLF4J MDC Filter 1.0.0 release.
 This is the first release of this module

 The docs are up to date at
 https://github.com/apache/sling/tree/trunk/contrib/extensions/slf4j-mdc

 Issues fixed
 https://issues.apache.org/jira/browse/SLING/fixforversion/12326853

 Release Notes
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12326853projectId=12310710

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1061

 You can use this UNIX script to download the release and verify the
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 1061 /tmp/sling-staging

 Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

 This vote will be open for 72 hours.

 regards
 Chetan


[jira] [Commented] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server

2014-05-16 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999239#comment-13999239
 ] 

Konrad Windszus commented on SLING-3567:


The fix worked for me. Thanks.

 Cannot add null entries, when creating a new bundle and adding it to an 
 existing server
 ---

 Key: SLING-3567
 URL: https://issues.apache.org/jira/browse/SLING-3567
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 With the most recent version of Sling IDE Tooling I get the following 
 exception when adding a new Sling bundle project and adding it to an existing 
 server: 
 {code}
 !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
 !MESSAGE Cannot add null entries
 !STACK 0
 java.lang.IllegalArgumentException: Cannot add null entries
   at 
 org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
   at 
 org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
   at 
 org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
   at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
   at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
   at 
 org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
   at 
 org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
   at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
   at 
 org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
   at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
   at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
   at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
   at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
   at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
   at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
   at org.eclipse.jface.window.Window.open(Window.java:802)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
   at 
 org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
   at 
 org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
   at 
 org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
   at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
   at 
 org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
   at 
 org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
   at 
 org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
   at 
 

[jira] [Created] (SLING-3565) TenantProvider.getTenants throws NPE if tenant root does not exist

2014-05-16 Thread Roland Schaer (JIRA)
Roland Schaer created SLING-3565:


 Summary: TenantProvider.getTenants throws NPE if tenant root does 
not exist
 Key: SLING-3565
 URL: https://issues.apache.org/jira/browse/SLING-3565
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Tenant 1.0.0
Reporter: Roland Schaer
 Attachments: SLING-3565.patch

The method TenantProvider.getTenant(tenantId) throws a NullPointerException if 
the tenant root at /etc/tenants does not exist.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Build failed in Jenkins: sling-samples-1.6 #439

2014-05-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-samples-1.6/439/

--
Failed to access build log

java.io.IOException: remote file operation failed: 
/home/jenkins/jenkins-slave/workspace/sling-samples-1.6 at 
hudson.remoting.Channel@1bd13118:ubuntu6
at hudson.FilePath.act(FilePath.java:916)
at hudson.FilePath.act(FilePath.java:893)
at hudson.FilePath.toURI(FilePath.java:1042)
at hudson.tasks.MailSender.createFailureMail(MailSender.java:278)
at hudson.tasks.MailSender.getMail(MailSender.java:153)
at hudson.tasks.MailSender.execute(MailSender.java:101)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.cleanUp(MavenModuleSetBuild.java:1058)
at hudson.model.Run.execute(Run.java:1752)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:529)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:231)
Caused by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:541)
at hudson.remoting.Request.call(Request.java:129)
at hudson.remoting.Channel.call(Channel.java:739)
at hudson.FilePath.act(FilePath.java:909)
... 10 more
Caused by: java.io.IOException
at hudson.remoting.Channel.close(Channel.java:1027)
at hudson.slaves.ChannelPinger$1.onDead(ChannelPinger.java:110)
at hudson.remoting.PingThread.ping(PingThread.java:120)
at hudson.remoting.PingThread.run(PingThread.java:81)
Caused by: java.util.concurrent.TimeoutException: Ping started on 1400194937838 
hasn't completed at 1400195177839
... 2 more


[VOTE] Release Apache Sling Servlet Archetype 1.0.2

2014-05-16 Thread Robert Munteanu
Hi,

We solved 9 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12315454

There are still some outstanding issues:
https://issues.apache.org/jira/browse/SLING/component/12311945

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1064/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1064 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


[jira] [Created] (SLING-3571) Introduce NodeTypeRegistry, attached to Repository

2014-05-16 Thread Stefan Egli (JIRA)
Stefan Egli created SLING-3571:
--

 Summary: Introduce NodeTypeRegistry, attached to Repository
 Key: SLING-3571
 URL: https://issues.apache.org/jira/browse/SLING-3571
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


We need more node type support in the IDE to support proper content 
manipulation checks and displaying properties with more details.

To do this, we introduce a NodeTypeRegistry that is attached to the Repository.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (SLING-3569) Fix test suite on Windows

2014-05-16 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-3569:
--

 Summary: Fix test suite on Windows
 Key: SLING-3569
 URL: https://issues.apache.org/jira/browse/SLING-3569
 Project: Sling
  Issue Type: Test
  Components: IDE
Reporter: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


Most of the eclipse-test tests fail on Windows, and a couple of the impl-vlt 
ones fail.

For the eclipse-test ones, it seems that no connection is made to the launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (SLING-3115) Deleting files and folders does not work on Windows

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-3115:
---

Fix Version/s: (was: Sling Eclipse IDE 1.0.2)
   Sling Eclipse IDE 1.0.0

 Deleting files and folders does not work on Windows
 ---

 Key: SLING-3115
 URL: https://issues.apache.org/jira/browse/SLING-3115
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 [September 25, 2013 12:07:23 PM EEST] AddOrUpdateNodeCommand - 
 /var/my-folder : JcrResult[ success:true] (78 ms)
 [September 25, 2013 12:07:23 PM EEST] AddOrUpdateNodeCommand - 
 /var/my-folder/some-file.txt : JcrResult[ success:true] (110 ms)
 [September 25, 2013 12:07:34 PM EEST] DeleteNodeCommand - /var/my-folder : 
 JcrResult[ success:true] (78 ms)
 [September 25, 2013 12:07:34 PM EEST] DeleteNodeCommand - 
 /var\my-folder/some-file.txt : JcrResult[ success:true] (47 ms)



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3547) Default handling for numerical types on Sling Models broken

2014-05-16 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13992732#comment-13992732
 ] 

Konrad Windszus commented on SLING-3547:


The referenced pull request shows the issue here. I am not sure how to fix 
because obviously just changing the comparison to the according object wrapper 
class leads to another error during setting the field (reflection does not 
support autoboxing)!

 Default handling for numerical types on Sling Models broken
 ---

 Key: SLING-3547
 URL: https://issues.apache.org/jira/browse/SLING-3547
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Sling Models Implementation 1.0.2
Reporter: Konrad Windszus

 Currently all default annotations on numeric types lead to the following 
 warning: 
 org.apache.sling.models.impl.ModelAdapterFactory Default values for class 
 java.lang.Boolean are not supported and the default is not used.
 This is due to the fact that first all types are converted from Primitives to 
 Object Wrapper Classes (in mapPrimitiveClasses). Then the comparison against 
 that type only considers Primitives (in getDefaultValue, except for Strings), 
 which obviously failed, because either those were Object Wrapper Classes 
 right from the beginning, or they were converted to those. 
 In my regard you should compare the Type against e.g. Integer.class instead 
 of Integer.TYPE (ModelAdapterFactory, line 428ff). Otherwise defaults for 
 numerical types will not work.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [VOTE] Release Apache Sling Servlet Archetype 1.0.2

2014-05-16 Thread Justin Edelson
+1

On Thu, May 15, 2014 at 5:03 AM, Robert Munteanu romb...@apache.org wrote:
 +1 ( non-binding )

 On Thu, May 15, 2014 at 12:03 PM, Robert Munteanu romb...@apache.org wrote:
 Hi,

 We solved 9 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12315454

 There are still some outstanding issues:
 https://issues.apache.org/jira/browse/SLING/component/12311945

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1064/

 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 1064 /tmp/sling-staging

 Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

 This majority vote is open for at least 72 hours.


[jira] [Commented] (SLING-3237) Refine new node creation workflow

2014-05-16 Thread Stefan Egli (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999722#comment-13999722
 ] 

Stefan Egli commented on SLING-3237:


We need the NodeTypeRegistry first to do this

 Refine new node creation workflow
 -

 Key: SLING-3237
 URL: https://issues.apache.org/jira/browse/SLING-3237
 Project: Sling
  Issue Type: Sub-task
  Components: IDE
Reporter: Robert Munteanu
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


 When creating a new node the dialog unconditionally generates a 
 ${node-name}.xml file. This doesn't really account for whether we are allowed 
 to generate such a node in this location, or whether the node has full or 
 partial coverage.
 This can lead to invalid structures being serialized on disk.
 Originally reported by [~dsuess]



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: Sling demos (Was Re: Ways of launching Sling for the demos)

2014-05-16 Thread Carsten Ziegeler
Thanks for bringing this up, David!

So what do people think, should we remove some of the demos David
mentioned? It doesn't make sense to have them around when they are of no
real value.

Carsten


2014-04-07 15:36 GMT+02:00 David Bosschaert david.bosscha...@gmail.com:

 Hi all,

 On 3 April 2014 17:14, David Bosschaert david.bosscha...@gmail.com
 wrote:
  On 3 April 2014 16:15, Bertrand Delacretaz bdelacre...@apache.org
 wrote:
  Note that you might find some quite old stuff under /samples, if you
  have suggestions for things that should be archived or at least marked
  obsolete let's hear them!
 
  I'm planning to take a closer look at their semantics soon - will
  share my thoughts :)

 I had a closer look at the demos. Many of the demos weren't really
 broken, but the steps to use them were often wrong (which made you
 feel it was broken) or missing. I updated the documentation for the
 following demos:
 * accessmanager-ui
 * espblog
 * javashell
 * path-based-rtp
 * slingbucks
 * slingshot
 * usermanager-ui
 * webloader (service and ui)
 the patch is in SLING-3489. I think they above demos are definitely useful
 :)

 The JavaShell demo had two deps that were broken, a fix is attached
 here: SLING-3493.

 I wasn't too sure about the following demos
 * simple-demo, I personally find this demo confusing and not 'simple' at
 all.
 * framework-fragment - this demo is broken, but it seems to show how
 to expand the OSGi Framework system packages. Seems to me that the
 Sling project is the wrong place for a demo like this (and in
 addition, you generally don't want to advocate this feature anyway).
 * installing-dependencies, a maven-based demo, is this still relevant?
 When would you use this setup?
 Maybe remove these three?

 I wasn't sure whether the following demos worked, at least I didn't
 figure out how to make them change the login form...
 * custom-login-form
 * custom-selector-login-form
 if someone can tell me how to make them do something, let me know and
 I can update their docs...

 The post-servlet-ext demo does seem to work, but requires development
 on the user side before you can actually see what it does. (The user
 needs to create a page that does a post with :operation=link to see
 something)
 I would suggest to add some more content to this demo so that you can
 actually see what it does.

 There are also a number of demos that aren't listed as submodules of
 the 'samples' pom, so they have less visibility. I would suggest to
 either remove them or make them submodules:
 * inplace-integration-tests: this one is broken, but seems useful. I
 think we should fix it and include as submodule in parent pom.
 * mail-archive: this is the beginning of a more comprehensive example.
 It seems nice but is unfortunately unfinished and doesn't seem to
 currently work. Should we keep it?
 * urlfilter: an example of using Servlet Filters with Sling. There is
 no documentation, but it might be useful to keep (and add some docs :)
 * workspacepicker: another Servlet Filter demo, this time using OSGi
 Services (whereas the urlfilter uses @SlingFilter). Again: without
 docs. Should we keep this?

 Thoughts, anyone?
 Cheers,

 David




-- 
Carsten Ziegeler
cziege...@apache.org


Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #490

2014-05-16 Thread Apache Jenkins Server
See 
https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/490/



[VOTE] Release Apache Sling Bundle Archetype 1.0.2

2014-05-16 Thread Robert Munteanu
Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12326805

There are still some outstanding issues:
https://issues.apache.org/jira/browse/SLING/component/12311945

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1062/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1062 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


[jira] [Updated] (SLING-3570) Assertion failed when trying to create new Sling Bundle project

2014-05-16 Thread Konrad Windszus (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-3570:
---

Affects Version/s: Sling Eclipse IDE 1.0.0

 Assertion failed when trying to create new Sling Bundle project
 ---

 Key: SLING-3570
 URL: https://issues.apache.org/jira/browse/SLING-3570
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
 Fix For: Sling Eclipse IDE 1.0.0


 When I try to create a new Sling Bundle project with the wizard I get the 
 following exception:
 {code}
 !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
 !MESSAGE assertion failed: 
 !STACK 0
 org.eclipse.core.runtime.AssertionFailedException: assertion failed: 
   at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
   at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
   at 
 org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
   at 
 org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
   at 
 org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
   at 
 org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
   at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
   at 
 org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
   at 
 org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
   at org.eclipse.core.internal.resources.Project.build(Project.java:114)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
   at 
 org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
   at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
 {code}
 I tested with SVN revision 1595036.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3564) it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid thread access

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998629#comment-13998629
 ] 

Robert Munteanu commented on SLING-3564:


Can you try the attached diff and see if it fixes the build for you?  In the 
tooling/ide directory, apply it with patch -p3  SLING-3564-1.diff

 it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid 
 thread access
 ---

 Key: SLING-3564
 URL: https://issues.apache.org/jira/browse/SLING-3564
 Project: Sling
  Issue Type: Bug
  Components: IDE
 Environment: mac os x, 10.7.5, java version 1.6.0_65
 Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
 Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: SLING-3564-1.diff


 When I run 'mvn clean install' in tooling/ide I get a failure in 
 tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in 
 eclipse-test):
 {code}
 ***WARNING: Display must be created on main thread due to Cocoa restrictions.
 {code}
 and the corresponding 
 tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
 {code}
 org.eclipse.swt.SWTException: Invalid thread access
 at org.eclipse.swt.SWT.error(SWT.java:4397)
 at org.eclipse.swt.SWT.error(SWT.java:4312)
 at org.eclipse.swt.SWT.error(SWT.java:4283)
 at org.eclipse.swt.widgets.Display.error(Display.java:1076)
 at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
 at org.eclipse.swt.widgets.Display.create(Display.java:816)
 at org.eclipse.swt.graphics.Device.init(Device.java:130)
 at org.eclipse.swt.widgets.Display.init(Display.java:707)
 at org.eclipse.swt.widgets.Display.init(Display.java:698)
 at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
 at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
 at 
 org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
 at 
 org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
 at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
 at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
 at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3571) Introduce NodeTypeRegistry, attached to Repository

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999752#comment-13999752
 ] 

Robert Munteanu commented on SLING-3571:


[~egli] I'm starting to get lots of test failures in the eclipse-test module. 
Can you please look into this?

{code}Failed tests:   
changeNodePrimaryType(org.apache.sling.ide.test.impl.ContentDeploymentTest): 
Unexpected IStatus when starting server
  
deployFileWithAttachedMetadata(org.apache.sling.ide.test.impl.ContentDeploymentTest):
 Unexpected IStatus when starting server
  deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest): Unexpected 
IStatus when starting server
  
reorderNodesFromNestedFullCoverageAggregate(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
 Unexpected IStatus when starting server
  
deployNestedFullCoverageAggregate(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
 Unexpected IStatus when starting server
  
deployNestedFullCoverageAggregateAtFilterRoot(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
 Unexpected IStatus when starting server
  
deleteNodeFromNestedFullCoverageAggreate(org.apache.sling.ide.test.impl.JcrFullCoverageAggregatesDeploymentTest):
 Unexpected IStatus when starting server
  deployBundleOnServer(org.apache.sling.ide.test.impl.BundleDeploymentTest): 
Unexpected IStatus when starting server

Tests run: 13, Failures: 8, Errors: 0, Skipped: 0
{code}

It seems that the server is no longer able to start 
{code}
deployFile(org.apache.sling.ide.test.impl.ContentDeploymentTest)  Time elapsed: 
0.36 sec   FAILURE!
java.lang.AssertionError: Unexpected IStatus when starting server
Expected: is OK
 but: was Status ERROR: org.apache.sling.ide.eclipse-core code=0  
java.lang.NullPointerException
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at 
org.apache.sling.ide.test.impl.helpers.SlingWstServer.waitForServerToStart(SlingWstServer.java:124)
at 
org.apache.sling.ide.test.impl.helpers.SlingWstServer.waitForServerToStart(SlingWstServer.java:105)
at 
org.apache.sling.ide.test.impl.ContentDeploymentTest.deployFile(ContentDeploymentTest.java:80)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at 
org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
at 

[jira] [Commented] (SLING-3485) Expose JSON Servlet Helpers

2014-05-16 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999707#comment-13999707
 ] 

Carsten Ziegeler commented on SLING-3485:
-

Basically the patch is fine, however instead of having the dependencies marked 
as optional, the package imports need to be marked as optional - or even better 
as dynamic. In addition a package export statement for the new package is 
missing.
But I can help with these things once you have the basic stuff committed.

I also think that we should have a look at the API and see if it might need 
improvements/changes

 Expose JSON Servlet Helpers
 ---

 Key: SLING-3485
 URL: https://issues.apache.org/jira/browse/SLING-3485
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Affects Versions: Servlets Get 2.1.8
Reporter: Dan Klco
Priority: Minor
  Labels: easyfix, patch
 Attachments: SLING-3485.diff


 Right now the following classes which are used for the JsonRendererServletare 
 not exported from the bundle.  From a developer's perspective, I may want to 
 use these classes to remix the Resource - JSON functionality without having 
 to re-write the code.
 - 
 https://svn.apache.org/repos/asf/sling/trunk/bundles/servlets/get/src/main/java/org/apache/sling/servlets/get/impl/helpers/JsonObjectCreator.java
 - 
 https://svn.apache.org/repos/asf/sling/trunk/bundles/servlets/get/src/main/java/org/apache/sling/servlets/get/impl/helpers/ResourceTraversor.java
 I propose we refactor these classes to be in the package 
 org.apache.sling.servlets.get.helpers which will expose them to the OSGi 
 Container.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (SLING-3564) it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid thread access

2014-05-16 Thread Stefan Egli (JIRA)
Stefan Egli created SLING-3564:
--

 Summary: it tests in tooling/ide/eclipse-test fail (for me) with 
SWTException: Invalid thread access
 Key: SLING-3564
 URL: https://issues.apache.org/jira/browse/SLING-3564
 Project: Sling
  Issue Type: Bug
  Components: IDE
 Environment: mac os x, 10.7.5, java version 1.6.0_65
Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
 Fix For: Sling Eclipse IDE 1.0.0
 Attachments: SLING-3564-1.diff

When I run 'mvn clean install' in tooling/ide I get a failure in 
tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in 
eclipse-test):

{code}
***WARNING: Display must be created on main thread due to Cocoa restrictions.
{code}

and the corresponding tooling/ide/eclipse-test/target/work/data/.metadata/.log 
says:

{code}
org.eclipse.swt.SWTException: Invalid thread access
at org.eclipse.swt.SWT.error(SWT.java:4397)
at org.eclipse.swt.SWT.error(SWT.java:4312)
at org.eclipse.swt.SWT.error(SWT.java:4283)
at org.eclipse.swt.widgets.Display.error(Display.java:1076)
at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
at org.eclipse.swt.widgets.Display.create(Display.java:816)
at org.eclipse.swt.graphics.Device.init(Device.java:130)
at org.eclipse.swt.widgets.Display.init(Display.java:707)
at org.eclipse.swt.widgets.Display.init(Display.java:698)
at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
at 
org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
at 
org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
at 
org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
at 
org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
at 
org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
at 
org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at 
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at 
org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at 
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at 
org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server

2014-05-16 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-3567:
--

 Summary: Cannot add null entries, when creating a new bundle and 
adding it to an existing server
 Key: SLING-3567
 URL: https://issues.apache.org/jira/browse/SLING-3567
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus


With the most recent version of Sling IDE Tooling I get the following exception 
when adding a new Sling bundle project and adding it to an existing server: 
{code}
!ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
!MESSAGE Cannot add null entries
!STACK 0
java.lang.IllegalArgumentException: Cannot add null entries
at 
org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
at 
org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
at 
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
at 
org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
at 
org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
at 
org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
at 
org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
at org.eclipse.jface.window.Window.open(Window.java:802)
at 
org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
at 
org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
at 
org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
at 
org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
at 
org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
at 
org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
at 
org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
at 
org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
at 
org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at 
org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
at 
org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
at 
org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
at 
org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at 
org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at 
org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at 

[jira] [Created] (SLING-3573) Local resources which are no longer present in the repository are not deleted when importing

2014-05-16 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-3573:
--

 Summary: Local resources which are no longer present in the 
repository are not deleted when importing
 Key: SLING-3573
 URL: https://issues.apache.org/jira/browse/SLING-3573
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.2


Consider the following scenario

Local workspace

{code}
.
├── item
│   └── html.jsp
└── list
├── html.jsp
└── json.jsp
{code}

Repository

{code}
.
├── item
│   └── html.jsp
└── list
└── html.jsp
{code}

When importing content from the repository, list/json.jsp is not deleted.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3571) Introduce NodeTypeRegistry, attached to Repository

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999761#comment-13999761
 ] 

Robert Munteanu commented on SLING-3571:


The following seems the fix the problem for me, can you double-check?

I think you might be using Oak-specific properties, which are not present in 
Jackrabbit 2.x .

{code}
diff --git 
a/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
 
b/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
index a7b589d..468eaa0 100644
--- 
a/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
+++ 
b/tooling/ide/impl-vlt/src/org/apache/sling/ide/impl/vlt/VltNodeTypeFactory.java
@@ -161,28 +161,32 @@ public class VltNodeTypeFactory {
 
 // load mandatory
 String[] mandatoryProperties = (String[]) 
child.getProperties().get(rep:mandatoryProperties);
-for (int i = 0; i  mandatoryProperties.length; i++) {
-String aMandatoryProperty = mandatoryProperties[i];
-VltPropertyDefinition vpd = pds.get(aMandatoryProperty);
-if (vpd==null) {
-vpd = new VltPropertyDefinition();
-vpd.setName(aMandatoryProperty);
-pds.put(aMandatoryProperty, vpd);
+if (mandatoryProperties != null) {
+for (int i = 0; i  mandatoryProperties.length; i++) {
+String aMandatoryProperty = mandatoryProperties[i];
+VltPropertyDefinition vpd = pds.get(aMandatoryProperty);
+if (vpd == null) {
+vpd = new VltPropertyDefinition();
+vpd.setName(aMandatoryProperty);
+pds.put(aMandatoryProperty, vpd);
+}
+vpd.setMandatory(true);
 }
-vpd.setMandatory(true);
 }
 
 // load protected
 String[] protectedProperties = (String[]) 
child.getProperties().get(rep:protectedProperties);
-for (int i = 0; i  protectedProperties.length; i++) {
-String aProtectedProperties = protectedProperties[i];
-VltPropertyDefinition vpd = pds.get(aProtectedProperties);
-if (vpd==null) {
-vpd = new VltPropertyDefinition();
-vpd.setName(aProtectedProperties);
-pds.put(aProtectedProperties, vpd);
+if (protectedProperties != null) {
+for (int i = 0; i  protectedProperties.length; i++) {
+String aProtectedProperties = protectedProperties[i];
+VltPropertyDefinition vpd = pds.get(aProtectedProperties);
+if (vpd == null) {
+vpd = new VltPropertyDefinition();
+vpd.setName(aProtectedProperties);
+pds.put(aProtectedProperties, vpd);
+}
+vpd.setProtected(true);
 }
-vpd.setProtected(true);
 }
 
 nt.setDeclaredPropertyDefinitions(pds.values().toArray(new 
VltPropertyDefinition[pds.size()]));
{code}

 Introduce NodeTypeRegistry, attached to Repository
 --

 Key: SLING-3571
 URL: https://issues.apache.org/jira/browse/SLING-3571
 Project: Sling
  Issue Type: Task
  Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


 We need more node type support in the IDE to support proper content 
 manipulation checks and displaying properties with more details.
 To do this, we introduce a NodeTypeRegistry that is attached to the 
 Repository.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3570) Assertion failed when trying to create new Sling Bundle project

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999695#comment-13999695
 ] 

Robert Munteanu commented on SLING-3570:


[~egli] - you're probably more familiar with this area of the code, does this 
ring any bells?

 Assertion failed when trying to create new Sling Bundle project
 ---

 Key: SLING-3570
 URL: https://issues.apache.org/jira/browse/SLING-3570
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
 Fix For: Sling Eclipse IDE 1.0.0


 When I try to create a new Sling Bundle project with the wizard I get the 
 following exception:
 {code}
 !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-16 09:20:12.020
 !MESSAGE assertion failed: 
 !STACK 0
 org.eclipse.core.runtime.AssertionFailedException: assertion failed: 
   at org.eclipse.core.runtime.Assert.isTrue(Assert.java:110)
   at org.eclipse.core.runtime.Assert.isTrue(Assert.java:96)
   at 
 org.eclipse.core.internal.events.BuildCommand.addBuilder(BuildCommand.java:249)
   at 
 org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:546)
   at 
 org.eclipse.core.internal.events.BuildManager.getBuilder(BuildManager.java:574)
   at 
 org.eclipse.core.internal.events.BuildManager.getRule(BuildManager.java:1124)
   at org.eclipse.core.internal.resources.Project$1.run(Project.java:612)
   at 
 org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
   at 
 org.eclipse.core.internal.resources.Project.internalBuild(Project.java:597)
   at org.eclipse.core.internal.resources.Project.build(Project.java:114)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration0(ProjectConfigurationManager.java:430)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:316)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager$2.call(ProjectConfigurationManager.java:1)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.executeBare(MavenExecutionContext.java:161)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:137)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenExecutionContext.execute(MavenExecutionContext.java:89)
   at 
 org.eclipse.m2e.core.internal.embedder.MavenImpl.execute(MavenImpl.java:1301)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:313)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:299)
   at 
 org.eclipse.m2e.core.internal.project.ProjectConfigurationManager.updateProjectConfiguration(ProjectConfigurationManager.java:281)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.updateProjectConfigurations(AbstractNewSlingApplicationWizard.java:305)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:249)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
   at 
 org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
   at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
 {code}
 I tested with SVN revision 1595036.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (SLING-3572) Make RepositoryFactory statefull, allow a Repository to be stopped

2014-05-16 Thread Stefan Egli (JIRA)
Stefan Egli created SLING-3572:
--

 Summary: Make RepositoryFactory statefull, allow a Repository to 
be stopped
 Key: SLING-3572
 URL: https://issues.apache.org/jira/browse/SLING-3572
 Project: Sling
  Issue Type: New Feature
  Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


At the moment we have a stateless RepositoryFactory, ie it only provides 
newRepository() which creates a new repository each time. This was fine as long 
as the repository was stateless - but with the introduction of the 
NodeTypeRegistry for example, the repository initialization is now also 
heavy-weight.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3405) Support Java 8 for compiling scripts

2014-05-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3405.
-

Resolution: Fixed

 Support Java 8 for compiling scripts
 

 Key: SLING-3405
 URL: https://issues.apache.org/jira/browse/SLING-3405
 Project: Sling
  Issue Type: Bug
  Components: Scripting, Testing
Reporter: Bertrand Delacretaz
Assignee: Carsten Ziegeler
Priority: Minor
 Fix For: Scripting JSP 2.1.0, Commons Compiler 2.1.2

 Attachments: jasper-upgrade.patch


 Running the launchpad/integration-tests SLING2094Test fails due to a 
 compilation error for the test script [1]: Unable to compile class for JSP, 
 the import java.util.Arrays cannot be resolved.
 [1] 
 https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/resources/integration-test/issues/sling2094/sling2094.jsp



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Build failed in Jenkins: sling-trunk-1.7 #493

2014-05-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-trunk-1.7/493/

--
Failed to access build log

java.io.IOException: remote file operation failed: 
/home/jenkins/jenkins-slave/workspace/sling-trunk-1.7 at 
hudson.remoting.Channel@1bd13118:ubuntu6
at hudson.FilePath.act(FilePath.java:916)
at hudson.FilePath.act(FilePath.java:893)
at hudson.FilePath.toURI(FilePath.java:1042)
at hudson.tasks.MailSender.createFailureMail(MailSender.java:278)
at hudson.tasks.MailSender.getMail(MailSender.java:153)
at hudson.tasks.MailSender.execute(MailSender.java:101)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.cleanUp(MavenModuleSetBuild.java:1058)
at hudson.model.Run.execute(Run.java:1752)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:529)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:231)
Caused by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:541)
at hudson.remoting.Request.call(Request.java:129)
at hudson.remoting.Channel.call(Channel.java:739)
at hudson.FilePath.act(FilePath.java:909)
... 10 more
Caused by: java.io.IOException
at hudson.remoting.Channel.close(Channel.java:1027)
at hudson.slaves.ChannelPinger$1.onDead(ChannelPinger.java:110)
at hudson.remoting.PingThread.ping(PingThread.java:120)
at hudson.remoting.PingThread.run(PingThread.java:81)
Caused by: java.util.concurrent.TimeoutException: Ping started on 1400194937838 
hasn't completed at 1400195177839
... 2 more


[jira] [Commented] (SLING-3564) it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: Invalid thread access

2014-05-16 Thread Stefan Egli (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998637#comment-13998637
 ] 

Stefan Egli commented on SLING-3564:


That patch helped - the SWTException is gone.

Unfortunately, now there's an actual test failure:
{code}
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.503 sec  
FAILURE!
deployBundleOnServer(org.apache.sling.ide.test.impl.BundleDeploymentTest)  Time 
elapsed: 11.27 sec   FAILURE!
java.lang.AssertionError: Unexpected status call for 
http://localhost:49227/simple-servlet
Expected: 200
 but: was 404
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:865)
at 
org.apache.sling.ide.test.impl.helpers.RepositoryAccessor.assertGetIsSuccessful(RepositoryAccessor.java:66)
at 
org.apache.sling.ide.test.impl.BundleDeploymentTest$1.call(BundleDeploymentTest.java:129)
at 
org.apache.sling.ide.test.impl.BundleDeploymentTest$1.call(BundleDeploymentTest.java:1)
at org.apache.sling.ide.test.impl.helpers.Poller$1.run(Poller.java:79)
at 
org.apache.sling.ide.test.impl.helpers.Poller.pollUntilSuccessful(Poller.java:41)
at 
org.apache.sling.ide.test.impl.helpers.Poller.pollUntil(Poller.java:74)
at 
org.apache.sling.ide.test.impl.BundleDeploymentTest.deployBundleOnServer(BundleDeploymentTest.java:126)
{code}

 it tests in tooling/ide/eclipse-test fail on MacOS X with SWTException: 
 Invalid thread access
 -

 Key: SLING-3564
 URL: https://issues.apache.org/jira/browse/SLING-3564
 Project: Sling
  Issue Type: Bug
  Components: IDE
 Environment: mac os x, 10.7.5, java version 1.6.0_65
 Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
 Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: SLING-3564-1.diff


 When I run 'mvn clean install' in tooling/ide I get a failure in 
 tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in 
 eclipse-test):
 {code}
 ***WARNING: Display must be created on main thread due to Cocoa restrictions.
 {code}
 and the corresponding 
 tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
 {code}
 org.eclipse.swt.SWTException: Invalid thread access
 at org.eclipse.swt.SWT.error(SWT.java:4397)
 at org.eclipse.swt.SWT.error(SWT.java:4312)
 at org.eclipse.swt.SWT.error(SWT.java:4283)
 at org.eclipse.swt.widgets.Display.error(Display.java:1076)
 at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
 at org.eclipse.swt.widgets.Display.create(Display.java:816)
 at org.eclipse.swt.graphics.Device.init(Device.java:130)
 at org.eclipse.swt.widgets.Display.init(Display.java:707)
 at org.eclipse.swt.widgets.Display.init(Display.java:698)
 at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
 at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
 at 
 org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
 at 
 org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
 at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
 at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
 at 

[jira] [Commented] (SLING-2985) [Tooling] show content of .content.xml in project explorer

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-2985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998588#comment-13998588
 ] 

Robert Munteanu commented on SLING-2985:


[~egli] - I get a compilation error, probably related to your latest changes, 
can you please double-check?

{code}[ERROR] Failed to execute goal 
org.eclipse.tycho:tycho-compiler-plugin:0.20.0:compile (default-compile) on 
project org.apache.sling.ide.eclipse-ui: Compilation failure: Compilation 
failure:
[ERROR] 
/home/ADOBENET/rmuntean/w/workspace/sling/tooling/ide/eclipse-ui/src/org/apache/sling/ide/eclipse/ui/actions/JcrNewNodeAction.java:[60]
[ERROR] node.createChild(id.getValue());
[ERROR] ^^^
[ERROR] The method createChild(String, String) in the type JcrNode is not 
applicable for the arguments (String)
[ERROR] 1 problem (1 error)
[ERROR] - [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn goals -rf :org.apache.sling.ide.eclipse-ui
{code}

 [Tooling] show content of .content.xml in project explorer
 --

 Key: SLING-2985
 URL: https://issues.apache.org/jira/browse/SLING-2985
 Project: Sling
  Issue Type: New Feature
  Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


 Irrespective of the chosen serialization the content of .content.xml should 
 be shown in the tree structure of the project explorer. This can be achieved 
 using a Navigator Content Extension (NCE) (which is part of the Common 
 Navigator Framework (CNF) of eclipse).



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3542) Use commons compiler (instead of embedding own jdt compiler)

2014-05-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-3542.
-

Resolution: Fixed

 Use commons compiler (instead of embedding own jdt compiler)
 

 Key: SLING-3542
 URL: https://issues.apache.org/jira/browse/SLING-3542
 Project: Sling
  Issue Type: Improvement
  Components: Scripting
Affects Versions: Scripting JSP 2.0.28
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Scripting JSP 2.1.0


 Currently the jsp scripting embeds its own compiler (which is quiet large). 
 Instead of doing this, the compiler from the commons compiler bundle can be 
 used.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (SLING-3359) Classloader Leak Detector Console Tab

2014-05-16 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-3359:
---

Fix Version/s: ClassLoader Leak Detector 1.0.0

 Classloader Leak Detector Console Tab
 -

 Key: SLING-3359
 URL: https://issues.apache.org/jira/browse/SLING-3359
 Project: Sling
  Issue Type: New Feature
  Components: Console
Reporter: Ian Boston
Assignee: Chetan Mehrotra
 Fix For: ClassLoader Leak Detector 1.0.0

 Attachments: 
 org.apache.sling.extensions.classloader-leak-detector-0.0.1-SNAPSHOT-src.zip


 Chetan has created a classloader leak detector console at 
 https://github.com/chetanmeh/sling-leak-detector. It would be really good to 
 get this into the contrib are and released so that consumers of Sling can use 
 it to locate code in bundles that is leaking classloaders.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (SLING-3571) Introduce NodeTypeRegistry, attached to Repository

2014-05-16 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-3571:
---

Issue Type: Task  (was: Bug)

 Introduce NodeTypeRegistry, attached to Repository
 --

 Key: SLING-3571
 URL: https://issues.apache.org/jira/browse/SLING-3571
 Project: Sling
  Issue Type: Task
  Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
 Fix For: Sling Eclipse IDE 1.0.0


 We need more node type support in the IDE to support proper content 
 manipulation checks and displaying properties with more details.
 To do this, we introduce a NodeTypeRegistry that is attached to the 
 Repository.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Re: [VOTE] Release Apache Sling Bundle Archetype 1.0.2

2014-05-16 Thread Robert Munteanu
+1 ( non-binding )

On Thu, May 15, 2014 at 11:55 AM, Robert Munteanu romb...@apache.org wrote:
 Hi,

 We solved 5 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12326805

 There are still some outstanding issues:
 https://issues.apache.org/jira/browse/SLING/component/12311945

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1062/

 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 1062 /tmp/sling-staging

 Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

 This majority vote is open for at least 72 hours.


Re: Events, Jobs and admin sessions

2014-05-16 Thread Lars Krapf
Hello Marius

It depends on the use-case. In examples like yours a service-user would
most probably be the right choice. In other examples, for instance a job
that processes an asset, the job should be performed with the privileges
of the triggering user, to limit the possibilities of an potential exploit.

Best greetings
Lars

On 14.05.2014 19:39, Marius Petria wrote:
 Hi,
 
 When processing events and jobs, the corresponding subject triggering
 the event usually gets lost. This lead to event handlers / job
 consumers often operating with administrative sessions/resolvers to
 do their work, which in turn can lead to privilege escalations.
 
 Is that a good pattern to encourage, i.e. to execute the handlers using the 
 security context of the triggering subject? You could pass the information on 
 a case by case basis, but typically consumers might represent different 
 services than the one triggering the action. Imagine an indexing service that 
 listens to all modifications. If the user for that service does not have read 
 permissions for certain resources then those should not be indexed when an 
 admin is editing the content.
 
 Marius
 
  
 



[jira] [Resolved] (SLING-3567) Cannot add null entries, when creating a new bundle and adding it to an existing server

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3567.


Resolution: Fixed

Thanks for confirming, marked as fixed.

 Cannot add null entries, when creating a new bundle and adding it to an 
 existing server
 ---

 Key: SLING-3567
 URL: https://issues.apache.org/jira/browse/SLING-3567
 Project: Sling
  Issue Type: Bug
  Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.0
Reporter: Konrad Windszus
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 With the most recent version of Sling IDE Tooling I get the following 
 exception when adding a new Sling bundle project and adding it to an existing 
 server: 
 {code}
 !ENTRY org.apache.sling.ide.eclipse-m2e-ui 4 0 2014-05-15 16:02:47.721
 !MESSAGE Cannot add null entries
 !STACK 0
 java.lang.IllegalArgumentException: Cannot add null entries
   at 
 org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2467)
   at 
 org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:268)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.access$0(AbstractNewSlingApplicationWizard.java:161)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard$1.run(AbstractNewSlingApplicationWizard.java:144)
   at 
 org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
   at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
   at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
   at 
 org.apache.sling.ide.eclipse.ui.wizards.np.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:138)
   at 
 org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
   at 
 org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
   at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:628)
   at 
 org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
   at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
   at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4166)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1466)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1489)
   at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1474)
   at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
   at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4012)
   at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3651)
   at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
   at org.eclipse.jface.window.Window.open(Window.java:802)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler$New.executeHandler(WizardHandler.java:259)
   at 
 org.eclipse.ui.internal.handlers.WizardHandler.execute(WizardHandler.java:279)
   at 
 org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:290)
   at 
 org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:90)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:56)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:243)
   at 
 org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:224)
   at 
 org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:132)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:167)
   at org.eclipse.core.commands.Command.executeWithChecks(Command.java:499)
   at 
 org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
   at 
 org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)
   at 
 org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:420)
   at 
 org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
   at 
 

[jira] [Resolved] (SLING-2651) Manually trigger sync on files/directories

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-2651.


Resolution: Fixed

Fixed:

- http://svn.apache.org/viewvc?view=revisionrevision=1594890 - move more 
filter-related logic to ProjectUtil
- http://svn.apache.org/viewvc?view=revisionrevision=1594892 - 
ExportWizardPage - display information about the filter that will be used
- http://svn.apache.org/viewvc?view=revisionrevision=1594893 - fix tracing 
arguments in ResourceChangeCommandFactory
- http://svn.apache.org/viewvc?view=revisionrevision=1594894 - skip 
serialization directories ( $nodename.dir )
- http://svn.apache.org/viewvc?view=revisionrevision=159489 - update key 
binding for export action

 Manually trigger sync on files/directories
 --

 Key: SLING-2651
 URL: https://issues.apache.org/jira/browse/SLING-2651
 Project: Sling
  Issue Type: Improvement
  Components: IDE
Reporter: Antonio Sanso
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 We should be able to manually publish a subtree of content, as opposed to the 
 sync happening in the background. One use case is where the auto-sync is 
 disabled and the user only wants to publish the changes manually.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3559) Never run project launches when publishing

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999192#comment-13999192
 ] 

Robert Munteanu commented on SLING-3559:


The new project wizard simply requests a full publish of the server - not sure 
if that's not too heavyweight right now, but it works.

https://github.com/apache/sling/blob/c6b87d8043efde46dad6cb360df738b821da206c/tooling/ide/eclipse-m2e-ui/src/org/apache/sling/ide/eclipse/ui/wizards/np/AbstractNewSlingApplicationWizard.java#L277

 Never run project launches when publishing
 --

 Key: SLING-3559
 URL: https://issues.apache.org/jira/browse/SLING-3559
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 The SlingLaunchpadBehaviour still runs project launches if they exist. I 
 don't think that's needed anymore, as the content sync code should be good 
 enough, and launches are reserved for other tasks. As such, we should remove 
 that code.
 [~egli] - is there anything that I missed?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Created] (SLING-3563) Removal of node with sling:alias property is ignored by sling resource resolution

2014-05-16 Thread Antonio Sanso (JIRA)
Antonio Sanso created SLING-3563:


 Summary: Removal of node with sling:alias property  is ignored by 
sling resource resolution
 Key: SLING-3563
 URL: https://issues.apache.org/jira/browse/SLING-3563
 Project: Sling
  Issue Type: Bug
Reporter: Antonio Sanso


Removal of node with sling:alias property  is ignored by sling resource 
resolution.

I will commit a show case test.
This issue will be address together with SLING-3505



--
This message was sent by Atlassian JIRA
(v6.2#6252)


Build failed in Jenkins: sling-contrib-1.6 #1129

2014-05-16 Thread Apache Jenkins Server
See https://builds.apache.org/job/sling-contrib-1.6/1129/

--
Failed to access build log

java.io.IOException: remote file operation failed: 
/home/jenkins/jenkins-slave/workspace/sling-contrib-1.6 at 
hudson.remoting.Channel@1bd13118:ubuntu6
at hudson.FilePath.act(FilePath.java:916)
at hudson.FilePath.act(FilePath.java:893)
at hudson.FilePath.toURI(FilePath.java:1042)
at hudson.tasks.MailSender.createFailureMail(MailSender.java:278)
at hudson.tasks.MailSender.getMail(MailSender.java:153)
at hudson.tasks.MailSender.execute(MailSender.java:101)
at 
hudson.maven.MavenModuleSetBuild$MavenModuleSetBuildExecution.cleanUp(MavenModuleSetBuild.java:1058)
at hudson.model.Run.execute(Run.java:1752)
at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:529)
at hudson.model.ResourceController.execute(ResourceController.java:88)
at hudson.model.Executor.run(Executor.java:231)
Caused by: hudson.remoting.ChannelClosedException: channel is already closed
at hudson.remoting.Channel.send(Channel.java:541)
at hudson.remoting.Request.call(Request.java:129)
at hudson.remoting.Channel.call(Channel.java:739)
at hudson.FilePath.act(FilePath.java:909)
... 10 more
Caused by: java.io.IOException
at hudson.remoting.Channel.close(Channel.java:1027)
at hudson.slaves.ChannelPinger$1.onDead(ChannelPinger.java:110)
at hudson.remoting.PingThread.ping(PingThread.java:120)
at hudson.remoting.PingThread.run(PingThread.java:81)
Caused by: java.util.concurrent.TimeoutException: Ping started on 1400194937838 
hasn't completed at 1400195177839
... 2 more


Re: Sling demos (Was Re: Ways of launching Sling for the demos)

2014-05-16 Thread Ruben Reusser
Carsten

It would be a good idea to make the demos available from the root page in sling 
once a demo is deployed. Some short description of the demo and how it's 
supposed to be used would be good too.

Ruben

 On May 16, 2014, at 4:49 AM, Carsten Ziegeler cziege...@apache.org wrote:
 
 Thanks for bringing this up, David!
 
 So what do people think, should we remove some of the demos David
 mentioned? It doesn't make sense to have them around when they are of no
 real value.
 
 Carsten
 
 
 2014-04-07 15:36 GMT+02:00 David Bosschaert david.bosscha...@gmail.com:
 
 Hi all,
 
 On 3 April 2014 17:14, David Bosschaert david.bosscha...@gmail.com
 wrote:
 On 3 April 2014 16:15, Bertrand Delacretaz bdelacre...@apache.org
 wrote:
 Note that you might find some quite old stuff under /samples, if you
 have suggestions for things that should be archived or at least marked
 obsolete let's hear them!
 
 I'm planning to take a closer look at their semantics soon - will
 share my thoughts :)
 
 I had a closer look at the demos. Many of the demos weren't really
 broken, but the steps to use them were often wrong (which made you
 feel it was broken) or missing. I updated the documentation for the
 following demos:
 * accessmanager-ui
 * espblog
 * javashell
 * path-based-rtp
 * slingbucks
 * slingshot
 * usermanager-ui
 * webloader (service and ui)
 the patch is in SLING-3489. I think they above demos are definitely useful
 :)
 
 The JavaShell demo had two deps that were broken, a fix is attached
 here: SLING-3493.
 
 I wasn't too sure about the following demos
 * simple-demo, I personally find this demo confusing and not 'simple' at
 all.
 * framework-fragment - this demo is broken, but it seems to show how
 to expand the OSGi Framework system packages. Seems to me that the
 Sling project is the wrong place for a demo like this (and in
 addition, you generally don't want to advocate this feature anyway).
 * installing-dependencies, a maven-based demo, is this still relevant?
 When would you use this setup?
 Maybe remove these three?
 
 I wasn't sure whether the following demos worked, at least I didn't
 figure out how to make them change the login form...
 * custom-login-form
 * custom-selector-login-form
 if someone can tell me how to make them do something, let me know and
 I can update their docs...
 
 The post-servlet-ext demo does seem to work, but requires development
 on the user side before you can actually see what it does. (The user
 needs to create a page that does a post with :operation=link to see
 something)
 I would suggest to add some more content to this demo so that you can
 actually see what it does.
 
 There are also a number of demos that aren't listed as submodules of
 the 'samples' pom, so they have less visibility. I would suggest to
 either remove them or make them submodules:
 * inplace-integration-tests: this one is broken, but seems useful. I
 think we should fix it and include as submodule in parent pom.
 * mail-archive: this is the beginning of a more comprehensive example.
 It seems nice but is unfortunately unfinished and doesn't seem to
 currently work. Should we keep it?
 * urlfilter: an example of using Servlet Filters with Sling. There is
 no documentation, but it might be useful to keep (and add some docs :)
 * workspacepicker: another Servlet Filter demo, this time using OSGi
 Services (whereas the urlfilter uses @SlingFilter). Again: without
 docs. Should we keep this?
 
 Thoughts, anyone?
 Cheers,
 
 David
 
 
 
 -- 
 Carsten Ziegeler
 cziege...@apache.org


Re: [VOTE] Release Apache Sling JCRInstall Bundle Archetype 1.0.2

2014-05-16 Thread Robert Munteanu
+1 ( non-binding )

On Thu, May 15, 2014 at 11:59 AM, Robert Munteanu romb...@apache.org wrote:
 Hi,

 We solved 5 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12326806

 There are still some outstanding issues:
 https://issues.apache.org/jira/browse/SLING/component/12311945

 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1063/

 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

 Usage:
 sh check_staged_release.sh 1063 /tmp/sling-staging

 Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

 This majority vote is open for at least 72 hours.


[jira] [Created] (SLING-3568) Allow importing content from arbitrary locations

2014-05-16 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-3568:
--

 Summary: Allow importing content from arbitrary locations
 Key: SLING-3568
 URL: https://issues.apache.org/jira/browse/SLING-3568
 Project: Sling
  Issue Type: Improvement
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


The current import wizard only processes the whole project. This is problematic 
for large projects where import would take a lot of time. Also, at times a 
developer makes a small change in the repository and wants to sync it back to 
the workspace.

To support these scenarios we need to allow importing content from arbitrary 
locations under the content sync root.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3161) SlingIDE Import Content wizard should respect .vltignore files

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999760#comment-13999760
 ] 

Robert Munteanu commented on SLING-3161:


The rules for parsing .vltignore files are found in the 
[Ignore#addIgnored|https://github.com/apache/jackrabbit-filevault/blob/9981fdca2630bc08b921752f41475e0027615da4/vault-vlt/src/main/java/org/apache/jackrabbit/vault/vlt/meta/Ignored.java#L122].

 SlingIDE Import Content wizard should respect .vltignore files
 --

 Key: SLING-3161
 URL: https://issues.apache.org/jira/browse/SLING-3161
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Justin Edelson
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 Given in repository:
 /apps/foo/install
 /apps/foo/install/.vltignore = *.jar
 /apps/foo/install/foo.jar
 Then running import content should not copy foo.jar into the local working 
 copy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (SLING-3564) it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid thread access

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-3564:
---

Attachment: SLING-3564-1.diff

 it tests in tooling/ide/eclipse-test fail (for me) with SWTException: Invalid 
 thread access
 ---

 Key: SLING-3564
 URL: https://issues.apache.org/jira/browse/SLING-3564
 Project: Sling
  Issue Type: Bug
  Components: IDE
 Environment: mac os x, 10.7.5, java version 1.6.0_65
 Java(TM) SE Runtime Environment (build 1.6.0_65-b14-462-11M4609)
 Java HotSpot(TM) 64-Bit Server VM (build 20.65-b04-462, mixed mode)
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
 Fix For: Sling Eclipse IDE 1.0.0

 Attachments: SLING-3564-1.diff


 When I run 'mvn clean install' in tooling/ide I get a failure in 
 tooling/ide/eclipse-test (same thing happens with just 'mvn clean verify' in 
 eclipse-test):
 {code}
 ***WARNING: Display must be created on main thread due to Cocoa restrictions.
 {code}
 and the corresponding 
 tooling/ide/eclipse-test/target/work/data/.metadata/.log says:
 {code}
 org.eclipse.swt.SWTException: Invalid thread access
 at org.eclipse.swt.SWT.error(SWT.java:4397)
 at org.eclipse.swt.SWT.error(SWT.java:4312)
 at org.eclipse.swt.SWT.error(SWT.java:4283)
 at org.eclipse.swt.widgets.Display.error(Display.java:1076)
 at org.eclipse.swt.widgets.Display.createDisplay(Display.java:833)
 at org.eclipse.swt.widgets.Display.create(Display.java:816)
 at org.eclipse.swt.graphics.Device.init(Device.java:130)
 at org.eclipse.swt.widgets.Display.init(Display.java:707)
 at org.eclipse.swt.widgets.Display.init(Display.java:698)
 at org.eclipse.ui.internal.Workbench.createDisplay(Workbench.java:695)
 at org.eclipse.ui.PlatformUI.createDisplay(PlatformUI.java:162)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.createDisplay(IDEApplication.java:154)
 at 
 org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:96)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.runApplication(UITestApplication.java:31)
 at 
 org.eclipse.tycho.surefire.osgibooter.AbstractUITestApplication.run(AbstractUITestApplication.java:114)
 at 
 org.eclipse.tycho.surefire.osgibooter.UITestApplication.start(UITestApplication.java:37)
 at 
 org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
 at 
 org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
 at 
 org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
 at java.lang.reflect.Method.invoke(Method.java:597)
 at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
 at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
 at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
 at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3550) Inspect bundles for deployment for well-known errors

2014-05-16 Thread Stefan Egli (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998610#comment-13998610
 ] 

Stefan Egli commented on SLING-3550:


+1

 Inspect bundles for deployment for well-known errors
 

 Key: SLING-3550
 URL: https://issues.apache.org/jira/browse/SLING-3550
 Project: Sling
  Issue Type: New Feature
  Components: IDE
Reporter: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.2


 We should validate that the bundle's output directory contains at least
 * a META-INF/MANIFEST.MF file 
 * DS descriptors if the Service-Component header is present
 This should cover almost all of the troubles hit when bundle deployment does 
 not work as expected



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Assigned] (SLING-3161) SlingIDE Import Content wizard should respect .vltignore filess

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-3161:
--

Assignee: Robert Munteanu

 SlingIDE Import Content wizard should respect .vltignore filess
 ---

 Key: SLING-3161
 URL: https://issues.apache.org/jira/browse/SLING-3161
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Justin Edelson
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 Given in repository:
 /apps/foo/install
 /apps/foo/install/.vltignore = *.jar
 /apps/foo/install/foo.jar
 Then running import content should not copy foo.jar into the local working 
 copy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3376) TenantProvider passes tenant with old state to TenantCustomizer

2014-05-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13998536#comment-13998536
 ] 

ASF GitHub Bot commented on SLING-3376:
---

Github user roele closed the pull request at:

https://github.com/apache/sling/pull/11


 TenantProvider passes tenant with old state to TenantCustomizer
 ---

 Key: SLING-3376
 URL: https://issues.apache.org/jira/browse/SLING-3376
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Tenant 1.0.0
Reporter: Roland Schaer
Assignee: Amit Gupta
Priority: Minor
 Fix For: Tenant 1.0.2

 Attachments: SLING-3376.patch


 The TenantProvider does pass a Tenant with the old state to the 
 TenantCustomizer#setup() method, making it impossible to handle changes  on 
 the update case. I would expect to have a Tenant (in a transient state) 
 passed which reflects the new state.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (SLING-3081) Do not re-publish modules when starting the launchpad for the first time

2014-05-16 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13999759#comment-13999759
 ] 

Robert Munteanu commented on SLING-3081:


{quote}The new-project-wizard will also start the server of course and 
up-till-now was assuming the publish would automatically start. That we can 
still trigger explicitly from the wizard though, so no issue there.{quote}

Sounds good

 Do not re-publish modules when starting the launchpad for the first time
 

 Key: SLING-3081
 URL: https://issues.apache.org/jira/browse/SLING-3081
 Project: Sling
  Issue Type: Bug
  Components: IDE
Reporter: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.2


 This results in unnecessary publishing activity. The right way is to provide 
 a manual action to sync a sub-tree to ( or the whole module ) to the 
 Launchpad.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (SLING-3568) Allow importing content from arbitrary locations

2014-05-16 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-3568.


Resolution: Fixed

- http://svn.apache.org/viewvc?view=revisionrevision=1595166 - add 
ProjectUtil.isInsideContentSyncRoot
- http://svn.apache.org/viewvc?view=revisionrevision=1595167 - update 
ContentResourceTester with canBeImported property
- http://svn.apache.org/viewvc?view=revisionrevision=1595168 - allow the 
ImportWizard to select arbitrary locations for importing.

 Allow importing content from arbitrary locations
 

 Key: SLING-3568
 URL: https://issues.apache.org/jira/browse/SLING-3568
 Project: Sling
  Issue Type: Improvement
  Components: IDE
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Sling Eclipse IDE 1.0.0


 The current import wizard only processes the whole project. This is 
 problematic for large projects where import would take a lot of time. Also, 
 at times a developer makes a small change in the repository and wants to sync 
 it back to the workspace.
 To support these scenarios we need to allow importing content from arbitrary 
 locations under the content sync root.



--
This message was sent by Atlassian JIRA
(v6.2#6252)