Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2186
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2186
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2186/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2186
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2186/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2186
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2186/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2186
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2186/
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Installer Integration Tests #2186
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/2186/
Jenkins build is still unstable: sling-trunk-1.6 #2186
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Updated] (SLING-3495) TopologyTest.testLargeTopologyWithHub failures on Jenkins
[
https://issues.apache.org/jira/browse/SLING-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Delacretaz updated SLING-3495:
---
Attachment: 2014-05-17.log
The timeout is correctly increased:
{code}
17.06.2014 04:51:32 *INFO * [main] LargeTopologyWithHubTest: setUp: using
heartbeatTimeout of 1200sec (default: 300)
{code}
But the test still failed at
http://ci.apache.org/builders/sling-trunk/builds/385/steps/compile/logs/stdio ,
I'm attaching the relevant part of the log.
It looks like TopologyView items are still expiring:
{code}
testLargeTopologyWithHub: checking if all connectors are registered,
TopologyView has 93 Instances
...TopologyView has 93 Instances
...TopologyView has 91 Instances
...TopologyView has 89 Instances
...
{code}
TopologyTest.testLargeTopologyWithHub failures on Jenkins
-
Key: SLING-3495
URL: https://issues.apache.org/jira/browse/SLING-3495
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Discovery Impl 1.0.6
Reporter: Robert Munteanu
Assignee: Stefan Egli
Attachments: 2014-05-17.log,
TopologyTest.testLargeTopologyWithHub-failure-sling-trunk-1.6.txt,
TopologyTest.testLargeTopologyWithHub-failure-sling-trunk-1.7.txt
TopologyTest.testLargeTopologyWithHub has failed in the last testing run for
both sling-trunk-1.6 [1] and sling-trunk-1.7 [2] .
The errors are attached, in case the build results will expire.
[1]:
https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.6/lastBuild/org.apache.sling$org.apache.sling.discovery.impl/testReport/org.apache.sling.discovery.impl.topology/TopologyTest/testLargeTopologyWithHub/
[2]:
https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/lastBuild/org.apache.sling$org.apache.sling.discovery.impl/testReport/org.apache.sling.discovery.impl.topology/TopologyTest/testLargeTopologyWithHub/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3495) TopologyTest.testLargeTopologyWithHub failures on Jenkins
[ https://issues.apache.org/jira/browse/SLING-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033524#comment-14033524 ] Stefan Egli commented on SLING-3495: [~bdelacretaz], thanks for double-checking! I 'forgot' to set the heartbeatTimeout also on the 'hub' instance (only set it on the 'satellite' instances so far). Hopefully this should fix everything and the timeout can be decreased from 300 back to eg 30 TopologyTest.testLargeTopologyWithHub failures on Jenkins - Key: SLING-3495 URL: https://issues.apache.org/jira/browse/SLING-3495 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.6 Reporter: Robert Munteanu Assignee: Stefan Egli Attachments: 2014-05-17.log, TopologyTest.testLargeTopologyWithHub-failure-sling-trunk-1.6.txt, TopologyTest.testLargeTopologyWithHub-failure-sling-trunk-1.7.txt TopologyTest.testLargeTopologyWithHub has failed in the last testing run for both sling-trunk-1.6 [1] and sling-trunk-1.7 [2] . The errors are attached, in case the build results will expire. [1]: https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.6/lastBuild/org.apache.sling$org.apache.sling.discovery.impl/testReport/org.apache.sling.discovery.impl.topology/TopologyTest/testLargeTopologyWithHub/ [2]: https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/lastBuild/org.apache.sling$org.apache.sling.discovery.impl/testReport/org.apache.sling.discovery.impl.topology/TopologyTest/testLargeTopologyWithHub/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (SLING-3673) Content-sync bug: children are uploaded, then immediately deleted
Stefan Egli created SLING-3673:
--
Summary: Content-sync bug: children are uploaded, then immediately
deleted
Key: SLING-3673
URL: https://issues.apache.org/jira/browse/SLING-3673
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Stefan Egli
Assignee: Robert Munteanu
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.0
consider the following content structure:
{code}
\- cccontent
|- jcr:content
|- en
\- fr
{code}
When uploading (export) this structure, the uploading mechanism correctly goes
through all children, eg in the following order:
{code}
/content/cccontent/fr
/content/cccontent/en
/content/cccontent/_jcr_content
{code}
then, handles the .content.xml of the cccontent directory:
{code}
/content/cccontent[.content.xml]
{code}
which seems to delete both 'fr' and 'en' children
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-3663) IllegalArgumentException when creating a bundle - Add and remove cannot be both null/empty
[
https://issues.apache.org/jira/browse/SLING-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli resolved SLING-3663.
Resolution: Fixed
Marking this one resolved for now as we have a potential fix. If it happens
again, we shall reopen it.
IllegalArgumentException when creating a bundle - Add and remove cannot be
both null/empty
--
Key: SLING-3663
URL: https://issues.apache.org/jira/browse/SLING-3663
Project: Sling
Issue Type: Bug
Components: IDE
Reporter: Stefan Egli
Assignee: Stefan Egli
Priority: Critical
Fix For: Sling Eclipse IDE 1.0.0
Following stacktrace occured when creating a new project:
{code}
java.lang.IllegalArgumentException: Add and remove cannot both be null/empty
at
org.eclipse.wst.server.core.internal.Server.canModifyModules(Server.java:2461)
at
org.eclipse.wst.server.core.internal.ServerWorkingCopy.modifyModules(ServerWorkingCopy.java:544)
at
org.apache.sling.ide.eclipse.ui.wizards.AbstractNewSlingApplicationWizard.deployProjectsOnServer(AbstractNewSlingApplicationWizard.java:183)
at
org.apache.sling.ide.eclipse.ui.wizards.AbstractNewSlingApplicationWizard$3.execute(AbstractNewSlingApplicationWizard.java:131)
at
org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:106)
at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2345)
at
org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:118)
at
org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
at
org.apache.sling.ide.eclipse.ui.wizards.AbstractNewSlingApplicationWizard.performFinish(AbstractNewSlingApplicationWizard.java:127)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Models Integration Tests #563
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.models.integration-tests/563/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #563
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/563/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Resource Access Security Integration Tests #563
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/563/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Sample Integration Tests #563
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/563/
Jenkins build is still unstable: sling-trunk-1.7 #563
See https://builds.apache.org/job/sling-trunk-1.7/changes
[jira] [Resolved] (SLING-3495) TopologyTest.testLargeTopologyWithHub failures on Jenkins
[ https://issues.apache.org/jira/browse/SLING-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz resolved SLING-3495. Resolution: Fixed Thanks Stefan for the fixes, the test indeed passes now, at http://ci.apache.org/builders/sling-trunk/builds/386/steps/compile/logs/stdio TopologyTest.testLargeTopologyWithHub failures on Jenkins - Key: SLING-3495 URL: https://issues.apache.org/jira/browse/SLING-3495 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Discovery Impl 1.0.6 Reporter: Robert Munteanu Assignee: Stefan Egli Attachments: 2014-05-17.log, TopologyTest.testLargeTopologyWithHub-failure-sling-trunk-1.6.txt, TopologyTest.testLargeTopologyWithHub-failure-sling-trunk-1.7.txt TopologyTest.testLargeTopologyWithHub has failed in the last testing run for both sling-trunk-1.6 [1] and sling-trunk-1.7 [2] . The errors are attached, in case the build results will expire. [1]: https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.6/lastBuild/org.apache.sling$org.apache.sling.discovery.impl/testReport/org.apache.sling.discovery.impl.topology/TopologyTest/testLargeTopologyWithHub/ [2]: https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/lastBuild/org.apache.sling$org.apache.sling.discovery.impl/testReport/org.apache.sling.discovery.impl.topology/TopologyTest/testLargeTopologyWithHub/ -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3234) Sling buildbot continuous integration
[ https://issues.apache.org/jira/browse/SLING-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033593#comment-14033593 ] Bertrand Delacretaz commented on SLING-3234: I have added the mvn -fae option to https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/sling.conf to avoid aborting the build if a single test fails Sling buildbot continuous integration - Key: SLING-3234 URL: https://issues.apache.org/jira/browse/SLING-3234 Project: Sling Issue Type: Task Components: Testing Reporter: Bertrand Delacretaz Assignee: Bertrand Delacretaz Buildbot jobs have been setup for Sling in INFRA-6962; * http://ci.apache.org/builders/sling-trunk (triggered by commits) * http://ci.apache.org/builders/sling-trunk-oak (runs after sling-trunk) We'll use this issue to keep track of changes related to this buildbot setup, as we did with SLING-920 for our Jenkins builds. I suggest marking issues that cause intermittent buildbot failures as blockers for this issue, so that we can quickly check if failed builds are due to known issues. Builds can be started manually via IRC if needed, via #asftest. Talk to the sling-bot there, start with help force, status or commands. [1] https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/sling.conf -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033606#comment-14033606
]
Bertrand Delacretaz commented on SLING-2938:
I'll restart the discussion about this on the dev list, see also
http://markmail.org/message/ku6svfns46jvw5ik where we didn't really agree on
whether the magic should happen at build time or runtime.
AdapterMethods annotation and adapter proxy service
---
Key: SLING-2938
URL: https://issues.apache.org/jira/browse/SLING-2938
Project: Sling
Issue Type: Bug
Components: Engine, Extensions
Affects Versions: Adapter 2.1.0
Reporter: Bertrand Delacretaz
Priority: Minor
Attachments: SLING-2938-api.patch, console.jpg
Following up on an idea that Olaf Otto presented at CQCon last week, I've
been working on an @AdapterMethod annotation that makes it easier to create
Sling adapters, as in
@Component
@Service
public class MyAdapters implements AdapterMethodProvider {
@AdapterMethod
public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
}
As this requires changes to the sling.api bundle, I'll commit to my
whiteboard first, for review
--
This message was sent by Atlassian JIRA
(v6.2#6252)
With Sling Models, do we still need the SLING-2938 Adapter methods?
Hi,
See SLING-2938 for the history and prototypes of simplified adapters,
example below.
Do we still need this with Sling Models?
I'd say both things are orthogonal, but I haven't worked with models
so far, so I'd like a second opinion - let's not introduce too many
different ways of doing the same thing.
-Bertrand
Example adapter, defined by the (controversial) AdapterProvider
interface, and @Adapter annotations:
public static class MultipleMethodsProvider implements AdapterProvider {
@Adapter
public Integer adaptToInt(TestAdaptable src) {
return new Integer((int)src.value);
}
@Adapter
public URL adaptToURL(TestAdaptable src) {
final String url = http://example.com/; + src.value;
try {
return new URL(url);
} catch(MalformedURLException mfu) {
throw new RuntimeException(Invalid URL + url, mfu);
}
}
}
[jira] [Created] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
Krystian Panek created SLING-3674:
-
Summary: Array of wrappers to primitives conversion in Sling Models
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.6
Reporter: Krystian Panek
Fix For: Sling Models Implementation 1.0.6
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
[
https://issues.apache.org/jira/browse/SLING-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Krystian Panek updated SLING-3674:
--
Attachment: ArrayPrimitivesModel.java
ResourceModelClassesTest.java
Array of wrappers to primitives conversion in Sling Models
--
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.6
Reporter: Krystian Panek
Labels: models
Fix For: Sling Models Implementation 1.0.6
Attachments: ArrayPrimitivesModel.java, ResourceModelClassesTest.java
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2187
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2187/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2187
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2187/
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Installer Integration Tests #2187
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.installer.it/2187/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2187
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2187/
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2187
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.discovery.impl/2187/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2187
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2187/
Jenkins build is still unstable: sling-trunk-1.6 #2187
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Commented] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
[
https://issues.apache.org/jira/browse/SLING-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033624#comment-14033624
]
Konrad Windszus commented on SLING-3674:
Please compare with SLING-2988. The ValueMap just does not support primitive
types and therefore the according injector does neither.
Array of wrappers to primitives conversion in Sling Models
--
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.6
Reporter: Krystian Panek
Labels: models
Fix For: Sling Models Implementation 1.0.6
Attachments: ArrayPrimitivesModel.java, ResourceModelClassesTest.java
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Resource Access Security Integration Tests #564
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/564/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #564
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/564/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Models Integration Tests #564
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.models.integration-tests/564/
Jenkins build is still unstable: sling-trunk-1.7 #564
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2188
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2188/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2188
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2188/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2188
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2188/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2188
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2188/
Jenkins build is still unstable: sling-trunk-1.6 #2188
See https://builds.apache.org/job/sling-trunk-1.6/changes
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Sample Integration Tests #564
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/564/
[jira] [Updated] (SLING-3651) Improve Conversion To Bundle and Content Projects
[ https://issues.apache.org/jira/browse/SLING-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-3651: --- Fix Version/s: Sling Eclipse IDE 1.0.0 Improve Conversion To Bundle and Content Projects - Key: SLING-3651 URL: https://issues.apache.org/jira/browse/SLING-3651 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.0 Reporter: Konrad Windszus Assignee: Stefan Egli Fix For: Sling Eclipse IDE 1.0.0 Currently the Convert To Bundle Project is always enabled and I can even add the bundle facet to a maven project which is of packaging content-package The Convert To Content Project... is only enabled under very specific conditions. Currently those conditions are neither described in https://cwiki.apache.org/confluence/display/SLING/Sling+IDE+tooling+User+Guide nor is there some warning/trace messages available. I would suggest the following: Always enable both conversion actions. Display a warning message with a very descriptive warning in case the conversion cannot be performed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033692#comment-14033692 ] Amit Gupta commented on SLING-3661: --- How does that supposed to work, FTP STORE, RESTART commands (http://www.w3.org/Protocols/rfc959/4_FileTransfer.html) dont support the spec https://cwiki.apache.org/confluence/display/SLING/Chunked+File+Upload+Support So, I am not sure if it can use the same. In case of FTP, it is not known in advance that it is a chunked upload, so temporary chunk content creation is not possible IMO ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Attachments: resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: With Sling Models, do we still need the SLING-2938 Adapter methods?
I agree that this is orthogonal to Sling Models. But I would say that
the importance of this new syntatic sugar is a bit lower now. Given
the lack of consensus and the (very valid) concern about how having
too many ways of doing similar things, I think we should put this on
hold (which I guess it was already).
Justin
On Tue, Jun 17, 2014 at 5:35 AM, Bertrand Delacretaz
bdelacre...@apache.org wrote:
Hi,
See SLING-2938 for the history and prototypes of simplified adapters,
example below.
Do we still need this with Sling Models?
I'd say both things are orthogonal, but I haven't worked with models
so far, so I'd like a second opinion - let's not introduce too many
different ways of doing the same thing.
-Bertrand
Example adapter, defined by the (controversial) AdapterProvider
interface, and @Adapter annotations:
public static class MultipleMethodsProvider implements AdapterProvider {
@Adapter
public Integer adaptToInt(TestAdaptable src) {
return new Integer((int)src.value);
}
@Adapter
public URL adaptToURL(TestAdaptable src) {
final String url = http://example.com/; + src.value;
try {
return new URL(url);
} catch(MalformedURLException mfu) {
throw new RuntimeException(Invalid URL + url, mfu);
}
}
}
[jira] [Updated] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
[
https://issues.apache.org/jira/browse/SLING-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-3674:
--
Affects Version/s: (was: Sling Models Implementation 1.0.6)
Sling Models Implementation 1.0.4
Array of wrappers to primitives conversion in Sling Models
--
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.4
Reporter: Krystian Panek
Labels: models
Fix For: Sling Models Implementation 1.0.6
Attachments: ArrayPrimitivesModel.java, ResourceModelClassesTest.java
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (SLING-3675) SecuredProviderResourceAccessSecurityTest times out on ci.apache.org
Bertrand Delacretaz created SLING-3675:
--
Summary: SecuredProviderResourceAccessSecurityTest times out on
ci.apache.org
Key: SLING-3675
URL: https://issues.apache.org/jira/browse/SLING-3675
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Bertrand Delacretaz
Priority: Minor
From
http://ci.apache.org/builders/sling-trunk/builds/388/steps/compile/logs/stdio
{code}
Running
org.apache.sling.resourceaccesssecurity.it.SecuredProviderResourceAccessSecurityTest
10 [main] INFO
org.apache.sling.resourceaccesssecurity.it.SecuredProviderResourceAccessSecurityTest
- Server base URL=http://localhost:48057
21 [main] INFO org.apache.sling.testing.tools.jarexec.JarExecutor - Executable
jar options: -p 48057
22 [main] INFO org.apache.sling.testing.tools.jarexec.JarExecutor - Executing
/usr/lib/jvm/java-6-sun-1.6.0.26/jre/bin/java -Xmx512m -jar
/home/buildslave3/slave3/sling-trunk/build/bundles/resourceaccesssecurity/it/target/dependency/org.apache.sling.launchpad-7-SNAPSHOT-standalone.jar
-p 48057
23 [main] INFO org.apache.sling.testing.tools.jarexec.JarExecutor - Setting up
ProcessDestroyer with waitOnShutdown=false
25 [main] INFO org.apache.sling.testing.tools.sling.TimeoutsProvider - Timeout
factor set to 4.0 from system property sling.testing.timeout.multiplier
26 [main] INFO
org.apache.sling.resourceaccesssecurity.it.SecuredProviderResourceAccessSecurityTest
- Will wait up to 1200 seconds for server to become ready
28 [main] INFO
org.apache.sling.resourceaccesssecurity.it.SecuredProviderResourceAccessSecurityTest
- Checking that GET requests return expected content (timeout=1200 seconds):
[/:script src=system/sling.js,
/.explorer.html:href=/libs/sling/explorer/css/explorer.css,
/sling-test/sling/sling-test.html:Sling client library tests]
17.06.2014 12:00:26.037 *INFO * [main] Setting sling.home=sling (default)
17.06.2014 12:00:26.039 *INFO * [main] Starting Apache Sling in
/home/buildslave3/slave3/sling-trunk/build/bundles/resourceaccesssecurity/it/sling
17.06.2014 12:00:26.059 *INFO * [main] Sling Extension Lib Home :
/home/buildslave3/slave3/sling-trunk/build/bundles/resourceaccesssecurity/it/sling/ext
17.06.2014 12:00:26.061 *INFO * [main] Checking launcher JAR in folder
/home/buildslave3/slave3/sling-trunk/build/bundles/resourceaccesssecurity/it/sling
17.06.2014 12:00:26.092 *INFO * [main] Installing new launcher:
jar:file:/home/buildslave3/slave3/sling-trunk/build/bundles/resourceaccesssecurity/it/target/dependency/org.apache.sling.launchpad-7-SNAPSHOT-standalone.jar!/resources/org.apache.sling.launchpad.base.jar,
4.4.0.2_5_1-SNAPSHOT, Last-Modified:Tue Jun 17 11:59:12 UTC 2014
(org.apache.sling.launchpad.base.jar.1403006426083)
17.06.2014 12:00:26.104 *INFO * [main] Loading launcher class
org.apache.sling.launchpad.base.app.MainDelegate from
org.apache.sling.launchpad.base.jar.1403006426083
17.06.2014 12:00:26.105 *INFO * [main] External Libs Home (ext) is null or does
not exists.
17.06.2014 12:00:26.131 *INFO * [main] Setting
sling.launchpad=/home/buildslave3/slave3/sling-trunk/build/bundles/resourceaccesssecurity/it/sling
17.06.2014 12:00:26.132 *INFO * [main] Setting org.osgi.service.http.port=48057
17.06.2014 12:00:26.133 *INFO * [main] Starting launcher ...
17.06.2014 12:00:26.134 *INFO * [main] HTTP server port: 48057
17.06.2014 12:00:27.865 *INFO* [FelixStartLevel]
org.apache.sling.commons.log.logback.internal.Activator LogbackManager
initialized at bundle startup
17.06.2014 12:00:28.738 *INFO * [main] Startup completed
command timed out: 1200 seconds without output, killing pid 1882
process killed by signal 9
program finished with exit code -1
elapsedTime=2796.783581
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Resolved] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
[
https://issues.apache.org/jira/browse/SLING-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-3674.
---
Resolution: Fixed
Assignee: Justin Edelson
Thanks for submitting these tests. Very helpful! (although in the future, it
would be better to submit a patch file when you are changing an existing test).
This is fixed in r1603159.
Array of wrappers to primitives conversion in Sling Models
--
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.4
Reporter: Krystian Panek
Assignee: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.6
Attachments: ArrayPrimitivesModel.java, ResourceModelClassesTest.java
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
[
https://issues.apache.org/jira/browse/SLING-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033769#comment-14033769
]
Konrad Windszus commented on SLING-3674:
[~justinedelson] Wouldn't it be good to use
https://commons.apache.org/proper/commons-lang/javadocs/api-2.5/org/apache/commons/lang/ClassUtils.html#primitivesToWrappers%28java.lang.Class[]%29?
Array of wrappers to primitives conversion in Sling Models
--
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.4
Reporter: Krystian Panek
Assignee: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.6
Attachments: ArrayPrimitivesModel.java, ResourceModelClassesTest.java
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Comment Edited] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
[
https://issues.apache.org/jira/browse/SLING-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033769#comment-14033769
]
Konrad Windszus edited comment on SLING-3674 at 6/17/14 1:19 PM:
-
[~justinedelson] Wouldn't it be good to use
https://commons.apache.org/proper/commons-lang/javadocs/api-2.5/org/apache/commons/lang/ClassUtils.html#primitivesToWrappers%28java.lang.Class[]%29
was (Author: kwin):
[~justinedelson] Wouldn't it be good to use
https://commons.apache.org/proper/commons-lang/javadocs/api-2.5/org/apache/commons/lang/ClassUtils.html#primitivesToWrappers%28java.lang.Class[]%29?
Array of wrappers to primitives conversion in Sling Models
--
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.4
Reporter: Krystian Panek
Assignee: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.6
Attachments: ArrayPrimitivesModel.java, ResourceModelClassesTest.java
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Build failed in Jenkins: sling-contrib-1.6 #1149
See https://builds.apache.org/job/sling-contrib-1.6/1149/changes Changes: [bdelacretaz] Improved fragment bundles handling [bdelacretaz] svn:ignore -- [...truncated 3078 lines...] [INFO] Copying jackrabbit-jcr-commons-2.7.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/jackrabbit-jcr-commons-2.7.2.jar [INFO] Copying slf4j-api-1.5.11.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/slf4j-api-1.5.11.jar [INFO] Copying jackrabbit-api-2.7.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/jackrabbit-api-2.7.2.jar [INFO] Copying commons-io-2.4.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/commons-io-2.4.jar [INFO] Copying jcr-2.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/jcr-2.0.jar [INFO] Copying junit-4.8.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/junit-4.8.2.jar [INFO] Copying org.apache.sling.replication-0.0.1-SNAPSHOT.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.sling.replication-0.0.1-SNAPSHOT.jar [INFO] Copying bndlib-1.50.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/bndlib-1.50.0.jar [INFO] Copying org.apache.felix.scr.annotations-1.9.8.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.felix.scr.annotations-1.9.8.jar [INFO] Copying org.apache.sling.api-2.5.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.sling.api-2.5.0.jar [INFO] Copying org.apache.sling.commons.osgi-2.2.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.sling.commons.osgi-2.2.0.jar [INFO] Copying org.apache.sling.hc.core-1.0.6.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.sling.hc.core-1.0.6.jar [INFO] Copying slf4j-simple-1.5.11.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/slf4j-simple-1.5.11.jar [INFO] Copying org.apache.sling.testing.tools-1.0.7-SNAPSHOT.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.sling.testing.tools-1.0.7-SNAPSHOT.jar [INFO] Copying httpclient-osgi-4.3.2.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/httpclient-osgi-4.3.2.jar [INFO] Copying org.apache.sling.launchpad-7-SNAPSHOT-standalone.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.sling.launchpad-7-SNAPSHOT-standalone.jar [INFO] Copying servlet-api-2.4.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/servlet-api-2.4.jar [INFO] Copying org.apache.jackrabbit.vault-3.0.0.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/org.apache.jackrabbit.vault-3.0.0.jar [INFO] Copying httpcore-osgi-4.3.1.jar to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/target/sling/additional-bundles/httpcore-osgi-4.3.1.jar [INFO] [INFO] --- build-helper-maven-plugin:1.8:reserve-network-port (reserve-server-port) @ org.apache.sling.replication.it --- [INFO] Reserved port 60276 for author.http.port [INFO] Reserved port 58487 for publish.http.port [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ org.apache.sling.replication.it --- [INFO] No sources to compile [INFO] [INFO] --- maven-scr-plugin:1.16.0:scr (generate-scr-scrdescriptor) @ org.apache.sling.replication.it --- [WARNING] Source tree does not exist. Ignoring https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/src/main/java [WARNING] Source tree does not exist. Ignoring https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/src/main/java [WARNING] Source tree does not exist. Ignoring https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/extensions/replication/it/src/main/java [INFO] [INFO] ---
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Replication Integration Tests #1149
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.replication.it/1149/ -- [INFO] [INFO] [INFO] Building Apache Sling Replication Integration Tests 0.0.1-SNAPSHOT [INFO] Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.testing.tools/1.0.7-SNAPSHOT/maven-metadata.xml Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.2/httpclient-osgi-4.3.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.2/httpclient-osgi-4.3.2.pom (8 KB at 796.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-cache/4.3.2/httpclient-cache-4.3.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-cache/4.3.2/httpclient-cache-4.3.2.pom (7 KB at 624.2 KB/sec) [WARNING] Failure to transfer org.apache.sling:org.apache.sling.launchpad:7-SNAPSHOT/maven-metadata.xml from http://repository.apache.org/snapshots was cached in the local repository, resolution will not be reattempted until the update interval of Nexus has elapsed or updates are forced. Original error: Could not transfer metadata org.apache.sling:org.apache.sling.launchpad:7-SNAPSHOT/maven-metadata.xml from/to Nexus (http://repository.apache.org/snapshots): Failed to transfer file: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad/7-SNAPSHOT/maven-metadata.xml. Return code is: 503 , ReasonPhrase:Service Temporarily Unavailable. Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.api/2.5.0/org.apache.sling.api-2.5.0.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.api/2.5.0/org.apache.sling.api-2.5.0.pom (6 KB at 32.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-api/2.7.2/jackrabbit-api-2.7.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-api/2.7.2/jackrabbit-api-2.7.2.pom (4 KB at 417.6 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-parent/2.7.2/jackrabbit-parent-2.7.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-parent/2.7.2/jackrabbit-parent-2.7.2.pom (30 KB at 2928.4 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/2.7.2/jackrabbit-jcr-commons-2.7.2.pom Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/2.7.2/jackrabbit-jcr-commons-2.7.2.pom (5 KB at 499.7 KB/sec) Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.2/httpclient-osgi-4.3.2.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-cache/4.3.2/httpclient-cache-4.3.2.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.api/2.5.0/org.apache.sling.api-2.5.0.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-api/2.7.2/jackrabbit-api-2.7.2.jar Downloading: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/2.7.2/jackrabbit-jcr-commons-2.7.2.jar Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-api/2.7.2/jackrabbit-api-2.7.2.jar (37 KB at 2837.9 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-cache/4.3.2/httpclient-cache-4.3.2.jar (147 KB at 6349.9 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/jackrabbit/jackrabbit-jcr-commons/2.7.2/jackrabbit-jcr-commons-2.7.2.jar (366 KB at 15904.8 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient-osgi/4.3.2/httpclient-osgi-4.3.2.jar (1297 KB at 24464.4 KB/sec) Downloaded: http://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.api/2.5.0/org.apache.sling.api-2.5.0.jar (83 KB at 454.8 KB/sec) [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.replication.it --- [INFO] Deleting https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.replication.it/ws/target [INFO] Deleting https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.replication.it/ws/ (includes = [sling/**], excludes = []) [INFO] [INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ org.apache.sling.replication.it --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.replication.it --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO]
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2189
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2189/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2189
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2189/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2189
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2189/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2189
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2189/
Jenkins build is still unstable: sling-trunk-1.6 #2189
See https://builds.apache.org/job/sling-trunk-1.6/changes
Build failed in Jenkins: sling-trunk-1.7 » Apache Sling Resource Access Security Integration Tests #565
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/565/ -- [INFO] [INFO] [INFO] Building Apache Sling Resource Access Security Integration Tests 0.0.1-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.resourceaccesssecurity.it --- [INFO] Deleting https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/ws/target [INFO] Deleting https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/ws/ (includes = [sling/**], excludes = []) [JENKINS] Archiving disabled
Build failed in Jenkins: sling-trunk-1.7 #565
See https://builds.apache.org/job/sling-trunk-1.7/565/changes Changes: [bdelacretaz] Improved fragment bundles handling [bdelacretaz] Sync to current snapshot [bdelacretaz] svn:ignore -- [...truncated 32783 lines...] [INFO] Sling Launchpad Standalone Archetype .. SUCCESS [21.509s] [INFO] Sling Launchpad Webapp Archetype .. SUCCESS [14.707s] [INFO] Sling Initial Content Archetype ... SUCCESS [11.090s] [INFO] Sling Servlet Archetype ... SUCCESS [11.362s] [INFO] Sling Bundle Archetype SUCCESS [9.462s] [INFO] Sling JCRInstall Bundle Archetype . SUCCESS [11.128s] [INFO] Sling Taglib Archetype SUCCESS [6.036s] [INFO] Apache Sling API .. SUCCESS [19.858s] [INFO] Apache Sling Resource Resolver SUCCESS [12.224s] [INFO] Apache Sling System Bundle Extension: Java Transaction API SUCCESS [8.564s] [INFO] Apache Sling System Bundle Extension: XML APIs SUCCESS [5.580s] [INFO] Apache Sling System Bundle Extension: Activation API SUCCESS [5.911s] [INFO] Apache Sling System Bundle Extension: WS APIs . SUCCESS [5.924s] [INFO] Apache Sling Dynamic Class Loader Support . SUCCESS [14.832s] [INFO] Apache Sling Commons Java Compiler SUCCESS [9.165s] [INFO] Apache Sling JSON Library . SUCCESS [10.999s] [INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [39.920s] [INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [6.015s] [INFO] Apache Sling MIME type mapping support SUCCESS [8.552s] [INFO] Apache Sling Commons OSGi support . SUCCESS [9.546s] [INFO] Apache Sling Scheduler Support SUCCESS [6.433s] [INFO] Apache Sling Testing Utilities SUCCESS [21.978s] [INFO] Apache Sling Thread Dumper SUCCESS [4.027s] [INFO] Apache Sling Thread Support ... SUCCESS [6.282s] [INFO] Apache Sling Authentication Service ... SUCCESS [9.179s] [INFO] Apache Sling OpenID Authentication SUCCESS [20.704s] [INFO] Apache Sling Form Based Authentication Handler SUCCESS [11.711s] [INFO] Apache Sling Authentication Selector .. SUCCESS [6.182s] [INFO] Apache Sling Engine Implementation SUCCESS [39.673s] [INFO] Apache Sling Repository API Bundle SUCCESS [6.577s] [INFO] Apache Sling JCR Base Bundle .. SUCCESS [8.916s] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [7.991s] [INFO] Apache Sling Initial Content Loader ... SUCCESS [11.858s] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [12.152s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [8.696s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [6.428s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [5.623s] [INFO] Apache Sling Object Content Mapping ... SUCCESS [8.832s] [INFO] Apache Sling JCR Resource Resolver SUCCESS [36.484s] [INFO] Apache Sling JCR Repository Registration .. SUCCESS [7.022s] [INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [9.071s] [INFO] Apache Sling DavEx Access to repositories . SUCCESS [9.077s] [INFO] Apache Sling JCR WebConsole Bundle SUCCESS [5.780s] [INFO] Apache Sling Oak Repository Server SUCCESS [9.129s] [INFO] Apache Sling SlingRepository Integration Tests SUCCESS [26.934s] [INFO] Apache Sling Servlet Resolver . SUCCESS [9.615s] [INFO] Apache Sling Default GET Servlets . SUCCESS [12.051s] [INFO] Apache Sling Default POST Servlets SUCCESS [11.752s] [INFO] Apache Sling Compat Servlets .. SUCCESS [5.825s] [INFO] Apache Sling Scripting Implementation API . SUCCESS [5.855s] [INFO] Apache Sling Scripting Core implementation SUCCESS [17.659s] [INFO] Apache Sling Scripting JavaScript Support . SUCCESS [18.644s] [INFO] Apache Sling Scripting JSP Support SUCCESS [12.217s] [INFO] Apache Sling JSP Tag Library .. SUCCESS [11.656s] [INFO] Apache Sling JSP Standard Tag Library . SUCCESS [6.437s] [INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [8.332s] [INFO] Apache Sling Bundle Resource Provider . SUCCESS [4.138s] [INFO] Apache Sling Discovery API SUCCESS [5.892s] [INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [2:30.237s] [INFO] Apache Sling Discovery Support Bundle . SUCCESS [5.745s] [INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [6.260s] [INFO] Apache Sling Event Support
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2190
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2190/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2190
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2190/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2190
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2190/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2190
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2190/
Jenkins build is still unstable: sling-trunk-1.6 #2190
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Commented] (SLING-3674) Array of wrappers to primitives conversion in Sling Models
[
https://issues.apache.org/jira/browse/SLING-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033862#comment-14033862
]
Justin Edelson commented on SLING-3674:
---
[~kwin] thanks for the pointer. That method seems to convert an array of
classes, which isn't so useful in this case, but there is a method in that
class which does the primitive - wrapper class mapping, so I pulled out the
duplicate code in r 1603178
Array of wrappers to primitives conversion in Sling Models
--
Key: SLING-3674
URL: https://issues.apache.org/jira/browse/SLING-3674
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.4
Reporter: Krystian Panek
Assignee: Justin Edelson
Labels: models
Fix For: Sling Models Implementation 1.0.6
Attachments: ArrayPrimitivesModel.java, ResourceModelClassesTest.java
Problem is related with: https://issues.apache.org/jira/browse/SLING-3547
Suppose that I have:
{quote}
@Inject
private int[] scores;
@Inject
private Integer[] scores;
{quote}
For first declaration injection does not work, because in my environment
ValueMap contains array of wrapped integers and type cast to array of
primitives cannot be done. I noticed an exception:
{quote}
27 [main] ERROR org.apache.sling.models.impl.ModelAdapterFactory - unable to
create object
java.lang.ClassCastException: [I cannot be cast to [Ljava.lang.Object;
at
org.apache.sling.api.wrappers.ValueMapDecorator.convertToArray(ValueMapDecorator.java:100)
{quote}
Second declaration seems to work but how to apply default value for it?
According to Sling Models documentation, example with default value for array
of integers currently it is not possible to get it working. Same error as for
first declaration.
I wrote unit test for it. I hope, useful for reproducing problem, see
attachments.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #566
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/566/
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Sample Integration Tests #566
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/566/
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Models Integration Tests #566
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.models.integration-tests/566/
Jenkins build is unstable: sling-trunk-1.7 » Apache Sling Resource Access Security Integration Tests #566
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/566/
Jenkins build is unstable: sling-trunk-1.7 #566
See https://builds.apache.org/job/sling-trunk-1.7/566/changes
[jira] [Updated] (SLING-3516) Sling Models Resource Child List Injector
[
https://issues.apache.org/jira/browse/SLING-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson updated SLING-3516:
--
Fix Version/s: Sling Models Implementation 1.0.6
Sling Models Resource Child List Injector
-
Key: SLING-3516
URL: https://issues.apache.org/jira/browse/SLING-3516
Project: Sling
Issue Type: New Feature
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.2
Reporter: Igor Sechyn
Assignee: Justin Edelson
Priority: Minor
Fix For: Sling Models Implementation 1.0.6
Attachments: ChildResourceInjectorPatch.diff
Hi All,
We have decided to use the sling models to process some hierarchical data in
our project and are facing the following issue right now.
Our content structure looks as follows:
{code}
+- dealer
|
+- addresses
|
+ -address1
|
+- address2
{code}
Dealer and address nodes have attributes, that can be injected through the
ValueMapInjector, so everything works fine here. Our goal however is also to
inject the List of AddressModel objects into the DealerModel object,
something like this:
{code}
@Inject
ListAddressModel addresses
{code}
The desired behavior would be:
- the injector resolves addresses as a child resource of the adaptable object
- iterates over the children of this resource (in this case „addresses)
- adapts each child to the actual type argument of the parameterized list type
- returns the list of adapted model objects
I have tried to play around with @Named but could not get it to work. The
only way of making it work, was to write a custom injector, which worked out
pretty fine.
But I was still wondering, if there might be an OOTB functionality, which can
be used for this use case
Cheers, Igor.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2191
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2191/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2191
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2191/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2191
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2191/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2191
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2191/
Jenkins build became unstable: sling-trunk-1.6 » Apache Sling SLF4J Implementation (Logback) #2191
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.commons.log/2191/
Jenkins build is still unstable: sling-trunk-1.6 #2191
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Assigned] (SLING-3516) Sling Models Resource Child List Injector
[
https://issues.apache.org/jira/browse/SLING-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson reassigned SLING-3516:
-
Assignee: Justin Edelson
Sling Models Resource Child List Injector
-
Key: SLING-3516
URL: https://issues.apache.org/jira/browse/SLING-3516
Project: Sling
Issue Type: New Feature
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.2
Reporter: Igor Sechyn
Assignee: Justin Edelson
Priority: Minor
Fix For: Sling Models Implementation 1.0.6
Attachments: ChildResourceInjectorPatch.diff
Hi All,
We have decided to use the sling models to process some hierarchical data in
our project and are facing the following issue right now.
Our content structure looks as follows:
{code}
+- dealer
|
+- addresses
|
+ -address1
|
+- address2
{code}
Dealer and address nodes have attributes, that can be injected through the
ValueMapInjector, so everything works fine here. Our goal however is also to
inject the List of AddressModel objects into the DealerModel object,
something like this:
{code}
@Inject
ListAddressModel addresses
{code}
The desired behavior would be:
- the injector resolves addresses as a child resource of the adaptable object
- iterates over the children of this resource (in this case „addresses)
- adapts each child to the actual type argument of the parameterized list type
- returns the list of adapted model objects
I have tried to play around with @Named but could not get it to work. The
only way of making it work, was to write a custom injector, which worked out
pretty fine.
But I was still wondering, if there might be an OOTB functionality, which can
be used for this use case
Cheers, Igor.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Resource Access Security Integration Tests #567
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/567/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Sample Integration Tests #567
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.testing.samples.integrationtests/567/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #567
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.launchpad.testing/567/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Models Integration Tests #567
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.models.integration-tests/567/
Jenkins build is still unstable: sling-trunk-1.7 #567
See https://builds.apache.org/job/sling-trunk-1.7/changes
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2192
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2192/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2192
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2192/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling SLF4J Implementation (Logback) #2192
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.commons.log/2192/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2192
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2192/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2192
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2192/
Jenkins build is still unstable: sling-trunk-1.6 #2192
See https://builds.apache.org/job/sling-trunk-1.6/changes
[jira] [Updated] (SLING-3624) Add SlingHealthCheck annotation
[
https://issues.apache.org/jira/browse/SLING-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bjoern Weide updated SLING-3624:
Attachment: (was: slinghealthcheck_annotation.txt)
Add SlingHealthCheck annotation
---
Key: SLING-3624
URL: https://issues.apache.org/jira/browse/SLING-3624
Project: Sling
Issue Type: Improvement
Components: Health Check
Affects Versions: Health Check Core 1.1.0
Reporter: Bjoern Weide
Priority: Minor
Fix For: Health Check Core 1.1.2
Add a SlingHealthCheck annotation (similar to SlingServlet). The metatype
property should set to true per default since its probably common to
configure healthchecks. Usage examples:
{code:title=Examples|borderStyle=solid}
@SlingHealthCheck(name = BundlesStartedCheck.HC_NAME, label = Apache Sling
Health Check - + BundlesStartedCheck.HC_NAME, description = Checks whether
all bundles are started., tags = osgi)
@SlingHealthCheck(name = DiskSpaceCheck.HC_NAME, label = Apache Sling Health
Check - + DiskSpaceCheck.HC_NAME,
description = Checks whether enough disk space is available., tags
= resources, configurationFactory = true,
configurationPolicy = ConfigurationPolicy.REQUIRE)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SLING-3624) Add SlingHealthCheck annotation
[
https://issues.apache.org/jira/browse/SLING-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bjoern Weide updated SLING-3624:
Attachment: slinghealthcheck_annotation.txt
[~henzlerg] I just added an updated version including the mbean name.
[~bdelacretaz] OK I will have a look!
Add SlingHealthCheck annotation
---
Key: SLING-3624
URL: https://issues.apache.org/jira/browse/SLING-3624
Project: Sling
Issue Type: Improvement
Components: Health Check
Affects Versions: Health Check Core 1.1.0
Reporter: Bjoern Weide
Priority: Minor
Fix For: Health Check Core 1.1.2
Attachments: slinghealthcheck_annotation.txt
Add a SlingHealthCheck annotation (similar to SlingServlet). The metatype
property should set to true per default since its probably common to
configure healthchecks. Usage examples:
{code:title=Examples|borderStyle=solid}
@SlingHealthCheck(name = BundlesStartedCheck.HC_NAME, label = Apache Sling
Health Check - + BundlesStartedCheck.HC_NAME, description = Checks whether
all bundles are started., tags = osgi)
@SlingHealthCheck(name = DiskSpaceCheck.HC_NAME, label = Apache Sling Health
Check - + DiskSpaceCheck.HC_NAME,
description = Checks whether enough disk space is available., tags
= resources, configurationFactory = true,
configurationPolicy = ConfigurationPolicy.REQUIRE)
{code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (SLING-3661) ftp server should support resumable file uploads
[ https://issues.apache.org/jira/browse/SLING-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14034197#comment-14034197 ] Alexander Klimetschek commented on SLING-3661: -- Hmm, ok, but the sling chunked file support should also be aware of suddenly stopping/disconnected requests. If you expect them, you have to write into a temporary content structure that you can later update. ftp server should support resumable file uploads Key: SLING-3661 URL: https://issues.apache.org/jira/browse/SLING-3661 Project: Sling Issue Type: Improvement Components: Extensions Reporter: Amrit Verma Attachments: resumeUploadDiff.txt The ftp server should support resuming file uploads. Steps: 1. Connect to ftp server and start file upload. 2. Terminate file upload in the middle. 3. Try resuming the upload. Issue: The server sends 551 error code. It only supports overwriting the existing file. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: [featureflags] Readding sling:features to resourceResolver
I still think an utility method is the best/easiest approach. What is the real problem with doing that? Adding feature flag to the resource resolver requires to check a property for each and every resource access - and I don't see a good reason why this burden should be added for a use case which can be easily solved with an utility method. Usually feature flags are exactly implemented in this way - you add code with an if statement, checking whether the flag is enabled and then do something depending an that result. So why not starting with utlity code and only if that really becomes a problem (and again I don't see why it should), we can talk about changing things. We failed with adding this general mechanism and so far nothing has changed and we would run in the same problems again. Carsten 2014-06-16 10:01 GMT-04:00 Dominik Süß dominik.su...@gmail.com: Hi Bertrand, I'm not really about altering resource rendering but enable disable resources for rendering, so I probably wouldn't decorate the scripts and servlets but the resources that define those resourceTypes. This is what we all have done a lot when hiding away frontend for endusers (at least I know nobody who didn't have to do that once in a while) via ACLs wherever the UI was composed from resources. I get the case where you would like to alter the Script/Servlet that handles a resourceType but as you mentioned this comes with quite some constraints and locations that would require some changes to work. To get this working we would definitively need some script metadata which could also be added as annotation to be able to distinct on servletresolution. I do not like the term magic feature flags since it implies there would happen something out of control for a developert. Declarative feature flags is matching what I'm thinking of - declaring something being part of a feature and having a unified behavior of the system to handle these for the specific cases just as we have a declarative way of defining selectorbased filtering for scripts and/or servlets (declaration syntax is different but declaration and behavior of the system is always the same. IMHO we should go for the simplest mechanism first - which is the endresource being declared being part of a specific feature and carefully checking the lower level mechanisms for alter resource rendering. It still is better to have an easy and cheap solution that covers the easy cases but requires some engineering where more complex scenarios come into the game then forcing people to write custom code everywhere even for such common cases like disabling a Tab in a ui. Best regards Dominik On Mon, Jun 16, 2014 at 3:13 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi Dominik, On Mon, Jun 16, 2014 at 1:55 PM, Dominik Süß dominik.su...@gmail.com wrote: ...I fear it is not as easy since this mandates rendering engines to be able to perform that filtering (in other words - to be able to skip rendering based on the feature flag)... so IIUC you're looking at the alter resource rendering use case of [1] ? Note that even if the resource resolver hides rendering resources like scripts, I suspect you'll get in trouble as rendering scripts are cached. That's a good example of why I pushed for the SLING-3483 removal. ...This might not be that much work if applying features in the first place, but just think of a solution like AEM where a huge codebase should be featurized (e.g. a part should be deactivable due to licencing or some other criteria)... I sense a slightly more complex use case than [1] here...not sure if in-content feature flags are the right way to implement this. ... If I got the idea of featureflags right they should be at least invasive in code as possible, keeping the risk low that a deactivated feature by accident influences the rest of the system at all aka magic feature flags ;-) I agree that this looks nice, but as mentioned before I'm wary of multiple weird side effects like the caching thing mentioned above. We've seen those coming before SLING-3483, and so far no one has been able to reassure me that we're not opening a can of worms. ...From a consumers perspective I would like to be able to declare resources to be part of a feature (whitelisting) and probably to be removed for a feature (blacklisting - although this requires a logic resolving potential theoretical conflicts with a whitelist) by adding attributes... Assuming you want to work like this for scripts, how to you handle rendering servlets? -Bertrand [1] https://cwiki.apache.org/confluence/display/SLING/Sling+Feature+Flags+support P.S. no emotions about this on my side...I'm just not convinced so far, and wary of possible side effects. Best way to convince me is probably a prototype with sufficiently good tests that prove me wrong. -- Carsten
[jira] [Resolved] (SLING-3516) Sling Models Resource Child List Injector
[
https://issues.apache.org/jira/browse/SLING-3516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Edelson resolved SLING-3516.
---
Resolution: Fixed
I have committed a modified version of the patch in r1603277. The most
significant change is that the call to resource.adaptTo() for a list is now
done in the ModelAdapterFactory rather than in the ChildResourceInjector. The
reason for this is that this is where the existing adaptTo() call is made, so
it seemed to make more sense to co-locate them.
Thanks Igor!
Sling Models Resource Child List Injector
-
Key: SLING-3516
URL: https://issues.apache.org/jira/browse/SLING-3516
Project: Sling
Issue Type: New Feature
Components: Extensions
Affects Versions: Sling Models Implementation 1.0.2
Reporter: Igor Sechyn
Assignee: Justin Edelson
Priority: Minor
Fix For: Sling Models Implementation 1.0.6
Attachments: ChildResourceInjectorPatch.diff
Hi All,
We have decided to use the sling models to process some hierarchical data in
our project and are facing the following issue right now.
Our content structure looks as follows:
{code}
+- dealer
|
+- addresses
|
+ -address1
|
+- address2
{code}
Dealer and address nodes have attributes, that can be injected through the
ValueMapInjector, so everything works fine here. Our goal however is also to
inject the List of AddressModel objects into the DealerModel object,
something like this:
{code}
@Inject
ListAddressModel addresses
{code}
The desired behavior would be:
- the injector resolves addresses as a child resource of the adaptable object
- iterates over the children of this resource (in this case „addresses)
- adapts each child to the actual type argument of the parameterized list type
- returns the list of adapted model objects
I have tried to play around with @Named but could not get it to work. The
only way of making it work, was to write a custom injector, which worked out
pretty fine.
But I was still wondering, if there might be an OOTB functionality, which can
be used for this use case
Cheers, Igor.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Models Integration Tests #2193
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.models.integration-tests/2193/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Sample Integration Tests #2193
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.testing.samples.integrationtests/2193/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2193
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/2193/
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling SLF4J Implementation (Logback) #2193
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.commons.log/2193/
Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Resource Access Security Integration Tests #2193
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/2193/
Jenkins build is still unstable: sling-trunk-1.6 #2193
See https://builds.apache.org/job/sling-trunk-1.6/changes
Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Installer Integration Tests #568
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.installer.it/568/
Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Resource Access Security Integration Tests #568
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.resourceaccesssecurity.it/568/
