RE: Launchpad 7 Release?

[Mike Müller]

> -Original Message-
> From: Carsten Ziegeler [mailto:cziege...@apache.org]
> Sent: Wednesday, July 23, 2014 9:22 AM
> To: dev@sling.apache.org
> Subject: Re: Launchpad 7 Release?
> 
> I've updated the bundle list - it was pretty current. For three bundles we
> still have open issues before we can release:
> 
> Commons JSON
> https://issues.apache.org/jira/browse/SLING/fixforversion/12315999
> 
> Explorer
> https://issues.apache.org/jira/browse/SLING/fixforversion/12316190
> 
> JCR Jackrabbit Server
> https://issues.apache.org/jira/browse/SLING/fixforversion/12324840

I would like to include a 1.0.0 release of resourceaccesssecurity in Sling 7.
I think it's pretty mature, documentation is up to date [1] and I recently
Added a bunch of various tests. 

WDYT?

Best regards
mike

FYI, frequent buildbot issues

[Bertrand Delacretaz]

Hi,

We've been having frequent issues with the
http://ci.apache.org/builders/sling-trunk build lately, which are
unrelated to our code, it's the build environment that's failing.

I have created https://issues.apache.org/jira/browse/INFRA-8098 for now.

(but don't take it as an excuse to ignore tests ;-)

-Bertrand

Jenkins build is unstable: sling-trunk-1.6 #2329

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2329

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.7 #706

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #706

[Apache Jenkins Server]

See 

Build failed in Jenkins: sling-contrib-1.6 » Apache Sling Launchpad Karaf - Integration Tests #1183

[Apache Jenkins Server]

See 


--
[INFO] 
[INFO] 
[INFO] Building Apache Sling Launchpad Karaf - Integration Tests 0.1.1-SNAPSHOT
[INFO] 
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/apache-karaf/3.0.1/apache-karaf-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/apache-karaf/3.0.1/apache-karaf-3.0.1.pom
 (8 KB at 76.4 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/assemblies/assemblies/3.0.1/assemblies-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/assemblies/assemblies/3.0.1/assemblies-3.0.1.pom
 (2 KB at 31.4 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/framework/3.0.1/framework-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/framework/3.0.1/framework-3.0.1.pom
 (22 KB at 274.9 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/assemblies/features/features/3.0.1/features-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/assemblies/features/features/3.0.1/features-3.0.1.pom
 (2 KB at 31.2 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/org.apache.karaf.main/3.0.1/org.apache.karaf.main-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/org.apache.karaf.main/3.0.1/org.apache.karaf.main-3.0.1.pom
 (7 KB at 113.9 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/org.apache.karaf.util/3.0.1/org.apache.karaf.util-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/org.apache.karaf.util/3.0.1/org.apache.karaf.util-3.0.1.pom
 (3 KB at 37.9 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/org.apache.karaf.exception/3.0.1/org.apache.karaf.exception-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/org.apache.karaf.exception/3.0.1/org.apache.karaf.exception-3.0.1.pom
 (2 KB at 28.9 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/org.apache.karaf.features.command/3.0.1/org.apache.karaf.features.command-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/org.apache.karaf.features.command/3.0.1/org.apache.karaf.features.command-3.0.1.pom
 (5 KB at 73.8 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/bundle/org.apache.karaf.bundle.command/3.0.1/org.apache.karaf.bundle.command-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/bundle/org.apache.karaf.bundle.command/3.0.1/org.apache.karaf.bundle.command-3.0.1.pom
 (5 KB at 73.2 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/bundle/bundle/3.0.1/bundle-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/bundle/bundle/3.0.1/bundle-3.0.1.pom
 (2 KB at 29.7 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/shell/org.apache.karaf.shell.table/3.0.1/org.apache.karaf.shell.table-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/shell/org.apache.karaf.shell.table/3.0.1/org.apache.karaf.shell.table-3.0.1.pom
 (3 KB at 45.5 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/bundle/org.apache.karaf.bundle.core/3.0.1/org.apache.karaf.bundle.core-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/bundle/org.apache.karaf.bundle.core/3.0.1/org.apache.karaf.bundle.core-3.0.1.pom
 (5 KB at 78.9 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/shell/org.apache.karaf.shell.help/3.0.1/org.apache.karaf.shell.help-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/shell/org.apache.karaf.shell.help/3.0.1/org.apache.karaf.shell.help-3.0.1.pom
 (5 KB at 84.7 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/org.apache.karaf.system.core/3.0.1/org.apache.karaf.system.core-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/org.apache.karaf.system.core/3.0.1/org.apache.karaf.system.core-3.0.1.pom
 (4 KB at 67.1 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/system/3.0.1/system-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/system/3.0.1/system-3.0.1.pom
 (2 KB at 29.0 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/org.apache.karaf.system.command/3.0.1/org.apache.karaf.system.command-3.0.1.pom
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/org.apache.karaf.system.comm

Build failed in Jenkins: sling-contrib-1.6 #1183

[Apache Jenkins Server]

See 

Changes:

[bdelacretaz] SLING-3667 Add SlingQuery library, donated by Tomek Rękawek, 
thanks!

--
[...truncated 6613 lines...]
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/shell/org.apache.karaf.shell.commands/3.0.1/org.apache.karaf.shell.commands-3.0.1.jar
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/org.apache.karaf.system.core/3.0.1/org.apache.karaf.system.core-3.0.1.jar
 (38 KB at 712.2 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/aries/blueprint/org.apache.aries.blueprint.core/1.4.0/org.apache.aries.blueprint.core-1.4.0.jar
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/system/org.apache.karaf.system.command/3.0.1/org.apache.karaf.system.command-3.0.1.jar
 (20 KB at 352.6 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/region/org.apache.karaf.region.core/3.0.1/org.apache.karaf.region.core-3.0.1.jar
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/region/org.apache.karaf.region.core/3.0.1/org.apache.karaf.region.core-3.0.1.jar
 (9 KB at 145.4 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/standard/3.0.1/standard-3.0.1-features.xml
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/shell/org.apache.karaf.shell.commands/3.0.1/org.apache.karaf.shell.commands-3.0.1.jar
 (103 KB at 802.7 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/spring/3.0.1/spring-3.0.1-features.xml
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/standard/3.0.1/standard-3.0.1-features.xml
 (13 KB at 226.8 KB/sec)
Downloading: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/enterprise/3.0.1/enterprise-3.0.1-features.xml
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/aries/blueprint/org.apache.aries.blueprint.core/1.4.0/org.apache.aries.blueprint.core-1.4.0.jar
 (394 KB at 2659.9 KB/sec)
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/spring/3.0.1/spring-3.0.1-features.xml
 (19 KB at 334.3 KB/sec)
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/enterprise/3.0.1/enterprise-3.0.1-features.xml
 (16 KB at 279.6 KB/sec)
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/features/framework/3.0.1/framework-3.0.1.kar
 (12722 KB at 11714.3 KB/sec)
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/karaf/apache-karaf/3.0.1/apache-karaf-3.0.1.tar.gz
 (15195 KB at 12942.7 KB/sec)
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run 
(set-bundle-required-execution-environment) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] Executing tasks

main:
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (default) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (check-memory-task) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] Executing tasks

main:
 [echo]  WARNING (SLING-443/SLING-1782) 
**
 [echo] On most platforms, you'll get OutOfMemoryErrors when building 
unless you set
 [echo] on 32bit platforms: MAVEN_OPTS="-Xmx256M -XX:MaxPermSize=256M", see 
SLING-443
 [echo] on 64bit platforms: MAVEN_OPTS="-Xmx512M -XX:MaxPermSize=512M", see 
SLING-1782
 [echo] 
**
[INFO] Executed tasks
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
org.apache.sling.launchpad.karaf-integration-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

Jenkins build became unstable: sling-contrib-1.6 » Apache Sling Replication Integration Tests #1183

[Apache Jenkins Server]

See 

[jira] [Resolved] (SLING-3667) Integrate SlingQuery library

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-3667.


Resolution: Fixed

Habemus Sling Query!

http://svn.apache.org/repos/asf/sling/trunk/contrib/extensions/sling-query/

Thanks again for this donation, I suspect it's going to be quite popular.

> Integrate SlingQuery library
> 
>
> Key: SLING-3667
> URL: https://issues.apache.org/jira/browse/SLING-3667
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Reporter: Tomek Rękawek
>Assignee: Bertrand Delacretaz
> Attachments: sling-query.zip
>
>
> [SlingQuery|https://github.com/Cognifide/Sling-Query] is a Sling resource 
> tree traversal tool inspired by the jQuery. [It was 
> presented|http://cognifide.github.io/Sling-Query/circuit2014/] on the recent 
> CIRCUIT 2014 and got warm response from the community. I think it should be 
> integrated with the Sling codebase as an extension.
> Library code was aligned to the Sling standards in the 
> [sling-extension|https://github.com/Cognifide/Sling-Query/tree/sling-extension]
>  branch on Github.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (SLING-3667) Integrate SlingQuery library

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074352#comment-14074352
 ] 

Bertrand Delacretaz commented on SLING-3667:


The incubator PMC vote has passed by lazy consensus:
Message-ID: 
on general@incubator.a.o

I'll proceed with the code integration.

> Integrate SlingQuery library
> 
>
> Key: SLING-3667
> URL: https://issues.apache.org/jira/browse/SLING-3667
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Reporter: Tomek Rękawek
>Assignee: Bertrand Delacretaz
> Attachments: sling-query.zip
>
>
> [SlingQuery|https://github.com/Cognifide/Sling-Query] is a Sling resource 
> tree traversal tool inspired by the jQuery. [It was 
> presented|http://cognifide.github.io/Sling-Query/circuit2014/] on the recent 
> CIRCUIT 2014 and got warm response from the community. I think it should be 
> integrated with the Sling codebase as an extension.
> Library code was aligned to the Sling standards in the 
> [sling-extension|https://github.com/Cognifide/Sling-Query/tree/sling-extension]
>  branch on Github.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Resolved] (SLING-3713) VanityPathTest testRedirectOnPathWithExtension fails: Expecting temporary redirect expected:<302> but was:<404>

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso resolved SLING-3713.
--

Resolution: Fixed

fixed in rev. 1613407 and r1613415

> VanityPathTest testRedirectOnPathWithExtension fails:  Expecting temporary 
> redirect expected:<302> but was:<404>
> 
>
> Key: SLING-3713
> URL: https://issues.apache.org/jira/browse/SLING-3713
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.1.2
>
> Attachments: SLING-3713-patch.txt
>
>
> This failure was first seen in 
> [https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/612|sling-trunk-1.7
>  build 612] - rev 1606740 .
> {code}Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.142 
> sec <<< FAILURE! - in 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
> testRedirectOnPathWithExtension(org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest)
>   Time elapsed: 0.546 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Expecting temporary redirect 
> expected:<302> but was:<404>
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.Assert.assertEquals(Assert.java:234)
>   at junit.framework.TestCase.assertEquals(TestCase.java:401)
>   at 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.testRedirectOnPathWithExtension(VanityPathTest.java:186){code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Resolved] (SLING-3703) Dependency on org.apache.sling.commons.osgi in version 2.2

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-3703.
---

Resolution: Fixed
  Assignee: Justin Edelson

fixed in r1613413

> Dependency on org.apache.sling.commons.osgi in version 2.2
> --
>
> Key: SLING-3703
> URL: https://issues.apache.org/jira/browse/SLING-3703
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Models Implementation 1.0.4, Sling Models 
> Implementation 1.0.6
>Reporter: Konrad Windszus
>Assignee: Justin Edelson
>Priority: Minor
> Fix For: Sling Models Implementation 1.0.8
>
>
> Currently it is not possible to start the bundle org.apache.sling.models.impl 
> in version 5.5 of Adobe CQ 5.5 due to the dependency on 
> org.apache.sling.commons.osgi in version 2.2. Can you lower the dependency to 
> version 2.1? To me it doesn't look that you actually rely on functionality 
> being introduced with version 2.2 
> (https://issues.apache.org/jira/browse/SLING/fixforversion/12317581).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3703) Dependency on org.apache.sling.commons.osgi in version 2.2

[Justin Edelson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson updated SLING-3703:
--

Fix Version/s: Sling Models Implementation 1.0.8

> Dependency on org.apache.sling.commons.osgi in version 2.2
> --
>
> Key: SLING-3703
> URL: https://issues.apache.org/jira/browse/SLING-3703
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Sling Models Implementation 1.0.4, Sling Models 
> Implementation 1.0.6
>Reporter: Konrad Windszus
>Priority: Minor
> Fix For: Sling Models Implementation 1.0.8
>
>
> Currently it is not possible to start the bundle org.apache.sling.models.impl 
> in version 5.5 of Adobe CQ 5.5 due to the dependency on 
> org.apache.sling.commons.osgi in version 2.2. Can you lower the dependency to 
> version 2.1? To me it doesn't look that you actually rely on functionality 
> being introduced with version 2.2 
> (https://issues.apache.org/jira/browse/SLING/fixforversion/12317581).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Pax Exam Utilities #2328

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2328

[Apache Jenkins Server]

See 

[jira] [Commented] (SLING-3713) VanityPathTest testRedirectOnPathWithExtension fails: Expecting temporary redirect expected:<302> but was:<404>

[Antonio Sanso (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074330#comment-14074330
 ] 

Antonio Sanso commented on SLING-3713:
--

bq. patch looks good to me, 

thanks

bq.  arent there constants for "sling:vanityPath" and "sling:alias" ?

I will give a look. if not i will create one and I will change the code 
accordingly.. :)

> VanityPathTest testRedirectOnPathWithExtension fails:  Expecting temporary 
> redirect expected:<302> but was:<404>
> 
>
> Key: SLING-3713
> URL: https://issues.apache.org/jira/browse/SLING-3713
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.1.2
>
> Attachments: SLING-3713-patch.txt
>
>
> This failure was first seen in 
> [https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/612|sling-trunk-1.7
>  build 612] - rev 1606740 .
> {code}Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.142 
> sec <<< FAILURE! - in 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
> testRedirectOnPathWithExtension(org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest)
>   Time elapsed: 0.546 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Expecting temporary redirect 
> expected:<302> but was:<404>
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.Assert.assertEquals(Assert.java:234)
>   at junit.framework.TestCase.assertEquals(TestCase.java:401)
>   at 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.testRedirectOnPathWithExtension(VanityPathTest.java:186){code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (SLING-3713) VanityPathTest testRedirectOnPathWithExtension fails: Expecting temporary redirect expected:<302> but was:<404>

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074326#comment-14074326
 ] 

Carsten Ziegeler commented on SLING-3713:
-

[~asanso] Patch looks good to me, except :) arent there constants for 
"sling:vanityPath" and "sling:alias" ?

> VanityPathTest testRedirectOnPathWithExtension fails:  Expecting temporary 
> redirect expected:<302> but was:<404>
> 
>
> Key: SLING-3713
> URL: https://issues.apache.org/jira/browse/SLING-3713
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.1.2
>
> Attachments: SLING-3713-patch.txt
>
>
> This failure was first seen in 
> [https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/612|sling-trunk-1.7
>  build 612] - rev 1606740 .
> {code}Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.142 
> sec <<< FAILURE! - in 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
> testRedirectOnPathWithExtension(org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest)
>   Time elapsed: 0.546 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Expecting temporary redirect 
> expected:<302> but was:<404>
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.Assert.assertEquals(Assert.java:234)
>   at junit.framework.TestCase.assertEquals(TestCase.java:401)
>   at 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.testRedirectOnPathWithExtension(VanityPathTest.java:186){code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (SLING-3791) Improve MapEntries to leverage changes in SLING-2529

[Antonio Sanso (JIRA)]

Antonio Sanso created SLING-3791:


 Summary: Improve MapEntries to leverage changes in SLING-2529
 Key: SLING-3791
 URL: https://issues.apache.org/jira/browse/SLING-3791
 Project: Sling
  Issue Type: Improvement
  Components: ResourceResolver
Reporter: Antonio Sanso
Assignee: Antonio Sanso


Once SLING-2529 is resolved the MapEntrires code can be improved to leverage 
the updated session.move event handling



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (SLING-3713) VanityPathTest testRedirectOnPathWithExtension fails: Expecting temporary redirect expected:<302> but was:<404>

[Antonio Sanso (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074319#comment-14074319
 ] 

Antonio Sanso commented on SLING-3713:
--

I have opened SLING-3791

> VanityPathTest testRedirectOnPathWithExtension fails:  Expecting temporary 
> redirect expected:<302> but was:<404>
> 
>
> Key: SLING-3713
> URL: https://issues.apache.org/jira/browse/SLING-3713
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.1.2
>
> Attachments: SLING-3713-patch.txt
>
>
> This failure was first seen in 
> [https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/612|sling-trunk-1.7
>  build 612] - rev 1606740 .
> {code}Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.142 
> sec <<< FAILURE! - in 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
> testRedirectOnPathWithExtension(org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest)
>   Time elapsed: 0.546 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Expecting temporary redirect 
> expected:<302> but was:<404>
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.Assert.assertEquals(Assert.java:234)
>   at junit.framework.TestCase.assertEquals(TestCase.java:401)
>   at 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.testRedirectOnPathWithExtension(VanityPathTest.java:186){code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (SLING-3713) VanityPathTest testRedirectOnPathWithExtension fails: Expecting temporary redirect expected:<302> but was:<404>

[Antonio Sanso (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074317#comment-14074317
 ] 

Antonio Sanso commented on SLING-3713:
--

the issue here is that session.move() doesn't carry resourceAddedAttributes 
properties. This is tracked in SLING-2529.

I have attached here a proposed patch I would like to apply. Once SLING-2529 is 
solved I can improved this part of the code (I am going to open a new issue 
that is blocked by SLING-2529 ).

Until then I would like to apply this patch [~cziegeler] [~justinedelson] might 
ypu please give a look at the patch? :)


> VanityPathTest testRedirectOnPathWithExtension fails:  Expecting temporary 
> redirect expected:<302> but was:<404>
> 
>
> Key: SLING-3713
> URL: https://issues.apache.org/jira/browse/SLING-3713
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.1.2
>
> Attachments: SLING-3713-patch.txt
>
>
> This failure was first seen in 
> [https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/612|sling-trunk-1.7
>  build 612] - rev 1606740 .
> {code}Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.142 
> sec <<< FAILURE! - in 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
> testRedirectOnPathWithExtension(org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest)
>   Time elapsed: 0.546 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Expecting temporary redirect 
> expected:<302> but was:<404>
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.Assert.assertEquals(Assert.java:234)
>   at junit.framework.TestCase.assertEquals(TestCase.java:401)
>   at 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.testRedirectOnPathWithExtension(VanityPathTest.java:186){code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3713) VanityPathTest testRedirectOnPathWithExtension fails: Expecting temporary redirect expected:<302> but was:<404>

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-3713:
-

Attachment: SLING-3713-patch.txt

attaching proposed patch

> VanityPathTest testRedirectOnPathWithExtension fails:  Expecting temporary 
> redirect expected:<302> but was:<404>
> 
>
> Key: SLING-3713
> URL: https://issues.apache.org/jira/browse/SLING-3713
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Robert Munteanu
>Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.1.2
>
> Attachments: SLING-3713-patch.txt
>
>
> This failure was first seen in 
> [https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.7/612|sling-trunk-1.7
>  build 612] - rev 1606740 .
> {code}Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.142 
> sec <<< FAILURE! - in 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest
> testRedirectOnPathWithExtension(org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest)
>   Time elapsed: 0.546 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: Expecting temporary redirect 
> expected:<302> but was:<404>
>   at junit.framework.Assert.fail(Assert.java:57)
>   at junit.framework.Assert.failNotEquals(Assert.java:329)
>   at junit.framework.Assert.assertEquals(Assert.java:78)
>   at junit.framework.Assert.assertEquals(Assert.java:234)
>   at junit.framework.TestCase.assertEquals(TestCase.java:401)
>   at 
> org.apache.sling.launchpad.webapp.integrationtest.VanityPathTest.testRedirectOnPathWithExtension(VanityPathTest.java:186){code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build is still unstable: sling-trunk-1.7 #705

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #705

[Apache Jenkins Server]

See 

[jira] [Commented] (SLING-3776) JsonRendererServlet should provide a way to list children as an array

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074266#comment-14074266
 ] 

Bertrand Delacretaz commented on SLING-3776:


We didn't seem to have docs for our default GET servlets so far, so I have 
added a minimal page at 
http://sling.apache.org/documentation/bundles/rendering-content-default-get-servlets.html,
 mentioning this new option.

> JsonRendererServlet should provide a way to list children as an array
> -
>
> Key: SLING-3776
> URL: https://issues.apache.org/jira/browse/SLING-3776
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.8
>Reporter: Damien Antipa
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Servlets Get 2.1.10
>
>
> The default JSON renderer prints all children of a node as another key-value 
> attribute. But browsers do not respect the order printed in the response of 
> object attributes (since the standard does not describe this).
> In a lot of cases I continue writing my own servlets to print the children as 
> a json array which respects the order. Imo the default renderer should 
> provide a selector to change the output and print children in an array.
> PR: https://github.com/apache/sling/pull/23



--
This message was sent by Atlassian JIRA
(v6.2#6252)

FYI, added a docs page for our GET servlets

[Bertrand Delacretaz]

Hi,

I don't think we had docs for that so far, I have added
http://sling.apache.org/documentation/bundles/rendering-content-default-get-servlets.html

It's fairly basic so far - patches welcome ;-)

-Bertrand

Jenkins build is still unstable: sling-trunk-1.6 #2327

[Apache Jenkins Server]

See 

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Pax Exam Utilities #2327

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2327

[Apache Jenkins Server]

See 

[jira] [Resolved] (SLING-3776) JsonRendererServlet should provide a way to list children as an array

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-3776.


Resolution: Fixed
  Assignee: Bertrand Delacretaz

I had a closer look at the commons.json rendering code and that's not too 
pretty - I have improved it a bit in SLING-3786, and added options there to 
render children as arrays.

The json get servlet now supports this option with a new .harray selector 
("hierarchy as arrays"), added in http://svn.apache.org/r1613371

Please cross-check and reopen this issue if not ok.

> JsonRendererServlet should provide a way to list children as an array
> -
>
> Key: SLING-3776
> URL: https://issues.apache.org/jira/browse/SLING-3776
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.8
>Reporter: Damien Antipa
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Servlets Get 2.1.10
>
>
> The default JSON renderer prints all children of a node as another key-value 
> attribute. But browsers do not respect the order printed in the response of 
> object attributes (since the standard does not describe this).
> In a lot of cases I continue writing my own servlets to print the children as 
> a json array which respects the order. Imo the default renderer should 
> provide a selector to change the output and print children in an array.
> PR: https://github.com/apache/sling/pull/23



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build is still unstable: sling-trunk-1.7 #704

[Apache Jenkins Server]

See 

[jira] [Updated] (SLING-3776) JsonRendererServlet should provide a way to list children as an array

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-3776:
---

Fix Version/s: Servlets Get 2.1.10

> JsonRendererServlet should provide a way to list children as an array
> -
>
> Key: SLING-3776
> URL: https://issues.apache.org/jira/browse/SLING-3776
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.8
>Reporter: Damien Antipa
>Priority: Minor
> Fix For: Servlets Get 2.1.10
>
>
> The default JSON renderer prints all children of a node as another key-value 
> attribute. But browsers do not respect the order printed in the response of 
> object attributes (since the standard does not describe this).
> In a lot of cases I continue writing my own servlets to print the children as 
> a json array which respects the order. Imo the default renderer should 
> provide a selector to change the output and print children in an array.
> PR: https://github.com/apache/sling/pull/23



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build is still unstable: sling-trunk-1.7 » Apache Sling Launchpad Testing #704

[Apache Jenkins Server]

See 

[jira] [Resolved] (SLING-3790) Enahnce MapEntries in order to update configuration under mapRoot only if needed

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso resolved SLING-3790.
--

   Resolution: Fixed
Fix Version/s: Resource Resolver 1.1.2

fixed in rev. 1613364

> Enahnce MapEntries in order to update configuration under mapRoot only if 
> needed
> 
>
> Key: SLING-3790
> URL: https://issues.apache.org/jira/browse/SLING-3790
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
> Fix For: Resource Resolver 1.1.2
>
>
> Enahnce MapEntries in order to update configuration under mapRoot (e.g. 
> etc/map) only if needed.
> Indeed 
> {code}
> if (path.startsWith(this.mapRoot)) {
> {code}
> can be used as a trigger on event handling



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build is still unstable: sling-trunk-1.6 #2326

[Apache Jenkins Server]

See 

Jenkins build is still unstable: sling-trunk-1.6 » Apache Sling Launchpad Testing #2326

[Apache Jenkins Server]

See 

[jira] [Assigned] (SLING-3790) Enahnce MapEntries in order to update configuration under mapRoot only if needed

[Antonio Sanso (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso reassigned SLING-3790:


Assignee: Antonio Sanso

> Enahnce MapEntries in order to update configuration under mapRoot only if 
> needed
> 
>
> Key: SLING-3790
> URL: https://issues.apache.org/jira/browse/SLING-3790
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>
> Enahnce MapEntries in order to update configuration under mapRoot (e.g. 
> etc/map) only if needed.
> Indeed 
> {code}
> if (path.startsWith(this.mapRoot)) {
> {code}
> can be used as a trigger on event handling



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (SLING-3790) Enahnce MapEntries in order to update configuration under mapRoot only if needed

[Antonio Sanso (JIRA)]

Antonio Sanso created SLING-3790:


 Summary: Enahnce MapEntries in order to update configuration under 
mapRoot only if needed
 Key: SLING-3790
 URL: https://issues.apache.org/jira/browse/SLING-3790
 Project: Sling
  Issue Type: Improvement
  Components: ResourceResolver
Reporter: Antonio Sanso


Enahnce MapEntries in order to update configuration under mapRoot (e.g. 
etc/map) only if needed.

Indeed 

{code}
if (path.startsWith(this.mapRoot)) {
{code}

can be used as a trigger on event handling





--
This message was sent by Atlassian JIRA
(v6.2#6252)