[jira] [Comment Edited] (SLING-4649) FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak

2015-07-08 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618185#comment-14618185
 ] 

Robert Munteanu edited comment on SLING-4649 at 7/8/15 8:08 AM:


Are you sure this is the task you wanted to reopen?


was (Author: rombert):
Are you sure this is the taks you wanted to reopen?

 FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
 --

 Key: SLING-4649
 URL: https://issues.apache.org/jira/browse/SLING-4649
 Project: Sling
  Issue Type: Bug
  Components: Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Oliver Lietz
  Labels: sling-IT
 Fix For: Launchpad Builder 8


 Failed tests: 
   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
 condition is false after 10 seconds: A document containing 'Excepteur' is 
 found under /FullTextIndexingTest
 This last worked on Jenkins with [sling-oak-it-1.7 
 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
 r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4649) FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak

2015-07-08 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618206#comment-14618206
 ] 

Oliver Lietz commented on SLING-4649:
-

Yes, see [~cziegeler]'s latest comment. I would like to add under 
{{\[configurations runModes=oak\]}} in {{oak.txt}} the following config:

{noformat}
  org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexProviderService
localIndexDir=sling/oak/repository/index
{noformat}

And remove {{repository.home=$\{sling.home}/repository\}} from {{boot.txt}}.


 FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
 --

 Key: SLING-4649
 URL: https://issues.apache.org/jira/browse/SLING-4649
 Project: Sling
  Issue Type: Bug
  Components: Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Oliver Lietz
  Labels: sling-IT
 Fix For: Launchpad Builder 8


 Failed tests: 
   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
 condition is false after 10 seconds: A document containing 'Excepteur' is 
 found under /FullTextIndexingTest
 This last worked on Jenkins with [sling-oak-it-1.7 
 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
 r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4412) upgrade Karaf to 4.0

2015-07-08 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618456#comment-14618456
 ] 

Oliver Lietz commented on SLING-4412:
-

Yes, something is going wrong with wrap. But it is only required in 
{{SlingLaunchpadOakMongoIT}} for some bundles related to MongoDB. And even 
adding wrap as boot feature does not help:

{noformat}
2015-07-08 13:31:41,217 | INFO  | pool-1-thread-1  | FeaturesServiceImpl
  | 8 - org.apache.karaf.features.core - 4.0.1.SNAPSHOT | Adding features: 
test-dependencies/[0,0.0.0], instance/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
package/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], log/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
sling-launchpad-oak-mongo/[0.1.1.SNAPSHOT,0.1.1.SNAPSHOT], 
ssh/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
aries-blueprint/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], exam/[4.5.0,4.5.0], 
system/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
feature/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
management/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
shell/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], service/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
jaas/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], deployer/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
diagnostic/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
shell-compat/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
bundle/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], config/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], 
kar/[4.0.1.SNAPSHOT,4.0.1.SNAPSHOT], wrap/[0,0.0.0]
{noformat}

It may be a Pax Exam problem.

 upgrade Karaf to 4.0
 

 Key: SLING-4412
 URL: https://issues.apache.org/jira/browse/SLING-4412
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Launchpad Karaf Features 0.2.0, Launchpad Karaf 
 Integration Tests 0.2.0

 Attachments: SLING-4412.WIP.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4412) upgrade Karaf to 4.0

2015-07-08 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618463#comment-14618463
 ] 

Guillaume Nodet commented on SLING-4412:


You also need to make sure your pax-exam tests install the {{wrap}} feature.
Do you have a github pointer to the failing test ?

 upgrade Karaf to 4.0
 

 Key: SLING-4412
 URL: https://issues.apache.org/jira/browse/SLING-4412
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Launchpad Karaf Features 0.2.0, Launchpad Karaf 
 Integration Tests 0.2.0

 Attachments: SLING-4412.WIP.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4412) upgrade Karaf to 4.0

2015-07-08 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618443#comment-14618443
 ] 

Guillaume Nodet commented on SLING-4412:


The problem is what you're missing the wrap url handler.
You need to install the wrap feature before trying to install sling.

 upgrade Karaf to 4.0
 

 Key: SLING-4412
 URL: https://issues.apache.org/jira/browse/SLING-4412
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Launchpad Karaf Features 0.2.0, Launchpad Karaf 
 Integration Tests 0.2.0

 Attachments: SLING-4412.WIP.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4412) upgrade Karaf to 4.0

2015-07-08 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618492#comment-14618492
 ] 

Oliver Lietz commented on SLING-4412:
-

[SlingLaunchpadOakMongoIT|https://github.com/apache/sling/blob/trunk/contrib/launchpad/karaf/org.apache.sling.launchpad.karaf-integration-tests/src/test/java/org/apache/sling/launchpad/karaf/tests/bootstrap/SlingLaunchpadOakMongoIT.java]

I've added {{addBootFeature(wrap),}} in line {{87}} besides 
[SLING-4412.WIP.patch|https://issues.apache.org/jira/secure/attachment/12743632/SLING-4412.WIP.patch].

 upgrade Karaf to 4.0
 

 Key: SLING-4412
 URL: https://issues.apache.org/jira/browse/SLING-4412
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Launchpad Karaf Features 0.2.0, Launchpad Karaf 
 Integration Tests 0.2.0

 Attachments: SLING-4412.WIP.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


releasing resource resolver 1.2.6? (for SLING-4644)

2015-07-08 Thread Stefan Egli
Hi all,

What's the status of the remaining tickets on resource resolver 1.2.6,
anything that would prevent making a release? Reason I ask is that having a
release would thus contain SLING-4644 and that might perhaps help in
narrowing down the root cause of SLING-4556 a bit further..

Cheers,
Stefan
--
https://issues.apache.org/jira/browse/SLING/fixforversion/12329842/?selected
Tab=com.atlassian.jira.jira-projects-plugin:version-issues-panel




[jira] [Updated] (SLING-4863) Use new launchpad rather than crankstart in the Debian packaging

2015-07-08 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SLING-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek updated SLING-4863:
-
Attachment: SLING-4863.patch

Working patch attached.

 Use new launchpad rather than crankstart in the Debian packaging
 

 Key: SLING-4863
 URL: https://issues.apache.org/jira/browse/SLING-4863
 Project: Sling
  Issue Type: Task
  Components: Launchpad
Reporter: Tomek Rękawek
Priority: Minor
 Fix For: Launchpad Builder 8

 Attachments: SLING-4863.patch


 The new launchpad, using provisioning text files is more popular than 
 crankstart. Please update the Debian packaging module to use the new 
 launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: releasing resource resolver 1.2.6? (for SLING-4644)

2015-07-08 Thread Carsten Ziegeler
+1, the open issues can be moved (assuming that you use the released
Sling API for the dependency and don't plan to release API as well)

Carsten

Am 08.07.15 um 06:55 schrieb Stefan Egli:
 Hi all,
 
 What's the status of the remaining tickets on resource resolver 1.2.6,
 anything that would prevent making a release? Reason I ask is that having a
 release would thus contain SLING-4644 and that might perhaps help in
 narrowing down the root cause of SLING-4556 a bit further..
 
 Cheers,
 Stefan
 --
 https://issues.apache.org/jira/browse/SLING/fixforversion/12329842/?selected
 Tab=com.atlassian.jira.jira-projects-plugin:version-issues-panel
 
 
 


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Created] (SLING-4863) Use new launchpad rather than crankstart in the Debian packaging

2015-07-08 Thread JIRA
Tomek Rękawek created SLING-4863:


 Summary: Use new launchpad rather than crankstart in the Debian 
packaging
 Key: SLING-4863
 URL: https://issues.apache.org/jira/browse/SLING-4863
 Project: Sling
  Issue Type: Task
  Components: Launchpad
Reporter: Tomek Rękawek
Priority: Minor
 Fix For: Launchpad Builder 8


The new launchpad, using provisioning text files is more popular than 
crankstart. Please update the Debian packaging module to use the new launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-4862) Sling Health Checks Servlet

2015-07-08 Thread Bertrand Delacretaz (JIRA)
Bertrand Delacretaz created SLING-4862:
--

 Summary: Sling Health Checks Servlet
 Key: SLING-4862
 URL: https://issues.apache.org/jira/browse/SLING-4862
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Reporter: Bertrand Delacretaz
Priority: Minor


A Servlet that can execute health checks would be useful.

It can take as input the tags of the HCs to execute, and output their results 
in JSON format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4649) FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak

2015-07-08 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618186#comment-14618186
 ] 

Robert Munteanu commented on SLING-4649:


Are you sure this is the taks you wanted to reopen?

 FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
 --

 Key: SLING-4649
 URL: https://issues.apache.org/jira/browse/SLING-4649
 Project: Sling
  Issue Type: Bug
  Components: Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Oliver Lietz
  Labels: sling-IT
 Fix For: Launchpad Builder 8


 Failed tests: 
   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
 condition is false after 10 seconds: A document containing 'Excepteur' is 
 found under /FullTextIndexingTest
 This last worked on Jenkins with [sling-oak-it-1.7 
 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
 r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4649) FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak

2015-07-08 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618185#comment-14618185
 ] 

Robert Munteanu commented on SLING-4649:


Are you sure this is the taks you wanted to reopen?

 FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
 --

 Key: SLING-4649
 URL: https://issues.apache.org/jira/browse/SLING-4649
 Project: Sling
  Issue Type: Bug
  Components: Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Oliver Lietz
  Labels: sling-IT
 Fix For: Launchpad Builder 8


 Failed tests: 
   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
 condition is false after 10 seconds: A document containing 'Excepteur' is 
 found under /FullTextIndexingTest
 This last worked on Jenkins with [sling-oak-it-1.7 
 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
 r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (SLING-4649) FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak

2015-07-08 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-4649:
---
Comment: was deleted

(was: Are you sure this is the taks you wanted to reopen?)

 FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
 --

 Key: SLING-4649
 URL: https://issues.apache.org/jira/browse/SLING-4649
 Project: Sling
  Issue Type: Bug
  Components: Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Oliver Lietz
  Labels: sling-IT
 Fix For: Launchpad Builder 8


 Failed tests: 
   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
 condition is false after 10 seconds: A document containing 'Excepteur' is 
 found under /FullTextIndexingTest
 This last worked on Jenkins with [sling-oak-it-1.7 
 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
 r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4862) Sling Health Checks Servlet

2015-07-08 Thread Georg Henzler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618301#comment-14618301
 ] 

Georg Henzler commented on SLING-4862:
--

I discussed this with [~jhoh] some time ago - this could be a Sling servlet 
that takes the tag config from the resource (allowing multiple to have multiple 
configs as resources at different URLs) or a low-level whiteboard servlet (just 
using request parameters for tags and response format). The advantage from the 
latter is performance (no jcr access, it's circumventing sling resource 
mapping/authentication) and reliability (less dependencies, even if sling was 
completely broken it can still answer as it relies solely on OSGi). The missing 
authentication is normally not a problem if a path at under /system is used 
(e.g /system/health) as those paths are normally hidden from the internet (but 
I would use configuration policy required for the servlet to only activate if 
desired).

 [~bdelacretaz] we have been using a servlet as described above for quite a 
while already, should we contribute it or would you like to use a different 
approach?



 Sling Health Checks Servlet
 ---

 Key: SLING-4862
 URL: https://issues.apache.org/jira/browse/SLING-4862
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Reporter: Bertrand Delacretaz
Priority: Minor

 A Servlet that can execute health checks would be useful.
 It can take as input the tags of the HCs to execute, and output their results 
 in JSON format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (SLING-4649) FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak

2015-07-08 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reopened SLING-4649:
-
  Assignee: Oliver Lietz  (was: Robert Munteanu)

configure components explicitly (Config Admin), drop framework properties

 FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
 --

 Key: SLING-4649
 URL: https://issues.apache.org/jira/browse/SLING-4649
 Project: Sling
  Issue Type: Bug
  Components: Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Oliver Lietz
  Labels: sling-IT
 Fix For: Launchpad Builder 8


 Failed tests: 
   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
 condition is false after 10 seconds: A document containing 'Excepteur' is 
 found under /FullTextIndexingTest
 This last worked on Jenkins with [sling-oak-it-1.7 
 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
 r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4528) Moving to Oak

2015-07-08 Thread JIRA

[ 
https://issues.apache.org/jira/browse/SLING-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618173#comment-14618173
 ] 

Michael Dürig commented on SLING-4528:
--

Still the same currently. Though there are plans to improve. See OAK-2910

 Moving to Oak
 -

 Key: SLING-4528
 URL: https://issues.apache.org/jira/browse/SLING-4528
 Project: Sling
  Issue Type: Task
  Components: JCR
Reporter: Oliver Lietz
  Labels: oak
 Fix For: JCR Oak Server 1.0.0


 _Apache Sling Oak Repository Server_ ({{org.apache.sling.jcr.oak.server}}) is 
 not released and contains some TODOs and {{JcrRepositoryHacks}}.
 What needs to be done for a first release, [~bdelacretaz] and [~mduerig]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4528) Moving to Oak

2015-07-08 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618343#comment-14618343
 ] 

Oliver Lietz commented on SLING-4528:
-

Thanks, [~mduerig]. Looks like there is more work to do. OAK-3083 blocks me 
right now on SLING-4412.

 Moving to Oak
 -

 Key: SLING-4528
 URL: https://issues.apache.org/jira/browse/SLING-4528
 Project: Sling
  Issue Type: Task
  Components: JCR
Reporter: Oliver Lietz
  Labels: oak
 Fix For: JCR Oak Server 1.0.0


 _Apache Sling Oak Repository Server_ ({{org.apache.sling.jcr.oak.server}}) is 
 not released and contains some TODOs and {{JcrRepositoryHacks}}.
 What needs to be done for a first release, [~bdelacretaz] and [~mduerig]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: releasing resource resolver 1.2.6? (for SLING-4644)

2015-07-08 Thread Stefan Egli
On 7/8/15 2:26 PM, Carsten Ziegeler cziege...@apache.org wrote:

+1, the open issues can be moved (assuming that you use the released
Sling API for the dependency and don't plan to release API as well)

Right, it was just about resource resolver (for my 'needs' that is :)

Ok, I'll move the 4 remaining issues and do the release next.

Cheers,
Stefan



Carsten

Am 08.07.15 um 06:55 schrieb Stefan Egli:
 Hi all,
 
 What's the status of the remaining tickets on resource resolver 1.2.6,
 anything that would prevent making a release? Reason I ask is that
having a
 release would thus contain SLING-4644 and that might perhaps help in
 narrowing down the root cause of SLING-4556 a bit further..
 
 Cheers,
 Stefan
 --
 
https://issues.apache.org/jira/browse/SLING/fixforversion/12329842/?selec
ted
 Tab=com.atlassian.jira.jira-projects-plugin:version-issues-panel
 
 
 


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org




[jira] [Updated] (SLING-4752) New resource query API

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4752:
---
Fix Version/s: (was: Resource Resolver 1.2.6)
   (was: API 2.10.0)
   Resource Resolver 1.2.8

 New resource query API
 --

 Key: SLING-4752
 URL: https://issues.apache.org/jira/browse/SLING-4752
 Project: Sling
  Issue Type: Improvement
  Components: API, JCR, ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Resource Resolver 1.2.8


 Discussion thread:
 http://mail-archives.apache.org/mod_mbox/sling-dev/201505.mbox/%3C555983F6.7020100%40apache.org%3E
 Starting mail:
 The current resource query api has several problems:
 - it's using the JCR spec to define a query
 - it's not clear which queries are supported by providers
 - queries are string based
 - implementing queries in a resource provider is way too hard as this
 would require to implement the complete jcr query api.
 I've created a draft for a new, object based API at [1]. The main idea
 is to use a builder pattern to create Query objects. This are immutable
 and have a unique identifier. The QueryManager service can be used to
 execute a query in the context of a resource resolver. The manager
 delegates the query to the providers. As each Query object has this
 identifier, implementations can use this to cache the parsing of the query.
 In addition to the query object you can pass in query instructions to
 specify a limit or range for the query.
 Obviously this is a reduced set compared to the full fledged jcr search
 api, however it should be suitable for the majority of use cases.
 [1]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler/api-v3/src/main/java/org/apache/sling/api/resource/query/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4751) New Observation Support

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4751:
---
Fix Version/s: (was: Resource Resolver 1.2.6)
   (was: API 2.10.0)
   Resource Resolver 1.2.8

 New Observation Support
 ---

 Key: SLING-4751
 URL: https://issues.apache.org/jira/browse/SLING-4751
 Project: Sling
  Issue Type: Improvement
  Components: API, JCR, ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Resource Resolver 1.2.8


 Mail thread:
 http://mail-archives.apache.org/mod_mbox/sling-dev/201505.mbox/%3C555983F2.20402%40apache.org%3E
 Starting mail
 Right now, resources changes are propagated through event admin - which
 at the time sounded like a good idea. Over time, this has shown to be a
 bottle neck.
 Basically there are at least three problems:
 - the sender of the resource events does not know whether there is a
 receiver, therefore events for each and every change need to be sent
 - event objects are immutable and therefore all relevant data needs to
 be calculated upfront, even if it's not used. For example a resource
 event contains the resource type which needs to be fetched from the
 repository, even if no one is interested in it.
 - receivers of the events can't easily act on behalf of the user who
 initiated the change.
 I created a new listener api at [1] which defines a ResourceListener
 interface and some ways how to specify the events one is interested in.
 The user aware resource listener allows to act on behalf of the user (if
 that information is available).
 On the other side, a new service, the ObservationReporter [2] is
 defined. Resource providers report changes through this interface. The
 payload of such an event is an interface which allows for lazy retrieval
 of the information.
 We can also use this mechanism for compatibility and an implementation
 of the observation reporter might sent all events via the event admin.
 [1]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler/api-v3/src/main/java/org/apache/sling/api/resource/observation/
 [2]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4770) Create DTOs for state inspection

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4770:
---
Fix Version/s: (was: Resource Resolver 1.2.6)
   (was: API 2.10.0)
   Resource Resolver 1.2.8

 Create DTOs for state inspection
 

 Key: SLING-4770
 URL: https://issues.apache.org/jira/browse/SLING-4770
 Project: Sling
  Issue Type: Improvement
  Components: API, ResourceResolver
Reporter: Carsten Ziegeler
 Fix For: Resource Resolver 1.2.8


 Newer OSGi specs usually always contain a DTO api which allows to get the 
 current state of the implementation, e.g. the framework state, DS provides 
 component states, the http whiteboard allows to inspect the registered 
 servlets etc.
 The nice thing of using such DTOs is that they are easily serializable (ootb, 
 rules are defined) and should be well known to OSGi aware developers.
 We should add such DTOs at least for the resource tree: mounted providers, 
 their configurations etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4750) New Resource Provider API

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4750:
---
Fix Version/s: (was: Resource Resolver 1.2.6)
   (was: API 2.10.0)
   Resource Resolver 1.2.8

 New Resource Provider API
 -

 Key: SLING-4750
 URL: https://issues.apache.org/jira/browse/SLING-4750
 Project: Sling
  Issue Type: Improvement
  Components: API, JCR, ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Resource Resolver 1.2.8


 Mail thread from the mailing list:
 http://mail-archives.apache.org/mod_mbox/sling-dev/201505.mbox/%3C555983ED.1080800%40apache.org%3E
 Starting mail:
 The resource provider API has grown a lot over time and when we started
 with it we didn't really think about potential extensions of the api.
 Today, each time we add a new feature, we come up with a new marker
 interface. There is also the distinction between a resource provider
 (singleton/stateless) and the factory (creating stateful providers).
 Although the api is not intended to be used by the average resource api
 user (it's an extension), we put it in the same package. And there are
 more minor things.
 Therefore I think it's time to start a new API that is more future proof
 and solves the known problems. I've created a draft prototype at [1].
 During the performance analysis by Joel he found out that getParent
 calls to a resource a pretty expensive as in the end these are string
 based. Therefore, e.g. the JCR implementation can't simply call
 getParent on a node and wrap it in a resource. Therefore I think we
 should add a getParent(Resource) method to the resource resolver and
 have a better way to handle this in a resource provider.
 Instead of having a resource provider and a resource provider factory,
 we define a single ResourceProvider which is a singleton. If this
 provider needs authentication and/or needs to keep state per user, the
 PROPERTY_AUTHENTICATE needs to be set to true and in this case the
 authenticate method is called. This one returns a data object which is
 passed in to each and every method. If auth is not required, the method
 is not called and null is passed in as the data object.
 For authentication, providers do not support login administrative
 anymore, just users and service users.
 A provider is mounted at a single root - no more support for mounting it
 at different path at the same time; and a provider always owns the root.
 So if a provider does not return a resource for a given path, no other
 provider is asked. This allows for improved implementations and resource
 resolving. If we decided that we need this for compatibility we can
 solve it differently.
 Instead of using marker interface, we define the ResourceProvider as an
 abstract class. This allows us to add new methods without breaking
 existing providers.
 Each method gets a ResolveContext, containing the resource resolver,
 the previously mentioned state data object and other things, e.g. the
 parameter support recently added to the resource resolving. In the
 future we can pass in additional data without breaking the interface.
 Apart from that the resource provider is similar to the aggregation of
 the already existing marker interfaces. There are two exceptions,
 observation and query which I'll handle in different emails.
 [1]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler/api-v3/src/main/java/org/apache/sling/api/resource/provider/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4864) SlingAuthenticator should handle empty path for anonymous resources

2015-07-08 Thread Antonio Sanso (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-4864:
-
Description: 
FELIX-4925 changed the semantic of {{request.getServletPath()}} in case of 

{code}
GET /
{code}

it now return {{}} rather than {{/}}


This case needs to be correctly handled

  was:
FELIX-4925 changed the semantic of {{request.getServletPath()}} in case of 

{code}
GET /
{code}

it now return {{}} rather than {{/}}


This case needs to be correctly handled


 SlingAuthenticator should handle empty path for anonymous resources
 ---

 Key: SLING-4864
 URL: https://issues.apache.org/jira/browse/SLING-4864
 Project: Sling
  Issue Type: Bug
  Components: Authentication
Reporter: Antonio Sanso
Assignee: Antonio Sanso

 FELIX-4925 changed the semantic of {{request.getServletPath()}} in case of 
 {code}
 GET /
 {code}
 it now return {{}} rather than {{/}}
 This case needs to be correctly handled



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-4864) SlingAuthenticator should handle empty path for anonymous resources

2015-07-08 Thread Antonio Sanso (JIRA)
Antonio Sanso created SLING-4864:


 Summary: SlingAuthenticator should handle empty path for anonymous 
resources
 Key: SLING-4864
 URL: https://issues.apache.org/jira/browse/SLING-4864
 Project: Sling
  Issue Type: Bug
  Components: Authentication
Reporter: Antonio Sanso
Assignee: Antonio Sanso


FELIX-4925 changed the semantic of {{request.getServletPath()}} in case of 

{code}
GET /
{code}

it now return {{}} rather than {{/}}


This case needs to be correctly handled



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4412) upgrade Karaf to 4.0

2015-07-08 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618546#comment-14618546
 ] 

Guillaume Nodet commented on SLING-4412:


I can't apply your patch.  Could you create a correct patch or push a private 
github fork with the applied patch ?

 upgrade Karaf to 4.0
 

 Key: SLING-4412
 URL: https://issues.apache.org/jira/browse/SLING-4412
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Launchpad Karaf Features 0.2.0, Launchpad Karaf 
 Integration Tests 0.2.0

 Attachments: SLING-4412.WIP.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4751) New Observation Support

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4751:
---
Fix Version/s: API 2.10.0

 New Observation Support
 ---

 Key: SLING-4751
 URL: https://issues.apache.org/jira/browse/SLING-4751
 Project: Sling
  Issue Type: Improvement
  Components: API, JCR, ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: API 2.10.0, Resource Resolver 1.2.8


 Mail thread:
 http://mail-archives.apache.org/mod_mbox/sling-dev/201505.mbox/%3C555983F2.20402%40apache.org%3E
 Starting mail
 Right now, resources changes are propagated through event admin - which
 at the time sounded like a good idea. Over time, this has shown to be a
 bottle neck.
 Basically there are at least three problems:
 - the sender of the resource events does not know whether there is a
 receiver, therefore events for each and every change need to be sent
 - event objects are immutable and therefore all relevant data needs to
 be calculated upfront, even if it's not used. For example a resource
 event contains the resource type which needs to be fetched from the
 repository, even if no one is interested in it.
 - receivers of the events can't easily act on behalf of the user who
 initiated the change.
 I created a new listener api at [1] which defines a ResourceListener
 interface and some ways how to specify the events one is interested in.
 The user aware resource listener allows to act on behalf of the user (if
 that information is available).
 On the other side, a new service, the ObservationReporter [2] is
 defined. Resource providers report changes through this interface. The
 payload of such an event is an interface which allows for lazy retrieval
 of the information.
 We can also use this mechanism for compatibility and an implementation
 of the observation reporter might sent all events via the event admin.
 [1]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler/api-v3/src/main/java/org/apache/sling/api/resource/observation/
 [2]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4862) Sling Health Checks Servlet

2015-07-08 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618537#comment-14618537
 ] 

Nicolas Peltier commented on SLING-4862:


on the wish list :-) it would be nice to have an osgi flag we can set to make 
the call fail in all cases (maintenance, ...) not sure if it is better to put 
it here, or create a dummy health check repeats what you tell him in its conf.

 Sling Health Checks Servlet
 ---

 Key: SLING-4862
 URL: https://issues.apache.org/jira/browse/SLING-4862
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Reporter: Bertrand Delacretaz
Priority: Minor

 A Servlet that can execute health checks would be useful.
 It can take as input the tags of the HCs to execute, and output their results 
 in JSON format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4412) upgrade Karaf to 4.0

2015-07-08 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618596#comment-14618596
 ] 

Oliver Lietz commented on SLING-4412:
-

I've replayed the 
[commits|https://github.com/sling-git/sling/commits/feature/karaf4] in 
[feature/karaf4|https://github.com/sling-git/sling/tree/feature/karaf4]. Does 
that work for you?

 upgrade Karaf to 4.0
 

 Key: SLING-4412
 URL: https://issues.apache.org/jira/browse/SLING-4412
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Launchpad Karaf Features 0.2.0, Launchpad Karaf 
 Integration Tests 0.2.0

 Attachments: SLING-4412.WIP.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE] Release Apache Sling Resource Resolver 1.2.6

2015-07-08 Thread Stefan Egli
Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12329842/

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1290/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1290 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Cheers,
Stefan




[jira] [Commented] (SLING-4862) Sling Health Checks Servlet

2015-07-08 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618534#comment-14618534
 ] 

Bertrand Delacretaz commented on SLING-4862:


What you suggest sounds good and I think both modes (resource-based and last 
resort path-based) are useful, so if you want to contribute that that would be 
great. I probably won't be able to work on this for the next 2 weeks but can 
pick that up when I'm back in action, unless someone beats me to it.

 Sling Health Checks Servlet
 ---

 Key: SLING-4862
 URL: https://issues.apache.org/jira/browse/SLING-4862
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Reporter: Bertrand Delacretaz
Priority: Minor

 A Servlet that can execute health checks would be useful.
 It can take as input the tags of the HCs to execute, and output their results 
 in JSON format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4862) Sling Health Checks Servlet

2015-07-08 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618549#comment-14618549
 ] 

Bertrand Delacretaz commented on SLING-4862:


[~npeltier] IIUC your use case is to set a flag that marks a Sling instance as 
being down? Sounds useful, we could add a config flag to the HC servlet.

 Sling Health Checks Servlet
 ---

 Key: SLING-4862
 URL: https://issues.apache.org/jira/browse/SLING-4862
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Reporter: Bertrand Delacretaz
Priority: Minor

 A Servlet that can execute health checks would be useful.
 It can take as input the tags of the HCs to execute, and output their results 
 in JSON format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4750) New Resource Provider API

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4750:
---
Fix Version/s: API 2.10.0

 New Resource Provider API
 -

 Key: SLING-4750
 URL: https://issues.apache.org/jira/browse/SLING-4750
 Project: Sling
  Issue Type: Improvement
  Components: API, JCR, ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: API 2.10.0, Resource Resolver 1.2.8


 Mail thread from the mailing list:
 http://mail-archives.apache.org/mod_mbox/sling-dev/201505.mbox/%3C555983ED.1080800%40apache.org%3E
 Starting mail:
 The resource provider API has grown a lot over time and when we started
 with it we didn't really think about potential extensions of the api.
 Today, each time we add a new feature, we come up with a new marker
 interface. There is also the distinction between a resource provider
 (singleton/stateless) and the factory (creating stateful providers).
 Although the api is not intended to be used by the average resource api
 user (it's an extension), we put it in the same package. And there are
 more minor things.
 Therefore I think it's time to start a new API that is more future proof
 and solves the known problems. I've created a draft prototype at [1].
 During the performance analysis by Joel he found out that getParent
 calls to a resource a pretty expensive as in the end these are string
 based. Therefore, e.g. the JCR implementation can't simply call
 getParent on a node and wrap it in a resource. Therefore I think we
 should add a getParent(Resource) method to the resource resolver and
 have a better way to handle this in a resource provider.
 Instead of having a resource provider and a resource provider factory,
 we define a single ResourceProvider which is a singleton. If this
 provider needs authentication and/or needs to keep state per user, the
 PROPERTY_AUTHENTICATE needs to be set to true and in this case the
 authenticate method is called. This one returns a data object which is
 passed in to each and every method. If auth is not required, the method
 is not called and null is passed in as the data object.
 For authentication, providers do not support login administrative
 anymore, just users and service users.
 A provider is mounted at a single root - no more support for mounting it
 at different path at the same time; and a provider always owns the root.
 So if a provider does not return a resource for a given path, no other
 provider is asked. This allows for improved implementations and resource
 resolving. If we decided that we need this for compatibility we can
 solve it differently.
 Instead of using marker interface, we define the ResourceProvider as an
 abstract class. This allows us to add new methods without breaking
 existing providers.
 Each method gets a ResolveContext, containing the resource resolver,
 the previously mentioned state data object and other things, e.g. the
 parameter support recently added to the resource resolving. In the
 future we can pass in additional data without breaking the interface.
 Apart from that the resource provider is similar to the aggregation of
 the already existing marker interfaces. There are two exceptions,
 observation and query which I'll handle in different emails.
 [1]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler/api-v3/src/main/java/org/apache/sling/api/resource/provider/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4862) Sling Health Checks Servlet

2015-07-08 Thread Nicolas Peltier (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618564#comment-14618564
 ] 

Nicolas Peltier commented on SLING-4862:


[~bdelacretaz] that's it yes, + also configurable OK/NOK messages, and 
decoupling of the response rendering (txt, html, json might be needed in some 
cases)

 Sling Health Checks Servlet
 ---

 Key: SLING-4862
 URL: https://issues.apache.org/jira/browse/SLING-4862
 Project: Sling
  Issue Type: Improvement
  Components: Health Check
Reporter: Bertrand Delacretaz
Priority: Minor

 A Servlet that can execute health checks would be useful.
 It can take as input the tags of the HCs to execute, and output their results 
 in JSON format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4752) New resource query API

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4752:
---
Fix Version/s: API 2.10.0

 New resource query API
 --

 Key: SLING-4752
 URL: https://issues.apache.org/jira/browse/SLING-4752
 Project: Sling
  Issue Type: Improvement
  Components: API, JCR, ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: API 2.10.0, Resource Resolver 1.2.8


 Discussion thread:
 http://mail-archives.apache.org/mod_mbox/sling-dev/201505.mbox/%3C555983F6.7020100%40apache.org%3E
 Starting mail:
 The current resource query api has several problems:
 - it's using the JCR spec to define a query
 - it's not clear which queries are supported by providers
 - queries are string based
 - implementing queries in a resource provider is way too hard as this
 would require to implement the complete jcr query api.
 I've created a draft for a new, object based API at [1]. The main idea
 is to use a builder pattern to create Query objects. This are immutable
 and have a unique identifier. The QueryManager service can be used to
 execute a query in the context of a resource resolver. The manager
 delegates the query to the providers. As each Query object has this
 identifier, implementations can use this to cache the parsing of the query.
 In addition to the query object you can pass in query instructions to
 specify a limit or range for the query.
 Obviously this is a reduced set compared to the full fledged jcr search
 api, however it should be suitable for the majority of use cases.
 [1]
 https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler/api-v3/src/main/java/org/apache/sling/api/resource/query/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4770) Create DTOs for state inspection

2015-07-08 Thread Stefan Egli (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli updated SLING-4770:
---
Fix Version/s: API 2.10.0

 Create DTOs for state inspection
 

 Key: SLING-4770
 URL: https://issues.apache.org/jira/browse/SLING-4770
 Project: Sling
  Issue Type: Improvement
  Components: API, ResourceResolver
Reporter: Carsten Ziegeler
 Fix For: API 2.10.0, Resource Resolver 1.2.8


 Newer OSGi specs usually always contain a DTO api which allows to get the 
 current state of the implementation, e.g. the framework state, DS provides 
 component states, the http whiteboard allows to inspect the registered 
 servlets etc.
 The nice thing of using such DTOs is that they are easily serializable (ootb, 
 rules are defined) and should be well known to OSGi aware developers.
 We should add such DTOs at least for the resource tree: mounted providers, 
 their configurations etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-4853) JobManager.findJobs should skip items that have been removed during the call

2015-07-08 Thread Marius Petria (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria resolved SLING-4853.
--
Resolution: Not A Problem

 JobManager.findJobs should skip items that have been removed during the call
 

 Key: SLING-4853
 URL: https://issues.apache.org/jira/browse/SLING-4853
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Marius Petria
  Labels: event
 Attachments: SLING-4853.diff


 Sometimes under high load the iteration over job nodes can fail [1] because 
 the nodes could be already processed and removed. We could by more fault 
 tolerant when reading a resource and just skip it in case of failure.
 {noformat}
 Caused by: java.lang.IllegalStateException: Failed to retrieve path from Item:
 at 
 org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResource.getPath(JcrItemResource.java:82)
 at 
 org.apache.sling.event.impl.jobs.JobManagerImpl.findJobs(JobManagerImpl.java:659)
 at 
 com.day.cq.replication.impl.queue.ReplicationQueueImpl.entries(ReplicationQueueImpl.java:144)
 Caused by: javax.jcr.InvalidItemStateException: This item does not exist 
 anymore
 at 
 org.apache.jackrabbit.oak.jcr.delegate.ItemDelegate.checkAlive(ItemDelegate.java:85)
 at 
 org.apache.jackrabbit.oak.jcr.session.operation.ItemOperation.checkPreconditions(ItemOperation.java:34)
 at 
 org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:289)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:113)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.getPath(ItemImpl.java:153)
 {noformat}
 [1] 
 https://github.com/apache/sling/blob/29420e3482d610c1dd9741276388670474026bf6/bundles/extensions/event/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L662



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4863) Use new launchpad rather than crankstart in the Debian packaging

2015-07-08 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SLING-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek updated SLING-4863:
-
Attachment: (was: SLING-4863.patch)

 Use new launchpad rather than crankstart in the Debian packaging
 

 Key: SLING-4863
 URL: https://issues.apache.org/jira/browse/SLING-4863
 Project: Sling
  Issue Type: Task
  Components: Launchpad
Reporter: Tomek Rękawek
Priority: Minor
 Fix For: Launchpad Builder 8

 Attachments: SLING-4863.patch


 The new launchpad, using provisioning text files is more popular than 
 crankstart. Please update the Debian packaging module to use the new 
 launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-4863) Use new launchpad rather than crankstart in the Debian packaging

2015-07-08 Thread JIRA

 [ 
https://issues.apache.org/jira/browse/SLING-4863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomek Rękawek updated SLING-4863:
-
Attachment: SLING-4863.patch

 Use new launchpad rather than crankstart in the Debian packaging
 

 Key: SLING-4863
 URL: https://issues.apache.org/jira/browse/SLING-4863
 Project: Sling
  Issue Type: Task
  Components: Launchpad
Reporter: Tomek Rękawek
Priority: Minor
 Fix For: Launchpad Builder 8

 Attachments: SLING-4863.patch


 The new launchpad, using provisioning text files is more popular than 
 crankstart. Please update the Debian packaging module to use the new 
 launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4853) JobManager.findJobs should skip items that have been removed during the call

2015-07-08 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618714#comment-14618714
 ] 

Carsten Ziegeler commented on SLING-4853:
-

Catching RuntimeException seems to strong for me, in fact, getPath() should not 
throw any exception. We should add a catch IllegalStateException to the check 
job method and open an issue for the jcr impl

 JobManager.findJobs should skip items that have been removed during the call
 

 Key: SLING-4853
 URL: https://issues.apache.org/jira/browse/SLING-4853
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Marius Petria
  Labels: event
 Attachments: SLING-4853.diff


 Sometimes under high load the iteration over job nodes can fail [1] because 
 the nodes could be already processed and removed. We could by more fault 
 tolerant when reading a resource and just skip it in case of failure.
 {noformat}
 Caused by: java.lang.IllegalStateException: Failed to retrieve path from Item:
 at 
 org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResource.getPath(JcrItemResource.java:82)
 at 
 org.apache.sling.event.impl.jobs.JobManagerImpl.findJobs(JobManagerImpl.java:659)
 at 
 com.day.cq.replication.impl.queue.ReplicationQueueImpl.entries(ReplicationQueueImpl.java:144)
 Caused by: javax.jcr.InvalidItemStateException: This item does not exist 
 anymore
 at 
 org.apache.jackrabbit.oak.jcr.delegate.ItemDelegate.checkAlive(ItemDelegate.java:85)
 at 
 org.apache.jackrabbit.oak.jcr.session.operation.ItemOperation.checkPreconditions(ItemOperation.java:34)
 at 
 org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:289)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:113)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.getPath(ItemImpl.java:153)
 {noformat}
 [1] 
 https://github.com/apache/sling/blob/29420e3482d610c1dd9741276388670474026bf6/bundles/extensions/event/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L662



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4412) upgrade Karaf to 4.0

2015-07-08 Thread Guillaume Nodet (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618718#comment-14618718
 ] 

Guillaume Nodet commented on SLING-4412:


I've pushed a first fix, there are still problems in the jackrabbit tests 
though...
  
https://github.com/sling-git/sling/commit/23d368fe285f300b987a9cdf0837e7f3630230df

 upgrade Karaf to 4.0
 

 Key: SLING-4412
 URL: https://issues.apache.org/jira/browse/SLING-4412
 Project: Sling
  Issue Type: Improvement
  Components: Launchpad
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Launchpad Karaf Features 0.2.0, Launchpad Karaf 
 Integration Tests 0.2.0

 Attachments: SLING-4412.WIP.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4853) JobManager.findJobs should skip items that have been removed during the call

2015-07-08 Thread Marius Petria (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618731#comment-14618731
 ] 

Marius Petria commented on SLING-4853:
--

[~cziegeler] it seems that getPath no longer throws IllegalStateException 
(since [1]). I will close this issue.


[1] 
https://github.com/apache/sling/commit/b8e2eee099be61277882c4ca3101ba693debb343

 JobManager.findJobs should skip items that have been removed during the call
 

 Key: SLING-4853
 URL: https://issues.apache.org/jira/browse/SLING-4853
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Marius Petria
  Labels: event
 Attachments: SLING-4853.diff


 Sometimes under high load the iteration over job nodes can fail [1] because 
 the nodes could be already processed and removed. We could by more fault 
 tolerant when reading a resource and just skip it in case of failure.
 {noformat}
 Caused by: java.lang.IllegalStateException: Failed to retrieve path from Item:
 at 
 org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResource.getPath(JcrItemResource.java:82)
 at 
 org.apache.sling.event.impl.jobs.JobManagerImpl.findJobs(JobManagerImpl.java:659)
 at 
 com.day.cq.replication.impl.queue.ReplicationQueueImpl.entries(ReplicationQueueImpl.java:144)
 Caused by: javax.jcr.InvalidItemStateException: This item does not exist 
 anymore
 at 
 org.apache.jackrabbit.oak.jcr.delegate.ItemDelegate.checkAlive(ItemDelegate.java:85)
 at 
 org.apache.jackrabbit.oak.jcr.session.operation.ItemOperation.checkPreconditions(ItemOperation.java:34)
 at 
 org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:289)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:113)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.getPath(ItemImpl.java:153)
 {noformat}
 [1] 
 https://github.com/apache/sling/blob/29420e3482d610c1dd9741276388670474026bf6/bundles/extensions/event/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L662



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (SLING-4853) JobManager.findJobs should skip items that have been removed during the call

2015-07-08 Thread Marius Petria (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria reopened SLING-4853:
--

I partially misunderstood your comment :). We still need to fix Utility.readJob.

 JobManager.findJobs should skip items that have been removed during the call
 

 Key: SLING-4853
 URL: https://issues.apache.org/jira/browse/SLING-4853
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Marius Petria
  Labels: event
 Attachments: SLING-4853.diff


 Sometimes under high load the iteration over job nodes can fail [1] because 
 the nodes could be already processed and removed. We could by more fault 
 tolerant when reading a resource and just skip it in case of failure.
 {noformat}
 Caused by: java.lang.IllegalStateException: Failed to retrieve path from Item:
 at 
 org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResource.getPath(JcrItemResource.java:82)
 at 
 org.apache.sling.event.impl.jobs.JobManagerImpl.findJobs(JobManagerImpl.java:659)
 at 
 com.day.cq.replication.impl.queue.ReplicationQueueImpl.entries(ReplicationQueueImpl.java:144)
 Caused by: javax.jcr.InvalidItemStateException: This item does not exist 
 anymore
 at 
 org.apache.jackrabbit.oak.jcr.delegate.ItemDelegate.checkAlive(ItemDelegate.java:85)
 at 
 org.apache.jackrabbit.oak.jcr.session.operation.ItemOperation.checkPreconditions(ItemOperation.java:34)
 at 
 org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:289)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:113)
 at org.apache.jackrabbit.oak.jcr.session.ItemImpl.getPath(ItemImpl.java:153)
 {noformat}
 [1] 
 https://github.com/apache/sling/blob/29420e3482d610c1dd9741276388670474026bf6/bundles/extensions/event/src/main/java/org/apache/sling/event/impl/jobs/JobManagerImpl.java#L662



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4528) Moving to Oak

2015-07-08 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618161#comment-14618161
 ] 

Oliver Lietz commented on SLING-4528:
-

[~rombert], did you get in contact with oak-dev@jackrabbit because of embedding 
{{oak-jcr}}? Is it still the same with Oak 1.3?

 Moving to Oak
 -

 Key: SLING-4528
 URL: https://issues.apache.org/jira/browse/SLING-4528
 Project: Sling
  Issue Type: Task
  Components: JCR
Reporter: Oliver Lietz
  Labels: oak
 Fix For: JCR Oak Server 1.0.0


 _Apache Sling Oak Repository Server_ ({{org.apache.sling.jcr.oak.server}}) is 
 not released and contains some TODOs and {{JcrRepositoryHacks}}.
 What needs to be done for a first release, [~bdelacretaz] and [~mduerig]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4649) FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak

2015-07-08 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618252#comment-14618252
 ] 

Robert Munteanu commented on SLING-4649:


I think at least there should be a different task, the IT is not failing 
anymore :-) 

And (again), I don't see why we should do this change, as {{repository.home}} 
is used in multiple places in Oak to build configuration values. Why specify 
multiple configuration values when we can specify just one?

For the record:

{noformat}
oak-blob/src/main/java/org/apache/jackrabbit/oak/spi/blob/osgi/FileBlobStoreService.java:
private static final String PROP_HOME = repository.home;
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/blob/datastore/AbstractDataStoreService.java:
private static final String PROP_HOME = repository.home;
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentNodeStoreService.java:
public static final String DIRECTORY = repository.home;
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexProviderService.java:
public static final String REPOSITORY_HOME = repository.home;
{noformat}

 FullTextIndexingTest.testUploadedPdfIsIndexed fails on Oak
 --

 Key: SLING-4649
 URL: https://issues.apache.org/jira/browse/SLING-4649
 Project: Sling
  Issue Type: Bug
  Components: Launchpad, Oak
Reporter: Robert Munteanu
Assignee: Oliver Lietz
  Labels: sling-IT
 Fix For: Launchpad Builder 8


 Failed tests: 
   FullTextIndexingTest.testUploadedPdfIsIndexed:57 RetryLoop failed, 
 condition is false after 10 seconds: A document containing 'Excepteur' is 
 found under /FullTextIndexingTest
 This last worked on Jenkins with [sling-oak-it-1.7 
 42|https://builds.apache.org/view/S-Z/view/Sling/job/sling-oak-it-1.7/42/] - 
 r1673619, Apr 17, 2015 5:20:55 PM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling Scripting Thymeleaf 0.0.6

2015-07-08 Thread Carsten Ziegeler
+1

Carsten

Am 07.07.15 um 04:30 schrieb Oliver Lietz:
 Hi,
 
 We solved 8 issues in this release:
 https://issues.apache.org/jira/browse/SLING/fixforversion/12328646/
 
 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1289/
 
 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
 
 Usage:
 sh check_staged_release.sh 1289 /tmp/sling-staging
 
 Please vote to approve this release:
 
   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...
 
 This majority vote is open for at least 72 hours.
 
 Regards,
 O.
 
 


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Content Detection Support 1.0.2

2015-07-08 Thread Carsten Ziegeler
+1

Carsten

Am 06.07.15 um 07:04 schrieb Bertrand Delacretaz:
 Hi,
 
 This is the first release of this new module.
 
 Staging repository:
 https://repository.apache.org/content/repositories/orgapachesling-1288
 
 You can use this UNIX script to download the release and verify the 
 signatures:
 http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
 
 Usage:
 sh check_staged_release.sh 1288 /tmp/sling-staging
 
 Note that this module uses the just released Sling parent pom 24, you
 might need to get the sling-24 module from
 https://dist.apache.org/repos/dist/release/sling/ if it's not in Maven
 Central yet (but it should be there soon).
 
 Please vote to approve this release:
 
   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...
 
 This majority vote is open for at least 72 hours.
 
 -Bertrand
 


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Closed] (SLING-4485) JcrSystemUserValidator uses a non synchronized set

2015-07-08 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-4485.
---

 JcrSystemUserValidator uses a non synchronized set
 --

 Key: SLING-4485
 URL: https://issues.apache.org/jira/browse/SLING-4485
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 2.5.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 2.5.2


 The set used in JcrSystemUserValidator is a simply HashSet which might be 
 modified/read concurrently.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (SLING-4820) NoClassDefFoundError and ServiceException when using Sling with Oak 1.3.0

2015-07-08 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-4820.
---

 NoClassDefFoundError and ServiceException when using Sling with Oak 1.3.0
 -

 Key: SLING-4820
 URL: https://issues.apache.org/jira/browse/SLING-4820
 Project: Sling
  Issue Type: Bug
Affects Versions: JCR Resource 2.5.0
Reporter: Davide Giannella
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 2.5.2


 If you try to run Sling with the latest Oak 1.3.0 you get a couple of
 errors (see below) most probably due to the fact that in 1.3.0 Oak
 exported a different API.
 {noformat:title=List of changed packages in Oak}
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/api/jmx/package-info.java:@Version(2.0.0)
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/api/package-info.java:@Version(2.0)
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/package-info.java:@Version(2.0.0)
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/package-info.java:@Version(2.0.0)
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/query/package-info.java:@Version(2.0)
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/spi/gc/package-info.java:@Version(2.0.0)
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/spi/query/package-info.java:@Version(2.0.0)
 ./oak-core/src/main/java/org/apache/jackrabbit/oak/spi/security/user/package-info.java:@Version(2.0)
 ./oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/package-info.java:@Version(2.0.0)
 {noformat}
 {noformat:title=Error messages}
 17.06.2015 14:57:01.912 *ERROR* [FelixStartLevel] 
 org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProviderFactory 
 Unable to instantiate improved JCR Resource listener for Oak. Using fallback.
 java.lang.NoClassDefFoundError: 
 org/apache/jackrabbit/oak/plugins/observation/NodeObserver
   at java.lang.ClassLoader.defineClass1(Native Method)
   at java.lang.ClassLoader.defineClass(ClassLoader.java:800)
   at 
 org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.defineClass(BundleWiringImpl.java:2350)
   at 
 org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.findClass(BundleWiringImpl.java:2134)
   at 
 org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1526)
   at 
 org.apache.felix.framework.BundleWiringImpl.access$400(BundleWiringImpl.java:79)
   at 
 org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1998)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
   at 
 org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProviderFactory.activate(JcrResourceProviderFactory.java:150)
   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
   at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   at java.lang.reflect.Method.invoke(Method.java:606)
   at 
 org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
   at 
 org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:37)
   at 
 org.apache.felix.scr.impl.helper.BaseMethod$Resolved.invoke(BaseMethod.java:615)
   at 
 org.apache.felix.scr.impl.helper.BaseMethod.invoke(BaseMethod.java:499)
   at 
 org.apache.felix.scr.impl.helper.ActivateMethod.invoke(ActivateMethod.java:295)
   at 
 org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:302)
   at 
 org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:113)
   at 
 org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:832)
   at 
 org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:799)
   at 
 org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:749)
   at 
 org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:347)
   at 
 org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:247)
   at 
 org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:343)
   at org.apache.felix.framework.Felix.getService(Felix.java:3692)
   at 
 org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:470)
   at 
 org.apache.felix.scr.impl.manager.SingleRefPair.getServiceObject(SingleRefPair.java:72)
   at 
 

[jira] [Closed] (SLING-4566) Get array of namespace prefixes only once

2015-07-08 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-4566.
---

 Get array of namespace prefixes only once
 -

 Key: SLING-4566
 URL: https://issues.apache.org/jira/browse/SLING-4566
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Affects Versions: JCR Resource 2.5.0
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 2.5.2


 The JcrModifiableValueMap caches an array of namespace prefixes as this is 
 right now an expensive repository operation.
 Instead of doing this in each and every value map, we could do this just once 
 per resource provider.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (SLING-4588) JcrNodeResourceIterator : wrong paths generated when the parent resource is the root node.

2015-07-08 Thread Radu Cotescu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu closed SLING-4588.
---

 JcrNodeResourceIterator : wrong paths generated when the parent resource is 
 the root node.
 --

 Key: SLING-4588
 URL: https://issues.apache.org/jira/browse/SLING-4588
 Project: Sling
  Issue Type: Bug
  Components: ResourceResolver
Affects Versions: JCR Resource 2.5.0
Reporter: Guillaume Douillet
Assignee: Carsten Ziegeler
 Fix For: JCR Resource 2.5.2


 It seems the new versioning feature introduced by SLING-848 breaks the 
 JcrNodeResourceIterator when the parent resource is the repository root (/).
 This is due to this line in {{JcrNodeResourceIterator.getPath(Node node)}} :
 {code}
  path = String.format(%s/%s, parentPath, node.getName());
 {code}
 When parentPath is  {{/}} and the node name  {{apps}}, then the generated 
 path is  {{//apps}}.
 This test case illustrates the wrong behavior :
 {code:title=JcrNodeResourceIteratorTest.java}
 public void testRoot() throws RepositoryException {
 String path = /child;
 Node node = new MockNode(path);
 NodeIterator ni = new MockNodeIterator(new Node[] { node });
 JcrNodeResourceIterator ri = new JcrNodeResourceIterator(null, /, 
 null, ni, null, new PathMapperImpl());
 assertTrue(ri.hasNext());
 Resource res = ri.next();
 assertEquals(path, res.getPath());
 assertEquals(node.getPrimaryNodeType().getName(), 
 res.getResourceType());
 assertFalse(ri.hasNext());
 try {
 ri.next();
 fail(Expected no element in the iterator);
 } catch (NoSuchElementException nsee) {
 // expected
 }
 }
 {code}
 This test currently fails with {code}expected:/[]child but 
 was:/[/]child{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-4865) Add support for nt:linkedFile nodes

2015-07-08 Thread Radu Cotescu (JIRA)
Radu Cotescu created SLING-4865:
---

 Summary: Add support for nt:linkedFile nodes
 Key: SLING-4865
 URL: https://issues.apache.org/jira/browse/SLING-4865
 Project: Sling
  Issue Type: Improvement
Affects Versions: JCR Resource 2.5.2, Servlets Get 2.1.10
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: JCR Resource 2.5.4, Servlets GET 2.1.12


{{nt:linkedFile}} node based resources are not adapted to an {{InputStream}} in 
{{org.apache.sling.jcr.resource.internal.helper.jcr.JcrNodeResource}} or 
{{org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet}}, although 
these nodes behave exactly like {{nt:file}} nodes when the {{jcr:content}} 
property is set correctly.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-4866) JSP scripting engine performance degraded in org.apache.sling.scripting.jsp 2.1.6

2015-07-08 Thread Radu Cotescu (JIRA)
Radu Cotescu created SLING-4866:
---

 Summary: JSP scripting engine performance degraded in 
org.apache.sling.scripting.jsp 2.1.6
 Key: SLING-4866
 URL: https://issues.apache.org/jira/browse/SLING-4866
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting JSP 2.1.6
Reporter: Radu Cotescu
Priority: Critical
 Fix For: Scripting JSP 2.1.8


The commit applied in 
[r1629144|https://svn.apache.org/viewvc?view=revisionrevision=r1629144] seems 
to have affected the JSP scripting engine performance.

The Sightly JSP [performance 
tests|https://github.com/apache/sling/blob/trunk/bundles/scripting/sightly/testing-content/src/main/resources/SLING-INF/apps/sightlyperf/test/test.jsp]
 show a 5x degradation on my machine when compared to running the same tests on 
{{org.apache.sling.scripting.jsp}} 2.1.4.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-4866) JSP scripting engine performance degraded in org.apache.sling.scripting.jsp 2.1.6

2015-07-08 Thread Radu Cotescu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-4866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14618945#comment-14618945
 ] 

Radu Cotescu commented on SLING-4866:
-

[~cziegeler], could we somehow maintain the compilation consistency without 
imposing such a slow locking mechanism?

 JSP scripting engine performance degraded in org.apache.sling.scripting.jsp 
 2.1.6
 -

 Key: SLING-4866
 URL: https://issues.apache.org/jira/browse/SLING-4866
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting JSP 2.1.6
Reporter: Radu Cotescu
Priority: Critical
 Fix For: Scripting JSP 2.1.8


 The commit applied in 
 [r1629144|https://svn.apache.org/viewvc?view=revisionrevision=r1629144] 
 seems to have affected the JSP scripting engine performance.
 The Sightly JSP [performance 
 tests|https://github.com/apache/sling/blob/trunk/bundles/scripting/sightly/testing-content/src/main/resources/SLING-INF/apps/sightlyperf/test/test.jsp]
  show a 5x degradation on my machine when compared to running the same tests 
 on {{org.apache.sling.scripting.jsp}} 2.1.4.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Errorpage for the Sling Resource Editor

2015-07-08 Thread Sandro Boehme

Yeah! I've found the solution.
I've just have to send :sendError=true with the post request.

The only documentation I've found is the javadoc [1].
I think I could add the information about that parameter at the Special 
Parameters paragraph of the manipulating content page [2] like:

:sendError
Setting this parameter to true (case insensitive) allows to use custom 
error handling as described in the Errorhandling documentation [3]

If there is no veto I would do that.

There is already a test case for that:
ErrorHandlingTest.test_errorhandling_POST_operation_SlingPostServlet()
It sends a post to /apps/testNode and seem to use the resource type for 
the resolution of the error handler.


[1] - 
https://sling.apache.org/apidocs/sling7/org/apache/sling/servlets/post/SlingPostConstants.html#RP_SEND_ERROR


[2] - 
http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#special-parameters


[3] - 
https://sling.apache.org/documentation/the-sling-engine/errorhandling.html


Best,

Sandro

Am 06.07.15 um 16:00 schrieb Sandro Boehme:

Am 06.07.15 um 15:20 schrieb Sandro Boehme:

Hi Bertrand,

Am 06.07.15 um 14:25 schrieb Bertrand Delacretaz:

Hi Sandro,

On Mon, Jul 6, 2015 at 2:00 PM, Sandro Boehme sandro.boe...@gmx.de
wrote:

Am 06.07.15 um 11:16 schrieb Bertrand Delacretaz:

...debugging the
SlingServletResolver.handleError method should help as well


The processing flow does not seem to go through this method as the
debugger
does not stop there


The below example works for me, comparing with what you are doing
might help?

There are integration tests for this in ErrorHandlingTest [1] but they
dont seem to test the resource-specific error handlers - if you can
add some tests for that while investigating that would be great, of
course.

I'd be happy if I could do that.



$ curl -u admin:admin -Fsling:resourceType=xyz
http://localhost:8080/apps/xyz
...
 titleContent created /apps/xyz/title
...
$ echo '% if(true) throw new IllegalStateException(this cannot
work); %'  /tmp/xyz.jsp
$ curl -u admin:admin -T/tmp/xyz.jsp
http://localhost:8080/apps/xyz/xyz.jsp
$ echo 'This is the custom error handler' 
/tmp/IllegalStateException.jsp
$ curl -u admin:admin -T /tmp/IllegalStateException.jsp
http://localhost:8080/apps/xyz/IllegalStateException.jsp
$ curl http://localhost:8080/apps/xyz.html
This is the custom error handler

Yeah, it works for me as well! Thanks for this error page example it
runs through the handleError() methods as you wrote.
I'll use the time between some family celebrations to compare with my
code and let you and the list (archive) know about the results.

As a quick check I've added your error handler jsp to the resource
folder and added the throw statement to my page. It works and shows the
custom error page! Next I will check for the right exception and
resource type in my case.

Best,

Sandro






Eclipse Plugin does not work with AEM installed in a Context Path

2015-07-08 Thread Andreas Schaefer Sr.
Hi

I installed AEM 6.1 in the context path /aem with the -c option. Everything 
works fine but I cannot connect to that Repository with both the IntelliJ and 
the Eclipse plugin.

AEM Startup:

java -jar -Xmx1280m -XX:MaxPermSize=256m aem*.jar -c aem

CRX Explorer:

http://localhost:4502/aem/crx/explorer/index.jsp 
http://localhost:4502/aem/crx/explorer/index.jsp

When I try to connect the 
org.apache.sling.ide.jcr.RepositoryUtils.getRepositoryAddress() method fails to 
login and throws an DavException ‘Item not found’. Line 84 in version 
1.0.7-SNAPSHOT of Impl-Vlt.

The Context Path is set to /aem/ and the port is correct.

Repository Info: RepositoryInfo [username=admin, url=http://localhost:4502/aem/]

Any idea what I am doing wrong or what the context path must look like?

Cheers - Andy Schaefer