[jira] [Created] (SLING-5143) osgi-mock: MockBundleContext is not thread-safe when using iterators
Stefan Seifert created SLING-5143:
-
Summary: osgi-mock: MockBundleContext is not thread-safe when
using iterators
Key: SLING-5143
URL: https://issues.apache.org/jira/browse/SLING-5143
Project: Sling
Issue Type: Bug
Components: Testing
Affects Versions: Testing OSGi Mock 1.6.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Minor
Fix For: Testing OSGi Mock 1.6.2
SLING-4845 introduced synchronized wrappers for the sets, maps and a list used
internally by MockBundleContext to make it thread-safe.
this does not cover all cases e.g. when iterating over the set oder map,
sometimes errors like this still occur:
{noformat}
[Apache Sling JCR Resource Event Queue Processor for path '/'] WARN
org.apache.sling.jcr.resource.internal.JcrResourceListener -
processOsgiEventQueue: Unexpected problem processing event
{event.topics=org/apache/sling/api/resource/Resource/ADDED, userid=admin,
resourceAddedAttributes=[Ljava.lang.String;@68fbe319, path=/content}
java.util.ConcurrentModificationException
at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1207)
at java.util.TreeMap$KeyIterator.next(TreeMap.java:1261)
at
org.apache.sling.testing.mock.osgi.MockBundleContext.getServiceReferences(MockBundleContext.java:188)
at
org.apache.sling.testing.mock.osgi.MockBundleContext.getServiceReference(MockBundleContext.java:169)
at
org.apache.sling.jcr.resource.internal.JcrResourceListener.getResourceResolver(JcrResourceListener.java:353)
at
org.apache.sling.jcr.resource.internal.JcrResourceListener.processOsgiEventQueue(JcrResourceListener.java:392)
at
org.apache.sling.jcr.resource.internal.JcrResourceListener$1.run(JcrResourceListener.java:131)
at java.lang.Thread.run(Thread.java:745)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-5143) osgi-mock: MockBundleContext is not thread-safe when using iterators
[
https://issues.apache.org/jira/browse/SLING-5143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-5143.
---
Resolution: Fixed
Completed: At revision: 1708556
switched to ConcurrentSkipListSet, ConcurrentHashMap, ConcurrentLinkedQueue
> osgi-mock: MockBundleContext is not thread-safe when using iterators
>
>
> Key: SLING-5143
> URL: https://issues.apache.org/jira/browse/SLING-5143
> Project: Sling
> Issue Type: Bug
> Components: Testing
>Affects Versions: Testing OSGi Mock 1.6.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
> Labels: mocks
> Fix For: Testing OSGi Mock 1.6.2
>
>
> SLING-4845 introduced synchronized wrappers for the sets, maps and a list
> used internally by MockBundleContext to make it thread-safe.
> this does not cover all cases e.g. when iterating over the set oder map,
> sometimes errors like this still occur:
> {noformat}
> [Apache Sling JCR Resource Event Queue Processor for path '/'] WARN
> org.apache.sling.jcr.resource.internal.JcrResourceListener -
> processOsgiEventQueue: Unexpected problem processing event
> {event.topics=org/apache/sling/api/resource/Resource/ADDED, userid=admin,
> resourceAddedAttributes=[Ljava.lang.String;@68fbe319, path=/content}
> java.util.ConcurrentModificationException
> at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1207)
> at java.util.TreeMap$KeyIterator.next(TreeMap.java:1261)
> at
> org.apache.sling.testing.mock.osgi.MockBundleContext.getServiceReferences(MockBundleContext.java:188)
> at
> org.apache.sling.testing.mock.osgi.MockBundleContext.getServiceReference(MockBundleContext.java:169)
> at
> org.apache.sling.jcr.resource.internal.JcrResourceListener.getResourceResolver(JcrResourceListener.java:353)
> at
> org.apache.sling.jcr.resource.internal.JcrResourceListener.processOsgiEventQueue(JcrResourceListener.java:392)
> at
> org.apache.sling.jcr.resource.internal.JcrResourceListener$1.run(JcrResourceListener.java:131)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling Launchpad Builder version 8
On Tuesday 13 October 2015 17:02:08 Robert Munteanu wrote: > Hi, > > We solved 51 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12328747 +1 O.
[jira] [Commented] (SLING-5099) Create 'New and Noteworthy' page for Sling 8
[ https://issues.apache.org/jira/browse/SLING-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956542#comment-14956542 ] Robert Munteanu commented on SLING-5099: Picked up changelog based on SVN tags / Jira issues in [r1708557|https://svn.apache.org/r1708557] > Create 'New and Noteworthy' page for Sling 8 > > > Key: SLING-5099 > URL: https://issues.apache.org/jira/browse/SLING-5099 > Project: Sling > Issue Type: Sub-task > Components: General >Reporter: Robert Munteanu >Assignee: Robert Munteanu > > WIP at https://cwiki.apache.org/confluence/display/SLING/Sling+8+release+notes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5099) Create 'New and Noteworthy' page for Sling 8
[ https://issues.apache.org/jira/browse/SLING-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956545#comment-14956545 ] Robert Munteanu commented on SLING-5099: Attached [^changelog.txt] with list of affected issues for updated Sling artifacts > Create 'New and Noteworthy' page for Sling 8 > > > Key: SLING-5099 > URL: https://issues.apache.org/jira/browse/SLING-5099 > Project: Sling > Issue Type: Sub-task > Components: General >Reporter: Robert Munteanu >Assignee: Robert Munteanu > Attachments: changelog.txt > > > WIP at https://cwiki.apache.org/confluence/display/SLING/Sling+8+release+notes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-5099) Create 'New and Noteworthy' page for Sling 8
[ https://issues.apache.org/jira/browse/SLING-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-5099: --- Attachment: changelog.txt > Create 'New and Noteworthy' page for Sling 8 > > > Key: SLING-5099 > URL: https://issues.apache.org/jira/browse/SLING-5099 > Project: Sling > Issue Type: Sub-task > Components: General >Reporter: Robert Munteanu >Assignee: Robert Munteanu > Attachments: changelog.txt > > > WIP at https://cwiki.apache.org/confluence/display/SLING/Sling+8+release+notes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5099) Create 'New and Noteworthy' page for Sling 8
[ https://issues.apache.org/jira/browse/SLING-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956616#comment-14956616 ] Robert Munteanu commented on SLING-5099: Final draft now at https://cwiki.apache.org/confluence/display/SLING/Sling+8+release+notes ; this is the one I will likely use for the release notes. > Create 'New and Noteworthy' page for Sling 8 > > > Key: SLING-5099 > URL: https://issues.apache.org/jira/browse/SLING-5099 > Project: Sling > Issue Type: Sub-task > Components: General >Reporter: Robert Munteanu >Assignee: Robert Munteanu > Attachments: changelog.txt > > > WIP at https://cwiki.apache.org/confluence/display/SLING/Sling+8+release+notes -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-5141) Expose Oak's Login Failures in Authenticator Reason
[ https://issues.apache.org/jira/browse/SLING-5141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso resolved SLING-5141. -- Resolution: Fixed Fix Version/s: Auth Core 1.3.12 applying patch from Dominique Jaeggi in rev. 1708557 thanks > Expose Oak's Login Failures in Authenticator Reason > --- > > Key: SLING-5141 > URL: https://issues.apache.org/jira/browse/SLING-5141 > Project: Sling > Issue Type: Improvement >Reporter: Dominique Jäggi >Assignee: Antonio Sanso > Fix For: Auth Core 1.3.12 > > Attachments: > SLING-5141_-_Expose_Oak_s_Login_Failures_in_Authenticator_Reason.patch > > > currently not all of the _LoginException_ variants are exposed by the > _SlingAuthenticator_ in its reason parameter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Build failed in Jenkins: sling-contrib-1.7 #459
On Wed, 2015-10-14 at 10:51 +, Apache Jenkins Server wrote: > Waiting for Jenkins to finish collecting data > [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven > -plugin:4.0.2:kar (features-create-kar) on project > org.apache.sling.launchpad.karaf-features: Failed to create archive: > Could not find artifact org.apache.jackrabbit:oak-core:jar:1.4 > -SNAPSHOT in Nexus (http://repository.apache.org/snapshots) I think we should not depend on external snasphots. Robert
Re: Build failed in Jenkins: sling-contrib-1.7 #459
On Wednesday 14 October 2015 13:58:18 Robert Munteanu wrote: > On Wed, 2015-10-14 at 10:51 +, Apache Jenkins Server wrote: > > Waiting for Jenkins to finish collecting data > > [ERROR] Failed to execute goal org.apache.karaf.tooling:karaf-maven > > -plugin:4.0.2:kar (features-create-kar) on project > > org.apache.sling.launchpad.karaf-features: Failed to create archive: > > Could not find artifact org.apache.jackrabbit:oak-core:jar:1.4 > > -SNAPSHOT in Nexus (http://repository.apache.org/snapshots) > > I think we should not depend on external snasphots. Agree, back to Oak 1.3.7 in r1708584. O. > Robert
[jira] [Commented] (SLING-5117) Reuse PrintWriter to avoid initialisation overhead
[ https://issues.apache.org/jira/browse/SLING-5117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14956786#comment-14956786 ] Joel Richard commented on SLING-5117: - [~cziegeler], do you think the problem could have been the following one? https://bz.apache.org/bugzilla/show_bug.cgi?id=50228 I have already quickly tested the pool and at a first glance it looked fine. Before the PageContext is reused, it resets the internal state of it. Since it resets even the internal state of the JspWriter, it can reuse the same object and therefore we could also reuse the PrintWriter. I don't see a reason why this should be a problem for JSPs/lead to memory leaks (unless there are further bugs similar to #50228). > Reuse PrintWriter to avoid initialisation overhead > -- > > Key: SLING-5117 > URL: https://issues.apache.org/jira/browse/SLING-5117 > Project: Sling > Issue Type: Improvement > Components: Scripting >Reporter: Joel Richard >Priority: Minor > Labels: performance > > Surprisingly, java.io.PrintWriter is relatively expensive to initialise > because of the AccessController.doPrivileged call in the constructor. Right > now, it initialises for each include a new PrintWriter which costs 2-3% > rendering time. > In order to avoid this overhead, I would suggest to fix SLING-1284 properly > (as far as I have seen there is a real fix in Tomcat) and create a reusable > PrintWriter in PageContextImpl together with the JspWriter. In addition, the > OnDemandWriterResponse must be adjusted to not create a new PrintWriter. > Maybe, all the OnDemand* classes could also just be removed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
On Mon, 2015-10-12 at 13:49 +, Nicolas Peltier wrote: > Hi, > > this thread is about voting for the acceptation of sling pipes > donation, tracked in SLING-5134. > > An archive containing the contribution is attached to SLING-5134, > shasum 7b199133ed12e915fd7c51410d8f15ae86e08da4. HEAD is viewable on > github at [0] > > Please cast your votes. +1 . Downloaded the zip, verified that checksums match. Rat checks are OK, build passes (with -DskipTests due to one test failure, but that should not block the donation IMO). Robert signature.asc Description: This is a digitally signed message part
[jira] [Created] (SLING-5144) Update local launchpad references to 8 or 9-SNAPSHOT
Robert Munteanu created SLING-5144: -- Summary: Update local launchpad references to 8 or 9-SNAPSHOT Key: SLING-5144 URL: https://issues.apache.org/jira/browse/SLING-5144 Project: Sling Issue Type: Sub-task Components: Launchpad Reporter: Robert Munteanu Assignee: Robert Munteanu * testing and testing-war should reference 9-SNAPSHOT as soon as the release vote starts * other projects depending on 8-SNAPSHOT should switch to 8 once the release vote is complete -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5145) DiscoveryServiceImpl imports private class from discovery-commons
[
https://issues.apache.org/jira/browse/SLING-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957035#comment-14957035
]
Robert Munteanu commented on SLING-5145:
[~egli] - is this something that should be fixed?
> DiscoveryServiceImpl imports private class from discovery-commons
> -
>
> Key: SLING-5145
> URL: https://issues.apache.org/jira/browse/SLING-5145
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Discovery Impl 1.1.10
>Reporter: Robert Munteanu
>
> {code:java}src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceImpl.java:import
>
> org.apache.sling.discovery.commons.providers.impl.ViewStateManagerFactory{code}
> This prevents the latest version of the discovery.impl from being deployed in
> the Launchpad, even with the discovery.commons bundle alongside it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-5145) DiscoveryServiceImpl imports private class from discovery-commons
Robert Munteanu created SLING-5145:
--
Summary: DiscoveryServiceImpl imports private class from
discovery-commons
Key: SLING-5145
URL: https://issues.apache.org/jira/browse/SLING-5145
Project: Sling
Issue Type: Bug
Components: Extensions
Affects Versions: Discovery Impl 1.1.10
Reporter: Robert Munteanu
{code:java}src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceImpl.java:import
org.apache.sling.discovery.commons.providers.impl.ViewStateManagerFactory{code}
This prevents the latest version of the discovery.impl from being deployed in
the Launchpad, even with the discovery.commons bundle alongside it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-5145) DiscoveryServiceImpl imports private class from discovery-commons
[
https://issues.apache.org/jira/browse/SLING-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957039#comment-14957039
]
Stefan Egli commented on SLING-5145:
[~rombert], thanks for noticing. I'll have a look. 'discovery.impl trunk' is
anyway currently under construction, so you'd have to switch back to 1.1.8,
that one should work fine though.
> DiscoveryServiceImpl imports private class from discovery-commons
> -
>
> Key: SLING-5145
> URL: https://issues.apache.org/jira/browse/SLING-5145
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Discovery Impl 1.1.10
>Reporter: Robert Munteanu
>
> {code:java}src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceImpl.java:import
>
> org.apache.sling.discovery.commons.providers.impl.ViewStateManagerFactory{code}
> This prevents the latest version of the discovery.impl from being deployed in
> the Launchpad, even with the discovery.commons bundle alongside it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-5145) DiscoveryServiceImpl imports private class from discovery-commons
[
https://issues.apache.org/jira/browse/SLING-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957046#comment-14957046
]
Robert Munteanu commented on SLING-5145:
Yup, I switched back to 1.1.8. I was just looking to see which projects have
changes since the last release to add them to the launchpad, as it's better IMO
to have them tested as part of the launchpad before the release and not after
> DiscoveryServiceImpl imports private class from discovery-commons
> -
>
> Key: SLING-5145
> URL: https://issues.apache.org/jira/browse/SLING-5145
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Discovery Impl 1.1.10
>Reporter: Robert Munteanu
>
> {code:java}src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceImpl.java:import
>
> org.apache.sling.discovery.commons.providers.impl.ViewStateManagerFactory{code}
> This prevents the latest version of the discovery.impl from being deployed in
> the Launchpad, even with the discovery.commons bundle alongside it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-5144) Update local launchpad references to 8 or 9-SNAPSHOT
[ https://issues.apache.org/jira/browse/SLING-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957050#comment-14957050 ] Robert Munteanu commented on SLING-5144: * https://svn.apache.org/r1708608 - testing and testing-war now running against 9-SNASPHOT > Update local launchpad references to 8 or 9-SNAPSHOT > > > Key: SLING-5144 > URL: https://issues.apache.org/jira/browse/SLING-5144 > Project: Sling > Issue Type: Sub-task > Components: Launchpad >Reporter: Robert Munteanu >Assignee: Robert Munteanu > > * testing and testing-war should reference 9-SNAPSHOT as soon as the release > vote starts > * other projects depending on 8-SNAPSHOT should switch to 8 once the release > vote is complete -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-5144) Update local launchpad references to 8 or 9-SNAPSHOT
[
https://issues.apache.org/jira/browse/SLING-5144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957059#comment-14957059
]
Robert Munteanu commented on SLING-5144:
{noformat}bundles/scripting/sightly/testing/src/main/provisioning/model.txt:
org.apache.sling/org.apache.sling.launchpad/8-SNAPSHOT/slingstart
contrib/crankstart/launcher/src/test/resources/sling-launchpad.txt:
org.apache.sling/org.apache.sling.launchpad/8-SNAPSHOT/txt/slingfeature
contrib/extensions/bgservlets/testing/src/main/provisioning/test-model.txt:
org.apache.sling/org.apache.sling.launchpad/8-SNAPSHOT/slingstart
contrib/launchpad/testing/src/main/provisioning/model.txt:
org.apache.sling/org.apache.sling.launchpad/8-SNAPSHOT/slingstart{noformat}
> Update local launchpad references to 8 or 9-SNAPSHOT
>
>
> Key: SLING-5144
> URL: https://issues.apache.org/jira/browse/SLING-5144
> Project: Sling
> Issue Type: Sub-task
> Components: Launchpad
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>
> * testing and testing-war should reference 9-SNAPSHOT as soon as the release
> vote starts
> * other projects depending on 8-SNAPSHOT should switch to 8 once the release
> vote is complete
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
out of curiosity, can you tell me which one of the tests failed? (it doesn’t on mine) Nicolas > On 14 Oct 2015, at 14:57, Robert Munteanu wrote: > > On Mon, 2015-10-12 at 13:49 +, Nicolas Peltier wrote: >> Hi, >> >> this thread is about voting for the acceptation of sling pipes >> donation, tracked in SLING-5134. >> >> An archive containing the contribution is attached to SLING-5134, >> shasum 7b199133ed12e915fd7c51410d8f15ae86e08da4. HEAD is viewable on >> github at [0] >> >> Please cast your votes. > > +1 . > > Downloaded the zip, verified that checksums match. > > Rat checks are OK, build passes (with -DskipTests due to one test > failure, but that should not block the donation IMO). > > Robert
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
On Wed, 2015-10-14 at 15:17 +, Nicolas Peltier wrote: > out of curiosity, can you tell me which one of the tests failed? (it > doesn’t on mine) testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time elapsed: 0.085 sec <<< FAILURE! java.lang.AssertionError: computed expression have testSum script's functionavailable expected: java.lang.Integer<3> but was: java.lang.Long<3> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.apache.sling.pipes.PipeBindingsTest.testAdditionalScript(PipeBindin gsTest.java:101) BTW, the build previously passed due to my having configured additional Maven repositories, but does not build with default maven configurations as it contains references to unavailable artifacts: [ERROR] Failed to execute goal on project org.apache.sling.pipes: Could not resolve dependencies for project org.apache.sling:org.apache.sling.pipes:bundle:0.0.8-SNAPSHOT: Failure to find org.apache.sling:org.apache.sling.api:jar:2.4.3-R1488084 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1] I therefore withdraw my vote and suggest that you re-attach an archive with the proper dependencies and restart the test. Thanks, Robert signature.asc Description: This is a digitally signed message part
[jira] [Assigned] (SLING-5145) DiscoveryServiceImpl imports private class from discovery-commons
[
https://issues.apache.org/jira/browse/SLING-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli reassigned SLING-5145:
--
Assignee: Stefan Egli
> DiscoveryServiceImpl imports private class from discovery-commons
> -
>
> Key: SLING-5145
> URL: https://issues.apache.org/jira/browse/SLING-5145
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Discovery Impl 1.1.8
>Reporter: Robert Munteanu
>Assignee: Stefan Egli
> Fix For: Discovery Impl 1.1.10
>
>
> {code:java}src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceImpl.java:import
>
> org.apache.sling.discovery.commons.providers.impl.ViewStateManagerFactory{code}
> This prevents the latest version of the discovery.impl from being deployed in
> the Launchpad, even with the discovery.commons bundle alongside it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-5145) DiscoveryServiceImpl imports private class from discovery-commons
[
https://issues.apache.org/jira/browse/SLING-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-5145:
---
Fix Version/s: Discovery Impl 1.1.10
> DiscoveryServiceImpl imports private class from discovery-commons
> -
>
> Key: SLING-5145
> URL: https://issues.apache.org/jira/browse/SLING-5145
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Discovery Impl 1.1.8
>Reporter: Robert Munteanu
> Fix For: Discovery Impl 1.1.10
>
>
> {code:java}src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceImpl.java:import
>
> org.apache.sling.discovery.commons.providers.impl.ViewStateManagerFactory{code}
> This prevents the latest version of the discovery.impl from being deployed in
> the Launchpad, even with the discovery.commons bundle alongside it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-5145) DiscoveryServiceImpl imports private class from discovery-commons
[
https://issues.apache.org/jira/browse/SLING-5145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-5145:
---
Affects Version/s: (was: Discovery Impl 1.1.10)
Discovery Impl 1.1.8
> DiscoveryServiceImpl imports private class from discovery-commons
> -
>
> Key: SLING-5145
> URL: https://issues.apache.org/jira/browse/SLING-5145
> Project: Sling
> Issue Type: Bug
> Components: Extensions
>Affects Versions: Discovery Impl 1.1.8
>Reporter: Robert Munteanu
> Fix For: Discovery Impl 1.1.10
>
>
> {code:java}src/main/java/org/apache/sling/discovery/impl/DiscoveryServiceImpl.java:import
>
> org.apache.sling.discovery.commons.providers.impl.ViewStateManagerFactory{code}
> This prevents the latest version of the discovery.impl from being deployed in
> the Launchpad, even with the discovery.commons bundle alongside it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
Thanks Robert, will fix that and update the ticket then :-) Nicolas > On 14 Oct 2015, at 17:23, Robert Munteanu wrote: > > On Wed, 2015-10-14 at 15:17 +, Nicolas Peltier wrote: >> out of curiosity, can you tell me which one of the tests failed? (it >> doesn’t on mine) > testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time > elapsed: 0.085 sec <<< FAILURE! > > java.lang.AssertionError: computed expression have testSum script's > functionavailable expected: java.lang.Integer<3> but was: > java.lang.Long<3> >at org.junit.Assert.fail(Assert.java:88) >at org.junit.Assert.failNotEquals(Assert.java:743) >at org.junit.Assert.assertEquals(Assert.java:118) >at > org.apache.sling.pipes.PipeBindingsTest.testAdditionalScript(PipeBindin > gsTest.java:101) > > BTW, the build previously passed due to my having configured additional > Maven repositories, but does not build with default maven > configurations as it contains references to unavailable artifacts: > > [ERROR] Failed to execute goal on project org.apache.sling.pipes: Could > not resolve dependencies for project > org.apache.sling:org.apache.sling.pipes:bundle:0.0.8-SNAPSHOT: Failure > to find org.apache.sling:org.apache.sling.api:jar:2.4.3-R1488084 in > https://repo.maven.apache.org/maven2 was cached in the local > repository, resolution will not be reattempted until the update > interval of central has elapsed or updates are forced -> [Help 1] > > I therefore withdraw my vote and suggest that you re-attach an archive > with the proper dependencies and restart the test. > > Thanks, > > Robert
[jira] [Commented] (SLING-4603) discovery.oak: oak-based discovery implementation
[
https://issues.apache.org/jira/browse/SLING-4603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957246#comment-14957246
]
Stefan Egli commented on SLING-4603:
scrap that - the bundle is going to be {{discovery.base}} - as it contains both
connector- and properties-support. The idea is to move as much as possible from
{{discovery.impl}} and {{discovery.oak}} into {{discovery.base}} - except where
it even fits into {{discovery.commons}}.
In contrast, {{discovery.commons}} is targeted to third-party based
implementations like {{discovery.zk}}/{{discovery.etcd}}/etc too - all of which
will likely not to base on {{discovery.base}}
> discovery.oak: oak-based discovery implementation
> -
>
> Key: SLING-4603
> URL: https://issues.apache.org/jira/browse/SLING-4603
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>
> When discovery is used in a stack based on jackrabbit oak as the repository,
> the current way of discoving instances somewhat sounds like duplicating work:
> oak, or more precisely documentnodestore, itself has a low-level [lease
> mechanism|http://jackrabbit.apache.org/oak/docs/nodestore/documentmk.html]
> where it stores information about the cluster nodes including a {{leaseEnd}}
> indicating at what time others can consider a particular node as
> dead/crashed. This corresponds pretty much to the discovery.impl heartbeat
> mechanism. And in a stack which is built ontop of oak-documentMk, we could be
> making use of this fact and delegate the decision about whether a node in a
> cluster is alive or not to the oak layer. Also, with OAK-2597 the relevant
> information: {{ActiveClusterNodes}} is nicely exposed via JMX - so that can
> become the new source of truth defining the cluster view.
> When replacing discovery-owned heartbeats with oak-owned ones, there is one
> important detail to be watched out for: it can no longer easily be determined
> from another instance in the cluster, whether it has this new discovery
> bundle activated or not. Hence it is not given that when a voting happens,
> that all {{active}} nodes (as reported by oak-documentMk) are actually going
> to respond. So the 'silent instance due to deactivated discovery bundle' case
> needs special attention/handling.
> Other than that, given the normal case of all {{active}} nodes having the
> bundle activated, the voting mechanism can stay the same as in
> discovery.impl. The topology connectors can be treated the same too (by
> storing announcements to their respective
> {{/var/discovery/clusterInstances//announcements/}}
> node. The properties can be handled the same too (by storing to
> {{/properties}} node. Only thing that gets replaced is the {{heartbeats}}.
> Note that in order for such an oak-based discovery.impl this oak-lease
> mechanism must be very robust (it should be so by its own interest already).
> However, there are currently a few issues that should probably first be
> resolved until discovery can be based on this: OAK-2739, OAK-2682 and
> OAK-2681 are currently known in this area.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SLING-5134) Donation of sling pipes
[ https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-5134: --- Attachment: (was: sling-pipes.tar.gz) > Donation of sling pipes > --- > > Key: SLING-5134 > URL: https://issues.apache.org/jira/browse/SLING-5134 > Project: Sling > Issue Type: New Feature > Components: Extensions >Reporter: Nicolas Peltier > > This issue tracks the donation of sling pipes as announced in [0]. Code & > documentation are there [1] https://github.com/npeltier/sling-pipes, two open > issues for now are tracked there a well [2] > [0] http://sling.markmail.org/thread/n6yr6upogruem7qp > [1] http://github.com/npeltier/sling-pipes > [2] https://github.com/npeltier/sling-pipes/issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-5134) Donation of sling pipes
[ https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-5134: --- Attachment: sling-pipes.tar.gz > Donation of sling pipes > --- > > Key: SLING-5134 > URL: https://issues.apache.org/jira/browse/SLING-5134 > Project: Sling > Issue Type: New Feature > Components: Extensions >Reporter: Nicolas Peltier > Attachments: sling-pipes.tar.gz > > > This issue tracks the donation of sling pipes as announced in [0]. Code & > documentation are there [1] https://github.com/npeltier/sling-pipes, two open > issues for now are tracked there a well [2] > [0] http://sling.markmail.org/thread/n6yr6upogruem7qp > [1] http://github.com/npeltier/sling-pipes > [2] https://github.com/npeltier/sling-pipes/issues -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] accept the donation of sling pipes tracked in SLING-5134
updated tarball & shasum, with additional bugfix. for your test issue, which version of java are you running? > On 14 Oct 2015, at 18:01, Nicolas Peltier wrote: > > Thanks Robert, will fix that and update the ticket then :-) > > Nicolas >> On 14 Oct 2015, at 17:23, Robert Munteanu wrote: >> >> On Wed, 2015-10-14 at 15:17 +, Nicolas Peltier wrote: >>> out of curiosity, can you tell me which one of the tests failed? (it >>> doesn’t on mine) >> testAdditionalScript(org.apache.sling.pipes.PipeBindingsTest) Time >> elapsed: 0.085 sec <<< FAILURE! >> >> java.lang.AssertionError: computed expression have testSum script's >> functionavailable expected: java.lang.Integer<3> but was: >> java.lang.Long<3> >> at org.junit.Assert.fail(Assert.java:88) >> at org.junit.Assert.failNotEquals(Assert.java:743) >> at org.junit.Assert.assertEquals(Assert.java:118) >> at >> org.apache.sling.pipes.PipeBindingsTest.testAdditionalScript(PipeBindin >> gsTest.java:101) >> >> BTW, the build previously passed due to my having configured additional >> Maven repositories, but does not build with default maven >> configurations as it contains references to unavailable artifacts: >> >> [ERROR] Failed to execute goal on project org.apache.sling.pipes: Could >> not resolve dependencies for project >> org.apache.sling:org.apache.sling.pipes:bundle:0.0.8-SNAPSHOT: Failure >> to find org.apache.sling:org.apache.sling.api:jar:2.4.3-R1488084 in >> https://repo.maven.apache.org/maven2 was cached in the local >> repository, resolution will not be reattempted until the update >> interval of central has elapsed or updates are forced -> [Help 1] >> >> I therefore withdraw my vote and suggest that you re-attach an archive >> with the proper dependencies and restart the test. >> >> Thanks, >> >> Robert >
[jira] [Comment Edited] (SLING-5134) Donation of sling pipes
[
https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953128#comment-14953128
]
Nicolas Peltier edited comment on SLING-5134 at 10/14/15 7:25 PM:
--
(edited) shasum gives {Code}4ec1ad6c725b2d0a78dfb1fe89cbc7dc89494654{Code}
was (Author: npeltier):
shasum gives {Code}7b199133ed12e915fd7c51410d8f15ae86e08da4{Code}
> Donation of sling pipes
> ---
>
> Key: SLING-5134
> URL: https://issues.apache.org/jira/browse/SLING-5134
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
>Reporter: Nicolas Peltier
> Attachments: sling-pipes.tar.gz
>
>
> This issue tracks the donation of sling pipes as announced in [0]. Code &
> documentation are there [1] https://github.com/npeltier/sling-pipes, two open
> issues for now are tracked there a well [2]
> [0] http://sling.markmail.org/thread/n6yr6upogruem7qp
> [1] http://github.com/npeltier/sling-pipes
> [2] https://github.com/npeltier/sling-pipes/issues
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Sling pipes failing test (Was: [VOTE] accept the donation of sling pipes tracked in SLING-5134)
On Wed, 2015-10-14 at 19:26 +, Nicolas Peltier wrote: > for your test issue, which version of java are you running? $ mvn -v Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04- 22T14:57:37+03:00) Maven home: /usr/share/java/maven Java version: 1.8.0_60, vendor: Oracle Corporation Java home: /usr/lib64/jvm/java-1.8.0-openjdk-1.8.0/jre Default locale: en_US, platform encoding: UTF-8 OS name: "linux", version: "4.2.1-1-desktop", arch: "amd64", family: "unix" Robert
