[jira] [Comment Edited] (SLING-5134) Donation of sling pipes

2015-10-17 Thread Nicolas Peltier (JIRA) 

[ 
https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953128#comment-14953128
 ] 

Nicolas Peltier edited comment on SLING-5134 at 10/17/15 8:49 AM:
--

fixed test issue {Code}fdf8052425fa6a66199f8fd5bec8bf6f420983b1{Code}


was (Author: npeltier):
(edited) shasum gives {Code}68eee1fa87784ea841c80e88b344ec92deb0f848{Code}

> Donation of sling pipes
> ---
>
> Key: SLING-5134
> URL: https://issues.apache.org/jira/browse/SLING-5134
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Nicolas Peltier
> Attachments: sling-pipes.tar.gz
>
>
> This issue tracks the donation of sling pipes as announced in [0]. Code & 
> documentation are there [1] https://github.com/npeltier/sling-pipes, two open 
> issues for now are tracked there a well [2]
> [0] http://sling.markmail.org/thread/n6yr6upogruem7qp
> [1] http://github.com/npeltier/sling-pipes
> [2] https://github.com/npeltier/sling-pipes/issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (SLING-5134) Donation of sling pipes

2015-10-17 Thread Nicolas Peltier (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-5134:
---
Attachment: sling-pipes.tar.gz

> Donation of sling pipes
> ---
>
> Key: SLING-5134
> URL: https://issues.apache.org/jira/browse/SLING-5134
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Nicolas Peltier
> Attachments: sling-pipes.tar.gz
>
>
> This issue tracks the donation of sling pipes as announced in [0]. Code & 
> documentation are there [1] https://github.com/npeltier/sling-pipes, two open 
> issues for now are tracked there a well [2]
> [0] http://sling.markmail.org/thread/n6yr6upogruem7qp
> [1] http://github.com/npeltier/sling-pipes
> [2] https://github.com/npeltier/sling-pipes/issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[VOTE] accept the donation of sling pipes tracked in SLING-5134

2015-10-17 Thread Nicolas Peltier 
Hi,

fixed the test issue for both java version (i should say nashorn versions) 
thanks to Robert’s patch. 
new version is attached, shasum is fdf8052425fa6a66199f8fd5bec8bf6f420983b1, 
please vote

Nicolas

> On 15 Oct 2015, at 14:42, Nicolas Peltier  wrote:
> 
> yes, closing this thread now, will resend a vote once it’s fixed. Sorry about 
> that.
> 
> Nicolas
>> On 15 Oct 2015, at 14:34, Carsten Ziegeler  wrote:
>> 
>> Can we maybe stop this vote thread, resolve the issues and then start a
>> clean vote thread? Otherwise tracking this is very hard.
>> 
>> Thanks
>> Carsten
>> -- 
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziege...@apache.org
>

Re: Moving tooling/maven out of the main reactor?

2015-10-17 Thread Julian Sedding 
Hi Robert

Your suggestions sound sensible and shouldn't hurt in any way.

In addition to your points above, we could consider, purely for
convenience, adding a profile to the main reactor pom that builds
tooling/maven.

Regards
Julian


On Fri, Oct 16, 2015 at 10:31 PM, Robert Munteanu  wrote:
> Hi,
>
> When releasing the Maven archetypes I was reminded that we build all
> the Maven stuff with the main reactor POM.
>
> IMO the tooling part is not part of the Sling product like the bundles
> / tests / launchpads. They participate in building the product, but
> they are not needed in the same reactor. Also, we can't consume
> SNASPHOT Maven plugins as part of the same reactor. So I would suggest
> that we move the tooling/maven out of the main reactor, with the
> following changes:
>
> 1. Remove all tooling/maven stuff out of the main reactor
> 2. Create a reactor pom for tooling/maven which builds the plugins
> 3. Create a reactor pom for tooling/maven/archetypes which builds the
> archetypes
> 4. Include tooling/maven/archetypes as a module of tooling/maven
> 5. Create a separate sling-tooling-trunk-1.7 build on Jekins
>
> Advantages:
>
> 1. Slightly faster builds ( have not really measured )
> 2. The main reactor does not break when the tooling/maven one breaks (
> like I did earlier :-) )
>
> Thoughts?
>
> Robert

[jira] [Updated] (SLING-5134) Donation of sling pipes

2015-10-17 Thread Nicolas Peltier (JIRA) 

 [ 
https://issues.apache.org/jira/browse/SLING-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-5134:
---
Attachment: (was: sling-pipes.tar.gz)

> Donation of sling pipes
> ---
>
> Key: SLING-5134
> URL: https://issues.apache.org/jira/browse/SLING-5134
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Nicolas Peltier
>
> This issue tracks the donation of sling pipes as announced in [0]. Code & 
> documentation are there [1] https://github.com/npeltier/sling-pipes, two open 
> issues for now are tracked there a well [2]
> [0] http://sling.markmail.org/thread/n6yr6upogruem7qp
> [1] http://github.com/npeltier/sling-pipes
> [2] https://github.com/npeltier/sling-pipes/issues



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Moving tooling/maven out of the main reactor?

2015-10-17 Thread Carsten Ziegeler 
Am 16.10.15 um 22:31 schrieb Robert Munteanu:
> Hi,
> 
> When releasing the Maven archetypes I was reminded that we build all
> the Maven stuff with the main reactor POM.
> 
> IMO the tooling part is not part of the Sling product like the bundles
> / tests / launchpads. They participate in building the product, but
> they are not needed in the same reactor. Also, we can't consume
> SNASPHOT Maven plugins as part of the same reactor. So I would suggest
> that we move the tooling/maven out of the main reactor, with the
> following changes:
> 
> 1. Remove all tooling/maven stuff out of the main reactor
> 2. Create a reactor pom for tooling/maven which builds the plugins
> 3. Create a reactor pom for tooling/maven/archetypes which builds the
> archetypes
> 4. Include tooling/maven/archetypes as a module of tooling/maven
> 5. Create a separate sling-tooling-trunk-1.7 build on Jekins
> 
> Advantages:
> 
> 1. Slightly faster builds ( have not really measured )
> 2. The main reactor does not break when the tooling/maven one breaks (
> like I did earlier :-) )
> 
> Thoughts?
> 
Sounds good to me

Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Archetype Parent version 4, Apache Sling Bundle Archetype version 1.0.4, Apache Sling JCRInstall Bundle Archetype 1.0.4, Apache Sling Initial Content Archetype 1.0.4, A

2015-10-17 Thread Carsten Ziegeler 
+1

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org



signature.asc
Description: OpenPGP digital signature