[GitHub] sling pull request: SLING-5266 Export org.mozilla.javascript.ast p...

2015-12-16 Thread welcomemandeep
Github user welcomemandeep closed the pull request at:

https://github.com/apache/sling/pull/110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (SLING-5266) Exporting org.mozilla.javascript.ast package in org.apache.sling.scripting.javascript bundle

2015-12-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061680#comment-15061680
 ] 

ASF GitHub Bot commented on SLING-5266:
---

GitHub user welcomemandeep opened a pull request:

https://github.com/apache/sling/pull/118

SLING-5266 Export org.mozilla.javascript.ast package

Currently Sling Scripting Javascript Support only exports 
org.mozilla.javascript package which is sufficient for evaluating javascript 
using Rhino but to convert expressions to  parsed AST we need 
org.mozilla.javascript.ast

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/welcomemandeep/sling trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit 4c5f97d1b478208afa38baea04db170a7b76687c
Author: Mandeep Gandhi 
Date:   2015-12-17T07:54:40Z

SLING-5266 Export org.mozilla.javascript.ast package
Currently Sling Scripting Javascript Support only exports 
org.mozilla.javascript package which is sufficient for evaluating javascript 
using Rhino but to convert expressions to  parsed AST we need 
org.mozilla.javascript.ast




> Exporting org.mozilla.javascript.ast package in 
> org.apache.sling.scripting.javascript  bundle 
> --
>
> Key: SLING-5266
> URL: https://issues.apache.org/jira/browse/SLING-5266
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Mandeep Gandhi
>Priority: Critical
> Attachments: SLING-5266.patch
>
>
> There is a need of parsing javascript expression. For achieving this, there 
> is a requirement of adding org.mozilla.javascript.ast package to the existing 
>  bundle (org.apache.sling.scripting.javascript ) and exporting it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] sling pull request: SLING-5266 Export org.mozilla.javascript.ast p...

2015-12-16 Thread welcomemandeep
GitHub user welcomemandeep opened a pull request:

https://github.com/apache/sling/pull/118

SLING-5266 Export org.mozilla.javascript.ast package

Currently Sling Scripting Javascript Support only exports 
org.mozilla.javascript package which is sufficient for evaluating javascript 
using Rhino but to convert expressions to  parsed AST we need 
org.mozilla.javascript.ast

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/welcomemandeep/sling trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #118


commit 4c5f97d1b478208afa38baea04db170a7b76687c
Author: Mandeep Gandhi 
Date:   2015-12-17T07:54:40Z

SLING-5266 Export org.mozilla.javascript.ast package
Currently Sling Scripting Javascript Support only exports 
org.mozilla.javascript package which is sufficient for evaluating javascript 
using Rhino but to convert expressions to  parsed AST we need 
org.mozilla.javascript.ast




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (SLING-5385) Support container adding request parameters

2015-12-16 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5385.
-
Resolution: Fixed

Added support in rev 1720489

> Support container adding request parameters
> ---
>
> Key: SLING-5385
> URL: https://issues.apache.org/jira/browse/SLING-5385
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Engine 2.4.6
>
>
> Some containers like Tomcat have the  concept of a Valve which allows to add 
> request parameters to a request.
> Due to SLING-3403 these parameters are not visible within Sling.
> We should allow this and check for those additional parameters. The support 
> should be disabled by default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5385) Support container adding request parameters

2015-12-16 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-5385:
---

 Summary: Support container adding request parameters
 Key: SLING-5385
 URL: https://issues.apache.org/jira/browse/SLING-5385
 Project: Sling
  Issue Type: Improvement
  Components: Engine
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Engine 2.4.6


Some containers like Tomcat have the  concept of a Valve which allows to add 
request parameters to a request.
Due to SLING-3403 these parameters are not visible within Sling.
We should allow this and check for those additional parameters. The support 
should be disabled by default



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling Content Distribution Core version 0.1.12 and Distribution API 0.3.0

2015-12-16 Thread Carsten Ziegeler
Marius Petria wrote
> Thank you all. The vote passed with 3 +1s. Can a PMC please help me promote 
> the release?
> 
I've uploaded the artifacts to our dist directory

Carsten
 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Commented] (SLING-5384) Expose BackgroundObserverMBean as part of OakResourceListener setup

2015-12-16 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15061605#comment-15061605
 ] 

Chetan Mehrotra commented on SLING-5384:


[patch|^SLING-5384.patch] for the same. It registers the mbean in addition to 
observor. Also enable metatype property for the component which somehow was 
missing

[~cziegeler] kindly review!

/cc  [~pfa...@adobe.com]

> Expose BackgroundObserverMBean as part of OakResourceListener setup
> ---
>
> Key: SLING-5384
> URL: https://issues.apache.org/jira/browse/SLING-5384
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: JCR Resource 2.6.0
>
> Attachments: SLING-5384.patch
>
>
> {{BackgroundObservor}} used by {{OakResourceListener}} also provides a 
> {{BackgroundObserverMBean}} which exposes some useful stats around the 
> backing internal queue. 
> For monitoring purpose it would be useful to expose that MBean



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5384) Expose BackgroundObserverMBean as part of OakResourceListener setup

2015-12-16 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-5384:
---
Attachment: SLING-5384.patch

> Expose BackgroundObserverMBean as part of OakResourceListener setup
> ---
>
> Key: SLING-5384
> URL: https://issues.apache.org/jira/browse/SLING-5384
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: JCR Resource 2.6.0
>
> Attachments: SLING-5384.patch
>
>
> {{BackgroundObservor}} used by {{OakResourceListener}} also provides a 
> {{BackgroundObserverMBean}} which exposes some useful stats around the 
> backing internal queue. 
> For monitoring purpose it would be useful to expose that MBean



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5384) Expose BackgroundObserverMBean as part of OakResourceListener setup

2015-12-16 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created SLING-5384:
--

 Summary: Expose BackgroundObserverMBean as part of 
OakResourceListener setup
 Key: SLING-5384
 URL: https://issues.apache.org/jira/browse/SLING-5384
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
 Fix For: JCR Resource 2.6.0


{{BackgroundObservor}} used by {{OakResourceListener}} also provides a 
{{BackgroundObserverMBean}} which exposes some useful stats around the backing 
internal queue. 

For monitoring purpose it would be useful to expose that MBean



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling Content Distribution Core version 0.1.12 and Distribution API 0.3.0

2015-12-16 Thread Marius Petria
Thank you all. The vote passed with 3 +1s. Can a PMC please help me promote the 
release?

Best regards,
Marius







On 12/16/15, 11:57 AM, "Robert Munteanu"  wrote:

>On Tue, 2015-12-15 at 12:11 +, Marius Petria wrote:
>> Please vote to approve this release:
>
>+1
>
>Robert


[jira] [Resolved] (SLING-5383) Provisioning model does not allow '=' sign in a string config value

2015-12-16 Thread David Bosschaert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved SLING-5383.
-
Resolution: Invalid

Ok - not a Sling issue, so I'm closing it... Thanks [~mpetria] and [~cziegeler] 
for explaining.

> Provisioning model does not allow '=' sign in a string config value
> ---
>
> Key: SLING-5383
> URL: https://issues.apache.org/jira/browse/SLING-5383
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Sling Provisioning Model 1.4.0
>Reporter: David Bosschaert
>
> Adding an "=" sign in a String configuration value results in an exception 
> when the provisioning model is parsed. I should be able to have add an "=" 
> sign in my config values.
> To reproduce, just add the following at the bottom of 
> {{.../checkouts/sling/launchpad/builder/src/main/provisioning/sling.txt}}
> {code}  org.foo.bar
> key="val=val"{code}
> Then run {{mvn install}} and you'll get the following error:
> {code}[ERROR] Internal error: java.lang.IllegalArgumentException: Unable to 
> read configuration properties: Configuration [pid=org.foo.bar, 
> factoryPid=null, properties={:rawconfig.format=felixca, 
> :rawconfig.mode=overwrite, :rawconfig=key="val=val"
> [ERROR] }]: Unexpected token 34; expected: 61 (line=0, pos=18)
> [ERROR] -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.IllegalArgumentException: Unable to read configuration properties: 
> Configuration [pid=org.foo.bar, factoryPid=null, 
> properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
> :rawconfig=key="val=val"
> }]
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: java.lang.IllegalArgumentException: Unable to read configuration 
> properties: Configuration [pid=org.foo.bar, factoryPid=null, 
> properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
> :rawconfig=key="val=val"
> }]
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:516)
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel(ModelUtility.java:316)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:149)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:124)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:119)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:274)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>   ... 11 more
> Caused by: java.io.IOException: Unexpected token 34; expected: 61 (line=0, 
> pos=18)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:681)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:300)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:263)
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:509)
>   ... 17 more{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5383) Provisioning model does not allow '=' sign in a string config value

2015-12-16 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060323#comment-15060323
 ] 

Carsten Ziegeler commented on SLING-5383:
-

You're using the Felix CA format, which doesn't allow this, as Marius points 
escaping the = should work.
If you want to have this changed, this needs to be solved in the Apache Felix 
configuration admin implementation

> Provisioning model does not allow '=' sign in a string config value
> ---
>
> Key: SLING-5383
> URL: https://issues.apache.org/jira/browse/SLING-5383
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Sling Provisioning Model 1.4.0
>Reporter: David Bosschaert
>
> Adding an "=" sign in a String configuration value results in an exception 
> when the provisioning model is parsed. I should be able to have add an "=" 
> sign in my config values.
> To reproduce, just add the following at the bottom of 
> {{.../checkouts/sling/launchpad/builder/src/main/provisioning/sling.txt}}
> {code}  org.foo.bar
> key="val=val"{code}
> Then run {{mvn install}} and you'll get the following error:
> {code}[ERROR] Internal error: java.lang.IllegalArgumentException: Unable to 
> read configuration properties: Configuration [pid=org.foo.bar, 
> factoryPid=null, properties={:rawconfig.format=felixca, 
> :rawconfig.mode=overwrite, :rawconfig=key="val=val"
> [ERROR] }]: Unexpected token 34; expected: 61 (line=0, pos=18)
> [ERROR] -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.IllegalArgumentException: Unable to read configuration properties: 
> Configuration [pid=org.foo.bar, factoryPid=null, 
> properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
> :rawconfig=key="val=val"
> }]
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: java.lang.IllegalArgumentException: Unable to read configuration 
> properties: Configuration [pid=org.foo.bar, factoryPid=null, 
> properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
> :rawconfig=key="val=val"
> }]
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:516)
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel(ModelUtility.java:316)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:149)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:124)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:119)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:274)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>   ... 11 more
> Caused by: java.io.IOException: Unexpected token 34; expected: 61 (line=0, 
> pos=18)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:681)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:300)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:263)
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:509)
>   ... 17 more{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5383) Provisioning model does not allow '=' sign in a string config value

2015-12-16 Thread Marius Petria (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060245#comment-15060245
 ] 

Marius Petria commented on SLING-5383:
--

AFAIK the {{=}} sign must be escaped {{"val\=val"}}. However that restriction 
can be probably dropped if only the first {{=}} is semantic.

> Provisioning model does not allow '=' sign in a string config value
> ---
>
> Key: SLING-5383
> URL: https://issues.apache.org/jira/browse/SLING-5383
> Project: Sling
>  Issue Type: Bug
>Affects Versions: Sling Provisioning Model 1.4.0
>Reporter: David Bosschaert
>
> Adding an "=" sign in a String configuration value results in an exception 
> when the provisioning model is parsed. I should be able to have add an "=" 
> sign in my config values.
> To reproduce, just add the following at the bottom of 
> {{.../checkouts/sling/launchpad/builder/src/main/provisioning/sling.txt}}
> {code}  org.foo.bar
> key="val=val"{code}
> Then run {{mvn install}} and you'll get the following error:
> {code}[ERROR] Internal error: java.lang.IllegalArgumentException: Unable to 
> read configuration properties: Configuration [pid=org.foo.bar, 
> factoryPid=null, properties={:rawconfig.format=felixca, 
> :rawconfig.mode=overwrite, :rawconfig=key="val=val"
> [ERROR] }]: Unexpected token 34; expected: 61 (line=0, pos=18)
> [ERROR] -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.IllegalArgumentException: Unable to read configuration properties: 
> Configuration [pid=org.foo.bar, factoryPid=null, 
> properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
> :rawconfig=key="val=val"
> }]
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: java.lang.IllegalArgumentException: Unable to read configuration 
> properties: Configuration [pid=org.foo.bar, factoryPid=null, 
> properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
> :rawconfig=key="val=val"
> }]
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:516)
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel(ModelUtility.java:316)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:149)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:124)
>   at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:119)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:274)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
>   ... 11 more
> Caused by: java.io.IOException: Unexpected token 34; expected: 61 (line=0, 
> pos=18)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:681)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:300)
>   at 
> org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:263)
>   at 
> org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:509)
>   ... 17 more{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5383) Provisioning model does not allow '=' sign in a string config value

2015-12-16 Thread David Bosschaert (JIRA)
David Bosschaert created SLING-5383:
---

 Summary: Provisioning model does not allow '=' sign in a string 
config value
 Key: SLING-5383
 URL: https://issues.apache.org/jira/browse/SLING-5383
 Project: Sling
  Issue Type: Bug
Affects Versions: Sling Provisioning Model 1.4.0
Reporter: David Bosschaert


Adding an "=" sign in a String configuration value results in an exception when 
the provisioning model is parsed. I should be able to have add an "=" sign in 
my config values.

To reproduce, just add the following at the bottom of 
{{.../checkouts/sling/launchpad/builder/src/main/provisioning/sling.txt}}
{code}  org.foo.bar
key="val=val"{code}

Then run {{mvn install}} and you'll get the following error:
{code}[ERROR] Internal error: java.lang.IllegalArgumentException: Unable to 
read configuration properties: Configuration [pid=org.foo.bar, factoryPid=null, 
properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
:rawconfig=key="val=val"
[ERROR] }]: Unexpected token 34; expected: 61 (line=0, pos=18)
[ERROR] -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: 
java.lang.IllegalArgumentException: Unable to read configuration properties: 
Configuration [pid=org.foo.bar, factoryPid=null, 
properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
:rawconfig=key="val=val"
}]
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: java.lang.IllegalArgumentException: Unable to read configuration 
properties: Configuration [pid=org.foo.bar, factoryPid=null, 
properties={:rawconfig.format=felixca, :rawconfig.mode=overwrite, 
:rawconfig=key="val=val"
}]
at 
org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:516)
at 
org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel(ModelUtility.java:316)
at 
org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:149)
at 
org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.addDependencies(DependencyLifecycleParticipant.java:124)
at 
org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead(DependencyLifecycleParticipant.java:119)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:274)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
... 11 more
Caused by: java.io.IOException: Unexpected token 34; expected: 61 (line=0, 
pos=18)
at 
org.apache.felix.cm.file.ConfigurationHandler.readFailure(ConfigurationHandler.java:681)
at 
org.apache.felix.cm.file.ConfigurationHandler.readInternal(ConfigurationHandler.java:300)
at 
org.apache.felix.cm.file.ConfigurationHandler.read(ConfigurationHandler.java:263)
at 
org.apache.sling.provisioning.model.ModelUtility.getProcessedConfiguration(ModelUtility.java:509)
... 17 more{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060180#comment-15060180
 ] 

Bertrand Delacretaz commented on SLING-5379:


> I think we should somehow prefix the attribute though, like 
> [sling:rename-bsn=] 
> just to make sure that this is not typical meta data for the artifact, 
> but an instruction

Works for me, anything that allows us to provide an overview of such renames in 
a single place (OSGi console) is good.

> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> To make this renaming simple and do it on the fly, we can extend the 
> slingstart-maven-plugin to do this renaming automatically, with a 
> configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.3{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060152#comment-15060152
 ] 

Carsten Ziegeler commented on SLING-5379:
-

I think this is a nice addition, I wouldn't force a specifc BSN format (like 
starting with R- ) as this can cause problems (users really want a specific 
BSN). Adding a header should be enough.
We could optionally build a web console plugin for this, or a bundle info 
provider maybe

I think we should somehow prefix the attribute though, like [sling:rename-bsn=] 
just to make sure that this is not typical meta data for the artifact, but an 
instruction

> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> To make this renaming simple and do it on the fly, we can extend the 
> slingstart-maven-plugin to do this renaming automatically, with a 
> configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.3{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060165#comment-15060165
 ] 

Carsten Ziegeler commented on SLING-5379:
-

Maybe bundle:rename-bsn is a nice name?

> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> To make this renaming simple and do it on the fly, we can extend the 
> slingstart-maven-plugin to do this renaming automatically, with a 
> configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.3{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread David Bosschaert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059873#comment-15059873
 ] 

David Bosschaert commented on SLING-5379:
-

Hi [~bdelacretaz], 

Yeah, the main thing why I think this feature can be helpful is that sometimes 
there is a need to do this renaming. Previously people have always had to 
create separate Maven Projects to generate the modified bundle which was quite 
a lot of overhead, especially given that we only need to rename one header.

I agree that it would be good to add an additional header to indicate what the 
Bundle Symbolic Name was, something like:
{code}Original-Bundle-SymbolicName: org.foo.bar{code}

> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> To make this renaming simple and do it on the fly, we can extend the 
> slingstart-maven-plugin to do this renaming automatically, with a 
> configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.3{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread David Bosschaert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-5379:

Description: 
Because the Sling OSGi Installer only allows a single OSGi bundle with a given 
BSN, it is sometimes necessary to rename a bundle's BSN to enable it to be 
installed more than once. 

To make this renaming simple and do it on the fly, we can extend the 
slingstart-maven-plugin to do this renaming automatically, with a configuration 
like this:
{code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}

One note, in case there are multiple model files that all reference the same 
artifact. For example, with a base model as above. 

Model A inherits from Base model and has:
{code}org.foo.bar/blah/1.2.5{code}
without the rename.

In this case the rename still happens as the attributes are inherited.

  was:
Because the Sling OSGi Installer only allows a single OSGi bundle with a given 
BSN, it is sometimes necessary to rename a bundle's BSN to enable it to be 
installed more than once. 

We can extend the slingstart-maven-plugin to do this renaming automatically, 
with a configuration like this:
{code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}

One note, in case there are multiple model files that all reference the same 
artifact. For example, with a base model as above. 

Model A inherits from Base model and has:
{code}org.foo.bar/blah/1.2.5{code}
without the rename.

In this case the rename still happens as the attributes are inherited.


> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> To make this renaming simple and do it on the fly, we can extend the 
> slingstart-maven-plugin to do this renaming automatically, with a 
> configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.5{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread David Bosschaert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert updated SLING-5379:

Description: 
Because the Sling OSGi Installer only allows a single OSGi bundle with a given 
BSN, it is sometimes necessary to rename a bundle's BSN to enable it to be 
installed more than once. 

To make this renaming simple and do it on the fly, we can extend the 
slingstart-maven-plugin to do this renaming automatically, with a configuration 
like this:
{code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}

One note, in case there are multiple model files that all reference the same 
artifact. For example, with a base model as above. 

Model A inherits from Base model and has:
{code}org.foo.bar/blah/1.2.3{code}
without the rename.

In this case the rename still happens as the attributes are inherited.

  was:
Because the Sling OSGi Installer only allows a single OSGi bundle with a given 
BSN, it is sometimes necessary to rename a bundle's BSN to enable it to be 
installed more than once. 

To make this renaming simple and do it on the fly, we can extend the 
slingstart-maven-plugin to do this renaming automatically, with a configuration 
like this:
{code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}

One note, in case there are multiple model files that all reference the same 
artifact. For example, with a base model as above. 

Model A inherits from Base model and has:
{code}org.foo.bar/blah/1.2.5{code}
without the rename.

In this case the rename still happens as the attributes are inherited.


> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> To make this renaming simple and do it on the fly, we can extend the 
> slingstart-maven-plugin to do this renaming automatically, with a 
> configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.3{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5382) DiscoveryServiceImpl#doUpdateProperties may fail due to a NPE

2015-12-16 Thread Timothee Maret (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059832#comment-15059832
 ] 

Timothee Maret commented on SLING-5382:
---

The {{config}} field should be checked for {{null}} as it could be that the 
framework binds a {{PropertyProvider}} instance before the {{config}} (thus 
before the component is active).

{code}
Resource myInstance = ResourceHelper
.getOrCreateResource(
resourceResolver,
config.getClusterInstancesPath()
+ "/" + slingId + "/properties");
{code}

> DiscoveryServiceImpl#doUpdateProperties may fail due to a NPE 
> --
>
> Key: SLING-5382
> URL: https://issues.apache.org/jira/browse/SLING-5382
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Discovery Oak 1.2.0
>Reporter: Timothee Maret
>
> Observed
> {code}
> 09.12.2015 14:19:13.175 *ERROR* [FelixStartLevel] 
> org.apache.sling.discovery.oak 
> [org.apache.sling.discovery.oak.OakDiscoveryService(186)] The 
> updatedPropertyProvider method has thrown an exception 
> (java.lang.NullPointerException)
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:476)
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:403)
>   at 
> org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:417)
>   at sun.reflect.GeneratedMethodAccessor53.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
>   at 
> org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:37)
>   at 
> org.apache.felix.scr.impl.helper.BaseMethod$Resolved.invoke(BaseMethod.java:615)
>   at 
> org.apache.felix.scr.impl.helper.BaseMethod.invoke(BaseMethod.java:499)
>   at 
> org.apache.felix.scr.impl.helper.BindMethod.invoke(BindMethod.java:41)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager.invokeUpdatedMethod(DependencyManager.java:1706)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.invokeUpdatedMethod(SingleComponentManager.java:381)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:349)
>   at 
> org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:295)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1228)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1136)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:884)
>   at 
> org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1167)
>   at 
> org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:120)
>   at 
> org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:991)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:839)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispatcher.java:546)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4557)
>   at org.apache.felix.framework.Felix.access$000(Felix.java:106)
>   at org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:420)
>   at 
> org.apache.felix.framework.ServiceRegistry.servicePropertiesModified(ServiceRegistry.java:571)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.setProperties(ServiceRegistrationImpl.java:131)
>   at 
> org.apache.sling.event.impl.jobs.JobConsumerManager.unbindService(JobConsumerManager.java:364)
>   at 
> org.apache.sling.event.impl.jobs.JobConsumerManager.unbindJobConsumer(JobConsumerManager.java:262)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
>   at 
> org.apache

[jira] [Created] (SLING-5382) DiscoveryServiceImpl#doUpdateProperties may fail due to a NPE

2015-12-16 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-5382:
-

 Summary: DiscoveryServiceImpl#doUpdateProperties may fail due to a 
NPE 
 Key: SLING-5382
 URL: https://issues.apache.org/jira/browse/SLING-5382
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Discovery Oak 1.2.0
Reporter: Timothee Maret


Observed
{code}
09.12.2015 14:19:13.175 *ERROR* [FelixStartLevel] 
org.apache.sling.discovery.oak 
[org.apache.sling.discovery.oak.OakDiscoveryService(186)] The 
updatedPropertyProvider method has thrown an exception 
(java.lang.NullPointerException)
java.lang.NullPointerException: null
at 
org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:476)
at 
org.apache.sling.discovery.oak.OakDiscoveryService.bindPropertyProviderInteral(OakDiscoveryService.java:403)
at 
org.apache.sling.discovery.oak.OakDiscoveryService.updatedPropertyProvider(OakDiscoveryService.java:417)
at sun.reflect.GeneratedMethodAccessor53.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
at 
org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:37)
at 
org.apache.felix.scr.impl.helper.BaseMethod$Resolved.invoke(BaseMethod.java:615)
at 
org.apache.felix.scr.impl.helper.BaseMethod.invoke(BaseMethod.java:499)
at 
org.apache.felix.scr.impl.helper.BindMethod.invoke(BindMethod.java:41)
at 
org.apache.felix.scr.impl.manager.DependencyManager.invokeUpdatedMethod(DependencyManager.java:1706)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.invokeUpdatedMethod(SingleComponentManager.java:381)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:349)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.modifiedService(DependencyManager.java:295)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1228)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerModified(ServiceTracker.java:1136)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:884)
at 
org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1167)
at 
org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:120)
at 
org.apache.felix.framework.util.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:991)
at 
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:839)
at 
org.apache.felix.framework.util.EventDispatcher.fireServiceEvent(EventDispatcher.java:546)
at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4557)
at org.apache.felix.framework.Felix.access$000(Felix.java:106)
at org.apache.felix.framework.Felix$1.serviceChanged(Felix.java:420)
at 
org.apache.felix.framework.ServiceRegistry.servicePropertiesModified(ServiceRegistry.java:571)
at 
org.apache.felix.framework.ServiceRegistrationImpl.setProperties(ServiceRegistrationImpl.java:131)
at 
org.apache.sling.event.impl.jobs.JobConsumerManager.unbindService(JobConsumerManager.java:364)
at 
org.apache.sling.event.impl.jobs.JobConsumerManager.unbindJobConsumer(JobConsumerManager.java:262)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.apache.felix.scr.impl.helper.BaseMethod.invokeMethod(BaseMethod.java:222)
at 
org.apache.felix.scr.impl.helper.BaseMethod.access$500(BaseMethod.java:37)
at 
org.apache.felix.scr.impl.helper.BaseMethod$Resolved.invoke(BaseMethod.java:615)
at 
org.apache.felix.scr.impl.helper.BaseMethod.invoke(BaseMethod.java:499)
at 
org.apache.felix.scr.impl.helper.BindMethod.invoke(BindMethod.java:41)
at 
org.apache.felix.scr.impl.manager.DependencyManager.invokeUnbindMethod(DependencyManager.java:1774)
at 
org.apache.felix.scr.impl.manager.SingleComponentManager.invokeUnbindMethod(SingleComponentManager.java:393)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.removedService(DependencyManager.java:364)
at 
org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynam

[jira] [Updated] (SLING-5381) NPE in QuartzScheduler

2015-12-16 Thread Timothee Maret (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-5381:
--
Description: 
Observed in our logs
{code}
10.12.2015 23:34:56.952 *ERROR* [FelixDispatchQueue] 
org.apache.sling.commons.scheduler FrameworkEvent ERROR 
(java.lang.NullPointerException)
java.lang.NullPointerException: null
at 
org.apache.sling.commons.scheduler.impl.QuartzScheduler.bundleChanged(QuartzScheduler.java:160)
at 
org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:916)
at 
org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:835)
at 
org.apache.felix.framework.util.EventDispatcher.run(EventDispatcher.java:1148)
at 
org.apache.felix.framework.util.EventDispatcher.access$000(EventDispatcher.java:55)
at 
org.apache.felix.framework.util.EventDispatcher$1.run(EventDispatcher.java:103)
at java.lang.Thread.run(Thread.java:745)
{code}

  was:
Observed in our logs
{code}

11.12.2015 04:37:52.295 *ERROR* [pool-74-thread-1] 
org.apache.sling.commons.scheduler.impl.QuartzScheduler Exception during job 
execution of org.apache.sling.discovery.oak.pinger.OakViewChecker@7e1e1c3d : 
null
java.lang.NullPointerException: null
at 
org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:476)
at 
org.apache.sling.discovery.oak.OakDiscoveryService.updateProperties(OakDiscoveryService.java:545)
at 
org.apache.sling.discovery.oak.pinger.OakViewChecker.updateProperties(OakViewChecker.java:330)
at 
org.apache.sling.discovery.base.commons.BaseViewChecker.issueHeartbeat(BaseViewChecker.java:213)
at 
org.apache.sling.discovery.base.commons.BaseViewChecker.heartbeatAndCheckView(BaseViewChecker.java:181)
at 
org.apache.sling.discovery.base.commons.BaseViewChecker.run(BaseViewChecker.java:167)
at 
org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:115)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
{code}


> NPE in QuartzScheduler
> --
>
> Key: SLING-5381
> URL: https://issues.apache.org/jira/browse/SLING-5381
> Project: Sling
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: Event 4.0.0
>Reporter: Timothee Maret
>Priority: Minor
>
> Observed in our logs
> {code}
> 10.12.2015 23:34:56.952 *ERROR* [FelixDispatchQueue] 
> org.apache.sling.commons.scheduler FrameworkEvent ERROR 
> (java.lang.NullPointerException)
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.bundleChanged(QuartzScheduler.java:160)
>   at 
> org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:916)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:835)
>   at 
> org.apache.felix.framework.util.EventDispatcher.run(EventDispatcher.java:1148)
>   at 
> org.apache.felix.framework.util.EventDispatcher.access$000(EventDispatcher.java:55)
>   at 
> org.apache.felix.framework.util.EventDispatcher$1.run(EventDispatcher.java:103)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5381) NPE in QuartzScheduler

2015-12-16 Thread Timothee Maret (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059825#comment-15059825
 ] 

Timothee Maret commented on SLING-5381:
---

Seems harmless, just a missing null check after
https://github.com/apache/sling/blob/7c4a53755aed1211c9af313a3973cd2543a7bbe0/bundles/commons/scheduler/src/main/java/org/apache/sling/commons/scheduler/impl/QuartzScheduler.java#L159

> NPE in QuartzScheduler
> --
>
> Key: SLING-5381
> URL: https://issues.apache.org/jira/browse/SLING-5381
> Project: Sling
>  Issue Type: Bug
>  Components: Engine
>Affects Versions: Event 4.0.0
>Reporter: Timothee Maret
>Priority: Minor
>
> Observed in our logs
> {code}
> 10.12.2015 23:34:56.952 *ERROR* [FelixDispatchQueue] 
> org.apache.sling.commons.scheduler FrameworkEvent ERROR 
> (java.lang.NullPointerException)
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzScheduler.bundleChanged(QuartzScheduler.java:160)
>   at 
> org.apache.felix.framework.util.EventDispatcher.invokeBundleListenerCallback(EventDispatcher.java:916)
>   at 
> org.apache.felix.framework.util.EventDispatcher.fireEventImmediately(EventDispatcher.java:835)
>   at 
> org.apache.felix.framework.util.EventDispatcher.run(EventDispatcher.java:1148)
>   at 
> org.apache.felix.framework.util.EventDispatcher.access$000(EventDispatcher.java:55)
>   at 
> org.apache.felix.framework.util.EventDispatcher$1.run(EventDispatcher.java:103)
>   at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5381) NPE in QuartzScheduler

2015-12-16 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-5381:
-

 Summary: NPE in QuartzScheduler
 Key: SLING-5381
 URL: https://issues.apache.org/jira/browse/SLING-5381
 Project: Sling
  Issue Type: Bug
  Components: Engine
Affects Versions: Event 4.0.0
Reporter: Timothee Maret
Priority: Minor


Observed in our logs
{code}

11.12.2015 04:37:52.295 *ERROR* [pool-74-thread-1] 
org.apache.sling.commons.scheduler.impl.QuartzScheduler Exception during job 
execution of org.apache.sling.discovery.oak.pinger.OakViewChecker@7e1e1c3d : 
null
java.lang.NullPointerException: null
at 
org.apache.sling.discovery.oak.OakDiscoveryService.doUpdateProperties(OakDiscoveryService.java:476)
at 
org.apache.sling.discovery.oak.OakDiscoveryService.updateProperties(OakDiscoveryService.java:545)
at 
org.apache.sling.discovery.oak.pinger.OakViewChecker.updateProperties(OakViewChecker.java:330)
at 
org.apache.sling.discovery.base.commons.BaseViewChecker.issueHeartbeat(BaseViewChecker.java:213)
at 
org.apache.sling.discovery.base.commons.BaseViewChecker.heartbeatAndCheckView(BaseViewChecker.java:181)
at 
org.apache.sling.discovery.base.commons.BaseViewChecker.run(BaseViewChecker.java:167)
at 
org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:115)
at org.quartz.core.JobRunShell.run(JobRunShell.java:202)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5380) NPE in TopologyWebConsolePlugin addDiscoveryLiteHistoryEntry

2015-12-16 Thread Timothee Maret (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059820#comment-15059820
 ] 

Timothee Maret commented on SLING-5380:
---

It may be that {{resourceResolverFactory}} is {{null}} in the 
{{getResourceResolver}} thus causing the NPE.

> NPE in TopologyWebConsolePlugin addDiscoveryLiteHistoryEntry
> 
>
> Key: SLING-5380
> URL: https://issues.apache.org/jira/browse/SLING-5380
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Discovery Oak 1.2.0
>Reporter: Timothee Maret
>
> In our logs we sometimes observe a NPE at start up.
> {code}
> Error Message
> error.log contains the unexpected line: 14.12.2015 16:52:50.791 *ERROR* 
> [Discovery-AsyncEventSender] 
> org.apache.sling.discovery.oak.TopologyWebConsolePlugin 
> addDiscoveryLiteHistoryEntry: Exception: java.lang.NullPointerException
> Stacktrace
> junit.framework.AssertionFailedError: error.log contains the unexpected line: 
> 14.12.2015 16:52:50.791 *ERROR* [Discovery-AsyncEventSender] 
> org.apache.sling.discovery.oak.TopologyWebConsolePlugin 
> addDiscoveryLiteHistoryEntry: Exception: java.lang.NullPointerException
>   at junit.framework.Assert.fail(Assert.java:57)
>   at 
> com.adobe.granite.quickstart.it.AAALogFileIT.testLogFiles(AAALogFileIT.java:100)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5380) NPE in TopologyWebConsolePlugin addDiscoveryLiteHistoryEntry

2015-12-16 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-5380:
-

 Summary: NPE in TopologyWebConsolePlugin 
addDiscoveryLiteHistoryEntry
 Key: SLING-5380
 URL: https://issues.apache.org/jira/browse/SLING-5380
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Discovery Oak 1.2.0
Reporter: Timothee Maret


In our logs we sometimes observe a NPE at start up.

{code}
Error Message

error.log contains the unexpected line: 14.12.2015 16:52:50.791 *ERROR* 
[Discovery-AsyncEventSender] 
org.apache.sling.discovery.oak.TopologyWebConsolePlugin 
addDiscoveryLiteHistoryEntry: Exception: java.lang.NullPointerException
Stacktrace

junit.framework.AssertionFailedError: error.log contains the unexpected line: 
14.12.2015 16:52:50.791 *ERROR* [Discovery-AsyncEventSender] 
org.apache.sling.discovery.oak.TopologyWebConsolePlugin 
addDiscoveryLiteHistoryEntry: Exception: java.lang.NullPointerException

at junit.framework.Assert.fail(Assert.java:57)
at 
com.adobe.granite.quickstart.it.AAALogFileIT.testLogFiles(AAALogFileIT.java:100)
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling Content Distribution Core version 0.1.12 and Distribution API 0.3.0

2015-12-16 Thread Robert Munteanu
On Tue, 2015-12-15 at 12:11 +, Marius Petria wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part


[jira] [Commented] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059754#comment-15059754
 ] 

Bertrand Delacretaz commented on SLING-5379:


Thinking about it, the best way to make such renames obvious is probably to 
force the new name to start with a prefix like {{R-}}

{code}
org.foo.bar/blah/1.2.3 [rename-bsn=R-com.example.foo.bar.blah]
{code}

Bundles with symbolic names starting with {{R-}} are then telltales that this 
feature was used. 

This makes the new names somewhat ugly but so is this feature ;-)

> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> We can extend the slingstart-maven-plugin to do this renaming automatically, 
> with a configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.5{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059714#comment-15059714
 ] 

Bertrand Delacretaz commented on SLING-5379:


While I see the need for this in edge cases, there's a high risk of confusing 
people who administer and troubleshoot Sling instances where such renames 
happen.

Please try to make this as transparent as possible, it should be easy to find 
out by looking at a running Sling instance which bundles were renamed. Adding a 
bundle header that explains what happens might be best if that's possible, 
second choice being an OSGi console page that lists all such renames.

> [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning 
> Model
> --
>
> Key: SLING-5379
> URL: https://issues.apache.org/jira/browse/SLING-5379
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Reporter: David Bosschaert
>
> Because the Sling OSGi Installer only allows a single OSGi bundle with a 
> given BSN, it is sometimes necessary to rename a bundle's BSN to enable it to 
> be installed more than once. 
> We can extend the slingstart-maven-plugin to do this renaming automatically, 
> with a configuration like this:
> {code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}
> One note, in case there are multiple model files that all reference the same 
> artifact. For example, with a base model as above. 
> Model A inherits from Base model and has:
> {code}org.foo.bar/blah/1.2.5{code}
> without the rename.
> In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-5379) [slingstart-maven-plugin] Support renaming of bundles via Sling Provisioning Model

2015-12-16 Thread David Bosschaert (JIRA)
David Bosschaert created SLING-5379:
---

 Summary: [slingstart-maven-plugin] Support renaming of bundles via 
Sling Provisioning Model
 Key: SLING-5379
 URL: https://issues.apache.org/jira/browse/SLING-5379
 Project: Sling
  Issue Type: New Feature
  Components: Maven Plugins and Archetypes
Reporter: David Bosschaert


Because the Sling OSGi Installer only allows a single OSGi bundle with a given 
BSN, it is sometimes necessary to rename a bundle's BSN to enable it to be 
installed more than once. 

We can extend the slingstart-maven-plugin to do this renaming automatically, 
with a configuration like this:
{code}org.foo.bar/blah/1.2.3 [rename-bsn=com.adobe.foo.bar.blah]{code}

One note, in case there are multiple model files that all reference the same 
artifact. For example, with a base model as above. 

Model A inherits from Base model and has:
{code}org.foo.bar/blah/1.2.5{code}
without the rename.

In this case the rename still happens as the attributes are inherited.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)