Re: [VOTE] Release Apache Sling Resource Resolver 1.4.2, JCR Resource 2.7.2, and Servlets Resolver 2.4.2

2016-02-18 Thread Carsten Ziegeler
The vote passed with four binding +1 votes (no other votes).

Thanks
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Created] (SLING-5534) Improve namespace handling

2016-02-18 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-5534:
---

 Summary: Improve namespace handling
 Key: SLING-5534
 URL: https://issues.apache.org/jira/browse/SLING-5534
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Reporter: Carsten Ziegeler
 Fix For: JCR Base 2.3.2


Right now the namespace handling support requries a proxy of the session object 
(in order to have namespace handling for impersonated session).
In addition for each new session, the mapping code is run, although it should 
only run once and register the namespaces in the registry.
This should improve performance as we don't have to run the namespace handling 
code for each and every session and get rid of the proxy.
The namespace registration itself gets a little more tricky, but basically we 
can directly change the registry whenever a bundle with a namespace header 
arrives. We just need to think about collition handling



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153868#comment-15153868
 ] 

Carsten Ziegeler commented on SLING-5531:
-

[~sseif...@pro-vision.de] Thanks, lgtm - do you want to apply it?

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
> Attachments: AbstractSlingRepository2.patch
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5517) Support of startsWith in exclude path of Content Disposition filter

2016-02-18 Thread Antonio Sanso (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152958#comment-15152958
 ] 

Antonio Sanso commented on SLING-5517:
--

[~mmarth] we discussed performance concerns in SLING-3829. At the end we found 
an agreement to just support exact matching in SLING-4973 (this has only O(1) 
performance impact).

> Support of startsWith in exclude path of Content Disposition filter
> ---
>
> Key: SLING-5517
> URL: https://issues.apache.org/jira/browse/SLING-5517
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Mandeep Gandhi
> Fix For: Security 1.0.18
>
>
> Right now exclude path parameter of config of Content Disposition filter 
> takes   specific paths into account. 
> To excluded everything under a give path, an enhancement is required.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-4046) Keyboard shortcuts do not work on content structure

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-4046:
--

Assignee: Robert Munteanu

> Keyboard shortcuts do not work on content structure
> ---
>
> Key: SLING-4046
> URL: https://issues.apache.org/jira/browse/SLING-4046
> Project: Sling
>  Issue Type: Bug
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.2
>Reporter: Kamil Ciecierski
>Assignee: Robert Munteanu
>Priority: Trivial
> Fix For: Sling Eclipse IDE 1.1.0
>
> Attachments: screenshot-1.png
>
>
> Actual:
> Please see the screenshot. Clicking on some node/folder/nt:structure element 
> (i.e example [sling:OrderedFolder] on the screen) and then pressing DEL or F2 
> button does not make any effect
> Expected:
> Pressing DEL or F2 causes actions suggested by context menu.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-5531:
-

Assignee: Carsten Ziegeler  (was: Stefan Seifert)

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
> Attachments: AbstractSlingRepository2.patch
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-5531:
--
Attachment: AbstractSlingRepository2.patch

i think i've found the problem.

the Loader is registered as bundle listener and nicely collects all bundle 
headers with namespaces or node types (and logs this in DEBUG level, not sure 
why i've not seen the messages in my previous attempt). but they never get 
applied to a session and thus not to the JCR repository when 
AbstractSlingRepository2 is used.

please see the patch [^AbstractSlingRepository2.patch]. with this patch the 
namespace registration works as expected. but i have no good understanding of 
the code in this module, [~cziegeler], can you have a look again?

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
> Attachments: AbstractSlingRepository2.patch
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5517) Support of startsWith in exclude path of Content Disposition filter

2016-02-18 Thread Michael Marth (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152371#comment-15152371
 ] 

Michael Marth commented on SLING-5517:
--

[~asanso], was this decision tracked in an issue, wiki, etc?
Thx!

> Support of startsWith in exclude path of Content Disposition filter
> ---
>
> Key: SLING-5517
> URL: https://issues.apache.org/jira/browse/SLING-5517
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Mandeep Gandhi
> Fix For: Security 1.0.18
>
>
> Right now exclude path parameter of config of Content Disposition filter 
> takes   specific paths into account. 
> To excluded everything under a give path, an enhancement is required.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: 2 sling pipes patches

2016-02-18 Thread Nicolas Peltier
Thank you, Robert!
> On 18 Feb 2016, at 11:56, Robert Munteanu  wrote:
> 
> Hi Nicolas,
> 
> On Mon, 2016-02-15 at 16:32 +, Nicolas Peltier wrote:
>> Hey sling committers!
>> 
>> i’ve posted 2 JIRAs with patches for a bug [0] and an improvement
>> [1]. Both contain as well documentation patches. The second doc patch
>> contains first doc patch (as there is only one documentation file).
>> Hope it would be ok for one of you to commit SLING_5434 patch, then
>> SLING-5523 patch, then SLING-5523 doc patch, otherwise i’m happy
>> (manner of speaking :-) re-attaching doc patch with 5523 changes
>> only.
> 
> Your patches are applied, thanks for the contributions :-)
> 
> Robert



Re: [VOTE] Release Apache Sling Internationalization Support 2.4.6

2016-02-18 Thread Robert Munteanu
On Thu, 2016-02-18 at 08:59 +, Julian Sedding wrote:
>   [ ] +1 Approve the release

+1

Robert

signature.asc
Description: This is a digitally signed message part


[jira] [Assigned] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-5531:
-

Assignee: Stefan Seifert

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: 2 sling pipes patches

2016-02-18 Thread Robert Munteanu
Hi Nicolas,

On Mon, 2016-02-15 at 16:32 +, Nicolas Peltier wrote:
> Hey sling committers!
> 
> i’ve posted 2 JIRAs with patches for a bug [0] and an improvement
> [1]. Both contain as well documentation patches. The second doc patch
> contains first doc patch (as there is only one documentation file).
> Hope it would be ok for one of you to commit SLING_5434 patch, then
> SLING-5523 patch, then SLING-5523 doc patch, otherwise i’m happy
> (manner of speaking :-) re-attaching doc patch with 5523 changes
> only.

Your patches are applied, thanks for the contributions :-)

Robert


[jira] [Resolved] (SLING-5523) filter pipe should be able to filter out resources that *have* a configured child

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5523.

Resolution: Fixed

- [r1731044|https://svn.apache.org/r1731044] - fix
- [r1731045|https://svn.apache.org/r1731045] - docs

Thanks for the submission!

> filter pipe should be able to filter out resources that *have* a configured 
> child
> -
>
> Key: SLING-5523
> URL: https://issues.apache.org/jira/browse/SLING-5523
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5434-5523-DOC.patch, SLING-5523.patch
>
>
> implementing that feature as is could be complicated. A simple way of doing 
> it is to add a "not" flag that inverts the filter results (if filter passes 
> and not, filter fails, if filter fails and not, filter succeeds, filter 
> succeeds in other cases (exclusive or of filter and not flag))



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5434) WritePipe shoud remove properties at the very end

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5434.

Resolution: Fixed

- [r1731043|https://svn.apache.org/r1731043] - committed patch
- [r1731041|https://svn.apache.org/r1731041] - updated docs

Thanks for the submission!

> WritePipe shoud remove properties at the very end
> -
>
> Key: SLING-5434
> URL: https://issues.apache.org/jira/browse/SLING-5434
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5434-DOC.patch, SLING-5434.patch
>
>
> in order to allow all expressions at current state to use the values of 
> properties to be removed.
> test & fix in attached patch
> related to thread 
> http://mail-archives.apache.org/mod_mbox/sling-users/201601.mbox/%3C2FBC4C5C-A110-40A2-A7CF-F2B11170DD8F%40adobe.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5523) filter pipe should be able to filter out resources that *have* a configured child

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5523:
---
Fix Version/s: Pipes 1.0.0

> filter pipe should be able to filter out resources that *have* a configured 
> child
> -
>
> Key: SLING-5523
> URL: https://issues.apache.org/jira/browse/SLING-5523
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5434-5523-DOC.patch, SLING-5523.patch
>
>
> implementing that feature as is could be complicated. A simple way of doing 
> it is to add a "not" flag that inverts the filter results (if filter passes 
> and not, filter fails, if filter fails and not, filter succeeds, filter 
> succeeds in other cases (exclusive or of filter and not flag))



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-5523) filter pipe should be able to filter out resources that *have* a configured child

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-5523:
--

Assignee: Robert Munteanu

> filter pipe should be able to filter out resources that *have* a configured 
> child
> -
>
> Key: SLING-5523
> URL: https://issues.apache.org/jira/browse/SLING-5523
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Attachments: SLING-5434-5523-DOC.patch, SLING-5523.patch
>
>
> implementing that feature as is could be complicated. A simple way of doing 
> it is to add a "not" flag that inverts the filter results (if filter passes 
> and not, filter fails, if filter fails and not, filter succeeds, filter 
> succeeds in other cases (exclusive or of filter and not flag))



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5434) WritePipe shoud remove properties at the very end

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5434:
---
Fix Version/s: Pipes 1.0.0

> WritePipe shoud remove properties at the very end
> -
>
> Key: SLING-5434
> URL: https://issues.apache.org/jira/browse/SLING-5434
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Fix For: Pipes 1.0.0
>
> Attachments: SLING-5434-DOC.patch, SLING-5434.patch
>
>
> in order to allow all expressions at current state to use the values of 
> properties to be removed.
> test & fix in attached patch
> related to thread 
> http://mail-archives.apache.org/mod_mbox/sling-users/201601.mbox/%3C2FBC4C5C-A110-40A2-A7CF-F2B11170DD8F%40adobe.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-5434) WritePipe shoud remove properties at the very end

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-5434:
--

Assignee: Robert Munteanu

> WritePipe shoud remove properties at the very end
> -
>
> Key: SLING-5434
> URL: https://issues.apache.org/jira/browse/SLING-5434
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Nicolas Peltier
>Assignee: Robert Munteanu
> Attachments: SLING-5434-DOC.patch, SLING-5434.patch
>
>
> in order to allow all expressions at current state to use the values of 
> properties to be removed.
> test & fix in attached patch
> related to thread 
> http://mail-archives.apache.org/mod_mbox/sling-users/201601.mbox/%3C2FBC4C5C-A110-40A2-A7CF-F2B11170DD8F%40adobe.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5530) Configuring DocumentNodeStore to use FileDataStore with latest Sling Launchpad doesn't work

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-5530.

Resolution: Fixed

Thanks for the patch, I have applied it in 
[r1731039|https://svn.apache.org/r1731039]

> Configuring DocumentNodeStore to use FileDataStore with latest Sling 
> Launchpad doesn't work
> ---
>
> Key: SLING-5530
> URL: https://issues.apache.org/jira/browse/SLING-5530
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad, Oak
>Reporter: Andrei Dulceanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Launchpad Builder 9
>
> Attachments: FileDataStore.patch
>
>
> I tried to configure DocumentNodeStore to use FileDataStore with Sling 
> Launchpad 8, as advised in [0]. 
> For this I created in ${sling.home}/install the following configurations:
> org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStoreService.cfg
> customBlobStore=true
> org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore.cfg
> minRecordLength=4096
> path=/some/path
> When starting launchpad with java -jar 
> org.apache.sling.launchpad-9-SNAPSHOT.jar 
> -Dsling.fileinstall.dir=sling/install the following exception is thrown:
> *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: 
> pid=org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore)] 
> org.apache.jackrabbit.oak-core 
> [org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore(196)] Error 
> during instantiation of the implementation object 
> (java.lang.NoClassDefFoundError: org/apache/jackrabbit/core/data/DataStore)
> The reason is that 
> org.apache.jackrabbit/jackrabbit-data/${jackrabbit.version} bundle is missing 
> from the provisioning model. Adding it solved the problem.
> [0] https://jackrabbit.apache.org/oak/docs/osgi_config.html#config-sling



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5530) Configuring DocumentNodeStore to use FileDataStore with latest Sling Launchpad doesn't work

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-5530:
---
Fix Version/s: Launchpad Builder 9

> Configuring DocumentNodeStore to use FileDataStore with latest Sling 
> Launchpad doesn't work
> ---
>
> Key: SLING-5530
> URL: https://issues.apache.org/jira/browse/SLING-5530
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad, Oak
>Reporter: Andrei Dulceanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Launchpad Builder 9
>
> Attachments: FileDataStore.patch
>
>
> I tried to configure DocumentNodeStore to use FileDataStore with Sling 
> Launchpad 8, as advised in [0]. 
> For this I created in ${sling.home}/install the following configurations:
> org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStoreService.cfg
> customBlobStore=true
> org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore.cfg
> minRecordLength=4096
> path=/some/path
> When starting launchpad with java -jar 
> org.apache.sling.launchpad-9-SNAPSHOT.jar 
> -Dsling.fileinstall.dir=sling/install the following exception is thrown:
> *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: 
> pid=org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore)] 
> org.apache.jackrabbit.oak-core 
> [org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore(196)] Error 
> during instantiation of the implementation object 
> (java.lang.NoClassDefFoundError: org/apache/jackrabbit/core/data/DataStore)
> The reason is that 
> org.apache.jackrabbit/jackrabbit-data/${jackrabbit.version} bundle is missing 
> from the provisioning model. Adding it solved the problem.
> [0] https://jackrabbit.apache.org/oak/docs/osgi_config.html#config-sling



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-5530) Configuring DocumentNodeStore to use FileDataStore with latest Sling Launchpad doesn't work

2016-02-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-5530:
--

Assignee: Robert Munteanu

> Configuring DocumentNodeStore to use FileDataStore with latest Sling 
> Launchpad doesn't work
> ---
>
> Key: SLING-5530
> URL: https://issues.apache.org/jira/browse/SLING-5530
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad, Oak
>Reporter: Andrei Dulceanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Launchpad Builder 9
>
> Attachments: FileDataStore.patch
>
>
> I tried to configure DocumentNodeStore to use FileDataStore with Sling 
> Launchpad 8, as advised in [0]. 
> For this I created in ${sling.home}/install the following configurations:
> org.apache.jackrabbit.oak.plugins.segment.SegmentNodeStoreService.cfg
> customBlobStore=true
> org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore.cfg
> minRecordLength=4096
> path=/some/path
> When starting launchpad with java -jar 
> org.apache.sling.launchpad-9-SNAPSHOT.jar 
> -Dsling.fileinstall.dir=sling/install the following exception is thrown:
> *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: 
> pid=org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore)] 
> org.apache.jackrabbit.oak-core 
> [org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore(196)] Error 
> during instantiation of the implementation object 
> (java.lang.NoClassDefFoundError: org/apache/jackrabbit/core/data/DataStore)
> The reason is that 
> org.apache.jackrabbit/jackrabbit-data/${jackrabbit.version} bundle is missing 
> from the provisioning model. Adding it solved the problem.
> [0] https://jackrabbit.apache.org/oak/docs/osgi_config.html#config-sling



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5533) Provide an XML generator for Sling Rewriter

2016-02-18 Thread Oliver Lietz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152049#comment-15152049
 ] 

Oliver Lietz commented on SLING-5533:
-

[~justinedelson] as there is an XML generator in {{acs-aem-commons}}, are you 
willing to bring it over to Sling or should I start from scratch?

> Provide an XML generator for Sling Rewriter
> ---
>
> Key: SLING-5533
> URL: https://issues.apache.org/jira/browse/SLING-5533
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Rewriter 1.1.2
>Reporter: Oliver Lietz
>
> Sling Rewriter comes with an HTML generator only. Having an XML generator 
> OOTB also would be very convenient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling Internationalization Support 2.4.6

2016-02-18 Thread Carsten Ziegeler
+1


-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org



[jira] [Created] (SLING-5533) Provide an XML generator for Sling Rewriter

2016-02-18 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-5533:
---

 Summary: Provide an XML generator for Sling Rewriter
 Key: SLING-5533
 URL: https://issues.apache.org/jira/browse/SLING-5533
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Rewriter 1.1.2
Reporter: Oliver Lietz


Sling Rewriter comes with an HTML generator only. Having an XML generator OOTB 
also would be very convenient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [RESULT] [VOTE] Release Apache Sling Rewriter 1.1.2

2016-02-18 Thread Oliver Lietz
On Tuesday 27 October 2015 15:56:27 Justin Edelson wrote:
> Hi,
> The vote has passed with the following result :
> 
> +1 (binding): Justin Edelson, Stefan Seifert, Setfan Egli, Robert Munteau,
> and Oliver Lietz
> 
> I will copy this release to the Sling dist directory and
> promote the artifacts to the central Maven repository.
> 
> On Mon, Oct 19, 2015 at 11:50 AM Justin Edelson 
> 
> wrote:
> > Hi,
> > 
> > We solved 1 issue in this release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/1285
> > 
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-1356/
> > 
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> > 
> > Usage:
> > sh check_staged_release.sh 1356 /tmp/sling-staging
> > 
> > Please vote to approve this release:
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> > 
> > This majority vote is open for at least 72 hours.

Did some missing tasks (updating news and download, closing issue, managing 
versions) to finalize the release.

O.



[jira] [Closed] (SLING-5072) Adjust filter order for RewriterFilter to accomodate changes from SLING-2920

2016-02-18 Thread Oliver Lietz (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-5072.
---

> Adjust filter order for RewriterFilter to accomodate changes from SLING-2920
> 
>
> Key: SLING-5072
> URL: https://issues.apache.org/jira/browse/SLING-5072
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Justin Edelson
>Assignee: Justin Edelson
> Fix For: Rewriter 1.1.2
>
>
> Based on the changes in SLING-2920, the order of the RewriterFilter needs to 
> be adjusted as it is now significantly later in the filter stack.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152002#comment-15152002
 ] 

Carsten Ziegeler commented on SLING-5531:
-

Actually I was wrong, the mapping should still be called per session
>From your comment above, it seems the Loader is not starting properly, however 
>diffing the versions I couldn't find a reason why this is the case

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-5531:

Assignee: (was: Carsten Ziegeler)

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [VOTE] Release Apache Sling Internationalization Support 2.4.6

2016-02-18 Thread Stefan Egli
+1

Cheers,
Stefan

On 18/02/16 09:59, "Julian Sedding"  wrote:

>Hi,
>
>We solved 2 issues in this release:
>https://issues.apache.org/jira/browse/SLING/fixforversion/12333246/
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1426
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1426 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
>
>Regards
>Julian




[jira] [Commented] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151982#comment-15151982
 ] 

Carsten Ziegeler commented on SLING-5531:
-

Thanks [~sseif...@pro-vision.de]
Looking at it again, I think I see the problem now: although the namespace 
registry calls are somewhere in the code, they were only triggered if a session 
was created (for the mapping). So it seems we had a bug in here for a long 
time, which we didn't discover as some session is always created. 

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE] Release Apache Sling Internationalization Support 2.4.6

2016-02-18 Thread Julian Sedding
Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12333246/

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1426

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1426 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Julian


[jira] [Commented] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151964#comment-15151964
 ] 

Stefan Seifert commented on SLING-5531:
---

i did not look deeper yet into the sources, but observed the following 
yesterday:
* in a instance running  JCR Base 2.3.0 (AEM in this case) i deployed a bundle 
with only a {{Sling-Namespaces}} header registering one custom namespace. the 
registration did not take place. setting DEBUG level for 
{{org.apache.sling.jcr.base.internal.loader}} did not generate any messages.
* i converted my Sling-Namespaces header to Sling-Nodetypes with a CND file 
containing only a namespace declaration - did not work either.
* i then switched back the svn folder 
https://svn.apache.org/repos/asf/sling/trunk/bundles/jcr/base to rev. 1695254 
(version 2.3.1-SNAPSHOT for jcr.base without any further changes), and 
additionally reverted the rev. 1694959 (SLING-4937 : Drop namespace mapping 
support), 1695250 (Use jcr api 2.3.0) and deployed this in the instance.
* the namespace was registered when redeploying my bundle


> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151956#comment-15151956
 ] 

Carsten Ziegeler commented on SLING-5531:
-

[~sseif...@pro-vision.de] It's still there, AbstractSlingRepository extends 
NamespaceMappingSupport which should do the mapping
AbstractSlingRepository2 use the manager which extends this as well. Looking at 
the changes of SLING-4937 I don't think that anything with respect to that has 
been removed - at least I can't find it.

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-5531:
---

Assignee: Carsten Ziegeler

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151940#comment-15151940
 ] 

Carsten Ziegeler commented on SLING-5531:
-

I'll have a look at it

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Assignee: Carsten Ziegeler
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5531) Declared Node Type Registration support broken in JCR Base

2016-02-18 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151934#comment-15151934
 ] 

Stefan Seifert commented on SLING-5531:
---

the {{Sling-Namespaces}} header is no more supported at all in JCR Base 2.3.0. 
which means it cannot be used any longer to register a global namespace in JCR 
even without the special sing-internal mapping supported dropped with 
SLING-4937.

> Declared Node Type Registration support broken in JCR Base
> --
>
> Key: SLING-5531
> URL: https://issues.apache.org/jira/browse/SLING-5531
> Project: Sling
>  Issue Type: Bug
>  Components: JCR
>Affects Versions: JCR Base 2.3.0
>Reporter: Stefan Seifert
>Priority: Critical
> Fix For: JCR Base 2.3.2
>
>
> the changes for SLING-4937 (Drop namespace mapping support) broke the 
> "Declared Node Type Registration" feature described in [1].
> this allows to register custom JCR namespaces or nodetypes via a CND file 
> when deploying a bundle and specifying the CND file via a {{Sling-Nodetypes}} 
> bundle header.
> i assume only the support for {{Sling-Namespaces}} should be removed with 
> SLING-4937, not the support for {{Sling-Nodetypes}}.
> [1] 
> https://sling.apache.org/documentation/bundles/content-loading-jcr-contentloader.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5532) resolver.map(../messaging.html) results in NPE

2016-02-18 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-5532.
-
Resolution: Fixed

Fixed by reintroducing the absolute path check (null, empty or not starting 
with /)

> resolver.map(../messaging.html) results in NPE
> --
>
> Key: SLING-5532
> URL: https://issues.apache.org/jira/browse/SLING-5532
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.4.0, Resource Resolver 1.4.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Resource Resolver 1.4.4
>
>
> Another regression from the rewrite of the resource resolver



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Random Failure to Deploy a File using AddOrUpdateNodeCommand

2016-02-18 Thread Robert Munteanu
Hi Andy,

On Wed, 2016-02-17 at 19:41 -0500, Andreas Schaefer Sr. wrote:
> Hi
> 
> During the development of the IntelliJ plugin I ran into some random
> failures to deploy.
> Looking deeper I save that the failure is happening when
> session.save() is called and
> to my surprise a slight delay (Thread.sleep(100)) does fix it on my
> Mac.
> 
> The code is in JcrCommand inside the impl-vlt module. This is the
> change that make it
> work for me:
> 
> @Override
> public Result execute() {
> 
> Session session = null;
> try {
> session = repository.login(credentials);
> 
> T result = execute0(session);
> 
> try {
> Thread.sleep(100);
> } catch(InterruptedException e) {
> }
> session.save();
> 
> return JcrResult.success(result);
> The exception I see is a ItemExistsException and was thrown for a
> folder and rendition file in the DAM.


Can you add a stack trace? Does this only happen for DAM assets +
renditions?

Robert