[jira] [Created] (SLING-6517) A condition that is always true.
JC created SLING-6517:
-
Summary: A condition that is always true.
Key: SLING-6517
URL: https://issues.apache.org/jira/browse/SLING-6517
Project: Sling
Issue Type: Bug
Reporter: JC
Priority: Trivial
I've recently found a condition that always returns true from the current
Github snapshot.
Path:
contrib/extensions/rewriter/src/main/java/org/apache/sling/rewriter/impl/components/TraxErrorHandler.java
{code:java}
86 private String getMessage(TransformerException exception) {
87 SourceLocator locator = exception.getLocator();
88 if (locator != null) {
89 String id =
(!locator.getPublicId().equals(locator.getPublicId()))
90 ? locator.getPublicId()
91 : (null != locator.getSystemId())
92 ? locator.getSystemId() : "SystemId Unknown";
93 return "File " + id
94+ "; Line " + locator.getLineNumber()
95+ "; Column " + locator.getColumnNumber()
96+ "; " + exception.getMessage();
97 }
98 return exception.getMessage();
99 }
100 }
{code}
In Line 89, locator.getPublicId().equals(locator.getPublicId()) compares the
same Id. It looks like a minor issue and typos but wanted to report just in
case.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (SLING-6512) Distribution ITs fail as they expect packages to be deleted synchronously
[ https://issues.apache.org/jira/browse/SLING-6512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-6512: - Assignee: Timothee Maret (was: Tommaso Teofili) > Distribution ITs fail as they expect packages to be deleted synchronously > - > > Key: SLING-6512 > URL: https://issues.apache.org/jira/browse/SLING-6512 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Tommaso Teofili >Assignee: Timothee Maret > Attachments: SLING-6512.0.patch > > > After the fix for SLING-6503, packages are not deleted upon release > synchronously, they are removed asynchronously in a separate thread. > We should adjust the test not to expect such packages to be removed > immediately after their processing, /cc [~marett] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SLING-6512) Distribution ITs fail as they expect packages to be deleted synchronously
[ https://issues.apache.org/jira/browse/SLING-6512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861269#comment-15861269 ] Timothee Maret commented on SLING-6512: --- Thanks [~teofili]! I'll have a look > Distribution ITs fail as they expect packages to be deleted synchronously > - > > Key: SLING-6512 > URL: https://issues.apache.org/jira/browse/SLING-6512 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Attachments: SLING-6512.0.patch > > > After the fix for SLING-6503, packages are not deleted upon release > synchronously, they are removed asynchronously in a separate thread. > We should adjust the test not to expect such packages to be removed > immediately after their processing, /cc [~marett] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SLING-6512) Distribution ITs fail as they expect packages to be deleted synchronously
[ https://issues.apache.org/jira/browse/SLING-6512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated SLING-6512: --- Attachment: SLING-6512.0.patch attaching a patch which I think it could fix the issue by setting a shorter cleanup delay within the VaultFactories, however the IT failures stay. > Distribution ITs fail as they expect packages to be deleted synchronously > - > > Key: SLING-6512 > URL: https://issues.apache.org/jira/browse/SLING-6512 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Tommaso Teofili >Assignee: Tommaso Teofili > Attachments: SLING-6512.0.patch > > > After the fix for SLING-6503, packages are not deleted upon release > synchronously, they are removed asynchronously in a separate thread. > We should adjust the test not to expect such packages to be removed > immediately after their processing, /cc [~marett] -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[RESULT] [VOTE] Release Apache Sling Content Distribution Core 0.2.0
Hi, Thanks all for voting! The vote has passed with the following result : +1 (binding): Robert, Stefan S., Antonio +1 (non binding): Tommaso Could someone from the PMC please copy the release to the Sling dist repository ? Regards, Timothee
Re: [VOTE] Release Apache Sling Content Distribution Core 0.2.0
+1 On Feb 7, 2017, at 5:19 PM, Timothee Maret wrote: > Hi, > > We solved 50 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12328963 > > There are still some outstanding issues: > https://issues.apache.org/jira/browse/SLING/component/12323405 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1634/ > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1634 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Content Distribution Core 0.2.0
Hi, Thanks for voting! This issue is still one vote short to pass though. Could someone from the PMC please cast a vote ? Regards, Timothee
