[jira] [Commented] (SLING-2696) Comply with project branding guidelines
[ https://issues.apache.org/jira/browse/SLING-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969453#comment-15969453 ] ASF GitHub Bot commented on SLING-2696: --- GitHub user auniverseaway opened a pull request: https://github.com/apache/sling/pull/214 SLING-2696 - Update Logo This is to address [SLING-2696](https://issues.apache.org/jira/browse/SLING-2696). I did not modify any samples. Only the logo for launchpad/content and the webconsolebranding bundle. I removed the old PNGs and put the new ones in retaining the same height. You can merge this pull request into a Git repository by running: $ git pull https://github.com/auniverseaway/sling SLING-2696_Update_Logo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 commit 8647b878182272a990403c981283eaefcf81d5d0 Author: Chris Millar Date: 2017-04-14T19:47:47Z SLING-2696 - Update Logo > Comply with project branding guidelines > --- > > Key: SLING-2696 > URL: https://issues.apache.org/jira/browse/SLING-2696 > Project: Sling > Issue Type: Task > Components: General >Reporter: Bertrand Delacretaz >Assignee: Oliver Lietz >Priority: Minor > Attachments: Apache Sling Logo 2017.zip > > > We need to comply with http://www.apache.org/foundation/marks/pmcs.html - the > current status is > Logos and Graphics: TM missing from all Logos > Project Website Basics: done > Project Naming And Descriptions: done > Website Navigation Links: done > Trademark Attributions: done > Project Metadata: done -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] sling pull request #214: SLING-2696 - Update Logo
GitHub user auniverseaway opened a pull request: https://github.com/apache/sling/pull/214 SLING-2696 - Update Logo This is to address [SLING-2696](https://issues.apache.org/jira/browse/SLING-2696). I did not modify any samples. Only the logo for launchpad/content and the webconsolebranding bundle. I removed the old PNGs and put the new ones in retaining the same height. You can merge this pull request into a Git repository by running: $ git pull https://github.com/auniverseaway/sling SLING-2696_Update_Logo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/214.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #214 commit 8647b878182272a990403c981283eaefcf81d5d0 Author: Chris Millar Date: 2017-04-14T19:47:47Z SLING-2696 - Update Logo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Sling IDE API - Refactoring
Hi Konrad, On Wed, 2017-04-12 at 15:14 +0200, Konrad Windszus wrote: > In the context of https://issues.apache.org/jira/browse/SLING-4043 I > had a closer look at the Sling IDE Tooling API again and made a new > proposal on it in https://cwiki.apache.org/confluence/x/eAsjB. > That should solve several of the issues we had with the API in the > past. > It would be good to hear some feedback on that, some parts are only > roughly outlined up till now, especially the SerializationManager > part seems to be a tricky one. > I would like to hear some feedback on the proposal before I go ahead > and implement that in a dedicated feature branch on Github. Thanks for taking this up, the proposal looks good overall. Some specific comments: 1. The ResourceProxy allows access to children but not to parents. Why not parents as well? The current version sort of evolved from a thin layer of properties to allow children access, but I'm not sure why we don't allow that in the future. 2. For the ResourceProxy it might be worth introducing a PropertyType concept. Right now IIRC we don't distinguish between the Reference and WeakReference because they are both backed by an UUID. 3. Where would the ResourceManager fit in for the IDE tooling? Currently we have a command concept that is used to perform remote changes, which allows us to do batching/sorting/compacting. Robert
