Unable to remove Slingshot from slingstart based on Sling 9

2017-06-19 Thread Robert Munteanu
Hi,

I'm trying to get a slingstart up which is based on Sling 9 but removes
  Slingshot.

I generated a project using the slingstart-maven-archetype, and I have
two provisioning model files

src/main/provisioning/model.txt:

[feature name=model]
[artifacts]
  org.apache.sling/org.apache.sling.launchpad/9/slingstart

src/main/provisioning/sling.txt:

[feature name=sling]
[artifacts runModes=:remove]
 
org.apache.sling/org.apache.sling.sample.slingshot/0.8.0/slingfeature/s
lingfeature

However, slingshot is still provisioned when I build and start the
slingstart.

Is this expected to work?

Thanks,

Robert


[jira] [Resolved] (SLING-6966) Sling Models Jackson Exporter always uses default Resource serialization for a model class which extends AbstractResource or implements the Resource interface

2017-06-19 Thread Justin Edelson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-6966.
---
Resolution: Fixed

fixed in r1799221, with unit test

> Sling Models Jackson Exporter always uses default Resource serialization for 
> a model class which extends AbstractResource or implements the Resource 
> interface
> --
>
> Key: SLING-6966
> URL: https://issues.apache.org/jira/browse/SLING-6966
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Sling Models Jackson Exporter 1.0.6
>Reporter: Justin Edelson
>Assignee: Justin Edelson
> Fix For: Sling Models Jackson Exporter 1.0.8
>
>
> If there is a model class which looks like this:
> {code}
> @Model(adaptable = SlingHttpServletRequest.class, resourceType = "something")
> @Exporter(name = "jackson", extensions = "json")
> public class Foo extends AbstractResource {
> 
> }
> {code}
> Then attempts to export this resource will always use the default Resource 
> serialization and not use the "bean" serialization technique used by Jackson. 
> This is because Jackson will first find the ResourceSerializer based on the 
> Resource interface before constructing a BeanSerializer. The serializer 
> lookup logic should be customized to skip any class with the {{@Model}} 
> annotation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (SLING-6966) Sling Models Jackson Exporter always uses default Resource serialization for a model class which extends AbstractResource or implements the Resource interface

2017-06-19 Thread Justin Edelson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson updated SLING-6966:
--
Summary: Sling Models Jackson Exporter always uses default Resource 
serialization for a model class which extends AbstractResource or implements 
the Resource interface  (was: Sling Models Jackson Exporter always uses default 
Resource serialization for a model class which extends AbstractResource or 
implements the Resource implementation)

> Sling Models Jackson Exporter always uses default Resource serialization for 
> a model class which extends AbstractResource or implements the Resource 
> interface
> --
>
> Key: SLING-6966
> URL: https://issues.apache.org/jira/browse/SLING-6966
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Sling Models Jackson Exporter 1.0.6
>Reporter: Justin Edelson
>Assignee: Justin Edelson
> Fix For: Sling Models Jackson Exporter 1.0.8
>
>
> If there is a model class which looks like this:
> {code}
> @Model(adaptable = SlingHttpServletRequest.class, resourceType = "something")
> @Exporter(name = "jackson", extensions = "json")
> public class Foo extends AbstractResource {
> 
> }
> {code}
> Then attempts to export this resource will always use the default Resource 
> serialization and not use the "bean" serialization technique used by Jackson. 
> This is because Jackson will first find the ResourceSerializer based on the 
> Resource interface before constructing a BeanSerializer. The serializer 
> lookup logic should be customized to skip any class with the {{@Model}} 
> annotation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (SLING-6966) Sling Models Jackson Exporter always uses default Resource serialization for a model class which extends AbstractResource or implements the Resource implementation

2017-06-19 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6966:
-

 Summary: Sling Models Jackson Exporter always uses default 
Resource serialization for a model class which extends AbstractResource or 
implements the Resource implementation
 Key: SLING-6966
 URL: https://issues.apache.org/jira/browse/SLING-6966
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Sling Models Jackson Exporter 1.0.6
Reporter: Justin Edelson
Assignee: Justin Edelson
 Fix For: Sling Models Jackson Exporter 1.0.8


If there is a model class which looks like this:

{code}
@Model(adaptable = SlingHttpServletRequest.class, resourceType = "something")
@Exporter(name = "jackson", extensions = "json")
public class Foo extends AbstractResource {



}
{code}

Then attempts to export this resource will always use the default Resource 
serialization and not use the "bean" serialization technique used by Jackson. 
This is because Jackson will first find the ResourceSerializer based on the 
Resource interface before constructing a BeanSerializer. The serializer lookup 
logic should be customized to skip any class with the {{@Model}} annotation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: [VOTE] Release Apache Sling Testing Clients 1.1.4, Apache Sling Testing Email Support 1.0.0

2017-06-19 Thread Stefan Egli
+1

Cheers,
Stefan

On 15/06/17 18:21, "Robert Munteanu"  wrote:

>Hi,
>
>We solved 2 issues in these release:
>https://issues.apache.org/jira/projects/SLING/versions/12340947
>https://issues.apache.org/jira/projects/SLING/versions/12340957
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-1744
>
>You can use this UNIX script to download the release and verify the
>signatures:
>http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
>Usage:
>sh check_staged_release.sh 1744 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.




[jira] [Created] (SLING-6965) Sling Models Jackson Exporter Fails with default resource serialization for a resource with a child

2017-06-19 Thread Justin Edelson (JIRA)
Justin Edelson created SLING-6965:
-

 Summary: Sling Models Jackson Exporter Fails with default resource 
serialization for a resource with a child
 Key: SLING-6965
 URL: https://issues.apache.org/jira/browse/SLING-6965
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Sling Models Jackson Exporter 1.0.6
Reporter: Justin Edelson
Assignee: Justin Edelson
 Fix For: Sling Models Jackson Exporter 1.0.8


If a model class has a serialized Resource field/getter and that Resource has 
children, the serialization will fail with a stack trace like

{code}
Caused by: com.fasterxml.jackson.core.JsonGenerationException: Can not start an 
object, expecting field name (context: Object)
at 
com.fasterxml.jackson.core.JsonGenerator._reportError(JsonGenerator.java:1897)
at 
com.fasterxml.jackson.core.json.JsonGeneratorImpl._reportCantWriteValueExpectName(JsonGeneratorImpl.java:244)
at 
com.fasterxml.jackson.core.json.WriterBasedJsonGenerator._verifyValueWrite(WriterBasedJsonGenerator.java:815)
at 
com.fasterxml.jackson.core.json.WriterBasedJsonGenerator.writeStartObject(WriterBasedJsonGenerator.java:268)
at 
org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.create(ResourceSerializer.java:52)
at 
org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.create(ResourceSerializer.java:100)
at 
org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.serialize(ResourceSerializer.java:46)
at 
org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.serialize(ResourceSerializer.java:35)
at 
com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:292)
at 
com.fasterxml.jackson.databind.ObjectMapper.writeValue(ObjectMapper.java:2493)
at 
org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(JacksonExporter.java:117)
{code}

This is because the object is started twice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Resolved] (SLING-6965) Sling Models Jackson Exporter Fails with default resource serialization for a resource with a child

2017-06-19 Thread Justin Edelson (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Edelson resolved SLING-6965.
---
Resolution: Fixed

fixed in r1799218 with updated IT

> Sling Models Jackson Exporter Fails with default resource serialization for a 
> resource with a child
> ---
>
> Key: SLING-6965
> URL: https://issues.apache.org/jira/browse/SLING-6965
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Sling Models Jackson Exporter 1.0.6
>Reporter: Justin Edelson
>Assignee: Justin Edelson
> Fix For: Sling Models Jackson Exporter 1.0.8
>
>
> If a model class has a serialized Resource field/getter and that Resource has 
> children, the serialization will fail with a stack trace like
> {code}
> Caused by: com.fasterxml.jackson.core.JsonGenerationException: Can not start 
> an object, expecting field name (context: Object)
> at 
> com.fasterxml.jackson.core.JsonGenerator._reportError(JsonGenerator.java:1897)
> at 
> com.fasterxml.jackson.core.json.JsonGeneratorImpl._reportCantWriteValueExpectName(JsonGeneratorImpl.java:244)
> at 
> com.fasterxml.jackson.core.json.WriterBasedJsonGenerator._verifyValueWrite(WriterBasedJsonGenerator.java:815)
> at 
> com.fasterxml.jackson.core.json.WriterBasedJsonGenerator.writeStartObject(WriterBasedJsonGenerator.java:268)
> at 
> org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.create(ResourceSerializer.java:52)
> at 
> org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.create(ResourceSerializer.java:100)
> at 
> org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.serialize(ResourceSerializer.java:46)
> at 
> org.apache.sling.models.jacksonexporter.impl.ResourceSerializer.serialize(ResourceSerializer.java:35)
> at 
> com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:292)
> at 
> com.fasterxml.jackson.databind.ObjectMapper.writeValue(ObjectMapper.java:2493)
> at 
> org.apache.sling.models.jacksonexporter.impl.JacksonExporter.export(JacksonExporter.java:117)
> {code}
> This is because the object is started twice.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: [VOTE] Release Apache Sling Testing Clients 1.1.4, Apache Sling Testing Email Support 1.0.0

2017-06-19 Thread Robert Munteanu
Ping? We still need 2 votes for these releases.

On Thu, 2017-06-15 at 19:21 +0300, Robert Munteanu wrote:
> Hi,
> 
> We solved 2 issues in these release:
> https://issues.apache.org/jira/projects/SLING/versions/12340947
> https://issues.apache.org/jira/projects/SLING/versions/12340957
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-174
> 4
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1744 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.



[jira] [Commented] (SLING-6955) Convert Sling website to JBake and gitpubsub

2017-06-19 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053960#comment-16053960
 ] 

Bertrand Delacretaz commented on SLING-6955:


I have moved the repository to 
https://git-wip-us.apache.org/repos/asf?p=sling-site.git and asked for a 
temporary live setup to test the results before switching, INFRA-14390

> Convert Sling website to JBake and gitpubsub
> 
>
> Key: SLING-6955
> URL: https://issues.apache.org/jira/browse/SLING-6955
> Project: Sling
>  Issue Type: Bug
>  Components: Site
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>
> I've started experimenting with JBake to generate the Sling website. If that 
> works well we might switch to that + gitpubsub to have a more flexible way to 
> generate the site.
> My current experiment is at https://github.com/bdelacretaz/sling-jbake, at 
> this point the site starts looking like the current one and many pages work 
> well. 
> Internal links will need to be converted, all *.md files need a more complete 
> "front matter" section, currently I have a stub for that, and I think images 
> need to move under the assets folder.
> To play with that, generate the site with the bake.sh script (setup 
> shamelessly copied from https://github.com/apache/incubator-tamaya-site)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (SLING-6955) Convert Sling website to JBake and gitpubsub

2017-06-19 Thread Bertrand Delacretaz (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053890#comment-16053890
 ] 

Bertrand Delacretaz commented on SLING-6955:


Note that JBake is moving from the pegdown Markdown parser to flexmark-java, 
probably in the next version, see https://github.com/jbake-org/jbake/pull/376 
and https://github.com/vsch/flexmark-java

> Convert Sling website to JBake and gitpubsub
> 
>
> Key: SLING-6955
> URL: https://issues.apache.org/jira/browse/SLING-6955
> Project: Sling
>  Issue Type: Bug
>  Components: Site
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>
> I've started experimenting with JBake to generate the Sling website. If that 
> works well we might switch to that + gitpubsub to have a more flexible way to 
> generate the site.
> My current experiment is at https://github.com/bdelacretaz/sling-jbake, at 
> this point the site starts looking like the current one and many pages work 
> well. 
> Internal links will need to be converted, all *.md files need a more complete 
> "front matter" section, currently I have a stub for that, and I think images 
> need to move under the assets folder.
> To play with that, generate the site with the bake.sh script (setup 
> shamelessly copied from https://github.com/apache/incubator-tamaya-site)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: Sling Node Type Web Console Plugin

2017-06-19 Thread Bertrand Delacretaz
Hi,

On Sat, Jun 17, 2017 at 10:06 PM, Andreas Schaefer Sr.  wrote:
> ...The Resource Provider is there to create a resource of a node type, 
> right?...

Yes, the idea is that a request like /system/nodetypes.tidy.99.json
outputs a JSON dump of all nodetypes.

> ...The list of node types and their dependencies is then handling in a
> “Web Console Plugin” to display them inside the OSGi console?...

Yes, that plugin would (internally) make that request and format the output.

>
> ...Does anyone know a good example of them (Resource Provider and Web
> Console Plugin) I could use as template?...

I think the simplest ResourceProvider example is the
PlanetResourceProvider used in our tests [1] , and the JMX
ResourceProvider [2] has similarities to what you need.


We have many webconsole plugin in our codebase. The Health Checks
plugin [2] is a relatively simple one.

-Bertrand

[1] 
https://svn.apache.org/repos/asf/sling/trunk/launchpad/test-services/src/main/java/org/apache/sling/launchpad/testservices/resourceprovider/
[2] https://svn.apache.org/repos/asf/sling/trunk/contrib/extensions/jmxprovider
[3] 
https://svn.apache.org/repos/asf/sling/trunk/bundles/extensions/healthcheck/webconsole


Re: FYI, working on moving to JBake for the Sling website

2017-06-19 Thread Bertrand Delacretaz
On Mon, Jun 19, 2017 at 8:21 AM, Oliver Lietz  wrote:
> ...I did start  a POC last year with JBake and Thymeleaf...

Ok, sorry I didn't remember that. I went with GroovyMarkupTemplates as
I like that language quite a lot in general.

I'll see if I can get that website up on a temporary domain so that we
can fully test it, the todo list has nicely shrunk after my travel
last week.

-Bertrand


Re: [VOTE] Release Apache Sling Resource Merger 1.3.4

2017-06-19 Thread Radu Cotescu
+1

On Fri, 16 Jun 2017 at 17:01 Konrad Windszus 
wrote:

> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Thanks,
> Konrad


Re: [VOTE] Release Apache Sling Resource Merger 1.3.4

2017-06-19 Thread Robert Munteanu
On Fri, 2017-06-16 at 16:01 +0200, Konrad Windszus wrote:
> Please vote to approve this release: 


+1

Robet

signature.asc
Description: This is a digitally signed message part