[jira] [Commented] (SLING-7922) Update to latest available releases for Sling 11

2018-09-13 Thread Carsten Ziegeler (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614407#comment-16614407
 ] 

Carsten Ziegeler commented on SLING-7922:
-

For Apache Felix we should update:
- the webconsole to 4.3.8 (released today)
- config admin to 1.9.6 (released next week)
- scr 2.1.8 (hopefully released end of next week)


> Update to latest available releases for Sling 11
> 
>
> Key: SLING-7922
> URL: https://issues.apache.org/jira/browse/SLING-7922
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
>
> Should look into:
> - Sling modules that are released but not included
> - Felix bundles
> - Oak 1.8
> - Other misc dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling Slingshot Sample 0.9.0

2018-09-13 Thread Carsten Ziegeler
+1


Robert Munteanu wrote
> Hi,
> 
> We solved 2 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12338911
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1974
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 1974 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Jackrabbit JSR-283 Access Control Manager Support 3.0.2

2018-09-13 Thread Carsten Ziegeler
+1


Robert Munteanu wrote
> Hi,
> 
> We solved 4 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12341398
> 
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1975
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 1975 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Jackrabbit UserManager Support 2.2.8

2018-09-13 Thread Carsten Ziegeler
+1


Robert Munteanu wrote
> Hi,
> 
> We solved 5 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12340294
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1976
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 1976 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Content Distribution Core version 0.3.2

2018-09-13 Thread Carsten Ziegeler
+1


Nicolas Peltier wrote
> Hi,
> 
> We solved 1 issue in this release:
> 
> https://issues.apache.org/jira/projects/SLING/versions/12344107
> 
> There are still some outstanding issues:
> 
> https://jira.apache.org/jira/browse/SLING-7775?jql=project%20%3D%20SLING%20AND%20component%20%3D%20%22Content%20Distribution%22%20AND%20status%20%3D%20Open%20
> 
> Staging repository:
> 
> https://repository.apache.org/content/repositories/orgapachesling-1983/
> 
> You can use this UNIX script to download the release and verify the
> signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 1983 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Pipes version 3.0.2

2018-09-13 Thread Carsten Ziegeler
+1


Nicolas Peltier wrote
> Hi,
> 
> We solved 21 issues in this
> release:https://issues.apache.org/jira/projects/SLING/versions/12342862
> 
> There are still 5 outstanding
> issues:https://issues.apache.org/jira/browse/SLING-7250
> https://issues.apache.org/jira/browse/SLING-7772
> https://issues.apache.org/jira/browse/SLING-7708 (doc bug that is being fixed)
> https://issues.apache.org/jira/browse/SLING-6593
> https://issues.apache.org/jira/browse/SLING-7425
> 
> also will add some documentation in case release:perform process step
> goes wrong :-)
> 
> 
>  Staging 
> repository:https://repository.apache.org/content/repositories/orgapachesling-1982
> 
> You can use this UNIX script to download the release and verify the
> signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 1982 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Created] (SLING-7924) ValidationModelRetriever does not correctly evaluate "applicable path"

2018-09-13 Thread Konrad Windszus (JIRA)
Konrad Windszus created SLING-7924:
--

 Summary: ValidationModelRetriever does not correctly evaluate 
"applicable path"
 Key: SLING-7924
 URL: https://issues.apache.org/jira/browse/SLING-7924
 Project: Sling
  Issue Type: Bug
  Components: Validation
Affects Versions: Validation Core 1.0.4
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Validation Core 1.0.6


Currently in 
[https://github.com/apache/sling-org-apache-sling-validation-core/blob/4d56bb636a3b68cd1bed5d6b03f194a41e0aef75/src/main/java/org/apache/sling/validation/impl/ValidationModelRetrieverImpl.java#L114]
 there is a PatriciaTrie from Apache Commons Collections being used to figure 
out the validation model bound to a specific resource with the most specific 
applicable path which still matches.

This does not work as the method {{PatriciaTrie.subMap}} returns all keys which 
are less than the given path according to lexicographical ordering.

That means, in case the trie would contain entries for "/", and "/a/b", a 
lookup for "/a/c" would return "/a/b" although the latter does not start with 
the former.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling Pipes version 3.0.2

2018-09-13 Thread Daniel Klco
+1

On Thu, Sep 13, 2018 at 10:50 AM Robert Munteanu  wrote:

> On Thu, 2018-09-13 at 12:31 +0200, Nicolas Peltier wrote:
> > Please vote to approve this release:
>
> +1
>
> And BTW, you probably want to fix this
>
> [WARNING]
> /tmp/sling-staging/1982/org/apache/sling/org.apache.sling.pipes/3.0.2/org.apache.sling.pipes-3.0.2/src/main/java/org/apache/sling/pipes/internal/CsvWriter.java:[19,48]
> com.sun.org.apache.bcel.internal.generic.NEW is internal proprietary API
> and may be removed in a future release
>
> Thanks,
>
> Robert
>


Re: [VOTE] Release Apache Sling Content Distribution Core version 0.3.2

2018-09-13 Thread Daniel Klco
+1

On Thu, Sep 13, 2018 at 10:59 AM Nicolas Peltier 
wrote:

> Hi,
>
> We solved 1 issue in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12344107
>
> There are still some outstanding issues:
>
>
> https://jira.apache.org/jira/browse/SLING-7775?jql=project%20%3D%20SLING%20AND%20component%20%3D%20%22Content%20Distribution%22%20AND%20status%20%3D%20Open%20
>
> Staging repository:
>
> https://repository.apache.org/content/repositories/orgapachesling-1983/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 1983 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>


[hackathon] sling instrumenting / metrics

2018-09-13 Thread Stefan Seifert
- the sling metrics module is available for some time, but not much used to 
instrument sling currently
- we should apply it to the important parts of sling - e.g.:
  - sling engine: render times of requests, components, includes
  - filters execution times (currently custom "metrics" in web console)
  - sling jobs statistics (currently custom "metrics" in web console)

stefan



[hackathon] sling scripting

2018-09-13 Thread Stefan Seifert
- problems with current scripting implementation
  - some existing script engines do not check for existence of sling object
  - remove dependency on resource paths in sling scripting - should focus only 
on compiling the scripts, regardless of their source
- planned actions:
  - try to get rid of the dynamic classloader from scripting
  - try to apply the scripting enhancements that karl did in the whiteboard for 
the prototype of [1]

stefan

[1] https://adapt.to/2018/en/schedule/apache-sling-scripting-reloaded.html




[hackathon] health checks

2018-09-13 Thread Stefan Seifert
- currently there is some overlap between sling health checks and the new felix 
system readyness framework presented [1]
- the idea is to bring this together within felix
- provide a facade for the sling healthcheck API for backwards compatibility

stefan

[1] 
https://adapt.to/2018/en/schedule/system-readiness-framework-makes-deployment-automation-a-breeze.html




[hackathon] making it easier to contribute

2018-09-13 Thread Stefan Seifert
- our current contributing [1] page is very outdated - we have to update it 
- search over all sling git repos is difficult currently - possible solutions 
which all have some drawbacks
  - search via https://sourcegraph.com - this does not seem to work properly 
(does not find all occurences), perhaps needs to be rechecked
  - git submodules - drawback is we need a module list file that to be updated 
manually (Jenkins job would do, but ASF does not allow Jenkins job pushing 
thinks to the git repo without having a real committer involved)
  - repo-checkout all modules locally and search in filesystem - cumbersome for 
a quick search

- committer & contributor statistics can be found on: 
http://demo.kibble.apache.org
  - login with demo user
  - set sub-filter to: sling-(?!site)
  - (excluding sling-site to avoiding tons html file counting in the stats)
- be careful when merging external contributions into the sling codebase to 
keep the authorship information of the contributor in git history
- define PR template in github with link to contribution hints in sling site, 
annotation best practices etc.
  - include manual steps to be checked before contributing that are not checked 
by the build automatically

stefan

[1] https://sling.apache.org/contributing.html




Re: Sling pax exam tests: How to override a low level feature

2018-09-13 Thread Oliver Lietz
On Thursday 13 September 2018 10:23:30 Christian Schneider wrote:
> In some cases I want to pull up a sling instances in pax exam but want to
> remove some lower level bundles and replace them with some custom bundle.
> This can not be handled by simply providing a different version.

Right, you have to remove the bundle.

> An example is:
> I want to load sling using SlingOptions.slingDistribution() but I want to
> remove the sling event bundle and install my own bundle instead.
> 
> As the methods in SlingOptions are all static I can not simply extend the
> class and and override the SlingOptions.slingEvent() method.
> 
> So currently I copy all features that I need from SlingOptions into my own
> class and change what I need to change there. This is of course not very
> manageable and also kind of hides the fact that most of the bundle will
> stay the same.
> 
> Any ideas how to tackle this problem?

Remove the unwanted options (bundles) from your Sling options – that is quite 
easy in fact.

I will add a remove(Option) to CompositeOption in Pax Exam and change the 
return types in SlingOptions from Option to CompositeOption. 

Until then do it yourself by casting to CompositeOption and recreating the 
CompositeOption, see ContentloaderTestSupport#configuration():Option[] where I 
remove the Content Loader bundle and use the build artifact.

https://github.com/apache/sling-org-apache-sling-jcr-contentloader/blob/master/src/test/java/org/apache/sling/jcr/contentloader/it/ContentloaderTestSupport.java#L100

Regards,
O.

> Christian



[hackathon] Sling 11 TODOs

2018-09-13 Thread Stefan Seifert
- no need to release the modules which were migrated jetbrains null annotations 
before releasing sling 11
- move all starter-related testing modules to a single git repo, releasing them 
together
- long-term goal: move integration tests to the modules they test, but add 
support for running them centrally from a central place
- long-term goal: execute central ITs with all module builds
- updates felix bundles to latest versions
- update to latest stable oak 1.8.x version
- update sling bundles to latest versions

stefan



[hackathon] new JRE release cycles

2018-09-13 Thread Stefan Seifert
- in the future new JRE version will come up quite often
- we should set up integration tests for new JRE releases as soon as possible
- with the changes karl already did for supporting the current JRE versions is 
should no longer needed to do any manual changes to the code (e.g. properties 
files) for new JRE versions

stefan



[hackathon] feature model, osgi installer

2018-09-13 Thread Stefan Seifert
- the current osgi-installer is a candidate for deprecation
- the current feature model is indented to be used for "from-scratch" 
deployments defining and setting up a full instance - not for delta deployments 
of changes to an existing instance
- it would be nice if there would be some support for "on-top"/"delta" 
deployment for an instance that was setup with the feature model. this happens 
often in real life deployments currently.
- we should clean up the starter project to create a set of sensible features
- in some time in the future we should switch the starter to feature models 
(instead of provisioning files)
  - after sling 11 release, and when the feature model tooling is ready and 
released
  - after this switch: deprecate all other launch* stuff like crankstart, 
provisioning model etc. to make sure which is the current only supported way to 
do this things

stefan



Re: [hackathon] flagging sling modules as deprecated/contrib

2018-09-13 Thread Daniel Klco
One concern I have with the experimental (or perhaps the definition
therein) is that it seems much more bleeding edge than what we currently
consider contrib. Is there some more middle ground here, between "not part
of the "core"" and "use on your own risk, probably not well maintained"?

On Thu, Sep 13, 2018 at 12:42 PM Stefan Seifert 
wrote:

> - current contrib/deprecated state maintained in [1]
> - status explanations pages missing e.g. [2]
>
> - we currently have not process when a module should be marked as
> deprecated - here is a proposal:
>   - export statistics on module usage (downloads) from maven central
> statistics
>   - mark modules as deprecated that have both low usage and no committers
> willing to actively maintain it
>   - there is no "attic" any more, so labeling the module as deprecated is
> equivalent to attic
>   - this deprecation check should be done roughly once a year for all
> non-deprecated modules
>
> - the "contrib" flag is difficult to understand what it should mean - we
> propose to rename it
>   - it should be renamed to "experimental"
>   - modules labeled as experimental (or currently "contrib") must never be
> included in the sling starter
>   - (contrib modules currently includes in starter have to be removed or
> "un-contribbed")
>   - the meaning of "experimental" is: not indented for production use, use
> on your own risk, probably not well maintained
>
> - our sling download page [3] should reflect the deprecated or contrib
> status of the modules liste
>   - this page is the one page users detect most easily, and they should
> know when the module is not part of the "core"
>
> stefan
>
> [1] https://github.com/apache/sling-aggregator/blob/master/Sling-Repos.csv
> [2]
> https://github.com/apache/sling-aggregator/blob/master/docs/status/contrib.md
> [3] http://sling.apache.org/downloads.cgi
>
>
>


[hackathon] flagging sling modules as deprecated/contrib

2018-09-13 Thread Stefan Seifert
- current contrib/deprecated state maintained in [1]
- status explanations pages missing e.g. [2]

- we currently have not process when a module should be marked as deprecated - 
here is a proposal:
  - export statistics on module usage (downloads) from maven central statistics
  - mark modules as deprecated that have both low usage and no committers 
willing to actively maintain it
  - there is no "attic" any more, so labeling the module as deprecated is 
equivalent to attic
  - this deprecation check should be done roughly once a year for all 
non-deprecated modules

- the "contrib" flag is difficult to understand what it should mean - we 
propose to rename it
  - it should be renamed to "experimental"
  - modules labeled as experimental (or currently "contrib") must never be 
included in the sling starter
  - (contrib modules currently includes in starter have to be removed or 
"un-contribbed")
  - the meaning of "experimental" is: not indented for production use, use on 
your own risk, probably not well maintained

- our sling download page [3] should reflect the deprecated or contrib status 
of the modules liste
  - this page is the one page users detect most easily, and they should know 
when the module is not part of the "core"

stefan

[1] https://github.com/apache/sling-aggregator/blob/master/Sling-Repos.csv
[2] 
https://github.com/apache/sling-aggregator/blob/master/docs/status/contrib.md
[3] http://sling.apache.org/downloads.cgi




[hackathon] bnd-maven-plugin vs. maven-bundle-plugin

2018-09-13 Thread Stefan Seifert
- we would like to switch completely to bnd-maven-plugin, but without the need 
for a separate bnd file
- we currently have only one parent pom for bundle modules and non-bundle 
modules, making it difficult to configure the bnd-maven-plugin globally so it 
gets up picked only for bundles, not for simple jar files.
- using maven profiles would be an option, but there is no nice way to trigger 
the profile without ugly hacks like having an empty bnd file present.
- https://issues.apache.org/jira/browse/MJAR-193 would be another solution 
(haven the bnd plugin handing over the manifest extensions to the maven jar 
plugin), but this feature is not available yet

- the best solution seems to be to create an additional "sling-bundle-parent" 
inheriting from the existing "sling-parent"
- all bundle-related stuff goes there and will be removed from "sling-parent"
- old maven-bundle-plugin should be removed from sling-parent
- maven-bundle-plugin should be banned from sling-bundle-parent
- one repo for both, always released together
- start with next version 36
- make a wiki page with migration steps
- bundle modules will use "sling-bundle-parent", jar modules "sling-parent"

we will do a vote on this.

stefan



[hackathon] JCR-less sling

2018-09-13 Thread Stefan Seifert
- in the past, it was not possible to use Sling without JCR, but there was some 
work on it lately to remove this hard dependency
- Sling servlets are cleaned up and do no longer have a dependency
- A remaining blocker is the usage of service users all over the code base - 
providing service users still currently still depends on JCR
- carsten had a proposal on the mailing list to solve this some time ago and 
will create a JIRA issue to track ist

stefan



[jira] [Created] (SLING-7923) Simplify integration tests

2018-09-13 Thread Oliver Lietz (JIRA)
Oliver Lietz created SLING-7923:
---

 Summary: Simplify integration tests
 Key: SLING-7923
 URL: https://issues.apache.org/jira/browse/SLING-7923
 Project: Sling
  Issue Type: Improvement
  Components: JCR
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: JCR ContentLoader 2.2.8


* remove boilerplate code and use Testing PaxExam instead
* use Sling Parent 34 and bnd Maven plugins



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[hackathon] adaptTo() 2018 - Sling Committer round table & hackathon results

2018-09-13 Thread Stefan Seifert
on tuesday we had the Sling Committer round table @ adaptTo() in Potsdam, and 
today the Hackathon in the office of pro!vision Berlin.

i will publish the results *) of the discussions on this list using the 
"[hackathon]" prefix in the subject.

participants of the hackathon: Carsten, Nicolas, Oliver, Robert, Radu, Georg, 
Konrad, Karl, myself - and Dominik Süß, Ioan Eugen Stan.

stefan

*) not decisions - this will take place on this list



RE: Maven Site for slingfeature-maven-plugin

2018-09-13 Thread Stefan Seifert
i pushed the current snapshot site to
http://sling.apache.org/components/slingfeature-maven-plugin/

stefan

>-Original Message-
>From: Konrad Windszus 
>Sent: Tuesday, September 11, 2018 11:32 AM
>To: dev@sling.apache.org
>Subject: Maven Site for slingfeature-maven-plugin
>
>Would it be possible to publish the Maven generated documentation to
>http://sling.apache.org/components  like
>described in http://sling.apache.org/documentation/development/release-
>management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable?
>management.html#appendix-b-deploy-maven-plugin-documentation-if-applicable?>
>
>Thanks,
>Konrad




Re: [VOTE] Release Apache Sling Jackrabbit UserManager Support 2.2.8

2018-09-13 Thread Nicolas Peltier
+1

Le mer. 12 sept. 2018 à 21:28, Eric Norman  a
écrit :

> +1
>
> On Wed, Sep 12, 2018 at 8:47 AM Daniel Klco  wrote:
>
> > +1
> >
> > On Wed, Sep 12, 2018 at 8:24 AM Robert Munteanu 
> > wrote:
> >
> > > Hi,
> > >
> > > We solved 5 issues in this release:
> > > https://issues.apache.org/jira/projects/SLING/versions/12340294
> > >
> > > Staging repository:
> > > https://repository.apache.org/content/repositories/orgapachesling-1976
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > >
> > > Usage:
> > > sh check_staged_release.sh 1976 /tmp/sling-staging
> > >
> > > Please vote to approve this release:
> > >
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> > >
> > > This majority vote is open for at least 72 hours.
> > >
> > >
> >
>


Re: [VOTE] Release Apache Sling Jackrabbit JSR-283 Access Control Manager Support 3.0.2

2018-09-13 Thread Nicolas Peltier
+1

Le mer. 12 sept. 2018 à 21:27, Eric Norman  a
écrit :

> +1
>
> On Wed, Sep 12, 2018 at 8:43 AM Daniel Klco  wrote:
>
> > +1
> >
> > On Wed, Sep 12, 2018 at 8:22 AM Robert Munteanu 
> > wrote:
> >
> > > Hi,
> > >
> > > We solved 4 issues in this release:
> > > https://issues.apache.org/jira/projects/SLING/versions/12341398
> > >
> > >
> > > Staging repository:
> > > https://repository.apache.org/content/repositories/orgapachesling-1975
> > >
> > > You can use this UNIX script to download the release and verify the
> > > signatures:
> > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> > >
> > > Usage:
> > > sh check_staged_release.sh 1975 /tmp/sling-staging
> > >
> > > Please vote to approve this release:
> > >
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> > >
> > > This majority vote is open for at least 72 hours.
> > >
> > >
> >
>


Re: [VOTE] Release Apache Sling Slingshot Sample 0.9.0

2018-09-13 Thread Nicolas Peltier
+1

Le mer. 12 sept. 2018 à 17:31, Daniel Klco  a écrit :

> +1
>
> On Wed, Sep 12, 2018 at 8:20 AM Robert Munteanu 
> wrote:
>
> > Hi,
> >
> > We solved 2 issues in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12338911
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-1974
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 1974 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> >
>


[VOTE] Release Apache Sling Content Distribution Core version 0.3.2

2018-09-13 Thread Nicolas Peltier
Hi,

We solved 1 issue in this release:

https://issues.apache.org/jira/projects/SLING/versions/12344107

There are still some outstanding issues:

https://jira.apache.org/jira/browse/SLING-7775?jql=project%20%3D%20SLING%20AND%20component%20%3D%20%22Content%20Distribution%22%20AND%20status%20%3D%20Open%20

Staging repository:

https://repository.apache.org/content/repositories/orgapachesling-1983/

You can use this UNIX script to download the release and verify the
signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1983 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


Re: [VOTE] Release Apache Sling App CMS version 0.10.0

2018-09-13 Thread Daniel Klco
Robert,

My understanding is these dependencies are coming from Gulp, our build tool
not from the built code. While the warnings aren't ideal, we're not
including minmatch, lodash or graceful-fs in our final JS / CSS builds,
they are just used to build our code.

I'll try to figure out which plugin is emitting these errors and remove /
replace it, but I'd vote to move forward with the release as this is a
compile-time not runtime issue.

Hope that helps!

-Dan

On Thu, Sep 13, 2018 at 10:14 AM Robert Munteanu  wrote:

> Hi,
>
> I noticed the following when building the CMS
>
> [WARNING] npm WARN notice [SECURITY] lodash has the following
> vulnerability: 1 low. Go here for more details:
> https://nodesecurity.io/advisories?search=lodash&version=1.0.2 - Run `npm
> i npm@latest -g` to upgrade your npm version, and then `npm audit` to get
> more info.
> [WARNING] npm WARN deprecated graceful-fs@1.2.3: please upgrade to
> graceful-fs 4 for compatibility with current and future versions of Node.js
> [WARNING] npm WARN notice [SECURITY] minimatch has the following
> vulnerability: 1 high. Go here for more details:
> https://nodesecurity.io/advisories?search=minimatch&version=0.2.14 - Run
> `npm i npm@latest -g` to upgrade your npm version, and then `npm audit`
> to get more info.
> [WARNING] npm WARN notice [SECURITY] minimatch has the following
> vulnerability: 1 high. Go here for more details:
> https://nodesecurity.io/advisories?search=minimatch&version=2.0.10 - Run
> `npm i npm@latest -g` to upgrade your npm version, and then `npm audit`
> to get more info.
>
> Is this something that we should redo for the release or is it OK to
> release this way?
>
> Thanks,
>
> Robert
>
>


Re: [VOTE] Release Apache Sling Pipes version 3.0.2

2018-09-13 Thread Robert Munteanu
On Thu, 2018-09-13 at 12:31 +0200, Nicolas Peltier wrote:
> Please vote to approve this release:

+1

And BTW, you probably want to fix this

[WARNING] 
/tmp/sling-staging/1982/org/apache/sling/org.apache.sling.pipes/3.0.2/org.apache.sling.pipes-3.0.2/src/main/java/org/apache/sling/pipes/internal/CsvWriter.java:[19,48]
 com.sun.org.apache.bcel.internal.generic.NEW is internal proprietary API and 
may be removed in a future release

Thanks,

Robert


signature.asc
Description: This is a digitally signed message part


[jira] [Assigned] (SLING-7902) The http.conn.timeout property on ForwardDistributionAgentFactory does not pick user entered values.

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7902:
--

Assignee: Nicolas Peltier

> The http.conn.timeout property on ForwardDistributionAgentFactory does not 
> pick user entered values.
> 
>
> Key: SLING-7902
> URL: https://issues.apache.org/jira/browse/SLING-7902
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Adityasharma
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Content Distribution Core 0.3.2
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> As part of one of the projects we were trying to use Sling Content 
> Distribution. Whenever our package size grew to a number which took more than 
> 10 seconds to process our distribution queue on the Author instance would go 
> into a blocked state and was irrecoverable from. We had to manually clean the 
> queue in order to proceed.
> While trying to troubleshoot the issue we tried to increase the 
> http.conn.timeout but this did not take hold. While trying to debug the issue 
> further we came across the file ForwardDistributionAgentFactory and found 
> that this parameter was not being read from the configs and hence getting 
> hard coded to a default value of 10 seconds. 
> On further investigation we found its the same case with the Reverse/Sync 
> Distribution Agent Factory classes too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7902) The http.conn.timeout property on ForwardDistributionAgentFactory does not pick user entered values.

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7902:
---
Fix Version/s: Content Distribution Core 0.3.2

> The http.conn.timeout property on ForwardDistributionAgentFactory does not 
> pick user entered values.
> 
>
> Key: SLING-7902
> URL: https://issues.apache.org/jira/browse/SLING-7902
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Adityasharma
>Priority: Major
> Fix For: Content Distribution Core 0.3.2
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> As part of one of the projects we were trying to use Sling Content 
> Distribution. Whenever our package size grew to a number which took more than 
> 10 seconds to process our distribution queue on the Author instance would go 
> into a blocked state and was irrecoverable from. We had to manually clean the 
> queue in order to proceed.
> While trying to troubleshoot the issue we tried to increase the 
> http.conn.timeout but this did not take hold. While trying to debug the issue 
> further we came across the file ForwardDistributionAgentFactory and found 
> that this parameter was not being read from the configs and hence getting 
> hard coded to a default value of 10 seconds. 
> On further investigation we found its the same case with the Reverse/Sync 
> Distribution Agent Factory classes too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-5760) Allow to support certificate based authentication in Distribution transport

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-5760:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> Allow to support certificate based authentication in Distribution transport
> ---
>
> Key: SLING-5760
> URL: https://issues.apache.org/jira/browse/SLING-5760
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.1.18
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Attachments: SLING-5760.patch
>
>
> Certificate based authentication is an alternative to the basic 
> authentication currently available for Distribution transport. Certificate 
> based authentication is done during the SSL handshake iff the target instance 
> is configured to require or accept client client authentication. This client 
> authentication scheme is a logical complement when connecting to endpoints 
> serving over https. This result in authenticating both the source and the 
> target using SSL.
> The client certificate and private key are required to complete the SSL 
> handshake. By default, the JRE will use the default {{KeyStore}} to retrieve 
> those informations. However, in some platforms such as Adobe Granite, there 
> is the ability to specify custom {{KeyStore}} based on user. For those 
> platforms, the custom {{KeyStore}} can be provided with a 
> {{javax.net.ssl.SSLContext}} which also contains a custom {{TrustStore}}.
> This issue tracks allowing to leverage certificate based authentication using 
> a custom {{javax.net.ssl.SSLContext}} in Distribution transport.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-5916) Remove all usages of jobManager.findJobs in SCD

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-5916:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> Remove all usages of jobManager.findJobs in SCD
> ---
>
> Key: SLING-5916
> URL: https://issues.apache.org/jira/browse/SLING-5916
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
>
> Given the latest discussions on the Sling dev@ list it'd be good to stop 
> using {{JobManager#findJobs}} API at all in the SCD code (for the jobs based 
> queues).
> This would require either accepting queues cannot be inspected in detail 
> (which / how many items there are in each queue) or rely on different 
> constructs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-4797) Improve handling of Move events

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-4797:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> Improve handling of Move events
> ---
>
> Key: SLING-4797
> URL: https://issues.apache.org/jira/browse/SLING-4797
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.1.4
>Reporter: Konrad Windszus
>Priority: Major
>
> In case you are moving a node with a lot of subnodes, this leads to a 
> distributed deletion of the node, followed by the distributed addition of the 
> node with all subnodes.
> To improve the performance it would be good, if the move operation would 
> really be distributed through a move event, which means that each receiver 
> would try to move the node (instead of first deleting it and then adding it 
> with all its subnodes).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-6211) Clarify AbstractJcrEventTrigger request addition strategy

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-6211:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> Clarify AbstractJcrEventTrigger request addition strategy
> -
>
> Key: SLING-6211
> URL: https://issues.apache.org/jira/browse/SLING-6211
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
>
> We should clarify the logic behind 
> [AbstractJcrEventListener#addToList|https://github.com/apache/sling/blob/trunk/contrib/extensions/distribution/core/src/main/java/org/apache/sling/distribution/trigger/impl/AbstractJcrEventTrigger.java#L150]
>  as that the addition mechanism seems to rely on the last request added, 
> which seems wrong as events may come in in an unsorted manner (not consistent 
> with the order the changes they refer to were done).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7472) Simplify factory mapping

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7472:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> Simplify factory mapping
> 
>
> Key: SLING-7472
> URL: https://issues.apache.org/jira/browse/SLING-7472
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
>
> As detailed in 
> [SLING-7468|https://issues.apache.org/jira/browse/SLING-7468?focusedCommentId=16352160&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16352160],
>  we could simplify the mapping of factory configurations, by setting the 
> component type in each factory. 
> This requires cleaning up the OSGI properties already set in some SCD 
> factories.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7733) Do not rewrite DistributionRequests until passed to Serializer

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7733:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> Do not rewrite DistributionRequests until passed to Serializer
> --
>
> Key: SLING-7733
> URL: https://issues.apache.org/jira/browse/SLING-7733
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Marius Petria
>Assignee: Marius Petria
>Priority: Major
>
> The AbstractDistributionPackageBuilder rewrites certain paths before creating 
> a package. This should be the responsibility of the serializer.
> [1] 
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/a4da85cf8e8fa4538b6a8e93380d3c03182bb9e0/src/main/java/org/apache/sling/distribution/packaging/impl/AbstractDistributionPackageBuilder.java#L67



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7513) VltUtils#createFilter adds an empty property filter when no filter is configured

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7513:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> VltUtils#createFilter adds an empty property filter when no filter is 
> configured 
> -
>
> Key: SLING-7513
> URL: https://issues.apache.org/jira/browse/SLING-7513
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7902) The http.conn.timeout property on ForwardDistributionAgentFactory does not pick user entered values.

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7902:
---
Fix Version/s: (was: Content Distribution Core 0.3.0)

> The http.conn.timeout property on ForwardDistributionAgentFactory does not 
> pick user entered values.
> 
>
> Key: SLING-7902
> URL: https://issues.apache.org/jira/browse/SLING-7902
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Adityasharma
>Priority: Major
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> As part of one of the projects we were trying to use Sling Content 
> Distribution. Whenever our package size grew to a number which took more than 
> 10 seconds to process our distribution queue on the Author instance would go 
> into a blocked state and was irrecoverable from. We had to manually clean the 
> queue in order to proceed.
> While trying to troubleshoot the issue we tried to increase the 
> http.conn.timeout but this did not take hold. While trying to debug the issue 
> further we came across the file ForwardDistributionAgentFactory and found 
> that this parameter was not being read from the configs and hence getting 
> hard coded to a default value of 10 seconds. 
> On further investigation we found its the same case with the Reverse/Sync 
> Distribution Agent Factory classes too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7902) The http.conn.timeout property on ForwardDistributionAgentFactory does not pick user entered values.

2018-09-13 Thread Nicolas Peltier (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7902.

   Resolution: Fixed
Fix Version/s: Content Distribution Core 0.3.0

> The http.conn.timeout property on ForwardDistributionAgentFactory does not 
> pick user entered values.
> 
>
> Key: SLING-7902
> URL: https://issues.apache.org/jira/browse/SLING-7902
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Core 0.2.10
>Reporter: Adityasharma
>Priority: Major
> Fix For: Content Distribution Core 0.3.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> As part of one of the projects we were trying to use Sling Content 
> Distribution. Whenever our package size grew to a number which took more than 
> 10 seconds to process our distribution queue on the Author instance would go 
> into a blocked state and was irrecoverable from. We had to manually clean the 
> queue in order to proceed.
> While trying to troubleshoot the issue we tried to increase the 
> http.conn.timeout but this did not take hold. While trying to debug the issue 
> further we came across the file ForwardDistributionAgentFactory and found 
> that this parameter was not being read from the configs and hence getting 
> hard coded to a default value of 10 seconds. 
> On further investigation we found its the same case with the Reverse/Sync 
> Distribution Agent Factory classes too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling App CMS version 0.10.0

2018-09-13 Thread Robert Munteanu
Hi,

I noticed the following when building the CMS

[WARNING] npm WARN notice [SECURITY] lodash has the following vulnerability: 1 
low. Go here for more details: 
https://nodesecurity.io/advisories?search=lodash&version=1.0.2 - Run `npm i 
npm@latest -g` to upgrade your npm version, and then `npm audit` to get more 
info.
[WARNING] npm WARN deprecated graceful-fs@1.2.3: please upgrade to graceful-fs 
4 for compatibility with current and future versions of Node.js
[WARNING] npm WARN notice [SECURITY] minimatch has the following vulnerability: 
1 high. Go here for more details: 
https://nodesecurity.io/advisories?search=minimatch&version=0.2.14 - Run `npm i 
npm@latest -g` to upgrade your npm version, and then `npm audit` to get more 
info.
[WARNING] npm WARN notice [SECURITY] minimatch has the following vulnerability: 
1 high. Go here for more details: 
https://nodesecurity.io/advisories?search=minimatch&version=2.0.10 - Run `npm i 
npm@latest -g` to upgrade your npm version, and then `npm audit` to get more 
info.

Is this something that we should redo for the release or is it OK to
release this way?

Thanks,

Robert



Re: Sling 11

2018-09-13 Thread Robert Munteanu
A note on Javadocs - we generate them from the list of artifacts in the
starter.

Any additional artifacts ( like annotations ) must be listed manually
in the generate_javadoc.sh script [1], so please add them there (or let
me know and I will add them).

Thanks,

Robert

[1]: 
https://github.com/apache/sling-tooling-release/blob/master/generate_javadoc_for_release.sh

On Tue, 2018-09-11 at 14:33 +0200, Robert Munteanu wrote:
> Hi,
> 
> I think it's a good time to release Sling 11. We've gathered a good
> set
> of updates and we want to release more often anyway.
> 
> If there are updates that still need to get in please add sub-tasks
> to
> [4]. Or for larger concerns we can discuss on this email thread.
> 
> I plan to start with the bundle releases on wednesday and continue
> with
> the the other releases.
> 
> I would encourage you to aid in the preparation of the release by:
> 
> - making releases of SNAPSHOT bundles [1]
> - making sure that all Sling ITs pass [2]
> - tag important fixes with 'Sling-11-ReleaseNotes' [3]
> 
> If anyone wants to participate in the actual release process I'm very
> happy to share the effort, the container task is at [4] and
> documentation at [5].
> 
> Thanks,
> 
> Robert
> 
> 
> [1]: https://issues.apache.org/jira/browse/SLING-7904
> [2]: https://issues.apache.org/jira/browse/SLING-7905
> [3]: 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20labels%20%20%3D%20Sling-11-ReleaseNotes%20%20ORDER%20BY%20updated%20DESC
> [4]: https://issues.apache.org/jira/browse/SLING-7903
> [5]: 
> https://cwiki.apache.org/confluence/display/SLING/Releasing+a+new+version+of+the+Sling+Starter
> 




Re: Sling 11

2018-09-13 Thread Robert Munteanu
On Wed, 2018-09-12 at 06:29 +, Stefan Seifert wrote:
> what about the missing releases of the jsr-305->jetbrains migration -
> see column "released" in
> https://issues.apache.org/jira/browse/SLING-7798
> 
> should we release them before releasing sling 11?

Sorry, missed this.

No, we don't need to update them since we now have the javax.annotation
bundle deployed in the Starter.

Robert

> 
> stefan
> 
> > -Original Message-
> > From: Robert Munteanu 
> > Sent: Tuesday, September 11, 2018 2:33 PM
> > To: dev@sling.apache.org
> > Subject: Sling 11
> > 
> > Hi,
> > 
> > I think it's a good time to release Sling 11. We've gathered a good
> > set
> > of updates and we want to release more often anyway.
> > 
> > If there are updates that still need to get in please add sub-tasks 
> > to
> > [4]. Or for larger concerns we can discuss on this email thread.
> > 
> > I plan to start with the bundle releases on wednesday and continue
> > with
> > the the other releases.
> > 
> > I would encourage you to aid in the preparation of the release by:
> > 
> > - making releases of SNAPSHOT bundles [1]
> > - making sure that all Sling ITs pass [2]
> > - tag important fixes with 'Sling-11-ReleaseNotes' [3]
> > 
> > If anyone wants to participate in the actual release process I'm
> > very
> > happy to share the effort, the container task is at [4] and
> > documentation at [5].
> > 
> > Thanks,
> > 
> > Robert
> > 
> > 
> > [1]: https://issues.apache.org/jira/browse/SLING-7904
> > [2]: https://issues.apache.org/jira/browse/SLING-7905
> > [3]:
> > 
https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20labe
> > ls%20%20%3D%20Sling-11-
> > ReleaseNotes%20%20ORDER%20BY%20updated%20DESC
> > [4]: https://issues.apache.org/jira/browse/SLING-7903
> > [5]:
> > 
https://cwiki.apache.org/confluence/display/SLING/Releasing+a+new+version+of+
> > the+Sling+Starter
> > 
> 
> 




[jira] [Commented] (SLING-7922) Update to latest available releases for Sling 11

2018-09-13 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613498#comment-16613498
 ] 

Robert Munteanu commented on SLING-7922:


As [~cziegeler] noted, these are the Sling dependencies should update:

{noformat}org.apache.sling:org.apache.sling.caconfig.api  1.1.0 -> 1.1.2
org.apache.sling:org.apache.sling.caconfig.impl . 1.4.12 -> 1.4.14
org.apache.sling:org.apache.sling.caconfig.spi  1.3.2 -> 1.3.4
org.apache.sling:org.apache.sling.commons.johnzon . 1.1.0 -> 1.1.2
org.apache.sling:org.apache.sling.fsresource  2.1.12 -> 2.1.14
org.apache.sling:org.apache.sling.i18n .. 2.5.12 -> 2.5.14
org.apache.sling:org.apache.sling.jcr.contentloader ... 2.2.4 -> 2.2.6
org.apache.sling:org.apache.sling.jcr.oak.server .. 1.1.4 -> 1.2.0
org.apache.sling:org.apache.sling.launchpad.base ...6.0.1-2.6.30 ->

6.0.1-2.6.32
org.apache.sling:org.apache.sling.servlets.get .. 2.1.30 -> 2.1.34{noformat}

> Update to latest available releases for Sling 11
> 
>
> Key: SLING-7922
> URL: https://issues.apache.org/jira/browse/SLING-7922
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
>
> Should look into:
> - Sling modules that are released but not included
> - Felix bundles
> - Oak 1.8
> - Other misc dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Sling 11

2018-09-13 Thread Robert Munteanu
I raised https://issues.apache.org/jira/browse/SLING-7922 for this.

Robert

On Tue, 2018-09-11 at 15:09 +0200, Carsten Ziegeler wrote:
> I also see that some of our sling modules are not updated to the
> latest:
> 
> 
> org.apache.sling:org.apache.sling.caconfig.api  1.1.0 ->
> 1.1.2
> org.apache.sling:org.apache.sling.caconfig.impl . 1.4.12 ->
> 1.4.14
> org.apache.sling:org.apache.sling.caconfig.spi  1.3.2 ->
> 1.3.4
> org.apache.sling:org.apache.sling.commons.johnzon . 1.1.0 ->
> 1.1.2
> org.apache.sling:org.apache.sling.fsresource  2.1.12 ->
> 2.1.14
> org.apache.sling:org.apache.sling.i18n .. 2.5.12 ->
> 2.5.14
> org.apache.sling:org.apache.sling.jcr.contentloader ... 2.2.4 ->
> 2.2.6
> org.apache.sling:org.apache.sling.jcr.oak.server .. 1.1.4 ->
> 1.2.0
> org.apache.sling:org.apache.sling.launchpad.base ...6.0.1-2.6.30 ->
> 
> 6.0.1-2.6.32
> org.apache.sling:org.apache.sling.servlets.get .. 2.1.30 ->
> 2.1.34
> 
> Regards
> Carsten
> 
> Carsten Ziegeler wrote
> > Great idea!
> > 
> > +5
> > 
> > I haven't looked in detail but we might want to update some of our
> > dependencies like to the Felix projects etc. We have a pending web
> > console release we should include, and a configuration admin
> > release
> > will start end of this week.
> > 
> > Regards
> > 
> > Carsten
> > 
> > 
> > Robert Munteanu wrote
> > > Hi,
> > > 
> > > I think it's a good time to release Sling 11. We've gathered a
> > > good set
> > > of updates and we want to release more often anyway.
> > > 
> > > If there are updates that still need to get in please add sub-
> > > tasks to
> > > [4]. Or for larger concerns we can discuss on this email thread.
> > > 
> > > I plan to start with the bundle releases on wednesday and
> > > continue with
> > > the the other releases.
> > > 
> > > I would encourage you to aid in the preparation of the release
> > > by:
> > > 
> > > - making releases of SNAPSHOT bundles [1]
> > > - making sure that all Sling ITs pass [2]
> > > - tag important fixes with 'Sling-11-ReleaseNotes' [3]
> > > 
> > > If anyone wants to participate in the actual release process I'm
> > > very
> > > happy to share the effort, the container task is at [4] and
> > > documentation at [5].
> > > 
> > > Thanks,
> > > 
> > > Robert
> > > 
> > > 
> > > [1]: https://issues.apache.org/jira/browse/SLING-7904
> > > [2]: https://issues.apache.org/jira/browse/SLING-7905
> > > [3]: 
> > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SLING%20AND%20labels%20%20%3D%20Sling-11-ReleaseNotes%20%20ORDER%20BY%20updated%20DESC
> > > [4]: https://issues.apache.org/jira/browse/SLING-7903
> > > [5]: 


> > > 
https://cwiki.apache.org/confluence/display/SLING/Releasing+a+new+version+of+the+Sling+Starter
> > > 




[jira] [Updated] (SLING-7922) Update to latest available releases for Sling 11

2018-09-13 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7922:
---
Description: 
Should look into:

- Sling modules that are released but not included
- Felix bundles
- Oak 1.8
- Other misc dependencies

> Update to latest available releases for Sling 11
> 
>
> Key: SLING-7922
> URL: https://issues.apache.org/jira/browse/SLING-7922
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Priority: Major
>
> Should look into:
> - Sling modules that are released but not included
> - Felix bundles
> - Oak 1.8
> - Other misc dependencies



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7922) Update to latest available releases for Sling 11

2018-09-13 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-7922:
--

 Summary: Update to latest available releases for Sling 11
 Key: SLING-7922
 URL: https://issues.apache.org/jira/browse/SLING-7922
 Project: Sling
  Issue Type: Sub-task
  Components: Starter
Reporter: Robert Munteanu






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7885) CMS - Core - UGC Service Not Registered

2018-09-13 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7885:
--

Assignee: Dan Klco

> CMS - Core - UGC Service Not Registered
> ---
>
> Key: SLING-7885
> URL: https://issues.apache.org/jira/browse/SLING-7885
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 0.10.0
>
>
> Currently when you start a new installation of the CMS Reference App, the UGC 
> Service will not start because it is missing the user sling-ugc whom should 
> be used to create the User Generated content.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7921) upgrade to parent 34

2018-09-13 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-7921:
--

 Summary: upgrade to parent 34
 Key: SLING-7921
 URL: https://issues.apache.org/jira/browse/SLING-7921
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Affects Versions: Content Distribution Core 0.3.0
Reporter: Nicolas Peltier


Current core parent version is set to 26, moving it up implies at least
- 245 classes updates of scr annotations, 
- removal of org.osgi.service.cm.ConfigurationAdmin usage





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-7919) Duplicate feature name "sling-event" in sling-org-apache-sling-starter

2018-09-13 Thread Bertrand Delacretaz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-7919.

Resolution: Fixed

Fixed by commit 22a7f13. Shouldn't impact anything, but the duplicate name 
exposed SLING-7920 when converting to the Feature Model.

> Duplicate feature name "sling-event" in sling-org-apache-sling-starter
> --
>
> Key: SLING-7919
> URL: https://issues.apache.org/jira/browse/SLING-7919
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Starter 11
>
>
> The sling-discovery feature is named "sling-event" in the txt file:
> {code}
> $ grep "feature " src/main/provisioning/*.txt | grep event
> src/main/provisioning/sling-discovery.txt:[feature name=sling-event]
> src/main/provisioning/sling-event.txt:[feature name=sling-event]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7920) IllegalStateException in Model-to-Feature converter for multiple repoinit sections

2018-09-13 Thread Bertrand Delacretaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613307#comment-16613307
 ] 

Bertrand Delacretaz commented on SLING-7920:


Fixed with this commit, by accumulating multiple repoinit sections and 
outputting a single repoinit extension json:

[https://github.com/apache/sling-org-apache-sling-feature-modelconverter/commit/fb225c9b480ea330c1212833a237e5b4cf00258a]

[~bosschaert] I think you wrote the original code, could you review my changes 
and tests?

I'm throwing the {{IllegalStateException("Repoinit sections already 
processed")}} exception if the repoinit extension was already present in the 
feature model, as I don't have a use case to test that branch. It wasn't tested 
before my changes either, and caused the {{IllegalStateException}}. In this way 
that untested use case will fail loudly if we encounter it.

> IllegalStateException in Model-to-Feature converter for multiple repoinit 
> sections
> --
>
> Key: SLING-7920
> URL: https://issues.apache.org/jira/browse/SLING-7920
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: Feature Model Converter 0.1.4
>
>
> Trying to convert the sling-org-apache-sling-starter I get the below 
> exception, as due to SLING-7919 the sling-event feature there contains two 
> :repoinit sections.
> {code}
> Exception in thread "main" java.lang.IllegalStateException
>   at org.apache.sling.feature.Extension.getText(Extension.java:111)
>   at 
> org.apache.sling.feature.modelconverter.ProvisioningToFeature.buildFromFeature(ProvisioningToFeature.java:444)
>   at 
> org.apache.sling.feature.modelconverter.ProvisioningToFeature.buildFeatures(ProvisioningToFeature.java:477)
>   at 
> org.apache.sling.feature.modelconverter.ProvisioningToFeature.convert(ProvisioningToFeature.java:113)
>   at org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:195)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[VOTE] Release Apache Sling Pipes version 3.0.2

2018-09-13 Thread Nicolas Peltier
Hi,

We solved 21 issues in this
release:https://issues.apache.org/jira/projects/SLING/versions/12342862

There are still 5 outstanding
issues:https://issues.apache.org/jira/browse/SLING-7250
https://issues.apache.org/jira/browse/SLING-7772
https://issues.apache.org/jira/browse/SLING-7708 (doc bug that is being fixed)
https://issues.apache.org/jira/browse/SLING-6593
https://issues.apache.org/jira/browse/SLING-7425

also will add some documentation in case release:perform process step
goes wrong :-)


 Staging 
repository:https://repository.apache.org/content/repositories/orgapachesling-1982

You can use this UNIX script to download the release and verify the
signatures:https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 1982 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


[jira] [Created] (SLING-7920) IllegalStateException in Model-to-Feature converter for multiple repoinit sections

2018-09-13 Thread Bertrand Delacretaz (JIRA)
Bertrand Delacretaz created SLING-7920:
--

 Summary: IllegalStateException in Model-to-Feature converter for 
multiple repoinit sections
 Key: SLING-7920
 URL: https://issues.apache.org/jira/browse/SLING-7920
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
 Fix For: Feature Model Converter 0.1.4


Trying to convert the sling-org-apache-sling-starter I get the below exception, 
as due to SLING-7919 the sling-event feature there contains two :repoinit 
sections.

{code}
Exception in thread "main" java.lang.IllegalStateException
at org.apache.sling.feature.Extension.getText(Extension.java:111)
at 
org.apache.sling.feature.modelconverter.ProvisioningToFeature.buildFromFeature(ProvisioningToFeature.java:444)
at 
org.apache.sling.feature.modelconverter.ProvisioningToFeature.buildFeatures(ProvisioningToFeature.java:477)
at 
org.apache.sling.feature.modelconverter.ProvisioningToFeature.convert(ProvisioningToFeature.java:113)
at org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:195)
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7919) Duplicate feature name "sling-event" in sling-org-apache-sling-starter

2018-09-13 Thread Bertrand Delacretaz (JIRA)
Bertrand Delacretaz created SLING-7919:
--

 Summary: Duplicate feature name "sling-event" in 
sling-org-apache-sling-starter
 Key: SLING-7919
 URL: https://issues.apache.org/jira/browse/SLING-7919
 Project: Sling
  Issue Type: Bug
  Components: Starter
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
 Fix For: Starter 11


The sling-discovery feature is named "sling-event" in the txt file:

{code}
$ grep "feature " src/main/provisioning/*.txt | grep event
src/main/provisioning/sling-discovery.txt:[feature name=sling-event]
src/main/provisioning/sling-event.txt:[feature name=sling-event]
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Sling pax exam tests: How to override a low level feature

2018-09-13 Thread Christian Schneider
In some cases I want to pull up a sling instances in pax exam but want to
remove some lower level bundles and replace them with some custom bundle.
This can not be handled by simply providing a different version.

An example is:
I want to load sling using SlingOptions.slingDistribution() but I want to
remove the sling event bundle and install my own bundle instead.

As the methods in SlingOptions are all static I can not simply extend the
class and and override the SlingOptions.slingEvent() method.

So currently I copy all features that I need from SlingOptions into my own
class and change what I need to change there. This is of course not very
manageable and also kind of hides the fact that most of the bundle will
stay the same.

Any ideas how to tackle this problem?

Christian

-- 
-- 
Christian Schneider
http://www.liquid-reality.de

Computer Scientist
http://www.adobe.com