[GitHub] [sling-org-apache-sling-feature-analyser] hsaginor commented on issue #14: Zip file extract

2019-06-14 Thread GitBox
hsaginor commented on issue #14: Zip file extract
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14#issuecomment-501994642
 
 
   @karlpauls 
   Not sure why the build failed. The dependency versions it complains about 
are referenced in master's POM and it looks like they are not installed in 
maven central. For example feature.io 1.0.4 isn't there
   
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.feature.io/
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (SLING-8491) Selection of feature without classifier does not work

2019-06-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8491:
---

 Summary: Selection of feature without classifier does not work
 Key: SLING-8491
 URL: https://issues.apache.org/jira/browse/SLING-8491
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Affects Versions: slingfeature-maven-plugin 1.0.4, 
slingfeature-maven-plugin 1.0.2
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: slingfeature-maven-plugin 1.0.6


For some of the mojos it is possible to configure the classifier of a feature 
to be used. For the feature with no classifier specifying an empty classifier 
worked:
{noformat}
   
{noformat}
However, this does not seem to work anymore; I suspect that this is rather a 
problem of the mvn version used as maven is not passing such a configuration to 
the mojo at all. I noticed this in other plugins as well.

Therefore we should support the "no classifier" differently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8491) Selection of feature without classifier does not work

2019-06-14 Thread Carsten Ziegeler (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8491.
-
Resolution: Fixed

Added support of using the character ":" as a placeholder for "no classifier"; 
a classifier cant contain this character

> Selection of feature without classifier does not work
> -
>
> Key: SLING-8491
> URL: https://issues.apache.org/jira/browse/SLING-8491
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.0.2, 
> slingfeature-maven-plugin 1.0.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.6
>
>
> For some of the mojos it is possible to configure the classifier of a feature 
> to be used. For the feature with no classifier specifying an empty classifier 
> worked:
> {noformat}
>
> {noformat}
> However, this does not seem to work anymore; I suspect that this is rather a 
> problem of the mvn version used as maven is not passing such a configuration 
> to the mojo at all. I noticed this in other plugins as well.
> Therefore we should support the "no classifier" differently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8492) Local feature can't be selected by specifying the classifier

2019-06-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8492:
---

 Summary: Local feature can't be selected by specifying the 
classifier
 Key: SLING-8492
 URL: https://issues.apache.org/jira/browse/SLING-8492
 Project: Sling
  Issue Type: Bug
  Components: Maven Plugins and Archetypes
Affects Versions: slingfeature-maven-plugin 1.0.4, 
slingfeature-maven-plugin 1.0.2
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: slingfeature-maven-plugin 1.0.6


For some mojos it is possible to select a feature by specifying the classifier 
like
{noformat}
foo
{noformat}
It is documented that this should select either a local or an aggregated 
feature. However, currently it is only possible to select an aggregated feature



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8492) Local feature can't be selected by specifying the classifier

2019-06-14 Thread Carsten Ziegeler (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8492.
-
Resolution: Fixed

Fixed in rev 90ddf88

> Local feature can't be selected by specifying the classifier
> 
>
> Key: SLING-8492
> URL: https://issues.apache.org/jira/browse/SLING-8492
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.0.2, 
> slingfeature-maven-plugin 1.0.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.6
>
>
> For some mojos it is possible to select a feature by specifying the 
> classifier like
> {noformat}
> foo
> {noformat}
> It is documented that this should select either a local or an aggregated 
> feature. However, currently it is only possible to select an aggregated 
> feature



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8493) Move embedded jackrabbit classes to Sling package space

2019-06-14 Thread Carsten Ziegeler (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864078#comment-16864078
 ] 

Carsten Ziegeler commented on SLING-8493:
-

Updated API in rev 78b4285

> Move embedded jackrabbit classes to Sling package space
> ---
>
> Key: SLING-8493
> URL: https://issues.apache.org/jira/browse/SLING-8493
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Servlets Get 2.1.42, API 2.20.2, Servlets Post 2.3.32
>
>
> Classes from jackrabbit util are embedded as is; it's better to move them to 
> a package owned by Sling to avoid collisions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8493) Move embedded jackrabbit classes to Sling package space

2019-06-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8493:
---

 Summary: Move embedded jackrabbit classes to Sling package space
 Key: SLING-8493
 URL: https://issues.apache.org/jira/browse/SLING-8493
 Project: Sling
  Issue Type: Improvement
  Components: API, Servlets
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Servlets Get 2.1.42, API 2.20.2, Servlets Post 2.3.32


Classes from jackrabbit util are embedded as is; it's better to move them to a 
package owned by Sling to avoid collisions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8493) Move embedded jackrabbit classes to Sling package space

2019-06-14 Thread Carsten Ziegeler (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864080#comment-16864080
 ] 

Carsten Ziegeler commented on SLING-8493:
-

Updated servlets get in rev 06d8e1d

> Move embedded jackrabbit classes to Sling package space
> ---
>
> Key: SLING-8493
> URL: https://issues.apache.org/jira/browse/SLING-8493
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Servlets Get 2.1.42, API 2.20.2, Servlets Post 2.3.32
>
>
> Classes from jackrabbit util are embedded as is; it's better to move them to 
> a package owned by Sling to avoid collisions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8493) Move embedded jackrabbit classes to Sling package space

2019-06-14 Thread Carsten Ziegeler (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8493.
-
Resolution: Fixed

Updated servlets post in rev 1afba78 (also relocated the jcr.contentparser 
package)

> Move embedded jackrabbit classes to Sling package space
> ---
>
> Key: SLING-8493
> URL: https://issues.apache.org/jira/browse/SLING-8493
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Servlets Get 2.1.42, API 2.20.2, Servlets Post 2.3.32
>
>
> Classes from jackrabbit util are embedded as is; it's better to move them to 
> a package owned by Sling to avoid collisions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8494) Don't embed commons codec and commons osgi

2019-06-14 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8494:
---

 Summary: Don't embed commons codec and commons osgi
 Key: SLING-8494
 URL: https://issues.apache.org/jira/browse/SLING-8494
 Project: Sling
  Issue Type: Improvement
  Components: Authentication
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Auth Core 1.4.4


Currently auth.core embeds commons coded and Slings commons osgi which creates 
unnecessary copies of those classes and makes it more difficult to update them 
(an update of auth core is required each time)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8494) Don't embed commons codec and commons osgi

2019-06-14 Thread Carsten Ziegeler (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8494.
-
Resolution: Fixed

Removed the embedded classes in rev 32b0675
Proper imports are now used

> Don't embed commons codec and commons osgi
> --
>
> Key: SLING-8494
> URL: https://issues.apache.org/jira/browse/SLING-8494
> Project: Sling
>  Issue Type: Improvement
>  Components: Authentication
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Auth Core 1.4.4
>
>
> Currently auth.core embeds commons coded and Slings commons osgi which 
> creates unnecessary copies of those classes and makes it more difficult to 
> update them (an update of auth core is required each time)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8495) Make FSClassLoader its cache location root directory configurable

2019-06-14 Thread Krystian Nowak (JIRA)
Krystian Nowak created SLING-8495:
-

 Summary: Make FSClassLoader its cache location root directory 
configurable
 Key: SLING-8495
 URL: https://issues.apache.org/jira/browse/SLING-8495
 Project: Sling
  Issue Type: Improvement
  Components: Commons
Affects Versions: File System ClassLoader 1.0.10
Reporter: Krystian Nowak


Currently FSClassLoader's cache location is on the bundle persistent storage 
area.
In cases when it would make more sense to externalize it to a different 
location, file system cache location root directory needs to be configurable.

For that 
[https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderProvider.java#L108]
 needs to be made parametrized to have its "root" directory configurable.
Also:
* 
[https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderWebConsole.java#L95]
* 
[https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L79]
* 
[https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L109]

should be changed accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)