[jira] [Updated] (SLING-8520) Improve artifact/bundle merging

2019-06-17 Thread Carsten Ziegeler (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-8520:

Fix Version/s: slingfeature-maven-plugin 1.0.6

> Improve artifact/bundle merging
> ---
>
> Key: SLING-8520
> URL: https://issues.apache.org/jira/browse/SLING-8520
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.0.6, slingfeature-maven-plugin 1.0.6
>
>
> Currently when there is a clash during merging of two features, the selected 
> bundle/artifact is always appended at the end, even if it is the same as 
> already in the list of artifacts (target). However, to keep the original 
> order the selected bundle/artifact should be placed at the same position as 
> the bundle/artifact in the target.
> Further more the code currently does not completely handle classifiers 
> correctly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8520) Improve artifact/bundle merging

2019-06-17 Thread Carsten Ziegeler (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-8520.
-
Resolution: Fixed

I've adjusted the merging process as described in rev b67c8bb
In addition I changed the type of an override rule from String to ArtifactId - 
as an override rule  is exactly that. This makes handling of the rules easier 
and avoids parsing them over and over again.
We could potentially further improve the algorithm as there is some stuff done 
several times during merging, but I'll leave that to another issue

> Improve artifact/bundle merging
> ---
>
> Key: SLING-8520
> URL: https://issues.apache.org/jira/browse/SLING-8520
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.0.6
>
>
> Currently when there is a clash during merging of two features, the selected 
> bundle/artifact is always appended at the end, even if it is the same as 
> already in the list of artifacts (target). However, to keep the original 
> order the selected bundle/artifact should be placed at the same position as 
> the bundle/artifact in the target.
> Further more the code currently does not completely handle classifiers 
> correctly



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8520) Improve artifact/bundle merging

2019-06-17 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-8520:
---

 Summary: Improve artifact/bundle merging
 Key: SLING-8520
 URL: https://issues.apache.org/jira/browse/SLING-8520
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Feature Model 1.0.6


Currently when there is a clash during merging of two features, the selected 
bundle/artifact is always appended at the end, even if it is the same as 
already in the list of artifacts (target). However, to keep the original order 
the selected bundle/artifact should be placed at the same position as the 
bundle/artifact in the target.
Further more the code currently does not completely handle classifiers correctly




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Sling Content Package to Feature Model Maven Plugin

2019-06-17 Thread Andreas Schaefer
Hi

I just committed the first draft of the 'Sling Content Package to Feature Model 
Maven Plugin’ into branch  feature/sling-cpconverter-maven-plugin of the 
sling-whiteboard project.

The IT tests should give a rough idea on how to use it and I will incorporate 
it into the Peregrine CMS project to have a better End-to-End test for this 
plugin.

For now this plugin is intended to generated a side-car FM configuration for an 
existing Content Package including installing it into the local Maven repo.

I am not a crack in writing Maven Plugins so this plugin for sure has it rough 
edges and so any feedback is appreciated.

Cheers - Andy Schaefer

[jira] [Commented] (SLING-8450) JcrPersist: Provide transparent persistence to Sling Models

2019-06-17 Thread Brendan Robert (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866038#comment-16866038
 ] 

Brendan Robert commented on SLING-8450:
---

[~cziegeler] There is an open PR to change the name to Sling Model Persist.  
Please advise if this looks correct now.

> JcrPersist: Provide transparent persistence to Sling Models
> ---
>
> Key: SLING-8450
> URL: https://issues.apache.org/jira/browse/SLING-8450
> Project: Sling
>  Issue Type: New Feature
>  Components: API
>Reporter: Brendan Robert
>Priority: Major
> Attachments: SlingJCRPersist.zip
>
>
> As a developer using sling, I would like my sling models to serve as a core 
> of a MVC coding paradigm; however, it is not possible to do this without 
> writing my own persistence logic to save my sling models back into resources 
> for every project I do this.
> I propose a new module to work in tandem with Sling Models, such that Sling 
> Models serve as a mechanism to load data from JCR and the JcrPersist module 
> provides an OSGi service to save changes to beans back to the JCR via a 
> persist method.
> There are some complex sling model features, such as @via, which will likely 
> not be subject to this feature, and other cases such as transient variables 
> that should not be persisted.  The persist service should provide the 
> developer a sufficient set of features to decide how much or how little is 
> persisted with it.  Like Sling Models, this should rely on annotations so 
> that no additional external configurations are needed.
>  
> PS: Here's the implementation with ~90% unit test coverage.  See attached. :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [sling-whiteboard] badvision commented on issue #40: Renaming to Sling Model Persist, fixed test error with JDK 11

2019-06-17 Thread GitBox
badvision commented on issue #40: Renaming to Sling Model Persist, fixed test 
error with JDK 11
URL: https://github.com/apache/sling-whiteboard/pull/40#issuecomment-502810056
 
 
   @klcodanr -- Renamed by popular request to something that didn't have "JCR" 
in the name. :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-whiteboard] badvision opened a new pull request #40: Renaming to Sling Model Persist, fixed test error with JDK 11

2019-06-17 Thread GitBox
badvision opened a new pull request #40: Renaming to Sling Model Persist, fixed 
test error with JDK 11
URL: https://github.com/apache/sling-whiteboard/pull/40
 
 
   PostConstruct wasn't imported, needed to add module dependency on javax 
annotations


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (SLING-8430) Use java.util.zip.ZipFile in Feature Model Analyser

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-8430:
--
Fix Version/s: Feature Model Analyser 1.0.6

> Use java.util.zip.ZipFile in Feature Model Analyser
> ---
>
> Key: SLING-8430
> URL: https://issues.apache.org/jira/browse/SLING-8430
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Analyser 1.0.4
>Reporter: Henry Saginor
>Assignee: Karl Pauls
>Priority: Minor
> Fix For: Feature Model Analyser 1.0.6
>
>
> The ContentPackageScanner and FelixFrameworkScanner could use 
> java.util.zip.ZipFile API. In my estimation this should improve performance 
> over the current use of ZipInputStream.
> Here is a pull request with suggested changes including a unit test for 
> ContentPackageScanner:
> https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8430) Use java.util.zip.ZipFile in Feature Model Analyser

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8430.
---
Resolution: Fixed

Thanks [~hsagi...@gmail.com], I just merged your PR!


> Use java.util.zip.ZipFile in Feature Model Analyser
> ---
>
> Key: SLING-8430
> URL: https://issues.apache.org/jira/browse/SLING-8430
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Analyser 1.0.4
>Reporter: Henry Saginor
>Assignee: Karl Pauls
>Priority: Minor
> Fix For: Feature Model Analyser 1.0.6
>
>
> The ContentPackageScanner and FelixFrameworkScanner could use 
> java.util.zip.ZipFile API. In my estimation this should improve performance 
> over the current use of ZipInputStream.
> Here is a pull request with suggested changes including a unit test for 
> ContentPackageScanner:
> https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8430) Use java.util.zip.ZipFile in Feature Model Analyser

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-8430:
--
Affects Version/s: Feature Model Analyser 1.0.4

> Use java.util.zip.ZipFile in Feature Model Analyser
> ---
>
> Key: SLING-8430
> URL: https://issues.apache.org/jira/browse/SLING-8430
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Analyser 1.0.4
>Reporter: Henry Saginor
>Assignee: Karl Pauls
>Priority: Minor
>
> The ContentPackageScanner and FelixFrameworkScanner could use 
> java.util.zip.ZipFile API. In my estimation this should improve performance 
> over the current use of ZipInputStream.
> Here is a pull request with suggested changes including a unit test for 
> ContentPackageScanner:
> https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [sling-org-apache-sling-feature-analyser] karlpauls merged pull request #14: Zip file extract

2019-06-17 Thread GitBox
karlpauls merged pull request #14: Zip file extract
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-feature-analyser] karlpauls commented on issue #14: Zip file extract

2019-06-17 Thread GitBox
karlpauls commented on issue #14: Zip file extract
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/14#issuecomment-502802563
 
 
   Thanks @hsaginor 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (SLING-8519) Improve CLI parsing and general look and feel

2019-06-17 Thread Radu Cotescu (JIRA)
Radu Cotescu created SLING-8519:
---

 Summary: Improve CLI parsing and general look and feel
 Key: SLING-8519
 URL: https://issues.apache.org/jira/browse/SLING-8519
 Project: Sling
  Issue Type: Improvement
  Components: Tooling
Reporter: Radu Cotescu
 Fix For: Committer CLI 1.0.0


The current implementation of the Committer CLI provides its own parsing of the 
command line arguments. However, the current design is not flexible enough when 
it comes to adding other commands, nor regarding the way the parameters are 
handled.

picocli [0], a project using the Apache 2.0 license, seems mature enough and 
can help with building the CLI, allowing the project to focus more on the 
actual commands to be executed rather than on the CLI itself.

[0] - https://picocli.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-8519) Improve CLI parsing and general look and feel

2019-06-17 Thread Radu Cotescu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-8519:
---

Assignee: Radu Cotescu

> Improve CLI parsing and general look and feel
> -
>
> Key: SLING-8519
> URL: https://issues.apache.org/jira/browse/SLING-8519
> Project: Sling
>  Issue Type: Improvement
>  Components: Tooling
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Committer CLI 1.0.0
>
>
> The current implementation of the Committer CLI provides its own parsing of 
> the command line arguments. However, the current design is not flexible 
> enough when it comes to adding other commands, nor regarding the way the 
> parameters are handled.
> picocli [0], a project using the Apache 2.0 license, seems mature enough and 
> can help with building the CLI, allowing the project to focus more on the 
> actual commands to be executed rather than on the CLI itself.
> [0] - https://picocli.info/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [VOTE] Release Apache Sling Auth Core 1.4.4

2019-06-17 Thread Andreas Schaefer
+1 (non binding)

- Andy Schaefer

> On Jun 15, 2019, at 6:27 AM, Carsten Ziegeler  wrote:
> 
> We solved 4 issues in this release:
> 
> https://issues.apache.org/jira/projects/SLING/versions/12342325
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2094/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2094 /tmp/sling-staging
> 
> Please vote to approve these release:
> 
>  [ ] +1 Approve the releases
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



Re: [VOTE] Release Apache Sling Servlets Resolver 2.5.6

2019-06-17 Thread Andreas Schaefer
+1 (non binding)

- Andy Schaefer

> On Jun 15, 2019, at 6:29 AM, Carsten Ziegeler  wrote:
> 
> We solved 3 issues in this release:
> 
> https://issues.apache.org/jira/projects/SLING/versions/12345473
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2095/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2095 /tmp/sling-staging
> 
> Please vote to approve these release:
> 
>  [ ] +1 Approve the releases
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



Re: [VOTE] Release Apache Sling File System Classloader 1.0.12

2019-06-17 Thread Andreas Schaefer
+1 (non binding)

- Andy Schaefer

> On Jun 17, 2019, at 6:02 AM, Karl Pauls  wrote:
> 
> I would like to call a vote on the following release,
> 
> Apache Sling File System Classloader 1.0.12
> 
> We solved 1 issue in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12345673
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2096/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 2096 /tmp/sling-staging
> 
> Please vote to approve these releases:
> 
>  [ ] +1 Approve the releases
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...



RE: [VOTE] Release Apache Sling Servlets Resolver 2.5.6

2019-06-17 Thread Stefan Seifert
+1



Re: [VOTE] Release Apache Sling Launchpad Integration Tests 1.0.10

2019-06-17 Thread Andreas Schaefer
+1 (non binding)

- Andy Schaefer

> On Jun 17, 2019, at 6:13 AM, Robert Munteanu  wrote:
> 
> Hi,
> 
> We solved 1 issue(s) in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345055
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2097/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2097 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> Robert Munteanu
> 



Re: [VOTE] Release Apache Sling Servlets Resolver 2.5.6

2019-06-17 Thread Carsten Ziegeler
Good catch, it has been marked as RESOLVED/Invalid with this version, so 
nothing has been done here.


I removed it from the version


Carsten


Stefan Seifert wrote

i do not see any commit for ticket 
https://issues.apache.org/jira/browse/SLING-8389
is it really solved in this release?

stefan


-Original Message-
From: Carsten Ziegeler [mailto:cziege...@apache.org]
Sent: Saturday, June 15, 2019 3:29 PM
To: dev@sling.apache.org
Subject: [VOTE] Release Apache Sling Servlets Resolver 2.5.6

We solved 3 issues in this release:

https://issues.apache.org/jira/projects/SLING/versions/12345473

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2095/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-
release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2095 /tmp/sling-staging

Please vote to approve these release:

   [ ] +1 Approve the releases
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org



--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Updated] (SLING-8389) Improve Encoding in the Servlet WebConsolePlugin

2019-06-17 Thread Carsten Ziegeler (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-8389:

Fix Version/s: (was: Servlets Resolver 2.5.6)

> Improve Encoding in the Servlet WebConsolePlugin 
> -
>
> Key: SLING-8389
> URL: https://issues.apache.org/jira/browse/SLING-8389
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>Priority: Major
>
> It would be good to improve the Encoding in the Servlet WebConsolePlugin 
> [0] 
> https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/master/src/main/java/org/apache/sling/servlets/resolver/internal/console/WebConsolePlugin.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


RE: [VOTE] Release Apache Sling Launchpad Integration Tests 1.0.10

2019-06-17 Thread Stefan Seifert
+1




RE: [VOTE] Release Apache Sling File System Classloader 1.0.12

2019-06-17 Thread Stefan Seifert
+1



RE: [VOTE] Release Apache Sling Servlets Resolver 2.5.6

2019-06-17 Thread Stefan Seifert
i do not see any commit for ticket 
https://issues.apache.org/jira/browse/SLING-8389
is it really solved in this release?

stefan

>-Original Message-
>From: Carsten Ziegeler [mailto:cziege...@apache.org]
>Sent: Saturday, June 15, 2019 3:29 PM
>To: dev@sling.apache.org
>Subject: [VOTE] Release Apache Sling Servlets Resolver 2.5.6
>
>We solved 3 issues in this release:
>
>https://issues.apache.org/jira/projects/SLING/versions/12345473
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-2095/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
>Usage:
>sh check_staged_release.sh 2095 /tmp/sling-staging
>
>Please vote to approve these release:
>
>   [ ] +1 Approve the releases
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
>Regards
>Carsten
>--
>Carsten Ziegeler
>Adobe Research Switzerland
>cziege...@apache.org



RE: [VOTE] Release Apache Sling Auth Core 1.4.4

2019-06-17 Thread Stefan Seifert
+1



Re: Release Validator Docker Image

2019-06-17 Thread Robert Munteanu
On Thu, 2019-06-13 at 10:49 -0500, Daniel Klco wrote:
> Yeah, I've gone back and forth regarding the JDK RPM. On the one
> hand, it'd
> be better not not require the local RPM, on the other hand, to
> support
> validation it'd be good to be able (I would think) to compile against
> multiple JDK versions and VMs (e.g. Oracle, IBM, whatever)
> 
> I guess it's a question to the overall team, is there any need to
> validate
> against OracleJDK or should I just base this off OpenDJK?

I always used OpenJDK.

Robert

> 
> On Thu, Jun 13, 2019 at 10:29 AM Robert Munteanu 
> wrote:
> 
> > Hi Dan,
> > 
> > On Thu, 2019-06-13 at 10:20 -0500, Daniel Klco wrote:
> > > I've also been working on a docker image to validate and build
> > > releases:
> > > 
> > > https://github.com/apache/sling-whiteboard/tree/master/release-validator
> > > 
> > > It's relatively easy to use
> > 
> > That looks nice! One question - do you need to have the Java RPM
> > locally? If yes, have you considered using one of the OpenJDK
> > docker
> > images, which already do this for you?
> > 
> >   https://hub.docker.com/_/openjdk
> > 
> > As a side note, I have some local scripts which do the following:
> > 
> > - check the status of a release on Github
> > - builds a reactor of the whole
> > 
> > I am a bit lazy but I'll attach them here, in case you want to pick
> > something up for the validator docker image feel free :-)
> > 
> > Thanks,
> > 
> > Robert
> > 



Re: Release automation (was: June board report draft)

2019-06-17 Thread Robert Munteanu
On Thu, 2019-06-13 at 17:59 +0200, Konrad Windszus wrote:
> Perfect thanks. Is this considered mature enough to be the default
> release process?
> I think at least a hint to that tool would be nice within 
> https://sling.apache.org/documentation/development/release-management.html
> <
> https://sling.apache.org/documentation/development/release-management.html>
> ;.
> I will definitely try that the next time I do a release.

That's a good point, I've added a note. The docker image does not yet
perform all the steps, so I would not call recommend using it as the
default release tool.

However, it's good enough to be tested more.

Robert

> Konrad
> 
> > On 13. Jun 2019, at 16:40, Robert Munteanu 
> > wrote:
> > 
> > Hi Konrad,
> > 
> > On Wed, 2019-06-12 at 16:33 +0200, Konrad Windszus wrote:
> > > I kind of missed those steps as well in the past. I thought that
> > > this
> > > would be automatically done as soon as you push something to
> > > dist.
> > > Can we aim for a better automation here?
> > > Also from the script 
> > > https://github.com/apache/sling-tooling-release/blob/master/update_reporter.sh
> > > <
> > > https://github.com/apache/sling-tooling-release/blob/master/update_reporter.sh
> > > > it is not clear to me in which format the release file has to
> > > > be
> > > given. Can you provide an example?
> > > Is it supposed to contain the full Maven G:A:V or rather the
> > > filename?
> > 
> > I think that for release automation the committer CLI is the
> > solution
> > 
> >  https://github.com/apache/sling-org-apache-sling-committer-cli
> > 
> > It allows a release manager to execute various steps in an
> > automated
> > manner. It's still WIP, but you can:
> > 
> > - generate vote emails
> > - generate vote result emails
> > - create next jira version
> > - record release data in reporter.apache.org
> > - generate a diff to apply on the website
> > 
> > Thanks,
> > 
> > Robert
> > 
> > > Thanks,
> > > Konrad
> > > 
> > > > On 12. Jun 2019, at 15:38, Robert Munteanu 
> > > > wrote:
> > > > 
> > > > Hi Timothee,
> > > > 
> > > > On Wed, 2019-06-12 at 15:30 +0200, Timothee Maret wrote:
> > > > > Hi Robert,
> > > > > 
> > > > > I am not sure if this is expected or even relevant but the
> > > > > list
> > > > > of
> > > > > releases
> > > > > does not seem to include all the items from
> > > > > https://sling.apache.org/releases.html
> > > > 
> > > > We should include all releases in the report. Which exactly are
> > > > you
> > > > missing? The release list is automatically generated 
> > > > https://reporter.apache.org/ . The reporter relies on the PMC
> > > > member
> > > > that commits a new release to dist to also add it to
> > > > reporter.apache.org . Maybe not all releases are added there,
> > > > hence
> > > > the
> > > > discrepancy.
> > > > 
> > > > Thanks,
> > > > 
> > > > Robert
> > > > 



Re: [VOTE] Release Apache Sling Servlets Resolver 2.5.6

2019-06-17 Thread Robert Munteanu
On Sat, 2019-06-15 at 15:29 +0200, Carsten Ziegeler wrote:
> Please vote to approve these release:

+1

Robert


signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling Auth Core 1.4.4

2019-06-17 Thread Robert Munteanu
On Sat, 2019-06-15 at 15:27 +0200, Carsten Ziegeler wrote:
> Please vote to approve these release:

+1


Robert


signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling File System Classloader 1.0.12

2019-06-17 Thread Robert Munteanu
On Mon, 2019-06-17 at 15:02 +0200, Karl Pauls wrote:
> Please vote to approve these releases:

+1

Robert


signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling Launchpad Integration Tests 1.0.10

2019-06-17 Thread Carsten Ziegeler

+1


Carsten


Robert Munteanu wrote

Hi,

We solved 1 issue(s) in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12345055

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2097/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2097 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu


--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling File System Classloader 1.0.12

2019-06-17 Thread Carsten Ziegeler

+1


Carsten


Karl Pauls wrote

I would like to call a vote on the following release,

Apache Sling File System Classloader 1.0.12

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12345673

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2096/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 2096 /tmp/sling-staging

Please vote to approve these releases:

   [ ] +1 Approve the releases
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...


--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: Happy tenth birthday, Apache Sling!

2019-06-17 Thread Robert Munteanu
On Mon, 2019-06-17 at 08:41 +0200, Bertrand Delacretaz wrote:
> Hi Sling community,
> 
> As per [1], the Apache Sling project was established ten years ago,
> on
> June 17th, 2009, after entering incubation on September 5th, 2007.
> 
> Even though it is ten years old, it's great to see the sustained
> ongoing activity in this project.
> 
> Thank you to everybody who's played a role in this, it's been a
> fantastic ride!
> 
> -Bertrand
> 
> [1] 
> http://apache.org/foundation/records/minutes/2009/board_minutes_2009_06_17.txt

+1, happy birthday to Apache Sling! 

Chorus, in background:

For they're a jolly RESTful fellow
For they're a jolly RESTful fellow
For they're a jolly RESTful fellow
Which nobody can deny



Re: [VOTE] Release Apache Sling Launchpad Integration Tests 1.0.10

2019-06-17 Thread Robert Munteanu
On Mon, 2019-06-17 at 13:12 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1

Robert


signature.asc
Description: This is a digitally signed message part


[VOTE] Release Apache Sling Launchpad Integration Tests 1.0.10

2019-06-17 Thread Robert Munteanu
Hi,

We solved 1 issue(s) in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12345055

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2097/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2097 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu



[jira] [Commented] (SLING-7935) Consolidate all 'launchpad-testing' modules into a single git repository

2019-06-17 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865569#comment-16865569
 ] 

Robert Munteanu commented on SLING-7935:


[~olli] -  I will start the release now, sorry for the delay.

> Consolidate all 'launchpad-testing' modules into a single git repository
> 
>
> Key: SLING-7935
> URL: https://issues.apache.org/jira/browse/SLING-7935
> Project: Sling
>  Issue Type: Task
>  Components: Launchpad
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>
> We currently have seven testing-related modules in Git:
> * org-apache-sling-launchpad-integration-tests
> * org-apache-sling-launchpad-test-bundles
> * org-apache-sling-launchpad-test-fragment
> * org-apache-sling-launchpad-testing
> * org-apache-sling-launchpad-testing-war
> * org-apache-sling-launchpad-test-services
> * org-apache-sling-launchpad-test-services-war
> All of these are related to testing the starter application and typically we 
> only release them when the starter is also released. As such, it's a pain to 
> manually keep versions in sync and release the modules one by one. This is 
> one scenario where a single git repository would make sense.
> Whether this should be the actual starter repository or a starter-testing one 
> is something that is not set in stone, but the current situation is not 
> optimal.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[VOTE] Release Apache Sling File System Classloader 1.0.12

2019-06-17 Thread Karl Pauls
I would like to call a vote on the following release,

Apache Sling File System Classloader 1.0.12

We solved 1 issue in this release:
https://issues.apache.org/jira/projects/SLING/versions/12345673

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2096/

You can use this UNIX script to download the release and verify the signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 2096 /tmp/sling-staging

Please vote to approve these releases:

  [ ] +1 Approve the releases
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...


[jira] [Closed] (SLING-8437) Sling Provisioning to Feature Model Converter Improvement and CLI

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8437.
-

> Sling Provisioning to Feature Model Converter Improvement and CLI
> -
>
> Key: SLING-8437
> URL: https://issues.apache.org/jira/browse/SLING-8437
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Converter 1.0.2
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Feature Model Converter 1.0.4
>
>
> The Provisioning to Feature Model Converter is not really usable. It should 
> have a CLI tool like the Package to FM Converter so that it can be used from 
> the command line.
> There is an issue that the FM Converter is setting the type of a Repoinit to 
> JSON which is not supporter (yet). It should have a type of TEXT.
> Bundle version variables are not supported in the Feature Model and so these 
> variables should be resolved during the conversion from PM to FM.
> Tests with a local output folder did sometimes fails for me and it was very 
> difficult to figure out what was going on. Each test should have its own sub 
> folder so that the output can be verified later and that there will be no 
> side effects between the tests.
> During tests on a faster computer the generated files have the same timestamp 
> as the source file and so existing generated files are still overwritten. 
> Change it so that they can be equal so test will work consistently.
> All of these items are fixed and committed to the branch 'standalone-app'. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-7949) Slingstart Maven Plugin should allow substitution of project properties in feature model files

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-7949.
-

> Slingstart Maven Plugin should allow substitution of project properties in 
> feature model files
> --
>
> Key: SLING-7949
> URL: https://issues.apache.org/jira/browse/SLING-7949
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.4
>
>
> SLING-7738 allows the maven coordinates to be substituted in the feature 
> model files. This should be expanded to support maven properties too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-7968) FeatureModelConverter should use FeatureProvider instead of ArtifactManager

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-7968.
-

> FeatureModelConverter should use FeatureProvider instead of ArtifactManager
> ---
>
> Key: SLING-7968
> URL: https://issues.apache.org/jira/browse/SLING-7968
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2, Feature Model Converter 
> 0.1.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Converter 0.2.0, Slingstart Maven Plugin 
> 1.8.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The feature model converter currently requires an ArtifactManager. This is 
> not needed and can be replaced with the less powerful FeatureProvider. 
> Subsequently, we can use the simpler interface to actually use the maven 
> resolver to resolve features in the Slingstart Maven Plugin (instead of using 
> a ArtifactManager when invoking the model convert.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-7738) Slingstart Maven Plugin should allow substitution of project coordinates in feature model files

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-7738.
-

> Slingstart Maven Plugin should allow substitution of project coordinates in 
> feature model files
> ---
>
> Key: SLING-7738
> URL: https://issues.apache.org/jira/browse/SLING-7738
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.4
>
>
> In order to avoid duplication of information, feature model files processed 
> via maven should support basic variable substitution so that they can inherit 
> certain properties from the parent pom.
> These properties should include:
> {code}
> project.groupId
> project.artifactId
> project.version
> {code}
> these properties can be used in a feature file to generate their IDs, for 
> example:
> {code}
> "id": 
> "${project.groupId}:${project.artifactId}:feature:my-feature-model:${project.version}"
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8423) Make Provisioning to Feature Model Usable for Sling Conversion

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8423.
-

> Make Provisioning to Feature Model Usable for Sling Conversion
> --
>
> Key: SLING-8423
> URL: https://issues.apache.org/jira/browse/SLING-8423
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Converter 1.0.2
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Feature Model Converter 1.0.4
>
>
> I am using the Sling Feature Model Converter to convert Sling’s Provisioning 
> Model from the Launchpad Starter into a Feature Model to run Sling with the 
> Feature Launcher. There are several issues with it and I want to tackle them 
> to create the FM without any manual interactions:
> 1. Make it an executable application like the Content Package to Feature 
> Model Converter using the piccocli
> 2. Make the Model Id configurable so that it fits into Sling Feature Maven 
> Plugin by being able to set group, artifact, classifier and version add at 
> the 'slingosgifeature' type
> 3. Enable to drop duplicate properties like in our case the 
> 'provisioning.model.name’
> 4. Replace variables in the bundle id with the actual value if that is still 
> an issue
> 5. Make sure ‘repoinit’ is of type TEXT and not JSON



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8421) Allow artifact providers that work with URLs instead of Files

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8421.
-

> Allow artifact providers that work with URLs instead of Files
> -
>
> Key: SLING-8421
> URL: https://issues.apache.org/jira/browse/SLING-8421
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model 1.0.2, Feature Model IO 1.0.2, Feature 
> Model Analyser 1.0.2, Feature Model Launcher 1.0.2, Feature Model Converter 
> 1.0.2, slingfeature-maven-plugin 1.0.2, Feature Model API Regions Extension 
> 1.0.2, Feature Model Content Extension 1.0.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model 1.0.4, Feature Model IO 1.0.4, Feature 
> Model Analyser 1.0.4, Feature Model Launcher 1.0.4, Feature Model Converter 
> 1.0.4, Feature Model API Regions Extension 1.0.4, Feature Model Content 
> Extension 1.0.4, slingfeature-maven-plugin 1.0.4
>
>  Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> The way we set-up the feature io (and subsequently, the way the launcher 
> currently uses it) there is a build-in assumption that artifacts are 
> available as local files. While that makes some sense there are scenarios 
> where it would be more efficient to not require them to be Files unless it is 
> really needed. We should make it possible for a provider to hand out URLs 
> instead of Files and prefer to use those URLs where possible as a File can be 
> easily accessed via a URL but the reverse is not true without locally 
> buffering the URL content as a File.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-7734) Slingstart Maven Plugin does not provide context to realize inherited features

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-7734.
-

> Slingstart Maven Plugin does not provide context to realize inherited features
> --
>
> Key: SLING-7734
> URL: https://issues.apache.org/jira/browse/SLING-7734
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.4
>
>
> When converting features that inherit other features to the provisioning 
> model context needs to be provided to allow the system to find inherited 
> features.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8474) Improve scanner by caching scanned results

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8474.
-

> Improve scanner by caching scanned results
> --
>
> Key: SLING-8474
> URL: https://issues.apache.org/jira/browse/SLING-8474
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.0.4
>
>
> In complex projects with a lot of features, potentially several aggregated 
> features, there might be a lot of overlap in terms of artifacts that need to 
> be scanned when all features are analysed. This results in multiple artifacts 
> being scanned over and over again, slowing down the analysis process.
> A simple in memory cache in the scanner avoids this



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8488) Slingstart maven plugin DependencyLifecycleParticipant needs to clean target/processed dir

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8488.
-

> Slingstart maven plugin DependencyLifecycleParticipant needs to clean 
> target/processed dir
> --
>
> Key: SLING-8488
> URL: https://issues.apache.org/jira/browse/SLING-8488
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.4
>
>
> The DependencyLifecycleParticipant runs before the clean if someone is to 
> invoke mvn clean install. That is fine, however, it invokes the 
> FeatureModelConverter to convert features into provisioning files. If that 
> has happend before, the convert will use the old cached results instead of 
> converting again. 
> The fix should be easy, we have to delete the target/processed dir in the 
> DependencyLifecycleParticipant manually to make sure we are not running on 
> stale models.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8050) Add substitution support for project version as OSGi version

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8050.
-

> Add substitution support for project version as OSGi version
> 
>
> Key: SLING-8050
> URL: https://issues.apache.org/jira/browse/SLING-8050
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.4
>
>
> Currently ${project.version} in a feature file is substituted with the maven 
> version of the project. However in some cases you might need the OSGi version 
> which is slightly different with respect to the qualifier (separated by dot 
> not by dash)
> With ${project.osgiVersion} you get the OSGi version of the project
> This is the slingstart-maven-plugin implementation of a similar feature in 
> the slingfeature-maven-plugin (see SLING-8049)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8476) Packages are exported with 0.x

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8476.
-

> Packages are exported with 0.x
> --
>
> Key: SLING-8476
> URL: https://issues.apache.org/jira/browse/SLING-8476
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model IO 1.0.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model IO 1.0.4
>
>
> The packages are exported with 0.x versions. These should have been changed 
> to 1.0.0 with the 1.0.0 release



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8478) Adding method to match Requirements and Capabilities

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8478.
-

> Adding method to match Requirements and Capabilities
> 
>
> Key: SLING-8478
> URL: https://issues.apache.org/jira/browse/SLING-8478
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.0.4, Feature Model IO 1.0.4, Feature 
> Model Analyser 1.0.4
>
>
> a feature can have requirements and capabilities, we use the OSGi interfaces 
> for this. However, there is currently no easy way to match requirements and 
> capabilities as these interfaces do not provide a method for it.
> For example, if you want to know whether a requirement is met by the 
> available capabilities, that's not possible. While the OSGi specs provide a 
> resolver that approach is way too heavy and not really suited for simple use 
> cases. The resolver is used by the framework for bundle wiring.
> Therefore I propose we add a simple interface like
> MatchingRequirement extends Requirement {
>boolean match(Capability cap);
> }
> and this allows to match requirements and capabilities. As we're using Apache 
> Felix utils for our reqs/caps, this method is already available there, so we 
> don't have to implement this ourselves. Its just making it available 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8484) Fail the launcher if not all bundles could be launched

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8484.
-

> Fail the launcher if not all bundles could be launched
> --
>
> Key: SLING-8484
> URL: https://issues.apache.org/jira/browse/SLING-8484
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Feature Model Launcher 1.0.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model Launcher 1.0.4
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If the launcher is not able to start all bundles successfully, the launcher 
> should fail with a non-zero exit code.
> This functionality should not be the default. It needs to be enabled with a 
> flag, for example -foe (Fail on Error)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8485) Feature Launcher should keep order of features

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8485.
-

> Feature Launcher should keep order of features
> --
>
> Key: SLING-8485
> URL: https://issues.apache.org/jira/browse/SLING-8485
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model Launcher 1.0.2
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Launcher 1.0.4
>
>
> As part of SLING-8334 in [0] a "loadedFeatures" HashMap has been introduced. 
> That in turn, is now used to get the final list of features from its values() 
> [1]. 
> As HashMaps are not ordered the order is effectively unpredictably now. We 
> should fix this and make sure we keep the original order.
> [0] 
> https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/4103794287784f51997866715d17466effe9e291
> [1] 
> https://github.com/apache/sling-org-apache-sling-feature-launcher/blob/master/src/main/java/org/apache/sling/feature/launcher/impl/FeatureProcessor.java#L104



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8475) Feature packages are exported as 0.2.0

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8475.
-

> Feature packages are exported as 0.2.0
> --
>
> Key: SLING-8475
> URL: https://issues.apache.org/jira/browse/SLING-8475
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.0.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.0.4
>
>
> Both packages are currently exported as 0.2.0 which should have been updated 
> for the release to 1.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8472) Provide an option to create a reference file with all attached features

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8472.
-

> Provide an option to create a reference file with all attached features
> ---
>
> Key: SLING-8472
> URL: https://issues.apache.org/jira/browse/SLING-8472
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.0.4
>
>
> In order to be able to get all feature files of a project through maven, we 
> could generate a reference file containing the maven coordinates of all 
> attached features of that project



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-8221) Feature model does not override from command line a property if set in pom.xml

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-8221.
-

> Feature model does not override from command line a property if set in pom.xml
> --
>
> Key: SLING-8221
> URL: https://issues.apache.org/jira/browse/SLING-8221
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Slingstart Maven Plugin 1.8.2, slingfeature-maven-plugin 
> 0.8.0
>Reporter: Davide Giannella
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.4, slingfeature-maven-plugin 
> 1.0.0
>
>
> If you set a property in the pom.xml in the format of
> {code:xml}
> 
>   1.2.3
> 
> {code}
> and you use it in a json file to specify a dependency
> {code}
>...
> {
>   "id":"org.apache.jackrabbit:oak-core-spi:${oak.version}",
>   "start-level":"15"
> },
>...
> {code}
> if you then try to override it from command line with something like
> {noformat}
> mvn clean verify -Doak.version=4.5.6
> {noformat}
> the generated jar will eventually have the version {{1.2.3}}
>  
> /cc [~bosschaert], [~kpauls]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (SLING-7763) Slingstart Maven Plugin looks at non-substituted files when converting to provisioning model

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-7763.
-

> Slingstart Maven Plugin looks at non-substituted files when converting to 
> provisioning model
> 
>
> Key: SLING-7763
> URL: https://issues.apache.org/jira/browse/SLING-7763
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.8.2
>Reporter: David Bosschaert
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Slingstart Maven Plugin 1.8.4
>
>
> The slingstart maven plugin converts feature model files back to provisioning 
> model files. However it looks at the feature model files in 
> src/main/features, these could contain maven variables such as 
> ${project.groupId}, ${project.artifactId} and ${project.version}. It should 
> used the files that are converted instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8495) Make FSClassLoader its cache location root directory configurable

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8495.
---
Resolution: Fixed

Thanks [~krystian], I merged the PR.

> Make FSClassLoader its cache location root directory configurable
> -
>
> Key: SLING-8495
> URL: https://issues.apache.org/jira/browse/SLING-8495
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: File System ClassLoader 1.0.10
>Reporter: Krystian Nowak
>Assignee: Karl Pauls
>Priority: Major
> Fix For: File System ClassLoader 1.0.12
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Currently FSClassLoader's cache location is on the bundle persistent storage 
> area.
> In cases when it would make more sense to externalize it to a different 
> location, file system cache location root directory needs to be configurable.
> For that 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderProvider.java#L108]
>  needs to be made parametrized to have its "root" directory configurable.
> Also:
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderWebConsole.java#L95]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L79]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L109]
> should be changed accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: [RESULT] [VOTE] Slingstart Maven Plugin 1.8.4

2019-06-17 Thread Karl Pauls
Time to call the vote on the Apache Sling Slingstart Maven Plugin 1.8.4 release.

* +1 votes from Carsten Ziegeler, Karl Pauls, David Bosschaert,
Andreas Schaefer, and Daniel Klco.

* No other votes.

The vote is successful. I will make the artifacts available as soon as possible.


Re: [RESULT][VOTE] Release Sling Feature Components 1.0.4

2019-06-17 Thread Karl Pauls
Time to call the vote on the Apache Sling Feature Components 1.0.4 release.

* +1 votes from Carsten Ziegeler, Karl Pauls, Simone Tripodi, David
Bosschaert, Andreas Schaefer, and Daniel Klco.

* No other votes.

The vote is successful. I will make the artifacts available as soon as possible.


RE: Happy tenth birthday, Apache Sling!

2019-06-17 Thread Stefan Seifert
+1 !

stefan

>-Original Message-
>From: Bertrand Delacretaz [mailto:bdelacre...@apache.org]
>Sent: Monday, June 17, 2019 8:42 AM
>To: dev
>Subject: Happy tenth birthday, Apache Sling!
>
>Hi Sling community,
>
>As per [1], the Apache Sling project was established ten years ago, on
>June 17th, 2009, after entering incubation on September 5th, 2007.
>
>Even though it is ten years old, it's great to see the sustained
>ongoing activity in this project.
>
>Thank you to everybody who's played a role in this, it's been a fantastic
>ride!
>
>-Bertrand
>
>[1]
>http://apache.org/foundation/records/minutes/2009/board_minutes_2009_06_17.
>txt



Re: [VOTE] Release Apache Sling Auth Core 1.4.4

2019-06-17 Thread Karl Pauls
+1

regards,

Karl

On Sat, Jun 15, 2019 at 4:39 PM Carsten Ziegeler  wrote:
>
> +1
>
>
> Carsten Ziegeler wrote
> > We solved 4 issues in this release:
> >
> > https://issues.apache.org/jira/projects/SLING/versions/12342325
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2094/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> >
> > Usage:
> > sh check_staged_release.sh 2094 /tmp/sling-staging
> >
> > Please vote to approve these release:
> >
> >[ ] +1 Approve the releases
> >[ ]  0 Don't care
> >[ ] -1 Don't release, because ...
> >
> > Regards
> > Carsten
> > --
> > Carsten Ziegeler
> > Adobe Research Switzerland
> > cziege...@apache.org
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



-- 
Karl Pauls
karlpa...@gmail.com


Re: [VOTE] Release Apache Sling Servlets Resolver 2.5.6

2019-06-17 Thread Karl Pauls
+1

regards,

Karl

On Sat, Jun 15, 2019 at 4:39 PM Carsten Ziegeler  wrote:
>
> +1
>
>
> Carsten Ziegeler wrote
> > We solved 3 issues in this release:
> >
> > https://issues.apache.org/jira/projects/SLING/versions/12345473
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2095/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> >
> > Usage:
> > sh check_staged_release.sh 2095 /tmp/sling-staging
> >
> > Please vote to approve these release:
> >
> >[ ] +1 Approve the releases
> >[ ]  0 Don't care
> >[ ] -1 Don't release, because ...
> >
> > Regards
> > Carsten
> > --
> > Carsten Ziegeler
> > Adobe Research Switzerland
> > cziege...@apache.org
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org



-- 
Karl Pauls
karlpa...@gmail.com


[jira] [Commented] (SLING-8495) Make FSClassLoader its cache location root directory configurable

2019-06-17 Thread Krystian Nowak (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865530#comment-16865530
 ] 

Krystian Nowak commented on SLING-8495:
---

[~karlpauls]: Proposed changes in this PR: 
[https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/pull/1]

> Make FSClassLoader its cache location root directory configurable
> -
>
> Key: SLING-8495
> URL: https://issues.apache.org/jira/browse/SLING-8495
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: File System ClassLoader 1.0.10
>Reporter: Krystian Nowak
>Assignee: Karl Pauls
>Priority: Major
> Fix For: File System ClassLoader 1.0.12
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently FSClassLoader's cache location is on the bundle persistent storage 
> area.
> In cases when it would make more sense to externalize it to a different 
> location, file system cache location root directory needs to be configurable.
> For that 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderProvider.java#L108]
>  needs to be made parametrized to have its "root" directory configurable.
> Also:
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderWebConsole.java#L95]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L79]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L109]
> should be changed accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8495) Make FSClassLoader its cache location root directory configurable

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-8495:
--
Fix Version/s: File System ClassLoader 1.0.12

> Make FSClassLoader its cache location root directory configurable
> -
>
> Key: SLING-8495
> URL: https://issues.apache.org/jira/browse/SLING-8495
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: File System ClassLoader 1.0.10
>Reporter: Krystian Nowak
>Assignee: Karl Pauls
>Priority: Major
> Fix For: File System ClassLoader 1.0.12
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently FSClassLoader's cache location is on the bundle persistent storage 
> area.
> In cases when it would make more sense to externalize it to a different 
> location, file system cache location root directory needs to be configurable.
> For that 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderProvider.java#L108]
>  needs to be made parametrized to have its "root" directory configurable.
> Also:
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderWebConsole.java#L95]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L79]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L109]
> should be changed accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-8495) Make FSClassLoader its cache location root directory configurable

2019-06-17 Thread Karl Pauls (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-8495:
-

Assignee: Karl Pauls

> Make FSClassLoader its cache location root directory configurable
> -
>
> Key: SLING-8495
> URL: https://issues.apache.org/jira/browse/SLING-8495
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: File System ClassLoader 1.0.10
>Reporter: Krystian Nowak
>Assignee: Karl Pauls
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently FSClassLoader's cache location is on the bundle persistent storage 
> area.
> In cases when it would make more sense to externalize it to a different 
> location, file system cache location root directory needs to be configurable.
> For that 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderProvider.java#L108]
>  needs to be made parametrized to have its "root" directory configurable.
> Also:
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderWebConsole.java#L95]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L79]
> * 
> [https://github.com/apache/sling-org-apache-sling-commons-fsclassloader/blob/master/src/main/java/org/apache/sling/commons/fsclassloader/impl/FSClassLoaderMBeanImpl.java#L109]
> should be changed accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)