Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
On Friday, September 27, 2019 5:21:03 PM CEST Radu Cotescu wrote: > Hi Olli, Hi Radu, > > On 27 Sep 2019, at 11:20, Oliver Lietz wrote: > > > > Please vote to approve this release: > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because … > > I would have loved to spend more time on [0] before cutting a release. It > feels like the implementation was rushed, Why do you think so? Can you explain? > although the issue was open for > four years. There’s also no extra documentation added at [1] about how [0] > can be used by developers. > > Unfortunately I’m away for the next 3 weeks - do you think [0] could wait > until then? The current implementation is the minimal to start with and was carefully added. The new feature doesn't change the existing behavior and doesn't expose a new public API. The TODO mentioned by Stefan explains the design. More implementation - taking language version and engine into account - is still missing because I'm investigating on a semantic version parser *and* there is most probably no demand (I'm not aware of an engine supporting more than one language version properly). As you might have noticed I improved the scripting documentation and I'm still in the process to consolidate the additional documentation from our wiki into our site. Once done I will document the new feature coming with SLING-4330. Regards, O. > Thanks, > Radu > > [0] - https://issues.apache.org/jira/browse/SLING-4330 > [1] - https://sling.apache.org/documentation/bundles/scripting.html
[jira] [Created] (SLING-8747) establish @apachesling npmjs organization
Ruben Reusser created SLING-8747: Summary: establish @apachesling npmjs organization Key: SLING-8747 URL: https://issues.apache.org/jira/browse/SLING-8747 Project: Sling Issue Type: Improvement Components: CI Reporter: Ruben Reusser now that the donation for the slingpackager has been accepted we need to create a common apachesling organization on npmjs and start setting up a ci/cd flow to release the slingpackager https://issues.apache.org/jira/browse/SLING-8584 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[caconfig] is allow read for everyone on /conf node ok?
Hey realized on applications using caconfig that if you had read right only on /conf/, and not on /conf, each (unsucessfull) lookup ended up in a quiet AccessDeniedException at jackrabbit level, ending up in a null return value. It "works", but still under performs (exceptions are expensive at that intensity). I think that in our context, we can set read rights on /conf, but i wonder if we shouldn't have "conf roots" for ca configs, or "root depth" whose lookup is done before reaching JCR. wdyt? Nicolas
Re: [VOTE] Release Apache Sling Scripting JSP 2.3.6
+1 On Fri, Sep 27, 2019 at 10:40 AM Radu Cotescu wrote: > +1 > > > On 27 Sep 2019, at 10:52, Karl Pauls wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > >
Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
Hi Olli, > On 27 Sep 2019, at 11:20, Oliver Lietz wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because … > I would have loved to spend more time on [0] before cutting a release. It feels like the implementation was rushed, although the issue was open for four years. There’s also no extra documentation added at [1] about how [0] can be used by developers. Unfortunately I’m away for the next 3 weeks - do you think [0] could wait until then? Thanks, Radu [0] - https://issues.apache.org/jira/browse/SLING-4330 [1] - https://sling.apache.org/documentation/bundles/scripting.html
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 2.0.2
+1 On Fri, Sep 27, 2019 at 11:03 AM Stefan Seifert wrote: > +1 > > >
RE: [VOTE] Release Apache Sling Scripting Thymeleaf 2.0.2
+1
RE: [VOTE] Release Apache Sling Scripting FreeMarker 1.0.2
+1
RE: [VOTE] Release Apache Sling Scripting Groovy 1.1.0
+1
Re: [VOTE] Release Apache Sling Resource Resolver 1.6.14
+1 On Fri, Sep 27, 2019 at 10:34 AM Radu Cotescu wrote: > +1 > > > On 26 Sep 2019, at 23:24, Oliver Lietz wrote: > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > >
RE: [VOTE] Release Apache Sling Scripting Core 2.0.60
+1 - others more deeper into the sling script core (than myself) should have a look at it as well. stefan p.s. there is an open TODO in the code - is it still relevant? https://github.com/apache/sling-org-apache-sling-scripting-core/blob/master/src/main/java/org/apache/sling/scripting/core/impl/SlingScriptEnginePicker.java#L95 >-Original Message- >From: Oliver Lietz [mailto:apa...@oliverlietz.de] >Sent: Friday, September 27, 2019 11:20 AM >To: dev@sling.apache.org >Subject: [VOTE] Release Apache Sling Scripting Core 2.0.60 > >Hi, > >We solved 4 issues in this release: >https://issues.apache.org/jira/browse/SLING/fixforversion/12345580 > >Staging repository: >https://repository.apache.org/content/repositories/orgapachesling-2135 > >You can use this UNIX script to download the release and verify the >signatures: >https://gitbox.apache.org/repos/asf?p=sling-tooling- >release.git;a=blob;f=check_staged_release.sh;hb=HEAD > >Usage: >sh check_staged_release.sh 2135 /tmp/sling-staging > >Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > >This majority vote is open for at least 72 hours. > >Regards, >O. > > >
Re: [VOTE] Release Apache Sling Commons MIME 2.2.2
+1 On Fri, Sep 27, 2019 at 6:01 AM Oliver Lietz wrote: > On Friday, September 27, 2019 10:14:59 AM CEST Robert Munteanu wrote: > > Hi, > > > > We solved 2 issues in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12344061 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2139/ > > +1 > > O. > > > > >
Re: [VOTE] Release Apache Sling Scripting Core 2.0.60
+1 On Fri, Sep 27, 2019 at 5:20 AM Oliver Lietz wrote: > Hi, > > We solved 4 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12345580 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2135 > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2135 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > O. > > > >
Re: [VOTE] Release Apache Sling Scripting JSP 2.3.6
+1 > On 27 Sep 2019, at 10:52, Karl Pauls wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
RE: [VOTE] Release Apache Sling Scripting JSP 2.3.6
+1
Re: [VOTE] Release Apache Sling Scripting FreeMarker 1.0.2
+1 > On 27 Sep 2019, at 11:21, Oliver Lietz wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
Re: [VOTE] Release Apache Sling Scripting Groovy 1.1.0
+1 > On 27 Sep 2019, at 11:22, Oliver Lietz wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 2.0.2
+1 > On 27 Sep 2019, at 11:24, Oliver Lietz wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
Re: [VOTE] Release Apache Sling Resource Resolver 1.6.14
+1 > On 26 Sep 2019, at 23:24, Oliver Lietz wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ...
[jira] [Commented] (SLING-8742) Allow overriding the extension when using the RequestDispatcher
[
https://issues.apache.org/jira/browse/SLING-8742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939324#comment-16939324
]
Robert Munteanu commented on SLING-8742:
That's good to know, thanks [~royteeuwen]!
Just note that this might take a while, since my changes will bump
{{org.apache.sling.api.request}} to version 2.5, which causes some problems
downstream. Also the {{org.apache.sling.api.resource}} package version will be
bumped. But I'll probably get around to it sooner rather than later.
> Allow overriding the extension when using the RequestDispatcher
> ---
>
> Key: SLING-8742
> URL: https://issues.apache.org/jira/browse/SLING-8742
> Project: Sling
> Issue Type: Improvement
> Components: API
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: API 2.20.2
>
>
> It is sometimes useful to be able to include another resource and override
> the extension at the same time.
> My scenario is that I am routing all requests through an entry point
> {{/content/maven.html}} and then serving resources based on the suffix.
> If I a binary file is requested, it should be downloaded ( by forcing the
> extension to be null ), but instead the html extension is used, which means
> the HTML Renderer kicks in.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [VOTE] Release Apache Sling Scripting JSP 2.3.6
On Friday, September 27, 2019 10:52:45 AM CEST Karl Pauls wrote: > We solved 1 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12346272 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2140/ +1 O.
Re: [VOTE] Release Apache Sling Commons MIME 2.2.2
On Friday, September 27, 2019 10:14:59 AM CEST Robert Munteanu wrote: > Hi, > > We solved 2 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12344061 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2139/ +1 O.
[jira] [Updated] (SLING-3766) Store the project's content sync root property in the filesystem
[ https://issues.apache.org/jira/browse/SLING-3766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-3766: --- Description: We should store the project's content sync root property in the filesystem, e.g. in the .settings directory, so that it can be shared through source control or other means. _Original description_: Just noticed that if I import a zipped content project, with all the Eclipse project files properly set up, the content sync root is shows as a filesystem structure, not with our nice navigator. [~stefanegli] - this would be nice to have for 1.0.2 if it's a quick fix. Otherwise we'll leave it for 1.1.0 . was: We should store the project's content sync root property in the filesystem, e.g. in the .settings directory, so that it can be shared through source control or other means. _Original description_: Just noticed that if I import a zipped content project, with all the Eclipse project files properly set up, the content sync root is shows as a filesystem structure, not with our nice navigator. [~egli] - this would be nice to have for 1.0.2 if it's a quick fix. Otherwise we'll leave it for 1.1.0 . > Store the project's content sync root property in the filesystem > > > Key: SLING-3766 > URL: https://issues.apache.org/jira/browse/SLING-3766 > Project: Sling > Issue Type: Improvement > Components: IDE >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Minor > Fix For: Sling Eclipse IDE 1.0.8 > > > We should store the project's content sync root property in the filesystem, > e.g. in the .settings directory, so that it can be shared through source > control or other means. > _Original description_: > Just noticed that if I import a zipped content project, with all the Eclipse > project files properly set up, the content sync root is shows as a filesystem > structure, not with our nice navigator. > [~stefanegli] - this would be nice to have for 1.0.2 if it's a quick fix. > Otherwise we'll leave it for 1.1.0 . -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-3741) When processing deleted folders, check for a covering aggregate higher in the filesytem hierarchy
[
https://issues.apache.org/jira/browse/SLING-3741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-3741:
---
Description:
Minimal scenario reported by [~stefanegli]
* Create:
{code}
grandparent [nt:unstructured]
\- parent [nt:unstructured]
|- child1 [nt:unstructured]
\- child2 [nt:unstructured]
{code}
* Then change child2 to sling:Folder
* Changing child2 back to nt:unstructured then causes the deletion of parent
(since I delete parent/child2 and parent folders explicitly, as they are no
longer needed)
was:
Minimal scenario reported by [~egli]
* Create:
{code}
grandparent [nt:unstructured]
\- parent [nt:unstructured]
|- child1 [nt:unstructured]
\- child2 [nt:unstructured]
{code}
* Then change child2 to sling:Folder
* Changing child2 back to nt:unstructured then causes the deletion of parent
(since I delete parent/child2 and parent folders explicitly, as they are no
longer needed)
> When processing deleted folders, check for a covering aggregate higher in the
> filesytem hierarchy
> -
>
> Key: SLING-3741
> URL: https://issues.apache.org/jira/browse/SLING-3741
> Project: Sling
> Issue Type: Bug
> Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.0
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.0.2
>
> Attachments: sling3741.zip
>
>
> Minimal scenario reported by [~stefanegli]
> * Create:
> {code}
> grandparent [nt:unstructured]
> \- parent [nt:unstructured]
> |- child1 [nt:unstructured]
> \- child2 [nt:unstructured]
> {code}
> * Then change child2 to sling:Folder
> * Changing child2 back to nt:unstructured then causes the deletion of parent
> (since I delete parent/child2 and parent folders explicitly, as they are no
> longer needed)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-7830) Defined leader switch
[ https://issues.apache.org/jira/browse/SLING-7830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated SLING-7830: --- Description: The current leader selection is based on startup time and sling id (mainly) and is stable across changed in the topology for as long as the leader is up and running. However there are use cases like blue green deployment where new instances with a new version are started and taking over the functionality. However with the current discovery setup, the leader would still be one of the instances with the old version. With a new deployed version, tasks currently bound to the leader should run on the new version. Therefore the leader needs to switch and stay the leader (until it dies). We probably need an additional criteria for the leader selection /cc [~stefanegli] was: The current leader selection is based on startup time and sling id (mainly) and is stable across changed in the topology for as long as the leader is up and running. However there are use cases like blue green deployment where new instances with a new version are started and taking over the functionality. However with the current discovery setup, the leader would still be one of the instances with the old version. With a new deployed version, tasks currently bound to the leader should run on the new version. Therefore the leader needs to switch and stay the leader (until it dies). We probably need an additional criteria for the leader selection /cc [~egli] > Defined leader switch > - > > Key: SLING-7830 > URL: https://issues.apache.org/jira/browse/SLING-7830 > Project: Sling > Issue Type: Improvement > Components: Discovery >Affects Versions: Discovery Oak 1.2.22 >Reporter: Carsten Ziegeler >Assignee: Stefan Egli >Priority: Major > Fix For: Discovery Oak 1.2.28 > > Time Spent: 20m > Remaining Estimate: 0h > > The current leader selection is based on startup time and sling id (mainly) > and is stable across changed in the topology for as long as the leader is up > and running. > However there are use cases like blue green deployment where new instances > with a new version are started and taking over the functionality. However > with the current discovery setup, the leader would still be one of the > instances with the old version. > With a new deployed version, tasks currently bound to the leader should run > on the new version. > Therefore the leader needs to switch and stay the leader (until it dies). > We probably need an additional criteria for the leader selection > /cc [~stefanegli] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-4665) Provide a Helper class to compare topology views
[
https://issues.apache.org/jira/browse/SLING-4665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated SLING-4665:
---
Description:
As discussed in SLING-4627, the Sling discovery would benefit from having a
helper class that allow applications to compare two different topology views.
As suggested by [~stefanegli] this could be developed in a new bundle
{code}
org.apache.sling
org.apache.sling.discovery.commons
{code}
The issue has no component/version assigned as it may require creating a new
one for discovery.common.
was:
As discussed in SLING-4627, the Sling discovery would benefit from having a
helper class that allow applications to compare two different topology views.
As suggested by [~egli] this could be developed in a new bundle
{code}
org.apache.sling
org.apache.sling.discovery.commons
{code}
The issue has no component/version assigned as it may require creating a new
one for discovery.common.
> Provide a Helper class to compare topology views
>
>
> Key: SLING-4665
> URL: https://issues.apache.org/jira/browse/SLING-4665
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
>Reporter: Timothee Maret
>Assignee: Stefan Egli
>Priority: Major
> Fix For: Discovery Commons 1.0.0
>
> Attachments: SLING-4665.patch
>
>
> As discussed in SLING-4627, the Sling discovery would benefit from having a
> helper class that allow applications to compare two different topology views.
> As suggested by [~stefanegli] this could be developed in a new bundle
> {code}
> org.apache.sling
> org.apache.sling.discovery.commons
> {code}
> The issue has no component/version assigned as it may require creating a new
> one for discovery.common.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[VOTE] Release Apache Sling Scripting FreeMarker 1.0.2
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12335658 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2136 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2136 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, O.
Re: [VOTE] Release Apache Sling Scripting Groovy 1.1.0
+1 - all checks ok Regards Julian On Fri, Sep 27, 2019 at 11:22 AM Oliver Lietz wrote: > > Hi, > > We solved 5 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12344109 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2137 > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2137 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > O. > > > >
Re: [VOTE] Release Apache Sling Scripting Thymeleaf 2.0.2
+1 - all checks ok Regards Julian On Fri, Sep 27, 2019 at 11:24 AM Oliver Lietz wrote: > > Hi, > > We solved 7 issues in this release: > https://issues.apache.org/jira/browse/SLING/fixforversion/12344052 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2138 > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2138 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards, > O. > > > >
[VOTE] Release Apache Sling Scripting Thymeleaf 2.0.2
Hi, We solved 7 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12344052 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2138 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2138 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, O.
[VOTE] Release Apache Sling Scripting Groovy 1.1.0
Hi, We solved 5 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12344109 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2137 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2137 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, O.
Re: Changing the resource to render and the handling servlet in a request
Hi Robert Have you tried "forwarding" instead of "including"? AFAIK that should clear any previous reuest path info etc. Regards Julian On Thu, Sep 26, 2019 at 4:54 PM Robert Munteanu wrote: > > On Thu, 2019-09-26 at 13:32 +0200, Radu Cotescu wrote: > > Hi Robert, > > > > > On 26 Sep 2019, at 13:08, Robert Munteanu > > > wrote: > > > > > > > > > My solution has two steps: > > > > > > 1. wrap the original request using a SlingHttpServletRequestWrapper > > > and > > > overriding getResource() to return the new resource. Also > > > overriding > > > getRequestPathInfo to return an object that points to the new > > > resource > > > > > > 2. obtain a reference to the DefaultGetServlet via > > > > > > @Reference(target = > > > "(component.name=org.apache.sling.servlets.get.DefaultGetServlet)") > > > private Servlet getServlet; > > > > > > (I guess I could use the component pid as a slight improvement). > > > > > > and invoke its service() method with the altered request and the > > > same response. > > > > > > > Why can’t you use the RequestDispatcher in the second step instead of > > directly referencing the DefaultGetServlet? > > Good question :-) There are two answers to this: > > 1. I did not think of that > 2. It does not allow me to override the extension. But that should be a > simple change. So I filed > > https://issues.apache.org/jira/browse/SLING-8742 > > to allow overriding the extension when including a resource. > > Thanks, > Robert >
[VOTE] Release Apache Sling Scripting Core 2.0.60
Hi, We solved 4 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12345580 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2135 You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2135 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, O.
Re: [VOTE] Release Apache Sling Scripting JSP 2.3.6
On Fri, 2019-09-27 at 10:52 +0200, Karl Pauls wrote: > sh check_staged_release.sh 2140 /tmp/sling-staging +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Commons MIME 2.2.2
+1 (non-binding) -Ashok On 27/09/19, 1:47 PM, "Robert Munteanu" wrote: On Fri, 2019-09-27 at 08:14 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert
[VOTE] Release Apache Sling Scripting JSP 2.3.6
We solved 1 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12346272 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2140/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2140 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ...
Re: [VOTE] Release Apache Sling Commons MIME 2.2.2
+1 regards, Karl On Fri, Sep 27, 2019 at 10:41 AM Stefan Seifert wrote: > > +1 > -- Karl Pauls karlpa...@gmail.com
[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #335 is BROKEN
Please see
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/335/
for details.
No further emails will be sent until the status of the build is changed.
Build log follows below:
Started by upstream project "Sling/sling-org-apache-sling-starter/master" build
number 76
originally caused by:
Push event to branch master
Connecting to https://api.github.com using rombert/** (Personal access
token for Github repository access. Use with Apache Sling jobs only.)
Obtained Jenkinsfile from 3f5a0b1917f0281a20d859f3d001354be528e77f
Running in Durability level: MAX_SURVIVABILITY
Loading library sling@master
Examining apache/sling-tooling-jenkins
Attempting to resolve master as a branch
Resolved master as branch master at revision
9894be99cd9c28362536fae36ce29725786f4874
using credential sling-github-token
> git rev-parse --is-inside-work-tree # timeout=10
Fetching changes from the remote Git repository
> git config remote.origin.url
> https://github.com/apache/sling-tooling-jenkins.git # timeout=10
Fetching without tags
Fetching upstream changes from
https://github.com/apache/sling-tooling-jenkins.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress
> https://github.com/apache/sling-tooling-jenkins.git
> +refs/heads/master:refs/remotes/origin/master
Checking out Revision 9894be99cd9c28362536fae36ce29725786f4874 (master)
> git config core.sparsecheckout # timeout=10
> git checkout -f 9894be99cd9c28362536fae36ce29725786f4874
Commit message: "corrected typo"
> git rev-list --no-walk 9894be99cd9c28362536fae36ce29725786f4874 # timeout=10
[Pipeline] Start of Pipeline
[Pipeline] node
Running on H29 in
/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master
[Pipeline] {
[Pipeline] timeout
Timeout set to expire after 15 min without activity
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Init)
[Pipeline] checkout
using credential sling-github-token
Fetching changes from the remote Git repository
Fetching without tags
> git rev-parse --is-inside-work-tree # timeout=10
> git config remote.origin.url
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git #
> timeout=10
Fetching upstream changes from
https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials Personal access token for Github
repository access. Use with Apache Sling jobs only.
> git fetch --no-tags --progress
> https://github.com/apache/sling-org-apache-sling-launchpad-testing.git
> +refs/heads/master:refs/remotes/origin/master
Checking out Revision 3f5a0b1917f0281a20d859f3d001354be528e77f (master)
Commit message: "Java 13 is out, test with 13 instead of 12."
> git config core.sparsecheckout # timeout=10
> git checkout -f 3f5a0b1917f0281a20d859f3d001354be528e77f
> git rev-list --no-walk 3f5a0b1917f0281a20d859f3d001354be528e77f # timeout=10
[Pipeline] sh
+ git config remote.origin.url
[Pipeline] fileExists
[Pipeline] readJSON
[Pipeline] echo
Jenkins overrides: [jdks:[8, 11, 13], archivePatterns:[**/logs/*.log],
emailRecipients:[dev@sling.apache.org],
upstreamProjects:[../sling-org-apache-sling-starter/master,
../sling-org-apache-sling-launchpad-test-bundles/master]]
[Pipeline] echo
Final job config: [jdks:[8, 11, 13],
upstreamProjects:[../sling-org-apache-sling-starter/master,
../sling-org-apache-sling-launchpad-test-bundles/master],
archivePatterns:[**/logs/*.log], mavenGoal:, additionalMavenParams:,
rebuildFrequency:@weekly, enabled:true, emailRecipients:[dev@sling.apache.org],
repoName:sling-org-apache-sling-launchpad-testing]
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Configure Job)
[Pipeline] properties
[Pipeline] }
[Pipeline] // stage
[Pipeline] readMavenPom
[Pipeline] stage
[Pipeline] { (Build (Java 8, deploy))
[Pipeline] withMaven
[withMaven] Options:
[org.jenkinsci.plugins.pipeline.maven.publishers.GeneratedArtifactsPublisher[disabled=false],
JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false],
org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='false',
healthy='', unHealthy='', thresholdLimit='low'],
org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=false,
scopes=[compile, provided, runtime], versions={snapshot:true, release:false}]]
[withMaven] Available options:
[withMaven] using JDK installation JDK 1.8 (latest)
[withMaven] using Maven installation 'Maven (latest)'
[Pipeline] {
[Pipeline] sh
+ mvn -U clean deploy
- withMaven Wrapper script -
Picked up JAVA_TOOL_OPTIONS:
-Dmaven.ext.class.path="/home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master@tmp/withMavenb50074fd/pipeline-maven-spy.jar"
RE: [VOTE] Release Apache Sling Commons MIME 2.2.2
+1
RE: [VOTE] Release Apache Sling Resource Resolver 1.6.14
+1
Re: [VOTE] Release Apache Sling Commons MIME 2.2.2
On Fri, 2019-09-27 at 08:14 +, Robert Munteanu wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[VOTE] Release Apache Sling Commons MIME 2.2.2
Hi, We solved 2 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12344061 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2139/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2139 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Robert Munteanu
[jira] [Resolved] (SLING-8746) Upgrade to parent pom 35
[ https://issues.apache.org/jira/browse/SLING-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-8746. Resolution: Fixed Fixed with [sling-org-apache-sling-commons-mime commit 0d5d434|https://github.com/apache/sling-org-apache-sling-commons-mime/commit/0d5d434]. > Upgrade to parent pom 35 > > > Key: SLING-8746 > URL: https://issues.apache.org/jira/browse/SLING-8746 > Project: Sling > Issue Type: Task > Components: Commons >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Commons Mime 2.2.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8746) Upgrade to parent pom 35
Robert Munteanu created SLING-8746: -- Summary: Upgrade to parent pom 35 Key: SLING-8746 URL: https://issues.apache.org/jira/browse/SLING-8746 Project: Sling Issue Type: Task Components: Commons Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Commons Mime 2.2.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8742) Allow overriding the extension when using the RequestDispatcher
[
https://issues.apache.org/jira/browse/SLING-8742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939186#comment-16939186
]
Roy Teeuwen commented on SLING-8742:
+1. I think you would make a lot of people happy with this one, I have seen
people having this issue on multiple projects.
> Allow overriding the extension when using the RequestDispatcher
> ---
>
> Key: SLING-8742
> URL: https://issues.apache.org/jira/browse/SLING-8742
> Project: Sling
> Issue Type: Improvement
> Components: API
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: API 2.20.2
>
>
> It is sometimes useful to be able to include another resource and override
> the extension at the same time.
> My scenario is that I am routing all requests through an entry point
> {{/content/maven.html}} and then serving resources based on the suffix.
> If I a binary file is requested, it should be downloaded ( by forcing the
> extension to be null ), but instead the html extension is used, which means
> the HTML Renderer kicks in.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
