[Jenkins] Sling » sling-org-apache-sling-starter » master #87 is BROKEN
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-starter/job/master/87/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 228 lines...] 09.11.2019 07:50:56.573 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment~sling from resource TaskResource(url=launchpad:resources/config/org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment-sling.config, entity=config:org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment~sling, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:9:225:433:, service.factoryPid=org.apache.sling.jcr.base.internal.LoginAdminWhitelist.fragment, service.pid=sling], digest=4798f118db6cc67a2da762b3a793b179) 09.11.2019 07:50:56.576 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration org.apache.sling.jcr.davex.impl.servlets.SlingDavExServlet from resource TaskResource(url=launchpad:resources/config/org.apache.sling.jcr.davex.impl.servlets.SlingDavExServlet.config, entity=config:org.apache.sling.jcr.davex.impl.servlets.SlingDavExServlet, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:9:225:433:, service.pid=org.apache.sling.jcr.davex.impl.servlets.SlingDavExServlet], digest=b5da891740ad9c266fbc1b28a602dd5d) 09.11.2019 07:50:56.578 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration org.apache.sling.jcr.repoinit.impl.RepositoryInitializer from resource TaskResource(url=launchpad:resources/config/org.apache.sling.jcr.repoinit.impl.RepositoryInitializer.config, entity=config:org.apache.sling.jcr.repoinit.impl.RepositoryInitializer, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:9:225:433:, service.pid=org.apache.sling.jcr.repoinit.impl.RepositoryInitializer], digest=65247ee84a0b61150ac674d7eeccbc89) 09.11.2019 07:50:56.578 *INFO* [CM Event Dispatcher (Fire ConfigurationEvent: pid=org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter~startupandshutdown)] org.apache.felix.hc.core.impl.filter.ServiceUnavailableFilter ServiceUnavailableFilter active (start level 30) 09.11.2019 07:50:56.580 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration org.apache.sling.jcr.webdav.impl.servlets.SimpleWebDavServlet from resource TaskResource(url=launchpad:resources/config/org.apache.sling.jcr.webdav.impl.servlets.SimpleWebDavServlet.config, entity=config:org.apache.sling.jcr.webdav.impl.servlets.SimpleWebDavServlet, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:9:225:433:, service.pid=org.apache.sling.jcr.webdav.impl.servlets.SimpleWebDavServlet], digest=b51abcc7f240ddf1280eadcf45b57140) 09.11.2019 07:50:56.581 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration org.apache.sling.scripting.core.impl.ScriptCacheImpl from resource TaskResource(url=launchpad:resources/config/org.apache.sling.scripting.core.impl.ScriptCacheImpl.config, entity=config:org.apache.sling.scripting.core.impl.ScriptCacheImpl, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:9:225:433:, service.pid=org.apache.sling.scripting.core.impl.ScriptCacheImpl], digest=13b57519a048a6c8873ed61949d013f6) 09.11.2019 07:50:56.584 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended~hc-support from resource TaskResource(url=launchpad:resources/config/org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended-hc-support.config, entity=config:org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended~hc-support, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:9:225:433:, service.factoryPid=org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended, service.pid=hc-support], digest=a098e94679bfbd40a4e39c205bede25b) 09.11.2019 07:50:56.601 *INFO* [OsgiInstallerImpl] org.apache.sling.audit.osgi.installer Installed configuration org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended~sling.discovery from resource TaskResource(url=launchpad:resources/config/org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended-sling.discovery.config, entity=config:org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended~sling.discovery, state=INSTALL, attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:9:225:433:, service.factoryPid=org.apache.sling.serviceusermapping.impl.ServiceUserMapperImpl.amended, service.pid=sling.discovery], digest=49f8c02a6e35568185d429678b3264ee) 09.11.2019 07:50:56.602 *INFO* [OsgiInstallerImpl]
Re: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10
+1 (non-binding) - Andy > On Nov 7, 2019, at 2:01 AM, Carsten Ziegeler wrote: > > Hi, > > We solved 4 issues > > https://issues.apache.org/jira/browse/SLING-8831?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22slingfeature-maven-plugin%201.1.10%22 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2152 > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 2152 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
Sling FM Starter Module
Hi I am wondering how a Sling FM Starter Module would look like and how it is used by clients like Peregrine. It is my assumption that any FM slingosgifeature project will install that file on release on a public Maven repository like all of our Sling Module. Then the Sling FM Starter Module will select the appropriate slingosgifeature files and assemble it into a Sling release slingosgifeature which is then also installed on a public Maven repo. This enables anyone to build the latest Sling instance w/o having any other Sling Module checked out / built like right now it is done in PM based Sling Starter. A customer will then do the same by taking the Sling slingosgifeature file and assembly it with their own project and external projects slingosgifeature files to build the final Sling / Customer instance. Cheers - Andy
[jira] [Resolved] (SLING-8762) Sling CMS - Create Archetype
[ https://issues.apache.org/jira/browse/SLING-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8762. - Resolution: Fixed Fixed on https://github.com/apache/sling-org-apache-sling-app-cms/commit/467816fc4b19aaa5e418b731efc5efc53895e2c8 > Sling CMS - Create Archetype > > > Key: SLING-8762 > URL: https://issues.apache.org/jira/browse/SLING-8762 > Project: Sling > Issue Type: Improvement >Affects Versions: App CMS 0.10.0, App CMS 0.11.0, App CMS 0.11.2, Version > App CMS 0.12.0 >Reporter: Dan Klco >Priority: Minor > Fix For: App CMS 0.12.2 > > > There should be an archetype allowing developers to get started quickly with > the Sling CMS based on the sling-bundle-archetype. This archetype should also > include a code and configuration for a simple webpage / website. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-8762) Sling CMS - Create Archetype
[ https://issues.apache.org/jira/browse/SLING-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco reassigned SLING-8762: --- Assignee: Dan Klco > Sling CMS - Create Archetype > > > Key: SLING-8762 > URL: https://issues.apache.org/jira/browse/SLING-8762 > Project: Sling > Issue Type: Improvement >Affects Versions: App CMS 0.10.0, App CMS 0.11.0, App CMS 0.11.2, Version > App CMS 0.12.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > Fix For: App CMS 0.12.2 > > > There should be an archetype allowing developers to get started quickly with > the Sling CMS based on the sling-bundle-archetype. This archetype should also > include a code and configuration for a simple webpage / website. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8719) CMS - Add Support for Basic Forms
[ https://issues.apache.org/jira/browse/SLING-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8719. - Assignee: Dan Klco Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/9f7d7f3c3bb24a7984c6f9910d68209b53706516] [https://github.com/apache/sling-org-apache-sling-app-cms/commit/6539122b7ad9007d4d9784d6854ede4617f7eea9] https://github.com/apache/sling-org-apache-sling-app-cms/commit/2a8051a62f03d7037f2880adf1dad6ea7b94fd07 > CMS - Add Support for Basic Forms > - > > Key: SLING-8719 > URL: https://issues.apache.org/jira/browse/SLING-8719 > Project: Sling > Issue Type: Improvement > Components: App CMS, App CMS Reference >Affects Versions: Version App CMS 0.12.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 0.12.2 > > > It would be a nice feature to show a basic form framework built in Apache > Sling / Sling CMS. > Included features: > * Extensible actions > * Basic Fields (textarea, textbox, select) > * Extensible model for fields > * Configurable look and feel > * Extensible model for populating data > * Basic security -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8835) CMS - Make Transformations Based on Definitions
Dan Klco created SLING-8835: --- Summary: CMS - Make Transformations Based on Definitions Key: SLING-8835 URL: https://issues.apache.org/jira/browse/SLING-8835 Project: Sling Issue Type: Improvement Affects Versions: Version App CMS 0.12.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 0.12.2 Currently, the transformation library uses the suffix directly to transform the images. This poses a potential issue as users could force the system to create an excessive number of rendered images by providing different variations of the suffix. Instead, the transformations should be provided in configuration and then selected by the author. This will also all for caching rendered images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8836) CMS - Add Grid View
Dan Klco created SLING-8836: --- Summary: CMS - Add Grid View Key: SLING-8836 URL: https://issues.apache.org/jira/browse/SLING-8836 Project: Sling Issue Type: New Feature Affects Versions: Version App CMS 0.12.0 Reporter: Dan Klco Assignee: Dan Klco Fix For: App CMS 0.12.2 Enable a view of the content in Sling CMS viewable as a grid of items instead of a table, using thumbnail images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8836) CMS - Add Grid View
[ https://issues.apache.org/jira/browse/SLING-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8836. - Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-app-cms/commit/38833c0315a62ecce65e1ad61a6c2be14cceb8fe > CMS - Add Grid View > --- > > Key: SLING-8836 > URL: https://issues.apache.org/jira/browse/SLING-8836 > Project: Sling > Issue Type: New Feature >Affects Versions: Version App CMS 0.12.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 0.12.2 > > > Enable a view of the content in Sling CMS viewable as a grid of items instead > of a table, using thumbnail images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8835) CMS - Make Transformations Based on Definitions
[ https://issues.apache.org/jira/browse/SLING-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-8835. - Resolution: Fixed Fixed in [https://github.com/apache/sling-org-apache-sling-app-cms/commit/38833c0315a62ecce65e1ad61a6c2be14cceb8fe] and https://github.com/apache/sling-org-apache-sling-app-cms/commit/0986f22e0247fbad4150ebfbf58dc7c6ced54a95 > CMS - Make Transformations Based on Definitions > --- > > Key: SLING-8835 > URL: https://issues.apache.org/jira/browse/SLING-8835 > Project: Sling > Issue Type: Improvement >Affects Versions: Version App CMS 0.12.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: App CMS 0.12.2 > > > Currently, the transformation library uses the suffix directly to transform > the images. This poses a potential issue as users could force the system to > create an excessive number of rendered images by providing different > variations of the suffix. > Instead, the transformations should be provided in configuration and then > selected by the author. This will also all for caching rendered images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10
+1 On Fri, Nov 8, 2019 at 5:46 AM Nicolas Peltier wrote: > +1 > > Le ven. 8 nov. 2019 à 10:59, Stefan Seifert a > écrit : > > > +1 > > > > >
[GitHub] [sling-org-apache-sling-scripting-esx] HarisAdzemovic commented on a change in pull request #1: Strings and Boxed types should be compared using "equals()"
HarisAdzemovic commented on a change in pull request #1: Strings and Boxed
types should be compared using "equals()"
URL:
https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1#discussion_r344179168
##
File path: src/main/java/org/apache/sling/scripting/esx/Module.java
##
@@ -505,7 +505,7 @@ public ModuleScript loadAsModule(String module, Resource
currentResource, String
for (int i = (parts.length - 1); i > 0;) {
log.debug(parts[i]);
-if (parts[i] == "node_modules" || parts[i] == "esx_modules") {
+if (parts[i].equals("node_modules") ||
parts[i].equals("esx_modules")) {
Review comment:
Sure thing!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()"
HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-551787523 Sorry, you're right that it should probably be changed. I missed one case: ``` Integer a = new Integer(10); Integer b = null; System.out.println(a.equals(b)); --> False System.out.println(b.equals(a)); --> NPE ``` So equals() could "hide" an NPE. Should I change it to compare() or compareTo()? The documentation seems to indicate compare() is for int and compareTo for Integer but perhaps there's a good reason for using compare()? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: [feature] Analyser complains that 'Bundle contains classes in the default package'
Hi it seems you run with all available checks. You should only run api region checks if you use api regions. We recently moved all analysers that use api regions to the regions extension. The other check is done by the analyser for OSGi connect; I can't recall why this check was useful though. Regards Carsten Am 08.11.2019 um 12:50 schrieb Robert Munteanu: Hi, I'm build an application using the feature model tooling. I enabled analysers and got shout at by the 'api-regions-check-order' checker since it required configuration. I don't use API regions, so I disabled that. Then I ran into a problem due to jackson jar having classes in the default package: Bundle contains classes in the default package: Artifact [id=com.fasterxml.jackson.core:jackson-core:2.10.0] I will disable this check as well, but I would like to understand why this is a problem. Thanks, Robert -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()"
HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-551771185 They differ in how they handle null: ``` Integer a = new Integer(10); Integer b = null; a == b; --> False a.equals(b); --> False Integer.compare(a, b); --> NPE a.compareTo(b); --> NPE ``` .equals() mirrors the previous behaviour but you know better than me what's actually preferable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [sling-org-apache-sling-scripting-esx] rombert commented on a change in pull request #1: Strings and Boxed types should be compared using "equals()"
rombert commented on a change in pull request #1: Strings and Boxed types
should be compared using "equals()"
URL:
https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1#discussion_r344144888
##
File path: src/main/java/org/apache/sling/scripting/esx/Module.java
##
@@ -505,7 +505,7 @@ public ModuleScript loadAsModule(String module, Resource
currentResource, String
for (int i = (parts.length - 1); i > 0;) {
log.debug(parts[i]);
-if (parts[i] == "node_modules" || parts[i] == "esx_modules") {
+if (parts[i].equals("node_modules") ||
parts[i].equals("esx_modules")) {
Review comment:
Could you invert the check here so that the constants come first? Slightly
better style and protects against NPEs (although I don't think that's the case
here).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [sling-org-apache-sling-feature] rombert commented on issue #15: Strings and Boxed types should be compared using "equals()"
rombert commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-551677421 @bosschaert , @HarisAdzemovic - shouldn't we use `Integer.compare(o1, o2)` here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[feature] Analyser complains that 'Bundle contains classes in the default package'
Hi, I'm build an application using the feature model tooling. I enabled analysers and got shout at by the 'api-regions-check-order' checker since it required configuration. I don't use API regions, so I disabled that. Then I ran into a problem due to jackson jar having classes in the default package: Bundle contains classes in the default package: Artifact [id=com.fasterxml.jackson.core:jackson-core:2.10.0] I will disable this check as well, but I would like to understand why this is a problem. Thanks, Robert
Re: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10
+1 Le ven. 8 nov. 2019 à 10:59, Stefan Seifert a écrit : > +1 > >
RE: [VOTE] Release Apache Sling Feature Maven Plugin 1.1.10
+1
[jira] [Resolved] (SLING-8834) sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin
[ https://issues.apache.org/jira/browse/SLING-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-8834. --- Resolution: Fixed https://github.com/apache/sling-parent/commit/cef099f9ebf55a23a99b1b297e42a5e620b1df99 > sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin > > > Key: SLING-8834 > URL: https://issues.apache.org/jira/browse/SLING-8834 > Project: Sling > Issue Type: Improvement > Components: General >Affects Versions: Bundle Parent 35 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Bundle Parent 36 > > > the default command line output of the bnd-baseline-maven-plugin is much less > usable than that of the baseline goal in the maven-bundle-plugin, i've also > opened an issue on bnd: > https://github.com/bndtools/bnd/issues/3545 > whatever the outcome of this issue is, for the time being we should enable > the "fullReport" flag which in case of a version validation outputs some more > relevant information which change in the API lead to the validation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-8834) sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin
Stefan Seifert created SLING-8834: - Summary: sling-bundle-parent: Enable fullReport for bnd-baseline-maven-plugin Key: SLING-8834 URL: https://issues.apache.org/jira/browse/SLING-8834 Project: Sling Issue Type: Improvement Components: General Affects Versions: Bundle Parent 35 Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Bundle Parent 36 the default command line output of the bnd-baseline-maven-plugin is much less usable than that of the baseline goal in the maven-bundle-plugin, i've also opened an issue on bnd: https://github.com/bndtools/bnd/issues/3545 whatever the outcome of this issue is, for the time being we should enable the "fullReport" flag which in case of a version validation outputs some more relevant information which change in the API lead to the validation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8743) Move DistributionQueueBuilderFactory class from impl to api surface
[
https://issues.apache.org/jira/browse/SLING-8743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969990#comment-16969990
]
Timothee Maret commented on SLING-8743:
---
IMO it makes sense to expose a cleaned up version of
{{DistributionQueueProviderFactory}} and {{DistributionQueueProvider}}.
[~mohiaror], [~ashishc] does your use case require the
{{DistributionQueueProcessor}} to be exposed ?
> Move DistributionQueueBuilderFactory class from impl to api surface
> ---
>
> Key: SLING-8743
> URL: https://issues.apache.org/jira/browse/SLING-8743
> Project: Sling
> Issue Type: Task
> Components: Content Distribution
>Reporter: Mohit Arora
>Priority: Major
>
> Currently, it is not possible to create an instance of DistributionQueue
> using DitributionQueueBuilderFactory as the factory is inside an impl package
> [0]. This should be exposed as an API so that consumers can get a reference
> of it.
>
> [0][https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/DistributionQueueProviderFactory.java]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
