[VOTE] Release slingfeature maven plugin 1.2.4 and slingstarter maven plugin 1.9.12
Hi, we solved one issue in these releases: https://issues.apache.org/jira/browse/SLING-9362 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2253/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2253 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Comment Edited] (SLING-9389) Distribution Event Packages should contain queue item creation time
[
https://issues.apache.org/jira/browse/SLING-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093799#comment-17093799
]
Harsh Chiki edited comment on SLING-9389 at 4/30/20, 4:59 AM:
--
Hi [~marett],
Please consider this a gentle reminder.
I worked out some basic changes to capture the queue item creation time, to be
put in the {{AGENT_PACKAGE_DISTRIBUTED}} and {{AGENT_PACKAGE_DROPPED}}. From
other paths, have sent out null. PFA SCD API and Core patches which of course
are very rough at the moment.
May I request your views, in general from this requirement pov, essentially:
* Whether we should add a new parameter in this internal API and internal
implementation, or a new method to capture time stamp as well. (Prior one is
done in the patch shared)
* Is it fine to send null in the other event topic cases?
* For scheduled import export cases.
* In our local experiments, we identified the queue item creation time stamp
is what one would need from an enqueue (first time creation, not on retries)
time stamp pov, so we intend to use
[https://github.com/apache/sling-org-apache-sling-distribution-core/blob/429f6bc225970c34e948d0ad41c38fe4c0ef9ef9/src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueueUtils.java#L219]
** Figured that
[https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/QueueingDistributionPackageProcessor.java#L119]
which is later used for getting {{globalStartTime}} here -
[https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L115.|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L115]
** But, relied on the queue item creation time - generated in
`ResourceQueueUtils` linked above (in this comment)
FTR, the event thrown looks like (with the attached patches) - the newly added
`distribution.enqueue.timestamp`
!image-2020-04-30-10-28-58-011.png!
Kindly have a look, and advise.
Thanks!
\cc: [~ashishc], [~shgu...@adobe.com]
was (Author: harshchiki):
Hi [~marett],
Please consider this a gentle reminder.
I worked out some basic changes to capture the queue item creation time, to be
put in the {{AGENT_PACKAGE_DISTRIBUTED}} and {{AGENT_PACKAGE_DROPPED}}. From
other paths, have sent out null. PFA SCD API and Core patches which of course
are very rough at the moment.
May I request your views, in general from this requirement pov, essentially:
* Whether we should add a new parameter in this internal API and internal
implementation, or a new method to capture time stamp as well. (Prior one is
done in the patch shared)
* Is it fine to send null in the other event topic cases?
* For scheduled import export cases.
* In our local experiments, we identified the queue item creation time stamp
is what one would need from an enqueue (first time creation, not on retries)
time stamp pov, so we intend to use
[https://github.com/apache/sling-org-apache-sling-distribution-core/blob/429f6bc225970c34e948d0ad41c38fe4c0ef9ef9/src/main/java/org/apache/sling/distribution/queue/impl/resource/ResourceQueueUtils.java#L219]
** Figured that
[https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/QueueingDistributionPackageProcessor.java#L119]
which is later used for getting {{globalStartTime}} here -
[https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L115.|https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L115]
** But, relied on the queue item creation time - generated in
`ResourceQueueUtils` linked above (in this comment)
Kindly have a look, and advise.
Thanks!
\cc: [~ashishc], [~shgu...@adobe.com]
> Distribution Event Packages should contain queue item creation time
> ---
>
> Key: SLING-9389
> URL: https://issues.apache.org/jira/browse/SLING-9389
> Project: Sling
> Issue Type: Improvement
> Components: Content Distribution
>Reporter: Harsh Chiki
>Assignee: Timothee Maret
>Priority: Major
> Attachments: image-2020-04-30-10-28-58-011.png, scdapi.patch,
> scdcore.patch
>
>
> Currently the Dsitribution Event package contains the following details:
> * Distribution Component N
[jira] [Closed] (SLING-9258) Provide features to consumer when reading feature archive
[ https://issues.apache.org/jira/browse/SLING-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9258. --- > Provide features to consumer when reading feature archive > - > > Key: SLING-9258 > URL: https://issues.apache.org/jira/browse/SLING-9258 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.0 > > > When extracting a feature archive, currently only the binaries are provided > to the consumer. We should include the features to avoid unnecessary special > casing of features when for example the archive is extracted into a maven > repository -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9361) Merge feature and feature.io modules
[ https://issues.apache.org/jira/browse/SLING-9361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9361. --- > Merge feature and feature.io modules > > > Key: SLING-9361 > URL: https://issues.apache.org/jira/browse/SLING-9361 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.0 > > > As discussed in the mailing list, we should merge the two modules feature and > feature.io. From the initial mail: > We have two bundles which make up the feature model, o.a.s.feature and > o.a.s.feature.io - while the first one contains the model, the second one > contains reading/writing models in JSON. > I initially kept them separate to leave it open whether we will use JSON as > the serialization format and also to keep the feature model itself free from > any additional dependencies. I think by now we have settled on the format and > the model now depends on JSON api as well for some features like the > extensions. > I think this separation is today more artifically and does not provide any > value. So I would prefer of merging the IO stuff into the feature model and > retire feature io as a separate git repository. > (package names would of course stay the same) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9263) Allow feature ids and urls in manifest header
[ https://issues.apache.org/jira/browse/SLING-9263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9263. --- > Allow feature ids and urls in manifest header > - > > Key: SLING-9263 > URL: https://issues.apache.org/jira/browse/SLING-9263 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.0 > > > We should support artifact ids as well as artifact urls in the manifest > header of a feature archive; both formats are supported everywhere else. > Right now only ids are supported -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9362) Use Apache Felix cm.json for JSON handling
[ https://issues.apache.org/jira/browse/SLING-9362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9362. --- > Use Apache Felix cm.json for JSON handling > -- > > Key: SLING-9362 > URL: https://issues.apache.org/jira/browse/SLING-9362 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Installer, Maven Plugins and Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.0, Installer Core 3.11.4, > slingfeature-maven-plugin 1.2.4, Slingstart Maven Plugin 1.9.12 > > > With https://github.com/apache/felix-dev/tree/master/cm.json we have a > reusable module to handle json configuration resources - so far we are > relying half on internal implementations from the Apache Felix Configurator > and half self implemented methods. > By switching to the new module, we get a stable contract and do not need to > implement anything ourselves anymore. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9261) Do not compress feature archive at all
[ https://issues.apache.org/jira/browse/SLING-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9261. --- > Do not compress feature archive at all > -- > > Key: SLING-9261 > URL: https://issues.apache.org/jira/browse/SLING-9261 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.0 > > > Right now, the features are compressed but binaries are not. However in order > to mount a feature archive as a repository no file should be compressed -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9262) Add prototype feature to feature archive
[ https://issues.apache.org/jira/browse/SLING-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9262. --- > Add prototype feature to feature archive > > > Key: SLING-9262 > URL: https://issues.apache.org/jira/browse/SLING-9262 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.0 > > > When a feature archive is created and the features are using prototypes, the > prototypes are currently not included in the archive -- This message was sent by Atlassian Jira (v8.3.4#803005)
[VOTE RESULT] Release Apache Sling Feature Model 1.2.0
The vote passes with 5 binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: Launching a Feature Archive Project?
Hi, there is currently no way, but I asked/proposed the same a month ago [1] :) We should definitely add support for feature archives to the launcher. I can probably have a look at it in the next days. Regards Carsten [1] https://lists.apache.org/thread.html/re04888b1621292117502226ee27ecb6576fa0ff460c5de759b29af3d%40%3Cdev.sling.apache.org%3E On 30.04.2020 01:25, Andreas Schaefer wrote: Hi Is there a way to launch a Feature Archive with the Feature Launcher? I created a Feature Archive but that is part of my local Maven repo with a Manifest file pointing to the starting FM. - Do we have a way to start / launch such a FA? - If not do we want to add support for that to the Feature Launcher module? Cheers - Andy -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling Testing JCR Mock 1.4.6, Testing OSGi Mock 2.4.16, Testing Sling Mock 2.5.0, Testing Sling Mock Oak 2.1.10-1.16.0
+1 Carsten On 30.04.2020 05:04, Daniel Klco wrote: +1 On Wed, Apr 29, 2020 at 8:21 AM wrote: +1 David On Wed, 29 Apr 2020 at 13:07, Stefan Seifert wrote: Hi, Testing JCR Mock 1.4.6 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12345058 Testing OSGi Mock 2.4.16 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12346888 Testing Sling Mock 2.5.0 (4 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12346889 Testing Sling Mock Oak 2.1.10-1.16.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12346286 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2250/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2250 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling Installer Factory Feature Model 0.2.0
+1 On Wed, Apr 29, 2020 at 12:44 PM Carsten Ziegeler wrote: > +1 > > Carsten > > On 29.04.2020 18:21, Carsten Ziegeler wrote: > > Hi, > > > > this is the first release of feature model support for the OSGi > > installer (second attempt) > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2252/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > > > Usage: > > sh check_staged_release.sh 2252 /tmp/sling-staging > > > > Please vote to approve this release: > > > >[ ] +1 Approve the release > >[ ] 0 Don't care > >[ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards > > Carsten > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > cziege...@apache.org > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Testing JCR Mock 1.4.6, Testing OSGi Mock 2.4.16, Testing Sling Mock 2.5.0, Testing Sling Mock Oak 2.1.10-1.16.0
+1 On Wed, Apr 29, 2020 at 8:21 AM wrote: > +1 > > David > > On Wed, 29 Apr 2020 at 13:07, Stefan Seifert > wrote: > > > Hi, > > > > Testing JCR Mock 1.4.6 (2 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12345058 > > > > Testing OSGi Mock 2.4.16 (2 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12346888 > > > > Testing Sling Mock 2.5.0 (4 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12346889 > > > > Testing Sling Mock Oak 2.1.10-1.16.0 (2 issues) > > https://issues.apache.org/jira/browse/SLING/fixforversion/12346286 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2250/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2250 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > stefan > > > > >
Re: [VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.0
+1 On Wed, Apr 29, 2020 at 4:29 AM Carsten Ziegeler wrote: > Thanks for reporting, I fixed the test case on master now > > Regards > Carsten > > On 29.04.2020 10:23, Stefan Seifert wrote: > > +1 > > > > please note that the unit tests fail on windows (but complete on linux) > - but this is not a release blocker: > > > > > --- > > Test set: org.apache.sling.feature.apiregions.impl.ActivatorTest > > > --- > > Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.652 s > <<< FAILURE! - in org.apache.sling.feature.apiregions.impl.ActivatorTest > > testStart(org.apache.sling.feature.apiregions.impl.ActivatorTest) Time > elapsed: 0.017 s <<< ERROR! > > java.lang.NullPointerException > > at > org.apache.sling.feature.apiregions.impl.ActivatorTest.testStart(ActivatorTest.java:99) > > > > > > > > stefan > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
Launching a Feature Archive Project?
Hi Is there a way to launch a Feature Archive with the Feature Launcher? I created a Feature Archive but that is part of my local Maven repo with a Manifest file pointing to the starting FM. - Do we have a way to start / launch such a FA? - If not do we want to add support for that to the Feature Launcher module? Cheers - Andy
Ianal Maven Plugin?
Hi I just stumbled over an issue with Ianal Maven Plugin and when I wanted to see what it is looking for I discovered that the project does not exist anymore nor does a documentation page. The plugin was released 2008 as alpha and nothing since. Shouldn’t we stop using that plugin or find / create a replacement for it? Cheers - Andy
[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #10: SLING-9406: Add bundled script support to the servlets resolver
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10#issuecomment-621430646 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=CODE_SMELL) [19 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&metric=new_coverage&view=list) [14.6% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=10&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-jsp] karlpauls commented on pull request #5: SLING-9406: Add bundled script support to the servlets resolver
karlpauls commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/5#issuecomment-621430192 @raducotescu PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-jsp] karlpauls opened a new pull request #5: SLING-9406: Add bundled script support to the servlets resolver
karlpauls opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] karlpauls commented on pull request #7: SLING-9406: Add bundled script support to the servlets resolver
karlpauls commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/7#issuecomment-621429913 @raducotescu PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly] karlpauls opened a new pull request #7: SLING-9406: Add bundled script support to the servlets resolver
karlpauls opened a new pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] karlpauls opened a new pull request #10: SLING-9406: Add bundled script support to the servlets resolver
karlpauls opened a new pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-servlets-resolver] karlpauls commented on pull request #10: SLING-9406: Add bundled script support to the servlets resolver
karlpauls commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/10#issuecomment-621428970 @raducotescu PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] karlpauls commented on pull request #4: SLING-9406: Add bundled script support to the servlets resolver
karlpauls commented on pull request #4: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/4#issuecomment-621429090 @raducotescu PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-core] karlpauls opened a new pull request #4: SLING-9406: Add bundled script support to the servlets resolver
karlpauls opened a new pull request #4: URL: https://github.com/apache/sling-org-apache-sling-scripting-core/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-9409) Sling Dynamic Include: Not Returning include tags
[ https://issues.apache.org/jira/browse/SLING-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Singaiah Chintalapudi updated SLING-9409: - Description: We've been using SDI (Version: 3.0.0) on our servers. This is not working as expected. Sometimes, SDI is not returning the include tags in the response (can't find the include tags on the cached version at the dispatcher). This is an intermittent issue. We are currently on AEM 6.2 CFP15. Please note that some components have TTL while others does not have any TTL (nocache) on same page. We've tried to upgrade the SDI version to: 3.1.6 but still this issue exits intermittently. This is happening on our prod servers. was: We've been using SDI (Version: 3.0.0) on our servers. This is not working as expected. Sometimes, SDI is not returning the include tags in the response. This is an intermittent issue. We are currently on AEM 6.2 CFP15. Please note that some components have TTL while others does not have any TTL (nocache) on same page. We've tried to upgrade the SDI version to: 3.1.6 but still this issue exits intermittently. This is happening on our prod servers. > Sling Dynamic Include: Not Returning include tags > - > > Key: SLING-9409 > URL: https://issues.apache.org/jira/browse/SLING-9409 > Project: Sling > Issue Type: Bug >Affects Versions: Dynamic Include 3.0.0, Dynamic Include 3.1.6 > Environment: PRODUCTION >Reporter: Singaiah Chintalapudi >Priority: Major > Labels: None > > We've been using SDI (Version: 3.0.0) on our servers. This is not working as > expected. Sometimes, SDI is not returning the include tags in the response > (can't find the include tags on the cached version at the dispatcher). This > is an intermittent issue. We are currently on AEM 6.2 CFP15. Please note that > some components have TTL while others does not have any TTL (nocache) on same > page. > > We've tried to upgrade the SDI version to: 3.1.6 but still this issue exits > intermittently. This is happening on our prod servers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9409) Sling Dynamic Include: Not Returning include tags
Singaiah Chintalapudi created SLING-9409: Summary: Sling Dynamic Include: Not Returning include tags Key: SLING-9409 URL: https://issues.apache.org/jira/browse/SLING-9409 Project: Sling Issue Type: Bug Affects Versions: Dynamic Include 3.1.6, Dynamic Include 3.0.0 Environment: PRODUCTION Reporter: Singaiah Chintalapudi We've been using SDI (Version: 3.0.0) on our servers. This is not working as expected. Sometimes, SDI is not returning the include tags in the response. This is an intermittent issue. We are currently on AEM 6.2 CFP15. Please note that some components have TTL while others does not have any TTL (nocache) on same page. We've tried to upgrade the SDI version to: 3.1.6 but still this issue exits intermittently. This is happening on our prod servers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Installer Factory Feature Model 0.2.0
+1 Carsten On 29.04.2020 18:21, Carsten Ziegeler wrote: Hi, this is the first release of feature model support for the OSGi installer (second attempt) Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2252/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2252 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Updated] (SLING-9397) SAML2 Authentication Handler [initial submission]
[
https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cris Rockwell updated SLING-9397:
-
Description:
Here is a pull request which adds an authentication handler for a SAML2 Service
Provider via the embedded OpenSAML V3 dependencies
[https://github.com/apache/sling-whiteboard/pull/51]
*TODO Before Initial*
[X] Sync attributes released by the IDP
[X] Confirm license and attribution
"As the code is ASL2 and does not require a notice or anything else, we don't
need to mention in. But I think its usually good style to do so and have a
single sentence in our NOTICE that we include (modified) code from ... which
has ASL2 as the license"
[ ] Get confirmation the project builds and operates as expected
*TODO After Initial*
[ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects
* [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
[ ] Consider whether use of {{SAML2ConfigService}} and
{{SAML2ConfigServiceImpl}} is a good design or not.
[ ] Get feedback whether README instructions are too much, too little, unclear,
etc
[ ] Decide whether to make signing and encryption optional. Currently it is
required
[ ] Find and fix any bugs
was:
Here is a pull request which adds an authentication handler for a SAML2 Service
Provider via the embedded OpenSAML V3 dependencies
[https://github.com/apache/sling-whiteboard/pull/51]
TODO:
[X] Sync attributes released by the IDP
[ ] Confirm license and attribution
[ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects
[https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
[ ] Consider whether use of {{SAML2ConfigService}} and
{{SAML2ConfigServiceImpl}} is a good design or not.
[ ] Get feedback whether README instructions are too much, too little, unclear,
etc
[ ] Get confirmation the project builds and operates as expected
[ ] Decide whether to make signing and encryption optional. Currently it is
required
[ ] Find and fix any bugs
> SAML2 Authentication Handler [initial submission]
> -
>
> Key: SLING-9397
> URL: https://issues.apache.org/jira/browse/SLING-9397
> Project: Sling
> Issue Type: New Feature
> Components: Authentication
> Environment: localhost
>Reporter: Cris Rockwell
>Priority: Major
> Labels: SAML, authentification, security, user_management
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Here is a pull request which adds an authentication handler for a SAML2
> Service Provider via the embedded OpenSAML V3 dependencies
> [https://github.com/apache/sling-whiteboard/pull/51]
>
> *TODO Before Initial*
> [X] Sync attributes released by the IDP
> [X] Confirm license and attribution
> "As the code is ASL2 and does not require a notice or anything else, we don't
> need to mention in. But I think its usually good style to do so and have a
> single sentence in our NOTICE that we include (modified) code from ... which
> has ASL2 as the license"
> [ ] Get confirmation the project builds and operates as expected
>
> *TODO After Initial*
> [ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects
> * [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
> [ ] Consider whether use of {{SAML2ConfigService}} and
> {{SAML2ConfigServiceImpl}} is a good design or not.
> [ ] Get feedback whether README instructions are too much, too little,
> unclear, etc
> [ ] Decide whether to make signing and encryption optional. Currently it is
> required
> [ ] Find and fix any bugs
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9408) java.lang.IllegalArgumentException: Argument is not an array on ConfigUtil.isSameData(...)
[
https://issues.apache.org/jira/browse/SLING-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-9408.
Resolution: Fixed
Merged in
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/commit/1b62c1a5e15ef1ce5222dc3a0af73cd9cf7bb57a.
> java.lang.IllegalArgumentException: Argument is not an array on
> ConfigUtil.isSameData(...)
> --
>
> Key: SLING-9408
> URL: https://issues.apache.org/jira/browse/SLING-9408
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Configuration Factory 1.3.2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The following exception is thrown in case the existing dictionary key is an
> array and the new one is no longer one:
> {code}
> 29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
> Exception during installation of config
> TaskResource(url=jcrinstall:/apps/.../config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
> entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:14209:,
> service.pid=com.adobe.acs.commons.util.impl.BundleDisabler],
> digest=3be32a646ef1ae9cc98f482c41486730) : Argument is not an array
> java.lang.IllegalArgumentException: Argument is not an array
> at java.lang.reflect.Array.getLength(Native Method)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.convertToObjectArray(ConfigUtil.java:83)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.isSameData(ConfigUtil.java:103)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:68)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
> [org.apache.sling.installer.core:3.9.0]
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [VOTE] Release Apache Sling Installer Factory Feature Model 0.2.0
+1 David On Wed, 29 Apr 2020 at 17:21, Carsten Ziegeler wrote: > Hi, > > this is the first release of feature model support for the OSGi > installer (second attempt) > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2252/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2252 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
[GitHub] [sling-org-apache-sling-installer-factory-configuration] sonarcloud[bot] commented on pull request #5: SLING-9408 do not throw IAE in case old value is array and new value is
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/5#issuecomment-621326221 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-installer-factory-configuration&pullRequest=5&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9408) java.lang.IllegalArgumentException: Argument is not an array on ConfigUtil.isSameData(...)
[
https://issues.apache.org/jira/browse/SLING-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095602#comment-17095602
]
Konrad Windszus commented on SLING-9408:
PR in
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/5.
> java.lang.IllegalArgumentException: Argument is not an array on
> ConfigUtil.isSameData(...)
> --
>
> Key: SLING-9408
> URL: https://issues.apache.org/jira/browse/SLING-9408
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Configuration Factory 1.3.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following exception is thrown in case the existing dictionary key is an
> array and the new one is no longer one:
> {code}
> 29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
> Exception during installation of config
> TaskResource(url=jcrinstall:/apps/.../config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
> entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:14209:,
> service.pid=com.adobe.acs.commons.util.impl.BundleDisabler],
> digest=3be32a646ef1ae9cc98f482c41486730) : Argument is not an array
> java.lang.IllegalArgumentException: Argument is not an array
> at java.lang.reflect.Array.getLength(Native Method)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.convertToObjectArray(ConfigUtil.java:83)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.isSameData(ConfigUtil.java:103)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:68)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
> [org.apache.sling.installer.core:3.9.0]
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-9408) java.lang.IllegalArgumentException: Argument is not an array on ConfigUtil.isSameData(...)
[
https://issues.apache.org/jira/browse/SLING-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-9408:
--
Assignee: Konrad Windszus
> java.lang.IllegalArgumentException: Argument is not an array on
> ConfigUtil.isSameData(...)
> --
>
> Key: SLING-9408
> URL: https://issues.apache.org/jira/browse/SLING-9408
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.4
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Installer Configuration Factory 1.3.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following exception is thrown in case the existing dictionary key is an
> array and the new one is no longer one:
> {code}
> 29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
> Exception during installation of config
> TaskResource(url=jcrinstall:/apps/.../config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
> entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:14209:,
> service.pid=com.adobe.acs.commons.util.impl.BundleDisabler],
> digest=3be32a646ef1ae9cc98f482c41486730) : Argument is not an array
> java.lang.IllegalArgumentException: Argument is not an array
> at java.lang.reflect.Array.getLength(Native Method)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.convertToObjectArray(ConfigUtil.java:83)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.isSameData(ConfigUtil.java:103)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:68)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
> [org.apache.sling.installer.core:3.9.0]
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9408) java.lang.IllegalArgumentException: Argument is not an array on ConfigUtil.isSameData(...)
[
https://issues.apache.org/jira/browse/SLING-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-9408:
---
Fix Version/s: Installer Configuration Factory 1.3.2
> java.lang.IllegalArgumentException: Argument is not an array on
> ConfigUtil.isSameData(...)
> --
>
> Key: SLING-9408
> URL: https://issues.apache.org/jira/browse/SLING-9408
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.4
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Installer Configuration Factory 1.3.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The following exception is thrown in case the existing dictionary key is an
> array and the new one is no longer one:
> {code}
> 29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
> Exception during installation of config
> TaskResource(url=jcrinstall:/apps/.../config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
> entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
> attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:14209:,
> service.pid=com.adobe.acs.commons.util.impl.BundleDisabler],
> digest=3be32a646ef1ae9cc98f482c41486730) : Argument is not an array
> java.lang.IllegalArgumentException: Argument is not an array
> at java.lang.reflect.Array.getLength(Native Method)
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.convertToObjectArray(ConfigUtil.java:83)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigUtil.isSameData(ConfigUtil.java:103)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:68)
> [org.apache.sling.installer.factory.configuration:1.2.4]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
> [org.apache.sling.installer.core:3.9.0]
> at
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
> [org.apache.sling.installer.core:3.9.0]
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-installer-factory-configuration] kwin opened a new pull request #5: SLING-9408 do not throw IAE in case old value is array and new value is
kwin opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/5 not This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SLING-9408) java.lang.IllegalArgumentException: Argument is not an array on ConfigUtil.isSameData(...)
Konrad Windszus created SLING-9408:
--
Summary: java.lang.IllegalArgumentException: Argument is not an
array on ConfigUtil.isSameData(...)
Key: SLING-9408
URL: https://issues.apache.org/jira/browse/SLING-9408
Project: Sling
Issue Type: Bug
Components: Installer
Affects Versions: Installer Configuration Factory 1.2.4
Reporter: Konrad Windszus
The following exception is thrown in case the existing dictionary key is an
array and the new one is no longer one:
{code}
29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
Exception during installation of config
TaskResource(url=jcrinstall:/apps/bruker/sysconfig/config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:14209:,
service.pid=com.adobe.acs.commons.util.impl.BundleDisabler],
digest=3be32a646ef1ae9cc98f482c41486730) : Argument is not an array
java.lang.IllegalArgumentException: Argument is not an array
at java.lang.reflect.Array.getLength(Native Method)
at
org.apache.sling.installer.factories.configuration.impl.ConfigUtil.convertToObjectArray(ConfigUtil.java:83)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.factories.configuration.impl.ConfigUtil.isSameData(ConfigUtil.java:103)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:68)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
[org.apache.sling.installer.core:3.9.0]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
[org.apache.sling.installer.core:3.9.0]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
[org.apache.sling.installer.core:3.9.0]
at java.lang.Thread.run(Thread.java:748)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-9408) java.lang.IllegalArgumentException: Argument is not an array on ConfigUtil.isSameData(...)
[
https://issues.apache.org/jira/browse/SLING-9408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-9408:
---
Description:
The following exception is thrown in case the existing dictionary key is an
array and the new one is no longer one:
{code}
29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
Exception during installation of config
TaskResource(url=jcrinstall:/apps/.../config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:14209:,
service.pid=com.adobe.acs.commons.util.impl.BundleDisabler],
digest=3be32a646ef1ae9cc98f482c41486730) : Argument is not an array
java.lang.IllegalArgumentException: Argument is not an array
at java.lang.reflect.Array.getLength(Native Method)
at
org.apache.sling.installer.factories.configuration.impl.ConfigUtil.convertToObjectArray(ConfigUtil.java:83)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.factories.configuration.impl.ConfigUtil.isSameData(ConfigUtil.java:103)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:68)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
[org.apache.sling.installer.core:3.9.0]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
[org.apache.sling.installer.core:3.9.0]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
[org.apache.sling.installer.core:3.9.0]
at java.lang.Thread.run(Thread.java:748)
{code}
was:
The following exception is thrown in case the existing dictionary key is an
array and the new one is no longer one:
{code}
29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
Exception during installation of config
TaskResource(url=jcrinstall:/apps/bruker/sysconfig/config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
attributes=[org.apache.sling.installer.api.tasks.ResourceTransformer=:14209:,
service.pid=com.adobe.acs.commons.util.impl.BundleDisabler],
digest=3be32a646ef1ae9cc98f482c41486730) : Argument is not an array
java.lang.IllegalArgumentException: Argument is not an array
at java.lang.reflect.Array.getLength(Native Method)
at
org.apache.sling.installer.factories.configuration.impl.ConfigUtil.convertToObjectArray(ConfigUtil.java:83)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.factories.configuration.impl.ConfigUtil.isSameData(ConfigUtil.java:103)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.execute(ConfigInstallTask.java:68)
[org.apache.sling.installer.factory.configuration:1.2.4]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.doExecuteTasks(OsgiInstallerImpl.java:914)
[org.apache.sling.installer.core:3.9.0]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.executeTasks(OsgiInstallerImpl.java:749)
[org.apache.sling.installer.core:3.9.0]
at
org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:298)
[org.apache.sling.installer.core:3.9.0]
at java.lang.Thread.run(Thread.java:748)
{code}
> java.lang.IllegalArgumentException: Argument is not an array on
> ConfigUtil.isSameData(...)
> --
>
> Key: SLING-9408
> URL: https://issues.apache.org/jira/browse/SLING-9408
> Project: Sling
> Issue Type: Bug
> Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.4
>Reporter: Konrad Windszus
>Priority: Major
>
> The following exception is thrown in case the existing dictionary key is an
> array and the new one is no longer one:
> {code}
> 29.04.2020 18:16:44.939 *ERROR* [OsgiInstallerImpl]
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask
> Exception during installation of config
> TaskResource(url=jcrinstall:/apps/.../config.netcentric.author/com.adobe.acs.commons.util.impl.BundleDisabler.config,
> entity=config:com.adobe.acs.commons.util.impl.BundleDisabler, state=INSTALL,
> attributes=[org.apache.sling.installer.api.tasks
[VOTE] Release Apache Sling Installer Factory Feature Model 0.2.0
Hi, this is the first release of feature model support for the OSGi installer (second attempt) Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2252/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2252 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling Installer Core 3.11.4
+1 On Wed, Apr 29, 2020 at 4:26 AM Stefan Seifert wrote: > +1 > >
[VOTE CANCELLED] Release Apache Sling Installer Factory Feature Model 0.1.0
I hereby cancel the vote as there seems to be a bug in the region handling :( Regards Carsten On 29.04.2020 13:56, Carsten Ziegeler wrote: Hi, this is the first release of feature model support for the OSGi installer Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2251/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2251 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Move slingpackager to its own repo
+1 On Wed, Apr 29, 2020 at 4:12 AM Carsten Ziegeler wrote: > +1 > > Carsten > > On 29.04.2020 09:39, Robert Munteanu wrote: > > Hi, > > > > I'd like to propose that we move sling-packager [1] from the whiteboard > > to its own repository. > > > > The project has seen continued contributions and it would be good to > > make a first ASF release and upload it to NPM. > > > > Proposed repository name: sling-slingpackager. See [2] for discussion. > > > > This majority vote is open for at least 72 hours. > > > > Thanks, > > Robert > > > > [1]: > https://github.com/apache/sling-whiteboard/tree/master/slingpackager > > [2]: > https://lists.apache.org/thread.html/rb155d3627f7a50aead641aefc8727c9fe82f5d889d4b749e46d1%40%3Cdev.sling.apache.org%3E > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
Re: [VOTE] Release Apache Sling Testing JCR Mock 1.4.6, Testing OSGi Mock 2.4.16, Testing Sling Mock 2.5.0, Testing Sling Mock Oak 2.1.10-1.16.0
+1 David On Wed, 29 Apr 2020 at 13:07, Stefan Seifert wrote: > Hi, > > Testing JCR Mock 1.4.6 (2 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12345058 > > Testing OSGi Mock 2.4.16 (2 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12346888 > > Testing Sling Mock 2.5.0 (4 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12346889 > > Testing Sling Mock Oak 2.1.10-1.16.0 (2 issues) > https://issues.apache.org/jira/browse/SLING/fixforversion/12346286 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2250/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2250 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > stefan > >
Re: [VOTE] Release Apache Sling Installer Factory Feature Model 0.1.0
+1 David On Wed, 29 Apr 2020 at 12:56, Carsten Ziegeler wrote: > Hi, > > this is the first release of feature model support for the OSGi installer > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2251/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2251 /tmp/sling-staging > > Please vote to approve this release: > >[ ] +1 Approve the release >[ ] 0 Don't care >[ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
RE: [VOTE] Release Apache Sling Installer Factory Feature Model 0.1.0
+1
RE: [VOTE] Release Apache Sling Testing JCR Mock 1.4.6, Testing OSGi Mock 2.4.16, Testing Sling Mock 2.5.0, Testing Sling Mock Oak 2.1.10-1.16.0
+1
[VOTE] Release Apache Sling Testing JCR Mock 1.4.6, Testing OSGi Mock 2.4.16, Testing Sling Mock 2.5.0, Testing Sling Mock Oak 2.1.10-1.16.0
Hi, Testing JCR Mock 1.4.6 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12345058 Testing OSGi Mock 2.4.16 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12346888 Testing Sling Mock 2.5.0 (4 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12346889 Testing Sling Mock Oak 2.1.10-1.16.0 (2 issues) https://issues.apache.org/jira/browse/SLING/fixforversion/12346286 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2250/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2250 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. stefan
[VOTE] Release Apache Sling Installer Factory Feature Model 0.1.0
Hi, this is the first release of feature model support for the OSGi installer Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2251/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2251 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Updated] (SLING-8820) sling-mock-oak: Upgrade to parent pom 38
[ https://issues.apache.org/jira/browse/SLING-8820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-8820: -- Summary: sling-mock-oak: Upgrade to parent pom 38 (was: sling-mock-oak: Upgrade to parent pom 35) > sling-mock-oak: Upgrade to parent pom 38 > > > Key: SLING-8820 > URL: https://issues.apache.org/jira/browse/SLING-8820 > Project: Sling > Issue Type: Sub-task > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Testing Sling Mock Oak 2.1.10-1.16.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8822) jcr-mock: Upgrade to parent pom 38
[ https://issues.apache.org/jira/browse/SLING-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert updated SLING-8822: -- Summary: jcr-mock: Upgrade to parent pom 38 (was: jcr-mock: Upgrade to parent pom 35) > jcr-mock: Upgrade to parent pom 38 > -- > > Key: SLING-8822 > URL: https://issues.apache.org/jira/browse/SLING-8822 > Project: Sling > Issue Type: Sub-task > Components: Testing >Affects Versions: Testing JCR Mock 1.4.4 >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Minor > Fix For: Testing JCR Mock 1.4.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-7284) Extend OsgiServiceUtil#invokeBindUnbindMethod to support more DS 1.3+ method signatures
[
https://issues.apache.org/jira/browse/SLING-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-7284:
--
Fix Version/s: (was: Testing OSGi Mock 2.4.16)
> Extend OsgiServiceUtil#invokeBindUnbindMethod to support more DS 1.3+ method
> signatures
> ---
>
> Key: SLING-7284
> URL: https://issues.apache.org/jira/browse/SLING-7284
> Project: Sling
> Issue Type: Improvement
> Components: Testing
>Affects Versions: Testing OSGi Mock 1.0.0
>Reporter: Radu Cotescu
>Priority: Major
>
> The
> {{org.apache.sling.testing.mock.osgi.OsgiServiceUtil#invokeBindUnbindMethod}}
> should be extended to support more DS 1.3+ method signatures.
> For more details check
> https://github.com/apache/felix/blob/a4755e768329a29252b1d7d8e52537941768606d/scr/src/main/java/org/apache/felix/scr/impl/inject/BindMethod.java#L86.
> The complete DS 1.4 spec related to this can be found at
> https://osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-method.injection.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9405) sling-mock-oak: Support ResourceChangeListeners
[ https://issues.apache.org/jira/browse/SLING-9405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095310#comment-17095310 ] Stefan Seifert commented on SLING-9405: --- yes, i've planned a new release for this week anyway > sling-mock-oak: Support ResourceChangeListeners > --- > > Key: SLING-9405 > URL: https://issues.apache.org/jira/browse/SLING-9405 > Project: Sling > Issue Type: Improvement > Components: Testing >Affects Versions: Testing Sling Mock Oak 2.1.8-1.16.0 >Reporter: Dirk Rudolph >Priority: Major > Fix For: Testing Sling Mock Oak 2.1.10-1.16.0 > > > It would be great when the mock oak would support ResourceChangeListeners to > support for example test cases around implementations using Sling Jobs (or > anything else that depends on ResourceChangeListeners). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9407) sling-mock: Add mock for ResourceBundleProvider and ResourceBundle (i18n)
[
https://issues.apache.org/jira/browse/SLING-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095304#comment-17095304
]
Stefan Seifert commented on SLING-9407:
---
default locale is Locale.US - but it's possibel to set you own default locale:
{code:java}
MockResourceBundleProvider bundleProvider =
(MockResourceBundleProvider)context.getService(ResourceBundleProvider.class);
bundleProvider.setDefaultLocale(Locale.KOREA);
{code}
it's also possible to add you own translations (in this case for the default
locale):
{code:java}
ResourceBundle bundle = context.request().getResourceBundle(null);
((MockResourceBundle)bundle).put("key1", "value1");
{code}
> sling-mock: Add mock for ResourceBundleProvider and ResourceBundle (i18n)
> -
>
> Key: SLING-9407
> URL: https://issues.apache.org/jira/browse/SLING-9407
> Project: Sling
> Issue Type: New Feature
> Components: Testing
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing Sling Mock 2.5.0
>
>
> currently there is no built-in support for i18n, it's required to implement
> an own mock of ResourceBundleProvider. we need a default implementation that
> returns the keys as values, but allows to add your own mappings if needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9407) sling-mock: Add mock for ResourceBundleProvider and ResourceBundle (i18n)
[ https://issues.apache.org/jira/browse/SLING-9407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Seifert resolved SLING-9407. --- Resolution: Fixed https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/461ac0e0373d0741467d0329c10e29fb2d242464 > sling-mock: Add mock for ResourceBundleProvider and ResourceBundle (i18n) > - > > Key: SLING-9407 > URL: https://issues.apache.org/jira/browse/SLING-9407 > Project: Sling > Issue Type: New Feature > Components: Testing >Reporter: Stefan Seifert >Assignee: Stefan Seifert >Priority: Major > Fix For: Testing Sling Mock 2.5.0 > > > currently there is no built-in support for i18n, it's required to implement > an own mock of ResourceBundleProvider. we need a default implementation that > returns the keys as values, but allows to add your own mappings if needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9407) sling-mock: Add mock for ResourceBundleProvider and ResourceBundle (i18n)
Stefan Seifert created SLING-9407: - Summary: sling-mock: Add mock for ResourceBundleProvider and ResourceBundle (i18n) Key: SLING-9407 URL: https://issues.apache.org/jira/browse/SLING-9407 Project: Sling Issue Type: New Feature Components: Testing Reporter: Stefan Seifert Assignee: Stefan Seifert Fix For: Testing Sling Mock 2.4.2 currently there is no built-in support for i18n, it's required to implement an own mock of ResourceBundleProvider. we need a default implementation that returns the keys as values, but allows to add your own mappings if needed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Move OSGi Installer Support for feature models to its own git repository
Thanks everyone, I have requested creating the git repository Regards Carsten On 28.04.2020 13:28, Carsten Ziegeler wrote: Hi in the whiteboard we have support for feathre models and archives for the OSGi installer. With this additional bundle, features can be installed through the OSGi installer. I would like to call a vote to move this out of the whiteboard and into its own git repository. Please cast your votes Thanks Carsten [1] https://github.com/apache/sling-whiteboard/tree/master/org.apache.sling.installer.factory.feature -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation
[ https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095285#comment-17095285 ] Carsten Ziegeler commented on SLING-8946: - SLING-9040 indicates there are failing tests with this, can we resolve these to unblock a resource resolver release? > Non-deterministic shadowing of resource observation > --- > > Key: SLING-8946 > URL: https://issues.apache.org/jira/browse/SLING-8946 > Project: Sling > Issue Type: Bug > Components: ResourceResolver >Affects Versions: Resource Resolver 1.5.34 >Reporter: Dirk Rudolph >Assignee: Robert Munteanu >Priority: Critical > Fix For: Resource Resolver 1.6.18 > > Attachments: PerformanceScript.sh > > Time Spent: 1.5h > Remaining Estimate: 0h > > The BasicObservationReporter implements shadowing of events being propagated > per ResourceProvider instance [1]. Assuming we do have 2 ResourceProviders > registered, where the one shadows the other like this: > - RP A registered on / > - RP B registered on /path > then currently the excludes given to the BasicObservationReporter are > different depending on either RP A or RP B gets registered first: > - RP A before RP B => excludes are empty > - RP B before RP A => excludes contain /path > This is because only the newly registered RP gets its ProviderContext updated > [2] > Same applies if RP B is registered before RP A and gets unregistered. In that > case the ObservationReporter of RP A stays untouched. > [1] > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L102] > [2] > [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTracker.java#L358] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9365) Optionally don't create resource providers for servlets
[ https://issues.apache.org/jira/browse/SLING-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095265#comment-17095265 ] Julian Sedding commented on SLING-9365: --- Glad that worked out. Cool! [~karlpauls] Do you have any performance data on this? > Optionally don't create resource providers for servlets > --- > > Key: SLING-9365 > URL: https://issues.apache.org/jira/browse/SLING-9365 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Servlets Resolver 2.6.4 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Servlets Resolver 2.6.6 > > Time Spent: 1h > Remaining Estimate: 0h > > The current ServletMounter creates a resource provider for each registered > servlet. That works fine for a given amount of servlets but can become > problematic for a high number of servlets as it means that on the one hand, > the number of services is doubled and on the other hand, a lot of > notifications are send out as well as a lot of computation has to be done by > the resource resolver. > As an optional remedy for these kinds of scenarios, we should allow to > configure the mounter to not provide resource providers for servlets but only > decorate resources into the content tree. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9406) Add bundled script support to the servlets resolver
Karl Pauls created SLING-9406: - Summary: Add bundled script support to the servlets resolver Key: SLING-9406 URL: https://issues.apache.org/jira/browse/SLING-9406 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Servlets Resolver 2.6.4 Reporter: Karl Pauls Assignee: Karl Pauls Fix For: Servlets Resolver 2.6.6 With the unification work for bundled scripts in SLING-9207 we can now provide scripts via bundles. Currently, that involves the bundled script tracker bundle that uses the provided meta-data of bundles providing scripts to publish servlets for the scripts. As the only reason for these servlets is to be picked-up by the resolver it makes sense to skip the intermediate step to avoid having to publish all the servlets as services. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9365) Optionally don't create resource providers for servlets
[ https://issues.apache.org/jira/browse/SLING-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-9365. --- Resolution: Fixed Thanks [~jsedding], the decorator turned out the to be the missing part of the puzzle. We can now not mount resource providers if we set servletresolver_mountProviders to false and it will decorate them back into the tree. > Optionally don't create resource providers for servlets > --- > > Key: SLING-9365 > URL: https://issues.apache.org/jira/browse/SLING-9365 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Servlets Resolver 2.6.4 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Servlets Resolver 2.6.6 > > Time Spent: 1h > Remaining Estimate: 0h > > The current ServletMounter creates a resource provider for each registered > servlet. That works fine for a given amount of servlets but can become > problematic for a high number of servlets as it means that on the one hand, > the number of services is doubled and on the other hand, a lot of > notifications are send out as well as a lot of computation has to be done by > the resource resolver. > As an optional remedy for these kinds of scenarios, we should allow to > configure the mounter to not provide resource providers for servlets but only > decorate resources into the content tree. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9365) Optionally don't create resource providers for servlets
[ https://issues.apache.org/jira/browse/SLING-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-9365: -- Description: The current ServletMounter creates a resource provider for each registered servlet. That works fine for a given amount of servlets but can become problematic for a high number of servlets as it means that on the one hand, the number of services is doubled and on the other hand, a lot of notifications are send out as well as a lot of computation has to be done by the resource resolver. As an optional remedy for these kinds of scenarios, we should allow to configure the mounter to not provide resource providers for servlets but only decorate resources into the content tree. was: The current ServletMounter creates a resource provider for each registered servlet. That works fine for a given amount of servlets but can become problematic for a high number of servlets as it means that on the one hand, the number of services is doubled and on the other hand, a lot of notifications are send out as well as a lot of computation has to be done by the resource resolver. As an optional remedy for these kinds of scenarios, we should allow to configure the mounter to instead provide a single resource provider that has manages the servlets internally. > Optionally don't create resource providers for servlets > --- > > Key: SLING-9365 > URL: https://issues.apache.org/jira/browse/SLING-9365 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Servlets Resolver 2.6.4 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Servlets Resolver 2.6.6 > > Time Spent: 1h > Remaining Estimate: 0h > > The current ServletMounter creates a resource provider for each registered > servlet. That works fine for a given amount of servlets but can become > problematic for a high number of servlets as it means that on the one hand, > the number of services is doubled and on the other hand, a lot of > notifications are send out as well as a lot of computation has to be done by > the resource resolver. > As an optional remedy for these kinds of scenarios, we should allow to > configure the mounter to not provide resource providers for servlets but only > decorate resources into the content tree. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9365) Optionally don't create resource providers for servlets
[ https://issues.apache.org/jira/browse/SLING-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-9365: -- Summary: Optionally don't create resource providers for servlets (was: Optimize servlet to resource provider servlet mounter) > Optionally don't create resource providers for servlets > --- > > Key: SLING-9365 > URL: https://issues.apache.org/jira/browse/SLING-9365 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Servlets Resolver 2.6.4 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Servlets Resolver 2.6.6 > > Time Spent: 1h > Remaining Estimate: 0h > > The current ServletMounter creates a resource provider for each registered > servlet. That works fine for a given amount of servlets but can become > problematic for a high number of servlets as it means that on the one hand, > the number of services is doubled and on the other hand, a lot of > notifications are send out as well as a lot of computation has to be done by > the resource resolver. > As an optional remedy for these kinds of scenarios, we should allow to > configure the mounter to instead provide a single resource provider that has > manages the servlets internally. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.0
Thanks for reporting, I fixed the test case on master now Regards Carsten On 29.04.2020 10:23, Stefan Seifert wrote: +1 please note that the unit tests fail on windows (but complete on linux) - but this is not a release blocker: --- Test set: org.apache.sling.feature.apiregions.impl.ActivatorTest --- Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.652 s <<< FAILURE! - in org.apache.sling.feature.apiregions.impl.ActivatorTest testStart(org.apache.sling.feature.apiregions.impl.ActivatorTest) Time elapsed: 0.017 s <<< ERROR! java.lang.NullPointerException at org.apache.sling.feature.apiregions.impl.ActivatorTest.testStart(ActivatorTest.java:99) stefan -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
RE: [VOTE] Release Apache Sling Feature Model 1.2.0
+1
RE: [VOTE] Release Apache Sling Installer Core 3.11.4
+1
RE: [VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.0
+1 please note that the unit tests fail on windows (but complete on linux) - but this is not a release blocker: --- Test set: org.apache.sling.feature.apiregions.impl.ActivatorTest --- Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.652 s <<< FAILURE! - in org.apache.sling.feature.apiregions.impl.ActivatorTest testStart(org.apache.sling.feature.apiregions.impl.ActivatorTest) Time elapsed: 0.017 s <<< ERROR! java.lang.NullPointerException at org.apache.sling.feature.apiregions.impl.ActivatorTest.testStart(ActivatorTest.java:99) stefan
[jira] [Closed] (SLING-8999) Improve Sling filter handling
[ https://issues.apache.org/jira/browse/SLING-8999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-8999. --- > Improve Sling filter handling > - > > Key: SLING-8999 > URL: https://issues.apache.org/jira/browse/SLING-8999 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > > The engine is currently listening for all servlet filters and then filters > them out by hand (if a property is set). This can already be done by the > service tracker. > In addition, we can optimize the handling of a modified service registration > by not blindly unregistering and reregistering things > And finally we should use the bundle context of the filter service to > register the mbean -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8991) Avoid recreation of main servlet on config change
[ https://issues.apache.org/jira/browse/SLING-8991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-8991. --- > Avoid recreation of main servlet on config change > - > > Key: SLING-8991 > URL: https://issues.apache.org/jira/browse/SLING-8991 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > > If the main servlet is reconfigured, it is deactivated and then activated > again with the new configuration. This creates unnecessary churn in the > system as this affects a couple of services beeing re-registered. > We can avoid this and handle the reconfiguration within the implementation -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9002) Improve service registrations
[ https://issues.apache.org/jira/browse/SLING-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9002. --- > Improve service registrations > - > > Key: SLING-9002 > URL: https://issues.apache.org/jira/browse/SLING-9002 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > > We should use the new R7 annotations like ServiceDescription etc for our > components. > In addition, we could register the web console plugin by DS instead of by hand -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9388) Add new properties for filtering based on resource and request path
[ https://issues.apache.org/jira/browse/SLING-9388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9388. --- > Add new properties for filtering based on resource and request path > --- > > Key: SLING-9388 > URL: https://issues.apache.org/jira/browse/SLING-9388 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > > As discussed in SLING-9378, we should add two new properties for filters, to > explicitely state whether the match should happen against the resource or the > request path -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9378) When internalRedirect and sling:match maps are added, filterPattern doesn't work
[ https://issues.apache.org/jira/browse/SLING-9378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9378. --- > When internalRedirect and sling:match maps are added, filterPattern doesn't > work > > > Key: SLING-9378 > URL: https://issues.apache.org/jira/browse/SLING-9378 > Project: Sling > Issue Type: Bug >Affects Versions: Engine 2.6.16, Engine 2.6.18 >Reporter: Ankita Agarwal >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > > ***sling.filter.pattern=/abcd/.** doesn't work after a map is added with > internalRedirect and sling:match. This is a issue due to > [SLING-7759|https://issues.apache.org/jira/browse/SLING-7759] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9398) Context might get unregistered on modification
[ https://issues.apache.org/jira/browse/SLING-9398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9398. --- > Context might get unregistered on modification > -- > > Key: SLING-9398 > URL: https://issues.apache.org/jira/browse/SLING-9398 > Project: Sling > Issue Type: Bug > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Blocker > Fix For: Engine 2.7.2 > > > When the configuration of the main servlet gets modified, the context might > get unregistered. This is due to a wrong logic of handling the > modified/destroy methods -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8992) Sling main servlet name is not set after move to http whiteboard
[ https://issues.apache.org/jira/browse/SLING-8992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-8992. --- > Sling main servlet name is not set after move to http whiteboard > > > Key: SLING-8992 > URL: https://issues.apache.org/jira/browse/SLING-8992 > Project: Sling > Issue Type: Bug > Components: Engine >Affects Versions: Engine 2.6.22 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > > With the move the http whiteboard, the property name for the servlet name has > not been updated and therefore the name is not picked up by the whiteboard -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-8993) Remove old deprecation warning
[ https://issues.apache.org/jira/browse/SLING-8993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-8993. --- > Remove old deprecation warning > -- > > Key: SLING-8993 > URL: https://issues.apache.org/jira/browse/SLING-8993 > Project: Sling > Issue Type: Improvement > Components: Engine >Affects Versions: Engine 2.6.22 >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > > For over five years now, the sling engine prints out a warning about the > usage of the configuration property "sling.default.parameter.encoding". This > really should be enough for everyone to update their configurations. > Therefore we should remove this warning now -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9006) Remove contention on sling request listener manager
[ https://issues.apache.org/jira/browse/SLING-9006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-9006. --- > Remove contention on sling request listener manager > --- > > Key: SLING-9006 > URL: https://issues.apache.org/jira/browse/SLING-9006 > Project: Sling > Issue Type: Improvement > Components: Engine >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Engine 2.7.2 > > > The RequestListenerManager is currently using service tracker to get the list > of request listeners. service tracker is using a synchronized block to get > all the listeners. This creates unnecessary contention during request > processing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[VOTE RESULT] Release Apache Sling Engine 2.7.2
The vote passes with three binding +1 votes Thanks Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Move slingpackager to its own repo
+1 Carsten On 29.04.2020 09:39, Robert Munteanu wrote: Hi, I'd like to propose that we move sling-packager [1] from the whiteboard to its own repository. The project has seen continued contributions and it would be good to make a first ASF release and upload it to NPM. Proposed repository name: sling-slingpackager. See [2] for discussion. This majority vote is open for at least 72 hours. Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/tree/master/slingpackager [2]: https://lists.apache.org/thread.html/rb155d3627f7a50aead641aefc8727c9fe82f5d889d4b749e46d1%40%3Cdev.sling.apache.org%3E -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Sling Feature Model API Regions Runtime Fragment 1.1.0
On Tue, 2020-04-28 at 09:36 +0100, dav...@apache.org wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
[VOTE] Move slingpackager to its own repo
Hi, I'd like to propose that we move sling-packager [1] from the whiteboard to its own repository. The project has seen continued contributions and it would be good to make a first ASF release and upload it to NPM. Proposed repository name: sling-slingpackager. See [2] for discussion. This majority vote is open for at least 72 hours. Thanks, Robert [1]: https://github.com/apache/sling-whiteboard/tree/master/slingpackager [2]: https://lists.apache.org/thread.html/rb155d3627f7a50aead641aefc8727c9fe82f5d889d4b749e46d1%40%3Cdev.sling.apache.org%3E
Re: slingpackager in it's own git repo
On Tue, 2020-04-28 at 07:27 -0700, Henry Saginor wrote: > +1 for /apache/sling-slingpackager Ack, I'll start a vote with this proposed name. Thanks, Robert > > > On Apr 28, 2020, at 5:26 AM, Ruben Reusser wrote: > > > > I think the problem with the naming of the packager has to be > > looked at from the npmjs registry [1] > > Ideally we use a similar name for the repo as we would use for > > publishing to npm and how we would like people to use it from the > > command line. > > > > sling-packager is unfortunately already taken and seems to be part > > of a sling in node implementation [2]. > > > > Installation would happen through the command > > > > > npm install *@apache-sling/slingpackager* --global > > > > and one would use the command with > > > > > *slingpackager* --help > > > > while github.com/*apache/sling-slingpackager* has a repetition of > > sling in the name it would map nicely to npm and the command line > > execution of the tool. If we use github.com/apache/sling-packager > > we run the risk that people will try to use the sling-packager > > module that already exists at [3] > > > > [1] https://www.npmjs.com/ > > [2] https://www.npmjs.com/package/sling-server > > [3] https://www.npmjs.com/package/sling-packager > > > > On 4/27/2020 9:37 AM, Henry Saginor wrote: > > > I like js in the name because it lets me know it's not a Java > > > project. Most > > > Sling projects are java and maven. So, repo naming is derived > > > from maven > > > artifact id and "java" does not need to be advertised. I am not > > > sure about > > > cli. I imagine exposing slingpackage operations as API so it can > > > be used by > > > other tools as a library as well. > > > > > > On Mon, Apr 27, 2020 at 1:35 AM Robert Munteanu < > > > romb...@apache.org> wrote: > > > > > > > On Fri, 2020-04-24 at 11:39 -0700, Henry Saginor wrote: > > > > > I am happy to put up the repository name to a vote. Here are > > > > > the > > > > > choices > > > > > and reasoning as I see it.. > > > > > 1) github.com/apache/sling-slingpackager - short and > > > > > filterable by > > > > > sling- > > > > > as project > > > > > 2) github.com/apache/sling-js-slingpackager - the same as 1) > > > > > but > > > > > includes > > > > > js to id it as a js project > > > > > 3) github.com/apache/apache-sling-js-slingpackager - maps to > > > > > npm org. > > > > > I > > > > > think this is better for compliance. But I am not sure. > > > > > 4) github.com/apache/sling-apache-sling-js-slingpackager - > > > > > also maps > > > > > to npm > > > > > org but starts with sling- to follow sling project > > > > > conventions. > > > > Well, first - ASF Infra requires that we start the repo name > > > > with > > > > 'sling-'. > > > > > > > > Personally, I think any repetition of 'sling' and 'apache' is > > > > confusing, so I would go with either 'sling-packager' or > > > > 'sling-js- > > > > packager'. > > > > > > > > I am not sure whether we need the 'js' part, since we don't > > > > advertise > > > > 'java' for our packages ... Maybe include 'cli' somewhere, > > > > since it's a > > > > CLI tool and would make it clear what the scope is? Just > > > > throwing out > > > > ideas... > > > > > > > > > Also, can we move it to a new repo 1st and then figure out > > > > > npm > > > > > release? > > > > +1 > > > > > > > > Thanks, > > > > Robert > > > > > > > >
Re: [VOTE] Move OSGi Installer Support for feature models to its own git repository
On Tue, 2020-04-28 at 13:28 +0200, Carsten Ziegeler wrote: > Please cast your votes +1 Thanks, Robert
[jira] [Commented] (SLING-9040) High resource consumption when activating/deactivating ResourceProviders
[
https://issues.apache.org/jira/browse/SLING-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095143#comment-17095143
]
Carsten Ziegeler commented on SLING-9040:
-
[~sonagupt] SLING-9365 will be fixed soon
[~diru] So I think we can probably close SLING-9077 (due to SLING-9365) and
then continue the discussion on SLING-8946 what needs to be done there.
Thanks
> High resource consumption when activating/deactivating ResourceProviders
>
>
> Key: SLING-9040
> URL: https://issues.apache.org/jira/browse/SLING-9040
> Project: Sling
> Issue Type: Bug
> Components: ResourceResolver
>Reporter: Dirk Rudolph
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: Resource Resolver 1.6.18
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> With SLING-8946 the updating of all ResourceProviders when their exclude path
> set changes was introduced to prevent non-deterministic behaviour of resource
> observation.
> This change though caused calling {{updateProviderContext()}} and
> {{ResourceProviderHandler#update()}} on every registered
> {{ResourceProviderHandler}} when a new ResourceProvider was
> activated/deactivated no matter if the paths actually intersect.
> This is quite resource consuming (processing time and memory) and should be
> reduced to update only those handlers that actually intersect with the
> handler added/removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
