Re: Feature Launcher Mojo supports Feature Archives now
Thanks Andy, nice! But could you please create a jira issue mentioning the change? Thanks Carsten On 12.05.2020 19:11, Andreas Schaefer wrote: Hi Just a heads up. I added support for the Feature Launcher Goal inside the Slingfeature Maven Plugin. A FAR can be loaded through its classifier (if part of the Maven project) or can be accessed through its Artifact Id if available in the local Maven repo. Cheers - Andy -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Create repository for the content-package-archetype
+1 Carsten On 12.05.2020 23:45, Robert Munteanu wrote: Hi, I'd like to 'promote' the content-package-archetype [1] to a Sling module. This archetype creates a minimal content package that is deployable on the Sling Starter. The template README [2] contains a few more details about the setup. It is usable as-is and it supports the content-package based development theme for Sling 12. [3] This majority vote is open for at least 72 hours. Thanks, Robert [1]: https://github.com/rombert/content-package-archetype/ [2]: https://github.com/rombert/content-package-archetype/tree/master/src/main/resources/archetype-resources [3]: https://issues.apache.org/jira/browse/SLING-6950 -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-9389) Distribution Event Packages should contain queue item creation time
[ https://issues.apache.org/jira/browse/SLING-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105844#comment-17105844 ] Harsh Chiki commented on SLING-9389: [~marett], Gentle reminder. Kindly review the PRs and share your feedback. Thanks! \cc: [~shgu...@adobe.com], [~ashishc] > Distribution Event Packages should contain queue item creation time > --- > > Key: SLING-9389 > URL: https://issues.apache.org/jira/browse/SLING-9389 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Harsh Chiki >Assignee: Timothee Maret >Priority: Major > Attachments: image-2020-04-30-10-28-58-011.png, scdapi.patch, > scdcore.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Currently the Distribution Event package contains the following details: > * Distribution Component Name > * Distribution Component Kind > * Distribution Type > * Distribution Paths > > Improvement aims at adding the queue item creation time, essentially when the > the item was creation for the first time, and enqueue into the queue. The > value does not change over retries (on failure). > > The purpose to get this detail is to be able to capture metrics at the > consumer level. The consumers could have an event handler, which can capture > the duration which turns out to be (NOW MINUS queue item creation time thrown > in the distribution event package); NOW being the current time in the event > handler (consumer). > > \cc: [~shgu...@adobe.com], [~ashishc] -- This message was sent by Atlassian Jira (v8.3.4#803005)
collect-sling-repos.groovy generating empty repository list?
Hi, I can't seem to get collect-sling-repos.groovy [1] to generate a repo list, I always get back I tried with Groovy Version: 2.4.16 JVM: 11.0.7 Vendor: Oracle Corporation OS: Linux Groovy Version: 2.4.16 JVM: 1.8.0_252 Vendor: IcedTea OS: Linux Groovy Version: 3.0.3 JVM: 11.0.7 Vendor: Oracle Corporation OS: Linux Groovy Version: 3.0.3 JVM: 1.8.0_252 Vendor: IcedTea OS: Linux Does the script work for anyone? (Though I must confess with JEP 330 [2] landing in Java 11 I'd be tempted to just rewrite it in Java) Thanks, Robert [1]: https://github.com/apache/sling-aggregator/blob/master/collect-sling-repos.groovy [2]: https://openjdk.java.net/jeps/330
Re: [VOTE] Create repository for the content-package-archetype
On Tue, 2020-05-12 at 23:45 +0200, Robert Munteanu wrote: > I'd like to 'promote' the content-package-archetype [1] to a Sling > module. +1 Robert signature.asc Description: This is a digitally signed message part
[VOTE] Create repository for the content-package-archetype
Hi, I'd like to 'promote' the content-package-archetype [1] to a Sling module. This archetype creates a minimal content package that is deployable on the Sling Starter. The template README [2] contains a few more details about the setup. It is usable as-is and it supports the content-package based development theme for Sling 12. [3] This majority vote is open for at least 72 hours. Thanks, Robert [1]: https://github.com/rombert/content-package-archetype/ [2]: https://github.com/rombert/content-package-archetype/tree/master/src/main/resources/archetype-resources [3]: https://issues.apache.org/jira/browse/SLING-6950
Feature Launcher Mojo supports Feature Archives now
Hi Just a heads up. I added support for the Feature Launcher Goal inside the Slingfeature Maven Plugin. A FAR can be loaded through its classifier (if part of the Maven project) or can be accessed through its Artifact Id if available in the local Maven repo. Cheers - Andy
Re: [discuss] Migrating the Sling Starter to the Feature Model
On Mon, 2020-05-11 at 14:34 -0700, Andreas Schaefer wrote: > Yes, that sums it up pretty much. Great! > > Also the Kickstart is replacing Launchpad more than the SlingStarter > as the PMs go to the wayside in favor of the FMs that are then > managed outside of the Kickstart. Ack, fully agree on that. > > With that said the testing of Sling FM should be done in a new module > (Kickstart Testing?) than re-using Launchpad Testing but that seems > to be pretty straight forward as we can use Kickstart Plugin and the > converted Sling FM. Not sure about that. The direction we're heading towards is that Launchpad testing should be going away and the test launcher folded in the starter. The reasoning is that integration tests in the same module have a much higher chance of catching regressions early. But then again I think we should keep this out of scope and focus on the conversion itself [1]. > > For me the basics on how to convert Sling to FMs from PMs and how to > launch it is pretty much laid out. The next part is: > > - Create native Sling Module FMs > - Aggregate them into a Sling FM / FAR > - Adjust testing > - Write documentation > - Composite Nodestore +1 from me. Also the composite nodestore is a great feature to have set up. I would still like to focus on the feature model first, and then on the niceties :-) Regarding the feasibility of using the feature model tooling directly, I was able to tweak your great work from the kickstart and add an 'on- the-fly' conversion to the Sling Starter, so that the oak_tar aggregate is packaged. [2] Proof-of-concept to support the discussion, not necessarily the way we will go, so it's on a branch for now. Thanks, Robert [1]: https://cwiki.apache.org/confluence/display/SLING/Migrating+the+Sling+Starter+to+the+Feature+Model#MigratingtheSlingStartertotheFeatureModel-Outofscope [2]: https://github.com/apache/sling-org-apache-sling-starter/compare/feature/create-feature-aggregate?expand=1 > > - Andy > > > On May 11, 2020, at 2:07 PM, Robert Munteanu > > wrote: > > > > On Mon, 2020-05-11 at 13:43 -0700, Andreas Schaefer wrote: > > > Hi Robert > > > > > > I think there is a misconception what the Kickstart is. Here is > > > my > > > rundown: > > > > > > - Provides a Sling FM > > > - Creates a Control Thread > > > - Offers Sling specific CLI options and converts them to Sling > > > properties > > > - Launches Sling through the Feature Launcher > > > - Provides the ability to access Sling running in another thread > > > > > > Because of the current situation it also does that: > > > > > > - Provides a mean to convert Sling PMs to FMs > > > - Aggregates these FMs > > > > Ack. > > > > > That said this is just temporary and should go away as soon as > > > Sling > > > is Feature Model-yfied. > > > > > > I am not sure how Sling is used in production environments > > > (beside > > > Peregrine) but I assume customers use Sling Start one way the > > > other > > > even if they create their own PM(s) to launch it with the Starter > > > (Peregrine does that). > > > The Kickstart can take a custom Sling FM (override the packaged > > > one) > > > as well as custom project FM(s). > > > > > > As a user I do not want to hunt down the properties on how to > > > launch > > > Sling but rather have an option in a Start (here Kickstart). > > > Instead of “-Dsling.port=8080” something like “-p 8080” would be > > > better especially because the Kickstart expose these options with > > > the > > > “—help”” option. > > > > > > The Kickstart project does not compete or shadow any of the > > > feature > > > tooling but rather leverages them. In addition support for > > > Composite > > > Nodestores is something the Feature Launcher cannot do and would > > > require scripts to run which are harder to manage for an admin. > > > > Right. > > > > I get the feeling that I am missing something, as I think we write > > the > > same things but don't necessarily agree :-) > > > > Let me try and rephrase my draft proposal in a very compact manner, > > let's see where the difference lie. > > > > 1. The feature model provides tooling for assembling and validating > > feature model files. > > > > 2. Kickstart is a convenient, featureful high-level launcher, and > > some > > (most?) users will like to use that for starting Sling. > > > > 3. The feature model launcher is a pure OSGi launcher for users > > that > > either desire to not be tied to the kickstart or do not have an use > > for > > the additional features of the kickstart. > > > > Does that match how you see things? If not, I'd love to understand > > where things don't align. > > > > Thanks, > > Robert > > > Cheers - Andy > > > > > > > On May 11, 2020, at 1:05 PM, Robert Munteanu < > > > > romb...@apache.org> > > > > wrote: > > > > > > > > Hi Andy, > > > > > > > > On Mon, 2020-05-11 at 09:50 -0700, Andreas Schaefer wrote: > > > > > Hi Robert > > > > > > > > > > Thanks for the nice rundown here but I think it is
[jira] [Created] (SLING-9441) Sling POST servlet responds with 500 if target is not modifiable
Lars Krapf created SLING-9441:
-
Summary: Sling POST servlet responds with 500 if target is not
modifiable
Key: SLING-9441
URL: https://issues.apache.org/jira/browse/SLING-9441
Project: Sling
Issue Type: Bug
Components: Servlets
Affects Versions: Servlets Post 2.3.36
Reporter: Lars Krapf
In case a POST is attempted to a node that the request session does not have
write access to, the POST servlets throws a 500, e.g.
{code}
04.05.2020 21:34:09.162 *ERROR* [xxx.xxx.xxx.xxx [1588628049158] POST
/content/cmo/us/en/home/users/geometrixx/james.dev...@spambob.com/fSPiyhliJm
HTTP/1.1] org.apache.sling.servlets.post.impl.operations.ModifyOperation
Exception during response processing.
org.apache.sling.api.resource.PersistenceException: Unable to create node at
/content/cmo/us/en/home/users
at
org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:477)
[org.apache.sling.jcr.resource:3.0.20]
{code}
Since this is actually a client error I think a 4xx response would be better
suited, and make it more obvious that such errors can be safely ignored when
doing health monitoring.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [VOTE][CANCELLED]Release Apache Sling Testing Clients version 1.2.8 and Apache Sling Testing Rules version 1.0.10
Hi Robert. Yeah, sorry about that. I must've forgotten. I'll drop them in a bit. -Andrei On Tue, 12 May 2020 at 11:16, Robert Munteanu wrote: > Hi Andrei, > > Should the staging repositories in Nexus also be dropped? I just > noticed them. > > Thanks, > Robert > >
[jira] [Resolved] (SLING-9406) Add bundled script support to the servlets resolver
[ https://issues.apache.org/jira/browse/SLING-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-9406. --- Fix Version/s: Scripting Core 2.2.2 Scripting HTL Engine 1.4.0-1.4.0 Scripting JSP 2.5.0 Resolution: Fixed > Add bundled script support to the servlets resolver > --- > > Key: SLING-9406 > URL: https://issues.apache.org/jira/browse/SLING-9406 > Project: Sling > Issue Type: Improvement > Components: Scripting >Affects Versions: Servlets Resolver 2.6.4 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Scripting JSP 2.5.0, Scripting HTL Engine 1.4.0-1.4.0, > Servlets Resolver 2.6.6, Scripting Core 2.2.2 > > Time Spent: 4h > Remaining Estimate: 0h > > With the unification work for bundled scripts in SLING-9207 we can now > provide scripts via bundles. Currently, that involves the bundled script > tracker bundle that uses the provided meta-data of bundles providing scripts > to publish servlets for the scripts. As the only reason for these servlets is > to be picked-up by the resolver it makes sense to skip the intermediate step > to avoid having to publish all the servlets as services. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE][CANCELLED]Release Apache Sling Testing Clients version 1.2.8 and Apache Sling Testing Rules version 1.0.10
Hi Andrei, Should the staging repositories in Nexus also be dropped? I just noticed them. Thanks, Robert
[RESULT] [VOTE] Release Apache Sling Archetype Parent 6
Hi, The vote has passed with the following result: +1 (binding): Robert Munteanu, Dan Klco, A. J. David Bosschaert +1 (non-binding): Andreas Schaefer I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
[jira] [Closed] (SLING-9428) Update plugins and dependency versions for Sling 12
[ https://issues.apache.org/jira/browse/SLING-9428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-9428. -- > Update plugins and dependency versions for Sling 12 > --- > > Key: SLING-9428 > URL: https://issues.apache.org/jira/browse/SLING-9428 > Project: Sling > Issue Type: Improvement > Components: Maven Plugins and Archetypes >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Archetype Parent 6 > > > For Sling 12 we should do a quick refresh of the plug-ins and dependencies we > are using in the generated archetypes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Archetype Parent 6
+1 David On Mon, 11 May 2020 at 08:15, Robert Munteanu wrote: > We would need one more binding vote here. > > Thanks, > Robert > > On Thu, 2020-05-07 at 21:38 +, Robert Munteanu wrote: > > Hi, > > > > We solved 1 issue in this release: > > https://issues.apache.org/jira/browse/SLING/fixforversion/12342716 > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2259/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2259 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Regards, > > Robert Munteanu > >
[jira] [Resolved] (SLING-9440) Clean up usage of constants
[ https://issues.apache.org/jira/browse/SLING-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-9440. Resolution: Fixed Fixed with https://github.com/apache/sling-org-apache-sling-jcr-resource/commit/2073970411f8de2691a9f3d06c57c2c5bcfcaae1. > Clean up usage of constants > --- > > Key: SLING-9440 > URL: https://issues.apache.org/jira/browse/SLING-9440 > Project: Sling > Issue Type: Improvement > Components: JCR >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Minor > Fix For: JCR Resource 3.0.22 > > > There are a lot of constants being referenced from Jackrabbit. To make it > clearer which parts are Jackrabbit-specific the constants from the JCR 2.0 > namespace should be prefered (also they don't refer on any prefixes as they > always use fully-qualified names). -- This message was sent by Atlassian Jira (v8.3.4#803005)
