Sling Feature Launcher Extensions with FM?
Hi This might be overkill but I was wondering that if the list of extensions gets longer that handing them over to the launcher might be a longer list or it might be hard to manage. I was wondering if it would make sense to use a Feature Model to define them and then the Feature Launcher would load them into its class loader because the target FM is actually loaded. Cheers - Andy
Re: [VOTE] Release Apache Sling Project Archetype version 1.0.4
+1 On Wed, May 13, 2020 at 4:56 PM Andreas Schaefer wrote: > Two more PM reviews needed for this release. > > Thanks - Andy > > > On May 10, 2020, at 2:09 PM, Andreas Schaefer > wrote: > > > > Hi, > > > > This is a maintenance update for the Project Archetype to work with > Sling 12. > > > > We solved 1 issue in this release: > > https://issues.apache.org/jira/projects/SLING/versions/12348258 > > > > There are no outstanding issues: > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachesling-2264 > > > > You can use this UNIX script to download the release and verify the > signatures: > > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > > > Usage: > > sh check_staged_release.sh 2264 /tmp/sling-staging > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] 0 Don't care > > [ ] -1 Don't release, because ... > > > > This majority vote is open for at least 72 hours. > > > > Cheers - Andy > > > >
Re: [VOTE]: Release Apache Sling Kickstart Project 0.0.2 and Apache Sling Kickstart Maven Plugin 0.0.2
One more PM review needed for this release. Thanks - Andy > On May 7, 2020, at 5:37 PM, Andreas Schaefer wrote: > > Hi, > > This is the initial release of the Sling Kickstart Project and the Sling > Kickstart Maven Plugin which is used in the former to run the IT Smoke test. > The release is a working release (version 0.0.2) as there are issues outside > of the control of these modules like the availability of a Sling 12/13 FM etc. > Releasing it now should help to get more people to have a look into the > Feature Model and to test is features. > > We solved 1 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12342716 > https://issues.apache.org/jira/projects/SLING/versions/12348245 > > There are still no outstanding issues: > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2260 > > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2260 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Cheers - Andreas Schaefer
Re: [VOTE] Release Apache Sling Project Archetype version 1.0.4
Two more PM reviews needed for this release. Thanks - Andy > On May 10, 2020, at 2:09 PM, Andreas Schaefer > wrote: > > Hi, > > This is a maintenance update for the Project Archetype to work with Sling 12. > > We solved 1 issue in this release: > https://issues.apache.org/jira/projects/SLING/versions/12348258 > > There are no outstanding issues: > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2264 > > You can use this UNIX script to download the release and verify the > signatures: > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh 2264 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Cheers - Andy >
Feature Launcher: Setting Log File and Log Level during Startup
Hi I tried to set the log level and log file while launching Sling with the Feature Launcher. I tried setting properties: -Dorg.apache.sling.commons.log.file=test.log -Dorg.apache.sling.commons.log.level=DEBUG Still it does not take it even though with the Sling Launcher it works. Is there a way to overwrite properties in a Feature Model configurations? - Andy
Re: Feature Launcher Mojo supports Feature Archives now
Done (SLING-9450) > On May 12, 2020, at 10:25 PM, Carsten Ziegeler wrote: > > Thanks Andy, nice! > > But could you please create a jira issue mentioning the change? > > Thanks > Carsten > > On 12.05.2020 19:11, Andreas Schaefer wrote: >> Hi >> Just a heads up. I added support for the Feature Launcher Goal inside the >> Slingfeature Maven Plugin. >> A FAR can be loaded through its classifier (if part of the Maven project) or >> can be accessed through its Artifact Id if available in the local Maven repo. >> Cheers - Andy > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
[jira] [Resolved] (SLING-9450) Add Support to the Slingfeature Maven Plugin Launcher to start Feature Archives
[ https://issues.apache.org/jira/browse/SLING-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Schaefer resolved SLING-9450. - Assignee: Andreas Schaefer Resolution: Fixed Two new Launcher properties added to handle Feature Archives. > Add Support to the Slingfeature Maven Plugin Launcher to start Feature > Archives > --- > > Key: SLING-9450 > URL: https://issues.apache.org/jira/browse/SLING-9450 > Project: Sling > Issue Type: New Feature > Components: Feature Model >Affects Versions: slingfeature-maven-plugin 1.3.0 >Reporter: Andreas Schaefer >Assignee: Andreas Schaefer >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.2 > > > Allow to launch of Feature Archives using the Slingfeature Maven Plugin's > Feature Launcher goal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9450) Add Support to the Slingfeature Maven Plugin Launcher to start Feature Archives
Andreas Schaefer created SLING-9450: --- Summary: Add Support to the Slingfeature Maven Plugin Launcher to start Feature Archives Key: SLING-9450 URL: https://issues.apache.org/jira/browse/SLING-9450 Project: Sling Issue Type: New Feature Components: Feature Model Affects Versions: slingfeature-maven-plugin 1.3.0 Reporter: Andreas Schaefer Fix For: slingfeature-maven-plugin 1.3.2 Allow to launch of Feature Archives using the Slingfeature Maven Plugin's Feature Launcher goal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9443) Access Feature Model Aggregates as Files during Maven Build
[ https://issues.apache.org/jira/browse/SLING-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-9443. --- Resolution: Fixed Merged https://github.com/apache/sling-slingfeature-maven-plugin/pull/52 > Access Feature Model Aggregates as Files during Maven Build > --- > > Key: SLING-9443 > URL: https://issues.apache.org/jira/browse/SLING-9443 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: slingfeature-maven-plugin 1.3.0 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.2 > > > When the Feature Aggregates are generated, they are initially kept in memory. > The slingfeature-maven-plugin can access them there, but they cannot be > accessed by other plugins as they won't share the same classloaders. > For other plugins to use these aggregates we need to have them available on > the filesystem. Therefore the feature should be written to the file system as > soon as the aggregate is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9444) Allow the specification of metadata for included artifacts
[
https://issues.apache.org/jira/browse/SLING-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert resolved SLING-9444.
---
Resolution: Fixed
Merged https://github.com/apache/sling-slingfeature-maven-plugin/pull/51
> Allow the specification of metadata for included artifacts
> --
>
> Key: SLING-9444
> URL: https://issues.apache.org/jira/browse/SLING-9444
> Project: Sling
> Issue Type: New Feature
> Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.3.0
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.3.2
>
>
> Artifacts included via the IncludeArtifactMojo should have the possibility of
> metadata provided. For example {{start-order}} ...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9446) Allow skipping inclusion of default resources
[ https://issues.apache.org/jira/browse/SLING-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9446. Fix Version/s: (was: slingfeature-maven-plugin 1.3.2) Resolution: Won't Fix I am going to use a combination of existing plugins instead → WONTFIX. > Allow skipping inclusion of default resources > - > > Key: SLING-9446 > URL: https://issues.apache.org/jira/browse/SLING-9446 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > > When generating api/source/javadoc jars we currently have the option of > configuring additional directories. Sometimes it is useful to configure those > directories to be the only ones included in the jars, as we should provide > flags for it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-9449. -- Fix Version/s: Repoinit JCR 1.1.28 Resolution: Fixed > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists for principal > - > > Key: SLING-9449 > URL: https://issues.apache.org/jira/browse/SLING-9449 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.26 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > Fix For: Repoinit JCR 1.1.28 > > > The check at > https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 > is very aggressive and results in an error getting thrown, which potentially > causes the repository service to not start up. > It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
[ https://issues.apache.org/jira/browse/SLING-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106383#comment-17106383 ] Andrei Dulvac commented on SLING-9449: -- resolved in https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/55aa500da6805482d6972330e37125eacedaca8f > Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry > exists for principal > - > > Key: SLING-9449 > URL: https://issues.apache.org/jira/browse/SLING-9449 > Project: Sling > Issue Type: Bug > Components: Repoinit >Affects Versions: Repoinit JCR 1.1.26 >Reporter: Andrei Dulvac >Assignee: Andrei Dulvac >Priority: Critical > > The check at > https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 > is very aggressive and results in an error getting thrown, which potentially > causes the repository service to not start up. > It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9449) Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal
Andrei Dulvac created SLING-9449: Summary: Repoinit AclUtil#setPrincipalAcl throws exception if no path-based entry exists for principal Key: SLING-9449 URL: https://issues.apache.org/jira/browse/SLING-9449 Project: Sling Issue Type: Bug Components: Repoinit Affects Versions: Repoinit JCR 1.1.26 Reporter: Andrei Dulvac Assignee: Andrei Dulvac The check at https://github.com/apache/sling-org-apache-sling-jcr-repoinit/blob/master/src/main/java/org/apache/sling/jcr/repoinit/impl/AclUtil.java#L191 is very aggressive and results in an error getting thrown, which potentially causes the repository service to not start up. It should be replaced with a log message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9448) Update to current sling parent
Christian Schneider created SLING-9448: -- Summary: Update to current sling parent Key: SLING-9448 URL: https://issues.apache.org/jira/browse/SLING-9448 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution API 0.4.0 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution API 0.4.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Create repository for the content-package-archetype
+1 On Wed, May 13, 2020 at 1:24 AM Carsten Ziegeler wrote: > +1 > > Carsten > > On 12.05.2020 23:45, Robert Munteanu wrote: > > Hi, > > > > I'd like to 'promote' the content-package-archetype [1] to a Sling > > module. This archetype creates a minimal content package that is > > deployable on the Sling Starter. > > > > The template README [2] contains a few more details about the setup. > > > > It is usable as-is and it supports the content-package based > > development theme for Sling 12. [3] > > > > This majority vote is open for at least 72 hours. > > > > Thanks, > > Robert > > > > [1]: https://github.com/rombert/content-package-archetype/ > > [2]: > https://github.com/rombert/content-package-archetype/tree/master/src/main/resources/archetype-resources > > [3]: https://issues.apache.org/jira/browse/SLING-6950 > > > > -- > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org >
[jira] [Comment Edited] (SLING-9389) Distribution Event Packages should contain queue item creation time
[ https://issues.apache.org/jira/browse/SLING-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106286#comment-17106286 ] Timothee Maret edited comment on SLING-9389 at 5/13/20, 1:33 PM: - [~harshchiki] thanks I looked at it. Is it correct that your requirement is to measure the end to end distribution latency for each package on the source service (author) ? If so, could you also clarify if it's a requirement for you to have the information in the event, or if you could not have the information exposed as a metric. was (Author: marett): [~harshchiki] thanks I looked at it. Is it correct that your requirement is to measure the end to end distribution latency for each package on the source service (author) ? > Distribution Event Packages should contain queue item creation time > --- > > Key: SLING-9389 > URL: https://issues.apache.org/jira/browse/SLING-9389 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Harsh Chiki >Assignee: Timothee Maret >Priority: Major > Attachments: image-2020-04-30-10-28-58-011.png, scdapi.patch, > scdcore.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Currently the Distribution Event package contains the following details: > * Distribution Component Name > * Distribution Component Kind > * Distribution Type > * Distribution Paths > > Improvement aims at adding the queue item creation time, essentially when the > the item was creation for the first time, and enqueue into the queue. The > value does not change over retries (on failure). > > The purpose to get this detail is to be able to capture metrics at the > consumer level. The consumers could have an event handler, which can capture > the duration which turns out to be (NOW MINUS queue item creation time thrown > in the distribution event package); NOW being the current time in the event > handler (consumer). > > \cc: [~shgu...@adobe.com], [~ashishc] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9447) Add packageId property to distribution events
[ https://issues.apache.org/jira/browse/SLING-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106300#comment-17106300 ] Timothee Maret commented on SLING-9447: --- [~cschneider] the PR LGTM. Would you also add the events in the core bundle ? > Add packageId property to distribution events > - > > Key: SLING-9447 > URL: https://issues.apache.org/jira/browse/SLING-9447 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution API 0.4.0 >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > For all distribution events it is useful to track the package id. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9447) Add packageId property to distribution events
[ https://issues.apache.org/jira/browse/SLING-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106298#comment-17106298 ] Christian Schneider commented on SLING-9447: [https://github.com/apache/sling-org-apache-sling-distribution-api/pull/5] > Add packageId property to distribution events > - > > Key: SLING-9447 > URL: https://issues.apache.org/jira/browse/SLING-9447 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution API 0.4.0 >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > For all distribution events it is useful to track the package id. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9446) Allow skipping inclusion of default resources
[ https://issues.apache.org/jira/browse/SLING-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106296#comment-17106296 ] Robert Munteanu commented on SLING-9446: For the sake of doing things in once place I guess? Yes, the maven-jar-plugin is also an option, I'll look into that. > Allow skipping inclusion of default resources > - > > Key: SLING-9446 > URL: https://issues.apache.org/jira/browse/SLING-9446 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.2 > > > When generating api/source/javadoc jars we currently have the option of > configuring additional directories. Sometimes it is useful to configure those > directories to be the only ones included in the jars, as we should provide > flags for it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9446) Allow skipping inclusion of default resources
[ https://issues.apache.org/jira/browse/SLING-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106290#comment-17106290 ] Carsten Ziegeler commented on SLING-9446: - Hmm, why would you use this mojo to generate such jars in the first place? You could simply use the jar maven plugin and zip up some resources > Allow skipping inclusion of default resources > - > > Key: SLING-9446 > URL: https://issues.apache.org/jira/browse/SLING-9446 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.2 > > > When generating api/source/javadoc jars we currently have the option of > configuring additional directories. Sometimes it is useful to configure those > directories to be the only ones included in the jars, as we should provide > flags for it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9447) Add packageId property to distribution events
[ https://issues.apache.org/jira/browse/SLING-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106289#comment-17106289 ] Timothee Maret commented on SLING-9447: --- Makes sense to add the package identifier as a property of the events. [~cschneider] do you have a PR for this ? Do you plan to support it in the distribution core bundle ? > Add packageId property to distribution events > - > > Key: SLING-9447 > URL: https://issues.apache.org/jira/browse/SLING-9447 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution API 0.4.0 >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > For all distribution events it is useful to track the package id. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9447) Add packageId property to distribution events
[ https://issues.apache.org/jira/browse/SLING-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-9447: -- Summary: Add packageId property to distribution events (was: Add packageId property) > Add packageId property to distribution events > - > > Key: SLING-9447 > URL: https://issues.apache.org/jira/browse/SLING-9447 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution API 0.4.0 >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > For all distribution events it is useful to track the package id. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9389) Distribution Event Packages should contain queue item creation time
[ https://issues.apache.org/jira/browse/SLING-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106286#comment-17106286 ] Timothee Maret commented on SLING-9389: --- [~harshchiki] thanks I looked at it. Is it correct that your requirement is to measure the end to end distribution latency for each package on the source service (author) ? > Distribution Event Packages should contain queue item creation time > --- > > Key: SLING-9389 > URL: https://issues.apache.org/jira/browse/SLING-9389 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Harsh Chiki >Assignee: Timothee Maret >Priority: Major > Attachments: image-2020-04-30-10-28-58-011.png, scdapi.patch, > scdcore.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Currently the Distribution Event package contains the following details: > * Distribution Component Name > * Distribution Component Kind > * Distribution Type > * Distribution Paths > > Improvement aims at adding the queue item creation time, essentially when the > the item was creation for the first time, and enqueue into the queue. The > value does not change over retries (on failure). > > The purpose to get this detail is to be able to capture metrics at the > consumer level. The consumers could have an event handler, which can capture > the duration which turns out to be (NOW MINUS queue item creation time thrown > in the distribution event package); NOW being the current time in the event > handler (consumer). > > \cc: [~shgu...@adobe.com], [~ashishc] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9447) Add packageId property
[ https://issues.apache.org/jira/browse/SLING-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider updated SLING-9447: --- Description: For all distribution events it is useful to track the package id. > Add packageId property > -- > > Key: SLING-9447 > URL: https://issues.apache.org/jira/browse/SLING-9447 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution API 0.4.0 >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > For all distribution events it is useful to track the package id. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9447) Add packageId property
Christian Schneider created SLING-9447: -- Summary: Add packageId property Key: SLING-9447 URL: https://issues.apache.org/jira/browse/SLING-9447 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution API 0.4.0 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution API 0.4.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9446) Allow skipping inclusion of default resources
[ https://issues.apache.org/jira/browse/SLING-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106281#comment-17106281 ] Robert Munteanu commented on SLING-9446: One of the scenarios is when inclusion of the actual sources is not desirable, so the sources jar could be basically empty with a README file explaining that. Maven Central deployment requires the presence of a sources jar, even if it does not contain the actual classes. As for the flags, I am working with - includeDefaultApiResources - includeDefaultApiJavadocResources - includeDefaultApiSourceResources at the moment. > Allow skipping inclusion of default resources > - > > Key: SLING-9446 > URL: https://issues.apache.org/jira/browse/SLING-9446 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.2 > > > When generating api/source/javadoc jars we currently have the option of > configuring additional directories. Sometimes it is useful to configure those > directories to be the only ones included in the jars, as we should provide > flags for it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9446) Allow skipping inclusion of default resources
[ https://issues.apache.org/jira/browse/SLING-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106277#comment-17106277 ] Carsten Ziegeler commented on SLING-9446: - [~rombert] Can you maybe elaborate what the use case here is and what flags are needed? > Allow skipping inclusion of default resources > - > > Key: SLING-9446 > URL: https://issues.apache.org/jira/browse/SLING-9446 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.2 > > > When generating api/source/javadoc jars we currently have the option of > configuring additional directories. Sometimes it is useful to configure those > directories to be the only ones included in the jars, as we should provide > flags for it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9442) Complete the semantic definition of distribution events
[ https://issues.apache.org/jira/browse/SLING-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106268#comment-17106268 ] Timothee Maret commented on SLING-9442: --- [~cschneider] I think it's ok to shorten the description. Could you open a PR ? > Complete the semantic definition of distribution events > - > > Key: SLING-9442 > URL: https://issues.apache.org/jira/browse/SLING-9442 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > The description of [distribution > events|https://github.com/apache/sling-org-apache-sling-distribution-api/blob/master/src/main/java/org/apache/sling/distribution/event/DistributionEventTopics.java] > does not clearly document the conditions for raising the events. We should > extend the documentation both in the API and in the published documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9446) Allow skipping inclusion of default resources
Robert Munteanu created SLING-9446: -- Summary: Allow skipping inclusion of default resources Key: SLING-9446 URL: https://issues.apache.org/jira/browse/SLING-9446 Project: Sling Issue Type: Improvement Components: Feature Model Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: slingfeature-maven-plugin 1.3.2 When generating api/source/javadoc jars we currently have the option of configuring additional directories. Sometimes it is useful to configure those directories to be the only ones included in the jars, as we should provide flags for it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9445) Add a type safe DistributionEvent
Christian Schneider created SLING-9445: -- Summary: Add a type safe DistributionEvent Key: SLING-9445 URL: https://issues.apache.org/jira/browse/SLING-9445 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution API 0.4.0 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution API 0.4.2 Currently we only define event properties and topics. This makes sending and receiving events a bit of a guesswork. I propose to have a type safe DistributionEvent than can be translated to and from an OSGi event. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9442) Complete the semantic definition of distribution events
[
https://issues.apache.org/jira/browse/SLING-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106261#comment-17106261
]
Christian Schneider commented on SLING-9442:
How about making the DistributionEventProperties docs a little shorter?
{code:java}
/**
* Name of component generating the event
*/
String DISTRIBUTION_COMPONENT_NAME = "distribution.component.name";
/**
* Kind of the component generating the event
*/
String DISTRIBUTION_COMPONENT_KIND= "distribution.component.kind";
/**
* Type of the distribution request
*/
String DISTRIBUTION_TYPE = "distribution.type";
/**
* Distribution paths as String[]
*/
String DISTRIBUTION_PATHS= "distribution.paths";
{code}
> Complete the semantic definition of distribution events
> -
>
> Key: SLING-9442
> URL: https://issues.apache.org/jira/browse/SLING-9442
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution API 0.4.2
>
>
> The description of [distribution
> events|https://github.com/apache/sling-org-apache-sling-distribution-api/blob/master/src/main/java/org/apache/sling/distribution/event/DistributionEventTopics.java]
> does not clearly document the conditions for raising the events. We should
> extend the documentation both in the API and in the published documentation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9442) Complete the semantic definition of distribution events
[ https://issues.apache.org/jira/browse/SLING-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106210#comment-17106210 ] Timothee Maret commented on SLING-9442: --- Updated the Sling sites with more informations https://github.com/apache/sling-site > Complete the semantic definition of distribution events > - > > Key: SLING-9442 > URL: https://issues.apache.org/jira/browse/SLING-9442 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > The description of [distribution > events|https://github.com/apache/sling-org-apache-sling-distribution-api/blob/master/src/main/java/org/apache/sling/distribution/event/DistributionEventTopics.java] > does not clearly document the conditions for raising the events. We should > extend the documentation both in the API and in the published documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9444) Allow the specification of metadata for included artifacts
[
https://issues.apache.org/jira/browse/SLING-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. J. David Bosschaert reassigned SLING-9444:
-
Assignee: A. J. David Bosschaert
> Allow the specification of metadata for included artifacts
> --
>
> Key: SLING-9444
> URL: https://issues.apache.org/jira/browse/SLING-9444
> Project: Sling
> Issue Type: New Feature
> Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.3.0
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.3.2
>
>
> Artifacts included via the IncludeArtifactMojo should have the possibility of
> metadata provided. For example {{start-order}} ...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9444) Allow the specification of metadata for included artifacts
A. J. David Bosschaert created SLING-9444:
-
Summary: Allow the specification of metadata for included artifacts
Key: SLING-9444
URL: https://issues.apache.org/jira/browse/SLING-9444
Project: Sling
Issue Type: New Feature
Components: Feature Model
Affects Versions: slingfeature-maven-plugin 1.3.0
Reporter: A. J. David Bosschaert
Fix For: slingfeature-maven-plugin 1.3.2
Artifacts included via the IncludeArtifactMojo should have the possibility of
metadata provided. For example {{start-order}} ...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-9443) Access Feature Model Aggregates as Files during Maven Build
[ https://issues.apache.org/jira/browse/SLING-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert reassigned SLING-9443: - Assignee: A. J. David Bosschaert > Access Feature Model Aggregates as Files during Maven Build > --- > > Key: SLING-9443 > URL: https://issues.apache.org/jira/browse/SLING-9443 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: slingfeature-maven-plugin 1.3.0 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.2 > > > When the Feature Aggregates are generated, they are initially kept in memory. > The slingfeature-maven-plugin can access them there, but they cannot be > accessed by other plugins as they won't share the same classloaders. > For other plugins to use these aggregates we need to have them available on > the filesystem. Therefore the feature should be written to the file system as > soon as the aggregate is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9443) Access Feature Model Aggregates as Files during Maven Build
A. J. David Bosschaert created SLING-9443: - Summary: Access Feature Model Aggregates as Files during Maven Build Key: SLING-9443 URL: https://issues.apache.org/jira/browse/SLING-9443 Project: Sling Issue Type: Improvement Components: Feature Model Affects Versions: slingfeature-maven-plugin 1.3.0 Reporter: A. J. David Bosschaert Fix For: slingfeature-maven-plugin 1.3.2 When the Feature Aggregates are generated, they are initially kept in memory. The slingfeature-maven-plugin can access them there, but they cannot be accessed by other plugins as they won't share the same classloaders. For other plugins to use these aggregates we need to have them available on the filesystem. Therefore the feature should be written to the file system as soon as the aggregate is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9442) Complete the semantic definition of distribution events
[ https://issues.apache.org/jira/browse/SLING-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret reassigned SLING-9442: - Assignee: Timothee Maret > Complete the semantic definition of distribution events > - > > Key: SLING-9442 > URL: https://issues.apache.org/jira/browse/SLING-9442 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > The description of [distribution > events|https://github.com/apache/sling-org-apache-sling-distribution-api/blob/master/src/main/java/org/apache/sling/distribution/event/DistributionEventTopics.java] > does not clearly document the conditions for raising the events. We should > extend the documentation both in the API and in the published documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9442) Complete the semantic definition of distribution events
[ https://issues.apache.org/jira/browse/SLING-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106108#comment-17106108 ] Timothee Maret commented on SLING-9442: --- Opened PR [#3|https://github.com/apache/sling-org-apache-sling-distribution-api/pull/3] > Complete the semantic definition of distribution events > - > > Key: SLING-9442 > URL: https://issues.apache.org/jira/browse/SLING-9442 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > The description of [distribution > events|https://github.com/apache/sling-org-apache-sling-distribution-api/blob/master/src/main/java/org/apache/sling/distribution/event/DistributionEventTopics.java] > does not clearly document the conditions for raising the events. We should > extend the documentation both in the API and in the published documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9442) Complete the semantic definition of distribution events
[ https://issues.apache.org/jira/browse/SLING-9442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-9442: -- Summary: Complete the semantic definition of distribution events(was: Complete the semantic of distribution events ) > Complete the semantic definition of distribution events > - > > Key: SLING-9442 > URL: https://issues.apache.org/jira/browse/SLING-9442 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Timothee Maret >Priority: Major > Fix For: Content Distribution API 0.4.2 > > > The description of [distribution > events|https://github.com/apache/sling-org-apache-sling-distribution-api/blob/master/src/main/java/org/apache/sling/distribution/event/DistributionEventTopics.java] > does not clearly document the conditions for raising the events. We should > extend the documentation both in the API and in the published documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9442) Complete the semantic of distribution events
Timothee Maret created SLING-9442: - Summary: Complete the semantic of distribution events Key: SLING-9442 URL: https://issues.apache.org/jira/browse/SLING-9442 Project: Sling Issue Type: Bug Components: Content Distribution Reporter: Timothee Maret Fix For: Content Distribution API 0.4.2 The description of [distribution events|https://github.com/apache/sling-org-apache-sling-distribution-api/blob/master/src/main/java/org/apache/sling/distribution/event/DistributionEventTopics.java] does not clearly document the conditions for raising the events. We should extend the documentation both in the API and in the published documentation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
