[jira] [Resolved] (SLING-9485) CMS - Reference Forms Package Not Exposed

2020-05-28 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-9485.
-
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-app-cms/commit/73c705e774ac6d7e4b1743d3fbeb493a5e6bb5bc

> CMS - Reference Forms Package Not Exposed
> -
>
> Key: SLING-9485
> URL: https://issues.apache.org/jira/browse/SLING-9485
> Project: Sling
>  Issue Type: Bug
>  Components: App CMS
>Affects Versions: App CMS 0.16.2
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 0.16.4
>
>
> The package `org.apache.sling.cms.reference.forms` is not exposed in the 
> reference project with the new BND configuration resulting in not being able 
> to import / extend the forms functionality.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9486) CMS - Not Compatible with AlpineJS

2020-05-28 Thread Dan Klco (Jira)
Dan Klco created SLING-9486:
---

 Summary: CMS - Not Compatible with AlpineJS
 Key: SLING-9486
 URL: https://issues.apache.org/jira/browse/SLING-9486
 Project: Sling
  Issue Type: Bug
  Components: App CMS
Affects Versions: App CMS 0.16.2
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: App CMS 0.16.4


Seemingly due to the rewriter Sling CMS is not compatible with AlpineJS and 
strips out the x-bind and @ attributes when rendering the HTML.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9485) CMS - Reference Forms Package Not Exposed

2020-05-28 Thread Dan Klco (Jira)
Dan Klco created SLING-9485:
---

 Summary: CMS - Reference Forms Package Not Exposed
 Key: SLING-9485
 URL: https://issues.apache.org/jira/browse/SLING-9485
 Project: Sling
  Issue Type: Bug
  Components: App CMS
Affects Versions: App CMS 0.16.2
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: App CMS 0.16.4


The package `org.apache.sling.cms.reference.forms` is not exposed in the 
reference project with the new BND configuration resulting in not being able to 
import / extend the forms functionality.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9484) CMS - Archetype Missing BND Configurations

2020-05-28 Thread Dan Klco (Jira)
Dan Klco created SLING-9484:
---

 Summary: CMS - Archetype Missing BND Configurations
 Key: SLING-9484
 URL: https://issues.apache.org/jira/browse/SLING-9484
 Project: Sling
  Issue Type: Bug
  Components: App CMS
Affects Versions: App CMS 0.16.2
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: App CMS 0.16.4


The Sling CMS Archetype project is missing the BND configuration attributes:

* -includeresource
* Sling-Initial-Content
* Sling-Model-Packages

And therefore will not load content or expose models.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9482) Seed the cache from offset persisted in the source repository

2020-05-28 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-9482:
--
Fix Version/s: (was: Content Distribution Journal Core 0.1.20)
   Content Distribution Journal Core 0.1.16

> Seed the cache from offset persisted in the source repository
> -
>
> Key: SLING-9482
> URL: https://issues.apache.org/jira/browse/SLING-9482
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.16
>
>
> The approach taken in SLING-9460 to avoid sending seeding messages does not 
> address some scenarios like publishing content without subscriber agents. 
> Without subscriber agents.
> To be sure we always have a recent seed available, we should persist seed 
> offsets in the source repository (typ. author) and seed caches from it. We do 
> have the local store class that allows to easily write the offsets in the 
> repository. To not stress the repository too much, we should batch those 
> writes (e.g. 1 offset update every 10 package processed). To support a 
> cluster, the writes must be initiated only from the cluster leader instance.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9482) Seed the cache from offset persisted in the source repository

2020-05-28 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-9482:
--
Fix Version/s: Content Distribution Journal Core 0.1.20

> Seed the cache from offset persisted in the source repository
> -
>
> Key: SLING-9482
> URL: https://issues.apache.org/jira/browse/SLING-9482
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.20
>
>
> The approach taken in SLING-9460 to avoid sending seeding messages does not 
> address some scenarios like publishing content without subscriber agents. 
> Without subscriber agents.
> To be sure we always have a recent seed available, we should persist seed 
> offsets in the source repository (typ. author) and seed caches from it. We do 
> have the local store class that allows to easily write the offsets in the 
> repository. To not stress the repository too much, we should batch those 
> writes (e.g. 1 offset update every 10 package processed). To support a 
> cluster, the writes must be initiated only from the cluster leader instance.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9482) Seed the cache from offset persisted in the source repository

2020-05-28 Thread Timothee Maret (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119097#comment-17119097
 ] 

Timothee Maret commented on SLING-9482:
---

Done in 
[c7814657bb42996558a781d749a93c72437c89fc|https://github.com/apache/sling-org-apache-sling-distribution-journal/commit/c7814657bb42996558a781d749a93c72437c89fc].
  The change introduce the following repository operations:

* One read op when a publisher agent starts
* At most one write operation per cluster every 15 minutes, 0 write op if no 
package was produced during the last 15 minutes

> Seed the cache from offset persisted in the source repository
> -
>
> Key: SLING-9482
> URL: https://issues.apache.org/jira/browse/SLING-9482
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>
> The approach taken in SLING-9460 to avoid sending seeding messages does not 
> address some scenarios like publishing content without subscriber agents. 
> Without subscriber agents.
> To be sure we always have a recent seed available, we should persist seed 
> offsets in the source repository (typ. author) and seed caches from it. We do 
> have the local store class that allows to easily write the offsets in the 
> repository. To not stress the repository too much, we should batch those 
> writes (e.g. 1 offset update every 10 package processed). To support a 
> cluster, the writes must be initiated only from the cluster leader instance.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9476) Journal IT tests fail

2020-05-28 Thread Timothee Maret (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17119091#comment-17119091
 ] 

Timothee Maret commented on SLING-9476:
---

Fixed in 
[73b225fc6d5a3ea67cc6315201d7a4c541e486cd|https://github.com/apache/sling-org-apache-sling-distribution-journal-it/commit/73b225fc6d5a3ea67cc6315201d7a4c541e486cd].
 Two tests had to be adjusted because they made the assumption that the first 
package sent would be at offset 1. This assumption is wrong since SLING-9460. 
As no seeding messages are sent, the first package comes at offset 0.

IT tests pass at 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/job/master/384/


 

> Journal IT tests fail
> -
>
> Key: SLING-9476
> URL: https://issues.apache.org/jira/browse/SLING-9476
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal ITs 0.1.2
>
>
> Since the change SLING-9460, some IT test fail
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/
> AuthorDistributeTest.testDistribute



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9476) Journal IT tests fail

2020-05-28 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-9476.
---
Resolution: Fixed

> Journal IT tests fail
> -
>
> Key: SLING-9476
> URL: https://issues.apache.org/jira/browse/SLING-9476
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal ITs 0.1.2
>
>
> Since the change SLING-9460, some IT test fail
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/
> AuthorDistributeTest.testDistribute



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows

2020-05-28 Thread Andreas Schaefer (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Schaefer resolved SLING-9483.
-
Resolution: Fixed

Added the check for a Windows drive letter to the path and then removed it 
before creating the cache folder path.

> Sling Feature is not supporting jar:file URLs on Windows
> 
>
> Key: SLING-9483
> URL: https://issues.apache.org/jira/browse/SLING-9483
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.0
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Feature Model 1.2.2
>
>
> When using a jar:file url to launch a feature in the feature launcher it will 
> fail because the folder to export the Feature Model file contains the drive 
> name (c:/) which fails when the folder is created.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9474) Bad partition when using an empty package topic

2020-05-28 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-9474.
---
Resolution: Fixed

> Bad partition when using an empty package topic
> ---
>
> Key: SLING-9474
> URL: https://issues.apache.org/jira/browse/SLING-9474
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.16
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.16
>
>
> Since SLING-9460, the PubQueueCacheService tail poller fails to establish on 
> empty topics. It prevents agent from activating properly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9483) Sling Feature is not supporting jar:file URLs on Windows

2020-05-28 Thread Andreas Schaefer (Jira)
Andreas Schaefer created SLING-9483:
---

 Summary: Sling Feature is not supporting jar:file URLs on Windows
 Key: SLING-9483
 URL: https://issues.apache.org/jira/browse/SLING-9483
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model 1.2.0
Reporter: Andreas Schaefer
Assignee: Andreas Schaefer
 Fix For: Feature Model 1.2.2


When using a jar:file url to launch a feature in the feature launcher it will 
fail because the folder to export the Feature Model file contains the drive 
name (c:/) which fails when the folder is created.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-28 Thread GitBox


sonarcloud[bot] commented on pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635590604


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_coverage=list)
 [8.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-28 Thread GitBox


sonarcloud[bot] removed a comment on pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-628945404


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=28=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=28=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SLING-9397) SAML2 Authentication Handler [initial submission]

2020-05-28 Thread Cris Rockwell (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118977#comment-17118977
 ] 

Cris Rockwell commented on SLING-9397:
--

Question about local testing using "docker or some sort of JUnit setup:"  I 
assume this means one step that installs and configures an external IDP 
(running locally), installs the related configurations for SAML2 module in 
Sling; perhaps a mvn profile, and runs integration JUnit tests. Let me know if 
I misunderstood.

It could take me a while for that. My knowledge and experience using docker is 
(shall we say) just now emerging. For example, I had Keycloak IDP running via 
docker and a week later it wouldn't start at all. Since I'm novice at docker 
and had this trouble, I had revised the instructions to download and install 
Keycloak the old fashioned way. 

Nevertheless, I can take another pass... 

[ ] Change signing and encryption to optional. This will simplify localhost 
testing.
[ ] One step process to launch a preconfigured localhost IDP external to Sling
[ ] Maven profile to rollout OSGI SAML2 settings for localhost IDP above

Any kind of direct help or advice would be most appreciated.  Otherwise, I'll 
chip away this localhost testing.

> SAML2 Authentication Handler [initial submission]
> -
>
> Key: SLING-9397
> URL: https://issues.apache.org/jira/browse/SLING-9397
> Project: Sling
>  Issue Type: New Feature
>  Components: Authentication
> Environment: localhost
>Reporter: Cris Rockwell
>Priority: Major
>  Labels: SAML, authentification, security, user_management
>   Original Estimate: 168h
>  Time Spent: 1h
>  Remaining Estimate: 167h
>
> Here is a pull request which adds an authentication handler for a SAML2 
> Service Provider via the embedded OpenSAML V3 dependencies
> [https://github.com/apache/sling-whiteboard/pull/51]
>  
> *TODO Before Initial*
> [X] Sync attributes released by the IDP
> [X] Confirm license and attribution 
> "As the code is ASL2 and does not require a notice or anything else, we don't 
> need to mention in. But I think its usually good style to do so and have a 
> single sentence in our NOTICE that we include (modified) code from ... which 
> has ASL2 as the license"
>  
> *TODO After Initial* 
> [ ] Get confirmation the project builds and operates as expected
> [X] Ensure that the NOTICE file is the correct one
> [ ] Testing setup ( documentation, local SAML provider, etc )
> [ ] Clarify whether we can depend on artifacts not deployed on Maven Central
> [ ] Review Web Browser SSO Profile Specification 4.1 and confirm all aspects 
> * [https://docs.oasis-open.org/security/saml/v2.0/saml-profiles-2.0-os.pdf]
> [ ] Consider whether use of {{SAML2ConfigService}} and 
> {{SAML2ConfigServiceImpl}} is a good design or not.
> [ ] Get feedback whether README instructions are too much, too little, 
> unclear, etc
> [ ] Decide whether to make signing and encryption optional. Currently it is 
> required
> [ ] Find and fix any bugs
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-cpconverter] kaushalmall edited a comment on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-28 Thread GitBox


kaushalmall edited a comment on pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635433227


   Hi @cziegeler @DominikSuess if this is preferred, I can move this code to 
the corresponding class(es) to delete _before_ the processing starts. Let me 
know.
   >why not delete the directory before running the tool; 
   
   @DominikSuess do you mind creating an issue for this? Not sure if I have 
access
   >It would also be good to have a jira issue for this
   
   Please add that the "synthetic" typo is also fixed as part of this issue :-) 




This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-feature-cpconverter] kaushalmall commented on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-28 Thread GitBox


kaushalmall commented on pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635434637


   @bdelacretaz thanks for catching it, the original class has the same typo, 
but, I just updated the PR to fix it across the board. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [sling-org-apache-sling-feature-cpconverter] kaushalmall commented on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-28 Thread GitBox


kaushalmall commented on pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635433227


   >why not delete the directory before running the tool; 
   Hi @cziegeler @DominikSuess if this is preferred, I can move this code to 
the corresponding class(es) to delete _before_ the processing starts. Let me 
know. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (SLING-9482) Seed the cache from offset persisted in the source repository

2020-05-28 Thread Timothee Maret (Jira)
Timothee Maret created SLING-9482:
-

 Summary: Seed the cache from offset persisted in the source 
repository
 Key: SLING-9482
 URL: https://issues.apache.org/jira/browse/SLING-9482
 Project: Sling
  Issue Type: Bug
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret


The approach taken in SLING-9460 to avoid sending seeding messages does not 
address some scenarios like publishing content without subscriber agents. 
Without subscriber agents.

To be sure we always have a recent seed available, we should persist seed 
offsets in the source repository (typ. author) and seed caches from it. We do 
have the local store class that allows to easily write the offsets in the 
repository. To not stress the repository too much, we should batch those writes 
(e.g. 1 offset update every 10 package processed). To support a cluster, the 
writes must be initiated only from the cluster leader instance.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-app-cms] klcodanr merged pull request #10: Avoid interaction with tzdata

2020-05-28 Thread GitBox


klcodanr merged pull request #10:
URL: https://github.com/apache/sling-org-apache-sling-app-cms/pull/10


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #816 is BROKEN

2020-05-28 Thread Apache Jenkins Server
Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/816/
 for details.

No further emails will be sent until the status of the build is changed.
Build log follows below:

[...truncated 11775 lines...]
body, h2 {
margin: 0
}

.Grid.Gutter > .Cell {
padding: 0 1rem
}

.Grid.Align-Center {
align-items: center
}

.Grid .Cell {
-webkit-box-flex: 0;
-webkit-flex: 0 0 100%;
-ms-flex: 0 0 100%;
flex: 0 0 100%
}

.Grid .Cell.Align-Center {
align-self: center
}

.Grid.Fit-Mobile > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}

@media (min-width: 34em) {
.Grid.Fit-Small > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}

}

@media (min-width: 48em) {
.Grid.Fit-Medium > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}

}

@media (min-width: 62em) {
.Grid .Cell.Large-15 {
flex: 0 0 15%
}

.Grid .Cell.Large-25 {
flex: 0 0 25%
}

.Grid .Cell.Large-35 {
flex: 0 0 35%
}

.Grid .Cell.Large-50 {
flex: 0 0 50%
}

.Grid.Fit-Large > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}
}

@media (min-width: 75em) {

.Grid.Fit-Extra > .Cell {
-webkit-box-flex: 1;
-webkit-flex: 1;
-ms-flex: 1;
flex: 1
}
}

* {
box-sizing: border-box
}

body {
font-family: 'Open Sans', Helvetica, Arial;
color: gray;
position: relative;
height: 100%;
}

h1 {
font-size: 2.4em;
color: #606060
}

h2 {
font-weight: 400;
font-size: 1em
}

a {
color: #00678c;
text-decoration: none
}

a:hover {
text-decoration: underline
}

a img {
border: none
}

.Home-Grid {
min-height: 100%
}

.Home-Grid .Gradient {
flex: 0 0 100%;
height: 16px;
background: 

[VOTE] move o.a.s.graphql.samples.website to its own repo

2020-05-28 Thread Bertrand Delacretaz
Hi,

I'd like to move the org.apache.sling.graphql.samples.website [1]
module to its own Git repository.

It's a companion module to the GraphQL Core module, which demonstrates
its features, see the README there for more info.

Proposed repository name:

  org.apache.sling.graphql.sample.website

(using singular "sample" as it's "a sample website")

This majority vote is open for at least 72 hours.

Here's my +1

-Bertrand

[1] 
https://github.com/apache/sling-whiteboard/tree/master/org.apache.sling.graphql.samples.website


[jira] [Created] (SLING-9481) Avoid seeding messages in PackageRepo

2020-05-28 Thread Christian Schneider (Jira)
Christian Schneider created SLING-9481:
--

 Summary: Avoid seeding messages in PackageRepo
 Key: SLING-9481
 URL: https://issues.apache.org/jira/browse/SLING-9481
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Affects Versions: Content Distribution Journal Core 0.1.10
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: Content Distribution Journal Core 0.1.16


Currently we us seeding messages to determine the oldest and newest offset on 
the journal. This is then used to cleanup the larger packages that are stored 
in the repo.

To avoid those seeding messages we should rely on a much simpler algorithm.

We only store very few packages in the repository. So there is no need to clean 
them quickly. We only must make sure we clean packages up after they are not 
anymore present in the journal. As retention time is maximum 7 days. We can 
assume that 30 days is a safe time after which we can delete packages.

So the idea is to run a cleanup in certain intervals and cleanup all packages 
that are older than 30 days.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9476) Journal IT tests fail

2020-05-28 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-9476:
--
Fix Version/s: Content Distribution Journal ITs 0.1.2

> Journal IT tests fail
> -
>
> Key: SLING-9476
> URL: https://issues.apache.org/jira/browse/SLING-9476
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal ITs 0.1.2
>
>
> Since the change SLING-9460, some IT test fail
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/
> AuthorDistributeTest.testDistribute



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9476) Journal IT tests fail

2020-05-28 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-9476:
--
Component/s: Content Distribution

> Journal IT tests fail
> -
>
> Key: SLING-9476
> URL: https://issues.apache.org/jira/browse/SLING-9476
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>
> Since the change SLING-9460, some IT test fail
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/
> AuthorDistributeTest.testDistribute



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-9480) Provide all artifacts to OSGi installer

2020-05-28 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9480.
-
Resolution: Fixed

Changed in 
https://github.com/apache/sling-org-apache-sling-installer-factory-feature/commit/c328d1f57736b0e2908a65ee5a13e84711883ca0

> Provide all artifacts to OSGi installer
> ---
>
> Key: SLING-9480
> URL: https://issues.apache.org/jira/browse/SLING-9480
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Installer
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.5.0
>
>
> Right now only bundles and artifacts from a content package extension are 
> provided to the OSGi installer; however all artifacts from all extensions 
> should be provided, avoiding special casing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9480) Provide all artifacts to OSGi installer

2020-05-28 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-9480:
---

 Summary: Provide all artifacts to OSGi installer
 Key: SLING-9480
 URL: https://issues.apache.org/jira/browse/SLING-9480
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model, Installer
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Installer Factory Feature Model 0.5.0


Right now only bundles and artifacts from a content package extension are 
provided to the OSGi installer; however all artifacts from all extensions 
should be provided, avoiding special casing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9479) GraphQL fetcher comments convert to headings in GraphiQL docs

2020-05-28 Thread Bertrand Delacretaz (Jira)
Bertrand Delacretaz created SLING-9479:
--

 Summary: GraphQL fetcher comments convert to headings in GraphiQL 
docs
 Key: SLING-9479
 URL: https://issues.apache.org/jira/browse/SLING-9479
 Project: Sling
  Issue Type: Bug
  Components: GraphQL
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz


The GraphQL core currently uses comments like this to map fields to 
DataFetchers:

{code}
## fetch:samples/seeAlso
{code}

A common tool to look at those schemas is GraphiQL, which converts such 
comments to headings, considering them to be Markdown.

We should switch to a less intrusive marker that converts nicely to Markdown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[VOTE RESULT] Release Apache Sling Installer Factory Feature 0.4.0

2020-05-28 Thread Carsten Ziegeler

The vote passes with four binding +1 votes and one non binding +1 vote

Thanks
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Closed] (SLING-9470) Variables in feature model are not replaced on installation

2020-05-28 Thread Carsten Ziegeler (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-9470.
---

> Variables in feature model are not replaced on installation
> ---
>
> Key: SLING-9470
> URL: https://issues.apache.org/jira/browse/SLING-9470
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Installer
>Affects Versions: Installer Factory Feature Model 0.3.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Factory Feature Model 0.4.0
>
>
> When variables are used in the feature model, they are currently not replaced



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-9478) Expose the full stack trace for PostConstruct exceptions

2020-05-28 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118532#comment-17118532
 ] 

Konrad Windszus commented on SLING-9478:


Probably this is caused by the Oracle Hotspot Optimization in 
[https://stackoverflow.com/a/3010106.]

> Expose the full stack trace for PostConstruct exceptions
> 
>
> Key: SLING-9478
> URL: https://issues.apache.org/jira/browse/SLING-9478
> Project: Sling
>  Issue Type: Improvement
>  Components: Sling Models
>Affects Versions: Sling Models Impl 1.4.12
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Models Impl 1.4.14
>
>
> Currently any InvocationTargetException is stripped in 
> https://github.com/apache/sling-org-apache-sling-models-impl/blob/80b1dea63615ea5be8252241d6147bce9552fa8e/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L756
>  as it is replaced by the more generic PostConstruct exception stripping the 
> the reflection part of the call stack.
> That may lead to exceptions like
> {code}
> Caused by: org.apache.sling.scripting.sightly.SightlyException: 
> org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
> Identifier  cannot be correctly instantiated by the Use API
>   at 
> com.adobe.cq.sightly.WCMScriptHelper.includeScript(WCMScriptHelper.java:227) 
> [com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
>   at 
> com.adobe.cq.sightly.internal.extensions.IncludeExtension.call(IncludeExtension.java:72)
>  [com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
>   at 
> org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:77)
>  [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
>   at 
> org.apache.sling.scripting.sightly.apps.bruker.components.structure.header.header_html.render(header_html.java:41)
>   at 
> org.apache.sling.scripting.sightly.render.RenderUnit.render(RenderUnit.java:50)
>  [org.apache.sling.scripting.sightly.runtime:1.1.0.1_4_0]
>   at 
> org.apache.sling.scripting.sightly.impl.engine.SightlyCompiledScript.eval(SightlyCompiledScript.java:60)
>  [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
>   at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
>  [org.apache.sling.scripting.core:2.0.56]
>   at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
>  [org.apache.sling.scripting.core:2.0.56]
>   at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
>  [org.apache.sling.scripting.core:2.0.56]
>   ... 198 common frames omitted
> Caused by: org.apache.sling.api.SlingException: Cannot get 
> DefaultSlingScript: Identifier  cannot be correctly instantiated by 
> the Use API
>   at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:510)
>  [org.apache.sling.scripting.core:2.0.56]
>   at 
> com.adobe.cq.sightly.WCMScriptHelper.includeScript(WCMScriptHelper.java:222) 
> [com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
>   ... 206 common frames omitted
> Caused by: org.apache.sling.scripting.sightly.SightlyException: Identifier 
>  cannot be correctly instantiated by the Use API
>   at 
> org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:77)
>  [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
>   at 
> org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:77)
>  [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
>   at 
> org.apache.sling.scripting.sightly.apps.bruker.components.structure.header.content_html.render(content_html.java:43)
>   at 
> org.apache.sling.scripting.sightly.render.RenderUnit.render(RenderUnit.java:50)
>  [org.apache.sling.scripting.sightly.runtime:1.1.0.1_4_0]
>   at 
> org.apache.sling.scripting.sightly.impl.engine.SightlyCompiledScript.eval(SightlyCompiledScript.java:60)
>  [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
>   at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
>  [org.apache.sling.scripting.core:2.0.56]
>   at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
>  [org.apache.sling.scripting.core:2.0.56]
>   at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
>  [org.apache.sling.scripting.core:2.0.56]
>   ... 207 common frames omitted
> Caused by: org.apache.sling.models.factory.PostConstructException: 
> Post-construct method has thrown an exception for model class 
>   at 
> 

[jira] [Updated] (SLING-9478) Expose the full stack trace for PostConstruct exceptions

2020-05-28 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9478:
---
Description: 
Currently any InvocationTargetException is stripped in 
https://github.com/apache/sling-org-apache-sling-models-impl/blob/80b1dea63615ea5be8252241d6147bce9552fa8e/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L756
 as it is replaced by the more generic PostConstruct exception stripping the 
the reflection part of the call stack.

That may lead to exceptions like
{code}
Caused by: org.apache.sling.scripting.sightly.SightlyException: 
org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: Identifier 
 cannot be correctly instantiated by the Use API
at 
com.adobe.cq.sightly.WCMScriptHelper.includeScript(WCMScriptHelper.java:227) 
[com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
at 
com.adobe.cq.sightly.internal.extensions.IncludeExtension.call(IncludeExtension.java:72)
 [com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
at 
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:77)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.sightly.apps.bruker.components.structure.header.header_html.render(header_html.java:41)
at 
org.apache.sling.scripting.sightly.render.RenderUnit.render(RenderUnit.java:50) 
[org.apache.sling.scripting.sightly.runtime:1.1.0.1_4_0]
at 
org.apache.sling.scripting.sightly.impl.engine.SightlyCompiledScript.eval(SightlyCompiledScript.java:60)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
 [org.apache.sling.scripting.core:2.0.56]
... 198 common frames omitted
Caused by: org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
Identifier  cannot be correctly instantiated by the Use API
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:510)
 [org.apache.sling.scripting.core:2.0.56]
at 
com.adobe.cq.sightly.WCMScriptHelper.includeScript(WCMScriptHelper.java:222) 
[com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
... 206 common frames omitted
Caused by: org.apache.sling.scripting.sightly.SightlyException: Identifier 
 cannot be correctly instantiated by the Use API
at 
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:77)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:77)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.sightly.apps.bruker.components.structure.header.content_html.render(content_html.java:43)
at 
org.apache.sling.scripting.sightly.render.RenderUnit.render(RenderUnit.java:50) 
[org.apache.sling.scripting.sightly.runtime:1.1.0.1_4_0]
at 
org.apache.sling.scripting.sightly.impl.engine.SightlyCompiledScript.eval(SightlyCompiledScript.java:60)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
 [org.apache.sling.scripting.core:2.0.56]
... 207 common frames omitted
Caused by: org.apache.sling.models.factory.PostConstructException: 
Post-construct method has thrown an exception for model class 
at 
org.apache.sling.models.impl.ModelAdapterFactory.createObject(ModelAdapterFactory.java:774)
 [org.apache.sling.models.impl:1.4.10]
at 
org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:448)
 [org.apache.sling.models.impl:1.4.10]
at 
org.apache.sling.models.impl.ModelAdapterFactory.createModel(ModelAdapterFactory.java:314)
 [org.apache.sling.models.impl:1.4.10]
at 
org.apache.sling.scripting.sightly.models.impl.SlingModelsUseProvider.provide(SlingModelsUseProvider.java:126)
 [org.apache.sling.scripting.sightly.models.provider:1.0.8]
at 
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:72)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
... 214 common 

[jira] [Updated] (SLING-9478) Expose the full stack trace for PostConstruct exceptions

2020-05-28 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9478:
---
Description: 
Currently any InvocationTargetException is stripped in 
https://github.com/apache/sling-org-apache-sling-models-impl/blob/80b1dea63615ea5be8252241d6147bce9552fa8e/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L756
 as it is replaced by the more generic PostConstruct exception stripping the 
the reflection part of the call stack.

That may lead to exceptions like
{code}
Caused by: org.apache.sling.scripting.sightly.SightlyException: 
org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: Identifier 
 cannot be correctly instantiated by the Use API
at 
com.adobe.cq.sightly.WCMScriptHelper.includeScript(WCMScriptHelper.java:227) 
[com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
at 
com.adobe.cq.sightly.internal.extensions.IncludeExtension.call(IncludeExtension.java:72)
 [com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
at 
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:77)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.sightly.apps.bruker.components.structure.header.header_html.render(header_html.java:41)
at 
org.apache.sling.scripting.sightly.render.RenderUnit.render(RenderUnit.java:50) 
[org.apache.sling.scripting.sightly.runtime:1.1.0.1_4_0]
at 
org.apache.sling.scripting.sightly.impl.engine.SightlyCompiledScript.eval(SightlyCompiledScript.java:60)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
 [org.apache.sling.scripting.core:2.0.56]
... 198 common frames omitted
Caused by: org.apache.sling.api.SlingException: Cannot get DefaultSlingScript: 
Identifier  cannot be correctly instantiated by the Use API
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:510)
 [org.apache.sling.scripting.core:2.0.56]
at 
com.adobe.cq.sightly.WCMScriptHelper.includeScript(WCMScriptHelper.java:222) 
[com.adobe.cq.sightly.cq-wcm-sightly-extension:1.6.0]
... 206 common frames omitted
Caused by: org.apache.sling.scripting.sightly.SightlyException: Identifier 
 cannot be correctly instantiated by the Use API
at 
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:77)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:77)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.sightly.apps.bruker.components.structure.header.content_html.render(content_html.java:43)
at 
org.apache.sling.scripting.sightly.render.RenderUnit.render(RenderUnit.java:50) 
[org.apache.sling.scripting.sightly.runtime:1.1.0.1_4_0]
at 
org.apache.sling.scripting.sightly.impl.engine.SightlyCompiledScript.eval(SightlyCompiledScript.java:60)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
 [org.apache.sling.scripting.core:2.0.56]
at 
org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
 [org.apache.sling.scripting.core:2.0.56]
... 207 common frames omitted
Caused by: org.apache.sling.models.factory.PostConstructException: 
Post-construct method has thrown an exception for model class 
at 
org.apache.sling.models.impl.ModelAdapterFactory.createObject(ModelAdapterFactory.java:774)
 [org.apache.sling.models.impl:1.4.10]
at 
org.apache.sling.models.impl.ModelAdapterFactory.internalCreateModel(ModelAdapterFactory.java:448)
 [org.apache.sling.models.impl:1.4.10]
at 
org.apache.sling.models.impl.ModelAdapterFactory.createModel(ModelAdapterFactory.java:314)
 [org.apache.sling.models.impl:1.4.10]
at 
org.apache.sling.scripting.sightly.models.impl.SlingModelsUseProvider.provide(SlingModelsUseProvider.java:126)
 [org.apache.sling.scripting.sightly.models.provider:1.0.8]
at 
org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:72)
 [org.apache.sling.scripting.sightly:1.1.2.1_4_0]
... 214 common 

[jira] [Created] (SLING-9478) Expose the full stack trace for PostConstruct exceptions

2020-05-28 Thread Konrad Windszus (Jira)
Konrad Windszus created SLING-9478:
--

 Summary: Expose the full stack trace for PostConstruct exceptions
 Key: SLING-9478
 URL: https://issues.apache.org/jira/browse/SLING-9478
 Project: Sling
  Issue Type: Improvement
  Components: Sling Models
Affects Versions: Sling Models Impl 1.4.12
Reporter: Konrad Windszus
Assignee: Konrad Windszus
 Fix For: Sling Models Impl 1.4.14


Currently any InvocationTargetException is swallowed in 
https://github.com/apache/sling-org-apache-sling-models-impl/blob/80b1dea63615ea5be8252241d6147bce9552fa8e/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java#L756
 as it is replaced by the more generic PostConstruct exception. The underlying 
exception should be kept as cause.

This has been a regression from SLING-4767 and SLING-5389.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9477) Teleported tests cannot be executed on the latest Sling Starter App

2020-05-28 Thread Radu Cotescu (Jira)
Radu Cotescu created SLING-9477:
---

 Summary: Teleported tests cannot be executed on the latest Sling 
Starter App
 Key: SLING-9477
 URL: https://issues.apache.org/jira/browse/SLING-9477
 Project: Sling
  Issue Type: Bug
  Components: Testing
Affects Versions: JUnit Core 1.0.28
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: JUnit Core 1.0.30


The {{org.apache.sling.junit.impl.BundleTestsProvider}} class relies on the 
{{service.pid}} property for generating a unique PID with which the provider 
should be registered for registering tests to execute. However, the 
{{service.pid}} property can be missing from the service.

A more stable property, which should still provide some uniqueness, would be 
{{component.name}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-cpconverter] bdelacretaz commented on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-28 Thread GitBox


bdelacretaz commented on pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635154939


   FWIW, I think "synthetic" is spelled wrong in `syntethic-content-packages` - 
but maybe that's a reflection of a typo made elsewhere.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Commented] (SLING-9460) Avoid seeding messages in PubQueueCache

2020-05-28 Thread Timothee Maret (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-9460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17118381#comment-17118381
 ] 

Timothee Maret commented on SLING-9460:
---

Cause SLING-9476 and SLING-9474

> Avoid seeding messages in PubQueueCache
> ---
>
> Key: SLING-9460
> URL: https://issues.apache.org/jira/browse/SLING-9460
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.10
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.12
>
>
> We seed the cache to make sure we have a known minimal offset. So when a 
> request for an older package comes in we can create an additional consumer 
> that can then stop when it reaches the minimal offset.
> Instead of seeding we could wait until we receive the first discovery 
> message. Then we can start from this offset. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-9476) Journal IT tests fail

2020-05-28 Thread Timothee Maret (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-9476:
--
Description: 
Since the change SLING-9460, some IT test fail

https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/
AuthorDistributeTest.testDistribute

> Journal IT tests fail
> -
>
> Key: SLING-9476
> URL: https://issues.apache.org/jira/browse/SLING-9476
> Project: Sling
>  Issue Type: Bug
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>
> Since the change SLING-9460, some IT test fail
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/
> AuthorDistributeTest.testDistribute



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (SLING-9476) Journal IT tests fail

2020-05-28 Thread Timothee Maret (Jira)
Timothee Maret created SLING-9476:
-

 Summary: Journal IT tests fail
 Key: SLING-9476
 URL: https://issues.apache.org/jira/browse/SLING-9476
 Project: Sling
  Issue Type: Bug
Reporter: Timothee Maret
Assignee: Timothee Maret






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-feature-cpconverter] cziegeler commented on pull request #28: Feature Converter doesn't cleanup after itself

2020-05-28 Thread GitBox


cziegeler commented on pull request #28:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/28#issuecomment-635139557


   I assume the problem here is a re-run of the tool?
   If that is the case, why not delete the directory *before* running the tool; 
this way someone just running the tool once does not pay the price of waiting 
for the directory delete
   
   It would also be good to have a jira issue for this



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org