Re: [VOTE] Release Apache Feature Model 1.2.2, Feature Model Analyser 1.3.0, Feature Model Launcher 1.1.4, slingfeature-maven-plugin 1.3.6

[David Bosschaert]

+1

David

On Thu, 18 Jun 2020 at 17:13, Karl Pauls  wrote:

> +1
>
> regards,
>
> Karl
>
> On Thursday, June 18, 2020, Carsten Ziegeler  wrote:
>
> > +1
> >
> > Carsten
> >
> > Am 18.06.2020 um 17:54 schrieb dav...@apache.org:
> >
> >> Hi all,
> >>
> >> I would like to call the release on the following Sling Apache
> components:
> >>
> >> Feature Model 1.2.2
> >> https://issues.apache.org/jira/projects/SLING/versions/12348205
> >>
> >> Feature Model Analyser 1.3.0
> >> https://issues.apache.org/jira/projects/SLING/versions/12347161
> >>
> >> Feature Model Launcher 1.1.4
> >> https://issues.apache.org/jira/projects/SLING/versions/12346852
> >>
> >> slingfeature-maven-plugin 1.3.6
> >> https://issues.apache.org/jira/projects/SLING/versions/12348320
> >>
> >> Staging repository:
> >> https://repository.apache.org/content/repositories/orgapachesling-2287
> >>
> >> You can use this UNIX script to download the release and verify the
> >> signatures:
> >> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.
> >> git;a=blob;f=check_staged_release.sh;hb=HEAD
> >>
> >> Usage:
> >> sh check_staged_release.sh 2287 /tmp/sling-staging
> >>
> >> Please vote to approve this release:
> >>
> >> [ ] +1 Approve the release
> >> [ ] -1 Don't release, because ...
> >>
> >> This majority vote is open for at least 72 hours.
> >>
> >> Best regards,
> >>
> >> David
> >>
> >>
> > --
> > --
> > Carsten Ziegeler
> > Adobe Research Switzerland
> > cziege...@apache.org
> >
>
>
> --
> Karl Pauls
> karlpa...@gmail.com
>

Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.2.6-1.4.0, Apache Sling Scripting HTL Engine 1.4.0-1.4.0, Apache Sling Scripting HTL Java Compiler 1.2.0-1.4.0, Apache Sling JSPC Maven Plugin

[David Bosschaert]

+1

David

On Thu, 18 Jun 2020 at 17:42, Radu Cotescu  wrote:

> And here’s my +1 as well.
>
> I know that there are a lot of issues and releases.
> https://issues.apache.org/jira/browse/SLING-9207 <
> https://issues.apache.org/jira/browse/SLING-9207> provides a good
> overview of what Karl and I have been working on.
>
> Since I will be on holiday until July 6th, Karl will promote the releases
> if the vote will be successful.
>
> Kind regards,
> Radu
>
> > On 18 Jun 2020, at 18:12, Radu Cotescu  wrote:
> >
> > Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
>
>

Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.2.6-1.4.0, Apache Sling Scripting HTL Engine 1.4.0-1.4.0, Apache Sling Scripting HTL Java Compiler 1.2.0-1.4.0, Apache Sling JSPC Maven Plugin

[Radu Cotescu]

And here’s my +1 as well.

I know that there are a lot of issues and releases. 
https://issues.apache.org/jira/browse/SLING-9207 
 provides a good overview of 
what Karl and I have been working on.

Since I will be on holiday until July 6th, Karl will promote the releases if 
the vote will be successful.

Kind regards,
Radu

> On 18 Jun 2020, at 18:12, Radu Cotescu  wrote:
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.

Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.2.6-1.4.0, Apache Sling Scripting HTL Engine 1.4.0-1.4.0, Apache Sling Scripting HTL Java Compiler 1.2.0-1.4.0, Apache Sling JSPC Maven Plugin

[Carsten Ziegeler]

+1

Carsten

Am 18.06.2020 um 18:16 schrieb Karl Pauls:

+1

regards,

Karl

On Thursday, June 18, 2020, Radu Cotescu  wrote:


Hi,

We solved 51 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348062
https://issues.apache.org/jira/browse/SLING/fixforversion/12346951
https://issues.apache.org/jira/browse/SLING/fixforversion/12347141
https://issues.apache.org/jira/browse/SLING/fixforversion/12347153
https://issues.apache.org/jira/browse/SLING/fixforversion/12346596
https://issues.apache.org/jira/browse/SLING/fixforversion/12347853
https://issues.apache.org/jira/browse/SLING/fixforversion/12348043
https://issues.apache.org/jira/browse/SLING/fixforversion/12347745
https://issues.apache.org/jira/browse/SLING/fixforversion/12347030
https://issues.apache.org/jira/browse/SLING/fixforversion/12347157
https://issues.apache.org/jira/browse/SLING/fixforversion/12346635
https://issues.apache.org/jira/browse/SLING/fixforversion/12348063

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2286/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-
release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2286 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Radu Cotescu






--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[RESULT][VOTE] Release Apache Sling GraphQL Core 0.0.2, Servlet Helpers 1.4.2

[Bertrand Delacretaz]

Hi,

On Mon, Jun 15, 2020 at 5:25 PM Bertrand Delacretaz
 wrote:
> ...Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2279/ ...

the vote passes with +1s from Robert, Nicolas and myself and no other
votes. Thank you!

I'll finalize the release.

-Bertrand

Re: [VOTE] Release Apache Sling Scripting HTL Compiler 1.2.6-1.4.0, Apache Sling Scripting HTL Engine 1.4.0-1.4.0, Apache Sling Scripting HTL Java Compiler 1.2.0-1.4.0, Apache Sling JSPC Maven Plugin

[Karl Pauls]

+1

regards,

Karl

On Thursday, June 18, 2020, Radu Cotescu  wrote:

> Hi,
>
> We solved 51 issues in these releases:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348062
> https://issues.apache.org/jira/browse/SLING/fixforversion/12346951
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347141
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347153
> https://issues.apache.org/jira/browse/SLING/fixforversion/12346596
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347853
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348043
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347745
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347030
> https://issues.apache.org/jira/browse/SLING/fixforversion/12347157
> https://issues.apache.org/jira/browse/SLING/fixforversion/12346635
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348063
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2286/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-
> release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2286 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Radu Cotescu
>


-- 
Karl Pauls
karlpa...@gmail.com

Re: [VOTE] Release Apache Sling Commons Log 5.1.12

[Karl Pauls]

+1

regards,

Karl

On Thursday, June 18, 2020, Carsten Ziegeler  wrote:

> +1
>
> Carsten
>
> Am 18.06.2020 um 12:28 schrieb Robert Munteanu:
>
>> Hi,
>>
>> We solved 1 issue in this release:
>> https://issues.apache.org/jira/browse/SLING/fixforversion/12344069
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2281/
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.
>> git;a=blob;f=check_staged_release.sh;hb=HEAD
>>
>> Usage:
>> sh check_staged_release.sh 2281 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>>[ ] +1 Approve the release
>>[ ]  0 Don't care
>>[ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>> Regards,
>> Robert Munteanu
>>
>>
> --
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>


-- 
Karl Pauls
karlpa...@gmail.com

Re: [VOTE] Release Apache Sling JCR Resource 3.0.22

[Karl Pauls]

+1

regards,

Karl

On Thursday, June 18, 2020, Timothee Maret  wrote:

> +1
>
> Regards,
>
> Timothee
>
> Le jeu. 18 juin 2020 à 14:01, Robert Munteanu  a
> écrit :
>
> > Hi,
> >
> > We solved 2 issues in this release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12348252
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2285/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-
> release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2285 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards,
> > Robert Munteanu
> >
>


-- 
Karl Pauls
karlpa...@gmail.com

[VOTE] Release Apache Sling Scripting HTL Compiler 1.2.6-1.4.0, Apache Sling Scripting HTL Engine 1.4.0-1.4.0, Apache Sling Scripting HTL Java Compiler 1.2.0-1.4.0, Apache Sling JSPC Maven Plugin 2.2.

[Radu Cotescu]

Hi,

We solved 51 issues in these releases:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348062
https://issues.apache.org/jira/browse/SLING/fixforversion/12346951
https://issues.apache.org/jira/browse/SLING/fixforversion/12347141
https://issues.apache.org/jira/browse/SLING/fixforversion/12347153
https://issues.apache.org/jira/browse/SLING/fixforversion/12346596
https://issues.apache.org/jira/browse/SLING/fixforversion/12347853
https://issues.apache.org/jira/browse/SLING/fixforversion/12348043
https://issues.apache.org/jira/browse/SLING/fixforversion/12347745
https://issues.apache.org/jira/browse/SLING/fixforversion/12347030
https://issues.apache.org/jira/browse/SLING/fixforversion/12347157
https://issues.apache.org/jira/browse/SLING/fixforversion/12346635
https://issues.apache.org/jira/browse/SLING/fixforversion/12348063

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2286/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2286 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Radu Cotescu

Re: [VOTE] Release Apache Feature Model 1.2.2, Feature Model Analyser 1.3.0, Feature Model Launcher 1.1.4, slingfeature-maven-plugin 1.3.6

[Karl Pauls]

+1

regards,

Karl

On Thursday, June 18, 2020, Carsten Ziegeler  wrote:

> +1
>
> Carsten
>
> Am 18.06.2020 um 17:54 schrieb dav...@apache.org:
>
>> Hi all,
>>
>> I would like to call the release on the following Sling Apache components:
>>
>> Feature Model 1.2.2
>> https://issues.apache.org/jira/projects/SLING/versions/12348205
>>
>> Feature Model Analyser 1.3.0
>> https://issues.apache.org/jira/projects/SLING/versions/12347161
>>
>> Feature Model Launcher 1.1.4
>> https://issues.apache.org/jira/projects/SLING/versions/12346852
>>
>> slingfeature-maven-plugin 1.3.6
>> https://issues.apache.org/jira/projects/SLING/versions/12348320
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2287
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.
>> git;a=blob;f=check_staged_release.sh;hb=HEAD
>>
>> Usage:
>> sh check_staged_release.sh 2287 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>> [ ] +1 Approve the release
>> [ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>> Best regards,
>>
>> David
>>
>>
> --
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>


-- 
Karl Pauls
karlpa...@gmail.com

Re: [VOTE] Release Apache Feature Model 1.2.2, Feature Model Analyser 1.3.0, Feature Model Launcher 1.1.4, slingfeature-maven-plugin 1.3.6

[Carsten Ziegeler]

+1

Carsten

Am 18.06.2020 um 17:54 schrieb dav...@apache.org:

Hi all,

I would like to call the release on the following Sling Apache components:

Feature Model 1.2.2
https://issues.apache.org/jira/projects/SLING/versions/12348205

Feature Model Analyser 1.3.0
https://issues.apache.org/jira/projects/SLING/versions/12347161

Feature Model Launcher 1.1.4
https://issues.apache.org/jira/projects/SLING/versions/12346852

slingfeature-maven-plugin 1.3.6
https://issues.apache.org/jira/projects/SLING/versions/12348320

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2287

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2287 /tmp/sling-staging

Please vote to approve this release:

[ ] +1 Approve the release
[ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards,

David



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Feature Model 1.2.2, Feature Model Analyser 1.3.0, Feature Model Launcher 1.1.4, slingfeature-maven-plugin 1.3.6

[davidb]

Hi all,

I would like to call the release on the following Sling Apache components:

Feature Model 1.2.2
https://issues.apache.org/jira/projects/SLING/versions/12348205

Feature Model Analyser 1.3.0
https://issues.apache.org/jira/projects/SLING/versions/12347161

Feature Model Launcher 1.1.4
https://issues.apache.org/jira/projects/SLING/versions/12346852

slingfeature-maven-plugin 1.3.6
https://issues.apache.org/jira/projects/SLING/versions/12348320

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2287

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2287 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards,

David

[jira] [Updated] (SLING-9532) Feature Model does not accept variables containing dash

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9532:
--
Fix Version/s: Feature Model 1.2.2

> Feature Model does not accept variables containing dash
> ---
>
> Key: SLING-9532
> URL: https://issues.apache.org/jira/browse/SLING-9532
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.0
>Reporter: Dirk Rudolph
>Priority: Minor
> Fix For: Feature Model 1.2.2
>
>
> From the regular expression {{${[a-zA-Z0-9.-_]+}}} [1] I assume that all 
> _lowercase_, all _uppercase characters_, _numbers_, _dot_, _dash_ and 
> _underscore_ should be allowed.
> The documentation and schema are not clear about this, but if the assumption 
> is right the regex needs to escape the dash otherwise it means all characters 
> starting at _dot_ till _underscore_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9532) Feature Model does not accept variables containing dash

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert resolved SLING-9532.
---
  Assignee: Dirk Rudolph
Resolution: Fixed

> Feature Model does not accept variables containing dash
> ---
>
> Key: SLING-9532
> URL: https://issues.apache.org/jira/browse/SLING-9532
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.0
>Reporter: Dirk Rudolph
>Assignee: Dirk Rudolph
>Priority: Minor
> Fix For: Feature Model 1.2.2
>
>
> From the regular expression {{${[a-zA-Z0-9.-_]+}}} [1] I assume that all 
> _lowercase_, all _uppercase characters_, _numbers_, _dot_, _dash_ and 
> _underscore_ should be allowed.
> The documentation and schema are not clear about this, but if the assumption 
> is right the regex needs to escape the dash otherwise it means all characters 
> starting at _dot_ till _underscore_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature] bosschaert merged pull request #19: SLING-9532: escaped dash in the regex validating variable names

[GitBox]

bosschaert merged pull request #19:
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/19


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature] bosschaert commented on pull request #19: SLING-9532: escaped dash in the regex validating variable names

[GitBox]

bosschaert commented on pull request #19:
URL: 
https://github.com/apache/sling-org-apache-sling-feature/pull/19#issuecomment-646084493


   LGTM, thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9533) NPE in DistributionSubscriber

[Christian Schneider (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider resolved SLING-9533.

Resolution: Fixed

> NPE in DistributionSubscriber
> -
>
> Key: SLING-9533
> URL: https://issues.apache.org/jira/browse/SLING-9533
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.16
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> We sometimes see the NPE below. It happens because we start the poller before 
> the pkgType is set.
> 18.06.2020 10:12:54.734 *WARN* [Message Poller [class 
> org.apache.sling.distribution.journal.messages.Messages$PackageMessage]] 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller Exception in 
> Poller for 
> http://replication-it-aem-pipeline-proxy/v2/topics/aemdistribution_package/messages?group=64b6fdf5-36a5-4eb3-b291-3e4dbfe5bd71=0%3A163886559=earliest=aem-ns-team-aemdevreplication-replication-it=0-0-----:
>  null
> java.lang.NullPointerException: null
>  at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.shouldEnqueue(DistributionSubscriber.java:343)
>  [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]
>  at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.handlePackageMessage(DistributionSubscriber.java:326)
>  [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]
>  at 
> org.apache.sling.distribution.journal.HandlerAdapter.handle(HandlerAdapter.java:54)
>  [org.apache.sling.distribution.journal.messages:0.1.3.T2020228041644-6b0d26b]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.handlePayload(MessagePoller.java:166)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.processMessage(MessagePoller.java:145)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.consume(MessagePoller.java:124)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.ActivityTracker.meter(ActivityTracker.java:72)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.run(MessagePoller.java:88)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at java.base/java.lang.Thread.run(Thread.java:834)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9533) NPE in DistributionSubscriber

[Christian Schneider (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated SLING-9533:
---
Fix Version/s: (was: Content Distribution Journal Core 0.1.16)
   Content Distribution Journal Core 0.1.18

> NPE in DistributionSubscriber
> -
>
> Key: SLING-9533
> URL: https://issues.apache.org/jira/browse/SLING-9533
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.10
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> We sometimes see the NPE below. It happens because we start the poller before 
> the pkgType is set.
> 18.06.2020 10:12:54.734 *WARN* [Message Poller [class 
> org.apache.sling.distribution.journal.messages.Messages$PackageMessage]] 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller Exception in 
> Poller for 
> http://replication-it-aem-pipeline-proxy/v2/topics/aemdistribution_package/messages?group=64b6fdf5-36a5-4eb3-b291-3e4dbfe5bd71=0%3A163886559=earliest=aem-ns-team-aemdevreplication-replication-it=0-0-----:
>  null
> java.lang.NullPointerException: null
>  at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.shouldEnqueue(DistributionSubscriber.java:343)
>  [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]
>  at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.handlePackageMessage(DistributionSubscriber.java:326)
>  [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]
>  at 
> org.apache.sling.distribution.journal.HandlerAdapter.handle(HandlerAdapter.java:54)
>  [org.apache.sling.distribution.journal.messages:0.1.3.T2020228041644-6b0d26b]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.handlePayload(MessagePoller.java:166)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.processMessage(MessagePoller.java:145)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.consume(MessagePoller.java:124)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.ActivityTracker.meter(ActivityTracker.java:72)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.run(MessagePoller.java:88)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at java.base/java.lang.Thread.run(Thread.java:834)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9533) NPE in DistributionSubscriber

[Christian Schneider (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated SLING-9533:
---
Affects Version/s: (was: Content Distribution Journal Core 0.1.10)
   Content Distribution Journal Core 0.1.16

> NPE in DistributionSubscriber
> -
>
> Key: SLING-9533
> URL: https://issues.apache.org/jira/browse/SLING-9533
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.16
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.18
>
>
> We sometimes see the NPE below. It happens because we start the poller before 
> the pkgType is set.
> 18.06.2020 10:12:54.734 *WARN* [Message Poller [class 
> org.apache.sling.distribution.journal.messages.Messages$PackageMessage]] 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller Exception in 
> Poller for 
> http://replication-it-aem-pipeline-proxy/v2/topics/aemdistribution_package/messages?group=64b6fdf5-36a5-4eb3-b291-3e4dbfe5bd71=0%3A163886559=earliest=aem-ns-team-aemdevreplication-replication-it=0-0-----:
>  null
> java.lang.NullPointerException: null
>  at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.shouldEnqueue(DistributionSubscriber.java:343)
>  [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]
>  at 
> org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.handlePackageMessage(DistributionSubscriber.java:326)
>  [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]
>  at 
> org.apache.sling.distribution.journal.HandlerAdapter.handle(HandlerAdapter.java:54)
>  [org.apache.sling.distribution.journal.messages:0.1.3.T2020228041644-6b0d26b]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.handlePayload(MessagePoller.java:166)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.processMessage(MessagePoller.java:145)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.consume(MessagePoller.java:124)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.ActivityTracker.meter(ActivityTracker.java:72)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at 
> com.adobe.granite.distribution.journal.pipeline.MessagePoller.run(MessagePoller.java:88)
>  [com.adobe.granite.distribution.journal.pipeline:0.0.40]
>  at java.base/java.lang.Thread.run(Thread.java:834)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9533) NPE in DistributionSubscriber

[Christian Schneider (Jira)]

Christian Schneider created SLING-9533:
--

 Summary: NPE in DistributionSubscriber
 Key: SLING-9533
 URL: https://issues.apache.org/jira/browse/SLING-9533
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Affects Versions: Content Distribution Journal Core 0.1.10
Reporter: Christian Schneider
Assignee: Christian Schneider
 Fix For: Content Distribution Journal Core 0.1.16


We sometimes see the NPE below. It happens because we start the poller before 
the pkgType is set.

18.06.2020 10:12:54.734 *WARN* [Message Poller [class 
org.apache.sling.distribution.journal.messages.Messages$PackageMessage]] 
com.adobe.granite.distribution.journal.pipeline.MessagePoller Exception in 
Poller for 
http://replication-it-aem-pipeline-proxy/v2/topics/aemdistribution_package/messages?group=64b6fdf5-36a5-4eb3-b291-3e4dbfe5bd71=0%3A163886559=earliest=aem-ns-team-aemdevreplication-replication-it=0-0-----:
 null

java.lang.NullPointerException: null

 at 
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.shouldEnqueue(DistributionSubscriber.java:343)
 [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]

 at 
org.apache.sling.distribution.journal.impl.subscriber.DistributionSubscriber.handlePackageMessage(DistributionSubscriber.java:326)
 [org.apache.sling.distribution.journal:0.1.15.T20200603-93a8248]

 at 
org.apache.sling.distribution.journal.HandlerAdapter.handle(HandlerAdapter.java:54)
 [org.apache.sling.distribution.journal.messages:0.1.3.T2020228041644-6b0d26b]

 at 
com.adobe.granite.distribution.journal.pipeline.MessagePoller.handlePayload(MessagePoller.java:166)
 [com.adobe.granite.distribution.journal.pipeline:0.0.40]

 at 
com.adobe.granite.distribution.journal.pipeline.MessagePoller.processMessage(MessagePoller.java:145)
 [com.adobe.granite.distribution.journal.pipeline:0.0.40]

 at 
com.adobe.granite.distribution.journal.pipeline.MessagePoller.consume(MessagePoller.java:124)
 [com.adobe.granite.distribution.journal.pipeline:0.0.40]

 at 
com.adobe.granite.distribution.journal.pipeline.ActivityTracker.meter(ActivityTracker.java:72)
 [com.adobe.granite.distribution.journal.pipeline:0.0.40]

 at 
com.adobe.granite.distribution.journal.pipeline.MessagePoller.run(MessagePoller.java:88)
 [com.adobe.granite.distribution.journal.pipeline:0.0.40]

 at java.base/java.lang.Thread.run(Thread.java:834)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9522) Site documentation for Feature Model

[Gaston Gonzalez (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139472#comment-17139472
 ] 

Gaston Gonzalez commented on SLING-9522:


[~bdelacretaz] - Thanks for reviewing, approving and merging the PR. Your 
tweaks look good.

> Site documentation for Feature Model
> 
>
> Key: SLING-9522
> URL: https://issues.apache.org/jira/browse/SLING-9522
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Gaston Gonzalez
>Priority: Trivial
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> While working on the Sling Kickstart Launcher, our team wrote a series of 
> how-to documents around the Feature Model under the sling-site GitHub 
> project. 
> PR: [https://github.com/apache/sling-site/pull/48]
>  
> We'd like to contribute the series and expand on the how-to documents, but 
> would appreciate some feedback first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Prevent Default Sling Post servlet from ever processing certain requests

[Ruben Reusser]

on the same line: is it possible to restrict what jcr:primaryType and 
what sling:resourceType is allowed to be created by the post servlet or 
even more in general?


On 6/18/2020 6:38 AM, Konrad Windszus wrote:

That already comes close, but I was more thinking about a dedicated operation 
which indicates, that a required specialized servlet is missing. That could by 
default return a status 500 with a reasonable error message (so only one 
parameter necessary).
I created https://issues.apache.org/jira/browse/SLING-9531 
 to track that.
Thanks for your input,
Konrad


On 18. Jun 2020, at 15:30, Karl Pauls  wrote:

https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations-1

obviously, that only helps if you have the client under your control.

regards,

Karl

On Thursday, June 18, 2020, Karl Pauls  wrote:


I guess you could add a nop operation.

regards,

Karl

On Thursday, June 18, 2020, Bertrand Delacretaz 
wrote:


On Thu, Jun 18, 2020 at 2:46 PM Konrad Windszus
 wrote:

...Is there a simple way (like a certain parameter or request path

format) which prevents the

Sling POST servlet from responding?...

Not that I know, but my memory is bad for such things.


If not, do you think that this would be a useful addition?

I think so - maybe something like the PathBasedAcceptor [1] created
for SLING-8110 could help set stricter requirements for that default
servlet to execute.

-Bertrand

[1] https://github.com/apache/sling-org-apache-sling-servlets-
resolver/blob/master/src/main/java/org/apache/sling/
servlets/resolver/internal/PathBasedServletAcceptor.java



--
Karl Pauls
karlpa...@gmail.com



--
Karl Pauls
karlpa...@gmail.com

[GitHub] [sling-org-apache-sling-feature] sonarcloud[bot] commented on pull request #19: SLING-9532: escaped dash in the regex validating variable names

[GitBox]

sonarcloud[bot] commented on pull request #19:
URL: 
https://github.com/apache/sling-org-apache-sling-feature/pull/19#issuecomment-646037520


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature=19=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature=19=new_coverage=list)
 [100.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature=19=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature=19=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature=19=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9207) Unify the support for bundled scripts

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9207.
-
Resolution: Fixed

All child issues have been marked as resolved.

> Unify the support for bundled scripts
> -
>
> Key: SLING-9207
> URL: https://issues.apache.org/jira/browse/SLING-9207
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes, Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: HTL Maven Plugin 2.0.0-1.4.0, Scripting JSP 2.5.0, 
> Scripting HTL Engine 1.4.0-1.4.0, Commons Compiler 2.4.0, Scripting HTL Java 
> Compiler 1.2.0-1.4.0, JSPC Maven Plugin 2.2.0, Scripting Bundle Maven Plugin 
> 0.2.0, Servlets Resolver 2.6.6, Scripting Core 2.2.2, Scripting HTL JS Use 
> Provider 1.2.0
>
>
> This issue serves as a container issue for the work needed to enable unified 
> support bundled scripts in the JSP and HTL script engines.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature] Buuhuu opened a new pull request #19: SLING-9532: escaped dash in the regex validating variable names

[GitBox]

Buuhuu opened a new pull request #19:
URL: https://github.com/apache/sling-org-apache-sling-feature/pull/19


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-8814) Create metrics for number of compilations

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-8814:

Fix Version/s: (was: Commons Compiler 2.3.8)
   Commons Compiler 2.5.0

> Create metrics for number of compilations
> -
>
> Key: SLING-8814
> URL: https://issues.apache.org/jira/browse/SLING-8814
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Commons Compiler 2.5.0
>
>
> A high number of compilations can impact the system performance negatively. 
> Additionally, there may be scenarios where compilation should never have 
> happened, e.g. scripts were precompiled using Maven tooling or a warmup phase 
> was executed.
> We should track the number of compilation events as a metrics to expose these 
> kinds of issues.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-8323) Use the JDK-provided JavaCompiler API instead of the Eclipse one

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-8323:

Fix Version/s: (was: Commons Compiler 2.3.8)
   Commons Compiler 2.5.0

> Use the JDK-provided JavaCompiler API instead of the Eclipse one
> 
>
> Key: SLING-8323
> URL: https://issues.apache.org/jira/browse/SLING-8323
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Commons Compiler 2.5.0
>
>
> Using the Eclipse compiler API works fine, with two minor caveats:
> - the dependency must be upgraded periodically to get support for newer Java 
> versions
> - we need to embed ecj (~2.7M)
> Since Java 7 the 
> [JavaCompiler|https://docs.oracle.com/javase/7/docs/api/javax/tools/JavaCompiler.html]
>  API allows programmatic access to the system java compiler. We should 
> instead try and use this compiler.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9207) Unify the support for bundled scripts

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-9207:

Fix Version/s: (was: Commons Compiler 2.3.8)
   Commons Compiler 2.4.0

> Unify the support for bundled scripts
> -
>
> Key: SLING-9207
> URL: https://issues.apache.org/jira/browse/SLING-9207
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes, Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: HTL Maven Plugin 2.0.0-1.4.0, Scripting JSP 2.5.0, 
> Scripting HTL Engine 1.4.0-1.4.0, Commons Compiler 2.4.0, Scripting HTL Java 
> Compiler 1.2.0-1.4.0, JSPC Maven Plugin 2.2.0, Scripting Bundle Maven Plugin 
> 0.2.0, Servlets Resolver 2.6.6, Scripting Core 2.2.2, Scripting HTL JS Use 
> Provider 1.2.0
>
>
> This issue serves as a container issue for the work needed to enable unified 
> support bundled scripts in the JSP and HTL script engines.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9532) Feature Model does not accept variables containing dash

[Dirk Rudolph (Jira)]

Dirk Rudolph created SLING-9532:
---

 Summary: Feature Model does not accept variables containing dash
 Key: SLING-9532
 URL: https://issues.apache.org/jira/browse/SLING-9532
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model 1.2.0
Reporter: Dirk Rudolph


>From the regular expression {{${[a-zA-Z0-9.-_]+}}} [1] I assume that all 
>_lowercase_, all _uppercase characters_, _numbers_, _dot_, _dash_ and 
>_underscore_ should be allowed.

The documentation and schema are not clear about this, but if the assumption is 
right the regex needs to escape the dash otherwise it means all characters 
starting at _dot_ till _underscore_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9532) Feature Model does not accept variables containing dash

[Dirk Rudolph (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dirk Rudolph updated SLING-9532:

Priority: Minor  (was: Major)

> Feature Model does not accept variables containing dash
> ---
>
> Key: SLING-9532
> URL: https://issues.apache.org/jira/browse/SLING-9532
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.0
>Reporter: Dirk Rudolph
>Priority: Minor
>
> From the regular expression {{${[a-zA-Z0-9.-_]+}}} [1] I assume that all 
> _lowercase_, all _uppercase characters_, _numbers_, _dot_, _dash_ and 
> _underscore_ should be allowed.
> The documentation and schema are not clear about this, but if the assumption 
> is right the regex needs to escape the dash otherwise it means all characters 
> starting at _dot_ till _underscore_.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9440) Clean up usage of constants

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-9440:
---
Description: There are a lot of constants being referenced from Jackrabbit. 
To make it clearer which parts are Jackrabbit-specific the constants from the 
JCR 2.0 namespace should be prefered (also they don't rely on any prefixes as 
they always use fully-qualified names).  (was: There are a lot of constants 
being referenced from Jackrabbit. To make it clearer which parts are 
Jackrabbit-specific the constants from the JCR 2.0 namespace should be prefered 
(also they don't refer on any prefixes as they always use fully-qualified 
names).)

> Clean up usage of constants
> ---
>
> Key: SLING-9440
> URL: https://issues.apache.org/jira/browse/SLING-9440
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Minor
> Fix For: JCR Resource 3.0.22
>
>
> There are a lot of constants being referenced from Jackrabbit. To make it 
> clearer which parts are Jackrabbit-specific the constants from the JCR 2.0 
> namespace should be prefered (also they don't rely on any prefixes as they 
> always use fully-qualified names).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Prevent Default Sling Post servlet from ever processing certain requests

[Konrad Windszus]

That already comes close, but I was more thinking about a dedicated operation 
which indicates, that a required specialized servlet is missing. That could by 
default return a status 500 with a reasonable error message (so only one 
parameter necessary).
I created https://issues.apache.org/jira/browse/SLING-9531 
 to track that.
Thanks for your input,
Konrad

> On 18. Jun 2020, at 15:30, Karl Pauls  wrote:
> 
> https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations-1
> 
> obviously, that only helps if you have the client under your control.
> 
> regards,
> 
> Karl
> 
> On Thursday, June 18, 2020, Karl Pauls  wrote:
> 
>> I guess you could add a nop operation.
>> 
>> regards,
>> 
>> Karl
>> 
>> On Thursday, June 18, 2020, Bertrand Delacretaz 
>> wrote:
>> 
>>> On Thu, Jun 18, 2020 at 2:46 PM Konrad Windszus
>>>  wrote:
 ...Is there a simple way (like a certain parameter or request path
>>> format) which prevents the
 Sling POST servlet from responding?...
>>> 
>>> Not that I know, but my memory is bad for such things.
>>> 
 If not, do you think that this would be a useful addition?
>>> 
>>> I think so - maybe something like the PathBasedAcceptor [1] created
>>> for SLING-8110 could help set stricter requirements for that default
>>> servlet to execute.
>>> 
>>> -Bertrand
>>> 
>>> [1] https://github.com/apache/sling-org-apache-sling-servlets-
>>> resolver/blob/master/src/main/java/org/apache/sling/
>>> servlets/resolver/internal/PathBasedServletAcceptor.java
>>> 
>> 
>> 
>> --
>> Karl Pauls
>> karlpa...@gmail.com
>> 
>> 
> 
> -- 
> Karl Pauls
> karlpa...@gmail.com

[jira] [Assigned] (SLING-9531) Add operation which indicates that a more specific servlet is needed

[Konrad Windszus (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-9531:
--

Assignee: Konrad Windszus

> Add operation which indicates that a more specific servlet is needed
> 
>
> Key: SLING-9531
> URL: https://issues.apache.org/jira/browse/SLING-9531
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Affects Versions: Servlets Post 2.3.36
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Servlets POST 2.3.38
>
>
> Very often POST servlets rely on OSGi DS which is dynamic. If for whatever 
> reason the specialized servlet component is not running, Sling falls back to 
> the Default POST Servlet. That is very often not intended. To prevent the 
> Default POST Servlet from doing any repository modification operations a new 
> operation should be added which leads to a 500 error and the status message, 
> that a more specific servlet is necessary.
> Compare with the discussion from 
> https://lists.apache.org/thread.html/r00d54024759efe1f0456008e21a994f5bafe512bf65ff9bc1c767999%40%3Cdev.sling.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9531) Add operation which indicates that a more specific servlet is needed

[Konrad Windszus (Jira)]

Konrad Windszus created SLING-9531:
--

 Summary: Add operation which indicates that a more specific 
servlet is needed
 Key: SLING-9531
 URL: https://issues.apache.org/jira/browse/SLING-9531
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
Affects Versions: Servlets Post 2.3.36
Reporter: Konrad Windszus
 Fix For: Servlets POST 2.3.38


Very often POST servlets rely on OSGi DS which is dynamic. If for whatever 
reason the specialized servlet component is not running, Sling falls back to 
the Default POST Servlet. That is very often not intended. To prevent the 
Default POST Servlet from doing any repository modification operations a new 
operation should be added which leads to a 500 error and the status message, 
that a more specific servlet is necessary.

Compare with the discussion from 
https://lists.apache.org/thread.html/r00d54024759efe1f0456008e21a994f5bafe512bf65ff9bc1c767999%40%3Cdev.sling.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Prevent Default Sling Post servlet from ever processing certain requests

[Karl Pauls]

https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations-1

obviously, that only helps if you have the client under your control.

regards,

Karl

On Thursday, June 18, 2020, Karl Pauls  wrote:

> I guess you could add a nop operation.
>
> regards,
>
> Karl
>
> On Thursday, June 18, 2020, Bertrand Delacretaz 
> wrote:
>
>> On Thu, Jun 18, 2020 at 2:46 PM Konrad Windszus
>>  wrote:
>> > ...Is there a simple way (like a certain parameter or request path
>> format) which prevents the
>> > Sling POST servlet from responding?...
>>
>> Not that I know, but my memory is bad for such things.
>>
>> > If not, do you think that this would be a useful addition?
>>
>> I think so - maybe something like the PathBasedAcceptor [1] created
>> for SLING-8110 could help set stricter requirements for that default
>> servlet to execute.
>>
>> -Bertrand
>>
>> [1] https://github.com/apache/sling-org-apache-sling-servlets-
>> resolver/blob/master/src/main/java/org/apache/sling/
>> servlets/resolver/internal/PathBasedServletAcceptor.java
>>
>
>
> --
> Karl Pauls
> karlpa...@gmail.com
>
>

-- 
Karl Pauls
karlpa...@gmail.com

Re: Prevent Default Sling Post servlet from ever processing certain requests

[Konrad Windszus]

I figured out that giving a parameter ":operation" with any invalid value 
should do the job 
(https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations).
 That will lead to a 500 status no modification in the repo.
The error message is not very verbose though, but good enough for my purpose.
Alternatively one can use "nop" as value for ":operation" together with 
parameter ":nopstatus" set to 500.

> On 18. Jun 2020, at 15:27, Bertrand Delacretaz  wrote:
> 
> On Thu, Jun 18, 2020 at 2:46 PM Konrad Windszus
>  wrote:
>> ...Is there a simple way (like a certain parameter or request path format) 
>> which prevents the
>> Sling POST servlet from responding?...
> 
> Not that I know, but my memory is bad for such things.
> 
>> If not, do you think that this would be a useful addition?
> 
> I think so - maybe something like the PathBasedAcceptor [1] created
> for SLING-8110 could help set stricter requirements for that default
> servlet to execute.
> 
> -Bertrand
> 
> [1] 
> https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/master/src/main/java/org/apache/sling/servlets/resolver/internal/PathBasedServletAcceptor.java

Re: Prevent Default Sling Post servlet from ever processing certain requests

[Karl Pauls]

I guess you could add a nop operation.

regards,

Karl

On Thursday, June 18, 2020, Bertrand Delacretaz 
wrote:

> On Thu, Jun 18, 2020 at 2:46 PM Konrad Windszus
>  wrote:
> > ...Is there a simple way (like a certain parameter or request path
> format) which prevents the
> > Sling POST servlet from responding?...
>
> Not that I know, but my memory is bad for such things.
>
> > If not, do you think that this would be a useful addition?
>
> I think so - maybe something like the PathBasedAcceptor [1] created
> for SLING-8110 could help set stricter requirements for that default
> servlet to execute.
>
> -Bertrand
>
> [1] https://github.com/apache/sling-org-apache-sling-
> servlets-resolver/blob/master/src/main/java/org/apache/
> sling/servlets/resolver/internal/PathBasedServletAcceptor.java
>


-- 
Karl Pauls
karlpa...@gmail.com

Re: Prevent Default Sling Post servlet from ever processing certain requests

[Bertrand Delacretaz]

On Thu, Jun 18, 2020 at 2:46 PM Konrad Windszus
 wrote:
> ...Is there a simple way (like a certain parameter or request path format) 
> which prevents the
> Sling POST servlet from responding?...

Not that I know, but my memory is bad for such things.

> If not, do you think that this would be a useful addition?

I think so - maybe something like the PathBasedAcceptor [1] created
for SLING-8110 could help set stricter requirements for that default
servlet to execute.

-Bertrand

[1] 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/blob/master/src/main/java/org/apache/sling/servlets/resolver/internal/PathBasedServletAcceptor.java

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.1.8, Content Distribution Journal Core 0.1.16 and Content Distribution Journal ITs 0.1.2

[Carsten Ziegeler]

+1

Carsten

Am 18.06.2020 um 15:17 schrieb Christian Schneider:

+1 (non binding)

Christian

Am Do., 18. Juni 2020 um 14:11 Uhr schrieb Timothee Maret 
:



Hi,

This vote includes 3 artifacts

1. Content Distribution Journal Messages 0.1.8

We solved 1 issue in this release:

 https://issues.apache.org/jira/projects/SLING/versions/12345984

There are still outstanding issues:

 https://issues.apache.org/jira/projects/SLING/versions/12348397

2. Content Distribution Journal Core 0.1.16

We solved 15 issues in this release:

 https://issues.apache.org/jira/projects/SLING/versions/12347846

There are still outstanding issues:

 https://issues.apache.org/jira/projects/SLING/versions/12347844

3. Content Distribution Journal ITs 0.1.2

We solved 2 issues in this release:

 https://issues.apache.org/jira/projects/SLING/versions/12345419


Staging repositories:


https://repository.apache.org/content/repositories/orgapachesling-orgapachesling-2280/

https://repository.apache.org/content/repositories/orgapachesling-orgapachesling-2282/

You can use this UNIX script to download the release and verify the
signatures:

https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2280 /tmp/sling-staging
sh check_staged_release.sh 2282 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.






--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.1.8, Content Distribution Journal Core 0.1.16 and Content Distribution Journal ITs 0.1.2

[Christian Schneider]

+1 (non binding)

Christian

Am Do., 18. Juni 2020 um 14:11 Uhr schrieb Timothee Maret :

> Hi,
>
> This vote includes 3 artifacts
>
> 1. Content Distribution Journal Messages 0.1.8
>
> We solved 1 issue in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12345984
>
> There are still outstanding issues:
>
> https://issues.apache.org/jira/projects/SLING/versions/12348397
>
> 2. Content Distribution Journal Core 0.1.16
>
> We solved 15 issues in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12347846
>
> There are still outstanding issues:
>
> https://issues.apache.org/jira/projects/SLING/versions/12347844
>
> 3. Content Distribution Journal ITs 0.1.2
>
> We solved 2 issues in this release:
>
> https://issues.apache.org/jira/projects/SLING/versions/12345419
>
>
> Staging repositories:
>
>
> https://repository.apache.org/content/repositories/orgapachesling-orgapachesling-2280/
>
> https://repository.apache.org/content/repositories/orgapachesling-orgapachesling-2282/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2280 /tmp/sling-staging
> sh check_staged_release.sh 2282 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>


-- 
-- 
Christian Schneider
http://www.liquid-reality.de

Computer Scientist
http://www.adobe.com

[GitHub] [sling-org-apache-sling-feature-analyser] bdelacretaz commented on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

bdelacretaz commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-646009253


   Don't wait for this one, as Carsten says it's not useful. The corresponding 
feature is not urgent anyway, I have created 
https://issues.apache.org/jira/browse/SLING-9530 to tackle it eventually



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-analyser] bdelacretaz closed pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

bdelacretaz closed pull request #20:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-analyser] bosschaert commented on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

bosschaert commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-646007986


   Hi @bdelacretaz I was just about to kick off a release of this component. Do 
you want me to wait?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9527) Add a proper documentation page for the Scripting Bundle Maven Plugin

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139405#comment-17139405
 ] 

Konrad Windszus commented on SLING-9527:


Great, thanks. Can you deploy a first SNAPSHOT version?

> Add a proper documentation page for the Scripting Bundle Maven Plugin
> -
>
> Key: SLING-9527
> URL: https://issues.apache.org/jira/browse/SLING-9527
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.2.0
>
>
> The Scripting Bundle Maven Plugin should provide a regular Maven Plugin 
> documentation page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Prevent Default Sling Post servlet from ever processing certain requests

[Konrad Windszus]

Hi,
it is quite common that applications register custom POST servlet (via OSGi DS) 
to a certain resource type.
If that custom POST servlet component for whatever reason is not running the 
default Sling POST servlet will kick in. That is never intended and will in the 
worst case add content to the repository.

Is there a simple way (like a certain parameter or request path format) which 
prevents the Sling POST servlet from responding?
If not, do you think that this would be a useful addition?

Thanks,
Konrad

Re: [VOTE] Release Apache Sling Auth Core 1.4.8

[Timothee Maret]

+1

Regards,

Timothee

Le jeu. 18 juin 2020 à 13:45, Robert Munteanu  a écrit :

> Hi,
>
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348402
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2284/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2284 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Robert Munteanu
>

Re: [VOTE] Release Apache Sling JCR Resource 3.0.22

[Timothee Maret]

+1

Regards,

Timothee

Le jeu. 18 juin 2020 à 14:01, Robert Munteanu  a écrit :

> Hi,
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348252
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2285/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2285 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Robert Munteanu
>

Re: [VOTE] Release Apache Sling Content Distribution Journal Messages 0.1.8, Content Distribution Journal Core 0.1.16 and Content Distribution Journal ITs 0.1.2

[Robert Munteanu]

On Thu, 2020-06-18 at 14:11 +0200, Timothee Maret wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] commented on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

sonarcloud[bot] commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-645984649


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
 [84.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] removed a comment on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

sonarcloud[bot] removed a comment on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-645965870


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
 [84.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [VOTE] Release Apache Sling Auth Core 1.4.8

[Carsten Ziegeler]

+1

Carsten

Am 18.06.2020 um 13:45 schrieb Robert Munteanu:

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348402

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2284/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2284 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling JCR Resource 3.0.22

[Carsten Ziegeler]

+1

Carsten

Am 18.06.2020 um 14:00 schrieb Robert Munteanu:

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348252

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2285/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2285 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Commons Log 5.1.12

[Carsten Ziegeler]

+1

Carsten

Am 18.06.2020 um 12:28 schrieb Robert Munteanu:

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12344069

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2281/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2281 /tmp/sling-staging

Please vote to approve this release:

   [ ] +1 Approve the release
   [ ]  0 Don't care
   [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu



--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Updated] (SLING-9453) Compile jsp in parallel

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-9453:

Fix Version/s: (was: Maven JSPC Plugin 2.1.2)
   JSPC Maven Plugin 2.2.0

> Compile jsp in parallel
> ---
>
> Key: SLING-9453
> URL: https://issues.apache.org/jira/browse/SLING-9453
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.1.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.2.0
>
>
> The jspc maven plugin currently compiles scripts one at a time - we should 
> make it compile them in parallel. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release Apache Sling Content Distribution Journal Messages 0.1.8, Content Distribution Journal Core 0.1.16 and Content Distribution Journal ITs 0.1.2

[Timothee Maret]

Hi,

This vote includes 3 artifacts

1. Content Distribution Journal Messages 0.1.8

We solved 1 issue in this release:

https://issues.apache.org/jira/projects/SLING/versions/12345984

There are still outstanding issues:

https://issues.apache.org/jira/projects/SLING/versions/12348397

2. Content Distribution Journal Core 0.1.16

We solved 15 issues in this release:

https://issues.apache.org/jira/projects/SLING/versions/12347846

There are still outstanding issues:

https://issues.apache.org/jira/projects/SLING/versions/12347844

3. Content Distribution Journal ITs 0.1.2

We solved 2 issues in this release:

https://issues.apache.org/jira/projects/SLING/versions/12345419


Staging repositories:

https://repository.apache.org/content/repositories/orgapachesling-orgapachesling-2280/
https://repository.apache.org/content/repositories/orgapachesling-orgapachesling-2282/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2280 /tmp/sling-staging
sh check_staged_release.sh 2282 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[jira] [Updated] (SLING-6982) JSPC plugin should support additional resource roots

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-6982:

Fix Version/s: (was: Maven JSPC Plugin 2.1.2)
   JSPC Maven Plugin 2.2.0

> JSPC plugin should support additional resource roots
> 
>
> Key: SLING-6982
> URL: https://issues.apache.org/jira/browse/SLING-6982
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Affects Versions: Maven JSPC Plugin 2.1.0
>Reporter: Tobias Bocanegra
>Assignee: Karl Pauls
>Priority: Major
> Fix For: JSPC Maven Plugin 2.2.0
>
>
> When trying to compile JSPs that have includes to dependent resources, it is 
> not possible to compile them. you can't put the includes into the same 
> sources, otherwise they will also be compiled.
> suggestion:
> - create new property: {{resourceDirectories}} that is used during resource 
> lookup.
> example:
> {noformat}
> 
> maven-dependency-plugin
> 
> 
> extract-deps
> generate-sources
> 
> unpack-dependencies
> 
> 
> 
> cq-foundation-content
> zip
> true
> 
> ${project.build.directory}/dependencies
> 
> 
> 
> 
> 
> 
> org.apache.sling
> jspc-maven-plugin
> 2.1.1-SNAPSHOT
> 
> 
> ${project.basedir}/jcr_root
> 
> 
> ${project.build.directory}/dependencies/jcr_root
> 
> false
> false
> 1.8
> 1.8
> 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9525) Create repoinit analyser

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139367#comment-17139367
 ] 

Bertrand Delacretaz commented on SLING-9525:


Ok, created SLING-9530.

Note that the language version is available via the OSGi capability 
{{org.apache.sling.repoinit.language;version:Version="8.1"}} - there's probably 
a way to retrieve that in a non-OSGi environment, but maybe that's a bit tricky.

> Create repoinit analyser
> 
>
> Key: SLING-9525
> URL: https://issues.apache.org/jira/browse/SLING-9525
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.0, slingfeature-maven-plugin 
> 1.3.6
>
>
> It would be good to have an analyser which at least checks the syntax of 
> repoinit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9207) Unify the support for bundled scripts

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-9207:

Fix Version/s: (was: Scripting Bundle Tracker 0.2.0)
   Scripting HTL JS Use Provider 1.2.0
   Scripting Core 2.2.2
   Servlets Resolver 2.6.6
   Commons Compiler 2.3.8

> Unify the support for bundled scripts
> -
>
> Key: SLING-9207
> URL: https://issues.apache.org/jira/browse/SLING-9207
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes, Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>  Labels: Sling-12-ReleaseNotes
> Fix For: Commons Compiler 2.3.8, HTL Maven Plugin 2.0.0-1.4.0, 
> Scripting JSP 2.5.0, Scripting HTL Engine 1.4.0-1.4.0, Scripting HTL Java 
> Compiler 1.2.0-1.4.0, JSPC Maven Plugin 2.2.0, Scripting Bundle Maven Plugin 
> 0.2.0, Servlets Resolver 2.6.6, Scripting Core 2.2.2, Scripting HTL JS Use 
> Provider 1.2.0
>
>
> This issue serves as a container issue for the work needed to enable unified 
> support bundled scripts in the JSP and HTL script engines.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9530) API to get the repoinit language version

[Bertrand Delacretaz (Jira)]

Bertrand Delacretaz created SLING-9530:
--

 Summary: API to get the repoinit language version
 Key: SLING-9530
 URL: https://issues.apache.org/jira/browse/SLING-9530
 Project: Sling
  Issue Type: Wish
  Components: Repoinit
Affects Versions: Repoinit Parser 1.6.2
Reporter: Bertrand Delacretaz


For SLING-9525 in particular we should provide an API that exposes the current 
repoinit language version.

That should be the same value as the existing

{code}
Provide-Capability: org.apache.sling.repoinit.language;version:Version="8.1"}
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling JCR Resource 3.0.22

[Robert Munteanu]

On Thu, 2020-06-18 at 12:00 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert

[VOTE] Release Apache Sling JCR Resource 3.0.22

[Robert Munteanu]

Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348252

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2285/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2285 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Commented] (SLING-9525) Create repoinit analyser

[Carsten Ziegeler (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139356#comment-17139356
 ] 

Carsten Ziegeler commented on SLING-9525:
-

[~bdelacretaz] Yes, maybe something like a "language version" or something - we 
should probably handle that in new issues for the next version

> Create repoinit analyser
> 
>
> Key: SLING-9525
> URL: https://issues.apache.org/jira/browse/SLING-9525
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.0, slingfeature-maven-plugin 
> 1.3.6
>
>
> It would be good to have an analyser which at least checks the syntax of 
> repoinit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9525) Create repoinit analyser

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139354#comment-17139354
 ] 

Bertrand Delacretaz commented on SLING-9525:


I see your comment in PR20 that this won't work depending on the environment.

As the analyser is using the concrete RepoInitParserService class, the simplest 
might be to add a method to that class that returns the parser version number?

> Create repoinit analyser
> 
>
> Key: SLING-9525
> URL: https://issues.apache.org/jira/browse/SLING-9525
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.0, slingfeature-maven-plugin 
> 1.3.6
>
>
> It would be good to have an analyser which at least checks the syntax of 
> repoinit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] commented on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

sonarcloud[bot] commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-645965870


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
 [84.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] removed a comment on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

sonarcloud[bot] removed a comment on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-645945180


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
 [84.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-9529) Update auth core to parent pom 39 or newer

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-9529:
--

 Summary: Update auth core to parent pom 39 or newer
 Key: SLING-9529
 URL: https://issues.apache.org/jira/browse/SLING-9529
 Project: Sling
  Issue Type: Sub-task
  Components: Authentication
Reporter: Robert Munteanu
 Fix For: Auth Core 1.4.10






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-analyser] cziegeler commented on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

cziegeler commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-645965229


   This does not work - at runtime a different version might be used - for 
example if the analyser is used in the slingfeature maven plugin, that plugin 
defines the version to be used - and its also possible that the dependency is 
overlayed in projects by plugin users. So the only way to get the version is at 
runtime



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (SLING-9522) Site documentation for Feature Model

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139348#comment-17139348
 ] 

Bertrand Delacretaz edited comment on SLING-9522 at 6/18/20, 11:48 AM:
---

Thank you for this contribution, I have merged PR#48

With a [few 
tweaks|https://github.com/apache/sling-site/commit/b0983faf7604b33c6e55fe9db9e6095b06adfcaa],
 please cross-check (includes the following commit - forgot a page).

I have also added a link to those new docs from 
[https://github.com/apache/sling-org-apache-sling-feature]


was (Author: bdelacretaz):
Thank you for this contribution, I have merged PR#48

With a [few 
tweaks|https://github.com/apache/sling-site/commit/b0983faf7604b33c6e55fe9db9e6095b06adfcaa],
 please cross-check!

I have also added a link to those new docs from 
https://github.com/apache/sling-org-apache-sling-feature

> Site documentation for Feature Model
> 
>
> Key: SLING-9522
> URL: https://issues.apache.org/jira/browse/SLING-9522
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Gaston Gonzalez
>Priority: Trivial
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> While working on the Sling Kickstart Launcher, our team wrote a series of 
> how-to documents around the Feature Model under the sling-site GitHub 
> project. 
> PR: [https://github.com/apache/sling-site/pull/48]
>  
> We'd like to contribute the series and expand on the how-to documents, but 
> would appreciate some feedback first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9522) Site documentation for Feature Model

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139348#comment-17139348
 ] 

Bertrand Delacretaz commented on SLING-9522:


Thank you for this contribution, I have merged PR#48

With a [few 
tweaks|https://github.com/apache/sling-site/commit/b0983faf7604b33c6e55fe9db9e6095b06adfcaa],
 please cross-check!

I have also added a link to those new docs from 
https://github.com/apache/sling-org-apache-sling-feature

> Site documentation for Feature Model
> 
>
> Key: SLING-9522
> URL: https://issues.apache.org/jira/browse/SLING-9522
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Gaston Gonzalez
>Priority: Trivial
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> While working on the Sling Kickstart Launcher, our team wrote a series of 
> how-to documents around the Feature Model under the sling-site GitHub 
> project. 
> PR: [https://github.com/apache/sling-site/pull/48]
>  
> We'd like to contribute the series and expand on the how-to documents, but 
> would appreciate some feedback first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Auth Core 1.4.8

[Robert Munteanu]

On Thu, 2020-06-18 at 11:45 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling Auth Core 1.4.8

[Robert Munteanu]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348402

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2284/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2284 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

Re: [VOTE] Release Apache Sling Dynamic Include 3.2.0

[Robert Munteanu]

On Thu, 2020-06-18 at 11:37 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[VOTE] Release Apache Sling Dynamic Include 3.2.0

[Robert Munteanu]

Hi,

We solved 5 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12346080

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2283/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2283 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Updated] (SLING-8693) Additional support for Anonymous v/s loggedin user experiences

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8693:
---
Fix Version/s: (was: Dynamic Include 3.2.0)
   Dynamic Include 3.2.2

> Additional support for Anonymous v/s loggedin user experiences
> --
>
> Key: SLING-8693
> URL: https://issues.apache.org/jira/browse/SLING-8693
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Mayank Arora
>Priority: Major
> Fix For: Dynamic Include 3.2.2
>
>
> I am using SDI heavily for my current project but unable to achieve a 
> usecase.  Not sure if this is currently a product gap or something not 
> covered in documentation.
> Usecase is that there is a dynamic component on a page for which content is 
> personalized per logged-in user and returned from an API. So, I have 
> specified no-cache for this component (resource type) in SDI config.
> A variation of this usecase is if the User is not logged in, then all 
> anonymous users see static/authored content for this component, which we want 
> to cache. Traffic we are seeing is 50% anonymous v/s logged-in users, so 
> there is a great benefit if we can cache static/authored content for this 
> component for anonymous users. As per SDI configuration, I am unable to find 
> a way where for this component (specific resourceType), using SSI, I can 
> achieve no-cache for logged-in users v/s cache for anonymous users.
> Logging this as a feature request / documentation update request. Is this . 
> usecase currently possible in SDI?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-8255) Use of mappings in SDI

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8255:
---
Fix Version/s: (was: Dynamic Include 3.2.0)
   Dynamic Include 3.2.2

> Use of mappings in SDI
> --
>
> Key: SLING-8255
> URL: https://issues.apache.org/jira/browse/SLING-8255
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Dynamic Include 3.1.2
>Reporter: Michał Tobiasz
>Priority: Minor
> Fix For: Dynamic Include 3.2.2
>
>
> Hello,
> It would be great to consider using mappings for SDI. In our case, we would 
> like to configure mappings for snippets to use a different format (short 
> names).
>  
> [~rombert]  what do you think of using ResourceResolver#map when building URL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-site] bdelacretaz merged pull request #48: SLING-9522 - Added how-to series for the Feature Model

[GitBox]

bdelacretaz merged pull request #48:
URL: https://github.com/apache/sling-site/pull/48


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-analyser] sonarcloud[bot] commented on pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

sonarcloud[bot] commented on pull request #20:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20#issuecomment-645945180


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-analyser=20=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
 [84.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser=20=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9525) Create repoinit analyser

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139312#comment-17139312
 ] 

Bertrand Delacretaz commented on SLING-9525:


I have implemented the version number report using a pom variable, 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20

> Create repoinit analyser
> 
>
> Key: SLING-9525
> URL: https://issues.apache.org/jira/browse/SLING-9525
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Analyser 1.3.0, slingfeature-maven-plugin 
> 1.3.6
>
>
> It would be good to have an analyser which at least checks the syntax of 
> repoinit



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-analyser] bdelacretaz opened a new pull request #20: SLING-9525 - include repoinit parser version number in error messages

[GitBox]

bdelacretaz opened a new pull request #20:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/20


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9527) Add a proper documentation page for the Scripting Bundle Maven Plugin

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9527.
-
Resolution: Fixed

Implemented in [commit 
8e8bb41|https://github.com/apache/sling-scriptingbundle-maven-plugin/commit/8e8bb41].

> Add a proper documentation page for the Scripting Bundle Maven Plugin
> -
>
> Key: SLING-9527
> URL: https://issues.apache.org/jira/browse/SLING-9527
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.2.0
>
>
> The Scripting Bundle Maven Plugin should provide a regular Maven Plugin 
> documentation page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Commons Log 5.1.12

[Robert Munteanu]

On Thu, 2020-06-18 at 10:28 +, Robert Munteanu wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[jira] [Created] (SLING-9528) Update commons log to parent pom 39 or newer

[Robert Munteanu (Jira)]

Robert Munteanu created SLING-9528:
--

 Summary: Update commons log to parent pom 39 or newer
 Key: SLING-9528
 URL: https://issues.apache.org/jira/browse/SLING-9528
 Project: Sling
  Issue Type: Sub-task
  Components: Commons
Reporter: Robert Munteanu
 Fix For: Commons Log 5.1.14






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9527) Add a proper documentation page for the Scripting Bundle Maven Plugin

[Radu Cotescu (Jira)]

Radu Cotescu created SLING-9527:
---

 Summary: Add a proper documentation page for the Scripting Bundle 
Maven Plugin
 Key: SLING-9527
 URL: https://issues.apache.org/jira/browse/SLING-9527
 Project: Sling
  Issue Type: Improvement
  Components: Maven Plugins and Archetypes
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: Scripting Bundle Maven Plugin 0.2.0


The Scripting Bundle Maven Plugin should provide a regular Maven Plugin 
documentation page.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-8039) Inline logback jars in commons log

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8039:
---
Fix Version/s: (was: Commons Log 5.1.12)
   Commons Log 5.1.14

> Inline logback jars in commons log
> --
>
> Key: SLING-8039
> URL: https://issues.apache.org/jira/browse/SLING-8039
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Log 5.1.10
>Reporter: Karl Pauls
>Priority: Minor
> Fix For: Commons Log 5.1.14
>
>
> It be nice to inline the embeded logback-classic-1.2.3.jar and 
> logback-core-1.2.3.jar to avoid having them extracted into the bundle cache.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] Release Apache Sling Commons Log 5.1.12

[Robert Munteanu]

Hi,

We solved 1 issue in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12344069

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2281/

You can use this UNIX script to download the release and verify the signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2281 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
Robert Munteanu

[jira] [Updated] (SLING-9489) Make it possible to compare parts of feature models

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-9489:

Fix Version/s: Feature Model Analyser 1.3.0

> Make it possible to compare parts of feature models
> ---
>
> Key: SLING-9489
> URL: https://issues.apache.org/jira/browse/SLING-9489
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.3.4
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Analyser 1.3.0, slingfeature-maven-plugin 
> 1.3.6
>
>
> We need a mojo that allows the comparison of parts of a feature model. If 
> these parts are not equal the mojo should fail the build.
> Right now comparing extensions would be a good start. But comparing 
> configurations or bundles would also be good.
> Key is that not everything needs to be compared. The configuration in the 
> pom.xml should specify what is being compared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9489) Make it possible to compare parts of feature models

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert resolved SLING-9489.
---
Resolution: Fixed

> Make it possible to compare parts of feature models
> ---
>
> Key: SLING-9489
> URL: https://issues.apache.org/jira/browse/SLING-9489
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Affects Versions: slingfeature-maven-plugin 1.3.4
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.3.6
>
>
> We need a mojo that allows the comparison of parts of a feature model. If 
> these parts are not equal the mojo should fail the build.
> Right now comparing extensions would be a good start. But comparing 
> configurations or bundles would also be good.
> Key is that not everything needs to be compared. The configuration in the 
> pom.xml should specify what is being compared.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9526) Allow launching feature model applications in external processes, non-blocking

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9526:
--
Fix Version/s: (was: slingfeature-maven-plugin 1.3.6)
   slingfeature-maven-plugin 1.3.8

> Allow launching feature model applications in external processes, non-blocking
> --
>
> Key: SLING-9526
> URL: https://issues.apache.org/jira/browse/SLING-9526
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.3.8
>
>
> It is currently not easily possible to launch a FM-based application as part 
> of an integration test, as the {{slingfeature-maven-plugin:launch}} goal 
> always blocks.
> I think we should keep this goal as-is, and add two new goals:
> - start
> - stop
> The plugin can then take a list of launch configurations that will be started 
> and stopped without blocking, and used in integration tests.
> The implementation can also be a part of another plug-in, as the 
> {{slingfeature-maven-plugin}} already does quite a lot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-8938) Add an analyser for configurations inconsistent with metatype definitions

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-8938:
--
Fix Version/s: (was: Feature Model Analyser 1.3.0)
   Feature Model Analyser 1.3.2

> Add an analyser for configurations inconsistent with metatype definitions
> -
>
> Key: SLING-8938
> URL: https://issues.apache.org/jira/browse/SLING-8938
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 1.3.2
>
>
> As discussed at 
> https://lists.apache.org/thread.html/11dbeb5233afafd56474c2138eb953da1f6dcd03d3e2c8b07bfaadb3%40%3Cdev.sling.apache.org%3E,
>  we should add a an analyser that aims to catch the simplest scenario of 
> incorrect configuration definitions:
> - a configuration is defined in a feature model
> - a component has a matching metatype definition
> - the configuration has a property name that does not match the metatype 
> definition



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-8940) Configurable severity for analyser messages

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-8940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-8940:
--
Fix Version/s: (was: Feature Model Analyser 1.3.0)
   Feature Model Analyser 1.3.2

> Configurable severity for analyser messages
> ---
>
> Key: SLING-8940
> URL: https://issues.apache.org/jira/browse/SLING-8940
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 1.3.2
>
>
> In the context SLING-8938 we also discussed the option of making message 
> severity configurable.
> The proposal from the mailing list was to create a code for each class of 
> reported issues, and then create mappings of the form 
> {{analyser_code.message_code}}, e.g. 
> {noformat}metatype-consistency.property-not-in-metatype=WARN{noformat}
> A further improvement (maybe as a separate issue) would be to also be able to 
> also filter further on the message or other structured properties. The use 
> case would be to lower the severity of unactionable items from bundles that 
> are not under control of the developer, e.g.
> {noformat}[WARNING] Bundle logback-core:1.2.3 is importing package(s) 
> [org.codehaus.commons.compiler, org.codehaus.janino] without specifying a 
> version range{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9458) Support Feature Model files inside a JAR File

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9458:
--
Fix Version/s: (was: Feature Model 1.2.2)
   Feature Model 1.2.4

> Support Feature Model files inside a JAR File
> -
>
> Key: SLING-9458
> URL: https://issues.apache.org/jira/browse/SLING-9458
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.0
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: Feature Model 1.2.4
>
>
> A Feature Model file cannot be passed to the Feature Model when inside a JAR 
> file (jar:file:/...!/feature-model-file.json).
> As we already have Feature Archive that needs to obtain the Feature Model 
> file from within its FAR (JAR) file this might be useful there as well.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-slingfeature-maven-plugin] bosschaert merged pull request #56: SLING-9489 Make it possible to compare parts of feature models

[GitBox]

bosschaert merged pull request #56:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/56


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9487) Default for org.apache.sling.commons.log.file only set via metatype breaking the logstatus webconsole.

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9487.

Fix Version/s: Commons Log 5.1.12
 Assignee: Carsten Ziegeler
   Resolution: Fixed

> Default for org.apache.sling.commons.log.file only set via metatype breaking 
> the logstatus webconsole.
> --
>
> Key: SLING-9487
> URL: https://issues.apache.org/jira/browse/SLING-9487
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Reporter: Dominik Süß
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Commons Log 5.1.12
>
>  Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> As the default for {{org.apache.sling.commons.log.file}}  for PID 
> {{org.apache.sling.commons.log.LogManager.factory.config}} is only set for 
> the metatype the default only applies on setting the configuration via UI. 
> The webconsole UI is dependent on this path to be configured to group the 
> loggers accordin to those writers and spawns a nullpointerexception if a 
> config is getting registered (e.g. via sling installer or feature model) that 
> doesn't set this parameter.
> The proposed solution to this bug is to make sure that configuration being 
> registered without this path pick up the same default value defined as in the 
> metatype. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] removed a comment on pull request #56: SLING-9489 Make it possible to compare parts of feature models

[GitBox]

sonarcloud[bot] removed a comment on pull request #56:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/56#issuecomment-645896304


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-commons-log] cziegeler merged pull request #6: SLING-9487 - adding logic & test to set default for Logfilepath in Ma…

[GitBox]

cziegeler merged pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-commons-log/pull/6


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #56: SLING-9489 Make it possible to compare parts of feature models

[GitBox]

sonarcloud[bot] commented on pull request #56:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/56#issuecomment-645905827


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #56: SLING-9489 Make it possible to compare parts of feature models

[GitBox]

sonarcloud[bot] commented on pull request #56:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/56#issuecomment-645896304


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=56=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=56=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_241) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-slingfeature-maven-plugin] bosschaert commented on a change in pull request #56: SLING-9489 Make it possible to compare parts of feature models

[GitBox]

bosschaert commented on a change in pull request #56:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/56#discussion_r442090896



##
File path: 
src/main/java/org/apache/sling/feature/maven/mojos/AnalyseFeaturesMojo.java
##
@@ -98,6 +99,20 @@ public URL provide(final ArtifactId id) {
 }
 getLog().debug(MessageUtils.buffer().strong("Scanner").a(" 
successfully set up").toString());
 
+FeatureProvider featureProvider = new FeatureProvider() {

Review comment:
   Thanks for the suggestion, I've made this change now.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-9526) Allow launching feature model applications in external processes, non-blocking

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9526:
---
Description: 
It is currently not easily possible to launch a FM-based application as part of 
an integration test, as the {{slingfeature-maven-plugin:launch}} goal always 
blocks.

I think we should keep this goal as-is, and add two new goals:

- start
- stop

The plugin can then take a list of launch configurations that will be started 
and stopped without blocking, and used in integration tests.

The implementation can also be a part of another plug-in, as the 
{{slingfeature-maven-plugin}} already does quite a lot.

  was:
It is currently not easily possible to launch a FM-based application as part of 
an integration test, as the {{slingfeature-maven-plugin:launch}} goal always 
blocks.

I think we should keep this goal as-is, and add two new goals:

- start
- stop

The plugin can then take a list of launch configurations that will be started 
and stopped without blocking, and used in integration tests.


> Allow launching feature model applications in external processes, non-blocking
> --
>
> Key: SLING-9526
> URL: https://issues.apache.org/jira/browse/SLING-9526
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.3.6
>
>
> It is currently not easily possible to launch a FM-based application as part 
> of an integration test, as the {{slingfeature-maven-plugin:launch}} goal 
> always blocks.
> I think we should keep this goal as-is, and add two new goals:
> - start
> - stop
> The plugin can then take a list of launch configurations that will be started 
> and stopped without blocking, and used in integration tests.
> The implementation can also be a part of another plug-in, as the 
> {{slingfeature-maven-plugin}} already does quite a lot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9477) Teleported tests cannot be executed on the latest Sling Starter App

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9477.
-
Resolution: Fixed

Fixed in [commit 
bfd7e0f|https://github.com/apache/sling-org-apache-sling-junit-core/commit/bfd7e0f].

> Teleported tests cannot be executed on the latest Sling Starter App
> ---
>
> Key: SLING-9477
> URL: https://issues.apache.org/jira/browse/SLING-9477
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: JUnit Core 1.0.28
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: JUnit Core 1.0.30
>
>
> The {{org.apache.sling.junit.impl.BundleTestsProvider}} class relies on the 
> {{service.pid}} property for generating a unique PID with which the provider 
> should be registered for registering tests to execute. However, the 
> {{service.pid}} property can be missing from the service.
> A more stable property, which should still provide some uniqueness, would be 
> {{component.name}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)