date:20200817

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #20 is BROKEN

2020-08-17 Thread Apache Jenkins Server

24, 
service.ranking=32768, service.scope=bundle, service.vendor=The Apache Software 
Foundation}] Ignoring unmatching Filter service
[DEBUG] [ServiceReference 74 from bundle 36 : 
org.apache.sling.launchpad.test-services:12.0.0.SNAPSHOT 
ref=[javax.servlet.Servlet] properties={component.id=54, 
component.name=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 objectClass=[javax.servlet.Servlet], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.servlet.pattern=/whiteboard_r6, service.bundleid=36, 
service.id=74, 
service.pid=org.apache.sling.launchpad.testservices.servlets.R6WhiteboardServlet,
 service.scope=bundle, service.vendor=The Apache Software Foundation}] Ignoring 
unmatching Servlet service
[DEBUG] [ServiceReference 427 from bundle 123 : org.apache.sling.engine:2.7.2 
ref=[javax.servlet.Filter] properties={component.id=218, 
component.name=org.apache.sling.engine.parameters, file.max=-1, 
file.threshold=256000, objectClass=[javax.servlet.Filter], 
osgi.http.whiteboard.context.select=(osgi.http.whiteboard.context.name=org.apache.sling),
 osgi.http.whiteboard.filter.pattern=[/], request.max=-1, service.bundleid=123, 
service.description=Filter for request parameter support, service.id=427, 
service.ranking=2147483647, service.scope=bundle, service.vendor=The Apache 
Software Foundation, sling.default.max.parameters=1, 
sling.default.parameter.checkForAdditionalContainerParameters=false, 
sling.default.parameter.encoding=ISO-8859-1}] Ignoring unmatching Filter service
[INFO] Apachde Felix Http Whiteboard Service stopped
[INFO] Stopped Jetty.
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT.jar
[INFO] Checking legal files in: 
org.apache.sling.launchpad.testing-12-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: src/main/appended-resources/META-INF/*
[INFO] Exclude: velocity.log
[INFO] Exclude: target/*
[INFO] Exclude: README.md
[INFO] Exclude: maven-eclipse.xml
[INFO] Exclude: .*
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.json
[INFO] Exclude: DEPENDENCIES
[INFO] Exclude: **/*.rej
[INFO] Exclude: hs_err_*.log
[INFO] Exclude: **/repository/index/*/index-details.txt
[INFO] Exclude: bnd.bnd
[INFO] 6 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 5 licence.
[INFO] 
[INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ 
org.apache.sling.launchpad.testing ---
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time:  03:09 min
[INFO] Finished at: 2020-08-17T22:26:00Z
[INFO] 
[INFO] [jenkins-event-spy] Generated 
/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMaven2e3f1936/maven-spy-20200817-51-4833375803985645170337.log
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on 
project org.apache.sling.launchpad.testing: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/jenkins/workspace/e-sling-launchpad-testing_master/target/failsafe-reports
 for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
[date].dumpstream and [date]-jvmRun[N].dumpstream.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[Pipeline] }
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated 
by maven-surefire-plugin:test (default-test): target/surefire-reports/*.xml
Recording test results
None of the test reports contained any result
[withMaven] junitPublisher - Archive test results for Maven artifact 
org.apache.sling:org.apache.sling.launchpad.testing:jar:12-SNAPSHOT generated 
by maven-failsafe-plugin:integration-test (default): 
target/failsafe-reports/*.xml
Recording test results
[DevOpticsMavenPublisher] dependencies consumed: 93, artifacts produced: 0
[withMaven] Publishers: Generated Artifacts Publisher: 347 ms, Junit Publisher: 
76429 ms, Dependencies Fingerprint Publisher: 691 ms, Open Task Scanner 
Publisher: 171 ms, CloudBees DevOptics Gate Artifact

[jira] [Assigned] (SLING-9636) Refine feature model files

2020-08-17 Thread Robert Munteanu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-9636:
--

Assignee: Robert Munteanu

> Refine feature model files
> --
>
> Key: SLING-9636
> URL: https://issues.apache.org/jira/browse/SLING-9636
> Project: Sling
>  Issue Type: Sub-task
>  Components: Starter
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Starter 12
>
>
> The feature model files have been auto-generated and, while they work, there 
> are improvements we can make, first of all making sure the split is 
> consistent.
> We should additionally least:
> - give consistent names to the features, e.g. {{boot_boot.json}} should 
> become {{boot.json}}
> - use placeholders where possible, e.g. {{ ${project.groupId} }} instead of 
> {{org.apache.sling}}.
> - use variables - we have for instance {{slf4.version}} defined but we don't 
> use it
> - remove (if no longer needed) {{sling.run.mode.install.options}}
> - remove {{org.apache.sling.provisioning.model}} bundle



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #19 is FIXED

2020-08-17 Thread Apache Jenkins Server

Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/19/
 for details.

No further emails will be sent until the status of the build is changed.

[jira] [Resolved] (SLING-7994) add skipExecution flag to reference pipes

2020-08-17 Thread Nicolas Peltier (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7994.

Resolution: Fixed

> add skipExecution flag to reference pipes
> -
>
> Key: SLING-7994
> URL: https://issues.apache.org/jira/browse/SLING-7994
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.0.0
>
>
> add a skipExecution flag to pipe, and the superpipe's behaviour to ignore 
> execution of a subpipe with that flag set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-7994) add skipExecution flag to reference pipes

2020-08-17 Thread Nicolas Peltier (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7994:
--

Assignee: Nicolas Peltier

> add skipExecution flag to reference pipes
> -
>
> Key: SLING-7994
> URL: https://issues.apache.org/jira/browse/SLING-7994
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.0.0
>
>
> add a skipExecution flag to pipe, and the superpipe's behaviour to ignore 
> execution of a subpipe with that flag set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7994) add skipExecution flag to reference pipes

2020-08-17 Thread Nicolas Peltier (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179060#comment-17179060
 ] 

Nicolas Peltier commented on SLING-7994:


adding it to containers not make lot of sense and is complicated

> add skipExecution flag to reference pipes
> -
>
> Key: SLING-7994
> URL: https://issues.apache.org/jira/browse/SLING-7994
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.0.0
>
>
> add a skipExecution flag to pipe, and the superpipe's behaviour to ignore 
> execution of a subpipe with that flag set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-7994) add skipExecution flag to reference pipes

2020-08-17 Thread Nicolas Peltier (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7994:
---
Summary: add skipExecution flag to reference pipes  (was: add skipExecution 
flag to pipes)

> add skipExecution flag to reference pipes
> -
>
> Key: SLING-7994
> URL: https://issues.apache.org/jira/browse/SLING-7994
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.0.0
>
>
> add a skipExecution flag to pipe, and the superpipe's behaviour to ignore 
> execution of a subpipe with that flag set



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7993) create some karate tests for pipes http api integration tests

2020-08-17 Thread Nicolas Peltier (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179050#comment-17179050
 ] 

Nicolas Peltier commented on SLING-7993:


great, thanks, i'll have a look! yeah running them outside would be my 
preference too :)

> create some karate tests for pipes http api integration tests
> -
>
> Key: SLING-7993
> URL: https://issues.apache.org/jira/browse/SLING-7993
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.0.0
>
>
> would be nice to have clear and "documenting" karate tests of pipes http API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9671) Allow non-bundled inheriting resource types to override Use-API templates

2020-08-17 Thread Radu Cotescu (Jira)

Radu Cotescu created SLING-9671:
---

 Summary: Allow non-bundled inheriting resource types to override 
Use-API templates
 Key: SLING-9671
 URL: https://issues.apache.org/jira/browse/SLING-9671
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting HTL Engine 1.4.0-1.4.0
Reporter: Radu Cotescu


SLING-9328 added support for loading templates via the 
{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}} API. 
However, when working with a bundled HTL script (precompiled or not), only 
template libraries available via the bundled script's 
{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}} hierarchy 
are considered, not allowing scripts from the resource tree to override the 
behaviour.





--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-9671) Allow non-bundled inheriting resource types to override Use-API templates

2020-08-17 Thread Radu Cotescu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-9671:
---

Assignee: Radu Cotescu

> Allow non-bundled inheriting resource types to override Use-API templates
> -
>
> Key: SLING-9671
> URL: https://issues.apache.org/jira/browse/SLING-9671
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.4.0-1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
>
> SLING-9328 added support for loading templates via the 
> {{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}} API. 
> However, when working with a bundled HTL script (precompiled or not), only 
> template libraries available via the bundled script's 
> {{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}} hierarchy 
> are considered, not allowing scripts from the resource tree to override the 
> behaviour.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7993) create some karate tests for pipes http api integration tests

2020-08-17 Thread Bertrand Delacretaz (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178979#comment-17178979
 ] 

Bertrand Delacretaz commented on SLING-7993:


Hi Nicolas, for this it's probably easier if the Karate tests run outside of 
the OSGi framework, so you don't have to import all the Karate dependencies?

I haven't done that myself yet but it looks like 
https://ops4j1.jira.com/wiki/spaces/PAXEXAM4/pages/54263878/Server+Mode is what 
you need, there's an example at 
https://github.com/ops4j/org.ops4j.pax.exam2/blob/master/itest/osgi/src/it/regression-multi/src/test/java/org/ops4j/pax/exam/regression/multi/server/WabSampleTest.java

There's another more recent example at 
https://github.com/ops4j/org.ops4j.pax.exam2/blob/master/drivers/pax-exam-acceptance/src/test/java/org/ops4j/pax/exam/acceptance/AcceptanceTestApiTest.java
 which seems to do pretty much the same thing but I haven't found any 
documentation about that.

On the Karate side the test instance URL is defined in karate-config.js and 
IIRC that can use environment variables.

Note that my Karate example is almost two years old, there's probably been lots 
of improvements in the meantime!

> create some karate tests for pipes http api integration tests
> -
>
> Key: SLING-7993
> URL: https://issues.apache.org/jira/browse/SLING-7993
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.0.0
>
>
> would be nice to have clear and "documenting" karate tests of pipes http API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9040) High resource consumption when activating/deactivating ResourceProviders

2020-08-17 Thread Robert Munteanu (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178974#comment-17178974
 ] 

Robert Munteanu commented on SLING-9040:


This commit has been reverted and moved to 
https://github.com/apache/sling-org-apache-sling-resourceresolver/tree/feature/SLING-8946
 . Please see 
https://issues.apache.org/jira/browse/SLING-8946?focusedCommentId=17178893=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17178893
 for more context.

> High resource consumption when activating/deactivating ResourceProviders
> 
>
> Key: SLING-9040
> URL: https://issues.apache.org/jira/browse/SLING-9040
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Dirk Rudolph
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: Resource Resolver 1.6.18
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> With SLING-8946 the updating of all ResourceProviders when their exclude path 
> set changes was introduced to prevent non-deterministic behaviour of resource 
> observation. 
> This change though caused calling {{updateProviderContext()}} and 
> {{ResourceProviderHandler#update()}} on every registered 
> {{ResourceProviderHandler}} when a new ResourceProvider was 
> activated/deactivated no matter if the paths actually intersect. 
> This is quite resource consuming (processing time and memory) and should be 
> reduced to update only those handlers that actually intersect with the 
> handler added/removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Reopened] (SLING-9040) High resource consumption when activating/deactivating ResourceProviders

2020-08-17 Thread Robert Munteanu (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reopened SLING-9040:

  Assignee: (was: Robert Munteanu)

> High resource consumption when activating/deactivating ResourceProviders
> 
>
> Key: SLING-9040
> URL: https://issues.apache.org/jira/browse/SLING-9040
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Reporter: Dirk Rudolph
>Priority: Blocker
> Fix For: Resource Resolver 1.6.18
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> With SLING-8946 the updating of all ResourceProviders when their exclude path 
> set changes was introduced to prevent non-deterministic behaviour of resource 
> observation. 
> This change though caused calling {{updateProviderContext()}} and 
> {{ResourceProviderHandler#update()}} on every registered 
> {{ResourceProviderHandler}} when a new ResourceProvider was 
> activated/deactivated no matter if the paths actually intersect. 
> This is quite resource consuming (processing time and memory) and should be 
> reduced to update only those handlers that actually intersect with the 
> handler added/removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation

2020-08-17 Thread Robert Munteanu (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178973#comment-17178973
 ] 

Robert Munteanu commented on SLING-8946:


I've created 
https://github.com/apache/sling-org-apache-sling-resourceresolver/tree/feature/SLING-8946
 and reverted the two commits.

> Non-deterministic shadowing of resource observation
> ---
>
> Key: SLING-8946
> URL: https://issues.apache.org/jira/browse/SLING-8946
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.34
>Reporter: Dirk Rudolph
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.6.18
>
> Attachments: PerformanceScript.sh
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The BasicObservationReporter implements shadowing of events being propagated 
> per ResourceProvider instance [1]. Assuming we do have 2 ResourceProviders 
> registered, where the one shadows the other like this:
>  - RP A registered on /
>  - RP B registered on /path
> then currently the excludes given to the BasicObservationReporter are 
> different depending on either RP A or RP B gets registered first:
>  - RP A before RP B => excludes are empty
>  - RP B before RP A => excludes contain /path
> This is because only the newly registered RP gets its ProviderContext updated 
> [2]
> Same applies if RP B is registered before RP A and gets unregistered. In that 
> case the ObservationReporter of RP A stays untouched.
> [1] 
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L102]
>  [2] 
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTracker.java#L358]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



sonarcloud[bot] commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-674876991


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18
 lved=false=SECURITY_HOTSPOT) [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_coverage=list)
 [97.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver=18=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



sonarcloud[bot] removed a comment on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-674796039


   Please retry analysis of this Pull-Request directly on 
[SonarCloud](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver=18).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on a change in pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



rombert commented on a change in pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#discussion_r471471135



##
File path: 
src/test/java/org/apache/sling/resourceresolver/impl/mapping/PathGeneratorTest.java
##
@@ -0,0 +1,120 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.resourceresolver.impl.mapping;
+
+import static java.util.Arrays.asList;
+import static java.util.Collections.emptyList;
+import static java.util.Collections.singletonList;
+import static org.junit.Assert.*;
+
+import java.util.List;
+
+import org.hamcrest.Matchers;
+import org.junit.Test;
+
+public class PathGeneratorTest {
+
+@Test
+public void rootPath() {
+
+List paths = new PathGenerator().generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/"));
+}
+
+@Test
+public void subPathWithMissingAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(singletonList(null), "bar");
+builder.insertSegment(singletonList(""), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar"));
+}
+
+@Test
+public void subPathWithMixedAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(singletonList("super"), "foo");
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/super/bar"));
+}
+
+@Test
+public void subPathWithResolutionInfo() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(emptyList(), "foo");
+builder.setResolutionPathInfo("/baz");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(1));
+assertThat(paths, Matchers.hasItem("/foo/bar/baz"));
+}
+
+@Test
+public void subPathWithMultipleAliases() {
+
+PathGenerator builder = new PathGenerator();
+builder.insertSegment(emptyList(), "bar");
+builder.insertSegment(asList("alias1", "alias2"), "foo");
+
+List paths = builder.generatePaths();
+
+assertThat(paths, Matchers.hasSize(2));
+assertThat(paths, Matchers.hasItems("/alias1/bar", "/alias2/bar"));

Review comment:
   FWIW, the behaviour is now the one you suggested, due to the special 
case of decorated resources. We now generate all combinations in this class and 
then remove extra ones if needed.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



rombert commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-674875144


   Testing should be ok now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



rombert commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-674869118


   Hm, a failing test slipped by. I will look into it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



rombert commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-674862672


   I've now updated the changes to cover SLING-9623 as well.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9670) Support binary zip files in feature extension

2020-08-17 Thread Karl Pauls (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178909#comment-17178909
 ] 

Karl Pauls commented on SLING-9670:
---

This extension should be handled at runtime via SLING-9658 but at launch time 
via a new launcher extension.

> Support binary zip files in feature extension
> -
>
> Key: SLING-9670
> URL: https://issues.apache.org/jira/browse/SLING-9670
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Unpack Extension 0.1.0
>
>
> We should create an extension with a handler that allows to unzip artifacts 
> into configurable locations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9670) Support binary zip files in feature extension

2020-08-17 Thread Karl Pauls (Jira)

Karl Pauls created SLING-9670:
-

 Summary: Support binary zip files in feature extension
 Key: SLING-9670
 URL: https://issues.apache.org/jira/browse/SLING-9670
 Project: Sling
  Issue Type: New Feature
  Components: Feature Model
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Feature Model Unpack Extension 0.1.0


We should create an extension with a handler that allows to unzip artifacts 
into configurable locations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-7993) create some karate tests for pipes http api integration tests

2020-08-17 Thread Nicolas Peltier (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178903#comment-17178903
 ] 

Nicolas Peltier commented on SLING-7993:


Hey [~bdelacretaz] looking at 
[https://github.com/apache/sling-whiteboard/tree/master/karate-http-testing] 
and specifically at the mention you do of running those tests with an already 
running instance, i wonder how easy that would be to run those tests against a 
PAX-EXAM container ? I already do [http 
stuff|https://github.com/apache/sling-org-apache-sling-pipes/blob/master/src/test/java/org/apache/sling/pipes/it/PlumberServletIT.java#L54]
 in there so i'm hoping it's feasible, but if from the top of your head there 
are blockers, i'd prefer to know them now :)

> create some karate tests for pipes http api integration tests
> -
>
> Key: SLING-7993
> URL: https://issues.apache.org/jira/browse/SLING-7993
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions, pipes
>Affects Versions: Pipes 3.0.2
>Reporter: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.0.0
>
>
> would be nice to have clear and "documenting" karate tests of pipes http API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



sonarcloud[bot] commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-674795988







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



sonarcloud[bot] removed a comment on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-671545274







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-8946) Non-deterministic shadowing of resource observation

2020-08-17 Thread Robert Munteanu (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178893#comment-17178893
 ] 

Robert Munteanu commented on SLING-8946:


My plan is the following:

- create a new branch {{feature/SLING-8946}} based on the current master
- revert commits [sling-org-apache-sling-resourceresolver commit 
272ea9a|https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/272ea9a]
 and [sling-org-apache-sling-resourceresolver commit 
4f48dee|https://github.com/apache/sling-org-apache-sling-resourceresolver/commit/4f48dee]
 
- revert the commits from above on the master branch
- keep the issue open and targeted for the 'next' release

If anyone objects, please let me know. Re-reverting is easy anyway.

> Non-deterministic shadowing of resource observation
> ---
>
> Key: SLING-8946
> URL: https://issues.apache.org/jira/browse/SLING-8946
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.34
>Reporter: Dirk Rudolph
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Resource Resolver 1.6.18
>
> Attachments: PerformanceScript.sh
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> The BasicObservationReporter implements shadowing of events being propagated 
> per ResourceProvider instance [1]. Assuming we do have 2 ResourceProviders 
> registered, where the one shadows the other like this:
>  - RP A registered on /
>  - RP B registered on /path
> then currently the excludes given to the BasicObservationReporter are 
> different depending on either RP A or RP B gets registered first:
>  - RP A before RP B => excludes are empty
>  - RP B before RP A => excludes contain /path
> This is because only the newly registered RP gets its ProviderContext updated 
> [2]
> Same applies if RP B is registered before RP A and gets unregistered. In that 
> case the ObservationReporter of RP A stays untouched.
> [1] 
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/observation/BasicObservationReporter.java#L102]
>  [2] 
> [https://github.com/apache/sling-org-apache-sling-resourceresolver/blob/master/src/main/java/org/apache/sling/resourceresolver/impl/providers/ResourceProviderTracker.java#L358]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-resourceresolver] rombert commented on pull request #18: SLING-9620 ResourceMapperImpl.getAllMappings does not respect multi-valued sling:alias

2020-08-17 Thread GitBox



rombert commented on pull request #18:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/18#issuecomment-674788859


   @anchela , @jsedding - this is ready for review, I added tests for optimise 
alias resolution enabled and disabled; Sling ITs pass.
   
   It would be great if could review the changes.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-settings] sonarcloud[bot] commented on pull request #3: SLING-9648 do not throw exception in case 'sling.properties.url' is not

2020-08-17 Thread GitBox



sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-settings/pull/3#issuecomment-674765541


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=SECURITY_HOTSPOT)
 [
 0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-settings=3=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-settings=3=new_coverage=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-settings=3=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-settings=3=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-settings=3=new_duplicated_lines_density=list)
   
The version of Java (1.8.0_252) you 
have used to run this analysis is deprecated and we will stop accepting it from 
October 2020. Please update to at least Java 11.
   Read more [here](https://sonarcloud.io/documentation/upcoming/)
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9648) SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided

2020-08-17 Thread Konrad Windszus (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178843#comment-17178843
 ] 

Konrad Windszus commented on SLING-9648:


PR: https://github.com/apache/sling-org-apache-sling-settings/pull/3/files

> SlingPropertiesPrinter fails to activate: No bundle context property 
> 'sling.properties.url' provided
> 
>
> Key: SLING-9648
> URL: https://issues.apache.org/jira/browse/SLING-9648
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Settings 1.4.2
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> When starting up the Sling Starter I see the following error printed on the 
> console:
> {noformat}ERROR: bundle org.apache.sling.settings:1.4.0 
> (22)[org.apache.sling.settings.impl.SlingPropertiesPrinter(1)] :  Error 
> during instantiation of the implementation object
> java.lang.reflect.InvocationTargetException
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>  Method)
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
>   at 
> org.apache.felix.scr.impl.inject.internal.ComponentConstructorImpl.newInstance(ComponentConstructorImpl.java:312)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:279)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:902)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248)
>   at 
> org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350)
>   at org.apache.felix.framework.Felix.getService(Felix.java:3954)
>   at 
> org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.addingService(WebConsoleAdapter.java:152)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:264)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.(WebConsoleAdapter.java:68)
>   at org.apache.felix.inventory.impl.Activator.start(Activator.java:63)
>   at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:698)
>   at org.apache.felix.framework.Felix.activateBundle(Felix.java:2402)
>   at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.IllegalStateException: No bundle context property 
> 'sling.properties.url' provided
>   at 
> org.apache.sling.settings.impl.SlingPropertiesPrinter.(SlingPropertiesPrinter.java:64)
>   ... 30 more
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-settings] kwin opened a new pull request #3: SLING-9648 do not throw exception in case 'sling.properties.url' is not

2020-08-17 Thread GitBox



kwin opened a new pull request #3:
URL: https://github.com/apache/sling-org-apache-sling-settings/pull/3


   used
   
   'sling.properties.url' is only used for the Sling Launchpad but no
   longer with the Feature Model Launcher



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: New committer setup

2020-08-17 Thread Robert Munteanu

I did not even know it's there, but it's definitely a good thing to
have.

Thanks,
Robert

On Mon, 2020-08-17 at 10:31 +0200, Konrad Windszus wrote:
> I am fine with having information in both wiki and site (as long as
> it is not overlapping) but I missed the link from site to wiki.
> Now I see that this is already there: 
> https://github.com/apache/sling-site/commit/144fa82c012006525cbf769a86f629ccc527a167
> <
> https://github.com/apache/sling-site/commit/144fa82c012006525cbf769a86f629ccc527a167>
> ;.
> 
> That is IMHO enough.
> Sorry for the noise.
> Konrad
> 
> > On 17. Aug 2020, at 10:22, Robert Munteanu 
> > wrote:
> > 
> > On Thu, 2020-08-13 at 17:19 +0200, Konrad Windszus wrote:
> > > Looks good, should we link from 
> > > https://sling.apache.org/documentation/development.html <
> > > https://sling.apache.org/documentation/development.html> or even
> > > move
> > > that to the site?
> > 
> > I personally tried to get away with writing committer-oriented
> > documentation on the wiki, because it's more convenient. However,
> > it
> > seems that others see value in having it on the website.
> > 
> > I have gathered this information under [1] and I think we should
> > either
> > keep all of the on the wiki and move all of them on the website. If
> > someone wants to move them I'm fine with that. If not, I can do it
> > but
> > I don't expect to have time for it in the following couple of
> > weeks.
> > 
> > Thanks,
> > Robert
> > 
> > [1]: 
> > https://cwiki.apache.org/confluence/display/SLING/Developing+for+Sling
> > 
> > > > On 13. Aug 2020, at 09:18, Robert Munteanu 
> > > > wrote:
> > > > 
> > > > Hi,
> > > > 
> > > > I wrote down a couple of items hopefully useful for new
> > > > committers
> > > > at
> > > > 
> > > > https://cwiki.apache.org/confluence/display/SLING/New+committer+setup
> > > > 
> > > > Comments welcome.
> > > > 
> > > > Thanks,
> > > > Robert
> > > >

[jira] [Commented] (SLING-9664) org.apache.sling.event.jobs package not present in javadoc for sling10+

2020-08-17 Thread Robert Munteanu (Jira)



[ 
https://issues.apache.org/jira/browse/SLING-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178839#comment-17178839
 ] 

Robert Munteanu commented on SLING-9664:


It seems that javadoc generation is broken for the event bundle. It's present 
for the 4.2.4 release ( 
https://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.event/4.2.4/ ) 
but not for the 4.2.6 one ( 
https://repo1.maven.org/maven2/org/apache/sling/org.apache.sling.event/4.2.6/ ) 
.  I see that between those changes the event.jobs package has been removed but 
it's still exported.

[~karlpauls], [~stefanegli] - since you made changes for those releases can you 
help clear up what is going on? Thanks!

> org.apache.sling.event.jobs package not present in javadoc for sling10+
> ---
>
> Key: SLING-9664
> URL: https://issues.apache.org/jira/browse/SLING-9664
> Project: Sling
>  Issue Type: Improvement
>  Components: Event
>Reporter: Jörg Hoh
>Priority: Major
>
> While the javadoc for sling9 [1] cover the org.apache.sling.event.jobs 
> package(s), they went missing with the sling10 javadoc [2] and subsequent 
> versions.
> [1] https://sling.apache.org/apidocs/sling9/index.html
> [2] https://sling.apache.org/apidocs/sling10/index.html



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: New committer setup

2020-08-17 Thread Konrad Windszus

I am fine with having information in both wiki and site (as long as it is not 
overlapping) but I missed the link from site to wiki.
Now I see that this is already there: 
https://github.com/apache/sling-site/commit/144fa82c012006525cbf769a86f629ccc527a167
 
.

That is IMHO enough.
Sorry for the noise.
Konrad

> On 17. Aug 2020, at 10:22, Robert Munteanu  wrote:
> 
> On Thu, 2020-08-13 at 17:19 +0200, Konrad Windszus wrote:
>> Looks good, should we link from 
>> https://sling.apache.org/documentation/development.html <
>> https://sling.apache.org/documentation/development.html> or even move
>> that to the site?
> 
> I personally tried to get away with writing committer-oriented
> documentation on the wiki, because it's more convenient. However, it
> seems that others see value in having it on the website.
> 
> I have gathered this information under [1] and I think we should either
> keep all of the on the wiki and move all of them on the website. If
> someone wants to move them I'm fine with that. If not, I can do it but
> I don't expect to have time for it in the following couple of weeks.
> 
> Thanks,
> Robert
> 
> [1]: https://cwiki.apache.org/confluence/display/SLING/Developing+for+Sling
> 
>> 
>>> On 13. Aug 2020, at 09:18, Robert Munteanu 
>>> wrote:
>>> 
>>> Hi,
>>> 
>>> I wrote down a couple of items hopefully useful for new committers
>>> at
>>> 
>>> https://cwiki.apache.org/confluence/display/SLING/New+committer+setup
>>> 
>>> Comments welcome.
>>> 
>>> Thanks,
>>> Robert
>>> 
>

Re: New committer setup

2020-08-17 Thread Robert Munteanu

On Thu, 2020-08-13 at 17:19 +0200, Konrad Windszus wrote:
> Looks good, should we link from 
> https://sling.apache.org/documentation/development.html <
> https://sling.apache.org/documentation/development.html> or even move
> that to the site?

I personally tried to get away with writing committer-oriented
documentation on the wiki, because it's more convenient. However, it
seems that others see value in having it on the website.

I have gathered this information under [1] and I think we should either
keep all of the on the wiki and move all of them on the website. If
someone wants to move them I'm fine with that. If not, I can do it but
I don't expect to have time for it in the following couple of weeks.

Thanks,
Robert

[1]: https://cwiki.apache.org/confluence/display/SLING/Developing+for+Sling

> 
> > On 13. Aug 2020, at 09:18, Robert Munteanu 
> > wrote:
> > 
> > Hi,
> > 
> > I wrote down a couple of items hopefully useful for new committers
> > at
> > 
> > https://cwiki.apache.org/confluence/display/SLING/New+committer+setup
> > 
> > Comments welcome.
> > 
> > Thanks,
> > Robert
> >

Re: [VOTE] Release Apache Sling Servlets Resolver 2.7.6

2020-08-17 Thread Robert Munteanu

On Thu, 2020-08-13 at 13:59 -0700, Eric Norman wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part

[RESULT] [VOTE] Release Apache Sling testing Clients version 2.0.2

2020-08-17 Thread Andrei Dulvac

Hi, The vote has passed with the following result : +1 (binding): Robert,
Stefan, Radu, Nicolas, Andrei +1 (non binding): none I will copy this
release to the Sling dist directory and promote the artifacts to the
central Maven repository.

Cheers,
- Andrei

On Mon, Aug 17, 2020 at 9:58 AM Andrei Dulvac  wrote:

> +1
>
> On Wed, Aug 12, 2020 at 12:09 PM Nicolas Peltier 
> wrote:
>
>> +1
>>
>> Le mar. 11 août 2020 à 14:03, Radu Cotescu  a écrit :
>>
>> > +1
>> >
>> > > On 10 Aug 2020, at 17:34, Andrei Dulvac  wrote:
>> > >
>> > > Please vote to approve this release:
>> > >
>> > >  [ ] +1 Approve the release
>> > >  [ ]  0 Don't care
>> > >  [ ] -1 Don't release, because ...
>> >
>> >
>>
>

Re: [VOTE] Release Apache Sling testing Clients version 2.0.2

2020-08-17 Thread Andrei Dulvac

+1

On Wed, Aug 12, 2020 at 12:09 PM Nicolas Peltier 
wrote:

> +1
>
> Le mar. 11 août 2020 à 14:03, Radu Cotescu  a écrit :
>
> > +1
> >
> > > On 10 Aug 2020, at 17:34, Andrei Dulvac  wrote:
> > >
> > > Please vote to approve this release:
> > >
> > >  [ ] +1 Approve the release
> > >  [ ]  0 Don't care
> > >  [ ] -1 Don't release, because ...
> >
> >
>

[jira] [Assigned] (SLING-9648) SlingPropertiesPrinter fails to activate: No bundle context property 'sling.properties.url' provided

2020-08-17 Thread Konrad Windszus (Jira)



 [ 
https://issues.apache.org/jira/browse/SLING-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-9648:
--

Assignee: Konrad Windszus

> SlingPropertiesPrinter fails to activate: No bundle context property 
> 'sling.properties.url' provided
> 
>
> Key: SLING-9648
> URL: https://issues.apache.org/jira/browse/SLING-9648
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Settings 1.4.2
>
>
> When starting up the Sling Starter I see the following error printed on the 
> console:
> {noformat}ERROR: bundle org.apache.sling.settings:1.4.0 
> (22)[org.apache.sling.settings.impl.SlingPropertiesPrinter(1)] :  Error 
> during instantiation of the implementation object
> java.lang.reflect.InvocationTargetException
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native
>  Method)
>   at 
> java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
>   at 
> java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
>   at 
> org.apache.felix.scr.impl.inject.internal.ComponentConstructorImpl.newInstance(ComponentConstructorImpl.java:312)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:279)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957)
>   at 
> org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:902)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348)
>   at 
> org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248)
>   at 
> org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350)
>   at org.apache.felix.framework.Felix.getService(Felix.java:3954)
>   at 
> org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.addingService(WebConsoleAdapter.java:152)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321)
>   at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:264)
>   at 
> org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.(WebConsoleAdapter.java:68)
>   at org.apache.felix.inventory.impl.Activator.start(Activator.java:63)
>   at 
> org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:698)
>   at org.apache.felix.framework.Felix.activateBundle(Felix.java:2402)
>   at org.apache.felix.framework.Felix.startBundle(Felix.java:2308)
>   at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539)
>   at 
> org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.IllegalStateException: No bundle context property 
> 'sling.properties.url' provided
>   at 
> org.apache.sling.settings.impl.SlingPropertiesPrinter.(SlingPropertiesPrinter.java:64)
>   ... 30 more
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

38 matches

Mail list logo