[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #5: SLING-9841: JCR ContentLoader Include/Exclude
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/5#issuecomment-714198144 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5 lved=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_coverage=list) [73.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] removed a comment on pull request #5: SLING-9841: JCR ContentLoader Include/Exclude
sonarcloud[bot] removed a comment on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/5#issuecomment-713895287 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5 lved=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_coverage=list) [73.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #5: SLING-9841: JCR ContentLoader Include/Exclude
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/5#issuecomment-713895287 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5 lved=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader=5=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_coverage=list) [73.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader=5=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-9844) JCR ContentLoader - Import Breaks on Complex Node Structures
[
https://issues.apache.org/jira/browse/SLING-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dan Klco resolved SLING-9844.
-
Resolution: Fixed
Great, change merged!
> JCR ContentLoader - Import Breaks on Complex Node Structures
>
>
> Key: SLING-9844
> URL: https://issues.apache.org/jira/browse/SLING-9844
> Project: Sling
> Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The save in the finishNode method causes issues on complex node types (e.g.
> when child nodes are required). This is exhibited in Oak Index's which fail
> with the following (deceptive) exception:
> {{20.10.2020 21:33:20.958 *ERROR* [Apache Sling Repository Startup Thread #1]
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader Cannot load
> initial content for bundle org.apache.sling.cms.ui : This builder is
> read-only.
> javax.jcr.RepositoryException: This builder is read-only.
> at
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader.createNode(BundleContentLoader.java:503)
> [org.apache.sling.jcr.contentloader:2.4.0.SNAPSHOT]
> at
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader.handleFile(BundleContentLoader.java:427)
> [org.apache.sling.jcr.contentloader:2.4.0.SNAPSHOT]}}
> After tracing through the code, I found this is where it was attempting to
> add the indexRules child node. Also, when you have a required standard child
> node where the operation will fail indicating the missing child node.
> [~jeb] -- Looks like you made the change here, any concerns with removing
> this save? It seems to also save at the path level.
> https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/e1509c5c4c73bbade952a118e04cb645c36aa5da
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-contentloader] klcodanr merged pull request #4: Fixes SLING-9844: Import Breaks on Complex Node Structures
klcodanr merged pull request #4: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] klcodanr closed pull request #3: SLING-9841: JCR ContentLoader Runmode Support
klcodanr closed pull request #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] klcodanr commented on pull request #3: SLING-9841: JCR ContentLoader Runmode Support
klcodanr commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/3#issuecomment-713891326 Closed as use of Runmodes is not recommended. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] klcodanr opened a new pull request #5: SLING-9841: JCR ContentLoader Include/Exclude
klcodanr opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/5 SLING-9841 - Added support for filtering installs based on the target path and renamed the ContentLoaderService since only handles bundles and isn't a service This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SLING-9841) JCR Content Loader Configure Skip Paths
[ https://issues.apache.org/jira/browse/SLING-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9841: Description: As a developer, I want to be able to set a directive in a path entry to skip the loading of the path entry when the value for a certain instance states. This should be implemented as an OSGi configuration with two properties which take an array of regular expression strings: -includedTargets - target paths which will be included -excludedTargets - target paths which will be excluded, takes precidence If not specified, the was: As a developer, I want to be able to set a directive in a path entry to skip the loading of the path entry when the value matches the current instance Runmode. The new directive should be called "skipRunmode". If not specified (null or empty) the content will be loaded. > JCR Content Loader Configure Skip Paths > --- > > Key: SLING-9841 > URL: https://issues.apache.org/jira/browse/SLING-9841 > Project: Sling > Issue Type: Improvement >Affects Versions: JCR ContentLoader 2.3.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: JCR ContentLoader 2.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > > As a developer, I want to be able to set a directive in a path entry to skip > the loading of the path entry when the value for a certain instance states. > This should be implemented as an OSGi configuration with two properties which > take an array of regular expression strings: > -includedTargets - target paths which will be included > -excludedTargets - target paths which will be excluded, takes precidence > If not specified, the -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9841) JCR Content Loader Configure Skip Paths
[ https://issues.apache.org/jira/browse/SLING-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9841: Description: As a developer, I want to be able to set a directive in a path entry to skip the loading of the path entry when the value for a certain instance states. This should be implemented as an OSGi configuration with two properties which take an array of regular expression strings: -includedTargets - target paths which will be included -excludedTargets - target paths which will be excluded, takes precidence If not specified, the bundle loader should still start and load all content targets. was: As a developer, I want to be able to set a directive in a path entry to skip the loading of the path entry when the value for a certain instance states. This should be implemented as an OSGi configuration with two properties which take an array of regular expression strings: -includedTargets - target paths which will be included -excludedTargets - target paths which will be excluded, takes precidence If not specified, the > JCR Content Loader Configure Skip Paths > --- > > Key: SLING-9841 > URL: https://issues.apache.org/jira/browse/SLING-9841 > Project: Sling > Issue Type: Improvement >Affects Versions: JCR ContentLoader 2.3.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: JCR ContentLoader 2.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > > As a developer, I want to be able to set a directive in a path entry to skip > the loading of the path entry when the value for a certain instance states. > This should be implemented as an OSGi configuration with two properties which > take an array of regular expression strings: > -includedTargets - target paths which will be included > -excludedTargets - target paths which will be excluded, takes precidence > If not specified, the bundle loader should still start and load all content > targets. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9841) JCR Content Loader Configure Skip Paths
[ https://issues.apache.org/jira/browse/SLING-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco updated SLING-9841: Summary: JCR Content Loader Configure Skip Paths (was: JCR Content Loader Skip on Sling Runmode) > JCR Content Loader Configure Skip Paths > --- > > Key: SLING-9841 > URL: https://issues.apache.org/jira/browse/SLING-9841 > Project: Sling > Issue Type: Improvement >Affects Versions: JCR ContentLoader 2.3.0 >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Fix For: JCR ContentLoader 2.4.0 > > Time Spent: 40m > Remaining Estimate: 0h > > As a developer, I want to be able to set a directive in a path entry to skip > the loading of the path entry when the value matches the current instance > Runmode. > The new directive should be called "skipRunmode". If not specified (null or > empty) the content will be loaded. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9844) JCR ContentLoader - Import Breaks on Complex Node Structures
[
https://issues.apache.org/jira/browse/SLING-9844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218599#comment-17218599
]
Jason Bailey commented on SLING-9844:
-
It's been a while, but I see no reason why not to remove the save. (y)
> JCR ContentLoader - Import Breaks on Complex Node Structures
>
>
> Key: SLING-9844
> URL: https://issues.apache.org/jira/browse/SLING-9844
> Project: Sling
> Issue Type: Bug
>Affects Versions: JCR ContentLoader 2.4.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: JCR ContentLoader 2.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The save in the finishNode method causes issues on complex node types (e.g.
> when child nodes are required). This is exhibited in Oak Index's which fail
> with the following (deceptive) exception:
> {{20.10.2020 21:33:20.958 *ERROR* [Apache Sling Repository Startup Thread #1]
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader Cannot load
> initial content for bundle org.apache.sling.cms.ui : This builder is
> read-only.
> javax.jcr.RepositoryException: This builder is read-only.
> at
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader.createNode(BundleContentLoader.java:503)
> [org.apache.sling.jcr.contentloader:2.4.0.SNAPSHOT]
> at
> org.apache.sling.jcr.contentloader.internal.BundleContentLoader.handleFile(BundleContentLoader.java:427)
> [org.apache.sling.jcr.contentloader:2.4.0.SNAPSHOT]}}
> After tracing through the code, I found this is where it was attempting to
> add the indexRules child node. Also, when you have a required standard child
> node where the operation will fail indicating the missing child node.
> [~jeb] -- Looks like you made the change here, any concerns with removing
> this save? It seems to also save at the path level.
> https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/e1509c5c4c73bbade952a118e04cb645c36aa5da
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (SLING-9802) Launcher Classloader is not synchronizing loadClass correctly
[ https://issues.apache.org/jira/browse/SLING-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-9802. - > Launcher Classloader is not synchronizing loadClass correctly > - > > Key: SLING-9802 > URL: https://issues.apache.org/jira/browse/SLING-9802 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Launcher 1.1.6 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model Launcher 1.1.8 > > > The default LauncherClassloader is not synchronizing its loadClass method > correctly. As it just delegates to the findClass of the URLClassloader it > extends, it needs to at a minimum lock on the classname it is trying to load > - otherwise, it is possible that it will catch a LinkageError if the same > class load is happening concurrently. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9798) Don't expose OSGi / Apache Felix JMX MBeans from the feature launcher
[ https://issues.apache.org/jira/browse/SLING-9798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls closed SLING-9798. - > Don't expose OSGi / Apache Felix JMX MBeans from the feature launcher > - > > Key: SLING-9798 > URL: https://issues.apache.org/jira/browse/SLING-9798 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model Launcher 1.1.6 >Reporter: Karl Pauls >Assignee: Karl Pauls >Priority: Major > Fix For: Feature Model Launcher 1.1.8 > > > In SLING-9621 the JMX Means have been added to the feature launcher. I think > that is a mistake. The goal of the feature launcher was to keep the > dependencies minimal and do as much as possible from the outside. > We already have the mechanism to expose the MBeans via the: > org-apache-sling-launchpad-startupmanager bundle [0]. If somebody needs the > MBeans as part of their features they can just add that bundle to their > features. > At a minimum, we would need to make the exposing configurable (in such a way > that if the config is off, it will not even need the javax.management classes > on the class path) but preferably I would really like to revert the commit in > question [1]. > [~klcodanr], would it work for if I revert the commit in favor of [0] or is > there another reasons to keep it (in which case I would make it configurable)? > [0] > https://github.com/apache/sling-org-apache-sling-launchpad-startupmanager/blob/master/src/main/java/org/apache/sling/launchpad/startupmanager/Activator.java > [1] > https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/89d2a4806b09051e95b16074d853f1d83b643172 -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [RESULT][VOTE] Release Apache Sling Feature Model Launcher 1.1.8
Time to call the vote on the ApacheSling Feature Model Launcher 1.1.8 release. * +1 votes from Carsten Ziegeler, David Bosschaert, Robert Munteanu, and Karl Pauls. * No other votes. The vote is successful. I will make the artifacts available as soon as possible.
Re: [VOTE] Release Apache Sling Feature Model Launcher 1.1.8
Yes, I forgot about it - sorry about that. Here is my +1. regards, Karl On Wed, Oct 21, 2020 at 10:30 PM Daniel Klco wrote: > > Was this release completed? Looks like it was never finished in Nexus and > I'm not seeing it on Maven Central. > > On Mon, Oct 12, 2020 at 6:01 AM Robert Munteanu wrote: > > > On Thu, 2020-10-08 at 11:48 +0200, Karl Pauls wrote: > > > Please vote to approve this release: > > > > +1 > > Robert > > -- Karl Pauls karlpa...@gmail.com
Re: [VOTE] Release Apache Sling Feature Model Launcher 1.1.8
Was this release completed? Looks like it was never finished in Nexus and I'm not seeing it on Maven Central. On Mon, Oct 12, 2020 at 6:01 AM Robert Munteanu wrote: > On Thu, 2020-10-08 at 11:48 +0200, Karl Pauls wrote: > > Please vote to approve this release: > > +1 > Robert >
[GitHub] [sling-org-apache-sling-scripting-sightly-compiler] sonarcloud[bot] commented on pull request #7: SLING-9829 - data-sly-element should correctly handle void elements
sonarcloud[bot] commented on pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/7#issuecomment-713800633 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting -sightly-compiler=7=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=new_coverage=list) [17.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-compiler=7=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-compiler] raducotescu opened a new pull request #7: SLING-9829 - data-sly-element should correctly handle void elements
raducotescu opened a new pull request #7: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/pull/7 * defined the set of void elements in `ElementPlugin`; every time the `data-sly-element` plugin is used, the dynamically passed tag name will be checked against the set; if the tag is a void element no closing tag will be added This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9829) data-sly-element should correctly handle void elements
[
https://issues.apache.org/jira/browse/SLING-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218483#comment-17218483
]
Radu Cotescu commented on SLING-9829:
-
[~paul.bjorkstrand], that's not so easy to do and the behaviour was not really
specified before either. The element name can be passed at run-time, so only
then we could allegedly issue a warning. However, there's no logging runtime
function that would allow us to do something like that.
> data-sly-element should correctly handle void elements
> --
>
> Key: SLING-9829
> URL: https://issues.apache.org/jira/browse/SLING-9829
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.0, Scripting HTL Compiler
> 1.0.0, Scripting HTL Compiler 1.1.0-1.4.0, Scripting HTL Compiler 1.2.0-1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.12-1.4.0
>
>
> The current implementation of {{data-sly-element}} doesn't correctly handle
> void elements which will replace the original element on which the block
> element was placed:
> When {{$\{item.element.name}}} evaluates to {{link}} or {{meta}}, the element
> will have a closing tag in the following example, although both {{link}} and
> {{meta}} are void elements:
> {code:html}
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[VOTE] Release Apache Sling JCR Oak Server 1.2.10
Hi, We solved 3 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12348809 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2361/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2361 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
sling level package format
Dear Sling Devs, currently we rely heavily on jcr filevalut packages to ingest content into our sling instances. While the filevault format is great to operate on the JCR level it unfortunately does not seem to be the best way to ingest some content. I have been wondering for a while if it would be a good idea to create a sling supported import format that operates at a higher level instead. Such an import format could for example solve issues like - ingest a page with all its versions - add/update a page and correctly manage the replication state of the page - turn off asset processing when ingesting processed assets It may be a good idea for sling to provide a basic infrastructure for such an import format where the actions one can take through the format is left to an implementation. Such a format could also be streamable. Unfortunately however such a format would not be able to support the bidirectional nature of the jcr filevault packages we currently enjoy. Would love to hear your thoughts on this and if it would make sense to start working on such a format. Ruben
Re: [Discuss] - JCR ContentLoader Skip Runmode
That's why I wanted to discuss the approach. I was trying to think of ways to link the contents of the Bundle Content to the instance state, Runmodes seem like a logical solution. On further reflection this morning, I think it makes more sense to handle this with include / exclude settings in the JCR Content Loader. The idea being you could have an OSGi Config with: Seeding Setting: - Includes Path: [ "^/apps/.*", "^/libs/.*", "^/oak:index/.*" ] Runtime Setting: - Includes Path: [ "^/.*" ] - Excludes Path: [ "^/apps/.*", "^/libs/.*", "^/oak:index/.*" ] The Bundle Content Loader would then filter out the path roots based on the include / exclude rules. I would only expect this to happen at the path root, not for the individual nodes being loaded. The configuration would not be required and in that case the Bundle Content Loader would load all content. I would think this solution would work and adds the added benefit of being very backwards compatible and not requiring changes to the bundle configurations. WDYT? On Wed, Oct 21, 2020 at 5:31 AM Robert Munteanu wrote: > Hi Daniel, > > On Mon, 2020-10-19 at 14:49 -0400, Daniel Klco wrote: > > Hey Sling Team, > > > > As Robert mentioned previously[1] using the JCR Content Loader with a > > Composite NodeStore is challenging as it keeps track of the status of > > the > > bundles underneath the /var directory. > > > > One of the practical challenges I've also seen with a Composite > > Repository > > is that you actually want the bundle content to re-install when the > > Composite Repository loads. For example, if you want a single bundle > > to > > populate the entire repository you may want it to load content under > > /apps > > during seeding and /conf during runtime. > > > > My proposal would be to add a new PathEntry directive, "skipRunmode" > > which > > would skip the installing of a content entry when the Sling instance > > is > > running with the specified runmode. If not specified the content > > would > > still be loaded so this would be backward compatible. > > Without looking at the code - why have you tried linking this to > runmodes? We are trying to move away from that and with the feature > model you can have different configurations per feature ( or aggregate > ). > > Thanks, > Robert > >
[GitHub] [sling-site] jsedding commented on pull request #50: SLING-9795 - JUnit 5 support for server-side tests
jsedding commented on pull request #50: URL: https://github.com/apache/sling-site/pull/50#issuecomment-713459393 Thanks @kwin for reviewing again. I have merged this now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-site] jsedding merged pull request #50: SLING-9795 - JUnit 5 support for server-side tests
jsedding merged pull request #50: URL: https://github.com/apache/sling-site/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [Discuss] - JCR ContentLoader Skip Runmode
Hi Daniel, On Mon, 2020-10-19 at 14:49 -0400, Daniel Klco wrote: > Hey Sling Team, > > As Robert mentioned previously[1] using the JCR Content Loader with a > Composite NodeStore is challenging as it keeps track of the status of > the > bundles underneath the /var directory. > > One of the practical challenges I've also seen with a Composite > Repository > is that you actually want the bundle content to re-install when the > Composite Repository loads. For example, if you want a single bundle > to > populate the entire repository you may want it to load content under > /apps > during seeding and /conf during runtime. > > My proposal would be to add a new PathEntry directive, "skipRunmode" > which > would skip the installing of a content entry when the Sling instance > is > running with the specified runmode. If not specified the content > would > still be loaded so this would be backward compatible. Without looking at the code - why have you tried linking this to runmodes? We are trying to move away from that and with the feature model you can have different configurations per feature ( or aggregate ). Thanks, Robert
[jira] [Updated] (SLING-9835) Update to Sling Bundle Parent 40
[ https://issues.apache.org/jira/browse/SLING-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-9835: -- Affects Version/s: (was: JUnit Core 1.0.30) JUnit Core 1.1.0 > Update to Sling Bundle Parent 40 > > > Key: SLING-9835 > URL: https://issues.apache.org/jira/browse/SLING-9835 > Project: Sling > Issue Type: Task > Components: JUnit Core >Affects Versions: JUnit Core 1.1.0 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: JUnit Core 1.1.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9795) JUnit 5 support for server-side tests
[ https://issues.apache.org/jira/browse/SLING-9795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed SLING-9795. - > JUnit 5 support for server-side tests > - > > Key: SLING-9795 > URL: https://issues.apache.org/jira/browse/SLING-9795 > Project: Sling > Issue Type: Improvement > Components: JUnit Core >Affects Versions: JUnit Core 1.0.30 >Reporter: Julian Sedding >Assignee: Julian Sedding >Priority: Minor > Fix For: JUnit Core 1.1.0 > > Time Spent: 4h > Remaining Estimate: 0h > > JUnit Core does not yet support server-side JUnit 5 tests. JUnit 5 is > provided via several OSGi bundles, i.e. the APIs and Implementations can be > deployed into Felix. > In order to leverage these, JUnit Core should have > - optional imports for the necessary packages > - run the tests JUnit 5 style *if* all of the optional imports are available > - run the tests like before *if* any of the optional imports are missing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (SLING-9542) Unable to use junit categories with sling junit core
[ https://issues.apache.org/jira/browse/SLING-9542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding closed SLING-9542. - > Unable to use junit categories with sling junit core > - > > Key: SLING-9542 > URL: https://issues.apache.org/jira/browse/SLING-9542 > Project: Sling > Issue Type: Bug > Components: JUnit Core >Reporter: Nitin Nizhawan >Assignee: Julian Sedding >Priority: Major > Fix For: JUnit Core 1.1.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Sling Junit core embeds JUnit and exports JUnit packages. These junit > packages are imported by test case bundles created by teleporter. If > however, test cases use junit categories to filter tests then such tests to > not work. > This is because sling junit core exports only some junit package. > Specifically, it does not export org.junit.experimental.categories and > org.junit.validator -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9835) Update to Sling Bundle Parent 40
[ https://issues.apache.org/jira/browse/SLING-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Sedding updated SLING-9835: -- Fix Version/s: (was: JUnit Core 1.1.0) JUnit Core 1.1.2 > Update to Sling Bundle Parent 40 > > > Key: SLING-9835 > URL: https://issues.apache.org/jira/browse/SLING-9835 > Project: Sling > Issue Type: Task > Components: JUnit Core >Affects Versions: JUnit Core 1.0.30 >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz >Priority: Minor > Fix For: JUnit Core 1.1.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-site] jsedding commented on pull request #50: SLING-9795 - JUnit 5 support for server-side tests
jsedding commented on pull request #50: URL: https://github.com/apache/sling-site/pull/50#issuecomment-713404938 @kwin, @bdelacretaz I've changed several paragraphs, hoping it addresses the issues/questions you raised. Could you please have another look? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
