[GitHub] [sling-org-apache-sling-dynamic-include] SBPrakash closed pull request #17: Sling 9981 remove jquery dependency

2020-12-15 Thread GitBox 


SBPrakash closed pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/17


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #16: Remove jQuery dependency -https://issues.apache.org/jira/browse/SLING-9981

2020-12-15 Thread GitBox 


sonarcloud[bot] commented on pull request #16:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/16#issuecomment-745605551


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&metric=coverage&view=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #17: Sling 9981 remove jquery dependency

2020-12-15 Thread GitBox 


sonarcloud[bot] commented on pull request #17:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/17#issuecomment-745604562


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=coverage&view=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] SBPrakash commented on a change in pull request #16: Remove jQuery dependency -https://issues.apache.org/jira/browse/SLING-9981

2020-12-15 Thread GitBox 


SBPrakash commented on a change in pull request #16:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/16#discussion_r543730275



##
File path: 
src/main/java/org/apache/sling/dynamicinclude/generator/types/JsiGenerator.java
##
@@ -39,7 +39,7 @@
  */
 @Component
 public class JsiGenerator implements IncludeGenerator {
-private static final String TEMPLATE_FILENAME = "generators/jquery.html";
+private static final String TEMPLATE_FILENAME = 
"generators/javascript.html";

Review comment:
   It's removed now.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] removed a comment on pull request #16: Remove jQuery dependency -https://issues.apache.org/jira/browse/SLING-9981

2020-12-15 Thread GitBox 


sonarcloud[bot] removed a comment on pull request #16:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/16#issuecomment-742851071


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&metric=coverage&view=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=16&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] removed a comment on pull request #17: Sling 9981 remove jquery dependency

2020-12-15 Thread GitBox 


sonarcloud[bot] removed a comment on pull request #17:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/17#issuecomment-745603958


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=coverage&view=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #17: Sling 9981 remove jquery dependency

2020-12-15 Thread GitBox 


sonarcloud[bot] commented on pull request #17:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/17#issuecomment-745603958


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=coverage&view=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=17&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] SBPrakash opened a new pull request #17: Sling 9981 remove jquery dependency

2020-12-15 Thread GitBox 


SBPrakash opened a new pull request #17:
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/17


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-dynamic-include] klcodanr commented on a change in pull request #16: Remove jQuery dependency -https://issues.apache.org/jira/browse/SLING-9981

2020-12-15 Thread GitBox 


klcodanr commented on a change in pull request #16:
URL: 
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/16#discussion_r543721089



##
File path: src/main/resources/generators/javascript.html
##
@@ -0,0 +1,36 @@
+
+
+

[jira] [Closed] (SLING-9949) Speed-up bundled scripts resolution

2020-12-15 Thread Karl Pauls (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-9949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls closed SLING-9949.
-

> Speed-up bundled scripts resolution
> ---
>
> Key: SLING-9949
> URL: https://issues.apache.org/jira/browse/SLING-9949
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Servlets Resolver 2.7.10
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Servlets Resolver 2.7.12
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> When resolving bundled scripts the resolver is currently parsing the metadata 
> several times. That can be avoided using caching the parsed result.
> Furthermore, the bundled script servlet is currently calculating the 
> providers on each request. That can be avoided by doing the calculation one 
> time when it is created. Additionally, it should unroll servlet exceptions 
> instead of wrapping them again in a servlet exception.
> Finally, the MergingResourceProvider does right now construct its resource 
> tree completely from scratch every time a servlet is added - that can be 
> avoided by just adding the servlet to the existing tree.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [RESULT][VOTE] Release Apache Sling Servlets Resolver 2.7.12

2020-12-15 Thread Karl Pauls 
Time to call the vote on the  Apache Sling Servlets Resolver 2.7.12 release.

* +1 votes from Daniellas Klco, Carsten Ziegeler, Radu Cotescu,
Nicolas Peltier, and Karl Pauls.

* No other votes.

The vote is successful. I will make the artifacts available as soon as possible.

Re: [VOTE] Release Apache Sling Servlets Resolver 2.7.12

2020-12-15 Thread Karl Pauls 
+1

regards,

Karl

On Mon, Dec 14, 2020 at 5:02 PM Nicolas Peltier  wrote:
>
> +1
>
> Le lun. 14 déc. 2020 à 16:53, Radu Cotescu  a écrit :
>
> > +1
> >
> > > On 11 Dec 2020, at 16:31, Karl Pauls  wrote:
> > >
> > > Please vote to approve this release:
> > >
> > >  [ ] +1 Approve the release
> > >  [ ]  0 Don't care
> > >  [ ] -1 Don't release, because ...
> >
> >



-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Commented] (SLING-10006) Parameter ":sendError" presence should not replace the PostResponse object

2020-12-15 Thread Eric Norman (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-10006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249908#comment-17249908
 ] 

Eric Norman commented on SLING-10006:
-

I prepared a fix in the PR at: 
[https://github.com/apache/sling-org-apache-sling-servlets-post/pull/8]

If there is no negative feedback in a few days then I will merge the fix into 
the mainline.

> Parameter ":sendError" presence should not replace the PostResponse object
> --
>
> Key: SLING-10006
> URL: https://issues.apache.org/jira/browse/SLING-10006
> Project: Sling
>  Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Servlets POST 2.3.38
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The PostResponseWithErrorHandling implementation is hardcoded to an 
> HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
> cases where a Json response is expected.  It also breaks the use case where a 
> custom PostResponseCreator component needs to do something different without 
> changing the error handling behavior.
> For example, this request should return a JSON success response instead of 
> HTML:
>  
> {code:java}
> curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
> -Ftext="some body text content" http://admin:admin@localhost:8080/content
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10006) Parameter ":sendError" presence should not replace the PostResponse object

2020-12-15 Thread Eric Norman (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-10006:

Description: 
The PostResponseWithErrorHandling implementation is hardcoded to an 
HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
cases where a Json response is expected.  It also breaks the use case where a 
custom PostResponseCreator component needs to do something different without 
changing the error handling behavior.

For example, this request should return a JSON success response instead of HTML:

 
{code:java}
curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
-Ftext="some body text content" http://admin:admin@localhost:8080/content
{code}
 

  was:
The PostResponseWithErrorHandling implementation is hardcoded to an 
HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
cases where a Json response is expected.  It also breaks the use case where a 
custom PostResponseCreator component needs to do something different without 
changing the error handling behavior.

For example, this request should return a JSON error response instead of HTML:

 
{code:java}
curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
-Ftext="some body text content" http://admin:admin@localhost:8080/content
{code}
 


> Parameter ":sendError" presence should not replace the PostResponse object
> --
>
> Key: SLING-10006
> URL: https://issues.apache.org/jira/browse/SLING-10006
> Project: Sling
>  Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Servlets POST 2.3.38
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> The PostResponseWithErrorHandling implementation is hardcoded to an 
> HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
> cases where a Json response is expected.  It also breaks the use case where a 
> custom PostResponseCreator component needs to do something different without 
> changing the error handling behavior.
> For example, this request should return a JSON success response instead of 
> HTML:
>  
> {code:java}
> curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
> -Ftext="some body text content" http://admin:admin@localhost:8080/content
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #8: SLING-10006 Parameter ":sendError" presence should not replace the PostResponse object

2020-12-15 Thread GitBox 


sonarcloud[bot] commented on pull request #8:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/8#issuecomment-745531994


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&metric=new_coverage&view=list)
 [31.9% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&metric=new_duplicated_lines_density&view=list)
 [0.3% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=8&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10006) Parameter ":sendError" presence should not replace the PostResponse object

2020-12-15 Thread Eric Norman (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-10006:

Description: 
The PostResponseWithErrorHandling implementation is hardcoded to an 
HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
cases where a Json response is expected.  It also breaks the use case where a 
custom PostResponseCreator component needs to do something different without 
changing the error handling behavior.

For example, this request should return a JSON error response instead of HTML:

 
{code:java}
curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
-Ftext="some body text content" http://admin:admin@localhost:8080/content
{code}
 

  was:
The PostResponseWithErrorHandling implementation is hardcoded to an 
HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
cases where a Json response is expected.  It also breaks the use case where a 
custom PostResponseCreator component needs to do something different without 
changing the error handling behavior.

For example, this request should return a JSON error response instead of HTML:

 
{code:java}
curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
-Ftext="some body text content" http://localhost:8080/content
{code}
 


> Parameter ":sendError" presence should not replace the PostResponse object
> --
>
> Key: SLING-10006
> URL: https://issues.apache.org/jira/browse/SLING-10006
> Project: Sling
>  Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Servlets POST 2.3.38
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The PostResponseWithErrorHandling implementation is hardcoded to an 
> HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
> cases where a Json response is expected.  It also breaks the use case where a 
> custom PostResponseCreator component needs to do something different without 
> changing the error handling behavior.
> For example, this request should return a JSON error response instead of HTML:
>  
> {code:java}
> curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
> -Ftext="some body text content" http://admin:admin@localhost:8080/content
> {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-servlets-post] enapps-enorman opened a new pull request #8: SLING-10006 Parameter ":sendError" presence should not replace the PostResponse object

2020-12-15 Thread GitBox 


enapps-enorman opened a new pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/8


   The PostResponseWithErrorHandling implementation was hardcoded to an 
HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
cases where a Json response is expected.
   
   This change deprecates and stops loading the PostResponseWithErrorHandling 
component and re-implements that feature by  wrapping whichever PostResponse 
object is calculated.  The error sending behavior is overridden and the rest of 
the calls pass through to the wrapped PostResponse instance.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-8473) Provide Sling CMS features

2020-12-15 Thread Oliver Lietz (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249902#comment-17249902
 ] 

Oliver Lietz commented on SLING-8473:
-

[~klcodanr], I've uncommented the CMS features for now (with 
{{0.16.3-SNAPSHOT}}) and also added configurations and features for _author_, 
_renderer_ and _standalone_.

> Provide Sling CMS features
> --
>
> Key: SLING-8473
> URL: https://issues.apache.org/jira/browse/SLING-8473
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Karaf Integration Tests 1.0.0, Karaf Distribution 1.0.0, 
> Karaf Features 1.0.0, Karaf Configs 1.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-9991) Parameter ":sendError" uses/significance should be listed in the sling document

2020-12-15 Thread Eric Norman (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249846#comment-17249846
 ] 

Eric Norman edited comment on SLING-9991 at 12/15/20, 6:13 PM:
---

[~cziegeler] Ok, I opened SLING-10006 for tracking.  I was just expecting that 
it would be better to add to the public documentation after the feature was 
known to be working.  There don't appear to be any tests to verify this 
functionality and it doesn't appear to work even in the happy path.  For 
example, reporting a success from the PostResponseWithErrorHandling code path 
seems to currently throw a NullPointerException as it can't find the html 
templates from a class in the "impl" package.
{code:java}
curl -i -F:sendError="true" -F:nameHint="test" -Ftext="some body text content" 
http://admin:admin@localhost:8080/content{code}


was (Author: enorman):
[~cziegeler] Ok, I opened SLING-10006 for tracking.  I was just expecting that 
it would be better to add to the public documentation after the feature was 
known to be working.  There don't appear to be any tests to verify this 
functionality and it doesn't appear to work even in the happy path.  For 
example, reporting an error from the PostResponseWithErrorHandling code path 
seems to currently throw a NullPointerException as it can't find the html 
templates from a class in the "impl" package.
{code:java}
curl -i -F:sendError="true" -F:nameHint="test" -Ftext="some body text content" 
http://admin:admin@localhost:8080/content{code}

> Parameter ":sendError"  uses/significance should be listed in the sling 
> document
> 
>
> Key: SLING-9991
> URL: https://issues.apache.org/jira/browse/SLING-9991
> Project: Sling
>  Issue Type: Improvement
>Reporter: Akanksha Jain
>Assignee: Carsten Ziegeler
>Priority: Minor
>
> The parameter ":sendError" is used by the sling error handler to delegate 
> HTTP Post response to the custom error handler.
> This Parameter should be listed in the document[0], along with other special 
> parameters for better understanding.
> [0]: 
> https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#special-parameters-1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9991) Parameter ":sendError" uses/significance should be listed in the sling document

2020-12-15 Thread Eric Norman (Jira) 


[ 
https://issues.apache.org/jira/browse/SLING-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249846#comment-17249846
 ] 

Eric Norman commented on SLING-9991:


[~cziegeler] Ok, I opened SLING-10006 for tracking.  I was just expecting that 
it would be better to add to the public documentation after the feature was 
known to be working.  There don't appear to be any tests to verify this 
functionality and it doesn't appear to work even in the happy path.  For 
example, reporting an error from the PostResponseWithErrorHandling code path 
seems to currently throw a NullPointerException as it can't find the html 
templates from a class in the "impl" package.
{code:java}
curl -i -F:sendError="true" -F:nameHint="test" -Ftext="some body text content" 
http://admin:admin@localhost:8080/content{code}

> Parameter ":sendError"  uses/significance should be listed in the sling 
> document
> 
>
> Key: SLING-9991
> URL: https://issues.apache.org/jira/browse/SLING-9991
> Project: Sling
>  Issue Type: Improvement
>Reporter: Akanksha Jain
>Assignee: Carsten Ziegeler
>Priority: Minor
>
> The parameter ":sendError" is used by the sling error handler to delegate 
> HTTP Post response to the custom error handler.
> This Parameter should be listed in the document[0], along with other special 
> parameters for better understanding.
> [0]: 
> https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#special-parameters-1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10006) Parameter ":sendError" presence should not replace the PostResponse object

2020-12-15 Thread Eric Norman (Jira) 
Eric Norman created SLING-10006:
---

 Summary: Parameter ":sendError" presence should not replace the 
PostResponse object
 Key: SLING-10006
 URL: https://issues.apache.org/jira/browse/SLING-10006
 Project: Sling
  Issue Type: Bug
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: Servlets POST 2.3.38


The PostResponseWithErrorHandling implementation is hardcoded to an 
HtmlResponse when the ":sendError" parameter is "true".  This breaks the use 
cases where a Json response is expected.  It also breaks the use case where a 
custom PostResponseCreator component needs to do something different without 
changing the error handling behavior.

For example, this request should return a JSON error response instead of HTML:

 
{code:java}
curl -i -H "Accept: application/json" -F:sendError="true" -F:nameHint="test" 
-Ftext="some body text content" http://localhost:8080/content
{code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10004) Feature extension feature-internal-data should not be required

2020-12-15 Thread Carsten Ziegeler (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-10004.
--
Resolution: Fixed

Fixed in 
https://github.com/apache/sling-org-apache-sling-feature/commit/b96c13d9668c2ba0880ff3ddb77687f07416e941

> Feature extension feature-internal-data should not be required
> --
>
> Key: SLING-10004
> URL: https://issues.apache.org/jira/browse/SLING-10004
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 1.2.16
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model 1.2.18
>
>
> The new introduced extension feature-internal-data for managing feature model 
> internal data like origins of properties/variables should not be required



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10005) Document the ExtensionHandler interface

2020-12-15 Thread Robert Munteanu (Jira) 
Robert Munteanu created SLING-10005:
---

 Summary: Document the ExtensionHandler interface
 Key: SLING-10005
 URL: https://issues.apache.org/jira/browse/SLING-10005
 Project: Sling
  Issue Type: Task
  Components: Feature Model
Reporter: Robert Munteanu
 Fix For: Feature Model Launcher 1.1.16


The {{ExtensionHandler}} interface is meant to be implemented by clients to 
write launcher extensions, but it does not have any Javadoc. Particularly the 
return value of the {{handle}} method is uncler.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10004) Feature extension feature-internal-data should not be required

2020-12-15 Thread Carsten Ziegeler (Jira) 
Carsten Ziegeler created SLING-10004:


 Summary: Feature extension feature-internal-data should not be 
required
 Key: SLING-10004
 URL: https://issues.apache.org/jira/browse/SLING-10004
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model 1.2.16
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: Feature Model 1.2.18


The new introduced extension feature-internal-data for managing feature model 
internal data like origins of properties/variables should not be required



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #261 is FIXED

2020-12-15 Thread Apache Jenkins Server 
Please see 
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/261/
 for details.

No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] removed a comment on pull request #37: Sling 9535-dummy: improvement for threadsafety and atomicity

2020-12-15 Thread GitBox 


sonarcloud[bot] removed a comment on pull request #37:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/37#issuecomment-745193164


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_coverage&view=list)
 [90.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #37: Sling 9535-dummy: improvement for threadsafety and atomicity

2020-12-15 Thread GitBox 


sonarcloud[bot] commented on pull request #37:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/37#issuecomment-745220774


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
 [3 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_coverage&view=list)
 [90.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9993) Allow configuring extensions using the CLI

2020-12-15 Thread Robert Munteanu (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-9993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9993.

Fix Version/s: (was: Feature Model Launcher 1.1.16)
   Resolution: Won't Fix

Thanks [~cziegeler], I'm closing this then as a won't fix.

> Allow configuring extensions using the CLI
> --
>
> Key: SLING-9993
> URL: https://issues.apache.org/jira/browse/SLING-9993
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
>
> When switching from using just the launcher to using the launcher + 
> extensions the launch command becomes more convoluted. Compare:
> {noformat}
> $ java -jar target/dependency/org.apache.sling.feature.launcher.jar
> {noformat}
> with 
> {noformat}
> $ java -cp 
> target/dependency/org.apache.sling.feature.launcher.jar:target/dependency/some.extension.jar
>  org.apache.sling.feature.launcher.impl.Main
> {noformat}
> It would be very useful to be able to specify extensions as CLI arguments, 
> e.g.
> {noformat}
> $ java  -jar target/dependency/org.apache.sling.feature.launcher.jar -e 
> target/dependency/some.extension.jar
> {noformat}
> or maybe an extension directory
> {noformat}
> $ java  -jar target/dependency/org.apache.sling.feature.launcher.jar -ed 
> target/dependency/extensions
> {noformat}
> We could even go as far as automatically loading extensions from a 
> {{LAUNCHER_HOME/ext}} directory ( with proper logging, of course ).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-resourceresolver] sonarcloud[bot] commented on pull request #37: Sling 9535-dummy: improvement for threadsafety and atomicity

2020-12-15 Thread GitBox 


sonarcloud[bot] commented on pull request #37:
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/37#issuecomment-745193164


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
 [1 
Bug](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_coverage&view=list)
 [90.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-resourceresolver&pullRequest=37&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] akankshajain18 opened a new pull request #37: Sling 9535: improvement for threadsafety and atomicity

2020-12-15 Thread GitBox 


akankshajain18 opened a new pull request #37:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/37


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-resourceresolver] akankshajain18 closed pull request #36: Sling 9535 : update for thread safety

2020-12-15 Thread GitBox 


akankshajain18 closed pull request #36:
URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/36


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org