[GitHub] [sling-slingfeature-maven-plugin] schaefa commented on pull request #63: Added the creation of the Generated Feature Model folder it is does n…

[GitBox]

schaefa commented on pull request #63:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/63#issuecomment-754899751


   You're guess is as good as mine. I see this as a root cause in the 
'apis-jar-exported-package-no-classes' it:
   
   Caused by: java.io.IOException: Server returned HTTP response code: 403 for 
URL: https://osgi.org/javadoc/r6/core//package-list
   at sun.net.www.protocol.http.HttpURLConnection.getInputStream0 
(HttpURLConnection.java:1894)
   at sun.net.www.protocol.http.HttpURLConnection.getInputStream 
(HttpURLConnection.java:1492)
   at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream 
(HttpsURLConnectionImpl.java:263)
   at org.apache.sling.feature.maven.mojos.apis.ApisUtil.getPackageList 
(ApisUtil.java:145)
   at org.apache.sling.feature.maven.mojos.apis.JavadocLinks.calculateLinks 
(JavadocLinks.java:44)
   at org.apache.sling.feature.maven.mojos.ApisJarMojo.onFeature 
(ApisJarMojo.java:585)
   at org.apache.sling.feature.maven.mojos.ApisJarMojo.execute 
(ApisJarMojo.java:407)
   
   Master has the same issue. I think osgi.org is down.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9968) ObjectModel.toString() should support more classes

[Konrad Windszus (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259158#comment-17259158
 ] 

Konrad Windszus commented on SLING-9968:


My plan was only to extend the {{toString()}} method, not any other method. 
IMHO {{SlingRuntimeObjectModel}} only overrides {{toBoolean()}} but not 
{{toString()}}.
Is there any particular reason why Enum.name() is called instead of 
Enum.toString()? This is rather unexpected IMHO.

> ObjectModel.toString() should support more classes
> --
>
> Key: SLING-9968
> URL: https://issues.apache.org/jira/browse/SLING-9968
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.4.6-1.4.0
>Reporter: Konrad Windszus
>Priority: Major
>
> For getter methods returning e.g. a {{java.net.URI}} there is no implicit 
> {{toString()}} being applied. When looking at the HTL specs it seems not 
> defined how to deal with complex objects 
> (https://github.com/adobe/htl-spec/blob/master/SPECIFICATION.md#1152-string), 
> but given that enums and primitives are automatically converted 
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/blob/6cbd676a8875af756e6e43b38c39ba9e4784dc4e/src/main/java/org/apache/sling/scripting/sightly/render/ObjectModel.java#L238)
>  already, I am wondering why other types like {{URI}} or {{URL}} are not 
> supported.
> Is there any harm when doing object.toString() as fallback?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] commented on pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox]

sonarcloud[bot] commented on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#issuecomment-754837694


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=15=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_coverage=list)
 [92.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] sonarcloud[bot] removed a comment on pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox]

sonarcloud[bot] removed a comment on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#issuecomment-749611125


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=15=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=15=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-graphql-core=15=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-graphql-core=15=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_coverage=list)
 [92.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-graphql-core=15=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10012) Lookup of precompiled template files does not work

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259051#comment-17259051
 ] 

Radu Cotescu commented on SLING-10012:
--

[~kwin], I see what the problem is and we've encountered something similar in 
the JS Use Provider too. There are two possibilities when starting a rendering 
chain:
 # the resource type of the accessed resource performs the rendering directly, 
via its own resource type label script
 # the resource type of the accessed resource delegates the rendering to a 
parent resource type ({{sling:resourceSuperType}} or via the {{extends}} file 
specific to bundled scripts)

Your example falls into the second category. For this there's indeed a bug in 
the implementation, in the sense that only the {{TypeProvider}} chain of the 
resource type that drives the rendering is queried for script dependencies. 
However, the correct approach would be to always start from the 
{{TypeProvider}} chain of the current resource type, rather than the one 
driving the rendering, and do a fallback to the latter if no dependency was 
found.

> Lookup of precompiled template files does not work
> --
>
> Key: SLING-10012
> URL: https://issues.apache.org/jira/browse/SLING-10012
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.4.6-1.4.0
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
>
> I have a resource type {{a}} with a bundled script {{a.html}} which contains
> {code}
> data-sly-call="${simpleTemplate.simple}">
> {code} 
> I have an extended resource type {{myA}} which has {{a}} as 
> resourceSuperType. That one contains {{simple.html}} as precompiled script 
> file. Still the lookup when trying to render a resource based on {{myA}} 
> fails with
> {code}
> Caused by: org.apache.sling.scripting.sightly.SightlyException: No use 
> provider could resolve identifier simple.html
>   at 
> org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:79)
>  [org.apache.sling.scripting.sightly:1.4.6.140]
>   at 
> org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:72)
>  [org.apache.sling.scripting.sightly:1.4.6.140]
>   at 
> org.apache.sling.scripting.sightly.__002e__html.render(container__002e__html.java:62)
> {code}
> It works fine when trying to render a resource directly leveraging {{a}}, but 
> in that case obviously the bundled {{a/simple.html}} is used
> Seems that the fix from SLING-9718 has not yet covered this use case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12

[Karl Pauls (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259049#comment-17259049
 ] 

Karl Pauls commented on SLING-9824:
---

[~rombert], isn't the resolution to just add the bootdelegation to the 
framework properties in the starter?

[0] 
https://github.com/apache/sling-org-apache-sling-starter/blob/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a/src/main/features/boot.json#L137

> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11 
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
> Fix For: Starter 12
>
>
> We are having some trouble running our application on [the current Sling 
> Starter 12 
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
>  since we are using ehache 3, which uses sun.misc.Unsafe internally. This 
> works with Sling Starter 11, but since Sling Starter changed to the feature 
> launcher, this class seems to have disappeared from the classpath: the class 
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError: 
> sun/misc/Unsafe
> I tried to add command line arguments
>  --add-modules=jdk.unsupported
>  and
>  --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
>  to the launcher command line, as I've seen that suggested on the net for 
> similar problems, but it didn't help.
>  In fact, this doesn't seem to be the problem: even without those flags the 
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports: 
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
>  <%
>  Class clazz = sun.misc.Unsafe.class;
>  %>
>  In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on 
> an x86_64 Linux.
>  This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add 
>  {{-D org.osgi.framework.system.packages.extra=sun.misc}}
>  to the command line, which was thankfully suggested [in the mailing 
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does 
> work. But I feel it is not a particularily clean solution. It also does 
> something else than what happens on Sling Starter 11 : now the sun.misc 
> package is listed in the exports list of the felix framework bundle 
>  [http://localhost:9090/system/console/bundles/0] . Not sure whether this is 
> good or bad.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9968) ObjectModel.toString() should support more classes

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259045#comment-17259045
 ] 

Radu Cotescu commented on SLING-9968:
-

[~kwin], feel free to add support for converting more object types. FTR, there 
are some overrides at different levels - see 
https://github.com/apache/sling-org-apache-sling-scripting-sightly/blob/master/src/main/java/org/apache/sling/scripting/sightly/impl/engine/runtime/SlingRuntimeObjectModel.java
 for an example.

> ObjectModel.toString() should support more classes
> --
>
> Key: SLING-9968
> URL: https://issues.apache.org/jira/browse/SLING-9968
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.4.6-1.4.0
>Reporter: Konrad Windszus
>Priority: Major
>
> For getter methods returning e.g. a {{java.net.URI}} there is no implicit 
> {{toString()}} being applied. When looking at the HTL specs it seems not 
> defined how to deal with complex objects 
> (https://github.com/adobe/htl-spec/blob/master/SPECIFICATION.md#1152-string), 
> but given that enums and primitives are automatically converted 
> (https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/blob/6cbd676a8875af756e6e43b38c39ba9e4784dc4e/src/main/java/org/apache/sling/scripting/sightly/render/ObjectModel.java#L238)
>  already, I am wondering why other types like {{URI}} or {{URL}} are not 
> supported.
> Is there any harm when doing object.toString() as fallback?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259044#comment-17259044
 ] 

Robert Munteanu commented on SLING-9824:


It would be good to have a solution for this, as it's a regression. 

> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11 
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
> Fix For: Starter 12
>
>
> We are having some trouble running our application on [the current Sling 
> Starter 12 
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
>  since we are using ehache 3, which uses sun.misc.Unsafe internally. This 
> works with Sling Starter 11, but since Sling Starter changed to the feature 
> launcher, this class seems to have disappeared from the classpath: the class 
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError: 
> sun/misc/Unsafe
> I tried to add command line arguments
>  --add-modules=jdk.unsupported
>  and
>  --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
>  to the launcher command line, as I've seen that suggested on the net for 
> similar problems, but it didn't help.
>  In fact, this doesn't seem to be the problem: even without those flags the 
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports: 
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
>  <%
>  Class clazz = sun.misc.Unsafe.class;
>  %>
>  In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on 
> an x86_64 Linux.
>  This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add 
>  {{-D org.osgi.framework.system.packages.extra=sun.misc}}
>  to the command line, which was thankfully suggested [in the mailing 
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does 
> work. But I feel it is not a particularily clean solution. It also does 
> something else than what happens on Sling Starter 11 : now the sun.misc 
> package is listed in the exports list of the felix framework bundle 
>  [http://localhost:9090/system/console/bundles/0] . Not sure whether this is 
> good or bad.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9824) sun.misc.Unsafe accessible in Sling Starter 12

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-9824:
---
Fix Version/s: Starter 12

> sun.misc.Unsafe accessible in Sling Starter 12
> --
>
> Key: SLING-9824
> URL: https://issues.apache.org/jira/browse/SLING-9824
> Project: Sling
>  Issue Type: Bug
>  Components: Starter
>Affects Versions: Starter 12
> Environment: Sling-Starter 12-SNAPSHOT (commit addb8f7b) with JDK 11 
> and 13 on MacOS, JDK 11 on an x86_64 Linux
>Reporter: Hans-Peter Stoerr
>Priority: Minor
> Fix For: Starter 12
>
>
> We are having some trouble running our application on [the current Sling 
> Starter 12 
> snapshot|https://github.com/apache/sling-org-apache-sling-starter/tree/addb8f7ba16dfb2ab6cda1a70f98a461a7cacb7a]
>  since we are using ehache 3, which uses sun.misc.Unsafe internally. This 
> works with Sling Starter 11, but since Sling Starter changed to the feature 
> launcher, this class seems to have disappeared from the classpath: the class 
> loading of ehcache classes fails with a java.lang.NoClassDefFoundError: 
> sun/misc/Unsafe
> I tried to add command line arguments
>  --add-modules=jdk.unsupported
>  and
>  --add-opens=jdk.unsupported/sun.misc=ALL-UNNAMED
>  to the launcher command line, as I've seen that suggested on the net for 
> similar problems, but it didn't help.
>  In fact, this doesn't seem to be the problem: even without those flags the 
> jdk.unsupported module does export sun.misc:
> module
> { name: jdk.unsupported@11.0.6, [mandated java.base], exports: 
> [com.sun.nio.file, sun.misc, sun.reflect], opens: [sun.misc, sun.reflect] }
> So it seems the module is loaded, but not used to load the class.
> The easiest way to reproduce the problem is to add this to some JSP:
>  <%
>  Class clazz = sun.misc.Unsafe.class;
>  %>
>  In case that matters: I tried JDK 11 and 13 on MacOS, as well as JDK 11 on 
> an x86_64 Linux.
>  This works on Sling Starter 11, but not the current 12 snapshot.
> The workaround to add 
>  {{-D org.osgi.framework.system.packages.extra=sun.misc}}
>  to the command line, which was thankfully suggested [in the mailing 
> list|https://www.mail-archive.com/users@sling.apache.org/msg05423.html], does 
> work. But I feel it is not a particularily clean solution. It also does 
> something else than what happens on Sling Starter 11 : now the sun.misc 
> package is listed in the exports list of the felix framework bundle 
>  [http://localhost:9090/system/console/bundles/0] . Not sure whether this is 
> good or bad.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9999) Remove cyclic dependency between scripting and servlets features

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259043#comment-17259043
 ] 

Radu Cotescu commented on SLING-:
-

If we still go forward with these changes, then we'll also have to touch 
https://github.com/apache/sling-scriptingbundle-maven-plugin, since it uses the 
{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}.

> Remove cyclic dependency between scripting and servlets features
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Karaf, Scripting, Servlets, Starter
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Before {{org.apache.sling.scripting.core.impl.bundled}} and 
> {{org.apache.sling.servlets.resolver.bundle}} were added the dependency chain 
> were e.g.
> {{sling-servlets}} → {{sling-scripting}} → {{sling}}
> {{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}
> Currently several _scripting_ modules depend on 
> {{org.apache.sling.servlets.resolver.bundle.tracker}}.
> h2. Move _Bundle_ API to Scripting and Resource packages (modules)
> ||Actual Package (Module)||Target Package (Module)||
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker. 
> BundledRenderUnitCapability}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
>  
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}*
>  ({{org.apache.sling.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}*
>  (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})|
> 
> ||Module||Commits||Status||
> |{{org.apache.sling.api}}|[02cb7f1|https://github.com/apache/sling-org-apache-sling-api/commit/02cb7f1bbc4836865afd7e9964d3be1380daf734]|(/)|
> |{{org.apache.sling.scripting.api}}|[d38759d|https://github.com/apache/sling-org-apache-sling-scripting-api/commit/d38759dbd3d4159f70ea54bff23b037be8d07cd6]|(/)|
> |{{org.apache.sling.scripting.core}}|[b2f368a|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/b2f368a90a087979c34d8072fe529675971234fe],
>  
> [1467cfa|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/1467cfa6a3fe4c77a628d078f9d944ce4cc42eb1]|(/)|
> |{{org.apache.sling.scripting.jsp}}|[ccdb902|https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/ccdb90266f254bb2143a5d870725a8f4b28d4d8b]|(/)|
> |{{org.apache.sling.scripting.sightly}}|[1567894|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/1567894f6c1835a317c01e6c5b5987a260a74757],
>  
> [b2f57cd|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/b2f57cd43d7d961fcf194cf7bf61b1c79f343d44]|(/)|
> |{{org.apache.sling.servlets.resolver}}|[8262ce6|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/8262ce63725b9ab93c1d3eb07ace6b02d79acc65]|(!)
>  probably more classes which should be living in a scripting module|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9999) Remove cyclic dependency between scripting and servlets features

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17259038#comment-17259038
 ] 

Radu Cotescu commented on SLING-:
-

[~olli], with 
[https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/8262ce63725b9ab93c1d3eb07ace6b02d79acc65]
 we now have a forced dependency chain between {{o.a.s.servlets.resolver}} and 
{{o.a.s.scripting.api}}, where the former cannot be deployed without the 
latter. IMO, the {{o.a.s.servlets.resolver}} should still be deployable on its 
own, without scripting support, since one can very well develop a Sling App 
without any kind of server-side scripts.

Wouldn't we achieve what you want by rather making the 
{{o.a.s.servlets.resolver}} an optional import on all the scripting modules 
that could use that functionality, similarly to SLING-9693? I think that both 
the JSP engine and the HTL one could be slightly changed to work with an 
optional import (if they don't already).



> Remove cyclic dependency between scripting and servlets features
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Karaf, Scripting, Servlets, Starter
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Before {{org.apache.sling.scripting.core.impl.bundled}} and 
> {{org.apache.sling.servlets.resolver.bundle}} were added the dependency chain 
> were e.g.
> {{sling-servlets}} → {{sling-scripting}} → {{sling}}
> {{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}
> Currently several _scripting_ modules depend on 
> {{org.apache.sling.servlets.resolver.bundle.tracker}}.
> h2. Move _Bundle_ API to Scripting and Resource packages (modules)
> ||Actual Package (Module)||Target Package (Module)||
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker. 
> BundledRenderUnitCapability}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
>  
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}*
>  ({{org.apache.sling.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}*
>  (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})|
> 
> ||Module||Commits||Status||
> |{{org.apache.sling.api}}|[02cb7f1|https://github.com/apache/sling-org-apache-sling-api/commit/02cb7f1bbc4836865afd7e9964d3be1380daf734]|(/)|
> |{{org.apache.sling.scripting.api}}|[d38759d|https://github.com/apache/sling-org-apache-sling-scripting-api/commit/d38759dbd3d4159f70ea54bff23b037be8d07cd6]|(/)|
> |{{org.apache.sling.scripting.core}}|[b2f368a|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/b2f368a90a087979c34d8072fe529675971234fe],
>  
> [1467cfa|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/1467cfa6a3fe4c77a628d078f9d944ce4cc42eb1]|(/)|
> |{{org.apache.sling.scripting.jsp}}|[ccdb902|https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/ccdb90266f254bb2143a5d870725a8f4b28d4d8b]|(/)|
> |{{org.apache.sling.scripting.sightly}}|[1567894|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/1567894f6c1835a317c01e6c5b5987a260a74757],
>  
> [b2f57cd|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/b2f57cd43d7d961fcf194cf7bf61b1c79f343d44]|(/)|
> |{{org.apache.sling.servlets.resolver}}|[8262ce6|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/8262ce63725b9ab93c1d3eb07ace6b02d79acc65]|(!)
>  probably more classes which should be living in a scripting module|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10042) Remove read permission on /content for everyone

[Oliver Lietz (Jira)]

Oliver Lietz created SLING-10042:


 Summary: Remove read permission on /content for everyone
 Key: SLING-10042
 URL: https://issues.apache.org/jira/browse/SLING-10042
 Project: Sling
  Issue Type: Task
  Components: Karaf
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Karaf Launchpad Integration Tests (Oak Tar) 0.0.12, Karaf 
Integration Tests 1.0.0, Karaf Features 1.0.0, Karaf Configs 1.0.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] tyge68 commented on pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox]

tyge68 commented on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#issuecomment-754691466


   @raducotescu  @stefangrimm  I have added the ProviderType annotation, then 
improved the javadoc with more details, and added more cases to the test. 
Please let me know if that help to better understand this add on.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10012) Lookup of precompiled template files does not work

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258959#comment-17258959
 ] 

Radu Cotescu commented on SLING-10012:
--

Back from the winter holidays. Thanks for the investigation, [~kwin], I'll try 
to have a look at this issue later this afternoon (CET).

> Lookup of precompiled template files does not work
> --
>
> Key: SLING-10012
> URL: https://issues.apache.org/jira/browse/SLING-10012
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.4.6-1.4.0
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
>
> I have a resource type {{a}} with a bundled script {{a.html}} which contains
> {code}
> data-sly-call="${simpleTemplate.simple}">
> {code} 
> I have an extended resource type {{myA}} which has {{a}} as 
> resourceSuperType. That one contains {{simple.html}} as precompiled script 
> file. Still the lookup when trying to render a resource based on {{myA}} 
> fails with
> {code}
> Caused by: org.apache.sling.scripting.sightly.SightlyException: No use 
> provider could resolve identifier simple.html
>   at 
> org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:79)
>  [org.apache.sling.scripting.sightly:1.4.6.140]
>   at 
> org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:72)
>  [org.apache.sling.scripting.sightly:1.4.6.140]
>   at 
> org.apache.sling.scripting.sightly.__002e__html.render(container__002e__html.java:62)
> {code}
> It works fine when trying to render a resource directly leveraging {{a}}, but 
> in that case obviously the bundled {{a/simple.html}} is used
> Seems that the fix from SLING-9718 has not yet covered this use case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-10012) Lookup of precompiled template files does not work

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu reassigned SLING-10012:


Assignee: Radu Cotescu

> Lookup of precompiled template files does not work
> --
>
> Key: SLING-10012
> URL: https://issues.apache.org/jira/browse/SLING-10012
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting HTL Engine 1.4.6-1.4.0
>Reporter: Konrad Windszus
>Assignee: Radu Cotescu
>Priority: Major
>
> I have a resource type {{a}} with a bundled script {{a.html}} which contains
> {code}
> data-sly-call="${simpleTemplate.simple}">
> {code} 
> I have an extended resource type {{myA}} which has {{a}} as 
> resourceSuperType. That one contains {{simple.html}} as precompiled script 
> file. Still the lookup when trying to render a resource based on {{myA}} 
> fails with
> {code}
> Caused by: org.apache.sling.scripting.sightly.SightlyException: No use 
> provider could resolve identifier simple.html
>   at 
> org.apache.sling.scripting.sightly.impl.engine.extension.use.UseRuntimeExtension.call(UseRuntimeExtension.java:79)
>  [org.apache.sling.scripting.sightly:1.4.6.140]
>   at 
> org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImpl.call(RenderContextImpl.java:72)
>  [org.apache.sling.scripting.sightly:1.4.6.140]
>   at 
> org.apache.sling.scripting.sightly.__002e__html.render(container__002e__html.java:62)
> {code}
> It works fine when trying to render a resource directly leveraging {{a}}, but 
> in that case obviously the bundled {{a/simple.html}} is used
> Seems that the fix from SLING-9718 has not yet covered this use case.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] tyge68 commented on a change in pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox]

tyge68 commented on a change in pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#discussion_r551954024



##
File path: 
src/test/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutorTest.java
##
@@ -188,4 +191,30 @@ public void unionFetcherTest() throws Exception {
 assertThat(json, 
hasJsonPath("$.data.unionFetcher.items[0].testingArgument", equalTo("1, 2, 
3")));
 assertThat(json, hasJsonPath("$.data.unionFetcher.items[1].path", 
equalTo(resource.getPath(;
 }
+
+@Test
+public void selectionSetTest() throws Exception {

Review comment:
   I will add a that in the test, only "inline" so currently in our cases 
Union would have the "type" as the name of the field.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-graphql-core] stefangrimm commented on a change in pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox]

stefangrimm commented on a change in pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#discussion_r551941984



##
File path: src/main/java/org/apache/sling/graphql/api/SelectionSet.java
##
@@ -0,0 +1,47 @@
+/*~~
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements.  See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership.  The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License.  You may obtain a copy of the License at
+ ~
+ ~   http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied.  See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ 
~*/
+package org.apache.sling.graphql.api;
+
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+import java.util.List;
+
+/**
+ * Interface to wrap GraphQL DataFetchingFieldSelectionSet.
+ */
+public interface SelectionSet {
+
+/**
+ * @return the immediate list of fields in the selection.
+ */
+@NotNull
+List getFields();
+
+/**
+ * @return true if the field qualified name exist.
+ */
+boolean contains(String qualifiedName);
+
+/**
+ * @return SelectedField for qualified name.

Review comment:
   The concept of "qualified name" should be explained (I don't want to 
have a look at the unit tests if I want to make use of an API, furthermore the 
unit tests only cover unions as a more complex use-case):
   
   - How does a "qualified name" look like?
   - How are things like unions and nested structures are reflected in the 
qualified name?

##
File path: 
src/test/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutorTest.java
##
@@ -188,4 +191,30 @@ public void unionFetcherTest() throws Exception {
 assertThat(json, 
hasJsonPath("$.data.unionFetcher.items[0].testingArgument", equalTo("1, 2, 
3")));
 assertThat(json, hasJsonPath("$.data.unionFetcher.items[1].path", 
equalTo(resource.getPath(;
 }
+
+@Test
+public void selectionSetTest() throws Exception {

Review comment:
   This only covers unions. I would suggest to add a test for "normal" 
nested structures as well, as it would also be interesting how they would be 
reflected in the output, mostly if the type name would be included as well or 
if that's only true for `union`s. Also it would be interesting for the latter 
case to determine if an item of the selection set determines a union 
differentiator or actual data, as we couldn't simply follow the result data in 
the fetcher implementation in this case.

##
File path: 
src/main/java/org/apache/sling/graphql/core/engine/SelectedFieldWrapper.java
##
@@ -0,0 +1,88 @@
+/*~~
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements.  See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership.  The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License.  You may obtain a copy of the License at
+ ~
+ ~   http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied.  See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ 
~*/
+package org.apache.sling.graphql.core.engine;
+
+import graphql.language.Field;
+import graphql.language.InlineFragment;
+import graphql.language.Selection;
+import graphql.language.SelectionSet;
+import org.apache.sling.graphql.api.SelectedField;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/**
+ * Implement a wrapper for GraphQL SelectedField.
+ */
+public class SelectedFieldWrapper implements SelectedField {
+
+private String name;
+private boolean isInline;
+private HashMap subFieldMap = new HashMap<>();
+private List subFields;
+
+public SelectedFieldWrapper(Selection selection) {
+

[jira] [Updated] (SLING-9999) Remove cyclic dependency between scripting and servlets features

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-:

Description: 
Before {{org.apache.sling.scripting.core.impl.bundled}} and 
{{org.apache.sling.servlets.resolver.bundle}} were added the dependency chain 
were e.g.

{{sling-servlets}} → {{sling-scripting}} → {{sling}}

{{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}

Currently several _scripting_ modules depend on 
{{org.apache.sling.servlets.resolver.bundle.tracker}}.
h2. Move _Bundle_ API to Scripting and Resource packages (modules)
||Actual Package (Module)||Target Package (Module)||
|*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}*
 ({{org.apache.sling.scripting.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker. 
BundledRenderUnitCapability}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}*
 ({{org.apache.sling.scripting.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}*
 ({{org.apache.sling.scripting.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}*
 ({{org.apache.sling.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}*
 (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})|

||Module||Commits||Status||
|{{org.apache.sling.api}}|[02cb7f1|https://github.com/apache/sling-org-apache-sling-api/commit/02cb7f1bbc4836865afd7e9964d3be1380daf734]|(/)|
|{{org.apache.sling.scripting.api}}|[d38759d|https://github.com/apache/sling-org-apache-sling-scripting-api/commit/d38759dbd3d4159f70ea54bff23b037be8d07cd6]|(/)|
|{{org.apache.sling.scripting.core}}|[b2f368a|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/b2f368a90a087979c34d8072fe529675971234fe],
 
[1467cfa|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/1467cfa6a3fe4c77a628d078f9d944ce4cc42eb1]|(/)|
|{{org.apache.sling.scripting.jsp}}|[ccdb902|https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/ccdb90266f254bb2143a5d870725a8f4b28d4d8b]|(/)|
|{{org.apache.sling.scripting.sightly}}|[1567894|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/1567894f6c1835a317c01e6c5b5987a260a74757],
 
[b2f57cd|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/b2f57cd43d7d961fcf194cf7bf61b1c79f343d44]|(/)|
|{{org.apache.sling.servlets.resolver}}|[8262ce6|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/8262ce63725b9ab93c1d3eb07ace6b02d79acc65]|(!)
 probably more classes which should be living in a scripting module|

  was:
Before {{org.apache.sling.scripting.core.impl.bundled}} and 
{{org.apache.sling.servlets.resolver.bundle}} were added the dependency chain 
were e.g.

{{sling-servlets}} → {{sling-scripting}} → {{sling}}

{{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}

Currently several _scripting_ modules depend on 
{{org.apache.sling.servlets.resolver.bundle.tracker}}.
h2. Move _Bundle_ API to Scripting and Resource packages (modules)
||Actual Package (Module)||Target Package (Module)||
|*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}*
 ({{org.apache.sling.scripting.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker. 
BundledRenderUnitCapability}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}*
 ({{org.apache.sling.scripting.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}*
 ({{org.apache.sling.scripting.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}*
 ({{org.apache.sling.api}})|
|*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}*
 (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})|

||Module||Commits||Status||
|{{org.apache.sling.api}}|[02cb7f1|https://github.com/apache/sling-org-apache-sling-api/commit/02cb7f1bbc4836865afd7e9964d3be1380daf734]|(/)|

[jira] [Resolved] (SLING-10031) Move MediaRangeList from Servlets POST to Sling API

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-10031.
--
Resolution: Done

> Move MediaRangeList from Servlets POST to Sling API
> ---
>
> Key: SLING-10031
> URL: https://issues.apache.org/jira/browse/SLING-10031
> Project: Sling
>  Issue Type: Task
>  Components: API, Servlets
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: API 2.23.2, Servlets POST 2.3.38
>
>
> {{org.apache.sling.servlets.post.impl.helper}} → 
> {{org.apache.sling.api.request.header}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10031) Move MediaRangeList from Servlets POST to Sling API

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-10031:
-
Description: {{org.apache.sling.servlets.post.impl.helper}} → 
{{org.apache.sling.api.request.header}}  (was: 
{{org.apache.sling.servlets.post.impl.helper}} → 
{{org.apache.sling.api.request}})

> Move MediaRangeList from Servlets POST to Sling API
> ---
>
> Key: SLING-10031
> URL: https://issues.apache.org/jira/browse/SLING-10031
> Project: Sling
>  Issue Type: Task
>  Components: API, Servlets
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: API 2.23.2, Servlets POST 2.3.38
>
>
> {{org.apache.sling.servlets.post.impl.helper}} → 
> {{org.apache.sling.api.request.header}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10031) Move MediaRangeList from Servlets POST to Sling API

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258893#comment-17258893
 ] 

Oliver Lietz commented on SLING-10031:
--

{{MediaRangeList}} moved to package {{org.apache.sling.api.request.header}}, 
consumer type annotation added.

> Move MediaRangeList from Servlets POST to Sling API
> ---
>
> Key: SLING-10031
> URL: https://issues.apache.org/jira/browse/SLING-10031
> Project: Sling
>  Issue Type: Task
>  Components: API, Servlets
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: API 2.23.2, Servlets POST 2.3.38
>
>
> {{org.apache.sling.servlets.post.impl.helper}} → 
> {{org.apache.sling.api.request}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10029) Remove Guava dependency

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258880#comment-17258880
 ] 

Robert Munteanu commented on SLING-10029:
-

[~olli] - I guess something like {{new HashSet<>(Arrays.asList("..."))}} should 
work.

> Remove Guava dependency
> ---
>
> Key: SLING-10029
> URL: https://issues.apache.org/jira/browse/SLING-10029
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.2.12
>
>
> Guava is used in a single place to create an immutable set, but there is 
> still the transitive dependency from {{oak-core}} {{1.36}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on a change in pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox]

raducotescu commented on a change in pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#discussion_r551900231



##
File path: src/main/java/org/apache/sling/graphql/api/SelectedField.java
##
@@ -0,0 +1,58 @@
+/*~~
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements.  See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership.  The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License.  You may obtain a copy of the License at
+ ~
+ ~   http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied.  See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ 
~*/
+package org.apache.sling.graphql.api;
+
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+import java.util.List;
+
+/**
+ * Interface to wrap GraphQL SelectedField.
+ */
+public interface SelectedField {

Review comment:
   The whole class needs a bit more details in its JavaDocs. In addition to 
that, I suspect that this will be a `@ProviderType`, right?

##
File path: src/main/java/org/apache/sling/graphql/api/SelectionSet.java
##
@@ -0,0 +1,47 @@
+/*~~
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements.  See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership.  The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License.  You may obtain a copy of the License at
+ ~
+ ~   http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied.  See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ 
~*/
+package org.apache.sling.graphql.api;
+
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+import java.util.List;
+
+/**
+ * Interface to wrap GraphQL DataFetchingFieldSelectionSet.
+ */
+public interface SelectionSet {

Review comment:
   The whole class needs a bit more details in its JavaDocs. In addition to 
that, I suspect that this will be a `@ProviderType`, right?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10029) Remove Guava dependency

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258867#comment-17258867
 ] 

Oliver Lietz commented on SLING-10029:
--

[~rombert], I guess immutability is not the point here but construction and 
initialization with values in one go.
{noformat}
// lucene full-text index
if (!index.hasChildNode("lucene")) {
LuceneIndexHelper.newLuceneIndexDefinition(
index, "lucene", LuceneIndexHelper.JR_PROPERTY_INCLUDES,
of(
"jcr:createdBy",
"jcr:lastModifiedBy",
"sling:alias",
"sling:resourceType",
"sling:vanityPath"),
"async");
}
 {noformat}

> Remove Guava dependency
> ---
>
> Key: SLING-10029
> URL: https://issues.apache.org/jira/browse/SLING-10029
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.2.12
>
>
> Guava is used in a single place to create an immutable set, but there is 
> still the transitive dependency from {{oak-core}} {{1.36}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10041) Support the filter patterns of the cp2fm tool

[A. J. David Bosschaert (Jira)]

A. J. David Bosschaert created SLING-10041:
--

 Summary: Support the filter patterns of the cp2fm tool
 Key: SLING-10041
 URL: https://issues.apache.org/jira/browse/SLING-10041
 Project: Sling
  Issue Type: New Feature
  Components: Maven Plugins and Archetypes
Affects Versions: Feature Model Converter Plugin 1.0.10
Reporter: A. J. David Bosschaert
Assignee: A. J. David Bosschaert
 Fix For: Feature Model Converter Plugin 1.0.12


The cp2fm tool supports filter patterns, which can be specified with the {{-f}} 
option. The Maven Plugin should support these too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-site] kwin merged pull request #53: SLING-10036 add information about Maven Central and different artifact

[GitBox]

kwin merged pull request #53:
URL: https://github.com/apache/sling-site/pull/53


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9997) Add missing OSGi capabilities

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258838#comment-17258838
 ] 

Robert Munteanu commented on SLING-9997:


[~olli] - last I checked there was a GitHub/Jira integration added by the ASF 
infra team that worked on the basis of pull requests, see 
https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features#git.asf.yamlfeatures-Jiranotificationoptions
 . 

I don't see anything related to the "native" SCM integration. I vaguely 
remember asking infra about it at some point but I can't find the Jira 
issue/email right now.

> Add missing OSGi capabilities
> -
>
> Key: SLING-9997
> URL: https://issues.apache.org/jira/browse/SLING-9997
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Engine 2.7.4
>
>
> {noformat}
> Provide-Capability:\
>osgi.service;objectClass=org.apache.sling.engine.SlingRequestProcessor,\
>osgi.service;objectClass=javax.servlet.ServletContext
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10029) Remove Guava dependency

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258835#comment-17258835
 ] 

Robert Munteanu commented on SLING-10029:
-

[~olli] - I think we should stay with 8 until we decide to move to Java 11 with 
Sling, as oak-server is fundamental to Sling apps. 

I would argue though that the usage of an immutable set when creating the 
Lucene index definition is more of a style issue, so we can pass any kind of 
set to it. And we can create the immutable set "by hand" anyway.

> Remove Guava dependency
> ---
>
> Key: SLING-10029
> URL: https://issues.apache.org/jira/browse/SLING-10029
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.2.12
>
>
> Guava is used in a single place to create an immutable set, but there is 
> still the transitive dependency from {{oak-core}} {{1.36}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Release Parent 41

[Oliver Lietz]

On Wednesday, December 30, 2020 11:49:11 AM CET Konrad Windszus wrote:
> Hi,
> if it is urgent, we can do it right away. However, I am currently working on
> https://issues.apache.org/jira/browse/SLING-7534
> . I was finally able to
> deploy the SHA512 of only the "source-release" artifact to the Maven
> Staging Repo with the help of
> https://github.com/nicoulaj/checksum-maven-plugin/issues/100
> . I hope that
> this will be included in the next release of the checksum-maven-plugin
> which should be published soon (tm). Afterwards I will include it in the
> Sling Parent and do a new release anyways

Thanks, Konrad.

It's not urgent but I would like to update and release around a dozen bundles.
So soon™ would help.

Regards,
O.


> Thanks,
> Konrad
> 
> > On 30. Dec 2020, at 09:38, Oliver Lietz  wrote:
> > 
> > Hi *,
> > 
> > Are there any blockers for 41 or could we move the unresolved issues to 42
> > and release Parent 41?
> > 
> > Thanks,
> > O.

[jira] [Commented] (SLING-10029) Remove Guava dependency

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258820#comment-17258820
 ] 

Oliver Lietz commented on SLING-10029:
--

[~rombert], If switching to Java 11 (9) is fine for JCR Oak Server we can use 
{{java.util.Set.of}} instead of {{com.google.common.collect.ImmutableSet.of}}.

> Remove Guava dependency
> ---
>
> Key: SLING-10029
> URL: https://issues.apache.org/jira/browse/SLING-10029
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.2.12
>
>
> Guava is used in a single place to create an immutable set, but there is 
> still the transitive dependency from {{oak-core}} {{1.36}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10029) Remove Guava dependency

[Robert Munteanu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258809#comment-17258809
 ] 

Robert Munteanu commented on SLING-10029:
-

I think that we should still remove our own usages. Perhaps, in time, we'll be 
able to shade a private Guava version and no longer ship a Guava bundle.

> Remove Guava dependency
> ---
>
> Key: SLING-10029
> URL: https://issues.apache.org/jira/browse/SLING-10029
> Project: Sling
>  Issue Type: Task
>  Components: JCR, Oak
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.2.12
>
>
> Guava is used in a single place to create an immutable set, but there is 
> still the transitive dependency from {{oak-core}} {{1.36}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9554) Documentation issue: Typo at https://sling.apache.org/documentation/bundles/resource-filter.html

[Robert Munteanu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-9554.

  Assignee: Oliver Lietz
Resolution: Fixed

[~bilaltk] - I see Olli has already merged this, so resolving. Thanks a lot for 
the PR!

> Documentation issue: Typo at 
> https://sling.apache.org/documentation/bundles/resource-filter.html
> 
>
> Key: SLING-9554
> URL: https://issues.apache.org/jira/browse/SLING-9554
> Project: Sling
>  Issue Type: Improvement
>Reporter: Bilal T
>Assignee: Oliver Lietz
>Priority: Trivial
>  Labels: documentation-update
> Attachments: image-2020-06-26-15-24-49-131.png, 
> image-2020-06-26-15-27-06-997.png
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Highlighted word should Collectors (java.util.stream.Collectors ) and not 
> Collections
> !image-2020-06-26-15-27-06-997.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10000) Switch to Jakarta APIs

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-1:
-
Description: 
Java EE APIs are switching from {{javax}} to {{jakarta}}.

Jakarta Specifications: [https://jakarta.ee/specifications/]

*Candidates*
 * {{javax.activation}}
 * {{javax.servlet}}
 * {{javax.mail}}

*Discovery*
 * Should we have branch {{jakarta}} in each module which needs to switch?
 * Should we use the breaking change (major version increase in most APIs) to 
clean up and improve our current API or limit it to the package switch?

*Tooling*
 * [Eclipse Transformer|https://github.com/eclipse/transformer]

  was:
Java EE APIs are switching from {{javax}} to {{jakarta}}.

Jakarta Specifications: [https://jakarta.ee/specifications/]

*Candidates*
 * {{javax.activation}}
 * {{javax.servlet}}
 * {{javax.mail}}

*Discovery*
 * Should we have branch {{jakarta}} in each module which needs to switch?
 * Should we use the breaking change (major version increase in most APIs) to 
clean up and improve our current API or limit it to the package switch?


> Switch to Jakarta APIs
> --
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: API
>Reporter: Oliver Lietz
>Priority: Major
>
> Java EE APIs are switching from {{javax}} to {{jakarta}}.
> Jakarta Specifications: [https://jakarta.ee/specifications/]
> *Candidates*
>  * {{javax.activation}}
>  * {{javax.servlet}}
>  * {{javax.mail}}
> *Discovery*
>  * Should we have branch {{jakarta}} in each module which needs to switch?
>  * Should we use the breaking change (major version increase in most APIs) to 
> clean up and improve our current API or limit it to the package switch?
> *Tooling*
>  * [Eclipse Transformer|https://github.com/eclipse/transformer]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-10000) Switch to Jakarta APIs

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258794#comment-17258794
 ] 

Oliver Lietz edited comment on SLING-1 at 1/5/21, 10:04 AM:


[~cziegeler], That's the magic I was hoping for.


was (Author: olli):
[~cziegeler], That's the magic is was hoping for.

> Switch to Jakarta APIs
> --
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: API
>Reporter: Oliver Lietz
>Priority: Major
>
> Java EE APIs are switching from {{javax}} to {{jakarta}}.
> Jakarta Specifications: [https://jakarta.ee/specifications/]
> *Candidates*
>  * {{javax.activation}}
>  * {{javax.servlet}}
>  * {{javax.mail}}
> *Discovery*
>  * Should we have branch {{jakarta}} in each module which needs to switch?
>  * Should we use the breaking change (major version increase in most APIs) to 
> clean up and improve our current API or limit it to the package switch?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-graphql-core] raducotescu commented on pull request #15: SLING-10018 Implement SelectionSet / SelectedField wrappers

[GitBox]

raducotescu commented on pull request #15:
URL: 
https://github.com/apache/sling-org-apache-sling-graphql-core/pull/15#issuecomment-754535379


   The API changes look ok to me. The only thing that I'd like to see in the 
API definitions are the JSR-305 annotations.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10000) Switch to Jakarta APIs

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258794#comment-17258794
 ] 

Oliver Lietz commented on SLING-1:
--

[~cziegeler], That's the magic is was hoping for.

> Switch to Jakarta APIs
> --
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: API
>Reporter: Oliver Lietz
>Priority: Major
>
> Java EE APIs are switching from {{javax}} to {{jakarta}}.
> Jakarta Specifications: [https://jakarta.ee/specifications/]
> *Candidates*
>  * {{javax.activation}}
>  * {{javax.servlet}}
>  * {{javax.mail}}
> *Discovery*
>  * Should we have branch {{jakarta}} in each module which needs to switch?
>  * Should we use the breaking change (major version increase in most APIs) to 
> clean up and improve our current API or limit it to the package switch?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10000) Switch to Jakarta APIs

[Oliver Lietz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258790#comment-17258790
 ] 

Oliver Lietz commented on SLING-1:
--

[~cziegeler], [~rombert], Following up on discussion in SLING-10031, should we 
prepare an API cleanup/improvement and roll it out once we switch to Jakarta?

> Switch to Jakarta APIs
> --
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: API
>Reporter: Oliver Lietz
>Priority: Major
>
> Java EE APIs are switching from {{javax}} to {{jakarta}}.
> Jakarta Specifications: [https://jakarta.ee/specifications/]
> *Candidates*
>  * {{javax.activation}}
>  * {{javax.servlet}}
>  * {{javax.mail}}
> *Discovery*
>  * Should we have branch {{jakarta}} in each module which needs to switch?
>  * Should we use the breaking change (major version increase in most APIs) to 
> clean up and improve our current API or limit it to the package switch?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10000) Switch to Jakarta APIs

[Carsten Ziegeler (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258784#comment-17258784
 ] 

Carsten Ziegeler commented on SLING-1:
--

In general, we should only switch, if there is a real need.
I haven't looked in detail into it, but maybe 
https://github.com/eclipse/transformer can help here (for example by rewriting 
bundles using the old api to use the new api), avoiding branches and deploying 
two versions in parallel

> Switch to Jakarta APIs
> --
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: API
>Reporter: Oliver Lietz
>Priority: Major
>
> Java EE APIs are switching from {{javax}} to {{jakarta}}.
> Jakarta Specifications: [https://jakarta.ee/specifications/]
> *Candidates*
>  * {{javax.activation}}
>  * {{javax.servlet}}
>  * {{javax.mail}}
> *Discovery*
>  * Should we have branch {{jakarta}} in each module which needs to switch?
>  * Should we use the breaking change (major version increase in most APIs) to 
> clean up and improve our current API or limit it to the package switch?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-slingfeature-maven-plugin] bosschaert commented on pull request #63: Added the creation of the Generated Feature Model folder it is does n…

[GitBox]

bosschaert commented on pull request #63:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/63#issuecomment-754516061


   What are these failing CI runs about?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10000) Switch to Jakarta APIs

[Oliver Lietz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz updated SLING-1:
-
Description: 
Java EE APIs are switching from {{javax}} to {{jakarta}}.

Jakarta Specifications: [https://jakarta.ee/specifications/]

*Candidates*
 * {{javax.activation}}
 * {{javax.servlet}}
 * {{javax.mail}}

*Discovery*
 * Should we have branch {{jakarta}} in each module which needs to switch?
 * Should we use the breaking change (major version increase in most APIs) to 
clean up and improve our current API or limit it to the package switch?

  was:
Java EE APIs are switching from {{javax}} to {{jakarta}}.

Jakarta Specifications: [https://jakarta.ee/specifications/]

*Candidates*
 * {{javax.activation}}
 * {{javax.servlet}}
 * {{javax.mail}}

*Discovery*
 * Should we have branch {{jakarta}} in each module which needs to switch?


> Switch to Jakarta APIs
> --
>
> Key: SLING-1
> URL: https://issues.apache.org/jira/browse/SLING-1
> Project: Sling
>  Issue Type: Task
>  Components: API
>Reporter: Oliver Lietz
>Priority: Major
>
> Java EE APIs are switching from {{javax}} to {{jakarta}}.
> Jakarta Specifications: [https://jakarta.ee/specifications/]
> *Candidates*
>  * {{javax.activation}}
>  * {{javax.servlet}}
>  * {{javax.mail}}
> *Discovery*
>  * Should we have branch {{jakarta}} in each module which needs to switch?
>  * Should we use the breaking change (major version increase in most APIs) to 
> clean up and improve our current API or limit it to the package switch?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-7966) Enhance the CLI by adding tool informations and more descriptive options

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7966.
-
Resolution: Later

> Enhance the CLI by adding tool informations and more descriptive options
> 
>
> Key: SLING-7966
> URL: https://issues.apache.org/jira/browse/SLING-7966
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Tooling
>Affects Versions: Feature Model Analyser 0.2.0
>Reporter: Simone Tripodi
>Priority: Major
>
> The proposal is about improving the user experience and doesn't intend to 
> change any existing feature.
> Currently, command output is really concise:
> {noformat}
> $ java org.apache.sling.feature.analyser.main.Main
> [INFO] Apache Sling Application Analyser
> [INFO] 
> [ERROR] Required argument missing: feature file
> {noformat}
> I would like to have it improved like described (but not included) in 
> SLING-7929:
> {noformat}
> $ java org.apache.sling.feature.analyser.main.Main
> Usage: sfa [-hqvX] -f= [-p=]
> Apache Sling Application Analyser
>   -f, --feature-file=
>   Set feature file.
>   -h, --help  Display the usage message.
>   -p, --plugin-class=
>   Explicitly specify plugin class to run, if ommitted the 
> default
> plugins are used
>   -q, --quiet Log errors only.
>   -v, --version   Display version information.
>   -X, --verbose   Produce execution debug output.
> Copyright(c) 2018 The Apache Software Foundation.
> {noformat}
> Pull request is coming



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-7929) Create a distribution package for the Feature Analyser

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-7929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7929.
-
Resolution: Later

> Create a distribution package for the Feature Analyser
> --
>
> Key: SLING-7929
> URL: https://issues.apache.org/jira/browse/SLING-7929
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Tooling
>Affects Versions: Feature Model Analyser 0.2.0
>Reporter: Simone Tripodi
>Priority: Major
>
> Packaging matters even if software distribution, I am going to submit a 
> proposal where the Analyser package can be distributed as a "product" like if 
> it was Apache Tomcat or Apache Maven, users will be able to download a 
> {{.zip}} or a {{.tar.gz}} package including required artifacts and 
> multi-platform binaries, the README with instructions of installation and 
> usage and, of course, legal files including NOTICE and LICENSE with enlisted 
> dependencies.
> {noformat}
> $ unzip org.apache.sling.feature.analyser-0.1.3-SNAPSHOT.zip 
> Archive:  org.apache.sling.feature.analyser-0.1.3-SNAPSHOT.zip
>creating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/
>creating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/bin/
>creating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/
>   inflating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/README.md  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.apache.sling.commons.johnzon-1.0.0.jar
>   
>   inflating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/LICENSE  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.apache.sling.feature.analyser-0.1.3-SNAPSHOT.jar
>   
>   inflating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/NOTICE  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/geronimo-json_1.0_spec-1.0-alpha-1.jar
>   
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.apache.felix.converter-1.0.0.jar
>   
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.apache.felix.configurator-1.0.4.jar
>   
>   inflating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/bin/sfa.bat  
>   inflating: org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/bin/sfa  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/osgi.core-6.0.0.jar  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/picocli-3.6.0.jar  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.osgi.annotation.versioning-1.0.0.jar
>   
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/slf4j-api-1.7.25.jar  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/slf4j-simple-1.7.25.jar  
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.apache.sling.feature-0.1.3-SNAPSHOT.jar
>   
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.apache.sling.feature.io-0.1.3-SNAPSHOT.jar
>   
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.osgi.util.function-1.0.0.jar
>   
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/org.apache.felix.utils-1.11.0.jar
>   
>   inflating: 
> org.apache.sling.feature.analyser-0.1.3-SNAPSHOT/lib/commons-lang-2.6.jar
> {noformat}
> I am also enriching the CLI with few useful options (enable the debug log or 
> reducing it to errors-only, see the product version) and a shiny {{help}} 
> command that will simplify users usage, i.e.
> Open the shell and type {{sfa --help}} to see the available commands:
> {noformat}
> $ ./bin/sfa --help
> Usage: sfa [-hqvX] -f= [-p=]
> Apache Sling Application Analyser
>   -f, --feature-file=
>   Set feature file.
>   -h, --help  Display the usage message.
>   -p, --plugin-class=
>   Explicitly specify plugin class to run, if ommitted the 
> default
> plugins are used
>   -q, --quiet Log errors only.
>   -v, --version   Display version information.
>   -X, --verbose   Produce execution debug output.
> Copyright(c) 2018 The Apache Software Foundation.
> {noformat}
> And a sample execution (please note version print and debug enabled):
> {noformat}
> $ ./bin/sfa analyse -X -v -f /path/to/src/main/features/emptyApiRegions.json 
> [INFO] org.apache.sling.feature.analyser v0.1.3-SNAPSHOT (built on 
> 2018-09-15T10:28:55Z)
> [INFO] Java version: 1.8.0_152, vendor: Oracle Corporation
> [INFO] Java home: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_152.jdk/Contents/Home/jre
> [INFO] Default locale: en_CH, platform encoding: UTF-8
> [INFO] Default Time Zone: Coordinated Universal Time
> [INFO] OS name: "Mac OS X", version: "10.13.6", arch: "x86_64", family: "mac"
> [INFO] 

[jira] [Resolved] (SLING-9909) Check/minimize embedded/shaded classes

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9909.
-
Resolution: Fixed

> Check/minimize embedded/shaded classes
> --
>
> Key: SLING-9909
> URL: https://issues.apache.org/jira/browse/SLING-9909
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Affects Versions: Feature Model Content Extension 1.0.8
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Content Extension 1.0.10
>
>
> The content extension is currently embedded a lot of dependencies, where some 
> are probably not needed - at the same time it is also shading them, which for 
> some of them does not make sense.
> For example, commons-cli is not needed at all, osgi packages are provided by 
> the runtime, shading jcr api should be avoided, slf-api is provided by the 
> runtime as well
> The embedded jackrabbit vault dependencies needs these packages (which might 
> need more):
> {noformat}
> org.apache.jackrabbit.api,
> org.apache.jackrabbit.api.security,
> org.apache.jackrabbit.api.security.authorization,
> org.apache.jackrabbit.api.security.principal,
> org.apache.jackrabbit.api.security.user,
> org.apache.jackrabbit.commons,
> org.apache.jackrabbit.commons.cnd,
> org.apache.jackrabbit.commons.jackrabbit,
> org.apache.jackrabbit.spi,
> org.apache.jackrabbit.spi.commons.conversion,
> org.apache.jackrabbit.spi.commons.name,
> org.apache.jackrabbit.spi.commons.namespace,
> org.apache.jackrabbit.spi.commons.nodetype,
> org.apache.jackrabbit.spi.commons.nodetype.compact,
> org.apache.jackrabbit.spi.commons.privilege,
> org.apache.jackrabbit.util,
> org.apache.jackrabbit.value,
> javax.jcr
> org.apache.commons.collections.map;version="[3.2.2,4)",
> org.apache.commons.io;version="[1.4.,2)",
> org.apache.commons.io.input;version="[1.4.,2)",
> org.apache.commons.io.output;version="[1.4.,2)",
> org.osgi.framework;version="[1.6.0,2)",
> org.slf4j;version="[1.7.6,2)"
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10031) Move MediaRangeList from Servlets POST to Sling API

[Carsten Ziegeler (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17258750#comment-17258750
 ] 

Carsten Ziegeler commented on SLING-10031:
--

I assume the narrow package range is because of other usages from that package 
(and not the newly introduced MediaRangeList which would be a consumer type). 
As [~olli] points out, we mixed too many things into the same package. Utility 
classes are best put into a separate package, unfortunately we didn't do this 
for RequestUtil and ResponseUtil, but at least for new api additions we should 
have clearer boundaries. Therefore I think we should put MediaRangeList into a 
new package

> Move MediaRangeList from Servlets POST to Sling API
> ---
>
> Key: SLING-10031
> URL: https://issues.apache.org/jira/browse/SLING-10031
> Project: Sling
>  Issue Type: Task
>  Components: API, Servlets
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: API 2.23.2, Servlets POST 2.3.38
>
>
> {{org.apache.sling.servlets.post.impl.helper}} → 
> {{org.apache.sling.api.request}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)