RE: [VOTE] Release Apache Sling Rewriter 1.3.0

[Stefan Seifert]

i've a problem running the unit test on windows - seems to be a line ending 
issue (see below).
another cosmetic remark: please put the SLING ticket number in the git commit 
messages, otherwise it's difficult to associate it.

stefan

---
Test set: org.apache.sling.rewriter.impl.components.Html5SerializerTest
---
Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.177 s <<< 
FAILURE! - in org.apache.sling.rewriter.impl.components.Html5SerializerTest
org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument 
 Time elapsed: 0.147 s  <<< FAILURE!
org.junit.ComparisonFailure: 
expected:<[]
> but was:<[
]
>
at 
org.apache.sling.rewriter.impl.components.Html5SerializerTest.testStartDocument(Html5SerializerTest.java:113)




>-Original Message-
>From: Daniel Klco 
>Sent: Friday, January 15, 2021 6:40 PM
>To: dev@sling.apache.org
>Subject: [VOTE] Release Apache Sling Rewriter 1.3.0
>
>Hi,
>
>We solved 9 issues in this release:
>https://issues.apache.org/jira/projects/SLING/versions/12342644
>
>I bumped to 1.3 due to the HTM5 serializer support which is backwards
>compatible.
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-2399/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
>Usage:
>sh check_staged_release.sh 2399 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.

RE: [VOTE] Release Apache Sling Pipes 4.1.2

[Stefan Seifert]

+1

[jira] [Closed] (SLING-10046) osgi-mock, sling-mock: Switch to individual OSGi artifacts and compile scope

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-10046.
--

> osgi-mock, sling-mock: Switch to individual OSGi artifacts and compile scope
> 
>
> Key: SLING-10046
> URL: https://issues.apache.org/jira/browse/SLING-10046
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing Sling Mock Oak 3.0.0-1.16.0, Testing OSGi Mock 
> 3.0.0, Testing Sling Mock 3.0.0
>
>
> goal:
> * do no longer depend on the "aggregated OSGi artifacts" {{osgi.core}}, 
> {{osgi.cmpn}}
> * instead depend on the individual artifacts {{org.osgi.framework}}, 
> {{org.osgi.service.component}} etc. as required
> * use the version of each osgi artifact that matches the version in run time 
> of the project under test
> additionally we want to switch these dependencies to compile scope, so they 
> get inherited in the test scope of the projects under test.
> (i assume the structure/naming osgi artifacts has now reached stable state 
> after all those changes in the last years)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10003) Allow to mock findResources in MockResourceResolver

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-10003.
--

> Allow to mock findResources in MockResourceResolver
> ---
>
> Key: SLING-10003
> URL: https://issues.apache.org/jira/browse/SLING-10003
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Konrad Windszus
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing ResourceResolver Mock 1.2.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently there is no easy way to override the method 
> [MockResourceResolver.findResources().|https://github.com/apache/sling-org-apache-sling-testing-resourceresolver-mock/blob/6ef6bd69ce1679b06d6b4d52b1b170dce51d102c/src/main/java/org/apache/sling/testing/resourceresolver/MockResourceResolver.java#L455]
> There should be a way to override that without relying on other mock 
> frameworks like Mockito.
> One way could be to add a static method 
> {{MockResourceResolver.registerFindResourcesFunction(ResourceResolver 
> resolver, BiFunction 
> findResourcesFunction)}} which allows to easily override the default 
> implementation (which always throws an UnsupportedOperationException) for the 
> given resolver (in case this is a MockResourceResolver). The registration 
> should only affect the given resource resolver as usually there is different 
> functions necessary per test method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10045) sling/jcr/osgi/resourceresolver-mock: Update Dependencies to 2018

[Stefan Seifert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert closed SLING-10045.
--

> sling/jcr/osgi/resourceresolver-mock: Update Dependencies to 2018
> -
>
> Key: SLING-10045
> URL: https://issues.apache.org/jira/browse/SLING-10045
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Major
> Fix For: Testing ResourceResolver Mock 1.2.0, Testing JCR Mock 
> 1.5.0, Testing Sling Mock Oak 3.0.0-1.16.0, Testing OSGi Mock 3.0.0, Testing 
> Sling Mock 3.0.0
>
>
> the concept of sling-mock and the other mocks was always to support a wide 
> range of sling and other sling dependencies versions in the real life 
> projects, also those using older versions of sling. we are currently at a 
> dependency range from ~2017 (SLING-8978).
> the goal of this ticket is to update to dependencies from ~2018.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT] [VOTE] Release Testing JCR Mock 1.5.0, ResourceResolver Mock 1.2.0, OSGi Mock 3.0.0, Sling Mock 3.0.0

[Stefan Seifert]

Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Carsten Ziegeler, Nicolas Peltier 
+1 (non binding): Andreas Schaefer

I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

stefan

[GitHub] [sling-slingfeature-maven-plugin] sonarcloud[bot] commented on pull request #66: SLING-10060 Substitutions for the "replacePropertyVariables" values should prefer the system property value

[GitBox]

sonarcloud[bot] commented on pull request #66:
URL: 
https://github.com/apache/sling-slingfeature-maven-plugin/pull/66#issuecomment-761254728


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=66=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=66=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-slingfeature-maven-plugin=66=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-slingfeature-maven-plugin=66=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=66=new_coverage=list)
 [81.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=66=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=66=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-slingfeature-maven-plugin=66=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-slingfeature-maven-plugin] enapps-enorman opened a new pull request #66: SLING-10060 Substitutions for the "replacePropertyVariables" values should prefer the system property value

[GitBox]

enapps-enorman opened a new pull request #66:
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/66


   Substitutions for the "replacePropertyVariables" values should prefer the 
system property value (if available) over the project property value.  
   
   For example, the use case of a parameterized jenkins job where the users 
choice should be passed along to maven and used to configure/prepare the 
environment to run a set of tests against.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

sonarcloud[bot] removed a comment on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761077579


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
 [45.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

sonarcloud[bot] commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761228566


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
 [48.6% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-9969) UsersEntryHandler and GroupEntryHandler contain hardcoded users/groups home path and doesn't include system-rel-path

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-9969:
-

Assignee: Karl Pauls

> UsersEntryHandler and GroupEntryHandler contain hardcoded users/groups home 
> path and doesn't include system-rel-path
> 
>
> Key: SLING-9969
> URL: https://issues.apache.org/jira/browse/SLING-9969
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> the constructor of {{SystemUsersEntryHandler}} looks as follows:
> {code}
> public SystemUsersEntryHandler() {
> super("/jcr_root(/home/users/.*/)\\.content.xml");
> }
> {code}
> i.e. it hardcodes the path to the users home node to the Adobe AEM specific 
> configuration. The default in Jackrabbit and Jackrabbit Oak is different (as 
> you can see in 
> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConstants.java?view=markup#l119).
> instead of hardcoding the path it should be extracted from a configuration 
> file in order to make the converter independent of Adobe AEM.
> in addition: oak comes with an addition configuration option that defines the 
> relative path below which all service users must be located (see 
> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConstants.java?view=markup#l141).
>  instead of traversing all user nodes (which may be quite a lot in a 
> productive enviroment), it would be better to fix the pattern such that it is 
> limited to the path, which is known to contain system users.
> note: there is no validator in place that prevents other users from 
> co-existing with system users so verifying the primary type would still 
> be needed, but at least the system-user-handler would be limited to a usually 
> fairly limited sub-tree of the whole user store.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #38: Bugfix SLING-9987 Add nullcheck to avoid a ClassCastException when there is no scripts or references fiel

[GitBox]

karlpauls commented on pull request #38:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/38#issuecomment-761217589


   This one should be fixed already - thanks for the patch!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls closed pull request #38: Bugfix SLING-9987 Add nullcheck to avoid a ClassCastException when there is no scripts or references field

[GitBox]

karlpauls closed pull request #38:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/38


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (SLING-10035) Sling Feature fails when Generated Features Directory is missing

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266330#comment-17266330
 ] 

Eric Norman edited comment on SLING-10035 at 1/15/21, 8:14 PM:
---

FYI: After switching to the newly release version of the plugin, I just noticed 
that this change appears to be creating a set of empty folders in the wrong 
place in my linux environment.

Using a debugger, I see that the targetDir File object is constructed at 
AbstractFeatureMojo line 244 with the "child" second argument already resolved 
to be an absolute path.  This appears to append the absolute child path to the 
parent path rather than checking if "child" is relative or absolute to resolve 
it.

[https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/main/java/org/apache/sling/feature/maven/mojos/AbstractFeatureMojo.java#L244]

 

Any objections to changing that line to something like below to properly 
resolve the 2 paths?

 
{code:java}
final File targetDir = 
this.project.getBasedir().toPath().resolve(this.project.getBuild().getDirectory()).toFile();
 
{code}
 


was (Author: enorman):
FYI: After switching to the newly release version of the plugin, I just noticed 
that this change appears to be creating an empty folder in the wrong place in 
my linux environment.

Using a debugger, I see that the targetDir File object is constructed at 
AbstractFeatureMojo line 244 with the "child" second argument already resolved 
to be an absolute path.  This appears to append the absolute child path to the 
parent path rather than checking if "child" is relative or absolute to resolve 
it.

[https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/main/java/org/apache/sling/feature/maven/mojos/AbstractFeatureMojo.java#L244]

 

Any objections to changing that line to something like below to properly 
resolve the 2 paths?

 
{code:java}
final File targetDir = 
this.project.getBasedir().toPath().resolve(this.project.getBuild().getDirectory()).toFile();
 
{code}
 

> Sling Feature fails when Generated Features Directory is missing
> 
>
> Key: SLING-10035
> URL: https://issues.apache.org/jira/browse/SLING-10035
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.4.20
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.22
>
>
> When I want to aggregate a Feature Model in another module like 'all' and 
> there is not attachment or other FM generation task beforehand the Sling 
> Feature Maven Plugin fails in handleGeneratedFeatures() method. This can be 
> fixed by copying the target folder from the resources but that is a lot of 
> unnecessary work.
>  
> I added code to that method that tries to create the folder if it does not 
> exist.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-10035) Sling Feature fails when Generated Features Directory is missing

[Eric Norman (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266330#comment-17266330
 ] 

Eric Norman commented on SLING-10035:
-

FYI: After switching to the newly release version of the plugin, I just noticed 
that this change appears to be creating an empty folder in the wrong place in 
my linux environment.

Using a debugger, I see that the targetDir File object is constructed at 
AbstractFeatureMojo line 244 with the "child" second argument already resolved 
to be an absolute path.  This appears to append the absolute child path to the 
parent path rather than checking if "child" is relative or absolute to resolve 
it.

[https://github.com/apache/sling-slingfeature-maven-plugin/blob/master/src/main/java/org/apache/sling/feature/maven/mojos/AbstractFeatureMojo.java#L244]

 

Any objections to changing that line to something like below to properly 
resolve the 2 paths?

 
{code:java}
final File targetDir = 
this.project.getBasedir().toPath().resolve(this.project.getBuild().getDirectory()).toFile();
 
{code}
 

> Sling Feature fails when Generated Features Directory is missing
> 
>
> Key: SLING-10035
> URL: https://issues.apache.org/jira/browse/SLING-10035
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.4.20
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.22
>
>
> When I want to aggregate a Feature Model in another module like 'all' and 
> there is not attachment or other FM generation task beforehand the Sling 
> Feature Maven Plugin fails in handleGeneratedFeatures() method. This can be 
> fixed by copying the target folder from the resources but that is a lot of 
> unnecessary work.
>  
> I added code to that method that tries to create the folder if it does not 
> exist.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Rewriter 1.3.0

[Nicolas Peltier]

+1

Le ven. 15 janv. 2021 à 18:39, Daniel Klco  a écrit :

> Hi,
>
> We solved 9 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12342644
>
> I bumped to 1.3 due to the HTM5 serializer support which is backwards
> compatible.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2399/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2399 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>

[VOTE] Release Apache Sling Rewriter 1.3.0

[Daniel Klco]

Hi,

We solved 9 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12342644

I bumped to 1.3 due to the HTM5 serializer support which is backwards
compatible.

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2399/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2399 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

sonarcloud[bot] removed a comment on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761062870


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
 [41.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

sonarcloud[bot] commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761077579


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
 [45.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

karlpauls commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761075235


   @anchela - PTAL



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

sonarcloud[bot] removed a comment on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761049200


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
 [41.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

sonarcloud[bot] commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761062870


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
 [41.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10065) make command servlet tests more robust

[Nicolas Peltier (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266192#comment-17266192
 ] 

Nicolas Peltier commented on SLING-10065:
-

interesting [~bdelacretaz] ! i had implemented a quick jsonpath feature in json 
pipe 
([https://github.com/apache/sling-org-apache-sling-pipes/blob/master/src/main/java/org/apache/sling/pipes/internal/inputstream/JsonPipe.java#L140)]
 but didn't think to use any for unit test

> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.1.2
>
>
> [~sseifert] observed a build issue that is probably due to different 
> implementation of EOL in json generation, or/and in test expectation on linux 
> / windows. We should have a more robust way of testing validity of the json 
> response 
> {Quote}i've a problem running the unit tests on windows. surefire output see 
> below.
>  i assume there is a problem with line endings, can you fix the test that it 
> is agnostic of unix/windows line endings?
>  
>  stefan
>  
>  
> ---
>  Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> ---
>  Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<< 
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
>   Time elapsed: 0.39 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...:content"],"size":5}[]
>  > but was:<...:content"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>  
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
>   Time elapsed: 0.265 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...tent/foo"],"size":1}[]
>  > but was:<...tent/foo"],"size":1}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>  
>  org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand  
> Time elapsed: 0.263 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...a/carrot"],"size":5}[]
>  > but was:<...a/carrot"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #54: minor improvements, cleanup, nullability-issues, ...

[GitBox]

karlpauls merged pull request #54:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/54


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #54: minor improvements, cleanup, nullability-issues, ...

[GitBox]

sonarcloud[bot] commented on pull request #54:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/54#issuecomment-761059402


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=54=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=54=new_coverage=list)
 [94.7% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=54=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=54=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=54=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-10065) make command servlet tests more robust

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266188#comment-17266188
 ] 

Bertrand Delacretaz commented on SLING-10065:
-

FWIW, in case you have more similar needs later, in the GraphQL Core module we 
are [using jsonpath 
matchers|https://github.com/apache/sling-org-apache-sling-graphql-core/blob/3be37e2ef574d6f4da8ecabd147bb9cecef7671d/src/test/java/org/apache/sling/graphql/core/engine/DefaultQueryExecutorTest.java#L106]
 and I find them quite convenient.

> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.1.2
>
>
> [~sseifert] observed a build issue that is probably due to different 
> implementation of EOL in json generation, or/and in test expectation on linux 
> / windows. We should have a more robust way of testing validity of the json 
> response 
> {Quote}i've a problem running the unit tests on windows. surefire output see 
> below.
>  i assume there is a problem with line endings, can you fix the test that it 
> is agnostic of unix/windows line endings?
>  
>  stefan
>  
>  
> ---
>  Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> ---
>  Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<< 
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
>   Time elapsed: 0.39 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...:content"],"size":5}[]
>  > but was:<...:content"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>  
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
>   Time elapsed: 0.265 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...tent/foo"],"size":1}[]
>  > but was:<...tent/foo"],"size":1}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>  
>  org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand  
> Time elapsed: 0.263 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...a/carrot"],"size":5}[]
>  > but was:<...a/carrot"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela opened a new pull request #54: minor improvements, cleanup, nullability-issues, ...

[GitBox]

anchela opened a new pull request #54:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/54


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[VOTE] Release Apache Sling Pipes 4.1.2

[Nicolas Peltier]

Hi,

We solved 8 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12349395

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2400/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2400 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

note that even filling in id.apache and the KEYS file from svn, looks like
people apache page is not updated. I'm on SKS though
https://keyserver.2ndquadrant.com/pks/lookup?op=get=0x08CBBC854D20BF87

Regards,
Nicolas

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

sonarcloud[bot] commented on pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53#issuecomment-761049200


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
 [1 Code 
Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=53=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
 [41.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=53=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (SLING-9962) DefaultAclManager#addPaths prone to causing ConstraintViolationException

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-9962:
-

Assignee: Karl Pauls

> DefaultAclManager#addPaths prone to causing ConstraintViolationException
> 
>
> Key: SLING-9962
> URL: https://issues.apache.org/jira/browse/SLING-9962
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> As discussed in SLING-9961 I suspect that {{DefaultAclManager.addPaths}} is 
> prone to cause {{ConstraintViolationException}} for the following reason:
> - method {{computePathType}} returns a default type (in this case 
> _sling:Folder_) if no primary type can be detected from the content package, 
> without verifying if that node type was legal at the target destination.
> - method {{addPaths}} generates the following repo-init statements: 
> {{formatter.format("create path (%s) %s%n", type, path)}} thus attempting to 
> create all intermediate paths with the same primary type.
> as far as i know Jackrabbit fVault content packages may leave out definitions 
> of intermediate nodes if those are known to already exist (or be created by 
> another package) and only start adding _.content.xml_ for those nodes that 
> actually need to be created.
> i haven't tested it but IMO, the converter should refrain from using a 
> default primary type if the content package doesn't define it. instead it 
> should probably generated repo-init statements as follows or (alternatively) 
> omit paths for which the content packages doesn't allow to unambiguously 
> create the right content structure.
> {code}
> formatter.format("create path %s(%s) %n", path, type)
> {code}
> also creation of intermediate paths could be simplified by using the 
> following repo-init structure, that allows to specify the type of each node 
> in the hierarchy to be created:
> {code}
> create path /content/subtree(nt:unstructured)/example.com(sling:Folder mixin 
> mix:referenceable)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9969) UsersEntryHandler and GroupEntryHandler contain hardcoded users/groups home path and doesn't include system-rel-path

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls updated SLING-9969:
--
Summary: UsersEntryHandler and GroupEntryHandler contain hardcoded 
users/groups home path and doesn't include system-rel-path  (was: 
SystemUsersEntryHandler contains hardcoded users home path and doesn't include 
system-rel-path)

> UsersEntryHandler and GroupEntryHandler contain hardcoded users/groups home 
> path and doesn't include system-rel-path
> 
>
> Key: SLING-9969
> URL: https://issues.apache.org/jira/browse/SLING-9969
> Project: Sling
>  Issue Type: Bug
>  Components: Content-Package to Feature Model Converter
>Reporter: Angela Schreiber
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
>
> the constructor of {{SystemUsersEntryHandler}} looks as follows:
> {code}
> public SystemUsersEntryHandler() {
> super("/jcr_root(/home/users/.*/)\\.content.xml");
> }
> {code}
> i.e. it hardcodes the path to the users home node to the Adobe AEM specific 
> configuration. The default in Jackrabbit and Jackrabbit Oak is different (as 
> you can see in 
> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConstants.java?view=markup#l119).
> instead of hardcoding the path it should be extracted from a configuration 
> file in order to make the converter independent of Adobe AEM.
> in addition: oak comes with an addition configuration option that defines the 
> relative path below which all service users must be located (see 
> http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/user/UserConstants.java?view=markup#l141).
>  instead of traversing all user nodes (which may be quite a lot in a 
> productive enviroment), it would be better to fix the pattern such that it is 
> limited to the path, which is known to contain system users.
> note: there is no validator in place that prevents other users from 
> co-existing with system users so verifying the primary type would still 
> be needed, but at least the system-user-handler would be limited to a usually 
> fairly limited sub-tree of the whole user store.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls opened a new pull request #53: SLING-9969: UsersEntryHandler and GroupEntryHandler contain hardcoded…

[GitBox]

karlpauls opened a new pull request #53:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/53


   … users/groups home path and doesn't include system-rel-path



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-10065) make command servlet tests more robust

[Nicolas Peltier (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-10065.
-
Fix Version/s: Pipes 4.1.2
 Assignee: Nicolas Peltier
   Resolution: Fixed

> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: Pipes 4.1.2
>
>
> [~sseifert] observed a build issue that is probably due to different 
> implementation of EOL in json generation, or/and in test expectation on linux 
> / windows. We should have a more robust way of testing validity of the json 
> response 
> {Quote}i've a problem running the unit tests on windows. surefire output see 
> below.
>  i assume there is a problem with line endings, can you fix the test that it 
> is agnostic of unix/windows line endings?
>  
>  stefan
>  
>  
> ---
>  Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> ---
>  Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<< 
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
>   Time elapsed: 0.39 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...:content"],"size":5}[]
>  > but was:<...:content"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>  
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
>   Time elapsed: 0.265 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...tent/foo"],"size":1}[]
>  > but was:<...tent/foo"],"size":1}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>  
>  org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand  
> Time elapsed: 0.263 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...a/carrot"],"size":5}[]
>  > but was:<...a/carrot"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10065) make command servlet tests more robust

[Nicolas Peltier (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-10065:

Issue Type: Bug  (was: Improvement)

> make command servlet tests more robust
> --
>
> Key: SLING-10065
> URL: https://issues.apache.org/jira/browse/SLING-10065
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 4.0.0
>Reporter: Nicolas Peltier
>Priority: Major
>
> [~sseifert] observed a build issue that is probably due to different 
> implementation of EOL in json generation, or/and in test expectation on linux 
> / windows. We should have a more robust way of testing validity of the json 
> response 
> {Quote}i've a problem running the unit tests on windows. surefire output see 
> below.
>  i assume there is a problem with line endings, can you fix the test that it 
> is agnostic of unix/windows line endings?
>  
>  stefan
>  
>  
> ---
>  Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> ---
>  Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<< 
> FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
>   Time elapsed: 0.39 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...:content"],"size":5}[]
>  > but was:<...:content"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>  
>  
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
>   Time elapsed: 0.265 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...tent/foo"],"size":1}[]
>  > but was:<...tent/foo"],"size":1}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>  
>  org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand  
> Time elapsed: 0.263 s  <<< FAILURE!
>  org.junit.ComparisonFailure: 
>  expected:<...a/carrot"],"size":5}[]
>  > but was:<...a/carrot"],"size":5}[
>  ]
>  >
>          at 
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10065) make command servlet tests more robust

[Nicolas Peltier (Jira)]

Nicolas Peltier created SLING-10065:
---

 Summary: make command servlet tests more robust
 Key: SLING-10065
 URL: https://issues.apache.org/jira/browse/SLING-10065
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: Pipes 4.0.0
Reporter: Nicolas Peltier


[~sseifert] observed a build issue that is probably due to different 
implementation of EOL in json generation, or/and in test expectation on linux / 
windows. We should have a more robust way of testing validity of the json 
response 

{Quote}i've a problem running the unit tests on windows. surefire output see 
below.
 i assume there is a problem with line endings, can you fix the test that it is 
agnostic of unix/windows line endings?
 
 stefan
 
 ---
 Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
 ---
 Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<< 
FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
 org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet 
 Time elapsed: 0.39 s  <<< FAILURE!
 org.junit.ComparisonFailure: 
 expected:<...:content"],"size":5}[]
 > but was:<...:content"],"size":5}[
 ]
 >
         at 
org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
 
 
org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
  Time elapsed: 0.265 s  <<< FAILURE!
 org.junit.ComparisonFailure: 
 expected:<...tent/foo"],"size":1}[]
 > but was:<...tent/foo"],"size":1}[
 ]
 >
         at 
org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
 
 org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand  
Time elapsed: 0.263 s  <<< FAILURE!
 org.junit.ComparisonFailure: 
 expected:<...a/carrot"],"size":5}[]
 > but was:<...a/carrot"],"size":5}[
 ]
 >
         at 
org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)\{Quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Servlets POST 2.4.2

[Daniel Klco]

+1

On Fri, Jan 15, 2021 at 5:59 AM Stefan Seifert
 wrote:

> +1
>

Re: [VOTE] Release Apache Sling Installer Configuration Factory 1.3.4

[Daniel Klco]

+1

On Wed, Jan 13, 2021 at 5:22 PM Robert Munteanu  wrote:

> Hi,
>
> We solved 1 issue in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348262
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2394/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2394 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> Robert Munteanu
>

[jira] [Resolved] (SLING-9692) Add support for principal-based access control entries

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-9692.
---
Resolution: Fixed

> Add support for principal-based access control entries
> --
>
> Key: SLING-9692
> URL: https://issues.apache.org/jira/browse/SLING-9692
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Robert Munteanu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
> Attachments: SLING-9692.patch
>
>
> When passed a content package that contains principal-based access control 
> entries, the converter ignores them. It should instead generate the proper 
> repoinit statements.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9692) Add support for principal-based access control entries

[Karl Pauls (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266107#comment-17266107
 ] 

Karl Pauls commented on SLING-9692:
---

[~angela] and I integrated her patch in 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52 

We added two new options:

{{--enforce-principal-based}} - Converts all service user access control 
entries to principal-based setup
and 
{{--supported-principal-based-path}} - Path supported for principal-based 
access control setup

> Add support for principal-based access control entries
> --
>
> Key: SLING-9692
> URL: https://issues.apache.org/jira/browse/SLING-9692
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Robert Munteanu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
> Attachments: SLING-9692.patch
>
>
> When passed a content package that contains principal-based access control 
> entries, the converter ignores them. It should instead generate the proper 
> repoinit statements.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (SLING-9692) Add support for principal-based access control entries

[Karl Pauls (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-9692:
-

Assignee: Karl Pauls

> Add support for principal-based access control entries
> --
>
> Key: SLING-9692
> URL: https://issues.apache.org/jira/browse/SLING-9692
> Project: Sling
>  Issue Type: Improvement
>  Components: Content-Package to Feature Model Converter
>Reporter: Robert Munteanu
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Content-Package to Feature Model Converter 1.0.26
>
> Attachments: SLING-9692.patch
>
>
> When passed a content package that contains principal-based access control 
> entries, the converter ignores them. It should instead generate the proper 
> repoinit statements.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls merged pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

karlpauls merged pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] removed a comment on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760972822


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [87.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] commented on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760989785


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [88.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] commented on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760972822


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [4 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [87.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] removed a comment on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760933537


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

karlpauls commented on a change in pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558314269



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -150,6 +164,20 @@ public void addRepoinitExtension(@NotNull 
List packageAss
 }
 }
 
+private String calculateIntermediatePath(RepoPath intermediatePath) {
+if (enforcePrincipalBased && supportedPrincipalBasedPath!= null && 
!intermediatePath.startsWith(supportedPrincipalBasedPath)) {
+RepoPath parent = supportedPrincipalBasedPath.getParent();
+if (parent.equals(intermediatePath)) {
+return supportedPrincipalBasedPath.toString();
+} else {
+String relpath = 
intermediatePath.toString().substring(parent.toString().length());
+return supportedPrincipalBasedPath.toString() + relpath;
+}
+} else {
+return intermediatePath.toString();
+}
+}
+
 private boolean aclStartsWith(RepoPath path) {

Review comment:
   Right, that is why the group does both:
   if (aclStartsWith(group.getPath())) {
   formatter.format("create group %s with path %s%n", 
group.getId(), group.getIntermediatePath());
   }
   if (aclIsBelow(group.getPath())) {
   throw new IllegalStateException("Detected policy on 
subpath of group: " + group);
   }
   I think that is doing what you want - just in a roundabout way, no?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] commented on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760933537


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] removed a comment on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760914825


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.4% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

karlpauls commented on a change in pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558293497



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -122,6 +134,8 @@ public void addRepoinitExtension(@NotNull 
List packageAss
 .filter(entry -> getSystemUser(entry.getKey()).isPresent())
 .map(Entry::getValue)
 .flatMap(Collection::stream)
+// paths only should/need to be create with resource-based 
access control
+.filter(((Predicate) 
AccessControlEntry::isPrincipalBased).negate())

Review comment:
   Yes, I think we can just wrap the complete block in an if statement.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls commented on a change in pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

karlpauls commented on a change in pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558293260



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -166,32 +194,46 @@ private void addStatements(@NotNull SystemUser systemUser,
 return;
 }
 
-Map entries = new LinkedHashMap<>();
+Map resourceEntries = new 
LinkedHashMap<>();
+Map principalEntries = new 
LinkedHashMap<>();
+
 authorizations.forEach(entry -> {
 String path = getRepoInitPath(entry.getRepositoryPath(), 
systemUser);
 if (path != null) {
-entries.put(entry, path);
+if (enforcePrincipalBased || entry.isPrincipalBased()) {
+principalEntries.put(entry, path);
+} else {
+resourceEntries.put(entry, path);
+}
 }
 });
-if (!entries.isEmpty()) {
-formatter.format("set ACL for %s%n", systemUser.getId());
-entries.forEach((entry, path) -> {
-formatter.format("%s %s on %s",
-entry.getOperation(),
-entry.getPrivileges(),
-path);
-
-if (!entry.getRestrictions().isEmpty()) {
-formatter.format(" restriction(%s)",
-String.join(",", entry.getRestrictions()));
-}
 
-formatter.format("%n");
-});
+if (!principalEntries.isEmpty()) {
+formatter.format("set principal ACL for %s%n", systemUser.getId());
+principalEntries.forEach((entry, path) -> writeEntry(entry, path, 
formatter));
+formatter.format("end%n");
+}
+if (!enforcePrincipalBased && !resourceEntries.isEmpty()) {

Review comment:
   True
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

anchela commented on a change in pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558272122



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -150,6 +164,20 @@ public void addRepoinitExtension(@NotNull 
List packageAss
 }
 }
 
+private String calculateIntermediatePath(RepoPath intermediatePath) {

Review comment:
   missing notnull
   
   btw: in the method... parent might be null and cause NPE
   one more thing after looking at the method again: i am not totally sure it 
properly covers all cases 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (SLING-9999) Remove cyclic dependency between scripting and servlets features

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266003#comment-17266003
 ] 

Radu Cotescu edited comment on SLING- at 1/15/21, 12:31 PM:


[~olli], I told you the reasoning for deprecating the 
[org.apache.sling.scripting.bundle.tracker|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]
 bundle: we wanted to bring the support for running a Sling web-app with 
bundled scripts into the core Sling modules. Before, that bundle was providing 
both the API and the implementation. We realised, though, that the 
implementations were better suited into {{org.apache.sling.servlets.resolver}} 
(for performance reasons) and {{org.apache.sling.scripting.core}} (to reduce 
code duplication, since we're essentially providing a {{ScriptContext}} to 
those bundled scripts).

Option no. 3 is actually something that would make sense: the new API would be 
extracted into a separate bundle, with the implementations kept like they were 
before your commits. This way the dependency chains are kept clean and we would 
still benefit from the performance improvements and reduced code duplication. 
So, like [~karlpauls] mentioned, if you revert your changes we can go into this 
direction without any issues. The API namespaces stay the same, so we don't 
introduce any backwards incompatible changes, at the cost of one additional API 
bundle. WDYT?


was (Author: radu.cotescu):
[~olli], I told you the reasoning for deprecating the 
[org.apache.sling.scripting.bundle.tracker|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]
 bundle: we wanted to bring the support for running a Sling web-app with 
bundled scripts into the core Sling modules. Before, that bundle was providing 
both the API and the implementation. We realised, though, that the 
implementations were better suited into {{org.apache.sling.servlets.resolver}} 
(for performance reasons) and {{org.apache.sling.scripting.core}} (to reduce 
code duplication, since we're essentially providing a {{ScriptContext}} to 
those bundled scripts).

Option no. 3 is actually something that would make sense: the new API would be 
extracted into a separate bundle, with the implementations kept like they were 
before your commits. This was the dependency chains are kept clean and we would 
still benefit from the performance improvements and reduced code duplication. 
So, like [~karlpauls] mentioned, if you revert your changes we can go into this 
direction without any issues. The API namespaces stay the same, so we don't 
introduce any backwards incompatible changes, at the cost of one additional API 
bundle. WDYT?

> Remove cyclic dependency between scripting and servlets features
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Karaf, Scripting, Servlets, Starter
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Before {{org.apache.sling.scripting.core.impl.bundled}} and 
> {{org.apache.sling.servlets.resolver.bundle}} were added the dependency 
> chains were e.g.
> {{sling-servlets}} → {{sling-scripting}} → {{sling}}
> {{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}
> Currently several _scripting_ modules depend on 
> {{org.apache.sling.servlets.resolver.bundle.tracker}}.
> h2. Move _Bundle_ API to Scripting and Resource packages (modules)
> ||Actual Package (Module)||Target Package (Module)||
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker. 
> BundledRenderUnitCapability}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
>  
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}*
>  ({{org.apache.sling.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}*
>  (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})|
> 
> ||Module||Commits||Status||
> 

[jira] [Commented] (SLING-9999) Remove cyclic dependency between scripting and servlets features

[Radu Cotescu (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266003#comment-17266003
 ] 

Radu Cotescu commented on SLING-:
-

[~olli], I told you the reasoning for deprecating the 
[org.apache.sling.scripting.bundle.tracker|https://github.com/apache/sling-org-apache-sling-scripting-bundle-tracker]
 bundle: we wanted to bring the support for running a Sling web-app with 
bundled scripts into the core Sling modules. Before, that bundle was providing 
both the API and the implementation. We realised, though, that the 
implementations were better suited into {{org.apache.sling.servlets.resolver}} 
(for performance reasons) and {{org.apache.sling.scripting.core}} (to reduce 
code duplication, since we're essentially providing a {{ScriptContext}} to 
those bundled scripts).

Option no. 3 is actually something that would make sense: the new API would be 
extracted into a separate bundle, with the implementations kept like they were 
before your commits. This was the dependency chains are kept clean and we would 
still benefit from the performance improvements and reduced code duplication. 
So, like [~karlpauls] mentioned, if you revert your changes we can go into this 
direction without any issues. The API namespaces stay the same, so we don't 
introduce any backwards incompatible changes, at the cost of one additional API 
bundle. WDYT?

> Remove cyclic dependency between scripting and servlets features
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Karaf, Scripting, Servlets, Starter
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Before {{org.apache.sling.scripting.core.impl.bundled}} and 
> {{org.apache.sling.servlets.resolver.bundle}} were added the dependency 
> chains were e.g.
> {{sling-servlets}} → {{sling-scripting}} → {{sling}}
> {{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}
> Currently several _scripting_ modules depend on 
> {{org.apache.sling.servlets.resolver.bundle.tracker}}.
> h2. Move _Bundle_ API to Scripting and Resource packages (modules)
> ||Actual Package (Module)||Target Package (Module)||
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker. 
> BundledRenderUnitCapability}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
>  
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}*
>  ({{org.apache.sling.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}*
>  (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})|
> 
> ||Module||Commits||Status||
> |{{org.apache.sling.api}}|[02cb7f1|https://github.com/apache/sling-org-apache-sling-api/commit/02cb7f1bbc4836865afd7e9964d3be1380daf734]|(/)|
> |{{org.apache.sling.scripting.api}}|[d38759d|https://github.com/apache/sling-org-apache-sling-scripting-api/commit/d38759dbd3d4159f70ea54bff23b037be8d07cd6]|(/)|
> |{{org.apache.sling.scripting.core}}|[b2f368a|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/b2f368a90a087979c34d8072fe529675971234fe],
>  
> [1467cfa|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/1467cfa6a3fe4c77a628d078f9d944ce4cc42eb1]|(/)|
> |{{org.apache.sling.scripting.jsp}}|[ccdb902|https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/ccdb90266f254bb2143a5d870725a8f4b28d4d8b]|(/)|
> |{{org.apache.sling.scripting.sightly}}|[1567894|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/1567894f6c1835a317c01e6c5b5987a260a74757],
>  
> [b2f57cd|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/b2f57cd43d7d961fcf194cf7bf61b1c79f343d44]|(/)|
> |{{org.apache.sling.servlets.resolver}}|[8262ce6|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/8262ce63725b9ab93c1d3eb07ace6b02d79acc65]|(!)
>  probably more classes which should be living in a scripting module|



--
This message was sent by Atlassian 

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] commented on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760914825


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.4% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] removed a comment on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760891570


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

anchela commented on a change in pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558272122



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -150,6 +164,20 @@ public void addRepoinitExtension(@NotNull 
List packageAss
 }
 }
 
+private String calculateIntermediatePath(RepoPath intermediatePath) {

Review comment:
   missing notnull
   
   btw: in the method... parent might be null and cause NPE





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on a change in pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

anchela commented on a change in pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#discussion_r558266803



##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -166,32 +194,46 @@ private void addStatements(@NotNull SystemUser systemUser,
 return;
 }
 
-Map entries = new LinkedHashMap<>();
+Map resourceEntries = new 
LinkedHashMap<>();
+Map principalEntries = new 
LinkedHashMap<>();
+
 authorizations.forEach(entry -> {
 String path = getRepoInitPath(entry.getRepositoryPath(), 
systemUser);
 if (path != null) {
-entries.put(entry, path);
+if (enforcePrincipalBased || entry.isPrincipalBased()) {
+principalEntries.put(entry, path);
+} else {
+resourceEntries.put(entry, path);
+}
 }
 });
-if (!entries.isEmpty()) {
-formatter.format("set ACL for %s%n", systemUser.getId());
-entries.forEach((entry, path) -> {
-formatter.format("%s %s on %s",
-entry.getOperation(),
-entry.getPrivileges(),
-path);
-
-if (!entry.getRestrictions().isEmpty()) {
-formatter.format(" restriction(%s)",
-String.join(",", entry.getRestrictions()));
-}
 
-formatter.format("%n");
-});
+if (!principalEntries.isEmpty()) {
+formatter.format("set principal ACL for %s%n", systemUser.getId());
+principalEntries.forEach((entry, path) -> writeEntry(entry, path, 
formatter));
+formatter.format("end%n");
+}
+if (!enforcePrincipalBased && !resourceEntries.isEmpty()) {

Review comment:
   isn't` !enforcePrincipalBased` redundant here?

##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -122,6 +134,8 @@ public void addRepoinitExtension(@NotNull 
List packageAss
 .filter(entry -> getSystemUser(entry.getKey()).isPresent())
 .map(Entry::getValue)
 .flatMap(Collection::stream)
+// paths only should/need to be create with resource-based 
access control
+.filter(((Predicate) 
AccessControlEntry::isPrincipalBased).negate())

Review comment:
   if principal-based ac-setup is enforced for all service user permissions 
(and thus resource-based entries get converted to principal-based), no paths 
should be created either so in addition to filtering out principal-based 
entries, the whole block might be excluded if the 
enforce-prinicipal-based-ac-setup is turned on.
   
   and we should have a test verifying this :)

##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -51,6 +51,9 @@
 
 private static final String CONTENT_XML_FILE_NAME = ".content.xml";
 
+private final boolean enforcePrincipalBased;
+private RepoPath supportedPrincipalBasedPath;

Review comment:
   may be final

##
File path: 
src/main/java/org/apache/sling/feature/cpconverter/accesscontrol/DefaultAclManager.java
##
@@ -166,32 +194,46 @@ private void addStatements(@NotNull SystemUser systemUser,
 return;
 }
 
-Map entries = new LinkedHashMap<>();
+Map resourceEntries = new 
LinkedHashMap<>();
+Map principalEntries = new 
LinkedHashMap<>();
+
 authorizations.forEach(entry -> {
 String path = getRepoInitPath(entry.getRepositoryPath(), 
systemUser);
 if (path != null) {
-entries.put(entry, path);
+if (enforcePrincipalBased || entry.isPrincipalBased()) {
+principalEntries.put(entry, path);
+} else {
+resourceEntries.put(entry, path);
+}
 }
 });
-if (!entries.isEmpty()) {
-formatter.format("set ACL for %s%n", systemUser.getId());
-entries.forEach((entry, path) -> {
-formatter.format("%s %s on %s",
-entry.getOperation(),
-entry.getPrivileges(),
-path);
-
-if (!entry.getRestrictions().isEmpty()) {
-formatter.format(" restriction(%s)",
-String.join(",", entry.getRestrictions()));
-}
 
-formatter.format("%n");
-});
+if (!principalEntries.isEmpty()) {
+formatter.format("set principal ACL for %s%n", systemUser.getId());
+principalEntries.forEach((entry, path) -> 

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] commented on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760891570


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [2 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.2% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] removed a comment on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760888140


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[CANCEL][VOTE] Release Apache Sling Pipes 4.1.0

[Nicolas Peltier]

will redo a new release once below bug is fixed, and my key problem is
fixed too

Le ven. 15 janv. 2021 à 12:11, Nicolas Peltier 
a écrit :

> ho! ok, will cancel that release then, thanks for spotting this, Stefan
>
> Le ven. 15 janv. 2021 à 12:05, Stefan Seifert
>  a écrit :
>
>> i've a problem running the unit tests on windows. surefire output see
>> below.
>> i assume there is a problem with line endings, can you fix the test that
>> it is agnostic of unix/windows line endings?
>>
>> stefan
>>
>>
>> ---
>> Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>>
>> ---
>> Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s
>> <<< FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
>> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
>> Time elapsed: 0.39 s  <<< FAILURE!
>> org.junit.ComparisonFailure:
>> expected:<...:content"],"size":5}[]
>> > but was:<...:content"],"size":5}[
>> ]
>> >
>> at
>> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>>
>> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
>> Time elapsed: 0.265 s  <<< FAILURE!
>> org.junit.ComparisonFailure:
>> expected:<...tent/foo"],"size":1}[]
>> > but was:<...tent/foo"],"size":1}[
>> ]
>> >
>> at
>> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>>
>> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand
>> Time elapsed: 0.263 s  <<< FAILURE!
>> org.junit.ComparisonFailure:
>> expected:<...a/carrot"],"size":5}[]
>> > but was:<...a/carrot"],"size":5}[
>> ]
>> >
>> at
>> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)
>>
>>
>>
>>
>> >-Original Message-
>> >From: Nicolas Peltier 
>> >Sent: Thursday, January 14, 2021 10:47 PM
>> >To: Sling Developers List 
>> >Subject: [VOTE] Release Apache Sling Pipes 4.1.0
>> >
>> >Hi,
>> >
>> >We solved 7 issues in this release:
>> >https://issues.apache.org/jira/projects/SLING/versions/12349395
>> >
>> >Staging repository:
>> >https://repository.apache.org/content/repositories/orgapachesling-2398/
>> >
>> >You can use this UNIX script to download the release and verify the
>> >signatures:
>> >https://gitbox.apache.org/repos/asf?p=sling-tooling-
>> >release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>> >
>> >Usage:
>> >sh check_staged_release.sh 2398 /tmp/sling-staging
>> >
>> >Please vote to approve this release:
>> >
>> >  [ ] +1 Approve the release
>> >  [ ]  0 Don't care
>> >  [ ] -1 Don't release, because ...
>> >
>> >This majority vote is open for at least 72 hours.
>> >
>> >Regards,
>>
>

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] commented on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760888140


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [6 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] removed a comment on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] removed a comment on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760886870


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [8 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

sonarcloud[bot] commented on pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52#issuecomment-760886870


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
 [8 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter=52=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
 [85.8% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_coverage=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-cpconverter=52=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-cpconverter] karlpauls opened a new pull request #52: SLING-9692: Add support for principal-based access control entries

[GitBox]

karlpauls opened a new pull request #52:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/52


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (SLING-9999) Remove cyclic dependency between scripting and servlets features

[Karl Pauls (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265936#comment-17265936
 ] 

Karl Pauls commented on SLING-:
---

[~olli], as I said, I think it is fine to create a new servlets.resolver.api 
bundle with just the package in question - that way, the scripting can just 
include that bundle and doesn't need the servlets.resolver. This is similar to 
what was happening before with the separate bundle.tracker bundle. If you would 
revert your changes I (or maybe [~radu]) can look into creating a 
servlets.resolver.api bundle and that should be all that is needed, no?

> Remove cyclic dependency between scripting and servlets features
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Karaf, Scripting, Servlets, Starter
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Before {{org.apache.sling.scripting.core.impl.bundled}} and 
> {{org.apache.sling.servlets.resolver.bundle}} were added the dependency 
> chains were e.g.
> {{sling-servlets}} → {{sling-scripting}} → {{sling}}
> {{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}
> Currently several _scripting_ modules depend on 
> {{org.apache.sling.servlets.resolver.bundle.tracker}}.
> h2. Move _Bundle_ API to Scripting and Resource packages (modules)
> ||Actual Package (Module)||Target Package (Module)||
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnit}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker. 
> BundledRenderUnitCapability}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitCapability}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
>  
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.BundledRenderUnitFinder}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.api.resource.type.ResourceType}}*
>  ({{org.apache.sling.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.api.bundle.TypeProvider}}*
>  (_*{color:#ff8b00}class name?{color}*_) ({{org.apache.sling.scripting.api}})|
> 
> ||Module||Commits||Status||
> |{{org.apache.sling.api}}|[02cb7f1|https://github.com/apache/sling-org-apache-sling-api/commit/02cb7f1bbc4836865afd7e9964d3be1380daf734]|(/)|
> |{{org.apache.sling.scripting.api}}|[d38759d|https://github.com/apache/sling-org-apache-sling-scripting-api/commit/d38759dbd3d4159f70ea54bff23b037be8d07cd6]|(/)|
> |{{org.apache.sling.scripting.core}}|[b2f368a|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/b2f368a90a087979c34d8072fe529675971234fe],
>  
> [1467cfa|https://github.com/apache/sling-org-apache-sling-scripting-core/commit/1467cfa6a3fe4c77a628d078f9d944ce4cc42eb1]|(/)|
> |{{org.apache.sling.scripting.jsp}}|[ccdb902|https://github.com/apache/sling-org-apache-sling-scripting-jsp/commit/ccdb90266f254bb2143a5d870725a8f4b28d4d8b]|(/)|
> |{{org.apache.sling.scripting.sightly}}|[1567894|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/1567894f6c1835a317c01e6c5b5987a260a74757],
>  
> [b2f57cd|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/b2f57cd43d7d961fcf194cf7bf61b1c79f343d44]|(/)|
> |{{org.apache.sling.servlets.resolver}}|[8262ce6|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/8262ce63725b9ab93c1d3eb07ace6b02d79acc65]|(!)
>  probably more classes which should be living in a scripting module|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-9987) Converter throws a ClassCastException for RepoInit without scripts or references field

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-9987.
-

> Converter throws a ClassCastException for RepoInit without scripts or 
> references field
> --
>
> Key: SLING-9987
> URL: https://issues.apache.org/jira/browse/SLING-9987
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Feature Model Converter Plugin 1.0.10
>Reporter: Ankit Rajpoot
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Feature Model Converter Plugin 1.0.12
>
>
> The Converter fails with a ClassCastException on encountering a RepoInit 
> script that doesn't have a "*scripts*" or "*references*" field. 
> {code:java}
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.sling:sling-feature-converter-maven-plugin:1.0.10:convert-cp 
> (convert-cp) on project com.adobe.fmdita: Content Package Converter Exception
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:498)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Content Package 
> Converter Exception
>     at org.apache.sling.cpconverter.maven.mojos.ConvertCPMojo.execute 
> (ConvertCPMojo.java:291)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
>     at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
>     at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
>     at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
>     at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
>     at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>     at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
>     at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
>     at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke (Method.java:498)
>     at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
>     

[jira] [Closed] (SLING-10041) Support the filter patterns of the cp2fm tool

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-10041.
--

> Support the filter patterns of the cp2fm tool
> -
>
> Key: SLING-10041
> URL: https://issues.apache.org/jira/browse/SLING-10041
> Project: Sling
>  Issue Type: New Feature
>  Components: Maven Plugins and Archetypes
>Affects Versions: Feature Model Converter Plugin 1.0.10
>Reporter: A. J. David Bosschaert
>Assignee: A. J. David Bosschaert
>Priority: Major
> Fix For: Feature Model Converter Plugin 1.0.12
>
>
> The cp2fm tool supports filter patterns, which can be specified with the 
> {{-f}} option. The Maven Plugin should support these too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10058) Activate the repoinit analyser by default

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-10058.
--

> Activate the repoinit analyser by default
> -
>
> Key: SLING-10058
> URL: https://issues.apache.org/jira/browse/SLING-10058
> Project: Sling
>  Issue Type: New Feature
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.22
>
>
> The repoinit plug-in is quick, does nothing if no repoinit extensions are 
> present and is very useful. We should enable it by default.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10035) Sling Feature fails when Generated Features Directory is missing

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-10035.
--

> Sling Feature fails when Generated Features Directory is missing
> 
>
> Key: SLING-10035
> URL: https://issues.apache.org/jira/browse/SLING-10035
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 1.4.20
>Reporter: Andreas Schaefer
>Assignee: Andreas Schaefer
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.22
>
>
> When I want to aggregate a Feature Model in another module like 'all' and 
> there is not attachment or other FM generation task beforehand the Sling 
> Feature Maven Plugin fails in handleGeneratedFeatures() method. This can be 
> fixed by copying the target folder from the resources but that is a lot of 
> unnecessary work.
>  
> I added code to that method that tries to create the folder if it does not 
> exist.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10056) Make feature self contained with respect to origins for configurations and properties

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-10056.
--

> Make feature self contained with respect to origins for configurations and 
> properties
> -
>
> Key: SLING-10056
> URL: https://issues.apache.org/jira/browse/SLING-10056
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model API Regions Extension 1.1.18
>
>
> When features are aggregated, configurations and framework properties get 
> metadata with their feature origins.
> When now a configuration api is used on an aggregated feature, it is 
> currently required that the feature origins (which might be different 
> features) are all available (via a feature provider). This makes the feature 
> not self-contained in such a scenario anymore which should be avoided to 
> easier pass around such a feature.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10052) Cache artifact resolution per project

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-10052.
--

> Cache artifact resolution per project
> -
>
> Key: SLING-10052
> URL: https://issues.apache.org/jira/browse/SLING-10052
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Carsten Ziegeler
>Assignee: Karl Pauls
>Priority: Major
> Fix For: slingfeature-maven-plugin 1.4.22
>
>
> ProjectHelper.getOrResolveArtifact is potentially a slow operation. The build 
> can be speed up by caching the resolution - if this method is called 
> frequently during a build



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (SLING-10055) Cache Feature lookup from FeatureProvider

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert closed SLING-10055.
--

> Cache Feature lookup from FeatureProvider
> -
>
> Key: SLING-10055
> URL: https://issues.apache.org/jira/browse/SLING-10055
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model Analyser
>Affects Versions: Feature Model Analyser 1.3.16
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model Analyser 1.3.18
>
>
> The analyzers should cache feature lookups from the feature provider to 
> speedup scans.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[RESULT][VOTE] Release Apache Sling Feature Model Analyser 1.3.18, Feature Model API Regions Extension 1.1.18, slingfeature-maven-plugin 1.4.22, Feature Model Converter Plugin 1.0.12

[davidb]

Hi all,

We received binding +1 votes from Karl Pauls, Carsten Ziegeler, Daniel
Klco, Stefan Seifert and me and a non-binding +1 vote from Andreas
Schaefer. No other votes were received.
With this, this release succeeds.

I have promoted the artifacts.

Best regards,

David

On Tue, 12 Jan 2021 at 11:04,  wrote:

> Hi all,
>
> I would like to call the release on the following Apache Sling Feature
> Model related components:
>
> Feature Model Analyser 1.3.18
> https://issues.apache.org/jira/projects/SLING/versions/12349508
>
> Feature Model API Regions Extension 1.1.18
> https://issues.apache.org/jira/projects/SLING/versions/12349509
>
> slingfeature-maven-plugin 1.4.22
> https://issues.apache.org/jira/projects/SLING/versions/12349510
>
> Feature Model Converter Plugin 1.0.12
> https://issues.apache.org/jira/projects/SLING/versions/12349443
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2391
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2391 /tmp/sling-staging
>
> Please vote to approve this release:
>
>[ ] +1 Approve the release
>[ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David
>

Re: [VOTE] Release Apache Sling Pipes 4.1.0

[Nicolas Peltier]

ho! ok, will cancel that release then, thanks for spotting this, Stefan

Le ven. 15 janv. 2021 à 12:05, Stefan Seifert
 a écrit :

> i've a problem running the unit tests on windows. surefire output see
> below.
> i assume there is a problem with line endings, can you fix the test that
> it is agnostic of unix/windows line endings?
>
> stefan
>
>
> ---
> Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
>
> ---
> Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s
> <<< FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet
> Time elapsed: 0.39 s  <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...:content"],"size":5}[]
> > but was:<...:content"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
> Time elapsed: 0.265 s  <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...tent/foo"],"size":1}[]
> > but was:<...tent/foo"],"size":1}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)
>
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand
> Time elapsed: 0.263 s  <<< FAILURE!
> org.junit.ComparisonFailure:
> expected:<...a/carrot"],"size":5}[]
> > but was:<...a/carrot"],"size":5}[
> ]
> >
> at
> org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)
>
>
>
>
> >-Original Message-
> >From: Nicolas Peltier 
> >Sent: Thursday, January 14, 2021 10:47 PM
> >To: Sling Developers List 
> >Subject: [VOTE] Release Apache Sling Pipes 4.1.0
> >
> >Hi,
> >
> >We solved 7 issues in this release:
> >https://issues.apache.org/jira/projects/SLING/versions/12349395
> >
> >Staging repository:
> >https://repository.apache.org/content/repositories/orgapachesling-2398/
> >
> >You can use this UNIX script to download the release and verify the
> >signatures:
> >https://gitbox.apache.org/repos/asf?p=sling-tooling-
> >release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> >Usage:
> >sh check_staged_release.sh 2398 /tmp/sling-staging
> >
> >Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> >
> >This majority vote is open for at least 72 hours.
> >
> >Regards,
>

RE: [VOTE] Release Apache Sling Pipes 4.1.0

[Stefan Seifert]

i've a problem running the unit tests on windows. surefire output see below.
i assume there is a problem with line endings, can you fix the test that it is 
agnostic of unix/windows line endings?

stefan

---
Test set: org.apache.sling.pipes.internal.CommandExecutorImplTest
---
Tests run: 17, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 4.657 s <<< 
FAILURE! - in org.apache.sling.pipes.internal.CommandExecutorImplTest
org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet  
Time elapsed: 0.39 s  <<< FAILURE!
org.junit.ComparisonFailure: 
expected:<...:content"],"size":5}[]
> but was:<...:content"],"size":5}[
]
>
at 
org.apache.sling.pipes.internal.CommandExecutorImplTest.testFileCommandServlet(CommandExecutorImplTest.java:236)

org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet
  Time elapsed: 0.265 s  <<< FAILURE!
org.junit.ComparisonFailure: 
expected:<...tent/foo"],"size":1}[]
> but was:<...tent/foo"],"size":1}[
]
>
at 
org.apache.sling.pipes.internal.CommandExecutorImplTest.testSimpleCommandServlet(CommandExecutorImplTest.java:200)

org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand  
Time elapsed: 0.263 s  <<< FAILURE!
org.junit.ComparisonFailure: 
expected:<...a/carrot"],"size":5}[]
> but was:<...a/carrot"],"size":5}[
]
>
at 
org.apache.sling.pipes.internal.CommandExecutorImplTest.testChainedCommand(CommandExecutorImplTest.java:225)




>-Original Message-
>From: Nicolas Peltier 
>Sent: Thursday, January 14, 2021 10:47 PM
>To: Sling Developers List 
>Subject: [VOTE] Release Apache Sling Pipes 4.1.0
>
>Hi,
>
>We solved 7 issues in this release:
>https://issues.apache.org/jira/projects/SLING/versions/12349395
>
>Staging repository:
>https://repository.apache.org/content/repositories/orgapachesling-2398/
>
>You can use this UNIX script to download the release and verify the
>signatures:
>https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
>Usage:
>sh check_staged_release.sh 2398 /tmp/sling-staging
>
>Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
>This majority vote is open for at least 72 hours.
>
>Regards,

RE: ***UNCHECKED*** Re: [VOTE] Release Apache Sling Pipes 4.1.0

[Stefan Seifert]

can you add your key to https://people.apache.org/keys/group/sling.asc
see [1], appendix A

stefan

[1] https://sling.apache.org/documentation/development/release-management.html

>-Original Message-
>From: Nicolas Peltier 
>Sent: Friday, January 15, 2021 11:41 AM
>To: Sling Developers List 
>Subject: ***UNCHECKED*** Re: [VOTE] Release Apache Sling Pipes 4.1.0
>
>Hey,
>
>spent quite some time yesterday to trying to send my new key to different
>key servers, thought as i could finally close the release in artifactory
>that it was good.
>attached it
>
>Le ven. 15 janv. 2021 à 00:04, Andreas Schaefer
> a écrit :
>+1 (non-binding)
>
>- Andy
>
>P.S.: the check does report gpg as bad because I do not have your
>(mailto:npelt...@apache.org) GPG key. Do you have one and if where can it
>be found?
>
>> On Jan 14, 2021, at 1:47 PM, Nicolas Peltier 
>wrote:
>>
>> Hi,
>>
>> We solved 7 issues in this release:
>> https://issues.apache.org/jira/projects/SLING/versions/12349395
>>
>> Staging repository:
>> https://repository.apache.org/content/repositories/orgapachesling-2398/
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> https://gitbox.apache.org/repos/asf?p=sling-tooling-
>release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>>
>> Usage:
>> sh check_staged_release.sh 2398 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>>  [ ] +1 Approve the release
>>  [ ]  0 Don't care
>>  [ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>> Regards,

RE: [VOTE] Release Apache Sling Servlets POST 2.4.2

[Stefan Seifert]

+1

RE: [VOTE] Release Apache Sling Installer Configuration Factory 1.3.4

[Stefan Seifert]

+1

RE: [VOTE] Release Apache Sling Resource Resolver 1.7.2

[Stefan Seifert]

+1

***UNCHECKED*** Re: [VOTE] Release Apache Sling Pipes 4.1.0

[Nicolas Peltier]

Hey,

spent quite some time yesterday to trying to send my new key to different
key servers, thought as i could finally close the release in artifactory
that it was good.
attached it

Le ven. 15 janv. 2021 à 00:04, Andreas Schaefer 
a écrit :

> +1 (non-binding)
>
> - Andy
>
> P.S.: the check does report gpg as bad because I do not have your (
> npelt...@apache.org) GPG key. Do you have one and if where can it be
> found?
>
> > On Jan 14, 2021, at 1:47 PM, Nicolas Peltier 
> wrote:
> >
> > Hi,
> >
> > We solved 7 issues in this release:
> > https://issues.apache.org/jira/projects/SLING/versions/12349395
> >
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2398/
> >
> > You can use this UNIX script to download the release and verify the
> > signatures:
> >
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
> > Usage:
> > sh check_staged_release.sh 2398 /tmp/sling-staging
> >
> > Please vote to approve this release:
> >
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> >
> > This majority vote is open for at least 72 hours.
> >
> > Regards,
>
>


npeltier.pgp
Description: application/pgp-encrypted

[jira] [Commented] (SLING-10043) Naming OSGi configs with dashes breaks the OSGi installer

[Akanksha Jain (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265901#comment-17265901
 ] 

Akanksha Jain commented on SLING-10043:
---

Thank you [~rombert]

> Naming OSGi configs with dashes breaks the OSGi installer
> -
>
> Key: SLING-10043
> URL: https://issues.apache.org/jira/browse/SLING-10043
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.2.4, Installer 
> Configuration Factory 1.3.0, Installer Configuration Factory 1.3.2
>Reporter: Akanksha Jain
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Installer Configuration Factory 1.3.4
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> If you name OSGi configuration files with many dashes in the name it can 
> break the OSGi installer module causing this error [1].
> {code:java}
> 10.09.2020 16:57:40.689 *ERROR* [OsgiInstallerImpl] 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl An unexpected error 
> occured in the installer task. Installer is stopped now!
> java.lang.ArrayIndexOutOfBoundsException: 0
>   at 
> org.apache.sling.installer.factories.configuration.impl.ConfigUpdateHandler.getMiddleDotSplitIndex(ConfigUpdateHandler.java:135)
>   at 
> org.apache.sling.installer.factories.configuration.impl.ConfigUpdateHandler.getFactoryPidAndPid(ConfigUpdateHandler.java:115)
>   at 
> org.apache.sling.installer.factories.configuration.impl.ConfigUpdateHandler.updateFactoryConfig(ConfigUpdateHandler.java:143)
>   at 
> org.apache.sling.installer.factories.configuration.impl.ConfigUpdateHandler.update(ConfigUpdateHandler.java:87)
>   at 
> org.apache.sling.installer.factories.configuration.impl.ConfigUpdateHandler.update(ConfigUpdateHandler.java:72)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.handleResourceUpdaters(OsgiInstallerImpl.java:1640)
>   at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:272)
>   at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling Pipes 4.1.0

[Robert Munteanu]

On Thu, 2021-01-14 at 22:47 +0100, Nicolas Peltier wrote:
> Please vote to approve this release:

+1
Robert


signature.asc
Description: This is a digitally signed message part