Re: [VOTE] Release Apache Sling Content Distribution Core version 0.4.4
+1 Regards, Timothee Le mar. 26 janv. 2021 à 14:07, Christian Schneider a écrit : > Hi, > > We solved 11 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12346959 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2401/ > > You can use this UNIX script to download the release and verify the > signatures: > > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD > > Usage: > sh check_staged_release.sh [YOUR REPOSITORY ID] /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > -- > > Here is my > +1 > > -- > Christian Schneider > http://www.liquid-reality.de > > Computer Scientist > http://www.adobe.com >
[GitHub] [sling-org-apache-sling-jcr-packageinit] kwin commented on a change in pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
kwin commented on a change in pull request #3:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#discussion_r564752756
##
File path:
src/main/java/org/apache/sling/jcr/packageinit/impl/ExecutionPlanRepoInitializer.java
##
@@ -163,6 +164,14 @@ public void processRepository(SlingRepository
slingRepository) throws Exception
builder.with(session);
ExecutionPlan xplan = builder.execute();
if (xplan.getTasks().size() > 0) {
+if (xplan.hasErrors()) {
+for (PackageTask task : xplan.getTasks()) {
+if
(PackageTask.State.ERROR.equals(task.getState())){
+logger.error("Error during
installation of {}: {}", task.getPackageId().toString(),
task.getError().toString());
Review comment:
Please rather add those as suppressed exceptions via
https://docs.oracle.com/javase/7/docs/api/java/lang/Throwable.html#addSuppressed(java.lang.Throwable)
to the ISE. They already get logged within
https://github.com/apache/jackrabbit-filevault/blob/beb4a72adcf963c1da6ed9604c18b8b5b69ee57c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/registry/impl/PackageTaskImpl.java#L113.
##
File path: pom.xml
##
@@ -42,37 +41,14 @@
+
Review comment:
No need to explicitly list these plugins as they are activated in the
parent:
https://github.com/apache/sling-parent/blob/7e6567a003f670e179895b9000e294bc631bae18/sling-bundle-parent/pom.xml#L192
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SLING-10080) Onboard org.apache.sling.jcr.maintenance to SonarCloud
[ https://issues.apache.org/jira/browse/SLING-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272326#comment-17272326 ] Dan Klco commented on SLING-10080: -- [~bellingard] Can you set up the quality gates? I would think this could be set the same as the other Sling bundle projects. > Onboard org.apache.sling.jcr.maintenance to SonarCloud > -- > > Key: SLING-10080 > URL: https://issues.apache.org/jira/browse/SLING-10080 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > Attachments: screenshot-1.png > > > [~bellingard] - can you please onboard > https://github.com/apache/sling-org-apache-sling-jcr-maintenance to > SonarCloud? > Thanks! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-dynamic-include] sonarcloud[bot] commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request
sonarcloud[bot] commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-767709363 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-dynamic-include&pullRequest=19&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-dynamic-include] santiagozky edited a comment on pull request #19: Extend the IncludeGenerator interface with the Sling Request
santiagozky edited a comment on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-767708146 The current interface is a bit limited. I want to create a custom IncludeGenerator that relies in some 'context' that could be obtained from the original request. If changing the interface is not an option, maybe I can add a second method? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-dynamic-include] santiagozky commented on pull request #19: Extend the IncludeGenerator interface with the Sling Request
santiagozky commented on pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19#issuecomment-767708146 The current interface is a bit limited. I want to create a custom IncludeGenerator that relies in some 'context' that could be obtained from the original request. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-dynamic-include] santiagozky opened a new pull request #19: Extend the IncludeGenerator interface with the Sling Request
santiagozky opened a new pull request #19: URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/19 Extend the IncludeGenerator interface with the Sling Request to give more flexibility to potential implementations of the interface. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Apache Sling Content Distribution Core version 0.4.4
Hi Robert, PR pending: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/44 :-) Am Di., 26. Jan. 2021 um 18:05 Uhr schrieb Robert Munteanu < romb...@apache.org>: > On Tue, 2021-01-26 at 14:06 +0100, Christian Schneider wrote: > > Please vote to approve this release: > > +1 from me. > > That being said, it would be nice to update to the latest parent pom to > fix building on Java 11, which would at least unblock SonarCloud runs. > > Thanks, > Robert > -- Cheers, Jörg Hoh, http://cqdump.wordpress.com Twitter: @joerghoh
Re: [VOTE] Release Apache Sling Content Distribution Core version 0.4.4
On Tue, 2021-01-26 at 14:06 +0100, Christian Schneider wrote: > Please vote to approve this release: +1 from me. That being said, it would be nice to update to the latest parent pom to fix building on Java 11, which would at least unblock SonarCloud runs. Thanks, Robert signature.asc Description: This is a digitally signed message part
[GitHub] [sling-org-apache-sling-jcr-packageinit] rombert commented on pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
rombert commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#issuecomment-767683873 Thanks @suess, LGTM. Konrad is the main reviewer here though, so we should wait for his opinion as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-8595) Update of sling parent pom
[ https://issues.apache.org/jira/browse/SLING-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272245#comment-17272245 ] Robert Munteanu commented on SLING-8595: Removed fix version from Won't fix issue as it appears in the 'done in release' listing, which is confusing IMO. > Update of sling parent pom > -- > > Key: SLING-8595 > URL: https://issues.apache.org/jira/browse/SLING-8595 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > > When running upstream modules together with sling distribution core in > eclipse I got issues as the outdated osgi core jar slipped into the build > dependencies of the upstream module. > I found that updating the parent pom fixed the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-8595) Update of sling parent pom
[ https://issues.apache.org/jira/browse/SLING-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-8595: --- Fix Version/s: (was: Content Distribution Core 0.4.4) > Update of sling parent pom > -- > > Key: SLING-8595 > URL: https://issues.apache.org/jira/browse/SLING-8595 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > > When running upstream modules together with sling distribution core in > eclipse I got issues as the outdated osgi core jar slipped into the build > dependencies of the upstream module. > I found that updating the parent pom fixed the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-jcr-packageinit] sonarcloud[bot] commented on pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
sonarcloud[bot] commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#issuecomment-767619211 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&metric=new_coverage&view=list) [83.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-packageinit&pullRequest=3&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-packageinit] DominikSuess commented on pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
DominikSuess commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#issuecomment-767618788 @kwin , @rombert - thanks for the review - incorporated the change to spawn the corresponding throwables as error messages (and added testcase) as well as bumping to latest bundle parent (including the necessary switch to bnd plugin) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-testing-jcr-mock] sonarcloud[bot] commented on pull request #5: Add mock node definition, is used in JcrUtil.copy to deep copy nodes
sonarcloud[bot] commented on pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/5#issuecomment-767576361 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&metric=new_duplicated_lines_density&view=list) [49.2% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-jcr-mock&pullRequest=5&metric=new_duplicated_lines_density&view=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-10093) Add Mock Node Definition in jcr-mock
[ https://issues.apache.org/jira/browse/SLING-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272121#comment-17272121 ] Roy Teeuwen commented on SLING-10093: - Added a pull request to add a mock node definition: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/5 > Add Mock Node Definition in jcr-mock > > > Key: SLING-10093 > URL: https://issues.apache.org/jira/browse/SLING-10093 > Project: Sling > Issue Type: Improvement > Components: Testing >Reporter: Roy Teeuwen >Priority: Major > > There is no mock node definition for the jcr mocks. It would be handy if > there is one because the JcrUtil.copy uses the node's definition when doing a > deep copy of a source node to a target -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10093) Add Mock Node Definition in jcr-mock
Roy Teeuwen created SLING-10093: --- Summary: Add Mock Node Definition in jcr-mock Key: SLING-10093 URL: https://issues.apache.org/jira/browse/SLING-10093 Project: Sling Issue Type: Improvement Components: Testing Reporter: Roy Teeuwen There is no mock node definition for the jcr mocks. It would be handy if there is one because the JcrUtil.copy uses the node's definition when doing a deep copy of a source node to a target -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-testing-jcr-mock] royteeuwen opened a new pull request #5: Add mock node definition, is used in JcrUtil.copy to deep copy nodes
royteeuwen opened a new pull request #5: URL: https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/5 https://issues.apache.org/jira/browse/SLING-10093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Apache Sling Content Distribution Core version 0.4.4
Hi, We solved 11 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12346959 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2401/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh [YOUR REPOSITORY ID] /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. -- Here is my +1 -- Christian Schneider http://www.liquid-reality.de Computer Scientist http://www.adobe.com
[jira] [Resolved] (SLING-10067) Prototype for chunked deep distribution
[ https://issues.apache.org/jira/browse/SLING-10067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-10067. - Resolution: Fixed > Prototype for chunked deep distribution > --- > > Key: SLING-10067 > URL: https://issues.apache.org/jira/browse/SLING-10067 > Project: Sling > Issue Type: Bug > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > > We have a case where a tree distribution could not be applied on oak level as > it was too large. As we can not control how large a tree can grow we should > have a solution that does not depend on the size of the tree. > I would like to create a prototype of a chunked deep distribution. It is > given a path to distribute and walks through the full tree of resources to > collect paths (breadth first). > Then the list of paths is split into chunks of configurable size. For each > chunk we create a distribution with all paths of the chunk. This makes sure > the package size will not grow too big. > The call should be asyncronous and it should be possible to monitor and > cancel the progress of package creation. So the idea is to use a sling job > with JobExecutor interface. This way the job can report progress and react to > cancel requests. > I plan to create the prototype in the sling whiteboard. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10092) Deprecate ConfigurationJSONReader and ConfigurationJSONWriter
A. J. David Bosschaert created SLING-10092: -- Summary: Deprecate ConfigurationJSONReader and ConfigurationJSONWriter Key: SLING-10092 URL: https://issues.apache.org/jira/browse/SLING-10092 Project: Sling Issue Type: Bug Components: Feature Model Affects Versions: Feature Model 1.2.18 Reporter: A. J. David Bosschaert Fix For: Feature Model 1.2.20 These 2 classes in the core feature model in the org.apache.sling.feature.io.json package are replaced by cm.json and should therefore be deprecated and removed in the future. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10091) ConfigurationJSONReader returns empty list
[ https://issues.apache.org/jira/browse/SLING-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-10091. -- Resolution: Fixed Fixed in https://github.com/apache/sling-org-apache-sling-feature/commit/75c4a034e2e673b06de83737c1d41291fe31963c > ConfigurationJSONReader returns empty list > -- > > Key: SLING-10091 > URL: https://issues.apache.org/jira/browse/SLING-10091 > Project: Sling > Issue Type: Bug > Components: Feature Model >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model 1.2.20 > > > ConfigurationJSONReader does not add the configurations to the list, > therefore always returning an empty list -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-10091) ConfigurationJSONReader returns empty list
Carsten Ziegeler created SLING-10091: Summary: ConfigurationJSONReader returns empty list Key: SLING-10091 URL: https://issues.apache.org/jira/browse/SLING-10091 Project: Sling Issue Type: Bug Components: Feature Model Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model 1.2.20 ConfigurationJSONReader does not add the configurations to the list, therefore always returning an empty list -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9017) ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
[
https://issues.apache.org/jira/browse/SLING-9017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated SLING-9017:
---
Fix Version/s: (was: Content Distribution Core 0.4.4)
Content Distribution Core 0.4.6
> ErrorQueueDispatchingStrategy ends up using an incorrect QueueProvider
> --
>
> Key: SLING-9017
> URL: https://issues.apache.org/jira/browse/SLING-9017
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Ashish Chopra
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.6
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, {{ErrorQueueDispatchingStrategy}} [0] interface dictates that the
> {{.add}} [1] method supplies the {{DistributionQueueProvider}} [1] to it.
> For {{ForwardDistributionAgentFactory}} (and perhaps other Agent-factories as
> well), this {{DistributionQueueProvider}} is further used to {{.getQueue}} by
> a name [2].
> As the discussion in SLING-8854 concluded, it was found acceptable [3] for
> {{DistributionQueue}} impls and {{DistributionQueueProvider}} impls to share
> state - concordantly, there needs to be a way for Agent-Factories to dictate
> which _specific_ queue-providers they want {{ErrorQueueDispatchingStrategy}}
> to use.
> One approach to make that happen would be to enhance
> {{ErrorQueueDispatchingStrategy}} with another CTOR to accept a
> {{DistributionQueueProvider}} argument. The impl of {{.add}} can then treat
> the supplied {{DistributionQueueProvider}} at the time of API invocation as a
> 'hint' and ignore it if the {{ErrorQueueDispatchingStrategy}} already has one
> of its own.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/ErrorQueueDispatchingStrategy.java#L56
> [2]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L187
> [3]
> https://issues.apache.org/jira/browse/SLING-8854?focusedCommentId=16982396&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16982396
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (SLING-8994) Optimize session saves for Single Queue Dispatching Strategy
[
https://issues.apache.org/jira/browse/SLING-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider updated SLING-8994:
---
Fix Version/s: (was: Content Distribution Core 0.4.4)
Content Distribution Core 0.4.6
> Optimize session saves for Single Queue Dispatching Strategy
>
>
> Key: SLING-8994
> URL: https://issues.apache.org/jira/browse/SLING-8994
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Reporter: Ashish Chopra
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Core 0.4.6
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Separation of concerns dictate that there's a loose coupling between
> Distribution Packages and Queue entries, and thus the distribution-packages
> and queue-items are persisted in different sessions (indeed, depending on
> queue-impl/distribution-packaging-impl chosen there may not be a need to
> persist either, or any of them at all).
> To enable collection of unreferenced Distribution packages, currently, queue
> items are be acquired [0] and released [1] on a per-queue basis in
> {{MultipleQueueDispatchingStrategy}}. Only the distribution-packages that
> don't have any live references are claimed.
> For a 1:1 distribution (as {{SingleQueueDispatchingStrategy}} [2] aims to
> achieve), acquring and releasing packages is superfluous (since there's only
> one queue) and as such it should just be sufficient to mark the package
> 'released' [3] once the queue is done with it.
> However, the ref-updates still happen given way it is implemented currently
> (as a subclass of {{MultipleQueueDispatchingStrategy}} that doesn't override
> anything [2]).
> Opening this issue propose improving {{SingleQueueDispatchingStrategy}} impl.
> This should slightly optimize the book-keeping and marginally reduce the
> write-overhead for 1:1 distribution.
> [0]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/MultipleQueueDispatchingStrategy.java#L61
> [1]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/agent/impl/SimpleDistributionAgentQueueProcessor.java#L169
> [2]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/queue/impl/SingleQueueDispatchingStrategy.java
> [3]
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/537bb57af821f21537cf4a24ad7d2347c6a5dae1/src/main/java/org/apache/sling/distribution/packaging/impl/DistributionPackageUtils.java#L107-L111
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-4075) Improve test coverage of SCD
[ https://issues.apache.org/jira/browse/SLING-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272035#comment-17272035 ] Timothee Maret commented on SLING-4075: --- This issue has been kept open for a long time and should be closed. SCD is a large multi-module project and test coverage has been increased as part of this issue and as part of other contributions. We should re-open more targeted issues to cover the components that remain uncovered. > Improve test coverage of SCD > > > Key: SLING-4075 > URL: https://issues.apache.org/jira/browse/SLING-4075 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Tommaso Teofili >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > Currently we moved lots of testing to the IT module but it'd be good to have > a better test coverage via unit testing in core module, at least to test > basic use cases and maybe some edge cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-4075) Improve test coverage of SCD
[ https://issues.apache.org/jira/browse/SLING-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret resolved SLING-4075. --- Resolution: Fixed > Improve test coverage of SCD > > > Key: SLING-4075 > URL: https://issues.apache.org/jira/browse/SLING-4075 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Tommaso Teofili >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > Currently we moved lots of testing to the IT module but it'd be good to have > a better test coverage via unit testing in core module, at least to test > basic use cases and maybe some edge cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-4075) Improve test coverage of SCD
[ https://issues.apache.org/jira/browse/SLING-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272032#comment-17272032 ] Christian Schneider commented on SLING-4075: Can we close this issue for 0.4.4 and create a new one for the next version if needed? > Improve test coverage of SCD > > > Key: SLING-4075 > URL: https://issues.apache.org/jira/browse/SLING-4075 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Tommaso Teofili >Assignee: Timothee Maret >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > Currently we moved lots of testing to the IT module but it'd be good to have > a better test coverage via unit testing in core module, at least to test > basic use cases and maybe some edge cases. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8595) Update of sling parent pom
[ https://issues.apache.org/jira/browse/SLING-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-8595. Resolution: Won't Fix > Update of sling parent pom > -- > > Key: SLING-8595 > URL: https://issues.apache.org/jira/browse/SLING-8595 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > When running upstream modules together with sling distribution core in > eclipse I got issues as the outdated osgi core jar slipped into the build > dependencies of the upstream module. > I found that updating the parent pom fixed the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-8595) Update of sling parent pom
[ https://issues.apache.org/jira/browse/SLING-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272031#comment-17272031 ] Christian Schneider commented on SLING-8595: I will close this one and propose we look into the issue Jörg opened as he provides a fix PR. > Update of sling parent pom > -- > > Key: SLING-8595 > URL: https://issues.apache.org/jira/browse/SLING-8595 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Christian Schneider >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > > When running upstream modules together with sling distribution core in > eclipse I got issues as the outdated osgi core jar slipped into the build > dependencies of the upstream module. > I found that updating the parent pom fixed the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-8639) VltUtils does not escape path in when creating filter patterns
[
https://issues.apache.org/jira/browse/SLING-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider resolved SLING-8639.
Resolution: Fixed
> VltUtils does not escape path in when creating filter patterns
> --
>
> Key: SLING-8639
> URL: https://issues.apache.org/jira/browse/SLING-8639
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.4.0
>Reporter: Timothee Maret
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Core 0.4.4
>
>
> When distributing a deep content path that includes parenthesis using
> FileVault, the content package produced does not contain content under that
> path.
> As an example, consider distributing the following path
> {code:java}
> /content/dam/we-retail/planet(1).jpg{code}
> which will yield a content package with the following filter.xml
> {code:java}
>
>
>
>
>
>
>
> matchProperties="true"/>
>
>
> {code}
> The include and exclude patterns are treated by FileVault [as regular
> expression|https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/filter/DefaultPathFilter.java#L84].
> Thus the {{(1)}} part of the {{/content/dam/we-retail/planet(1).jpg}} and
> {{/content/dam/we-retail/planet(1).jpg/.*}} patterns is treated as a group
> rather than literally.
> The path should be escaped when building the patterns, in
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/3d51ac0b09c9a057b590349727392eaedba26aea/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VltUtils.java#L84
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (SLING-8639) VltUtils does not escape path in when creating filter patterns
[
https://issues.apache.org/jira/browse/SLING-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider reassigned SLING-8639:
--
Assignee: Christian Schneider
> VltUtils does not escape path in when creating filter patterns
> --
>
> Key: SLING-8639
> URL: https://issues.apache.org/jira/browse/SLING-8639
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.4.0
>Reporter: Timothee Maret
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Core 0.4.4
>
>
> When distributing a deep content path that includes parenthesis using
> FileVault, the content package produced does not contain content under that
> path.
> As an example, consider distributing the following path
> {code:java}
> /content/dam/we-retail/planet(1).jpg{code}
> which will yield a content package with the following filter.xml
> {code:java}
>
>
>
>
>
>
>
> matchProperties="true"/>
>
>
> {code}
> The include and exclude patterns are treated by FileVault [as regular
> expression|https://github.com/apache/jackrabbit-filevault/blob/6df76ba4a45316a84ec1cd10636296d191a82260/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/filter/DefaultPathFilter.java#L84].
> Thus the {{(1)}} part of the {{/content/dam/we-retail/planet(1).jpg}} and
> {{/content/dam/we-retail/planet(1).jpg/.*}} patterns is treated as a group
> rather than literally.
> The path should be escaped when building the patterns, in
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/3d51ac0b09c9a057b590349727392eaedba26aea/src/main/java/org/apache/sling/distribution/serialization/impl/vlt/VltUtils.java#L84
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9582) OsgiConfigurationManager should use Configuration#getProcessedProperties
[ https://issues.apache.org/jira/browse/SLING-9582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved SLING-9582. Resolution: Fixed > OsgiConfigurationManager should use Configuration#getProcessedProperties > > > Key: SLING-9582 > URL: https://issues.apache.org/jira/browse/SLING-9582 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Affects Versions: Content Distribution Core 0.4.2 >Reporter: Carsten Ziegeler >Assignee: Christian Schneider >Priority: Major > Fix For: Content Distribution Core 0.4.4 > > Time Spent: 50m > Remaining Estimate: 0h > > OsgiConfigurationManager uses Configuration#getProperties to get properties > from an OSGi configuration (in two places). However, it should rather use > Configuration#getProcessedProperties(ServiceReference) instead. THis way > configuration plugins like the Apache Felix interpolation plugin are run -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10088) PatternSyntaxException: Unclosed group near index x
[
https://issues.apache.org/jira/browse/SLING-10088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christian Schneider resolved SLING-10088.
-
Resolution: Fixed
> PatternSyntaxException: Unclosed group near index x
> ---
>
> Key: SLING-10088
> URL: https://issues.apache.org/jira/browse/SLING-10088
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Core 0.4.2
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Critical
> Fix For: Content Distribution Core 0.4.4
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> if a path contains a "(" the following exception will occur when we try to
> distribute it.
> As far as I can tell the problem is a missing escaping of the path in
> org.apache.sling.distribution.serialization.impl.vlt.VltUtils.createFilter.
> {code:java}
> [org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
> org.apache.sling.distribution.journal.impl.publisher.PackageMessageFactory.createAdd(PackageMessageFactory.java:95)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.PackageMessageFactory.create(PackageMessageFactory.java:86)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.lambda$execute$1(DistributionPublisher.java:271)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.shared.DistributionMetricsService.timed(DistributionMetricsService.java:147)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.execute(DistributionPublisher.java:270)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.journal.impl.publisher.DistributionPublisher.execute(DistributionPublisher.java:259)
> [org.apache.sling.distribution.journal:0.2.0.T202009251421-0284693]
> at
> org.apache.sling.distribution.impl.DefaultDistributor.distribute(DefaultDistributor.java:60)
> [org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
> org.apache.sling.distribution.chunked.ChunkedDistribution.distributeChunk(ChunkedDistribution.java:124)
> [org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
> org.apache.sling.distribution.chunked.ChunkedDistribution.distribute(ChunkedDistribution.java:102)
> [org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
> org.apache.sling.distribution.chunked.ChunkedDistribution.process(ChunkedDistribution.java:72)
> [org.apache.sling.distribution.chunked:0.1.0.20210121164255060] at
> org.apache.sling.event.impl.jobs.queues.JobQueueImpl.startJob(JobQueueImpl.java:293)
> [org.apache.sling.event:4.2.12] at
> org.apache.sling.event.impl.jobs.queues.JobQueueImpl.access$100(JobQueueImpl.java:60)
> [org.apache.sling.event:4.2.12] at
> org.apache.sling.event.impl.jobs.queues.JobQueueImpl$1.run(JobQueueImpl.java:229)
> [org.apache.sling.event:4.2.12] at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:834)Caused by:
> java.util.regex.PatternSyntaxException: Unclosed group near index
> 20/nodewith(shouldwork at
> java.base/java.util.regex.Pattern.error(Pattern.java:2027) at
> java.base/java.util.regex.Pattern.accept(Pattern.java:1877) at
> java.base/java.util.regex.Pattern.group0(Pattern.java:3060) at
> java.base/java.util.regex.Pattern.sequence(Pattern.java:2123) at
> java.base/java.util.regex.Pattern.expr(Pattern.java:2068) at
> java.base/java.util.regex.Pattern.compile(Pattern.java:1782) at
> java.base/java.util.regex.Pattern.(Pattern.java:1428) at
> java.base/java.util.regex.Pattern.compile(Pattern.java:1068) at
> org.apache.jackrabbit.vault.fs.filter.DefaultPathFilter.setPattern(DefaultPathFilter.java:68)
> [org.apache.jackrabbit.vault:3.4.0] at
> org.apache.jackrabbit.vault.fs.filter.DefaultPathFilter.(DefaultPathFilter.java:48)
> [org.apache.jackrabbit.vault:3.4.0] at
> org.apache.sling.distribution.serialization.impl.vlt.VltUtils.createFilter(VltUtils.java:92)
> [org.apache.sling.distribution.core:0.4.3.T20200720-c96d3fb] at
> org.apache.sling.distribution.serialization.impl.vlt.FileVaultContentSerializer.exportToStr
[GitHub] [sling-org-apache-sling-distribution-core] cschneider closed pull request #45: Fixed vault filter generation so that paths are properly escaped
cschneider closed pull request #45: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-core] cschneider merged pull request #46: SLING-10088 - Correctly escape paths
cschneider merged pull request #46: URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-10084) Prevent the creation of configuration properties with duplicate keys
[ https://issues.apache.org/jira/browse/SLING-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-10084. Resolution: Fixed > Prevent the creation of configuration properties with duplicate keys > > > Key: SLING-10084 > URL: https://issues.apache.org/jira/browse/SLING-10084 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 1.2.18 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model 1.2.20 > > > Having 2 (or more) properties in a single configuration with the same key > regardless of capitalization is an invalid situation and should not be > allowed in feature models. > When reading or writing a feature we should fail if the feature is detected > to have duplicate property keys within a single PID by comparing the keys in > a case insensitive way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-10084) Prevent the creation of configuration properties with duplicate keys
[ https://issues.apache.org/jira/browse/SLING-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271998#comment-17271998 ] A. J. David Bosschaert commented on SLING-10084: I'll update the Feature to pick up the latest cm.json. > Prevent the creation of configuration properties with duplicate keys > > > Key: SLING-10084 > URL: https://issues.apache.org/jira/browse/SLING-10084 > Project: Sling > Issue Type: Improvement > Components: Feature Model >Affects Versions: Feature Model 1.2.18 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model 1.2.20 > > > Having 2 (or more) properties in a single configuration with the same key > regardless of capitalization is an invalid situation and should not be > allowed in feature models. > When reading or writing a feature we should fail if the feature is detected > to have duplicate property keys within a single PID by comparing the keys in > a case insensitive way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9611) Enforce setting the "project.build.outputTimestamp" property
[ https://issues.apache.org/jira/browse/SLING-9611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-9611: --- Description: The property is required for reproducible builds and should therefore be enforced ([https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build]). Right now it will fallback to the property set on the parent, but this cannot be updated with each release, therefore preferably the property should be set on each reactor pom.xml. was:The property is required for reproducible builds and should therefore be enforced ([https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build]) > Enforce setting the "project.build.outputTimestamp" property > > > Key: SLING-9611 > URL: https://issues.apache.org/jira/browse/SLING-9611 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Priority: Major > Fix For: Parent 41 > > > The property is required for reproducible builds and should therefore be > enforced > ([https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build]). > Right now it will fallback to the property set on the parent, but this cannot > be updated with each release, therefore preferably the property should be set > on each reactor pom.xml. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-10059) Drop management of org.codehaus.groovy.maven:gmaven-plugin
[ https://issues.apache.org/jira/browse/SLING-10059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved SLING-10059. - Assignee: Konrad Windszus Resolution: Fixed Removed in https://github.com/apache/sling-parent/commit/d14ea473296c95164b5df2aeee9beeb4a8a9a5d5. > Drop management of org.codehaus.groovy.maven:gmaven-plugin > -- > > Key: SLING-10059 > URL: https://issues.apache.org/jira/browse/SLING-10059 > Project: Sling > Issue Type: Improvement > Components: General >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: Parent 41 > > > According to https://groovy.github.io/gmaven/ the gmaven-plugin should no > longer be used to compile Groovy scripts. Also groovy is used in almost no > Sling modules, therefore I propose to just remove it from > https://github.com/apache/sling-parent/blob/f9dc40c7e40a5f38e5bb360efe7afa16b5e06673/sling-parent/pom.xml#L348 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-10054) Get rid of emma-maven-plugin and related profiles
[
https://issues.apache.org/jira/browse/SLING-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-10054:
---
Assignee: Konrad Windszus
> Get rid of emma-maven-plugin and related profiles
> -
>
> Key: SLING-10054
> URL: https://issues.apache.org/jira/browse/SLING-10054
> Project: Sling
> Issue Type: Improvement
> Components: General
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Parent 41
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Our parent pom.xml contains a profile with id {{emma}} leveraging the
> {{emma-maven-plugin}} from org.codehaus
> (https://github.com/apache/sling-parent/blob/de3d9c8255fa84a62a7be921127376a817309bd9/sling-parent/pom.xml#L402).
> As we now do the coverage reporting with profile {{jacoco-report}} and the
> {{jacoco-maven-plugin}} we should get rid of the {{emma}} profile and most
> probably also of {{emma-report}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-10054) Get rid of emma-maven-plugin and related profiles
[
https://issues.apache.org/jira/browse/SLING-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-10054.
-
Resolution: Fixed
Removed in
https://github.com/apache/sling-parent/commit/d14ea473296c95164b5df2aeee9beeb4a8a9a5d5.
> Get rid of emma-maven-plugin and related profiles
> -
>
> Key: SLING-10054
> URL: https://issues.apache.org/jira/browse/SLING-10054
> Project: Sling
> Issue Type: Improvement
> Components: General
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Parent 41
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Our parent pom.xml contains a profile with id {{emma}} leveraging the
> {{emma-maven-plugin}} from org.codehaus
> (https://github.com/apache/sling-parent/blob/de3d9c8255fa84a62a7be921127376a817309bd9/sling-parent/pom.xml#L402).
> As we now do the coverage reporting with profile {{jacoco-report}} and the
> {{jacoco-maven-plugin}} we should get rid of the {{emma}} profile and most
> probably also of {{emma-report}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-10090) Add default value to property description
Carsten Ziegeler created SLING-10090: Summary: Add default value to property description Key: SLING-10090 URL: https://issues.apache.org/jira/browse/SLING-10090 Project: Sling Issue Type: Improvement Components: Feature Model Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model API Regions Extension 1.1.20 A property description should also have a possibility to store the default value -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-parent] kwin merged pull request #14: SLING-10054 remove emma-maven-plugin and related profiles
kwin merged pull request #14: URL: https://github.com/apache/sling-parent/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-parent] kwin commented on pull request #14: SLING-10054 remove emma-maven-plugin and related profiles
kwin commented on pull request #14: URL: https://github.com/apache/sling-parent/pull/14#issuecomment-767374831 Given that emma-maven-plugin is no longer maintained and the last release was in 2010 I would remove it. In case someone needs the profile we need to look for another way to generate the coverage report. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-packageinit] rombert commented on pull request #3: SLING-10089 - adding logic & test to consider failing on error in exe…
rombert commented on pull request #3: URL: https://github.com/apache/sling-org-apache-sling-jcr-packageinit/pull/3#issuecomment-767372462 A bit unrelated, but it would be nice to also update the project to the latest parent POM so it can build with Java 11 and therefore have a working SonarCloud analysis. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
