[GitHub] [sling-site] npeltier merged pull request #56: SLING-10179 update Filter doc

2021-03-03 Thread GitBox 


npeltier merged pull request #56:
URL: https://github.com/apache/sling-site/pull/56


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #370 is BROKEN

2021-03-03 Thread Apache Jenkins Server 
publishers.GeneratedArtifactsPublisher[disabled=false],
 
JunitTestsPublisher[disabled=false,healthScaleFactor=,keepLongStdio=false,ignoreAttachments=false],
 
org.jenkinsci.plugins.pipeline.maven.publishers.TasksScannerPublisher[disabled='false',
 healthy='', unHealthy='', thresholdLimit='low'], 
org.jenkinsci.plugins.pipeline.maven.publishers.DependenciesFingerprintPublisher[disabled=false,
 scopes=[compile, provided, runtime], versions={snapshot:true, release:false}]]
[withMaven] Available options: 
[withMaven] using JDK installation jdk_1.8_latest
[withMaven] using Maven installation 'maven_3_latest'
[Pipeline] {
[Pipeline] sh
+ mvn -U clean deploy -Pci
- withMaven Wrapper script -
Picked up JAVA_TOOL_OPTIONS: 
-Dmaven.ext.class.path="/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavence8c21ee/pipeline-maven-spy.jar"
 
-Dorg.jenkinsci.plugins.pipeline.maven.reportsFolder="/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavence8c21ee"
 
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/jenkins/tools/maven/latest3
Java version: 1.8.0_281, vendor: Oracle Corporation, runtime: 
/usr/local/asfpackages/java/oraclejdk-1.8.0-281/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-124-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate 
/home/jenkins/workspace/e-sling-launchpad-testing_master@tmp/withMavence8c21ee/maven-spy-20210303-112619-2993856508302307813239.log.tmp
 ...
[INFO] Scanning for projects...
[INFO] 
[INFO] < org.apache.sling:org.apache.sling.launchpad.testing >-
[INFO] Building Apache Sling Launchpad Testing 12-SNAPSHOT
[INFO] [ jar ]-
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/maven-metadata.xml
[INFO] Downloaded from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/maven-metadata.xml
 (1.0 kB at 1.4 kB/s)
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integration-tests-12-20210303.061343-255.pom
[INFO] Downloaded from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integration-tests-12-20210303.061343-255.pom
 (14 kB at 36 kB/s)
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/maven-metadata.xml
[INFO] Downloaded from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/maven-metadata.xml
 (1.0 kB at 2.7 kB/s)
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-20210227.192440-133.pom
[INFO] Downloaded from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-20210227.192440-133.pom
 (9.8 kB at 28 kB/s)
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/maven-metadata.xml
[INFO] Downloaded from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/maven-metadata.xml
 (1.0 kB at 2.9 kB/s)
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/org.apache.sling.launchpad.test-fragment-12-20210226.031833-125.pom
[INFO] Downloaded from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/org.apache.sling.launchpad.test-fragment-12-20210226.031833-125.pom
 (2.9 kB at 8.7 kB/s)
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.integration-tests/12-SNAPSHOT/org.apache.sling.launchpad.integration-tests-12-20210303.061343-255.jar
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-services/12-SNAPSHOT/org.apache.sling.launchpad.test-services-12-20210227.192440-133.jar
[INFO] Downloading from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.launchpad.test-fragment/12-SNAPSHOT/org.apache.sling.launchpad.test-fragment-12-20210226.031833-125.jar
[INFO] Downloaded from Nexus: 
http://repository.apache.org/snapshots/org/apache/sling/or

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nod

2021-03-03 Thread GitBox 


sonarcloud[bot] removed a comment on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-786364570


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_coverage&view=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is no

2021-03-03 Thread GitBox 


sonarcloud[bot] commented on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-789698737


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_coverage&view=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=12&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] commented on pull request #11: SLING-10087 convert more persistenceexceptions

2021-03-03 Thread GitBox 


sonarcloud[bot] commented on pull request #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-789699262


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL)
 [5 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-post] sonarcloud[bot] removed a comment on pull request #11: SLING-10087 convert more persistenceexceptions

2021-03-03 Thread GitBox 


sonarcloud[bot] removed a comment on pull request #11:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/11#issuecomment-785059124


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL)
 [5 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list)
 [0.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-post&pullRequest=11&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] removed a comment on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-03 Thread GitBox 


sonarcloud[bot] removed a comment on pull request #7:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-787221668


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list)
 [70.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-servlets-resolver] sonarcloud[bot] commented on pull request #7: [SLING-9230] - Servlet should not be allowed to register with invalid…

2021-03-03 Thread GitBox 


sonarcloud[bot] commented on pull request #7:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/7#issuecomment-789701754


   SonarCloud Quality Gate failed.
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list)
 [70.0% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-servlets-resolver&pullRequest=7&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] removed a comment on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-03 Thread GitBox 


sonarcloud[bot] removed a comment on pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-787221951


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_coverage&view=list)
 [83.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-scripting-core] sonarcloud[bot] commented on pull request #5: SLING-10147 scripting variables implementation details are exposed to not authorized users

2021-03-03 Thread GitBox 


sonarcloud[bot] commented on pull request #5:
URL: 
https://github.com/apache/sling-org-apache-sling-scripting-core/pull/5#issuecomment-789703132


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_coverage&view=list)
 [83.3% 
Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_coverage&view=list)
  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_duplicated_lines_density&view=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-core&pullRequest=5&metric=new_duplicated_lines_density&view=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: PAX Help

2021-03-03 Thread Oliver Lietz 
On Tuesday, 2 March 2021 21:35:46 CET Eric Norman wrote:
> Hi Oliver,
> 
> Sure I gave it a shot and I stashed the code changes for what I came up
> with at [1] if you wish to review.  Most of the effort was to create a
> simple tool to scan all the possible features and find out what bundles are
> included in each of those and then scan each of those bundles to find out
> what packages/capabilities are provided and match up what was missing with
> the smallest feature that contained those things.
> 
> After building the project from the fork, I launched the feature to confirm
> it starts with this command:
> java -jar
> ~/.m2/repository/org/apache/sling/org.apache.sling.feature.launcher/1.1.16/o
> rg.apache.sling.feature.launcher-1.1.16.jar -f
> target/slingfeature-tmp/feature-it-testing.json
> 
> 1.
> https://github.com/enapps-enorman/sling-org-apache-sling-jcr-maintenance/com
> mit/a713ad93496f5d58a246c84c7207f6e714c79036
> 
> How does that look to you?

I don't get it – where are the requirements for Scripting and CA Config coming 
from?

https://github.com/enapps-enorman/sling-org-apache-sling-jcr-maintenance/blob/
testing/paxexam/src/test/features/starter.ref

Please help me.

O.

> Regards,
> -Eric
> 
> On Tue, Mar 2, 2021 at 3:05 AM Oliver Lietz  wrote:
> > On Tuesday, 2 March 2021 01:04:06 CET Eric Norman wrote:
> > > Hi Oliver,
> > 
> > Hi Eric,
> > 
> > > I'm not sure about how a "feature model" feature would express
> > 
> > dependencies
> > 
> > > on other features or whether that is even necessary.
> > > 
> > > But as an experiment, I just tried to create a simple aggregate feature
> > > that contains just the jcr maintenance feature and nothing else.
> > > 
> > > During the build the analyse-features goal processes that incomplete
> > > aggregate feature and I get a nice report back (see below) about what
> > > packages and capabilities are missing and then I can go look for the
> > > features or bundles that would provide those and add them, and repeat
> > 
> > that
> > 
> > > cycle until there are no errors.  I guess I'm just saying that it is a
> > > nicer error report and fails faster than trying to parse the log files
> > > generated during a paxexam test to figure out why it didn't work.  And
> > 
> > if I
> > 
> > > go through all the work to create a working aggregate feature model it
> > > seems like it would be nice to be able to use that directly in my
> > > paxexam integration tests rather than trying to recreate the same
> > > configuration in java code.
> > > 
> > > For example, the mvn output may look something like this:
> > > =
> > > [INFO] Starting analyzing feature
> > > 'experiment:starter:slingosgifeature:jcr_maintenance:1.0.0-SNAPSHOT'...
> > > [INFO] - Executing APIs jar properties check [apis-jar]...
> > > [INFO] - Executing Bundle Import/Export Check [bundle-packages]...
> > > [INFO] - Executing Repoinit Check [repoinit]...
> > > [INFO] - Executing Requirements Capabilities check
> > > [requirements-capabilities]...
> > > [INFO] Analyzing feature
> > > 'experiment:starter:slingosgifeature:jcr_maintenance:1.0.0-SNAPSHOT'
> > > finished : 0 warnings, 2 errors.
> > > [ERROR] org.apache.sling:org.apache.sling.jcr.maintenance:1.0.0:  is
> > > importing package(s) [org.apache.jackrabbit.oak.api.jmx,
> > > org.apache.jackrabbit.oak.commons.jmx, org.slf4j,
> > 
> > org.apache.felix.hc.api,
> > 
> > > javax.jcr.version, org.apache.sling.api.resource, javax.jcr] in start
> > 
> > level
> > 
> > > 20 but no bundle is exporting these for that start level.
> > > [ERROR] org.apache.sling:org.apache.sling.jcr.maintenance:1.0.0:
> > > Artifact
> > > org.apache.sling:org.apache.sling.jcr.maintenance:1.0.0 requires
> > > [org.apache.sling.jcr.maintenance/1.0.0] osgi.extender;
> > 
> > filter:="(&(osgi.extender=osgi.component)(version>=1.4.0)(!(version>=2.0.0
> > ))> 
> > > )" in start level 20 but no artifact is providing a matching capability
> > 
> > in
> > 
> > > this start level.
> > > [ERROR] Analyser detected errors on feature
> > > 'experiment:starter:slingosgifeature:jcr_maintenance:1.0.0-SNAPSHOT'.
> > > See
> > > log output for error messages.
> > 
> > Can you proceed with this approach, collect all bundles and configurations
> > and
> > let me know how much effort it is in total to have a working Sling
> > instance to
> > test Sling JCR Maintenance? (There are no ITs currently for the module so
> > effort is not wasted.)
> > 
> > Thanks,
> > O.
> > 
> > > Regards,
> > > -Eric
> > > 
> > > On Mon, Mar 1, 2021 at 2:57 PM Oliver Lietz 
> > 
> > wrote:
> > > > On Monday, 1 March 2021 18:51:42 CET Eric Norman wrote:
> > > > > Hi Oliver,
> > > > 
> > > > Hi Eric,
> > > > 
> > > > > The problem I frequently run into is that the default configurations
> > > > > from
> > > > > SlingOptions are almost always providing versions of bundles that
> > > > > are
> > > > > too
> > > > > old to use for testing new features.  And then at that point it
>

[GitHub] [sling-org-apache-sling-models-impl] henrykuijpers commented on pull request #17: SLING-8706 - Injections for java.util.Optional<> should be automatically optional

2021-03-03 Thread GitBox 


henrykuijpers commented on pull request #17:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/17#issuecomment-789796687


   Is anything still needed to merge this in, @justinedelson ?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-models-impl] henrykuijpers commented on pull request #11: SLING-8069: allow non public constructors

2021-03-03 Thread GitBox 


henrykuijpers commented on pull request #11:
URL: 
https://github.com/apache/sling-org-apache-sling-models-impl/pull/11#issuecomment-789797395


   It would be really nice to have this, @justinedelson . Can this be merged 
in? It would prevent our developers from instantiating Sling Models by calling 
the constructor (i.e. in unit tests, but also in production scenarios!) - 
Therefore bypassing the Sling Models injection.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done

2021-03-03 Thread Nicolas Peltier (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-10179:

Fix Version/s: Engine 2.7.6

> it should be made clearer that calling FilterChain.doFilter twice must not be 
> done
> --
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Engine 2.7.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an 
> ArrayIndexOutOfBoundException (timer array based on the number of registered 
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException 
> what he did wrong and i think we should 
> 1. either throw a servlet exception saying "Filter should not been called 
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice, 
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out 
> of 1.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10179) it should be made clearer that calling FilterChain.doFilter twice must not be done

2021-03-03 Thread Nicolas Peltier (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-10179.
-
Resolution: Fixed

> it should be made clearer that calling FilterChain.doFilter twice must not be 
> done
> --
>
> Key: SLING-10179
> URL: https://issues.apache.org/jira/browse/SLING-10179
> Project: Sling
>  Issue Type: Improvement
>  Components: Engine
>Affects Versions: Engine 2.7.4
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Minor
> Fix For: Engine 2.7.6
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Right now, calling FilterChain.doFilter twice will trigger an 
> ArrayIndexOutOfBoundException (timer array based on the number of registered 
> filter handles).
> Such (bad) code can trigger this:
> {Code}
> ...
> filterChain.doFilter(...)
> ...
> if (wrongAssumption()) {
>filterChain.doFilter(...);
> }
> ...
> {Code}
> it's not obvious for the developer from the ArrayIndexOutOfBoundException 
> what he did wrong and i think we should 
> 1. either throw a servlet exception saying "Filter should not been called 
> twice", either log a warning with the stack trace
> 2. document clearly in sling filters that filter should not be called twice, 
> referring to both case (ArrayIndexOufOfBoundException and whatever comes out 
> of 1.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-10181) fix docu example

2021-03-03 Thread Stefan Egli (Jira) 
Stefan Egli created SLING-10181:
---

 Summary: fix docu example
 Key: SLING-10181
 URL: https://issues.apache.org/jira/browse/SLING-10181
 Project: Sling
  Issue Type: Task
  Components: Event
Reporter: Stefan Egli


https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html#jobs-guarantee-of-processing
 mentions

{noformat}
ScheduleBuilder scheduleBuilder = 
jobManager.startJob("my/special/jobtopic").schedule();
{noformat}

but that seems to be from an oldish API and should rather be something like

{noformat}
ScheduleBuilder scheduleBuilder = 
jobManager.createJob("my/special/jobtopic").schedule();
{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10181) fix docu example

2021-03-03 Thread Stefan Egli (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved SLING-10181.
-
  Assignee: Stefan Egli
Resolution: Fixed

fixed

> fix docu example
> 
>
> Key: SLING-10181
> URL: https://issues.apache.org/jira/browse/SLING-10181
> Project: Sling
>  Issue Type: Task
>  Components: Event
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
>
> https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html#jobs-guarantee-of-processing
>  mentions
> {noformat}
> ScheduleBuilder scheduleBuilder = 
> jobManager.startJob("my/special/jobtopic").schedule();
> {noformat}
> but that seems to be from an oldish API and should rather be something like
> {noformat}
> ScheduleBuilder scheduleBuilder = 
> jobManager.createJob("my/special/jobtopic").schedule();
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: PAX Help

2021-03-03 Thread Eric Norman 
Hi Oliver,

I don't get it – where are the requirements for Scripting and CA Config
> coming from?


Ok, let me try to unwind what I was seeing.

The scripting feature got pulled into the set as required because the
"org.apache.sling:org.apache.sling.starter:slingosgifeature:base:12-SNAPSHOT"
feature includes the "org.apache.geronimo.bundles:jstl:1.2_1" and
"org.apache.sling:org.apache.sling.models.impl:1.4.12" bundles which
reported the following errors from the feature-analyzer when the scripting
feature was excluded:

[ERROR] org.apache.geronimo.bundles:jstl:1.2_1:  is importing package(s)
[javax.servlet.jsp.tagext, javax.servlet.jsp, javax.el,
javax.servlet.jsp.el] in start level 20 but no bundle is exporting these
for that start level.
[ERROR] org.apache.sling:org.apache.sling.models.impl:1.4.12:  is importing
package(s) [org.apache.sling.scripting.core,
org.apache.sling.scripting.api] in start level 20 but no bundle is
exporting these for that start level.

And then once the scripting feature is included, then the caconfig gets
pulled in as required because
the "org.apache.sling:org.apache.sling.scripting.jsp.taglib:2.4.0" reported
this error:

[ERROR] org.apache.sling:org.apache.sling.scripting.jsp.taglib:2.4.0:  is
importing package(s) org.apache.sling.caconfig.resource in start level 20
but no bundle is exporting these for that start level.

So, it seems to me that the feature definitions in the starter could use
some further refinement to split them into smaller pieces or move things to
different places.  Also, some bundles may not be properly declaring
optional stuff as optional?

Does that make sense?

Regards,
-Eric

On Wed, Mar 3, 2021 at 7:15 AM Oliver Lietz  wrote:

> On Tuesday, 2 March 2021 21:35:46 CET Eric Norman wrote:
> > Hi Oliver,
> >
> > Sure I gave it a shot and I stashed the code changes for what I came up
> > with at [1] if you wish to review.  Most of the effort was to create a
> > simple tool to scan all the possible features and find out what bundles
> are
> > included in each of those and then scan each of those bundles to find out
> > what packages/capabilities are provided and match up what was missing
> with
> > the smallest feature that contained those things.
> >
> > After building the project from the fork, I launched the feature to
> confirm
> > it starts with this command:
> > java -jar
> >
> ~/.m2/repository/org/apache/sling/org.apache.sling.feature.launcher/1.1.16/o
> > rg.apache.sling.feature.launcher-1.1.16.jar -f
> > target/slingfeature-tmp/feature-it-testing.json
> >
> > 1.
> >
> https://github.com/enapps-enorman/sling-org-apache-sling-jcr-maintenance/com
> > mit/a713ad93496f5d58a246c84c7207f6e714c79036
> >
> > How does that look to you?
>
> I don't get it – where are the requirements for Scripting and CA Config
> coming
> from?
>
>
> https://github.com/enapps-enorman/sling-org-apache-sling-jcr-maintenance/blob/
> testing/paxexam/src/test/features/starter.ref
> 
>
> Please help me.
>
> O.
>
> > Regards,
> > -Eric
> >
> > On Tue, Mar 2, 2021 at 3:05 AM Oliver Lietz 
> wrote:
> > > On Tuesday, 2 March 2021 01:04:06 CET Eric Norman wrote:
> > > > Hi Oliver,
> > >
> > > Hi Eric,
> > >
> > > > I'm not sure about how a "feature model" feature would express
> > >
> > > dependencies
> > >
> > > > on other features or whether that is even necessary.
> > > >
> > > > But as an experiment, I just tried to create a simple aggregate
> feature
> > > > that contains just the jcr maintenance feature and nothing else.
> > > >
> > > > During the build the analyse-features goal processes that incomplete
> > > > aggregate feature and I get a nice report back (see below) about what
> > > > packages and capabilities are missing and then I can go look for the
> > > > features or bundles that would provide those and add them, and repeat
> > >
> > > that
> > >
> > > > cycle until there are no errors.  I guess I'm just saying that it is
> a
> > > > nicer error report and fails faster than trying to parse the log
> files
> > > > generated during a paxexam test to figure out why it didn't work.
> And
> > >
> > > if I
> > >
> > > > go through all the work to create a working aggregate feature model
> it
> > > > seems like it would be nice to be able to use that directly in my
> > > > paxexam integration tests rather than trying to recreate the same
> > > > configuration in java code.
> > > >
> > > > For example, the mvn output may look something like this:
> > > > =
> > > > [INFO] Starting analyzing feature
> > > >
> 'experiment:starter:slingosgifeature:jcr_maintenance:1.0.0-SNAPSHOT'...
> > > > [INFO] - Executing APIs jar properties check [apis-jar]...
> > > > [INFO] - Executing Bundle Import/Export Check [bundle-packages]...
> > > > [INFO] - Executing Repoinit Check [repoinit]...
> > > > [INFO] - Executing Requirements Capabil

[jira] [Created] (SLING-10182) Analyze fails to evaluate when the aggregate feature contains the bundle being built

2021-03-03 Thread Eric Norman (Jira) 
Eric Norman created SLING-10182:
---

 Summary: Analyze fails to evaluate when the aggregate feature 
contains the bundle being built
 Key: SLING-10182
 URL: https://issues.apache.org/jira/browse/SLING-10182
 Project: Sling
  Issue Type: Bug
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: Feature Model Analyser 1.3.24


BundleDescriptorImpl fails to load the manifest if the URL for the bundle 
points at a folder as it assumes the URL passed in points at a jar file.

I noticed this while trying to add an it-testing aggregate feature so a bundle 
could test itself in an integration test.  In this scenario, the URL for the 
local bundle gets passed to the BundleDescriptorImpl as a file URL pointing at 
the target/classes folder and fails the analyze-feature goal with this error:
{noformat}
Caused by: java.io.FileNotFoundException: 
/home/projects/sling-org-apache-sling-jcr-maintenance/target/classes (Is a 
directory)
at java.io.RandomAccessFile.open0 (Native Method)
at java.io.RandomAccessFile.open (RandomAccessFile.java:345)
at java.io.RandomAccessFile. (RandomAccessFile.java:259)
at java.io.RandomAccessFile. (RandomAccessFile.java:214)
at java.util.zip.ZipFile$Source. (ZipFile.java:1285)
at java.util.zip.ZipFile$Source.get (ZipFile.java:1251)
at java.util.zip.ZipFile$CleanableResource. (ZipFile.java:732)
at java.util.zip.ZipFile$CleanableResource.get (ZipFile.java:849)
at java.util.zip.ZipFile. (ZipFile.java:247)
at java.util.zip.ZipFile. (ZipFile.java:177)
at java.util.jar.JarFile. (JarFile.java:348)
at java.util.jar.JarFile. (JarFile.java:319)
at java.util.jar.JarFile. (JarFile.java:285)
at org.apache.sling.feature.io.IOUtils.getJarFileFromURL (IOUtils.java:242)
at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl.getManifest 
(BundleDescriptorImpl.java:75)
at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl. 
(BundleDescriptorImpl.java:83)
at org.apache.sling.feature.scanner.Scanner.doScan (Scanner.java:146)
at org.apache.sling.feature.scanner.Scanner.scanBundle (Scanner.java:117)
at org.apache.sling.feature.scanner.Scanner.getBundleInfos 
(Scanner.java:162)
at org.apache.sling.feature.scanner.Scanner.scan (Scanner.java:227)
at org.apache.sling.feature.analyser.Analyser.analyse (Analyser.java:188)
at org.apache.sling.feature.maven.mojos.AnalyseFeaturesMojo.execute 
(AnalyseFeaturesMojo.java:157)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
{noformat}
Expected that the BundleDescriptorImpl should check if the address is a file 
url pointing at a local directory and try to load the META-INF/MANIFEST.MF 
relative as a file within that directory.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-10182) Analyze fails to evaluate when the aggregate feature contains the bundle being built

2021-03-03 Thread Eric Norman (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-10182.
-
Resolution: Fixed

Fixed at: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/642a14742f1b940ab658979dc4828248d092610b

> Analyze fails to evaluate when the aggregate feature contains the bundle 
> being built
> 
>
> Key: SLING-10182
> URL: https://issues.apache.org/jira/browse/SLING-10182
> Project: Sling
>  Issue Type: Bug
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Feature Model Analyser 1.3.24
>
>
> BundleDescriptorImpl fails to load the manifest if the URL for the bundle 
> points at a folder as it assumes the URL passed in points at a jar file.
> I noticed this while trying to add an it-testing aggregate feature so a 
> bundle could test itself in an integration test.  In this scenario, the URL 
> for the local bundle gets passed to the BundleDescriptorImpl as a file URL 
> pointing at the target/classes folder and fails the analyze-feature goal with 
> this error:
> {noformat}
> Caused by: java.io.FileNotFoundException: 
> /home/projects/sling-org-apache-sling-jcr-maintenance/target/classes (Is a 
> directory)
> at java.io.RandomAccessFile.open0 (Native Method)
> at java.io.RandomAccessFile.open (RandomAccessFile.java:345)
> at java.io.RandomAccessFile. (RandomAccessFile.java:259)
> at java.io.RandomAccessFile. (RandomAccessFile.java:214)
> at java.util.zip.ZipFile$Source. (ZipFile.java:1285)
> at java.util.zip.ZipFile$Source.get (ZipFile.java:1251)
> at java.util.zip.ZipFile$CleanableResource. (ZipFile.java:732)
> at java.util.zip.ZipFile$CleanableResource.get (ZipFile.java:849)
> at java.util.zip.ZipFile. (ZipFile.java:247)
> at java.util.zip.ZipFile. (ZipFile.java:177)
> at java.util.jar.JarFile. (JarFile.java:348)
> at java.util.jar.JarFile. (JarFile.java:319)
> at java.util.jar.JarFile. (JarFile.java:285)
> at org.apache.sling.feature.io.IOUtils.getJarFileFromURL 
> (IOUtils.java:242)
> at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl.getManifest 
> (BundleDescriptorImpl.java:75)
> at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl. 
> (BundleDescriptorImpl.java:83)
> at org.apache.sling.feature.scanner.Scanner.doScan (Scanner.java:146)
> at org.apache.sling.feature.scanner.Scanner.scanBundle (Scanner.java:117)
> at org.apache.sling.feature.scanner.Scanner.getBundleInfos 
> (Scanner.java:162)
> at org.apache.sling.feature.scanner.Scanner.scan (Scanner.java:227)
> at org.apache.sling.feature.analyser.Analyser.analyse (Analyser.java:188)
> at org.apache.sling.feature.maven.mojos.AnalyseFeaturesMojo.execute 
> (AnalyseFeaturesMojo.java:157)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> {noformat}
> Expected that the BundleDescriptorImpl should check if the address is a file 
> url pointing at a local directory and try to load the META-INF/MANIFEST.MF 
> relative as a file within that directory.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-10182) Analyze fails to evaluate when the aggregate feature contains the bundle being built

2021-03-03 Thread Eric Norman (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-10182:

Description: 
BundleDescriptorImpl fails to load the manifest if the URL for the bundle 
points at a folder as it assumes the URL passed in points at a jar file.

I noticed this while trying to add an it-testing aggregate feature so a bundle 
could test itself in an integration test.  In this scenario, the URL for the 
local bundle gets passed to the BundleDescriptorImpl as a file URL pointing at 
the target/classes folder and fails the analyze-feature goal with this error:
{noformat}
Caused by: java.io.FileNotFoundException: 
/home/projects/sling-org-apache-sling-jcr-maintenance/target/classes (Is a 
directory)
at java.io.RandomAccessFile.open0 (Native Method)
at java.io.RandomAccessFile.open (RandomAccessFile.java:345)
at java.io.RandomAccessFile. (RandomAccessFile.java:259)
at java.io.RandomAccessFile. (RandomAccessFile.java:214)
at java.util.zip.ZipFile$Source. (ZipFile.java:1285)
at java.util.zip.ZipFile$Source.get (ZipFile.java:1251)
at java.util.zip.ZipFile$CleanableResource. (ZipFile.java:732)
at java.util.zip.ZipFile$CleanableResource.get (ZipFile.java:849)
at java.util.zip.ZipFile. (ZipFile.java:247)
at java.util.zip.ZipFile. (ZipFile.java:177)
at java.util.jar.JarFile. (JarFile.java:348)
at java.util.jar.JarFile. (JarFile.java:319)
at java.util.jar.JarFile. (JarFile.java:285)
at org.apache.sling.feature.io.IOUtils.getJarFileFromURL (IOUtils.java:242)
at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl.getManifest 
(BundleDescriptorImpl.java:75)
at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl. 
(BundleDescriptorImpl.java:83)
at org.apache.sling.feature.scanner.Scanner.doScan (Scanner.java:146)
at org.apache.sling.feature.scanner.Scanner.scanBundle (Scanner.java:117)
at org.apache.sling.feature.scanner.Scanner.getBundleInfos 
(Scanner.java:162)
at org.apache.sling.feature.scanner.Scanner.scan (Scanner.java:227)
at org.apache.sling.feature.analyser.Analyser.analyse (Analyser.java:188)
at org.apache.sling.feature.maven.mojos.AnalyseFeaturesMojo.execute 
(AnalyseFeaturesMojo.java:157)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
{noformat}
Expected that the BundleDescriptorImpl should check if the address is a file 
url pointing at a local directory and try to load the META-INF/MANIFEST.MF  as 
a file within that directory.

 

  was:
BundleDescriptorImpl fails to load the manifest if the URL for the bundle 
points at a folder as it assumes the URL passed in points at a jar file.

I noticed this while trying to add an it-testing aggregate feature so a bundle 
could test itself in an integration test.  In this scenario, the URL for the 
local bundle gets passed to the BundleDescriptorImpl as a file URL pointing at 
the target/classes folder and fails the analyze-feature goal with this error:
{noformat}
Caused by: java.io.FileNotFoundException: 
/home/projects/sling-org-apache-sling-jcr-maintenance/target/classes (Is a 
directory)
at java.io.RandomAccessFile.open0 (Native Method)
at java.io.RandomAccessFile.open (RandomAccessFile.java:345)
at java.io.RandomAccessFile. (RandomAccessFile.java:259)
at java.io.RandomAccessFile. (RandomAccessFile.java:214)
at java.util.zip.ZipFile$Source. (ZipFile.java:1285)
at java.util.zip.ZipFile$Source.get (ZipFile.java:1251)
at java.util.zip.ZipFile$CleanableResource. (ZipFile.java:732)
at java.util.zip.ZipFile$CleanableResource.get (ZipFile.java:849)
at java.util.zip.ZipFile. (ZipFile.java:247)
at java.util.zip.ZipFile. (ZipFile.java:177)
at java.util.jar.JarFile. (JarFile.java:348)
at java.util.jar.JarFile. (JarFile.java:319)
at java.util.jar.JarFile. (JarFile.java:285)
at org.apache.sling.feature.io.IOUtils.getJarFileFromURL (IOUtils.java:242)
at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl.getManifest 
(BundleDescriptorImpl.java:75)
at org.apache.sling.feature.scanner.impl.BundleDescriptorImpl. 
(BundleDescriptorImpl.java:83)
at org.apache.sling.feature.scanner.Scanner.doScan (Scanner.java:146)
at org.apache.sling.feature.scanner.Scanner.scanBundle (Scanner.java:117)
at org.apache.sling.feature.scanner.Scanner.getBundleInfos

[GitHub] [sling-org-apache-sling-servlets-post] joerghoh commented on pull request #12: SLING-10169: Enabling servlet.post.autoCheckout breaks POST requests when one of the ancestor nodes is not acces

2021-03-03 Thread GitBox 


joerghoh commented on pull request #12:
URL: 
https://github.com/apache/sling-org-apache-sling-servlets-post/pull/12#issuecomment-790023513


   makes sense from my point of view.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: PAX Help

2021-03-03 Thread Oliver Lietz 
On Wednesday, 3 March 2021 19:17:01 CET Eric Norman wrote:
> Hi Oliver,
> 
> I don't get it – where are the requirements for Scripting and CA Config
> 
> > coming from?
> 
> Ok, let me try to unwind what I was seeing.
> 
> The scripting feature got pulled into the set as required because the
> "org.apache.sling:org.apache.sling.starter:slingosgifeature:base:12-SNAPSHOT
> " feature includes the "org.apache.geronimo.bundles:jstl:1.2_1" and
> "org.apache.sling:org.apache.sling.models.impl:1.4.12" bundles which
> reported the following errors from the feature-analyzer when the scripting
> feature was excluded:
> 
> [ERROR] org.apache.geronimo.bundles:jstl:1.2_1:  is importing package(s)
> [javax.servlet.jsp.tagext, javax.servlet.jsp, javax.el,
> javax.servlet.jsp.el] in start level 20 but no bundle is exporting these
> for that start level.
> [ERROR] org.apache.sling:org.apache.sling.models.impl:1.4.12:  is importing
> package(s) [org.apache.sling.scripting.core,
> org.apache.sling.scripting.api] in start level 20 but no bundle is
> exporting these for that start level.
> 
> And then once the scripting feature is included, then the caconfig gets
> pulled in as required because
> the "org.apache.sling:org.apache.sling.scripting.jsp.taglib:2.4.0" reported
> this error:
> 
> [ERROR] org.apache.sling:org.apache.sling.scripting.jsp.taglib:2.4.0:  is
> importing package(s) org.apache.sling.caconfig.resource in start level 20
> but no bundle is exporting these for that start level.
> 
> So, it seems to me that the feature definitions in the starter could use
> some further refinement to split them into smaller pieces or move things to
> different places.  Also, some bundles may not be properly declaring
> optional stuff as optional?
> 
> Does that make sense?

Absolutely! But for me this means also the features in Starter are far away 
from being useful as source for Exam Options. For now I will stick to Sling's 
Karaf Features and release Testing PaxExam hopefully with latest releases 
soon.

Thanks!
O.


> Regards,
> -Eric
> 
> On Wed, Mar 3, 2021 at 7:15 AM Oliver Lietz  wrote:
> > On Tuesday, 2 March 2021 21:35:46 CET Eric Norman wrote:
> > > Hi Oliver,
> > > 
> > > Sure I gave it a shot and I stashed the code changes for what I came up
> > > with at [1] if you wish to review.  Most of the effort was to create a
> > > simple tool to scan all the possible features and find out what bundles
> > 
> > are
> > 
> > > included in each of those and then scan each of those bundles to find
> > > out
> > > what packages/capabilities are provided and match up what was missing
> > 
> > with
> > 
> > > the smallest feature that contained those things.
> > > 
> > > After building the project from the fork, I launched the feature to
> > 
> > confirm
> > 
> > > it starts with this command:
> > > java -jar
> > 
> > ~/.m2/repository/org/apache/sling/org.apache.sling.feature.launcher/1.1.16
> > /o> 
> > > rg.apache.sling.feature.launcher-1.1.16.jar -f
> > > target/slingfeature-tmp/feature-it-testing.json
> > > 
> > > 1.
> > 
> > https://github.com/enapps-enorman/sling-org-apache-sling-jcr-maintenance/c
> > om> 
> > > mit/a713ad93496f5d58a246c84c7207f6e714c79036
> > > 
> > > How does that look to you?
> > 
> > I don't get it – where are the requirements for Scripting and CA Config
> > coming
> > from?
> > 
> > 
> > https://github.com/enapps-enorman/sling-org-apache-sling-jcr-maintenance/b
> > lob/ testing/paxexam/src/test/features/starter.ref
> >  > blob/testing/paxexam/src/test/features/starter.ref>
> > 
> > Please help me.
> > 
> > O.
> > 
> > > Regards,
> > > -Eric
> > > 
> > > On Tue, Mar 2, 2021 at 3:05 AM Oliver Lietz 
> > 
> > wrote:
> > > > On Tuesday, 2 March 2021 01:04:06 CET Eric Norman wrote:
> > > > > Hi Oliver,
> > > > 
> > > > Hi Eric,
> > > > 
> > > > > I'm not sure about how a "feature model" feature would express
> > > > 
> > > > dependencies
> > > > 
> > > > > on other features or whether that is even necessary.
> > > > > 
> > > > > But as an experiment, I just tried to create a simple aggregate
> > 
> > feature
> > 
> > > > > that contains just the jcr maintenance feature and nothing else.
> > > > > 
> > > > > During the build the analyse-features goal processes that incomplete
> > > > > aggregate feature and I get a nice report back (see below) about
> > > > > what
> > > > > packages and capabilities are missing and then I can go look for the
> > > > > features or bundles that would provide those and add them, and
> > > > > repeat
> > > > 
> > > > that
> > > > 
> > > > > cycle until there are no errors.  I guess I'm just saying that it is
> > 
> > a
> > 
> > > > > nicer error report and fails faster than trying to parse the log
> > 
> > files
> > 
> > > > > generated during a paxexam test to figure out why it didn't work.
> > 
> > And
> > 
> > > > if I
> > > > 
> > > > > go through all the work to create a working aggregate feature model

[jira] [Reopened] (SLING-9999) Remove cyclic dependency between scripting and servlets features

2021-03-03 Thread Oliver Lietz (Jira) 


 [ 
https://issues.apache.org/jira/browse/SLING-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reopened SLING-:
-

[~radu], Please move {{ResourceType}} into {{o.a.s.api.resource.type}} (see 
reasons above). You changed the package version to {{1.0.0}}. Moving (removing) 
{{ResourceType}} later would be a breaking change and unnecessary trouble for 
all consumers.

> Remove cyclic dependency between scripting and servlets features
> 
>
> Key: SLING-
> URL: https://issues.apache.org/jira/browse/SLING-
> Project: Sling
>  Issue Type: Improvement
>  Components: API, Karaf, Scripting, Servlets, Starter
>Reporter: Oliver Lietz
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting Bundle Maven Plugin 0.2.4, Scripting Core 
> 2.3.6, Servlets Resolver 2.7.14, Scripting JSP 2.5.2, Scripting HTL Engine 
> 1.4.8-1.4.0, Scripting SPI 1.0.0
>
>
> Before {{org.apache.sling.scripting.core.impl.bundled}} and 
> {{org.apache.sling.servlets.resolver.bundle}} were added the dependency 
> chains were e.g.
> {{sling-servlets}} → {{sling-scripting}} → {{sling}}
> {{sling-scripting-jsp}} → {{sling-scripting}} → {{sling}}
> Currently several _scripting_ modules depend on 
> {{org.apache.sling.servlets.resolver.bundle.tracker}}.
> h2. Move _Bundle_ API to Scripting and Resource packages (modules)
> ||Actual Package (Module)||Target Package (Module)||
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnit}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.spi.bundle.BundledRenderUnit}}*
>  ({{org.apache.sling.scripting.spi}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker. 
> BundledRenderUnitCapability}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.spi.bundle.BundledRenderUnitCapability}}*
>  ({{org.apache.sling.scripting.spi}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.BundledRenderUnitFinder}}*
>  
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.spi.bundle.BundledRenderUnitFinder}}*
>  ({{org.apache.sling.scripting.api}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.ResourceType}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.spi.bundle.ResourceType}}*
>  ({{org.apache.sling.scripting.spi}})|
> |*{{org.apache.sling.servlets.resolver.bundle.tracker.TypeProvider}}* 
> ({{org.apache.sling.servlets.resolver}})|*{{org.apache.sling.scripting.spi.bundle.TypeProvider}}*
>  ({{org.apache.sling.scripting.spi}})|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-feature-inventoryprinter] stbischof opened a new pull request #3: fix url to felix-dev

2021-03-03 Thread GitBox 


stbischof opened a new pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/pull/3


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [sling-org-apache-sling-feature-inventoryprinter] sonarcloud[bot] commented on pull request #3: fix url to felix-dev

2021-03-03 Thread GitBox 


sonarcloud[bot] commented on pull request #3:
URL: 
https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/pull/3#issuecomment-790353565


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&resolved=false&types=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&metric=coverage&view=list)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-inventoryprinter&pullRequest=3&metric=duplicated_lines_density&view=list)
 No Duplication information
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (SLING-10183) Contrebution

2021-03-03 Thread Stefan Bischof (Jira) 
Stefan Bischof created SLING-10183:
--

 Summary: Contrebution
 Key: SLING-10183
 URL: https://issues.apache.org/jira/browse/SLING-10183
 Project: Sling
  Issue Type: Task
Reporter: Stefan Bischof


Hello,

what is the best way to notify you about PR on Github?

Is to create a PR enough, or should i also create an issue in jira?

[https://github.com/apache/sling-org-apache-sling-feature-inventoryprinter/pull/3]
[https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/16]
[https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/17]
[https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/18]


regards
Stefan Bischof



--
This message was sent by Atlassian Jira
(v8.3.4#803005)